From nobody Thu Dec 18 05:20:30 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83986198823 for ; Tue, 18 Mar 2025 05:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742276198; cv=none; b=Qiqlt+MzykTGntExyjvBsm0YGGL5zGD+VgfcYI+SOQlzgSqi6p/M4hnItKhFrOn1hSW+WxwlTVmAe/mDV9LlRlseuelgiQue4h7g/kHDQuVkKms4ktKXIL3aYwSN7+wqtYH/QLQprBSa3SHzhHCr8/4r9e5pipi0/8G1kuJCAaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742276198; c=relaxed/simple; bh=QIF4KUSFHzWAgGYaR66ayatH3tkKk6gzz62eiEOD8nY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=f2Ss4be2TmVLJD8D6cSJatB5BgNfrvcfBRjWH2mo7shPy//YNrZczShb5BU2K5hlURTReookZNNdD2dSSMBVs4RKDfJVbjKbydj5TNIutaOzUR/Is3d5tDAUxfiHsN1gvahItH67EhlZAkrI+SgcOWL4tsfIHuhN5Anw6aZ4o/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dvWx5BAz; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dvWx5BAz" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-224100e9a5cso99471375ad.2 for ; Mon, 17 Mar 2025 22:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742276197; x=1742880997; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JAXz5zFV/dNZck8AAhHpDywdjolmlMduTc9D2SMrXCY=; b=dvWx5BAzlV3/+UKXRlknjw1qGgTAIqy/fyW109+YbDh7soTSoi7twqNDutmH9Opg61 rYqoq0Oobx5UNm1gQmBjBBOuYuuiBGYZxaRFhyugyi4GR+HZ/LKwiqBmnZHr7b2XqgRM +TqAssJQvFoz2qjN4fsbhc482nRRoOVu0aJtWciYdGi0vcYa8Enh4Yj4fQMy7ykvoEmO 908TpXQji7LTkpvJfb4Egg/Sh0/VeuBB5OpcZPMWnlfun9OSlbbjRucIhOL0keS4yyV9 MrxMAJ98LBUDVCVzhpzqJZeYhcpr4XagiDB8VhnhseW7T/igl9968plm3y3RMJTRp3PR zNrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742276197; x=1742880997; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JAXz5zFV/dNZck8AAhHpDywdjolmlMduTc9D2SMrXCY=; b=Rfo4j5o3gidPP9r9/q6lqCmTC7C0BeKrF6o4fWEjG59UnoA2jyCorj2+qgDLOcZgeo /LmXSce0+GAjb0/o2P3l4vu2nH0Nj/+fYf0WrzLCqyedqOGpe/WyVx+IP5syPPLLegWk 2NK1BFeWsF4Fq9Qq+fG5Gb8Dah2Eb0PWcojtRzX9JinPan0hZS3jdTsl3cNFkBUQcIiT iMKOlWuEtWxc+R+g0gkgJl1rOZEvzhwQzAhYogNunxKvNuGxPdDuf2QHEcZnuXvHLt0c UqRkHEqjtZS1BykpT7RJ1eTLjpWaETDKbsQ1KT/vNW6Wb7Atk3rAhBxHLyzwEBNF8gGh zg+w== X-Gm-Message-State: AOJu0YxiQUp+xj2HEnlbFo1yYgN4A2Cshzg2Ni/KZX6NaF7OayX7CrLW 6FfYgISd66mK/dLQ3kQtZ9qLEkUI/SWyLUH5Gj0a60dEag78o/Xs X-Gm-Gg: ASbGncsL/r6SRADS50kM02Fn4UAv4YMTg39rc7W95M4GiPQIzmF7EV0Zs2uWp++pa81 GsjRa3l93Q48Wca50nOzUA2lY5XlJ1AGaVeMdl331s4/rG4psm/ckNOrE/fFMDyv7qoJRROVXKs ay0sIwFecoF1ueVjV2da/uWjki+tLJDPNmnsAjAts4RdT+EjkjpWGvjY6mmTPfA2wdyO6AjzJSY pLh1LyzNqRArfR2gt/8ZZ+sQwOB3gSN6At0SY88sCrYNC+y863d6G4Vev7HndWIA6OohrP13DlQ Gv0MzmJNll41OcjLYe/mrtk5sOf9Kv5Ln+AKxy0l5fW6xWfkd972OFA= X-Google-Smtp-Source: AGHT+IH8K71L41KaQuidRb124ubL5NH0GzYCl4FWRdtxSZGd+wGA+J5yLIlXt4vfeFTUswsRyFIAtg== X-Received: by 2002:a17:902:ce8d:b0:224:721:ed9 with SMTP id d9443c01a7336-225e0b118ebmr195585385ad.44.1742276196636; Mon, 17 Mar 2025 22:36:36 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:dc02:2d2e:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba6f09sm85299905ad.133.2025.03.17.22.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 22:36:36 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v2 1/3] i3c: master: svc: Fix missing the IBI rules Date: Tue, 18 Mar 2025 13:36:04 +0800 Message-Id: <20250318053606.3087121-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250318053606.3087121-1-yschu@nuvoton.com> References: <20250318053606.3087121-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu The code does not add IBI rules for devices with controller capability. However, the secondary controller has the controller capability and works at target mode when the device is probed. Therefore, add IBI rules for such devices. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 1d1f351b9a85..a72ba5a7edd4 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1106,7 +1106,7 @@ static int svc_i3c_update_ibirules(struct svc_i3c_mas= ter *master) =20 /* Create the IBIRULES register for both cases */ i3c_bus_for_each_i3cdev(&master->base.bus, dev) { - if (I3C_BCR_DEVICE_ROLE(dev->info.bcr) =3D=3D I3C_BCR_I3C_MASTER) + if (!(dev->info.bcr & I3C_BCR_IBI_REQ_CAP)) continue; =20 if (dev->info.bcr & I3C_BCR_IBI_PAYLOAD) { --=20 2.34.1 From nobody Thu Dec 18 05:20:30 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6958C1CD214 for ; Tue, 18 Mar 2025 05:36:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742276214; cv=none; b=Saec2aGbzqJ5wL89ra1EYH0lgKdDbaPsZDh5spABgzZoRAERYyXbGr6zFGE9oUvL3f0VCakoai79UhJQeHy8cdCYqvSOd/hJh2MeHR/aZVtqX9qkbhQIxOBrMHDZ5IuJ7iVasPFYzaCj1gLBWvfTzyyTYmBx9YKobm3Y78219j0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742276214; c=relaxed/simple; bh=2LA+Y8RVFhP75zD1DZGhcUh4uKDs+UbDTmTf+Wc1f5g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mrcEUd+AJuOQ9Ec20gmVcUBdwk265Vs9O67D3O6uxHRqv2udo6mr9z6i4Iik0QQaSMUQb7hx2ZrNaIKiD37Xy69XoKTEOLPhkhQ6y2CjF8AqFqCsrc1YiUYP3UFbfqvIIfPQKI/5SU42fImuznowWeIsTiYp96SS9DqcFz7y2Dg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QMsoR/SP; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QMsoR/SP" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-225a28a511eso86561425ad.1 for ; Mon, 17 Mar 2025 22:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742276212; x=1742881012; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0rhPbDd0rp/+eHjWfo/oyKCU6wF9P8ggGmtlZyVMevo=; b=QMsoR/SPkdmOeuOlkWQA37men82uRH++JogTkwFvc3Zv+28R0HcoCY0DZZNJvTQxCL W/IBiDXcVJ6tN/oXi+cFSrVw2lZlBwW9lHH1xv/eHP9GRQxDdOedeQjFuyfEu5of9lny 85u6+JCJVEqgaBcr081prMkJwL9tNidny+fu+dhieEwM13pry2EBq2E1gHvDW5BPbsiV lohyOfDUyzNRz88uyEgGZZf4ztuN9SJakHikQFopmNana6svv95zcLyUXhccmLBIS5pO 86Lrtbp1Nw+B8SFxQzPC8D/7WINXMwQ+5+01WRtVr+gqeghsX2K6tq6BWkQusUuU5mp7 Db0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742276212; x=1742881012; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0rhPbDd0rp/+eHjWfo/oyKCU6wF9P8ggGmtlZyVMevo=; b=OjBXIxlPt318ElT1ligW4pfq8li01ml6APFXVYpYz/tlaV4i81eY2YByy222eWzAuO QJKs4e5JsN2PnCAb0cmUmsM50bYtpeenf3xWpOf6vjj8Fkq4tcFV2Gj/VIZKh//+aYUo nFL5H82ev9hJ8A3wGODJJEyPcEMc41c9IHAVKZArwedEIBPreGykuzf/VrgAM6FJrWXu J3dxs1k1uGuOYiP7D7ZV4QaDzV1cagXyuBWQTFXEhGcudvAM6YoEjt7Pqis+eFHZYzb9 gc4YZyvXglj1MrnSoZZTTpVmFnVLWEmo/dg366LXEq8f4/y4IvvmTtR0aSHNQxdZPTlC QSSg== X-Gm-Message-State: AOJu0YwR3an8aYZ6uvSq60Nx0fG1eX0QbTlovpmcKQOA7+Sxk9MSW3e6 7FMvzd0kj+FvyFpI7TF2u+wT7u5JV6P3A2pbMZrnTbpn7HLev+XJvXzUHkvN X-Gm-Gg: ASbGncsGABFVK9HC9QiADQRNJbyzE6CijCvNnpV1F19ly//iHKEG0fj2PHeHOn0CAm4 QFlQ3wonOdtQGLeCQu5a0hU6dApzAUACYlv7P9su/w2Prp1cmQnxJ9Xu71UO/lEzcJaFO6JN86T R9Vx2Gz0nkvrfjgc+0lwGTu3LGrMMPQ5UmhNq0AdZCAWlDlSAYQe3jfRnvwjPUrP/PJfbi+KUNH sajI2JOqN01oZrKdPyVttIhjEe5a56WMBAl4Ax7JE+K7KEI1pH0Gve7vfXiPj4Cqc0EpqG3RAg9 jSZ8/pF1BwCx7vSif/hUcCZPNwhFr4uFTd6ZVJXUWK8/nPh0AGAHAkYj8fYm8HvlzA== X-Google-Smtp-Source: AGHT+IEQ5Xvf+rbEz83j21PmQVZJa1tTQ+KrF/RyhHQ1rBe5bD51Nx04dUVCxZ5zSSVIrBohADEJzg== X-Received: by 2002:a17:902:ef48:b0:221:85:f384 with SMTP id d9443c01a7336-225e0a3fbc1mr197525795ad.16.1742276212613; Mon, 17 Mar 2025 22:36:52 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:dc02:2d2e:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba6f09sm85299905ad.133.2025.03.17.22.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 22:36:52 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, stable@kernel.org Subject: [PATCH v2 2/3] i3c: master: svc: Use readsb helper for reading MDB Date: Tue, 18 Mar 2025 13:36:05 +0800 Message-Id: <20250318053606.3087121-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250318053606.3087121-1-yschu@nuvoton.com> References: <20250318053606.3087121-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu The target can send the MDB byte followed by additional data bytes. The readl on MRDATAB reads one actual byte, but the readsl advances the destination pointer by 4 bytes. This causes the subsequent payload to be copied to wrong position in the destination buffer. Cc: stable@kernel.org Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index a72ba5a7edd4..57b9dec6b5a8 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -425,7 +425,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_mas= ter *master, slot->len < SVC_I3C_FIFO_SIZE) { mdatactrl =3D readl(master->regs + SVC_I3C_MDATACTRL); count =3D SVC_I3C_MDATACTRL_RXCOUNT(mdatactrl); - readsl(master->regs + SVC_I3C_MRDATAB, buf, count); + readsb(master->regs + SVC_I3C_MRDATAB, buf, count); slot->len +=3D count; buf +=3D count; } --=20 2.34.1 From nobody Thu Dec 18 05:20:30 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6D8B1A5BAD for ; Tue, 18 Mar 2025 05:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742276220; cv=none; b=VW+KihOaCEXeFTUR8kfechY71neq4nvRURHYnwaHNqSIpkgtyRLR2fwO3LrKl7bgUtTLhpEso+OQ0ZAXH0WeznTPN4Cpph/Hryqll6x6D05Qc+3U9t1PNWHkhPi5Z1/NyxH3FW3ilebd8OgXzFmSiF7qx2QuEFXj2YqBnVGpS3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742276220; c=relaxed/simple; bh=3SkWDJ1KeIVjC5cH9fvKRmhISc9NcxbCKIhvLQW49cI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JvjEXcGh1Vc3akbCD6n59uPqRKLcpaf8FlLHL+HPQ2FmBuTJjQUNDkdU6ZPwqKRRcC/n3zI/HNteeSUnC5OM1wiShHUjEmYXPHPzIKauV7/DDc1v+79JSe56UE+31fQNuhUOtrDuPPtk4MglgHw0QcwEbo91bIvFBeDMhNZ3rjQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZgvRwBMJ; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZgvRwBMJ" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-223fd89d036so102896215ad.1 for ; Mon, 17 Mar 2025 22:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742276218; x=1742881018; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t2l70gmWLq1u+RsRNabUWN7Xz1zqqPiMQOA3ywbVZDU=; b=ZgvRwBMJiecYRj33stNjSTPWj/wlB/n/GWhE/S8bLCjMzSKg4aEgnrD8qepBYxY/rH GhWNMV/oCTMW1v50HAXHoQ0nXZ7ajNZ7aEBFlzo858l6SxS/5wEKdyZub59X7z90BCS/ UtbpOYbPukyA5EBh5Erx/Hh0tTPTOB9sDjjyeIBwwt+gO+aG4v1aMSSFr3w7dYDgDP9C 8dS1GK74sb3X0CpRNRWfVGpfGg8WNaQcVZFoTmVHSOH4EcjGmE34HdRIkN+hlMYkSGIH d1GBQ985DnSXDS0dQmFbQe5lB3Ne41Pib2znZoQgUZwqrz/XjyeiwPZNkknwFJW5VZcn ZkoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742276218; x=1742881018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t2l70gmWLq1u+RsRNabUWN7Xz1zqqPiMQOA3ywbVZDU=; b=DHz0ATLZu0dGfi4G9e6oOtmnMd+WA+ZsnndA/i5KArJoRjn3yf4ki79EOCD/jqLac1 fmEfrHLkzJ7j6WkrumpBwokg0mWz88lV8mFb0qK4lVfZpF3YD8zRzfJ/cl846zTCDU/F uGESwr5qR74fs6t0oRqEURPd40T9KEoG5y8GGV+tWTO3T7Ogshf5I5BPG7Yc67XvaykB ubAsVoVvcjvvHBOb82xHHx3K+u44u4AuOXFwS8oku+goKfhIkac59DEJm3uKC06sCyb4 /okzfbFoTTXRk2XZ2R6HwioRzQtjMiQ6YC/5Arq0/puE6AlSnQ5+uSXVr8/ooZwfFbQ0 bc1Q== X-Gm-Message-State: AOJu0YwTxOk4oIK6Q+WPcaBj5vZKbpaNB09s/LrI+tWGLqyn8jyaAmGQ 796nlhBvPer7gmtCGMBDXoIr0g+r3Iabpz5l0PRQTW0DYXFm6gE/ X-Gm-Gg: ASbGncsPo2tWUMALc0zuD0oCrXnfsqmlzp4+TZw6mN5JRvibfJfCMM2NIK9K6x61VNs UxXw6RajuYHcdT8dfkzpjyio3JE+WJKA7hkQPNOErmJpROQTQc28TOC2nW/N4PoxO/0mKBZncvG btqvhSc13Wc0pobFe81mjKYBkqYDuK3Y5vDfbPrrNk2VjD/HSaN7PN/9sI3oO3w7zAPYUwhSGIx CENZrTT5sLf6Z1Vcc/smHklU/cgFcqKWQbshXdoyTiSDCFyRGUOh2IAvirXNiUOmIqBvvpXlq5P 1lDsonauJiHTxA3cYW6S1JKvuN8rQkJHyH8JU5Q//ceRMAWlkEgLalk= X-Google-Smtp-Source: AGHT+IHh61jHEle2cIzLwjfMURMV6oyMDvmV3DsO5QwJwWAe5RRi+4NcIIvl2m8zXZrzfh21OGTCZA== X-Received: by 2002:a17:902:e545:b0:224:2384:5b40 with SMTP id d9443c01a7336-225e0aa0c3fmr202843365ad.24.1742276217919; Mon, 17 Mar 2025 22:36:57 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:dc02:2d2e:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba6f09sm85299905ad.133.2025.03.17.22.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 22:36:57 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v2 3/3] i3c: master: svc: Fix missing STOP for master request Date: Tue, 18 Mar 2025 13:36:06 +0800 Message-Id: <20250318053606.3087121-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250318053606.3087121-1-yschu@nuvoton.com> References: <20250318053606.3087121-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu The controller driver nacked the master request but didn't emit a STOP to end the transaction. The driver shall refuse the unsupported requests and return the controller state to IDLE by emitting a STOP. Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 57b9dec6b5a8..e0cd3ce28b7f 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -592,6 +592,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) queue_work(master->base.wq, &master->hj_work); break; case SVC_I3C_MSTATUS_IBITYPE_MASTER_REQUEST: + svc_i3c_master_emit_stop(master); default: break; } --=20 2.34.1