From nobody Wed Dec 17 13:56:50 2025 Received: from mail-oa1-f73.google.com (mail-oa1-f73.google.com [209.85.160.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADE271B414B for ; Tue, 18 Mar 2025 04:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742271295; cv=none; b=lcP0RNJof0il3BuBeQqMQWYof8wfN3qyAv5/BqA+o2vLwLOQR0Q/nRrCUZ1PCRgYVyT4Vfm+ucwSVldzkLZiC/8a+wVDoK+fNQeIC9JDaA0nCd1H/5Z8575ri0e54J1qVRexwtpLYcl0ZQU08K265Oz05helWGYcVvp+6q7ytBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742271295; c=relaxed/simple; bh=1ifexhJwUBdmaJDGG25z0IZv2DVc0saV1QH/eEcKA84=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=aU4UPh89UE2NFEfvXMClEmiK+ii8Kh0KP8R4Kj2yq/lNz2uvKHhLvTN+I9gUrpgjAdtqeGMs86FFfu9DlbQAbRNLvNNBLj2uUWwuKMstAibM+zzITfDWu/ch+zayu/ofx52B0lmbtcaV7/TBaYxW9amAwbnq4zijhvb9tI3Dp2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=4JR+e9V/; arc=none smtp.client-ip=209.85.160.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="4JR+e9V/" Received: by mail-oa1-f73.google.com with SMTP id 586e51a60fabf-2c2bd2872c4so1568284fac.3 for ; Mon, 17 Mar 2025 21:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742271293; x=1742876093; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=uZBuQKhM+u9c6pepP6gqKhQVXCUikQqb1UN6fdxC8pQ=; b=4JR+e9V/qRzkfnJ4Y+QPNMkwOW1fYuFejr9KA6DQeZY4LCrMLKhOaq/V2LW6Op31CV B6im6/SaCdRdw311hbnkxYchEAXvR1a3QFkeVdJED4RspaMCAV4BCx2RY6sJdP86lI43 jrV5t4QXRHCd5UchmWBJDMRuvKKoowyLGCy2Q0uNw0y9vp6fhXgYIfHxzRr7PtJ/um3s Xkld9lsd0tuPUC2voV4Dg+L4b6k7B9qa7N6AX665vU1QCm6+3PGrpbNv7429Pm9KkZdJ Mf1S0oYZR2Z4RSbMOHj1/apaTKHz1XeiPLwjFU8VQiIZtcyyRjQjNj3JmU7EFUnsioH6 tHdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742271293; x=1742876093; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uZBuQKhM+u9c6pepP6gqKhQVXCUikQqb1UN6fdxC8pQ=; b=HmDgykNx0p5zTbMW9PsUYf1A13/FvMcKIYRO5xSK+X2S1TbUTn2MCdrVYoodsPoVPB Wu7ms4HZy4NBNrgzj0Ye2No0IH+TrWHEZYfg9sdV/G0ZYAAKfSP8kp1m+dbwI3iwSkfc GaVr6a+QOWGgu8WZBa3kW+PyUciER2T1ADVGcDQV6eXDjWgYQcqHSaqSyBle/ZUWAtSP Jl8Is9HxtmI/8ZAiZNk/kfzYqRP/jSWsAsHxjYg/maXOTkjXB9bAYTCSGAmkVN32gOgg vsG3BwVy1Wp+9nqzBYGnn9NGf6nLe2CT2UDma95Q9U6uvdj1i4Tmf8SP/tiUWOiYjITx n5nw== X-Forwarded-Encrypted: i=1; AJvYcCV6W7JJQz1tcLViVULHY7j2LnF/4vP8uoBTNwuAbYNBlAQpjPLAVtH47Dkwsy6PeTinqOun2mCaHxMeVOw=@vger.kernel.org X-Gm-Message-State: AOJu0YxTRBheZNp3zdhWh89N3aKFjTyiRk8vwsugC5hCXWy/T7Utzg6b YsZaseDghOZM/wQYEKXPHICKf7On5HUkkNbpUJc78a6k1ss5yx/wJTu78F7OgYFMAtw7gkwdmWj uxXePsw== X-Google-Smtp-Source: AGHT+IHGwEtX1e44VeoF08hASz/dr/doRnth0R2Nh6U3dXLSsvJEuOjhpPAqND3KAFY16udrSphrHf+yI2dL X-Received: from oabsf10.prod.google.com ([2002:a05:6871:230a:b0:2bc:6ad3:5671]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6870:468d:b0:29e:80d8:31a9 with SMTP id 586e51a60fabf-2c719f157d9mr1055815fac.2.1742271292698; Mon, 17 Mar 2025 21:14:52 -0700 (PDT) Date: Mon, 17 Mar 2025 21:14:39 -0700 In-Reply-To: <20250318041442.321230-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250318041442.321230-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.rc1.451.g8f38331e32-goog Message-ID: <20250318041442.321230-3-irogers@google.com> Subject: [PATCH v1 2/5] perf stat: Remove print_mixed_hw_group_error From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Howard Chu , Weilin Wang , Levi Yun , "Dr. David Alan Gilbert" , Andi Kleen , James Clark , Dominique Martinet , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" print_mixed_hw_group_error will print a warning when a group of events uses different PMUs. This isn't possible to happen as parse_events__sort_events_and_fix_groups will break groups when this happens, adding the warning at the start of perf of: WARNING: events were regrouped to match PMUs As the previous mixed group warning can never happen, remove the associated code. Signed-off-by: Ian Rogers --- tools/perf/util/stat-display.c | 31 ------------------------------- tools/perf/util/stat.h | 1 - 2 files changed, 32 deletions(-) diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index f311f1960e29..1751a450f449 100644 --- a/tools/perf/util/stat-display.c +++ b/tools/perf/util/stat-display.c @@ -798,30 +798,6 @@ static void abs_printout(struct perf_stat_config *conf= ig, print_cgroup(config, os, evsel->cgrp); } =20 -static bool is_mixed_hw_group(struct evsel *counter) -{ - struct evlist *evlist =3D counter->evlist; - u32 pmu_type =3D counter->core.attr.type; - struct evsel *pos; - - if (counter->core.nr_members < 2) - return false; - - evlist__for_each_entry(evlist, pos) { - /* software events can be part of any hardware group */ - if (pos->core.attr.type =3D=3D PERF_TYPE_SOFTWARE) - continue; - if (pmu_type =3D=3D PERF_TYPE_SOFTWARE) { - pmu_type =3D pos->core.attr.type; - continue; - } - if (pmu_type !=3D pos->core.attr.type) - return true; - } - - return false; -} - static bool evlist__has_hybrid(struct evlist *evlist) { struct evsel *evsel; @@ -886,8 +862,6 @@ static void printout(struct perf_stat_config *config, s= truct outstate *os, if (counter->supported) { if (!evlist__has_hybrid(counter->evlist)) { config->print_free_counters_hint =3D 1; - if (is_mixed_hw_group(counter)) - config->print_mixed_hw_group_error =3D 1; } } } @@ -1587,11 +1561,6 @@ static void print_footer(struct perf_stat_config *co= nfig) " echo 0 > /proc/sys/kernel/nmi_watchdog\n" " perf stat ...\n" " echo 1 > /proc/sys/kernel/nmi_watchdog\n"); - - if (config->print_mixed_hw_group_error) - fprintf(output, - "The events in group usually have to be from " - "the same PMU. Try reorganizing the group.\n"); } =20 static void print_percore(struct perf_stat_config *config, diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h index 2fda9acd7374..1bcd7634bf47 100644 --- a/tools/perf/util/stat.h +++ b/tools/perf/util/stat.h @@ -100,7 +100,6 @@ struct perf_stat_config { int times; int run_count; int print_free_counters_hint; - int print_mixed_hw_group_error; const char *csv_sep; struct stats *walltime_nsecs_stats; struct rusage ru_data; --=20 2.49.0.rc1.451.g8f38331e32-goog