From nobody Wed Dec 17 15:38:26 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F2C218AA5 for ; Mon, 17 Mar 2025 05:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742188801; cv=none; b=S4sFVVpugyxHr3wo0hzzEt4DH4PpdvQWRlWWHau696YyiLCubgNWi5lJAlVncuTTqGLEFXy3GB3MyqTEoHKgUrdMKtnKTEgcw5r/Wpq1nB7QHg6qo+WAbE06R2DkauCdzY6+/iWpDbkirUjqlZncpERgdINUHusAjKTEfBY81cg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742188801; c=relaxed/simple; bh=QDlARu+d9zQMAzpj8Wxu49XYTGOg89oarS2O06Aif40=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CXNSaCAAZ4R8jfO76Zy5PUvpjpZpAhVokc4TRs3Pd8Qp7l2oMccquzh6RfLpb6TQhrkSddLggx6lKKkbG4ezS8gBXKbhA+1GFo4Fh9n8iVH68wC8MAWKmEJ0836ZH17TJtLqGn4VsyL528bnRlNSiBL6AxAw9rEqPvnpkWEgDVE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IR4Weys+; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IR4Weys+" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-22401f4d35aso70680185ad.2 for ; Sun, 16 Mar 2025 22:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742188800; x=1742793600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8hHpeaAz642MIL/iezdA9kA+qz/7ACYSpLAAklsJNG0=; b=IR4Weys+n+dh+SeueHBjTP20QK3D+/V6d2fO2Ri4KRVgqCGd1XxauaJyIsh1g/JRsV X0Z+uAUTtQ5RdY7s+uh6pR0wZ7s5LW1k/9ZmW4MqN2ISOBvKR0wTxg8bpKMv1HFpEGhV tnOcnmHcfJYGivn9ufKGOeUKatdE++HisShdeiRnEtZNuJBrljMkxsV5bU8qaY60LWjE tujxxnb71rlqZ28i37woMwZsAxtFWFBO464cvbUyEARnUAEQYKVSXQazK6iMe2yryoLm EnIyTjHjcd5Cmoi11U/EjuDFrB7hVgfhb6PubRARoaTKxNyZJLzKvyDeG6GOYsimvPfG Bb6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742188800; x=1742793600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8hHpeaAz642MIL/iezdA9kA+qz/7ACYSpLAAklsJNG0=; b=IFIlNHeaO1JX+rMTUikQWeGx4fPaCHAX9ZzG91lzAtR4RO4P0XUT/xVQIJOKYn/42W JOhCvB0sUQRN+7uDwk1QWNEuYQEaaYFs5LxW5L4HMFxzE6MiDkPvJWw7fFpITsifPtam FOWTVs25LjSaoKfMP64smpXtjd1cPq2ROZ63y/iL68cMrB8DKxE8mwH1JUvdNJNQVj56 WdL/tvlPPb1uDYyThuoO0sXHaSuHhZacipCo6cBlcs0bitS+vSMyxGUnu+LjQFv/SNH1 gLozcYbT6kz7sDLHxo4uS0QWYkA0nUcE6j1cGy+ag7Kh8euw52M3gfwZuA1LLE6gykIN XUXQ== X-Gm-Message-State: AOJu0YxAAnWxWUquTKAORbo0pO49xg+SOd+tlw/buYl7Lc8Igxaa1rQg dWA61bblaEI02Ie2gRDG/DV5EKt1shXVsy/vdKAZWJKhY2mb810S X-Gm-Gg: ASbGncs1Dvi7oZeTe2LVmf0sw+7Y5NqVWSrbmJ1vivVTMV8qWglo25Hmg+PRQrtNGaQ Do2RScapPpCPUeDKC+fusuhcq8YH2OiM5TzH+GRANHybueIazNy39VpStp9b+5FnOTF5t/MfvI8 LccRI2Oxt/HWWtsib10vENGUQswqWwq4w0ZL6SPxeaGmD/VTNBMUdQ8KOFz89bP7ZH2p7Qj8Yfh sxr4l8C9zIUMD+ThMRhbqD+Ak2i5JYZYQhcfZmk2G12iS3JDrXljzZs6wFc3l9tflIVHAjCgWXR XTHWD1uyJWyJvQdEAav3yST8aS/nZEl+qcHcmSEQbMk2Q9RvBQH04gnnaeusK7/TsQ== X-Google-Smtp-Source: AGHT+IEV6Wz5E1OsOPUft0kE2VrP4XoFNpoRQ5PM0M1BZxRJlTEp2VRWJHVmkulPVIEYr2uaQc1eAg== X-Received: by 2002:a17:902:ce8f:b0:220:c63b:d93c with SMTP id d9443c01a7336-225e0b07523mr139991475ad.44.1742188799683; Sun, 16 Mar 2025 22:19:59 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:df04:8817:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba721esm66029975ad.149.2025.03.16.22.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Mar 2025 22:19:59 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v1 1/3] i3c: master: svc: Fix missing the IBI rules Date: Mon, 17 Mar 2025 13:19:49 +0800 Message-Id: <20250317051951.3065011-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250317051951.3065011-1-yschu@nuvoton.com> References: <20250317051951.3065011-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu The code does not add IBI rules for devices with controller capability. However, some target devices, such as secondary controller, also have the controller capability. Modify the code to add rules for devices capable of sending IBI requests. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 1d1f351b9a85..a72ba5a7edd4 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1106,7 +1106,7 @@ static int svc_i3c_update_ibirules(struct svc_i3c_mas= ter *master) =20 /* Create the IBIRULES register for both cases */ i3c_bus_for_each_i3cdev(&master->base.bus, dev) { - if (I3C_BCR_DEVICE_ROLE(dev->info.bcr) =3D=3D I3C_BCR_I3C_MASTER) + if (!(dev->info.bcr & I3C_BCR_IBI_REQ_CAP)) continue; =20 if (dev->info.bcr & I3C_BCR_IBI_PAYLOAD) { --=20 2.34.1 From nobody Wed Dec 17 15:38:26 2025 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9970B218E92 for ; Mon, 17 Mar 2025 05:20:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742188804; cv=none; b=V9CbSjud/m2qsT64QdotNse8L1UsaTX8yit6dT1zTufmCEE725Gz1cVcjKZYKF9Tub+9/f6bvgOKXNwCoQxTl18TuEZWxNse5gUcFhFW3aRywZ7g39kL/eXZsqBpbznt2F+LajiMgFFqaOHmoxET1WCgSM4CIdF0p9hhHAiGW3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742188804; c=relaxed/simple; bh=ZvUxiJNGJUJ6eSLy6xmqeIcDyL3ulL7Wf4C669XW1MI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kbVbwM1xMkUID/jWEAQuFNHiWl0+VvOHz9v+GaFKikYT8/+SJ97X8XUXaiVlqcRyPLVCyBo8nh4g7v+M4K41PxM8P39EpalaX+r8l5F+p6rF4iC8zed5dUVnX9rKBngs7EyzmKtTUQEzZyBzHoHDMV/StO6+gGZWbIa7kBGUV6U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UZpwjXV4; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UZpwjXV4" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-225d66a4839so45586035ad.1 for ; Sun, 16 Mar 2025 22:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742188802; x=1742793602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aAEvizj50eAxWAKykJSsmzW28jqssjw0r0XHccdzS7k=; b=UZpwjXV4ydW/GGuQ5Uc8qPu7hZJelZw2221/rtXS3zPGCYZgMHCWp/cjF7ChUV2Ngh zUr5xhNKZjrZKdG7Bx+5Equ2eNCTnRKN2ii9gbb5xH1ta7z/i+FMnOWNDKOosMXCawun ViGxflPFNd6KFEINQqLhOAKk6nyFbkFnlAFVjNAy5IcE4EIdqc++7FXO3+/ye7DhVjJB Y70bh85tfpGK1op+vsxAoZDuqxjdVJ23vZ50/WgjTevRknxBGGsB1wIZ/T7BfXoKPlr4 Oc4ZCj1fi2xbejjb0W6oAt2ih7lIqKcD1/WCX2iuLRdN62trpZ908+HEOdEYYwoCi+Yf z9pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742188802; x=1742793602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aAEvizj50eAxWAKykJSsmzW28jqssjw0r0XHccdzS7k=; b=WCjO2BmknXdhMc2Q9xgM7c8mn3ROqkqe/bY5WLIl/uBfUP4ksHNJS6iVaIToXGrZGR +HwvtUTw49Wi3fYPApDJT0bmBGoeA8ehBhnXrSgEphT7fm+0bY5etsl/5xHPrPUp0LGF aQ+h57ad9YWeQkEB6MT2lZj11vcx4bky0RLj35is0bdB2sz2y2/dUKLGyeR5ovDjkFvO L7quRaLru3vMwfPq82mZQX2SI3V8Bkj6w0zU7jm+nWKmtCWnyTzIj3UZNf5AvjI3GdJt y4J7T7caKUewQ233AiHnDzSpqYKWqL/axbCz+Skv7CGkmjyopDp0QpgJ+krw2x41Eq7v EOOg== X-Gm-Message-State: AOJu0YxFlJDJJ/hrBrj3L4HwQOJtsr79k0UmAz9Adfh+K04M81du7RWW uVN86n4YnaEoWCcZO/CHso+S3xjQ8Gyaxc98/Ydhqa6NWMDPJgZ5 X-Gm-Gg: ASbGncvcG8lt3OMnsHsU9GIdXwCqy6sB9bZiDd0ii+o1MpMCd1+wL1JLFNBFQiOv9Re ui2cmoti65dXcWe8NeOcZ+yQen5Ihg/P9waXf1G9xie0/QksdikJay//nm94K9ZNugAJ7R4Qtz3 FWpr9RpbRdppYMSkOs/cIIFgtGWk0Bxa5IMKKGVoAaOAMvIM4VdBTEsckLU1FIDrtWAA9otFsXe XWI/2duKJ14o+uOz80wfNHu2XBt3HWv4WRv5WtM/0n8mvfzj3cg7TdlGgZHSEQ65oNsmabqJL+q LgpvrmY5hLQZoDL3JK0KQDU53uaYyrysKiu/SM/2w/Vgs6FO8/cY5Lg= X-Google-Smtp-Source: AGHT+IEHB6SBZYCHYVZ9nI0CRHRWXDHgiOP2L/CSK0IC9gfbmhq+cygXWU14lVnZh41QKkaCLFkxmQ== X-Received: by 2002:a17:902:e750:b0:223:607c:1d99 with SMTP id d9443c01a7336-225e1594eacmr155354065ad.0.1742188801791; Sun, 16 Mar 2025 22:20:01 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:df04:8817:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba721esm66029975ad.149.2025.03.16.22.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Mar 2025 22:20:01 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v1 2/3] i3c: master: svc: Use readsb helper for reading MDB Date: Mon, 17 Mar 2025 13:19:50 +0800 Message-Id: <20250317051951.3065011-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250317051951.3065011-1-yschu@nuvoton.com> References: <20250317051951.3065011-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu The target can send the MDB byte followed by additional data bytes. The readl on MRDATAB reads one actual byte, but the readsl advances the destination pointer by 4 bytes. This causes the subsequent payload to be copied to wrong position in the destination buffer. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index a72ba5a7edd4..57b9dec6b5a8 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -425,7 +425,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_mas= ter *master, slot->len < SVC_I3C_FIFO_SIZE) { mdatactrl =3D readl(master->regs + SVC_I3C_MDATACTRL); count =3D SVC_I3C_MDATACTRL_RXCOUNT(mdatactrl); - readsl(master->regs + SVC_I3C_MRDATAB, buf, count); + readsb(master->regs + SVC_I3C_MRDATAB, buf, count); slot->len +=3D count; buf +=3D count; } --=20 2.34.1 From nobody Wed Dec 17 15:38:26 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B78202192E5 for ; Mon, 17 Mar 2025 05:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742188806; cv=none; b=tmVh2v4cl7v1TV1ZqWC9UWAXTZ3ZoPCIVsBjyNV++JnbvC1iY6qzvrOck1Etxak+nwNyj8fqq9RrLfjfj5lzqr+E3sodwqO49ZsaKvLbWfFb/RSWsFKj2+wEJDmlbdxBQSTT2P+GQcMkPhkVVQRFNQJkx8Jbo26FZeZ5W5LKYKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742188806; c=relaxed/simple; bh=tm73wRGCtj2/+L15dF+oTxK0gYdTwD/VikeDQ7qKsDw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Leuc3RpER+YMB80AR1mX5LvOjt05L1rlUgImt417KydJJsoOjzfOU4usdgKulRuNymCrMOV83FxLfC0KFwXqE9/k3n2nKClYDNWZc5w7NXcel5ZKjOCWheoiGEN6S3/COBPdNVACvlsLtQuvU910t4CfAOjSBwR7u41RpAMd2pY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GvClAWsS; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GvClAWsS" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2235189adaeso65345565ad.0 for ; Sun, 16 Mar 2025 22:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742188804; x=1742793604; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T18/LmksYiI2JDaALAx8F0tVbVplhY6o09bZJuKtckw=; b=GvClAWsSw/rNg49bQnvwPu6Ie2pEjLVHRSWGEHjZJzSkm0FT1/39eroeDB0FyrR+Y5 JX4k7I8BuZsHN2dAE0rGB5ysXVfLWftF0WttrKc1w86jU/r8JA1kRiKvUPF3OBcKq/gI fBvzU9mwyb/1hDfnS+CLNKbLdRAj6/VaCs4lKqaG6h8+JGIR25IX3d85P/VRENC1v/AE j+oxIz6M9buklO8M39R0d6ik7f42k9+R0/jIVCHiL+fJU5h68xD+4zO53pNS+lLvDOvG MgMuUwOR+g3iRPo+tmPd2gzoQfD6Qa/1inqV/Q2w/w0Ob5soHyxNFZX+8yD95/zbiNhx UUOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742188804; x=1742793604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T18/LmksYiI2JDaALAx8F0tVbVplhY6o09bZJuKtckw=; b=UTU/7pv/XsrvyvQCbInKPirhHAN1CFdefSWR7B1GZB1HmvlfuDDI9cvA7xFpe205uA k8B89b5Gdr9F3cVUbIK8U0lBva42mZScg1u0/oXegfnJolqJPKdKfxetogCUy+PjjAwF wD8MZrdBhdIp03xxdLSOgXO9TSXS0kTjaDb3s/PpbN7lKofZT8t1oYtgJUIPYO6W8BCp D7Ari5Nl0U/GnHwD9ZiEqSQf+t8gQeiM9+GqIjqUSDW2zrNcAP/tSIwwFdRHj0yfRzfg lX0YTGZdFTxn1Juy5P4iEcIFxFPPvv+iuz9syBrEs0NQ8b0LEdhvDRfcjpGnLrKMdSLp 918w== X-Gm-Message-State: AOJu0YxwdfIwMUrMb0Qh6m0/WonB1fJnvKRxaD+/WrQkOBbX+6GPy8xk vHY64/XZdunPsk5QPYx2/PYsFOkVZMxX+rMj9kxHP/JlAOnS/Wsy X-Gm-Gg: ASbGncuytsDvYHe8xVZfJCaMX3tlPah7yOYciZbi/tD4Tn5a9DP7rKTdCoB6rocbqxH YFQnM7t+ECbQPaQBkMJR61ScfS/AtZZBfntrftjLnZYs6ISpAWvG0PlKkKzCmY1ruFbmS3PWITN uC0T/AvwdSGdynlXlUFHxrkQ1aMmVPkPUQr7ftSPyUGo5pscyVhzREbAqLvVzsGm5fEH3wntNis rzZX47UXOyzC+XGMku+BwXvOlOfs6JztZa0V20h5P/VIEi20QtwbASJ6KpUxlMELJ/gkkJe8IR1 aBFhM/3gB+2NFGYt9OfdwXl8LBRyyEirir6cX0oqhVTSZEpLIqtkfvg= X-Google-Smtp-Source: AGHT+IFAseff1yIkZHzc1rGdhQPKl7uycYfsnTrI/GVu4JilKm2nddWrecFI4sABECPAMNZYRmECeA== X-Received: by 2002:a17:903:41d0:b0:220:fe36:650c with SMTP id d9443c01a7336-225e1782e22mr164178955ad.23.1742188803960; Sun, 16 Mar 2025 22:20:03 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:df04:8817:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba721esm66029975ad.149.2025.03.16.22.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Mar 2025 22:20:03 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v1 3/3] i3c: master: svc: Fix missing STOP for master request Date: Mon, 17 Mar 2025 13:19:51 +0800 Message-Id: <20250317051951.3065011-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250317051951.3065011-1-yschu@nuvoton.com> References: <20250317051951.3065011-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu The controller driver nacked the master request but didn't emit a STOP to end the transaction. The driver shall refuse the unsupported requests and return the controller state to IDLE by emitting a STOP. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 57b9dec6b5a8..e0cd3ce28b7f 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -592,6 +592,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) queue_work(master->base.wq, &master->hj_work); break; case SVC_I3C_MSTATUS_IBITYPE_MASTER_REQUEST: + svc_i3c_master_emit_stop(master); default: break; } --=20 2.34.1