From nobody Wed Dec 17 17:27:12 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA02C1C8638 for ; Sun, 16 Mar 2025 18:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742151516; cv=none; b=R9KFuOhYnyF2mD9nPN+ZsMRd3sjWNd0SK8rM/vFzYRzLXVre8Z0XlD08kHqD8PI+I2je6FCh1l9KsmeIXvRntfLzHVIesefue1mNEKlzuPocWF+tzCCX6yIqcRvStIwA+Gn9jx4jke3wYA6uHqnUVlBdc79bqRZ6N4PblUchO9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742151516; c=relaxed/simple; bh=6qAvQnwnRTyZctD+w0UHaE3qyqtxNrI4mn2Ek0AIBp0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=uDUSH3AA+fDczWq8v2ponaBWzd1LLo48wlsmhOqqSHbxHjuDZeSB7ktzVctUR7zqvASwSsyvNem3auW4zzR4qUBF1uXyZIeP144S1g5ys2N8iz/tpShCeMmco6F6aRwYGlOlf2bdN9fOk26MUB6g7Am8jr/gqRzq6Sfac1kWEP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JAzuPoss; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JAzuPoss" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742151513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D5ral2Iq5Mk0NPFIAn2fk0EzZmk6i/aP++c5b9Msz3M=; b=JAzuPoss+ileNBeDqGdbJTG4m2E4GEoUf6Iy1OTKY5EGfg+Ly5hOAgP8VwCv1bzk4866rL 23ZQJlUsh6dbC8a6N6zb/76DoD3JfRGGdPzELfmY81fyyxOnqBYutWUVL29pgaXMmxeubG bs2D428X2sGQBTEsb/x7mrqGhOqrpkU= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-573-HlhW3WGkN1eiXdc8vMFX_Q-1; Sun, 16 Mar 2025 14:58:29 -0400 X-MC-Unique: HlhW3WGkN1eiXdc8vMFX_Q-1 X-Mimecast-MFC-AGG-ID: HlhW3WGkN1eiXdc8vMFX_Q_1742151508 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 867491809CA6; Sun, 16 Mar 2025 18:58:27 +0000 (UTC) Received: from asrivats-na.rmtustx.csb (unknown [10.2.16.186]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0019B18001D4; Sun, 16 Mar 2025 18:58:24 +0000 (UTC) From: Anusha Srivatsa Date: Sun, 16 Mar 2025 14:58:22 -0400 Subject: [PATCH] drm/panel/sharp-ls043t1le01: Use _multi variants Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250316-b4-panel-ls043t1le01-v1-1-ee38371b0ba0@redhat.com> X-B4-Tracking: v=1; b=H4sIAE0f12cC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1MDY0Mz3SQT3YLEvNQc3ZxiAxPjEsOcVANDXXMTA/MkC0uzJPNECyWg1oK i1LTMCrCx0bG1tQDpAiE1ZgAAAA== X-Change-ID: 20250316-b4-panel-ls043t1le01-7407b896b7a8 To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Tejas Vipin , Doug Anderson , Anusha Srivatsa X-Developer-Signature: v=1; a=ed25519-sha256; t=1742151504; l=6039; i=asrivats@redhat.com; s=20250122; h=from:subject:message-id; bh=6qAvQnwnRTyZctD+w0UHaE3qyqtxNrI4mn2Ek0AIBp0=; b=ljTsoSffq/s19aFhr0/nICcWfPmJltZzmLzAy7iCYRYG0M71OcLY0roycbDSIzvSFGekMzRp0 BoH+wEeg+YhDN3U8S3M7oTVZmgBnSDS7L8rR9IxeHXmUKWScQ1rCLN9 X-Developer-Key: i=asrivats@redhat.com; a=ed25519; pk=brnIHkBsUZEhyW6Zyn0U92AeIZ1psws/q8VFbIkf1AU= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Move away from using deprecated API and use _multi variants if available. Use mipi_dsi_msleep() and mipi_dsi_usleep_range() instead of msleep() and usleep_range() respectively. Used Coccinelle to find the _multi variant APIs, replacing mpi_dsi_msleep() where necessary and for returning dsi_ctx.accum_err in these functions. @rule_1@ identifier dsi_var; identifier r; identifier func; type t; position p; expression dsi_device; expression list es; @@ t func(...) { ... struct mipi_dsi_device *dsi_var =3D dsi_device; +struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi_var }; <+... ( -r =3D mipi_dsi_dcs_nop(dsi_var)@p; +mipi_dsi_dcs_nop_multi(&dsi_ctx); | -r =3D mipi_dsi_dcs_exit_sleep_mode(dsi_var)@p; +mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); | -r =3D mipi_dsi_dcs_enter_sleep_mode(dsi_var)@p; +mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); | -r =3D mipi_dsi_dcs_write_buffer(dsi_var,es)@p; +mipi_dsi_dcs_write_buffer_multi(&dsi_ctx,es); | -r =3D mipi_dsi_dcs_set_display_off(dsi_var,es)@p; +mipi_dsi_dcs_set_display_off_multi(&dsi_ctx,es); | -r =3D mipi_dsi_compression_mode_ext(dsi_var,es)@p; +mipi_dsi_compression_mode_ext_multi(&dsi_ctx,es); | -r =3D mipi_dsi_compression_mode(dsi_var,es)@p; +mipi_dsi_compression_mode_multi(&dsi_ctx,es); | -r =3D mipi_dsi_picture_parameter_set(dsi_var,es)@p; +mipi_dsi_picture_parameter_set_multi(&dsi_ctx,es); | -r =3D mipi_dsi_dcs_set_display_on(dsi_var,es)@p; +mipi_dsi_dcs_set_display_on_multi(&dsi_ctx,es); | -r =3D mipi_dsi_dcs_set_tear_on(dsi_var)@p; +mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx); | -r =3D mipi_dsi_turn_on_peripheral(dsi_var)@p; +mipi_dsi_turn_on_peripheral_multi(&dsi_ctx); | -r =3D mipi_dsi_dcs_soft_reset(dsi_var)@p; +mipi_dsi_dcs_soft_reset_multi(&dsi_ctx); | -r =3D mipi_dsi_dcs_set_display_brightness(dsi_var,es)@p; +mipi_dsi_dcs_set_display_brightness_multi(&dsi_ctx,es); | -r =3D mipi_dsi_dcs_set_pixel_format(dsi_var,es)@p; +mipi_dsi_dcs_set_pixel_format_multi(&dsi_ctx,es); | -r =3D mipi_dsi_dcs_set_column_address(dsi_var,es)@p; +mipi_dsi_dcs_set_column_address_multi(&dsi_ctx,es); | -r =3D mipi_dsi_dcs_set_page_address(dsi_var,es)@p; +mipi_dsi_dcs_set_page_address_multi(&dsi_ctx,es); | -r =3D mipi_dsi_dcs_set_tear_scanline(dsi_var,es)@p; +mipi_dsi_dcs_set_tear_scanline_multi(&dsi_ctx,es); ) -if(r < 0) { -... -} ...+> } @rule_2@ identifier dsi_var; identifier r; identifier func; type t; position p; expression dsi_device; expression list es; @@ t func(...) { ... struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi_var }; <+... ( -r =3D msleep(es)@p; +r =3D mipi_dsi_msleep(&dsi_ctx,es); | -msleep(es)@p; +mipi_dsi_msleep(&dsi_ctx,es); | -r =3D usleep_range(es)@p; +r =3D mipi_dsi_usleep_range(&dsi_ctx,es); | -usleep_range(es)@p; +mipi_dsi_usleep_range(&dsi_ctx,es); ) ...+> } @rule_3@ identifier dsi_var; identifier func; type t; position p; expression list es; @@ t func(...) { ... struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi_var }; ... -return 0; +return dsi_ctx.accum_err; } Cc: Maxime Ripard Cc: Dmitry Baryshkov Cc: Tejas Vipin Cc: Doug Anderson Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 36 ++++++++++-----------= ---- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gpu/= drm/panel/panel-sharp-ls043t1le01.c index 729cbb0d8403ff7c0c4b9d21774909cc298904a2..9803eaf18e95d70742ece88e829= 32751476fdda8 100644 --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c @@ -36,15 +36,14 @@ static inline struct sharp_nt_panel *to_sharp_nt_panel(= struct drm_panel *panel) static int sharp_nt_panel_init(struct sharp_nt_panel *sharp_nt) { struct mipi_dsi_device *dsi =3D sharp_nt->dsi; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; int ret; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_exit_sleep_mode(dsi); - if (ret < 0) - return ret; + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); =20 - msleep(120); + mipi_dsi_msleep(&dsi_ctx, 120); =20 /* Novatek two-lane operation */ ret =3D mipi_dsi_dcs_write(dsi, 0xae, (u8[]){ 0x03 }, 1); @@ -52,44 +51,37 @@ static int sharp_nt_panel_init(struct sharp_nt_panel *s= harp_nt) return ret; =20 /* Set both MCU and RGB I/F to 24bpp */ - ret =3D mipi_dsi_dcs_set_pixel_format(dsi, MIPI_DCS_PIXEL_FMT_24BIT | - (MIPI_DCS_PIXEL_FMT_24BIT << 4)); - if (ret < 0) - return ret; + mipi_dsi_dcs_set_pixel_format_multi(&dsi_ctx, + MIPI_DCS_PIXEL_FMT_24BIT | + (MIPI_DCS_PIXEL_FMT_24BIT << 4)); =20 - return 0; + return dsi_ctx.accum_err; } =20 static int sharp_nt_panel_on(struct sharp_nt_panel *sharp_nt) { struct mipi_dsi_device *dsi =3D sharp_nt->dsi; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_set_display_on(dsi); - if (ret < 0) - return ret; + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 - return 0; + return dsi_ctx.accum_err; } =20 static int sharp_nt_panel_off(struct sharp_nt_panel *sharp_nt) { struct mipi_dsi_device *dsi =3D sharp_nt->dsi; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_set_display_off(dsi); - if (ret < 0) - return ret; + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); =20 - ret =3D mipi_dsi_dcs_enter_sleep_mode(dsi); - if (ret < 0) - return ret; + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 - return 0; + return dsi_ctx.accum_err; } =20 static int sharp_nt_panel_unprepare(struct drm_panel *panel) --- base-commit: dbe74119ff71c00f2d863a32f72aab2d15e61c39 change-id: 20250316-b4-panel-ls043t1le01-7407b896b7a8 Best regards, --=20 Anusha Srivatsa