From nobody Mon Feb 9 21:40:50 2026 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AF081FCF44 for ; Fri, 14 Mar 2025 12:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741955878; cv=none; b=K4V14tofUqftPvYF+L2Spjeif0Sm0KSpvO8OFjaE0ocuc9NGNtkCI0ywRIlFb3X/vFMAQ8z+MGn9MCtix3gwmdEReWcpo2xMpmrjFUdccv70Kkmoteji9WSFfd7N0IMPk2e8Mo1bpcxneDkkqBS+qLtv/2K1OrxAYONNrroKzw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741955878; c=relaxed/simple; bh=qIm+gMdvupKqwS9Xu6DPAYAhkyp9bxQv0TScmBCRWAU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VvngP1/viqe1LnRS6koxsqgg4vA4WkyfaIltMoKIyoFnD4no1P9XYXBjRH74vvZ5SsR9Pcu6itpWrb0VWvUyLyHNdgsd7GrmQkE93Ya4hVztzv2oGgBHR5vL8mB36LH1zrBtiI7omFQmp/JhrtJwp+uOUBA1XoTsoVOxKpLthRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=fa8iduWn; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fa8iduWn" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6e904f53151so17790716d6.3 for ; Fri, 14 Mar 2025 05:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741955876; x=1742560676; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Au/TjH3+zjUdDPhRJAjj0/vsDAjgHCF7V+hbXHtsO9U=; b=fa8iduWndcsK9L7/pmbrHFddq+M2vwWCH13NcPwywJnpfUGxW+Us8VutCZ+kkF4U1X WGlx0/31lK9yihFLuqPEBgPMB8C0ev1T45ANHHaEvPg3I554zttVC81M4wZMml4ByNcE tJKc6/W9bwzIdqFyZ4/RAIaKs3prEYJROZlu0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741955876; x=1742560676; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Au/TjH3+zjUdDPhRJAjj0/vsDAjgHCF7V+hbXHtsO9U=; b=llENzrh9zrEjbMU29Y7bXgKqY2+Kz9RzMevot75xILMwUIpqGdjq93F2uMBf7IJ8uB gzk3N5kuxOnLmXN2iAowXyx+We3rZYDHAiesPDYTS7BurVaAFXYteVxm2PTMtIPEEoCp Bp9Wvc6mbmtYMetB3nnjg/J9CbfKFz3GLJADCCnqNEd9X7pwuSjTNoXzAuPSpNz3li5/ oOxoL1zMpIskVElQJ7BSyZLsN3AZcj1C01MgN7ZV0kTqto22KrqBL14xlEbtR+Tudbtr MFfNHsm7vMVmyosyVFjBJoNj5+sW2ItsNHdU7UWs8LdpxnSEJtzLVFHQNqYZzLZUk23E w+Fw== X-Forwarded-Encrypted: i=1; AJvYcCUAQgtX3Fg9FflTfHtUGCpw+lt6sBmxYxvOzkQqe6QQSuWIA9fCL0qkpsHgIcBBvfG7sNW2potPGanYwVw=@vger.kernel.org X-Gm-Message-State: AOJu0YxucZi3aSvqELH5UFi85v2DuzUcsDZNJrzdQG2OitWkg6KgRMTc ZLV2OAMA4OpYBTuSiWqbNQ79i01oK49UYj+loKaH3Ot/ZSdC59BnXNO0UmNrHg== X-Gm-Gg: ASbGncuBqiyg+htPLjbRSJUkOWRg0Eh8p17CfuKhfKZ/3p5qOVhlc+o69OqwYQLnAP8 wwypvw67gQcTKZeXJOSVFYDDZZP+uyb/jDwRJYPUUgqpzqUwg2k+mzo7dAleZN9WhixrPt7MfaK oZzwVVcNtLhX/9MTiBFcLf3eMFM4nigwDI4ePfHscIc+YJjF/aGeUskRZcYzTTZbDX6FAON+aHJ tNMIOICvZ63+fCqycL0eUDZdMSDRpqX4UCVcWsDcMxBzMdO6VaV6AoUmq/nsx9qPrL79G/CucJ7 wnrTa59IiK2GHND1lppbL5J//YMiPtsM0ZPjUnZwdScXT+ppLyCp8WajQrfj5tQmM27zMWmufJy 2sb00+4ybnspAFuwlniZ+6w== X-Google-Smtp-Source: AGHT+IG1soI/f8SA1zxak+RF/DcH11J2/WsE7iepmItBe5lAxghxQPzlLhQXGTbEnZnAJSzvs34p/Q== X-Received: by 2002:a05:6214:2483:b0:6e8:eabf:fd55 with SMTP id 6a1803df08f44-6eaeaae0998mr29795736d6.39.1741955875895; Fri, 14 Mar 2025 05:37:55 -0700 (PDT) Received: from denia.c.googlers.com (15.237.245.35.bc.googleusercontent.com. [35.245.237.15]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eade24dda0sm23168706d6.58.2025.03.14.05.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 05:37:55 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 14 Mar 2025 12:37:51 +0000 Subject: [PATCH 1/2] media: vivid: Fix requirement about webcam_intervals Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250314-vivid-fix-twice-v1-1-7463c2b0ba63@chromium.org> References: <20250314-vivid-fix-twice-v1-0-7463c2b0ba63@chromium.org> In-Reply-To: <20250314-vivid-fix-twice-v1-0-7463c2b0ba63@chromium.org> To: Hans Verkuil , Mauro Carvalho Chehab Cc: Hidenori Kobayashi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 Since commit f0b4a2c037c0 ("media: vivid: Extend FPS rates offered by simulated webcam") we do not require twice as many intervals as sizes. In fact, now we have 13 intervals and 6 sizes. Fix the comment. Signed-off-by: Ricardo Ribalda --- drivers/media/test-drivers/vivid/vivid-vid-cap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/test-drivers/vivid/vivid-vid-cap.c b/drivers/med= ia/test-drivers/vivid/vivid-vid-cap.c index b166d90177c641eed8116e791daeec8822973ff0..623ba1e5e54791c0ac62aa2f0fc= c3dcd444c873a 100644 --- a/drivers/media/test-drivers/vivid/vivid-vid-cap.c +++ b/drivers/media/test-drivers/vivid/vivid-vid-cap.c @@ -33,8 +33,7 @@ static const struct v4l2_frmsize_discrete webcam_sizes[] = =3D { }; =20 /* - * Intervals must be in increasing order and there must be twice as many - * elements in this array as there are in webcam_sizes. + * Intervals must be in increasing order. */ static const struct v4l2_fract webcam_intervals[] =3D { { 1, 1 }, --=20 2.49.0.rc1.451.g8f38331e32-goog From nobody Mon Feb 9 21:40:50 2026 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADB1B1FDE29 for ; Fri, 14 Mar 2025 12:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741955879; cv=none; b=VtffJCk+V01dQe5guIpFPZHf/aMaOWF/BnE40/dhjMkn5fL/4qaLQn9DS4CAnt/w2+NZ8SeQOXKIna1fi7agIZY29ehZay56bOFyU10R+S5r385L43YMDXqwnbQRW7buL8UWfYIGXX49VxuRQNOq1LH10JkIdcDoYoJGgTmXohs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741955879; c=relaxed/simple; bh=Z4vVBZrwdsora5jaavoKvH4SBMRfW+n+z+2ksvCX0uU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HsdUCNa6rgpfusau01Ikb7wQHB1vs67uTyOxQ9XD+zeCUKEEBzwmKO/eh550L1l8CtQ3j86Xz51U5wmoeBqzd8m0usiyU5jeQWJ7LHZsPGi8dE9omdvsu3JpLiiaeTs3dPvdU61QxUBNuVWx/w4+Ug2lXRga0igSGfteLuj3Ct4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ct0fMGqj; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ct0fMGqj" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6e8fce04655so18509106d6.3 for ; Fri, 14 Mar 2025 05:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741955876; x=1742560676; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4Mt1R0EC3FYz66XqhH4MaCDZ6sflbyDD7zxn5LRYO4w=; b=Ct0fMGqj0Zq8y6F7+IU1iK0RUohll3LgpOZJf7Cidnyoh+M6nk52fghd+lNBG/dRPA XXBj0FYXMtZKcOJBMRKpx4NXtc2xWcJ3DRW9fg37sV7rG9bRnpqFWRvGGyNnOdGOkGWz 1GXlZ9oBOGwt72dDKU4fD7P0gaNiR0YtC/Unk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741955876; x=1742560676; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4Mt1R0EC3FYz66XqhH4MaCDZ6sflbyDD7zxn5LRYO4w=; b=GmBNpIwN8kgNrOpPXcp1lshIL0P9S3QuhnqBiMjMKV9RYqJfT2FpHDOOOHmqfTCFHu YJa3KNgildhE79LcVtzpmQPv16FwmOC5jaBvLQggIHUXursN7tJxkE/N+YzuCwiDJAO9 Tu9Bk82BRSc4Rx+DwawaAYkqcAjLkhmhWQxdtcc5xE8Nb+3UM47ACnTssgXsY/2j4Yig tULfgdN/htHi/wNIpqQu7rwnt/k9Wms8h7NWdYxThhLMLL9JEO36IsfWKfSQSfVMSB1u P+OAKEXTmhk4NqUfM+gkGYHYoig0P2Or3v4w7GX2uV3W1W0G6cyvXM9CnpWUdhwvvQJV Mwtw== X-Forwarded-Encrypted: i=1; AJvYcCWe/iroFRWREv2BurbYx4TByK9dAp9i91RJH+7OpC7IpvvxNJBsumqOWkUY8S8OGwWvOLDy62A30qTd/nQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwQOTHkT3FV87T3ICcFXdr1L1qpZhwqZ1bfsZeZK6lldekQbFQL tByUSPWtMA2+vH5wKscbyO0GUXdiCEVpUh5v56UJuy7eRKAsp/SzYVoDoZKEO/690HcvIY8vaY0 xpA== X-Gm-Gg: ASbGncu58MGYEYZll0k3WbpEG+wCp6dX62LiuJnTxlZ8/bup2R+jCe/p7wPyvDojD+g +EXgKQbwi5ssfP38B7d8YbMZHXIAYCKJP16olcKa4XC8aMQplSL92rtZLu4aoTWVEd+JmtXmO9j rSIer8CqUZqjKCCM0/O+8Y9zftB51MEdtt9eSm4Ga5MNdZJOit0YyirW7sp/5cSt1S9tR0tiWlz IsbJdEdG4qdHeGTs3W52NnaubCE4fXDycDZvaWHO3PXQyF/qKNAtSwZuOZ+52a6o6923csAvgUr 1+k76i3KDZVhVuop/9MyS5FhiUNgk/mNXogl+AupMmYXpqIVx2S5Ee86i5ohyyQT4Um59UHu7g7 4EfCpjUjlV0bCd4sZ6v2jCQ== X-Google-Smtp-Source: AGHT+IGMU11VsoezNLSdINUAsRSlE0CW48Y+kQb7z5VQcOk1VIrvuaXDWSla6So21S8lMPm/2Jii/g== X-Received: by 2002:a05:6214:300a:b0:6d8:99cf:d2db with SMTP id 6a1803df08f44-6eaeab5a2bfmr28487096d6.38.1741955876613; Fri, 14 Mar 2025 05:37:56 -0700 (PDT) Received: from denia.c.googlers.com (15.237.245.35.bc.googleusercontent.com. [35.245.237.15]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eade24dda0sm23168706d6.58.2025.03.14.05.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 05:37:56 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 14 Mar 2025 12:37:52 +0000 Subject: [PATCH 2/2] media: vivid: Add more webcam resolutions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250314-vivid-fix-twice-v1-2-7463c2b0ba63@chromium.org> References: <20250314-vivid-fix-twice-v1-0-7463c2b0ba63@chromium.org> In-Reply-To: <20250314-vivid-fix-twice-v1-0-7463c2b0ba63@chromium.org> To: Hans Verkuil , Mauro Carvalho Chehab Cc: Hidenori Kobayashi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 Add 3 more common resolution for webcams. This is required to increase the test coverage of unit tests based on vivid. Co-developed-by: Hidenori Kobayashi Signed-off-by: Hidenori Kobayashi Signed-off-by: Ricardo Ribalda --- drivers/media/test-drivers/vivid/vivid-vid-cap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/test-drivers/vivid/vivid-vid-cap.c b/drivers/med= ia/test-drivers/vivid/vivid-vid-cap.c index 623ba1e5e54791c0ac62aa2f0fcc3dcd444c873a..df726961222be874c39d19e1fb4= 57bd816ab45fd 100644 --- a/drivers/media/test-drivers/vivid/vivid-vid-cap.c +++ b/drivers/media/test-drivers/vivid/vivid-vid-cap.c @@ -25,9 +25,12 @@ /* Sizes must be in increasing order */ static const struct v4l2_frmsize_discrete webcam_sizes[] =3D { { 320, 180 }, + { 320, 240 }, { 640, 360 }, { 640, 480 }, { 1280, 720 }, + { 1280, 960 }, + { 1600, 1200 }, { 1920, 1080 }, { 3840, 2160 }, }; --=20 2.49.0.rc1.451.g8f38331e32-goog