From nobody Thu Dec 18 18:17:40 2025 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0145269D16 for ; Thu, 13 Mar 2025 15:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741881595; cv=none; b=HRLHpSN9CG3bNFa3sxzu4BbWobm3BX2ysezqj4LOsMouO2HrkK3cH3riAAnoszUjgUglehFPkaZ4CNKuDLCsQWqrdC6Sdr95hWa+prRfVVKPmy+CRJbNrEUB8/IpiRINXpDMTGSNQPURqFpQR11kfzIrcqvWM35/02TKEj3twOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741881595; c=relaxed/simple; bh=BSeM3MygPsa2Ki+GyIgTvUBRixtUtAxOAhOHZhKHtT4=; h=Message-ID:From:To:Cc:Subject:References:MIME-Version: Content-Type:Date; b=BzTnTYWt5nJFPqKa8YMPGFDcvOlsappY0zPiWJVhGK6VGD9qCuDD83+d8QhC82+WWvM26Oj4dFWjARgufEb5oahN5tN9UQmiBXaXxuWCdqUXuigv5BshIqE7K3flCWevJ9EyvtSlG8mQrmDbXNYuCaz2DvMsbXmicvzWL/drktI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=HEECuTeC; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=Tqy9+HUd; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="HEECuTeC"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Tqy9+HUd" Message-ID: <20250313155914.276685779@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1741881592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=pJ3c2uTRlpYbT0X+Ce70TgQESWwWd+/6IGj70OyJbAY=; b=HEECuTeCAMEgNVsMfcioaBmgcL71RjobCEqeYqRL9tEKubn9CneleMKoXfEejyPkVhay5u ctAVg2APF2RT0qE+vlj1+pqoXs2SWWicjUJk2Hi1LpRFpuYgSYLld2MAlRlZ2xH05ItnKM FEBgQsHFfgMGqUwijDMsaN6n3rSSN4M9eMRddu1LOxdRlTY09BrwL9qg61xY2x/k+nqOla 5hPjQvgTSEvRvIwJ2cGD6nUlnuW3WPv6iTznpUNUVoKAKgaNKcEE+ElggVBI02NQK0S2rR N6e4gC1tld5B0DmOPSnRhvXpJNysKmnNcrIo+wDaW9CM0Q2zpuz0yYAl9cUlqA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1741881592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=pJ3c2uTRlpYbT0X+Ce70TgQESWwWd+/6IGj70OyJbAY=; b=Tqy9+HUdO0v/fOr5sk0THam2tXUZ0VxswgOeJZPKnQvMjzF0eYVUyectzgpaU7OZOtJUp/ KI7hJD4wnjkzecBg== From: Thomas Gleixner To: LKML Cc: Peter Zijlstra , Jiri Slaby Subject: [patch 06/46] genirq/proc: Switch to lock guards References: <20250313154615.860723120@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Thu, 13 Mar 2025 16:59:51 +0100 (CET) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert all lock/unlock pairs to guards and tidy up the code. No functional change. Signed-off-by: Thomas Gleixner --- kernel/irq/proc.c | 65 +++++++++++++++++++------------------------------= ----- 1 file changed, 24 insertions(+), 41 deletions(-) --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c @@ -81,20 +81,18 @@ static int show_irq_affinity(int type, s static int irq_affinity_hint_proc_show(struct seq_file *m, void *v) { struct irq_desc *desc =3D irq_to_desc((long)m->private); - unsigned long flags; cpumask_var_t mask; =20 if (!zalloc_cpumask_var(&mask, GFP_KERNEL)) return -ENOMEM; =20 - raw_spin_lock_irqsave(&desc->lock, flags); - if (desc->affinity_hint) - cpumask_copy(mask, desc->affinity_hint); - raw_spin_unlock_irqrestore(&desc->lock, flags); + scoped_guard (raw_spinlock_irq, &desc->lock) { + if (desc->affinity_hint) + cpumask_copy(mask, desc->affinity_hint); + } =20 seq_printf(m, "%*pb\n", cpumask_pr_args(mask)); free_cpumask_var(mask); - return 0; } =20 @@ -295,23 +293,18 @@ static int irq_spurious_proc_show(struct =20 #define MAX_NAMELEN 128 =20 -static int name_unique(unsigned int irq, struct irqaction *new_action) +static bool name_unique(unsigned int irq, struct irqaction *new_action) { struct irq_desc *desc =3D irq_to_desc(irq); struct irqaction *action; - unsigned long flags; - int ret =3D 1; =20 - raw_spin_lock_irqsave(&desc->lock, flags); + guard(raw_spinlock_irq)(&desc->lock); for_each_action_of_desc(desc, action) { if ((action !=3D new_action) && action->name && - !strcmp(new_action->name, action->name)) { - ret =3D 0; - break; - } + !strcmp(new_action->name, action->name)) + return false; } - raw_spin_unlock_irqrestore(&desc->lock, flags); - return ret; + return true; } =20 void register_handler_proc(unsigned int irq, struct irqaction *action) @@ -319,8 +312,7 @@ void register_handler_proc(unsigned int char name [MAX_NAMELEN]; struct irq_desc *desc =3D irq_to_desc(irq); =20 - if (!desc->dir || action->dir || !action->name || - !name_unique(irq, action)) + if (!desc->dir || action->dir || !action->name || !name_unique(irq, actio= n)) return; =20 snprintf(name, MAX_NAMELEN, "%s", action->name); @@ -347,17 +339,16 @@ void register_irq_proc(unsigned int irq, * added, not when the descriptor is created, so multiple * tasks might try to register at the same time. */ - mutex_lock(®ister_lock); + guard(mutex)(®ister_lock); =20 if (desc->dir) - goto out_unlock; - - sprintf(name, "%d", irq); + return; =20 /* create /proc/irq/1234 */ + sprintf(name, "%d", irq); desc->dir =3D proc_mkdir(name, root_irq_dir); if (!desc->dir) - goto out_unlock; + return; =20 #ifdef CONFIG_SMP umode_t umode =3D S_IRUGO; @@ -366,31 +357,27 @@ void register_irq_proc(unsigned int irq, umode |=3D S_IWUSR; =20 /* create /proc/irq//smp_affinity */ - proc_create_data("smp_affinity", umode, desc->dir, - &irq_affinity_proc_ops, irqp); + proc_create_data("smp_affinity", umode, desc->dir, &irq_affinity_proc_ops= , irqp); =20 /* create /proc/irq//affinity_hint */ proc_create_single_data("affinity_hint", 0444, desc->dir, - irq_affinity_hint_proc_show, irqp); + irq_affinity_hint_proc_show, irqp); =20 /* create /proc/irq//smp_affinity_list */ proc_create_data("smp_affinity_list", umode, desc->dir, &irq_affinity_list_proc_ops, irqp); =20 - proc_create_single_data("node", 0444, desc->dir, irq_node_proc_show, - irqp); + proc_create_single_data("node", 0444, desc->dir, irq_node_proc_show, irqp= ); # ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK proc_create_single_data("effective_affinity", 0444, desc->dir, - irq_effective_aff_proc_show, irqp); + irq_effective_aff_proc_show, irqp); proc_create_single_data("effective_affinity_list", 0444, desc->dir, - irq_effective_aff_list_proc_show, irqp); + irq_effective_aff_list_proc_show, irqp); # endif #endif proc_create_single_data("spurious", 0444, desc->dir, - irq_spurious_proc_show, (void *)(long)irq); + irq_spurious_proc_show, (void *)(long)irq); =20 -out_unlock: - mutex_unlock(®ister_lock); } =20 void unregister_irq_proc(unsigned int irq, struct irq_desc *desc) @@ -468,7 +455,6 @@ int show_interrupts(struct seq_file *p, int i =3D *(loff_t *) v, j; struct irqaction *action; struct irq_desc *desc; - unsigned long flags; =20 if (i > ACTUAL_NR_IRQS) return 0; @@ -487,13 +473,13 @@ int show_interrupts(struct seq_file *p, seq_putc(p, '\n'); } =20 - rcu_read_lock(); + guard(rcu)(); desc =3D irq_to_desc(i); if (!desc || irq_settings_is_hidden(desc)) - goto outsparse; + return 0; =20 if (!desc->action || irq_desc_is_chained(desc) || !desc->kstat_irqs) - goto outsparse; + return 0; =20 seq_printf(p, "%*d:", prec, i); for_each_online_cpu(j) { @@ -503,7 +489,7 @@ int show_interrupts(struct seq_file *p, } seq_putc(p, ' '); =20 - raw_spin_lock_irqsave(&desc->lock, flags); + guard(raw_spinlock_irq)(&desc->lock); if (desc->irq_data.chip) { if (desc->irq_data.chip->irq_print_chip) desc->irq_data.chip->irq_print_chip(&desc->irq_data, p); @@ -532,9 +518,6 @@ int show_interrupts(struct seq_file *p, } =20 seq_putc(p, '\n'); - raw_spin_unlock_irqrestore(&desc->lock, flags); -outsparse: - rcu_read_unlock(); return 0; } #endif