From nobody Fri Dec 19 03:18:59 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FD861FBCBE for ; Thu, 13 Mar 2025 05:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741843201; cv=none; b=ObKMsI8Ta1jb0Drs3CCU13+f4ojmXBi7vAA0CVFG/DnPBDMDC7/FsQ6iNhzlNZlMDhmlb6F82rvPCy2lNnR1a+swft7JC0xCORv+20qHFJ8Zcfq0IvPtMDk08T+hdw04rauKi4+XgeiHNCBevEb2rSKMpznNgkkOjjoTTAMNR84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741843201; c=relaxed/simple; bh=QnZI5g5/imwILnMF97Mve/8kvZvqDgLUw+ieihDhkwQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MMJOjEJj1F8jZj25mLf9EjgICrMImy2sExShT6OgSVAoSKE0nP2BNdlggLZmA9KIP61HeXPLpy2QyFbI5cgES8MboxGaM9BSz0HrYT411AjaSGLImXPf5/Wxl/DidD7sFaWHJMmHMCm7fTswKrkPvr+igJsEN5GK2WlZJmeUIGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HJHhCtlu; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HJHhCtlu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741843200; x=1773379200; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QnZI5g5/imwILnMF97Mve/8kvZvqDgLUw+ieihDhkwQ=; b=HJHhCtluBmjjI9xQRq4GH70btMfLu1Uq4P7bWk6r9QpBpih9NcrYPlsj 3o0n0mROrQouC9pMGcQigbQnygT86Qm1hQNyUczII+pfO2qhN266i1y2W Vgt66LdssCRUf6eKHjIObSFvNBITBX08wRMBls4MuWAyZuAaUJDTqjdzY NAGaYzdP1CcWqnMEDeN7l7ahIFFCFydzHZ3NH88bfbqHj2Pk7dY5rCQFb nWdUxKqsnyH1Yhf1DWvR5FVrEPez0AD67FWdxMcLgO1Ex1i2z2Yene59L eoV58v9H+rBK1q9+rwleBCL7dNJYJmAhobW9tQUjT6Pr7+Plxn7eTrTot Q==; X-CSE-ConnectionGUID: pLHF7jHeS+eGkBVT4yyX9A== X-CSE-MsgGUID: 1Z83jiZRQEWxLaJZn0EApw== X-IronPort-AV: E=McAfee;i="6700,10204,11371"; a="54323713" X-IronPort-AV: E=Sophos;i="6.14,243,1736841600"; d="scan'208";a="54323713" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2025 22:20:00 -0700 X-CSE-ConnectionGUID: XR5O9DQ5SRSbJswEMqKKjg== X-CSE-MsgGUID: wVWPpc6xSDqaAT93RROwdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,243,1736841600"; d="scan'208";a="151807139" Received: from allen-box.sh.intel.com ([10.239.159.52]) by fmviesa001.fm.intel.com with ESMTP; 12 Mar 2025 22:19:57 -0700 From: Lu Baolu To: Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian Cc: Dave Jiang , Vinod Koul , Fenghua Yu , Zhangfei Gao , Zhou Wang , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Lu Baolu , Jason Gunthorpe Subject: [PATCH v4 6/8] uacce: Remove unnecessary IOMMU_DEV_FEAT_IOPF Date: Thu, 13 Mar 2025 13:19:51 +0800 Message-ID: <20250313051953.4064532-7-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313051953.4064532-1-baolu.lu@linux.intel.com> References: <20250313051953.4064532-1-baolu.lu@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" None of the drivers implement anything for IOMMU_DEV_FEAT_IOPF anymore, remove it to avoid dead code. Signed-off-by: Lu Baolu Reviewed-by: Jason Gunthorpe Reviewed-by: Kevin Tian Acked-by: Zhangfei Gao Tested-by: Zhangfei Gao --- drivers/misc/uacce/uacce.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c index 2a1db2abeeca..42e7d2a2a90c 100644 --- a/drivers/misc/uacce/uacce.c +++ b/drivers/misc/uacce/uacce.c @@ -465,31 +465,6 @@ static void uacce_release(struct device *dev) kfree(uacce); } =20 -static unsigned int uacce_enable_sva(struct device *parent, unsigned int f= lags) -{ - int ret; - - if (!(flags & UACCE_DEV_SVA)) - return flags; - - flags &=3D ~UACCE_DEV_SVA; - - ret =3D iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_IOPF); - if (ret) { - dev_err(parent, "failed to enable IOPF feature! ret =3D %pe\n", ERR_PTR(= ret)); - return flags; - } - return flags | UACCE_DEV_SVA; -} - -static void uacce_disable_sva(struct uacce_device *uacce) -{ - if (!(uacce->flags & UACCE_DEV_SVA)) - return; - - iommu_dev_disable_feature(uacce->parent, IOMMU_DEV_FEAT_IOPF); -} - /** * uacce_alloc() - alloc an accelerator * @parent: pointer of uacce parent device @@ -509,8 +484,6 @@ struct uacce_device *uacce_alloc(struct device *parent, if (!uacce) return ERR_PTR(-ENOMEM); =20 - flags =3D uacce_enable_sva(parent, flags); - uacce->parent =3D parent; uacce->flags =3D flags; uacce->ops =3D interface->ops; @@ -533,7 +506,6 @@ struct uacce_device *uacce_alloc(struct device *parent, return uacce; =20 err_with_uacce: - uacce_disable_sva(uacce); kfree(uacce); return ERR_PTR(ret); } @@ -596,9 +568,6 @@ void uacce_remove(struct uacce_device *uacce) unmap_mapping_range(q->mapping, 0, 0, 1); } =20 - /* disable sva now since no opened queues */ - uacce_disable_sva(uacce); - if (uacce->cdev) cdev_device_del(uacce->cdev, &uacce->dev); xa_erase(&uacce_xa, uacce->dev_id); --=20 2.43.0