From nobody Thu Dec 18 18:01:32 2025 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29A6B8635C for ; Thu, 13 Mar 2025 02:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741832402; cv=none; b=f6cgbFaAl4EklMbNq8r4vNqkZ5CGDZQXNhKi6os6I6x1sjVgoJCzuNrz7+L3+V4d0jl9vBjQmy7W3dOfqCzW+fy40fiFgJiABVUzcPZhSRaGMvVNWwfm2O4ueDQwC0Tp1aOdN9Yegz3XyzCsRSaEFPhEOnCIkuFES3ABfWX2Oew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741832402; c=relaxed/simple; bh=/aIPWqp9LXKFEOXp2hDhwWiOmfrCgTzlcuMg3NdcVgE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V1YBoC+Zav8de5UPtgi9aBSJ2ubPgkxQ47M9HPAZvsi/yCFhtae9dZxLpX4bze+voDnqY0Ej1YWAuY8+2YmqXF1J2lwP0T9AqZktupLCLU2jaiSKliLGAR/77XwTIWT6g8C25++yDxe4JpiDGTRjnprHfKPCbbn+VERSMCJGmPg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VjlRCPI5; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VjlRCPI5" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2ff694d2d4dso914793a91.0 for ; Wed, 12 Mar 2025 19:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741832400; x=1742437200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rM07y6mRejtfGVMen1h/wSs59kI5KFRRXlr+zYZ8+Iw=; b=VjlRCPI5G5euMkcxcEeVHbVaK3ND0OB9kVG79Mg7thZhquMNRHs3ncUUZF/CK4gFrP yeC48vG9mQ8d0MEYOzhkUYpcQfD6TUa/Heu4MPhUEJkaclNU1P+SHYmZD6S9ScVFKhOr fQk5cPbv+TbIrmGDZ5c6bjUSs+3+czGmX65vJgGz5/ADVWnHFZp7yVr2EVV9ZDbKQXeY VCrw6uyY3E09im07taJ1g+8VZgzh3D28ljDmOnBpKiUG18pb/PkDxh1jKjSMgakhBhEs PR2DASvSgxWnVl8tuVLyt44cPNZ3DcaB0w1mSefqaoiB9Bz5Z+6vDtd3i2AI3qsq9uz9 NsXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741832400; x=1742437200; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rM07y6mRejtfGVMen1h/wSs59kI5KFRRXlr+zYZ8+Iw=; b=V4KeSnh1zRLg3mkTU44G5IDUXm68d1tIKcX+MZ5zEkdiOVb89bRtdrEmRnSzVqToSK 3uKryvmTRZF9cxtP8nIiO58uwsEKZUHnp3yMcQ1MexTHOu4ijEn5jHflw5CV8nWgwqly ds0Oj+IqIufnyysydm/iIREUgIuOs4z6ooV6Vp8kvDpR3v4PKL87hLghLp+JkhuvTt+1 u1KGd4IBoGxt9U/W/KykrkcU8o4v+c7r5oCstjEfKcjrlDoLTWRL8jDdM+Xi65A4R8yH G3sd6AjapwxgbwKc8IyWCpfxr8ngL1HH076p+DX91Wg779FHxijOHYjpooqvLo+h/ri4 RjmA== X-Gm-Message-State: AOJu0YwjUVkamgSrEI/pakx7Q3Wno/4xK852wuGJlrebYJub8QQ6uAoo KmiimD/xcqfb8/u43+t+EPQb1yvZM4Tucghd6syeyC1KVxM7HV6E7qERaAkW X-Gm-Gg: ASbGncsBTqwfYegqk/MY3PmWRUFyAIIwHLrS2+4RHPOHIfF7Iy/KDcjxyhW2sDyut9H jYsWOxZECCcmPXYtTZLR6ZeASmyqAnGbsrEfpZmrQ39NvGKBC/OMaUZbvp3TKmgkvevoDOdgxcD GtOHZuOY8vMElioMKc6N5DFgosAbqdpv0pgui7HBVwagCdXy3/wQDAkDUKq1+inKBTuL5EJGyDe 6u/pWphKAl/iw241EcWAfJtx/7XqK5y3TsvS4UbkA/y87NDWX8R+34x+oJzdlbSmUrpurQPWOsA Bshj+hLiigQH3IxIcSCl8+zlmy3L1vmVrMCVltMabKkzoParOHPX6U4= X-Google-Smtp-Source: AGHT+IH9h4gO1h633yHabDi56gUwUKc/1ei4QrFAgLV1x3b/3cKCpZ3eVwq4OVI4qIBzDVM8XCyTpg== X-Received: by 2002:a17:90b:164f:b0:2f2:ab09:c256 with SMTP id 98e67ed59e1d1-2ff7cf13a9cmr39914901a91.33.1741832400202; Wed, 12 Mar 2025 19:20:00 -0700 (PDT) Received: from localhost ([216.228.125.129]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-301182181c3sm2651251a91.5.2025.03.12.19.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 19:19:59 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Yury Norov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rasmus Villemoes , Charlie Jenkins , Alexandre Ghiti , Samuel Holland , Anup Patel Subject: [PATCH 1/4] nodemask: drop nodes_shift Date: Wed, 12 Mar 2025 22:19:49 -0400 Message-ID: <20250313021953.86035-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313021953.86035-1-yury.norov@gmail.com> References: <20250313021953.86035-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" nodes_shift_{left,right} are not used. Drop them. Signed-off-by: Yury Norov --- include/linux/nodemask.h | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h index 9fd7a0ce9c1a..b1a26ef5912e 100644 --- a/include/linux/nodemask.h +++ b/include/linux/nodemask.h @@ -39,9 +39,6 @@ * int nodes_full(mask) Is mask full (all bits sets)? * int nodes_weight(mask) Hamming weight - number of set bits * - * void nodes_shift_right(dst, src, n) Shift right - * void nodes_shift_left(dst, src, n) Shift left - * * unsigned int first_node(mask) Number lowest set bit, or MAX_NUMNODES * unsigend int next_node(node, mask) Next node past 'node', or MAX_NUMNOD= ES * unsigned int next_node_in(node, mask) Next node past 'node', or wrap to= first, @@ -241,22 +238,6 @@ static __always_inline int __nodes_weight(const nodema= sk_t *srcp, unsigned int n return bitmap_weight(srcp->bits, nbits); } =20 -#define nodes_shift_right(dst, src, n) \ - __nodes_shift_right(&(dst), &(src), (n), MAX_NUMNODES) -static __always_inline void __nodes_shift_right(nodemask_t *dstp, - const nodemask_t *srcp, int n, int nbits) -{ - bitmap_shift_right(dstp->bits, srcp->bits, n, nbits); -} - -#define nodes_shift_left(dst, src, n) \ - __nodes_shift_left(&(dst), &(src), (n), MAX_NUMNODES) -static __always_inline void __nodes_shift_left(nodemask_t *dstp, - const nodemask_t *srcp, int n, int nbits) -{ - bitmap_shift_left(dstp->bits, srcp->bits, n, nbits); -} - /* FIXME: better would be to fix all architectures to never return > MAX_NUMNODES, then the silly min_ts could be dropped. */ =20 --=20 2.43.0 From nobody Thu Dec 18 18:01:32 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F239313A258 for ; Thu, 13 Mar 2025 02:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741832405; cv=none; b=QAybXvHFadop6NIZ2AXraBukJ1yEMH4KApzVe3BjXUF++JPx6UA38zmAUrMfyFaRUd8Ss/W9SulUmXvLjqAlUq3BNxhErJDHWxOb7maz2rEiZX+tnAwr3EA5q7kM1VYxtH/2Eb9qjZrdntGM+WDAVBTzv7i93yRcVv4CsIX8C/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741832405; c=relaxed/simple; bh=RPLcgs6LiHSA5B9TFpPC14NZ5A6TQ2jAShGjBl+sfKM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HQ+rE1YL3UdsMBNCqTDDcpS1dVJcojO+ShK1Z8qWqtDeBqtzFTBOQTIk3W+bu+s9j+CAbkQXhr2qjCLEq7ULVPV5YNTwMeyNs+MG2RZ1MffpI26b0TPFekOlYmA5IqsIRzb0JFu+WraQtlGBrq2q7ndJChbfz57mMOyjs7vtQ1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eS36z7AD; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eS36z7AD" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-22548a28d0cso12780025ad.3 for ; Wed, 12 Mar 2025 19:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741832403; x=1742437203; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JYhELuNh/H+0ZU3yo6Tx42VZD/1lCOeZE6fYEs5O9r4=; b=eS36z7ADpN/bL4Dtz5RJhNksm3J0ExebFISEPLumciTNC1G2EygWP0NRg/N8f+Zjni EG4bYK8eZYQsjsvLlW3u7yjuPp4gqUd27LPCPshrIEXjQ4dy7X1Re92NK93TL8+V0knL 89a1ODYWD8Akc7Mv/KhfjcW+gi01Hi+yRhjAFkgWU2PBrk/Hoe3zAJV3a4XALsTCAhbk YHMwYXImvHJdwN4YzmZdFbZUYhAtrkRfRHVfSQwmQCUkFI/sIZgTlT3dEQuLG6NBIdOY i7+VquBVAA/Jpru+ReL70Brox04/CkHnBiLNp5LKvQ4X/OesgSkglHaFz0Rjd0PIz6IP CWew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741832403; x=1742437203; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JYhELuNh/H+0ZU3yo6Tx42VZD/1lCOeZE6fYEs5O9r4=; b=q+j8bxVDARf2xT2xRawVqKtswFPzPtGYzFmIO8ELwp9xfL9xmjpjBD13WcgTEDFWOf KU0iI2FdJ7iuSezCyMan59G3woVH3ysoAl3b1kBkLG6nRM2rCSYuC6aL+wQW9TGZYrnh RduoCeMsmjtGVRVTEBSUJEp9kr9JlvhLspEq99UPaAQNCN8oNAXFhsLpv/PDkGiCe5Ga PBqv0oyrQ6VXfsnpLMTmowTaRvOUmGA/2yhoBVkLBxPdc940Mzg61LUrOAnMQqikugKj cDfC9V/9c3REfNGYtrx5iKLYmPVkSsReg/h6l334WIAqVNYs28ZzLedRvJdW6FwUN01D RBpw== X-Gm-Message-State: AOJu0Yx0Z1hMd2T55XYFC7W/ls7RYHyF43f1C7LUotjiwlnq69fcGnct ua5YFJp006eeBeDb0okm5VhmJFBOZuUDecXB/whnvIJ+uRsLsAv8q4jCiAhl X-Gm-Gg: ASbGncu2+mGMFCDeAEJ8H+kmgMIdOlavzwK5Pq82cY4zpP248lZ+YWH5o9e+73VDTmX H3b6Riw1IKTF8I67h2L2/IZ79IS6xtfIeJ3VRUMiUL50fH3xYiSDEqJbkwIOAxdAJaEzHiL/0MF 0BTIvKXEzhVkMZlxMs/5BFK8CQJC17q+H2t3AEdtVr2XwBTsOHWsYdH1EgU6bfGvpWptjNYDdiC h8RWEl0/H9IAOZGtb9Rbd9ZJrfCHN21QczPtK06LS0fcj89DQ6eoxvV8HhNrEg08PrVGz59k4Wx yLVCvPXogJGo7hIiJJgYZ6RI0z48gpU3pgtat6ZHinqg X-Google-Smtp-Source: AGHT+IHcxiSU+kMKPherfsGG+ddx6B45jAAx+w+XqsI7BCKH7gfYWRuQvwRSvxc64ktLopvBtjMDRg== X-Received: by 2002:a17:902:e80a:b0:224:13a4:d61e with SMTP id d9443c01a7336-22428c0a43bmr308389355ad.51.1741832403015; Wed, 12 Mar 2025 19:20:03 -0700 (PDT) Received: from localhost ([216.228.125.129]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c68887fcsm2696535ad.39.2025.03.12.19.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 19:20:02 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Yury Norov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rasmus Villemoes , Charlie Jenkins , Alexandre Ghiti , Samuel Holland , Anup Patel Subject: [PATCH 2/4] cpumask: add non-atomic __assign_cpu() Date: Wed, 12 Mar 2025 22:19:50 -0400 Message-ID: <20250313021953.86035-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313021953.86035-1-yury.norov@gmail.com> References: <20250313021953.86035-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Similarly to atomic, add a non-atomic version. Signed-off-by: Yury Norov --- include/linux/cpumask.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h index 9289d4612170..f8caa025c6bb 100644 --- a/include/linux/cpumask.h +++ b/include/linux/cpumask.h @@ -1074,6 +1074,9 @@ void init_cpu_possible(const struct cpumask *src); #define assign_cpu(cpu, mask, val) \ assign_bit(cpumask_check(cpu), cpumask_bits(mask), (val)) =20 +#define __assign_cpu(cpu, mask, val) \ + __assign_bit(cpumask_check(cpu), cpumask_bits(mask), (val)) + #define set_cpu_possible(cpu, possible) assign_cpu((cpu), &__cpu_possible_= mask, (possible)) #define set_cpu_enabled(cpu, enabled) assign_cpu((cpu), &__cpu_enabled_mas= k, (enabled)) #define set_cpu_present(cpu, present) assign_cpu((cpu), &__cpu_present_mas= k, (present)) --=20 2.43.0 From nobody Thu Dec 18 18:01:32 2025 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B78513C81B for ; Thu, 13 Mar 2025 02:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741832407; cv=none; b=JnrqKJCdkkPj1ODfNHRvOulQ4/nqoBXmmPgW6AJkul9kde35UjAT1/xtuDlZrRbLHFMXXXJJH7NYK608ZQV9ZlUoHXVV7AXAEqqKdDUzjFLWmvnB3NLO+7attr/P/H+vBFSJ6zUV2A/+7s8wQzzqEYDqyuYCnHJVJ58krtHmYDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741832407; c=relaxed/simple; bh=YrooeLVFWs9fZicoPRhZ9aArw0E5gKkPFcEy+QVRPSI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DjVlx1mGaQ3LkKtR5qBwf+AC3QQGao5Jqu9v+Io85p6n6qHXSmWqIt6nWIgdrmXnJ27Z2hQrM+FdG4uK2B3JM5wCslXcqMp6D6Y+0rP6SdV4nbU2zP+URsr+zjk1UZ1UhL8lWPMF1wpsAawmgt483Ua8e/zCarkIcIeJ37Rmhro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iu2CqXNV; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iu2CqXNV" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3012a0c8496so826252a91.2 for ; Wed, 12 Mar 2025 19:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741832405; x=1742437205; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kLw67BqWA0BIkPETmcHm1W/HkXtVEPs+aCbes5Kp6pw=; b=iu2CqXNVj/nuPpHG+v1rwUMVYBm2R3QWcprdF/J9R+sr+tWoaM5EjeqCRsrjCtYozG WME+DyU+V2TjnDpWnL/YhTqQXqsvipMhz9mdQ8sQmBTSAW9xpr7P8EZMLgATeqWg7NuN rI8rrI6/TBEI7Mci2l89dPL1gcwtkklH7dGAVxc2/YcEKmgQMYojgtY3WXW+ThT7kOBC EUbO40gHMY3/Zdx4RgynZ2119xbIZgT4pIaHiqQiUTxL5iKB6EdmQjtucYiFquNaqBbE harJJBfPWMOqqaP6twRm67r7sucfKQXgfywgRLg/MnHcJagNihxkrdpM1f9PG7fk09L2 jS3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741832405; x=1742437205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kLw67BqWA0BIkPETmcHm1W/HkXtVEPs+aCbes5Kp6pw=; b=SIiIChUxSmjLeUulGGggLpvRP8tyBcQqAvZi+wxcjnLto5hwLNQ/B5tadmEcJovZlS jMbR0P7x2WhuC4qcGPS9IWWxltpXGYUCqwBvNmpjWhpt9Da/3GmcJPpfK5q/v31g5LGh 3Ajj8Jp/CR96RWlGg8Go5eNdwNhagFf/RQa8WTHYRK8gSz7SEluKtW4B3EBoXUdQQdhQ 9RWXwuGcib2SYaMW/L7Dwz6C2bfMxHhQ/pKoDkZY9Mfj1b22WcgR70Fc5dBjD11cXAIb 3Xt/RmeAz4jy+nMcEUrbXDfrVkkaAQ9+Egyu8yAwzosVkIb/W2yaog3Hm/2G1cM6LrvM KXlw== X-Gm-Message-State: AOJu0Yw3LgT+lt8zhTn0zuv9Yt5eql+98ac4LZyFwlnE33ibBtkEF02U rTRnxuLVq9+TtbUZKzdAn5DqFAM/eEutoe5W1hPwxIkcngHmP2tiN5My1z5v X-Gm-Gg: ASbGncvnpZ5vTUMDEQCTCz9dfGZv+eCiNWVYskOUMPA3rzefwPzhN/fYubU+PhWTwlw +QBUt8lsJbW4vZvB6kU5k7a/HW1UoXnkY1r0SrYVbij5zGlDkJlhw5/HaL1YLAmOlpWwuKEWuJq qJ17V2XMAnYr+hg+Lsrthf3by/Xmrumf+jvk8xO1xvWFy99Bf0ndFi8HX5LyruJok5OsVmYSDkr 3RSHyCuQPansAJDA9CsZ042gq5StkdQ+BeNL6Q3sb+O0Ux3f9QbLAQY33/2ldBlosJDD88lU+rO uY1K1RvdYDlTQMnkpVB2K3AsfeDr5YgpcjEIzbqK/7hY X-Google-Smtp-Source: AGHT+IGd/HsBjLkc68NP6moc+1YM/RCLuYwV9ycuTAbmTeB62jDlEwfr3ThGTS9nnEwZw2LwUvK2WA== X-Received: by 2002:a17:90a:d605:b0:2f9:cf97:56ac with SMTP id 98e67ed59e1d1-2ff7cd3ebcfmr41200798a91.0.1741832405575; Wed, 12 Mar 2025 19:20:05 -0700 (PDT) Received: from localhost ([216.228.125.129]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3011809f308sm2668096a91.0.2025.03.12.19.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 19:20:05 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Yury Norov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rasmus Villemoes , Charlie Jenkins , Alexandre Ghiti , Samuel Holland , Anup Patel Subject: [PATCH 3/4] riscv: switch set_icache_stale_mask() to using non-atomic assign_cpu() Date: Wed, 12 Mar 2025 22:19:51 -0400 Message-ID: <20250313021953.86035-4-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313021953.86035-1-yury.norov@gmail.com> References: <20250313021953.86035-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The atomic cpumask_assign_cpu() follows non-atomic cpumask_setall(), which makes the whole operation non-atomic. Fix this by relaxing to non-atomic __assign_cpu(). Fixes: 7c1e5b9690b0e14 ("riscv: Disable preemption while handling PR_RISCV_= CTX_SW_FENCEI_OFF") Signed-off-by: Yury Norov --- arch/riscv/mm/cacheflush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/mm/cacheflush.c b/arch/riscv/mm/cacheflush.c index b81672729887..b8e96dfff19d 100644 --- a/arch/riscv/mm/cacheflush.c +++ b/arch/riscv/mm/cacheflush.c @@ -172,7 +172,7 @@ static void set_icache_stale_mask(void) stale_cpu =3D cpumask_test_cpu(cpu, mask); =20 cpumask_setall(mask); - cpumask_assign_cpu(cpu, mask, stale_cpu); + __assign_cpu(cpu, mask, stale_cpu); put_cpu(); } #endif --=20 2.43.0 From nobody Thu Dec 18 18:01:32 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1823014658C for ; Thu, 13 Mar 2025 02:20:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741832410; cv=none; b=rKFD8kBPxz/oI7V43pxkhql4xy59vlG6gHUhywEqMvHMAEu1h1UTgUGXlyxwnkvAva60U/zRamRmoDPa5qKy6W1GRwCXhlymciW0jL7vylkVYFmirWa9KyWMjyF4stW46gOcmZ9QWPzl6hyEPDIxLxG28PKd72tCLHtjD1n7BHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741832410; c=relaxed/simple; bh=l0rwUcCJ2FyNJ6tzvfLStV2z+Q0pi6N7ETW8/F9bHwE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T9oT2aax5rezwueRHFYTP24nn38njcjzMhxWcP8aJSKWXCbTRiQxo5dH3I2sQoA7ABSL/v6GYxmdXwYdKmfjxTM5tYj/AKR/D3d4rlNCV11+eYnMobSCQJ7tmF+N8QV5ScLSk1hv0btiRD5csWecT+a9tdzngzGebGVaBUwU2vg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QIUvvNG+; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QIUvvNG+" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-22355618fd9so8893945ad.3 for ; Wed, 12 Mar 2025 19:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741832408; x=1742437208; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xhrJ8HGtR8k3dxAA+AgdZEOnZohoN1a96l9KBcI/XnA=; b=QIUvvNG+G1NqiJ4bw3QJvmOFw2DIjHioijgaZzPjWRJFvUYtX+GK8Vn8LGcC3LBerf 9TSpRRXOViQ+x1e6jC61zcxfvDsBOptjJi3aIUDAeCeK2OBcfv75m+22a56bK90sKEa3 AurjB1T9LvpepiBFV2DccY25ueBT0Ef/qEwSvgqokKSt2hDyIx8dPM5OxAXcczqnSunK SJ2+VHYerXalt6XbODcmhbLm+Cw4VJdLc7OLtn7TjFfHgNXzkLpTiGmPgASUDwnDg1Dd anKmtP31QlLB2RR/p2IV1K5dsPNG2ma7jj/Xihklk+Xby2Wz/0FHEO/j48BpKe1idReH Wb2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741832408; x=1742437208; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xhrJ8HGtR8k3dxAA+AgdZEOnZohoN1a96l9KBcI/XnA=; b=jQtTp9TU37o3ZCKEcSg5zZ8QDsk3fTOy/b6B30ag2HTknb3phlSuHs+BKzwKyMRwGO zHsAAwd/+u9LX4920cAhkwe7hSrXqkkV5MPDygMKguE4rN3SoTLIlvLI+nbGP3L9azXb xze6kjvaIE8QXnwYt1SUCXJS5NUoirS/e21zukCi9pSTB4E/5gFwaYk6h32s2QRB/Zec v07JUGQ7GJWrgHAwqXpoN6togsiJ9Rb8CvlTQiOp1kAFbiHc1wIZ8getCBlKS9siUDNi 0YP3RCvqnKa17JWN0uhqxBjfw75Mm8LUlN1fGmeXAJeZ6VZi5y0kjv59RlbsFe/veHgy SShw== X-Gm-Message-State: AOJu0YwNse8OtKpvuxFrzOMyy7mdFEO9UjeEGpO5481ybdPTfp5LDNqz Aj6aq/u2062pGvbInKAFutq863YPAqWU+AdD491OeFElDprJjRfEc4Z4Iz7c X-Gm-Gg: ASbGnctca+lmBXzGa4EvGo69WN94oQsIP7yBW21OxrmSZpUCYFizktASiIiB6mOEQ7r 9eFD95wM8cB2/Yp69/4vuu14ZNNaJrhUlCHnxmUWyWQNUOHMdDImbR6I40Bs5soHC/LviVw+vV4 3zibiKf+0+k8t3Q2RBVLvMnDj13GWmC6KdaZn1S68A7c4/7o6bucuEeiNBemud3fUY27an5EhrW YupRCPtQNXtGWqGM1dJc5HTpi89QkPOiAgsHeiil1ONYg6UNrHRlm58rD8X4rKh4x+j1rYKYl3N eyHhUnFQBZxkkmtkwsug40e/vq/MYvQS7QWveh26xrj/ X-Google-Smtp-Source: AGHT+IFcQfoNRBmW4J0WVDBuE/gGCx1w5h+8C1HXlvpyeZVWWTFjP7qL4lXzgdHuMvZqdEU+k1TZgA== X-Received: by 2002:a05:6a00:a09:b0:736:ab1d:83c4 with SMTP id d2e1a72fcca58-736eb65d07amr13574673b3a.0.1741832408295; Wed, 12 Mar 2025 19:20:08 -0700 (PDT) Received: from localhost ([216.228.125.129]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7371155934asm232634b3a.56.2025.03.12.19.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 19:20:07 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Yury Norov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rasmus Villemoes , Charlie Jenkins , Alexandre Ghiti , Samuel Holland , Anup Patel Subject: [PATCH 4/4] cpumask: drop cpumask_assign_cpu() Date: Wed, 12 Mar 2025 22:19:52 -0400 Message-ID: <20250313021953.86035-5-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313021953.86035-1-yury.norov@gmail.com> References: <20250313021953.86035-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit decde1fa209323c7 ("cpumask: Add assign cpu") was merged bypassing cpumasks reviewers. It adds atomic and non-atomic cpumask_assign_cpu() helpers. In the same merge window, commit 5c563ee90a22d3 ("cpumask: introduce assign_cpu() macro") added the same functionality. So now we have it duplicated. __cpumask_assign_cpu() has never been used since introducing, and because this series reworks the only user of cpumask_assign_cpu(), both functions become a dead code. Signed-off-by: Yury Norov --- include/linux/cpumask.h | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h index f8caa025c6bb..ddeefb2744b1 100644 --- a/include/linux/cpumask.h +++ b/include/linux/cpumask.h @@ -558,22 +558,6 @@ static __always_inline void __cpumask_clear_cpu(int cp= u, struct cpumask *dstp) __clear_bit(cpumask_check(cpu), cpumask_bits(dstp)); } =20 -/** - * cpumask_assign_cpu - assign a cpu in a cpumask - * @cpu: cpu number (< nr_cpu_ids) - * @dstp: the cpumask pointer - * @bool: the value to assign - */ -static __always_inline void cpumask_assign_cpu(int cpu, struct cpumask *ds= tp, bool value) -{ - assign_bit(cpumask_check(cpu), cpumask_bits(dstp), value); -} - -static __always_inline void __cpumask_assign_cpu(int cpu, struct cpumask *= dstp, bool value) -{ - __assign_bit(cpumask_check(cpu), cpumask_bits(dstp), value); -} - /** * cpumask_test_cpu - test for a cpu in a cpumask * @cpu: cpu number (< nr_cpu_ids) --=20 2.43.0