From nobody Fri Dec 19 03:04:55 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45BC6243951 for ; Wed, 12 Mar 2025 13:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741784983; cv=none; b=L2J0j514ujQhRQ+S0mwj0V5NmqivCxlp6yRJAo097WT4wdbkbTfzlIZF8WQYkL0YsBop6lL/vaG+HD9xFMK4alytotjmLaNiJLWn/yKAVbAi5SVeH0OyK7v8JlmC45JW0weNTxKNNMPVBck02vdF+2cjDspAHiRnf2dp40yhTgI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741784983; c=relaxed/simple; bh=ueLLfb2g6ooAKzkCZNWnsaYYsRz9CK6dnjSm/F8mDd8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FGb0CVK1rWg5B6X05FaeFDCZGwzZO8QSLlV4rii5uX+E7tBQ6NtE34lOdSqXhIMuZrOagqGi8zW+ohUirgqFC1AMYqLVaW6mAem39Y160LmakJcTtyCnH/ce+RPbaVtHqQxQTRKhygWosHOQhMs3k1cqo97i173RPYTj0g+QSps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=furiosa.ai; spf=none smtp.mailfrom=furiosa.ai; dkim=pass (2048-bit key) header.d=furiosa-ai.20230601.gappssmtp.com header.i=@furiosa-ai.20230601.gappssmtp.com header.b=xXgbPt2l; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=furiosa-ai.20230601.gappssmtp.com header.i=@furiosa-ai.20230601.gappssmtp.com header.b="xXgbPt2l" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-22185cddbffso14742675ad.1 for ; Wed, 12 Mar 2025 06:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=furiosa-ai.20230601.gappssmtp.com; s=20230601; t=1741784981; x=1742389781; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0xE5xU4H97yAwT+GSMKnaXD9mzHnmpKqghu02U5UNnw=; b=xXgbPt2lnIl76IcX7VCKYy5orOCANDofbFa9AXKD/CCXbU2BjqocYnQVK+gAcUi7QK yW26EpOOJDdkrn305NcS86z5X2/LiLF2w8KLI5m/V8I1hi6281RlsgxfYX3ktgLSwp7M hr5/1nGfz5h4EZhQk3AuPMudso3ISkP/HybBPnY2DKNcalglVVL7jgyVfonfv+k/qdVZ DsasTcAritcWqq0jkiOGTKlSZ6fxad/Y6Yf3zhOw7oalKvwlL0hcafWKZZxuE8BXUA92 bMwhzZJleBZlsjNN5jF7lWDU1xOEZMezmtVmdVvin1qrndE2IbLU35Kk3Z5oPjEt7AhJ kqCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741784981; x=1742389781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0xE5xU4H97yAwT+GSMKnaXD9mzHnmpKqghu02U5UNnw=; b=lgoHgeHWIiUtY62sq473jYy6+HMUUNYCf/8sIPewODV8/TP7MyfZBW84UaT8zd+et4 8/i2vRMFLulsAMU49xZeSaNd2/X8QXDthe6oUhcQU7SkmLIsTO4jNrb4Z6c4OfvjKsOj vFVXP6G/I1zzu7CRzB8if5MyslMn+eRizAurz72h/A69vBo61x0FVMp6ozG+l5zCOG/B hIeQxfR+rwPf3UKyYXCQd7WLcAPU3c+kL+ZGErapitakk+DwyyuqdIT65IKmxMjd8roG sOjoiEfYBYf0YegBNVUkgHrD8IFPn5t7Fy5pW108dUh7EoTc56GeXHLytRIdFW6loU0b AG1A== X-Forwarded-Encrypted: i=1; AJvYcCX7S/Rg9NbcysXDsuBFi6fvKE9Hb/ymxVgGVHXlBTfeDL7B8dxqwtIdYmhG8E3+Fu2uBqmnoS+mfwVlP8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzDtyEjBysgZbh3fqEevUZxDLF3onL2szaAn/QsW5qzuLRR8oEP OhgsKf8nBk3KSkVjL9lIFoQMLeerbLnqKaNGxkyezaeAS3NpMeM3PUNuVynwRmU= X-Gm-Gg: ASbGncuAk1GMA1dq+mEtLlzNBBId2q1H5WCymBfvO1okaU/R9Nlw4YeFBXz4c7wdHCn FA53O7VN1sJvK9RbT1Iiy0gjsYJyc9diSiCuOy6oMIV2+hJG+tIWcTHpoBuef7MXhqjgbudDxv8 yvHTiAZ7xu/xig8qHky4WDSzeAI0CZKP04rH5lvjUZDL1qXdK+cXVH68k326arxDKLh76ubQ/4q kcrzWwZN75SB9FsT9RLV8M9KphQQBUPDfhJznd6mr/7mFDip+JpTWia/wAyQrtm4BlO2KUhm8d8 tPcd2vxutZFH64oqc6N3pLI5aa8MQs5cUCxyUuGfSsfkJqjfyUNRnMB8kO40gxgPZeOz+P5fATr MvS2u X-Google-Smtp-Source: AGHT+IH7VkB+NmesEyRPaK+5JngGbkotuud4dSkt+bqgpb7eOgAc+UGan0lPxKxbcp4ppjOow3D4eA== X-Received: by 2002:a05:6a21:38c:b0:1ee:c598:7a87 with SMTP id adf61e73a8af0-1f58d73a925mr9693203637.14.1741784981396; Wed, 12 Mar 2025 06:09:41 -0700 (PDT) Received: from sidong.sidong.yang.office.furiosa.vpn ([61.83.209.48]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af5053a85c2sm9432299a12.10.2025.03.12.06.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 06:09:41 -0700 (PDT) From: Sidong Yang To: Jens Axboe , Pavel Begunkov Cc: Sidong Yang , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 1/2] io_uring: cmd: introduce io_uring_cmd_import_fixed_vec Date: Wed, 12 Mar 2025 13:09:21 +0000 Message-ID: <20250312130924.11402-2-sidong.yang@furiosa.ai> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250312130924.11402-1-sidong.yang@furiosa.ai> References: <20250312130924.11402-1-sidong.yang@furiosa.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" io_uring_cmd_import_fixed_vec() could be used for using multiple fixed buffer in uring_cmd callback. Signed-off-by: Sidong Yang --- include/linux/io_uring/cmd.h | 14 ++++++++++++++ io_uring/uring_cmd.c | 31 +++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/include/linux/io_uring/cmd.h b/include/linux/io_uring/cmd.h index 598cacda4aa3..b0e09c685941 100644 --- a/include/linux/io_uring/cmd.h +++ b/include/linux/io_uring/cmd.h @@ -44,6 +44,12 @@ int io_uring_cmd_import_fixed(u64 ubuf, unsigned long le= n, int rw, struct io_uring_cmd *ioucmd, unsigned int issue_flags); =20 +int io_uring_cmd_import_fixed_vec(struct io_uring_cmd *ioucmd, + const struct iovec __user *uiovec, + unsigned long nr_segs, int rw, + unsigned int issue_flags, + struct iov_iter *iter, struct bio_vec **bvec); + /* * Completes the request, i.e. posts an io_uring CQE and deallocates @iouc= md * and the corresponding io_uring request. @@ -76,6 +82,14 @@ io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, i= nt rw, { return -EOPNOTSUPP; } +int io_uring_cmd_import_fixed_vec(struct io_uring_cmd *ioucmd, + const struct iovec __user *uiovec, + unsigned long nr_segs, int rw, + unsigned int issue_flags, + struct iov_iter *iter, struct bio_vec **bvec); +{ + return -EOPNOTSUPP; +} static inline void io_uring_cmd_done(struct io_uring_cmd *cmd, ssize_t ret, u64 ret2, unsigned issue_flags) { diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c index de39b602aa82..6bf076f45e6a 100644 --- a/io_uring/uring_cmd.c +++ b/io_uring/uring_cmd.c @@ -1,4 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 +#include "linux/io_uring_types.h" #include #include #include @@ -255,6 +256,36 @@ int io_uring_cmd_import_fixed(u64 ubuf, unsigned long = len, int rw, } EXPORT_SYMBOL_GPL(io_uring_cmd_import_fixed); =20 +int io_uring_cmd_import_fixed_vec(struct io_uring_cmd *ioucmd, + const struct iovec __user *uiovec, + unsigned long nr_segs, int rw, + unsigned int issue_flags, + struct iov_iter *iter, struct bio_vec **bvec) +{ + struct io_kiocb *req =3D cmd_to_io_kiocb(ioucmd); + struct iovec *iov; + int ret; + bool is_compat =3D io_is_compat(req->ctx); + struct iou_vec iou_vec; + + if (!bvec) + return -EINVAL; + + iov =3D iovec_from_user(uiovec, nr_segs, 0, NULL, is_compat); + if (IS_ERR(iov)) + return PTR_ERR(iov); + + iou_vec.iovec =3D iov; + iou_vec.nr =3D nr_segs; + + ret =3D io_import_reg_vec(rw, iter, req, &iou_vec, iou_vec.nr, 0, + issue_flags); + + *bvec =3D iou_vec.bvec; + return ret; +} +EXPORT_SYMBOL_GPL(io_uring_cmd_import_fixed_vec); + void io_uring_cmd_issue_blocking(struct io_uring_cmd *ioucmd) { struct io_kiocb *req =3D cmd_to_io_kiocb(ioucmd); --=20 2.43.0 From nobody Fri Dec 19 03:04:55 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F39F324A043 for ; Wed, 12 Mar 2025 13:09:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741784985; cv=none; b=YrXTUFH11NINnn0+TyRaMIjahRvOnOnoobimmU2Gxp4m9jdNn+ozk4wu+fJo4/T8RWXLjGGp9fiWYWLZtgu1WlH2DpMs5pM220E2rRP5lRctD1SJuxxNihh0n3ZXRXn1j4xQLByx2Y7j9PewHxfFiuZOe9PZ35L0hnRYE+aPKeI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741784985; c=relaxed/simple; bh=ga2LSmT61md5n2p7rdCucn4O99aWE/jCY95aOOLVTH4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BGtfojqux31zbvKaDrUMJ01J2Vu/Fcxm+m0aDw0I2MNx8U4i8sG3K5/548mOgNA9BCBGhKqIiM08714V5j3Tg5xzcH8GkPL2HkC28TOSH84QAt0aY4VC4RwyUPH0a3CFLFUwAHePGHvhcva1ayyyKK4gBmQaqHDI4zW3ZTjiU8A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=furiosa.ai; spf=none smtp.mailfrom=furiosa.ai; dkim=pass (2048-bit key) header.d=furiosa-ai.20230601.gappssmtp.com header.i=@furiosa-ai.20230601.gappssmtp.com header.b=0awkaYd9; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=furiosa-ai.20230601.gappssmtp.com header.i=@furiosa-ai.20230601.gappssmtp.com header.b="0awkaYd9" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-22337bc9ac3so126921825ad.1 for ; Wed, 12 Mar 2025 06:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=furiosa-ai.20230601.gappssmtp.com; s=20230601; t=1741784983; x=1742389783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sf5Mim88v1zsUv2CF9zajfgiTTZumS4UoXrfg/qlMyE=; b=0awkaYd9We31IKpPedZDh3uvKNmfLqn9OtPI56bX2wSvlrJjNNEEkBqJ6EMF1bOdJu 81ukfkIqH7bM5vRz/c7MeCLDiYJdDotmswVhUcZnF/Zyr7rnaj3NF0tnrbBVJJKFJqRk 70P+fNaZNNZfrMl6arvVrn49RFaDB/1zmdl94VdKWhhCuBcFlBatDjWz9+VqaQqbi0BM WZuX72wNZ74DnD1eruYlAWmZgjvW+T6Sd+aC9Sj8eM6HOCZzeezgoGH/nFOQO+OlHAcX htWQG2U6cbNI/370ofEH7CyeAkZh4C+ZJOQtmkx9rsGvTPLfAYbGA3pdVDsiGtWjAA5s +l1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741784983; x=1742389783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sf5Mim88v1zsUv2CF9zajfgiTTZumS4UoXrfg/qlMyE=; b=gpYmaNr6Krcxxo88/eNXlgEWDqCM5N2KXRlrs6k/77A7Lg0AEguFAGwb5rXVp2c3gN or9DWKRpSY5Ba1L7ItK/Pu721NBGU/HOhny5MdW3GQZTDAsGdBmeMkOcoWs35iJTltXH qlcrmFVI4y9cTmAceh2gH5AIGhJliqDWj8CNpLTDwbfWm5+XEF5P5/ZfdhVp3NaMhicv lOJ6Emlh5RnFSu7LYgXzydkGpp4G6eaZkj3aSh3j8rgNZjD1eyrurL/rYFFKdX97aCfV Sbj/h/2VGdNgarTTk+Y0TSW4R/SJbNm8nq5hCHqgww5KDwnW9sd7Ub52dsRAlZdFaPue pquw== X-Forwarded-Encrypted: i=1; AJvYcCWU9Cx2ksruv3q/oviFVNZ479bbZOXRlHzejqU9CqFa2ER++HK72PwextjBVEiBZVnxTZznLCzL2WzHptU=@vger.kernel.org X-Gm-Message-State: AOJu0YzLd5mZ7O7WYAt2OdPU2g2FWRrMq9FzicBrypsSy8Mb0qGp5KEU ZV5H5FoFvxOnMqpDgXtochk4yasKJsqdeKDWZKvtIVJx3OJXOIi2NndFsPmk+zgOSZfIAdiIO+b 1 X-Gm-Gg: ASbGncs4OVVfJQ9u5lC045cCy2QnYT4JhI+xjoAoBmtJPD0uDUNN+OvgEO9v2XLVCzv rbqKwZ9+HQfnRK97GBEK4MXI3fAHPX6jiCE976S0Hmh162WortN/G7oNsdwX/qdcrHOUPk8LlZW d2poQm4/ATrpM8taAf51m9frJTNA+xh0NWeCDbpNZnnOUKYtFwCD/xDZh7eoQU1VkQwy7Ynnsg8 DHUSZIUveV/kFg1r/duXRX1f0V3ZXSaTl+0wxsgdgHbTvaj8GTC/B/uuUuMBCfF522RzlVB3gX5 xnXVqljC15Kggo94PrVA8wpHZEvfxyzRjyPmZ7Y92HYoAuA84Wk1oitOyG1VOmRDBCDDXMFu7Md 5AHpw X-Google-Smtp-Source: AGHT+IHINSsNMXDf/ujoGNsvP22wMUl9hboDvbpyzHad1RW7/6Vo+ySwFx65tyhXFD9eKYlgsO5pNA== X-Received: by 2002:a05:6a20:b68a:b0:1f5:619a:7f4c with SMTP id adf61e73a8af0-1f58cbb5ebbmr11897051637.29.1741784983366; Wed, 12 Mar 2025 06:09:43 -0700 (PDT) Received: from sidong.sidong.yang.office.furiosa.vpn ([61.83.209.48]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af5053a85c2sm9432299a12.10.2025.03.12.06.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 06:09:43 -0700 (PDT) From: Sidong Yang To: Josef Bacik , David Sterba Cc: Sidong Yang , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: [RFC PATCH v2 2/2] btrfs: ioctl: use registered buffer for IORING_URING_CMD_FIXED Date: Wed, 12 Mar 2025 13:09:22 +0000 Message-ID: <20250312130924.11402-3-sidong.yang@furiosa.ai> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250312130924.11402-1-sidong.yang@furiosa.ai> References: <20250312130924.11402-1-sidong.yang@furiosa.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch supports IORING_URING_CMD_FIXED flags in io-uring cmd. It means that user provided buf_index in sqe that is registered before submitting requests. In this patch, btrfs_uring_encoded_read() makes iov_iter bvec type by checking the io-uring cmd flag. And there is additional bvec field in btrfs_uring_priv for remaining bvec lifecycle. Signed-off-by: Sidong Yang --- fs/btrfs/ioctl.c | 27 ++++++++++++++++++++++----- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 6c18bad53cd3..7ac5a387ae5d 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -3,6 +3,7 @@ * Copyright (C) 2007 Oracle. All rights reserved. */ =20 +#include "linux/bvec.h" #include #include #include @@ -4644,6 +4645,7 @@ struct btrfs_uring_priv { unsigned long nr_pages; struct kiocb iocb; struct iovec *iov; + struct bio_vec *bvec; struct iov_iter iter; struct extent_state *cached_state; u64 count; @@ -4711,6 +4713,7 @@ static void btrfs_uring_read_finished(struct io_uring= _cmd *cmd, unsigned int iss =20 kfree(priv->pages); kfree(priv->iov); + kfree(priv->bvec); kfree(priv); } =20 @@ -4730,7 +4733,8 @@ static int btrfs_uring_read_extent(struct kiocb *iocb= , struct iov_iter *iter, struct extent_state *cached_state, u64 disk_bytenr, u64 disk_io_size, size_t count, bool compressed, - struct iovec *iov, struct io_uring_cmd *cmd) + struct iovec *iov, struct io_uring_cmd *cmd, + struct bio_vec *bvec) { struct btrfs_inode *inode =3D BTRFS_I(file_inode(iocb->ki_filp)); struct extent_io_tree *io_tree =3D &inode->io_tree; @@ -4767,6 +4771,7 @@ static int btrfs_uring_read_extent(struct kiocb *iocb= , struct iov_iter *iter, priv->start =3D start; priv->lockend =3D lockend; priv->err =3D 0; + priv->bvec =3D bvec; =20 ret =3D btrfs_encoded_read_regular_fill_pages(inode, disk_bytenr, disk_io_size, pages, priv); @@ -4818,6 +4823,7 @@ static int btrfs_uring_encoded_read(struct io_uring_c= md *cmd, unsigned int issue u64 start, lockend; void __user *sqe_addr; struct btrfs_uring_encoded_data *data =3D io_uring_cmd_get_async_data(cmd= )->op_data; + struct bio_vec *bvec =3D NULL; =20 if (!capable(CAP_SYS_ADMIN)) { ret =3D -EPERM; @@ -4875,9 +4881,19 @@ static int btrfs_uring_encoded_read(struct io_uring_= cmd *cmd, unsigned int issue } =20 data->iov =3D data->iovstack; - ret =3D import_iovec(ITER_DEST, data->args.iov, data->args.iovcnt, - ARRAY_SIZE(data->iovstack), &data->iov, - &data->iter); + + if (cmd && (cmd->flags & IORING_URING_CMD_FIXED)) { + ret =3D io_uring_cmd_import_fixed_vec( + cmd, data->args.iov, data->args.iovcnt, + ITER_DEST, issue_flags, &data->iter, &bvec); + data->iov =3D NULL; + } else { + ret =3D import_iovec(ITER_DEST, data->args.iov, + data->args.iovcnt, + ARRAY_SIZE(data->iovstack), + &data->iov, &data->iter); + } + if (ret < 0) goto out_acct; =20 @@ -4929,13 +4945,14 @@ static int btrfs_uring_encoded_read(struct io_uring= _cmd *cmd, unsigned int issue ret =3D btrfs_uring_read_extent(&kiocb, &data->iter, start, lockend, cached_state, disk_bytenr, disk_io_size, count, data->args.compression, - data->iov, cmd); + data->iov, cmd, bvec); =20 goto out_acct; } =20 out_free: kfree(data->iov); + kfree(bvec); =20 out_acct: if (ret > 0) --=20 2.43.0