From nobody Thu Dec 18 19:05:50 2025 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D359F1552FA for ; Thu, 13 Mar 2025 01:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741828584; cv=none; b=iby1aqprkIYgw+rX5SYWNgQfMSTYrgmWtFlaVrx3c+y6Uiker86dYpi6RTUwlLCNtSVqu+RDJu+7RTEuac15MHoOVgJNgCm3Xab89Y2q2uC920DL9squYQ3N7S0REtrIXPDScKZ47lS1r6UizWRGidV16pnLio47jZOlli6MAFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741828584; c=relaxed/simple; bh=j0OwH7hw7Z1b3HyiF1OCjv9TuVAtV2k/Sj7t3TrDRug=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IB4aDHvdduz6rtGUP7l71yxwG1cW99iUkpL3ci79TAQ4QY7ZsCraKebrada2bzZo8lIXoMsgdQDwhqwwXUuLy5k2UEDMrg4DRncn2qXgkwS7TlxHCmfa0oPoX5SvhWuOa8vDC1GlnkgwXL5bebeM2VC8ZkChysDIHDR01VsfKAM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=MTW/oNqf; arc=none smtp.client-ip=209.85.161.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="MTW/oNqf" Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-5fe9c1c14baso228719eaf.0 for ; Wed, 12 Mar 2025 18:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741828582; x=1742433382; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Fmffu037s/U5DhU/4Qm/eUlh4c3Y4N1MaROpALwgUVI=; b=MTW/oNqfD6SI0o9XWUhHOTebehM/D1G0VQurLkhjjIs5JDLI9ZJYFt40yg9bVpZXMD LbB5niKwgpqUf8YK18pt5Jr+w+nQLsRjjKSuztDYmt1cv6vdCOepI5HHE0yzNuJr4tGl vdhcUUT78t9taGVJpjqvKMNQxds4dcQSrCsddXeVjfXkM92zrF5TfB9eQ7fWk3wYQbb4 0/EHUTMqNnCsLdUuydFOnPx4XhG1LxI7xtraIY7DuUrR0jhptgdvJ1j0mEZpoX1j3yIw NFIxASUD+carIg4mGxd+yu93rBsv9aBq01Lnr85X9qm6MQBvQt9k5jWXmVNpViZWq4yl pK4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741828582; x=1742433382; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fmffu037s/U5DhU/4Qm/eUlh4c3Y4N1MaROpALwgUVI=; b=Oebu+1C8WgNB69bAg+izZxyVkGceb2VKWqU3po6CCBuzgJIEUJYLgTp9APSIcFdkpS NWvDG2BpAh20qWXfFC0vlIbRLnDLnLxiHnKMgD+Jrhqzv6g+l8mLH4PoKbvOdqS+t69L sw30+xKO3Fm/syIM1SZV2/mpNlg8FAtk0YQnKtd7trr00OAR5HBSxZrSRL3ZQgnYH8y5 Gz2+ud61Wb6P+YQGeN8CPLVSk/XxAIHXF7eYbXclZTcDF1ZsSV7qAKW+DM2vcBsEydT/ xkThymXK9pK74LEIQBO3qYt95EXKpzFF00OQatO2IgKrJN6fv41Xv4JEdrg96/g5KbEs fuQA== X-Forwarded-Encrypted: i=1; AJvYcCXlPdELc6Vqq9pEwvl1Khd3pDCm6T7BkAeeHy+Qfxk1qzlw3W1Ghty1M7O0RwsW4EAFGXzyhr+Cm2MeyGI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzcr8XQtfpKd8+mwcxwaVuACTESy5gGYK7Zw5q29X2vxMkroXXq yOVVVKUbDZCv14U438WYGlebJJjtCgYj4VY9BdaLgXCe4aYLDbjCDf0IQYRmH8U= X-Gm-Gg: ASbGncsTwN5iVgg7vHApNbt+FePlGCdyyO+BfM094Evu55Ba7lDvDz58OIxAIfwqRjM RpZHFPGuBtPzyRUP72BcDfydiBWCDVqnfTX4zc6RSSIcqbWEBMZdcHZH86qndSKqf9sbbM9ECyo GkBZrP62nxZjFUi+J9XZdFOlijCWUNGSdpH0C0YK9UHD1qECQYh10byJSKKnqo6DJ1y0vEwjhjN xWoUZAbh+rxDLEdEuAvoMl6NsaXAwD3UXulOS6E2davwqYVBke0dTabR6hlD87sumRaDry/kBWd 6uWQY8eI9+k6ZtiDs/GR7k7dBHtuaOvHvpZfidRZUVK9reoriE1CxZj0iAQXECzkyH0Z2zJNL1x + X-Google-Smtp-Source: AGHT+IHG62j6un/OgQv23cM3V5FUNAh1VSrXx89rDwqZ/IlptiiF8UNCSL5BArMVaH92vDzHoN6O1Q== X-Received: by 2002:a05:6820:1845:b0:601:a813:5f22 with SMTP id 006d021491bc7-601a81360d3mr11639775eaf.6.1741828581864; Wed, 12 Mar 2025 18:16:21 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-601db659ad8sm39865eaf.8.2025.03.12.18.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 18:16:20 -0700 (PDT) From: David Lechner Date: Wed, 12 Mar 2025 20:15:43 -0500 Subject: [PATCH 05/11] iio: adc: ad7606: use devm_mutex_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250312-iio-adc-ad7606-improvements-v1-5-d1ec04847aea@baylibre.com> References: <20250312-iio-adc-ad7606-improvements-v1-0-d1ec04847aea@baylibre.com> In-Reply-To: <20250312-iio-adc-ad7606-improvements-v1-0-d1ec04847aea@baylibre.com> To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: Michael Hennerich , Angelo Dureghello , Alexandru Ardelean , Beniamin Bia , Stefan Popa , linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1131; i=dlechner@baylibre.com; h=from:subject:message-id; bh=j0OwH7hw7Z1b3HyiF1OCjv9TuVAtV2k/Sj7t3TrDRug=; b=owEBgwJ8/ZANAwAKAR+K+IyC93wDAcsmYgBn0jHaB/tuEDvy1HQERh8WW6U7nCYeKHCBENB7F bBkbdWQ8/OJAkkEAAEKADMWIQSKc9gqah9QmQfzc4gfiviMgvd8AwUCZ9Ix2hUcZGF2aWRAbGVj aG5vbG9neS5jb20ACgkQH4r4jIL3fAPe6BAAkH3NMfjir7Y5B2pqR8bhdCvPJQwbeSvxpljn5Mh GpL+cqJpYKZCTVuGH3VTTCDG/k/9GUrmLp1eW6Pa8TW4nIjUt8fNnsXocBri25z7P9PBSB5xRFP OCMvorGEOmuKXIthn5YFTTITvdjyAkrAQJ8OPfhgeIozUFGfMA8UBWaj+MG/LpsYpWXt27vQEYI QkKzC5pCEz2beAqGknJhLBOAaCmOAsIgbcB1Q69XCivTreM3AT43KAvZhv8FBs6RWOkDc9I9ZYf 3iu5z7ECH6VDmihvx8nq7Vn1t95p6rZyTwIzml4WMPjWywktbMnI9abCT4gd/cTfLuhSOY6UouZ Y760zBwLa183b/R5rikNi4NnsOIaVajfsRAZDXIVAyRWXpYQvrePDFh1EQirnJOUpMGEZWPPDI0 VBXBfxMa6m5xmIVvYCzsC3llUXCK+4M49x/HWC7YwCoUgxUXA5uXt8LJ93dmTYdqs7veErh13Gl IvcgWl0cgQV8OYYP0K12P6rxt000EDMvDUbeY3NQuWn+3AMOjQoTlYAqPGZ0KCgMz12xKlDIvG5 JHB7fm2WHxXAu6mWYuEoI8gELegex6CEp7qpxDIB4AlLBSS9bFebumJ1b0q9kkZ2UwXb4nsoIx3 +uPhrMzvMD76T08u7PfVj2SkDNDJOZmZc7pM0KGjHWOE= X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use devm_mutex_init() in ad7606_probe(). Mutexes should be cleaned up on driver removal. Also add missing include while we are touching this. Signed-off-by: David Lechner --- drivers/iio/adc/ad7606.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index 440e1e5a9b18570dc6441bff91afbc51d20cbc47..f190269ac8ddd859e94eb24c26f= 5f010d0951646 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -1332,8 +1333,11 @@ int ad7606_probe(struct device *dev, int irq, void _= _iomem *base_address, st =3D iio_priv(indio_dev); dev_set_drvdata(dev, indio_dev); =20 + ret =3D devm_mutex_init(dev, &st->lock); + if (ret) + return ret; + st->dev =3D dev; - mutex_init(&st->lock); st->bops =3D bops; st->base_address =3D base_address; st->oversampling =3D 1; --=20 2.43.0