From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F08DD19CC33 for ; Tue, 11 Mar 2025 13:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699103; cv=none; b=SoHVucKibhQJprpZwE1FW+oDHQzWyjhmTYN6WFhCNYrtIuCxXMcbZUxMr7FWttUTELzMTkuthZ374z3ZDtD8hX85QFUGEWQVRIL5TUNEh8ZgZ7BiytTOvx1h9MlLLPwS5P5tCDtadu6LjjgC8GxhFfx/hhI7RYqQwdwxevO0GG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699103; c=relaxed/simple; bh=JQhRr6deSyIwx2zw/NuSPazbVfMmtvtNqOIabeeTs8Q=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VPvM+oIv6CxmpbuXxl9LqhLAbxYZCQmaS9p5GlPMDrYOyKrT+hHOoEiA8j2UpRRVTuuGY8n7VBfGA9SxjXk7UzoIW2TsWj6Mv7BN1Ep/eFG0FwniNZpXBSCFvA3KVlHrKaMMvOY2svCbnEhBdLw06ZblOR0bHWXMqpOjuEqLVsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GqgZKTOz; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GqgZKTOz" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43bd0586a73so46271195e9.2 for ; Tue, 11 Mar 2025 06:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699100; x=1742303900; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=q3kjR3e+tUhw3L1FQAPtkpKMwUmzOI7e4dVWjhqVqwM=; b=GqgZKTOzQfPAi905c5YmvBCypQts0zgmtYFsl1TJpL5IEjPvx0l2LKgyd7njdeK92I DaDODI5yt2UwldUS0iWgen9/R5rjcRaTRgFSBAadwCZ2fXAmzBWq8h3wPCeNgmZrHR2d SoWQBObMopX6qhlYXtxyUaZSJqdaCxUFiNm1vHQm6qjqyKkz8TQ6PZhDTnbHeIDLTKdQ 4vD3RthaJfMTAydVeBc8bZ6oxxqYsE7dCsCJzmkJXQa55JZUkiYPHA+uC2d/i4jk9MoD EXvifftU5AwbZvOJuUGhvvw/Er3MHm179Q4lvlWN9wnTwcNOYKrg2ohWah9JzogTZZM4 9BFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699100; x=1742303900; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q3kjR3e+tUhw3L1FQAPtkpKMwUmzOI7e4dVWjhqVqwM=; b=VimNs+FENX9LHGZezBHwjQFNNfq4bEQRd+PJ2ySqg29iXwPPFTGs2PtipKjJ/eP6mw nfLXdh6YkgmyWv/9z9H41ICpIlXM+zyUHdyIv5LKPyXwyGVzP6v2yy+4WC2FLkyEzOOq B3j4UNuTsxnsYvtg0NZ7fACrzviawZO8BRyt27QqZ3zQJ7zJ4EJbYFjodHOPeCV+y+Zp Vbx6zU9Yp8RKYnaEQRES5IDfbBb8SnyAMcXyLYBmwzg/deVj6tOn40Fmh4UQz2Gvo7WM Mu6a1/F/Pc/jfR0VLMoaK2M1bo62pgpMC5wy52sOjvG4kWr1wmRi8pSuHH3WzvdcXxNc lO/w== X-Forwarded-Encrypted: i=1; AJvYcCXevql3qdjQM8ITVU1tPEXxeDx3SLrSIcHKudcM1xGMzed1iAgooAoPX8+4B97cs2cvXHq0pD5l5U1ZbbE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8A6j0cpv+O5FfmrVSZsR4PXsXXQ91BhMNkeX+pUnMMcnDC1qA dW618Xnb/nGMFHHZkWtEG9s3yp72NXd1flSjGNaTNEzZGRxl1iWfQkYBvlykIEmafK6S9Owz1Zf 2ED9HagvqsQ== X-Google-Smtp-Source: AGHT+IFvDSGF/OHbPFKrTNFDJv2bYNbhXrjsIZlG+nsyMMEqyV04VNqP84+SWfbxxSYLZ4nKYbR3gmw1XGhYsg== X-Received: from wmpz16.prod.google.com ([2002:a05:600c:a10:b0:43c:ee49:c14d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3ba3:b0:43c:fcbc:968c with SMTP id 5b1f17b1804b1-43cfcbc97d3mr87744455e9.7.1741699100416; Tue, 11 Mar 2025 06:18:20 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:12 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-1-dec210a658f5@google.com> Subject: [PATCH v4 01/12] selftests/mm: Report errno when things fail in gup_longterm From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 37 ++++++++++++++++++---------= ---- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/self= tests/mm/gup_longterm.c index 9423ad439a6140163bdef2974615bb86406a8c14..15335820656b1c143b440b8a106= 5a025378e22a2 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,13 +96,13 @@ static void do_test(int fd, size_t size, enum test_type= type, bool shared) int ret; =20 if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed\n"); + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); return; } =20 if (fallocate(fd, 0, 0, size)) { if (size =3D=3D pagesize) - ksft_test_result_fail("fallocate() failed\n"); + ksft_test_result_fail("fallocate() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -112,7 +112,7 @@ static void do_test(int fd, size_t size, enum test_type= type, bool shared) shared ? MAP_SHARED : MAP_PRIVATE, fd, 0); if (mem =3D=3D MAP_FAILED) { if (size =3D=3D pagesize || shared) - ksft_test_result_fail("mmap() failed\n"); + ksft_test_result_fail("mmap() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -130,7 +130,7 @@ static void do_test(int fd, size_t size, enum test_type= type, bool shared) */ ret =3D mprotect(mem, size, PROT_READ); if (ret) { - ksft_test_result_fail("mprotect() failed\n"); + ksft_test_result_fail("mprotect() failed (%s)\n", strerror(errno)); goto munmap; } /* FALLTHROUGH */ @@ -165,18 +165,20 @@ static void do_test(int fd, size_t size, enum test_ty= pe type, bool shared) args.flags |=3D rw ? PIN_LONGTERM_TEST_FLAG_USE_WRITE : 0; ret =3D ioctl(gup_fd, PIN_LONGTERM_TEST_START, &args); if (ret && errno =3D=3D EINVAL) { - ksft_test_result_skip("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_skip("PIN_LONGTERM_TEST_START failed (EINVAL)n"); break; } else if (ret && errno =3D=3D EFAULT) { ksft_test_result(!should_work, "Should have failed\n"); break; } else if (ret) { - ksft_test_result_fail("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_fail("PIN_LONGTERM_TEST_START failed (%s)\n", + strerror(errno)); break; } =20 if (ioctl(gup_fd, PIN_LONGTERM_TEST_STOP)) - ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed\n"); + ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed (%s)\n", + strerror(errno)); =20 /* * TODO: if the kernel ever supports long-term R/W pinning on @@ -202,7 +204,8 @@ static void do_test(int fd, size_t size, enum test_type= type, bool shared) /* Skip on errors, as we might just lack kernel support. */ ret =3D io_uring_queue_init(1, &ring, 0); if (ret < 0) { - ksft_test_result_skip("io_uring_queue_init() failed\n"); + ksft_test_result_skip("io_uring_queue_init() failed (%s)\n", + strerror(-ret)); break; } /* @@ -215,13 +218,15 @@ static void do_test(int fd, size_t size, enum test_ty= pe type, bool shared) /* Only new kernels return EFAULT. */ if (ret && (errno =3D=3D ENOSPC || errno =3D=3D EOPNOTSUPP || errno =3D=3D EFAULT)) { - ksft_test_result(!should_work, "Should have failed\n"); + ksft_test_result(!should_work, "Should have failed (%s)\n", + strerror(errno)); } else if (ret) { /* * We might just lack support or have insufficient * MEMLOCK limits. */ - ksft_test_result_skip("io_uring_register_buffers() failed\n"); + ksft_test_result_skip("io_uring_register_buffers() failed (%s)\n", + strerror(-ret)); } else { ksft_test_result(should_work, "Should have worked\n"); io_uring_unregister_buffers(&ring); @@ -249,7 +254,7 @@ static void run_with_memfd(test_fn fn, const char *desc) =20 fd =3D memfd_create("test", 0); if (fd < 0) { - ksft_test_result_fail("memfd_create() failed\n"); + ksft_test_result_fail("memfd_create() failed (%s)\n", strerror(errno)); return; } =20 @@ -266,13 +271,13 @@ static void run_with_tmpfile(test_fn fn, const char *= desc) =20 file =3D tmpfile(); if (!file) { - ksft_test_result_fail("tmpfile() failed\n"); + ksft_test_result_fail("tmpfile() failed (%s)\n", strerror(errno)); return; } =20 fd =3D fileno(file); if (fd < 0) { - ksft_test_result_fail("fileno() failed\n"); + ksft_test_result_fail("fileno() failed (%s)\n", strerror(errno)); goto close; } =20 @@ -290,12 +295,12 @@ static void run_with_local_tmpfile(test_fn fn, const = char *desc) =20 fd =3D mkstemp(filename); if (fd < 0) { - ksft_test_result_fail("mkstemp() failed\n"); + ksft_test_result_fail("mkstemp() failed (%s)\n", strerror(errno)); return; } =20 if (unlink(filename)) { - ksft_test_result_fail("unlink() failed\n"); + ksft_test_result_fail("unlink() failed (%s)\n", strerror(errno)); goto close; } =20 @@ -317,7 +322,7 @@ static void run_with_memfd_hugetlb(test_fn fn, const ch= ar *desc, =20 fd =3D memfd_create("test", flags); if (fd < 0) { - ksft_test_result_skip("memfd_create() failed\n"); + ksft_test_result_skip("memfd_create() failed (%s)\n", strerror(errno)); return; } =20 --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F87C1BD01F for ; Tue, 11 Mar 2025 13:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699105; cv=none; b=Imr+LPv0Pd8YCx50X8OCip9kwZuizgSPZIqzkR0q4F6iHxlsr10RFWbykFIPoZ+RN4BKJh0MywEQNJjgbPoeU1c4HwygIWNNkd9NFG1vJID18nn1ovE3MFxhIAA4R4sGFplQbvM+P3nmsYqtlDelaGjch6CUhiTGQlcLnZm9i4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699105; c=relaxed/simple; bh=epdKFY+uVF/7PgVLHKRyqByV9Sxbc8LmSXgVAXlQ4wM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=RRv3X+R/FstQo01p3hp03oKA5981pbJnIh2lJ3cKmlcgoK9qRFdrQi0rGPd9Nkq7I0MR9xceQAm2NTZSzaPp7JgmkfIJscO21BWv13YpPMnTzjjsChHF3I0j3Ce+xvTNYUfJrq3xvXGSileGGMn9X7UVGqCKeGJkc0Mr65kHhw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=oS7wC3oS; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oS7wC3oS" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43bc97e6360so27361705e9.3 for ; Tue, 11 Mar 2025 06:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699102; x=1742303902; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=eNnWwlE7ZfA4njYaSa6+RHThvRYMfszFV0jljda2YI4=; b=oS7wC3oSPKVKVSYi9w/ORJ7KYQZjiNZv+3fM72dRJr13uKfg0uEd5+jLFVWL7fsJVr MSGW0KYM11lbtGGfCUpobD9HvTJtcneT9ylP1Nh9qAf3MGMIZ8gYPQbbJS/S1/0Zrjwm tEM2J8VG6xKZ+YowwX6qMfDkAgv6lbEnwc1jS4ewqQDl2UvWLiuUxqGf0lwCWyt8s+Rv Uj+6/HER2lsE+t+hSUqGNMrpgd0cbsZ/Gtq7eVLVrrYKC2+EKKD9f0OPkvNSjqHWMjHs 1gzy0fOpsbUe/P9X3liFZ16+Xbi7femne/lgeWAa2ZpRWinY4iBgzhUCEP/E/w8PYDbo AnPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699102; x=1742303902; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eNnWwlE7ZfA4njYaSa6+RHThvRYMfszFV0jljda2YI4=; b=FzMmN1htpPzsArvpphNxdoxA0zPVwpFBIoVIS/u+PRozGdQ80hGv8ZAaAGnsnvVTlj l751gZif9TMHOPhuIHgfU2GPb86uhMXcTFgZLEajMCS+L1wN9vJIUtrr/3VOvkRhhwFC 2vpqPtolHhkeB1+Nyeqx8kI1jKlAt3X3706VNnT/CRGUmC8+yy+8w4/ZLI6DewppvxWc NPXfbuEuKIbJS/VwB4PnA/YNL8usBvpw4ggJgVXZcykaUTP+2FpcSaB34DHKG7Z2A5jn hHIhtW6JisP+jNpDSWPx9ORMjJHK3qymhEA18x+tMdYIBhwfSnQRniNA1tDYfeXp5zjf 0SZg== X-Forwarded-Encrypted: i=1; AJvYcCVjMPULo4abJ4Dcvuvn2+uewzdnKe8aa4vMseljRoI2oNvys2xVtzoPqOGMaUIOZ21ODX2kMAtyC2G1MlE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/hEV9ErqLguJN1NwsroWaquVK35qVHOTIQpq8tn6yhn9iTyvz WEwmQnub7EBY1QlUgO50nsLd64Yy4RHM4xnb77+7XdUiE76jDfAdUIXMxSnOvj5UeZXsQ+i3E2f D/1F1W2roKg== X-Google-Smtp-Source: AGHT+IF00DB9vxEjSFZYMwiT0cUkAqXFwWmkRj0Y1btbCtCISAk52bWxBSSNcRq9+pCP65pccsXXfMuEUhHyLQ== X-Received: from wmbfk3.prod.google.com ([2002:a05:600c:cc3:b0:43b:c336:7b29]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3512:b0:43c:fded:9654 with SMTP id 5b1f17b1804b1-43cfded98b3mr57431755e9.19.1741699102457; Tue, 11 Mar 2025 06:18:22 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:13 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-2-dec210a658f5@google.com> Subject: [PATCH v4 02/12] selftests/mm: Skip uffd-stress if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selft= ests/mm/uffd-stress.c index 944d559ade21f255404eb38557660e54e81d46b8..91174e9425cde2500b459db78cb= 27adda6647b55 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -412,8 +412,8 @@ static void parse_test_type_arg(const char *raw_type) * feature. */ =20 - if (uffd_get_features(&features)) - err("failed to get available features"); + if (uffd_get_features(&features) && errno =3D=3D ENOENT) + ksft_exit_skip("failed to get available features (%d)\n", errno); =20 test_uffdio_wp =3D test_uffdio_wp && (features & UFFD_FEATURE_PAGEFAULT_FLAG_WP); --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD0171C3BF9 for ; Tue, 11 Mar 2025 13:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699107; cv=none; b=Y+ri7TOrgMojMuoTnz+AuQLiQWByRTcFbxOVw3JLAAYw8x+Oqe2kQJzKhq8hNO8xMFSyL5lWVYH3n+upmb24+l4PvfjCsEFfq1IWD3uV2NyuT8LYe6tv4ssQRl63KuOlc7aza9QA3QqUOJp6vbUaD3r7Bl3B2lhx1c9zh/txFv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699107; c=relaxed/simple; bh=YI+QfZYo+Ua4IptGRz3TLf+pOBqxcgMjursiHKuuqQg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nuX+3dq64WD5qXLLjPH7aT1Fs1bSOKB3cJq8M5UD2FJnbdH1B7ODgn5GoXjWvM2BdvzZFt3Fqir4B2lobDMBFai7Vm6Pud3n3tMKcGFd2NdRnCqYi5TWqQpY/l3zRkO5HWNFLu6vbXwOkaKvdP/8OO4NSjqehtjrDheJdinfZ1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EsN2Npuv; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EsN2Npuv" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43d0830c3f7so1715855e9.2 for ; Tue, 11 Mar 2025 06:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699104; x=1742303904; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mU0cRsNzbsuSP1E5sjoXt0xKYtlq+gxz63wOE52l3IA=; b=EsN2NpuvnZRBWPwHVjVhZUlAvWVacGYo/2PJwIenfRAOgHz1eyNNJMdMDLqHzqyvA0 aU469XLW91EJUqiyViSiO5yqrPIHoVG2eir/YAB2TkteKxe5xEFRH9Hhzbd+vcsVVbQ7 lr9cqyBPkHCSLnCzR08Fb/BDQcZarXiwL+iU90qkbMGeh3LYivhVc+BwbexhFUN+SvRz u62+uvLEmD/0hHvoO5Amfh99qGA6z4JU+zdeEFCTKfYmYvKk4NyKA0NzHMjPTCSU1ZaN BTXKoAJUkvsfUL16UdFuJeQH9WBQgwo1ZeCcTCdwqO37+B1ZAHsqkXSeqfB59Tfwi9TK dpEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699104; x=1742303904; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mU0cRsNzbsuSP1E5sjoXt0xKYtlq+gxz63wOE52l3IA=; b=uZsWI3hiiLhHDZ8R6+N8SRDdZ+iqIhqjUweqtaYzCwWCbXnE2KRtZDdINP781l3KvB GQ0bD3sHaGXb1mSuI/xIm5U2MFkTKimJ4n/YHmWBIgIgjaKoiWopf/5ucsALiw+Wx1O/ pInDnB+phgSMJ2Q0A80m1spA3mkLp4LjHD9X98ajSh+yxVTRcWgHzdajECQZA7GT6Ma7 DVMgC1eK4SM9RmmJoWYYLnLuiC2feA2V42tLycX/obyNFvHsN6rs7v3ivd9SPS1wUSFb UD+b0D9DqEz020ToHVNMt6g2XgnRObAU5yjZSC1Gn2usSnGY8eoQ+HUvtYh19NC4he1H zZnA== X-Forwarded-Encrypted: i=1; AJvYcCVSK6v2PGXtXUsdRjgvGS86Je7qE7dg1QijvvOCXLsLwsCnwZyZUTqCptDXg8UGqr/w1ewYf02IcLFl1e8=@vger.kernel.org X-Gm-Message-State: AOJu0YypJh/6JAaS198bPgJ5vdx7aMFutPmu0p/KQQbCYSZsOzH7EvB/ CVLjV4rXcQ5yiOz183sn6+IlVMAxKNZFDz0CcdbdBLPWOiojV5iqw+g5I/dxKxMU0Leu4qiscdm EkkqClTTUiw== X-Google-Smtp-Source: AGHT+IGSV21QBYLlvs34tFS6Vj4C4TFSxgnu4bOOKFjZdG2VcNI1hO3z4RNOQPjlkVLg4FfQFOtvmKJGtJlrQA== X-Received: from wmpz16.prod.google.com ([2002:a05:600c:a10:b0:43c:ee49:c14d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:46cd:b0:43c:ee3f:2c3 with SMTP id 5b1f17b1804b1-43cee3f0578mr100814485e9.7.1741699104325; Tue, 11 Mar 2025 06:18:24 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:14 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-3-dec210a658f5@google.com> Subject: [PATCH v4 03/12] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It's obvious that this should fail in that case, but still, save the reader the effort of figuring out that they've run into this by just SKIPping Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/se= lftests/mm/uffd-wp-mremap.c index 2c4f984bd73caa17e12b9f4a5bb71e7fdf5d8554..c2ba7d46c7b4581a3c32a6b6acd= 148e3e89c2172 100644 --- a/tools/testing/selftests/mm/uffd-wp-mremap.c +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c @@ -182,7 +182,10 @@ static void test_one_folio(size_t size, bool private, = bool swapout, bool hugetlb =20 /* Register range for uffd-wp. */ if (userfaultfd_open(&features)) { - ksft_test_result_fail("userfaultfd_open() failed\n"); + if (errno =3D=3D ENOENT) + ksft_test_result_skip("userfaultfd not available\n"); + else + ksft_test_result_fail("userfaultfd_open() failed\n"); goto out; } if (uffd_register(uffd, mem, size, false, true, false)) { --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCED71C8636 for ; Tue, 11 Mar 2025 13:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699109; cv=none; b=rdoF/GFS7KJ7Bf+eTmG928uhGIXiio3V3mQjCsqzPkv2RCe8D779zJ+TZX8HkpYoRt+3b67GMa3q5v6MQ9uK1EYLQaLvBhrdxI4LmidWYuaVwTpa4cAyTOx0I1VY3gWFczWfv7FDPBBb+2fX1JND3qgsVlKxythqnCJ/Omg+8fo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699109; c=relaxed/simple; bh=7cu9Mo5jePwqRqrQo8QLwmI2cqs8fPM09Kmi4kZUvjs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=jnY9dH5T723J9ody4uWdYv8uk2q+rwn7XlFXQBfMaSA/TJClCoKNhlslTrMjONLbK4QTZ/Nkxtm/iGjjOaz6D8nmmoJOP2RCz0SYpqSFOKNoSs0HX1v/Qccz8RNa+S47vBq4ay26drNdl5BK0jCp3VfjeTXsuV1dEsh8TQRivww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=n7rBrxT2; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="n7rBrxT2" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43d01024089so11529915e9.1 for ; Tue, 11 Mar 2025 06:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699106; x=1742303906; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5QUtJ68S5WVMBdPVxDoGekz8XvAVXh0h8UUq5TqoFAw=; b=n7rBrxT2Yk8Ff/HuAbhiwpQDQKDuYlr7cRXL7aJjI61NU3ZU734PgVzJSawdaxQRdJ blvMsdcYwwUzdtosHTMe9ywU+Tcsk/mlYq/n6/4lO1TeY8FvOyXLKhBGZKQpnqflEf6s slXmCM1byGNUDvZYm0opb8lh2Bl/uUzlDrcuMWdicbJKNTMzKc/ZhSbc5zU5lwuwBcDN d+OrCMqqVz18FN/MfKZgQFX+CEwcyEIyiKkgldDSXLMa6hv8y6fzLArN1VwqAthWLdbX Yd32i2kq50JBSvAz92bF3U8u/dW66B9uA2cNqSR8Z63OA9WDpAcNG2uPv5F5rH0EAao+ HCWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699106; x=1742303906; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5QUtJ68S5WVMBdPVxDoGekz8XvAVXh0h8UUq5TqoFAw=; b=upSiTVU2tvnX9KwJ+yfqub7XfI1t1oXmYCpH0CJPVNiyGTgyFFdQledJEnIbEKNNNr xiK+6Uh+w3UsHeGg28+ilvtHBG2CueM4bBVxWaJajMkOXaZW3//8M7R8L+7Qpp+t3FD5 TZxKBoNjyz2zwJLg6Qidwgi7WWd3AYV8rAQyutOGUWsvhKb8CdYVztw7hR7Emt3G3rMf mM/PNGp4YZwUaYR/drDoP48+23ASTDtWNqTvPqomV3by2SagtT4uwnvsp13CkTRN7fHZ GM4TZ/FDPVcSscpSTjfdkhfLb/pc7c1CZmj3NUf+xTEJKGl82kNOTMXQbmmru0ZmI0dm VR9g== X-Forwarded-Encrypted: i=1; AJvYcCX/Ua8n3pioRKDgQZr+Fp0DOz1PD8KaPYZR9AqCrjORm6rm4Kp3I9UytF0C5g3JXjq7YXTBqMMRxPTyvBg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7+x/0Np1ImqxBjVGp7h+F6xjw0g/qlFGV67GBFAQ2N5vslukb /ZyVTtIeF397HJeV6EzHN95qaVzB2ayYY5HRKompQB781DJSaSeJHkxqwtcWD2NOJPZsXgsFYYT DhmSub7sBxg== X-Google-Smtp-Source: AGHT+IHToyTOs3PPNxoBJUiCtaIlgO3ErHmKsYxSiQO/bRF9eUGsPTje1OCUomarBDaBQGTLwh5n+zuKNOR9zw== X-Received: from wmbet7.prod.google.com ([2002:a05:600c:8187:b0:43c:fad4:7595]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3554:b0:43c:fffc:787b with SMTP id 5b1f17b1804b1-43cfffc7b0fmr77724175e9.12.1741699106174; Tue, 11 Mar 2025 06:18:26 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:15 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-4-dec210a658f5@google.com> Subject: [PATCH v4 04/12] selftests/mm/uffd: Rename nr_cpus -> nr_parallel From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable A later commit will bound this variable so it no longer necessarily matches the number of CPUs. Rename it appropriately. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-common.c | 8 ++++---- tools/testing/selftests/mm/uffd-common.h | 2 +- tools/testing/selftests/mm/uffd-stress.c | 28 ++++++++++++++----------= ---- tools/testing/selftests/mm/uffd-unit-tests.c | 2 +- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-common.c b/tools/testing/selft= ests/mm/uffd-common.c index 7ad6ba660c7d6f1f5762d0b231b92b05e971a3c5..dd01d2c95175b0329a75e220d2f= 43c915261090c 100644 --- a/tools/testing/selftests/mm/uffd-common.c +++ b/tools/testing/selftests/mm/uffd-common.c @@ -10,7 +10,7 @@ #define BASE_PMD_ADDR ((void *)(1UL << 30)) =20 volatile bool test_uffdio_copy_eexist =3D true; -unsigned long nr_cpus, nr_pages, nr_pages_per_cpu, page_size; +unsigned long nr_parallel, nr_pages, nr_pages_per_cpu, page_size; char *area_src, *area_src_alias, *area_dst, *area_dst_alias, *area_remap; int uffd =3D -1, uffd_flags, finished, *pipefd, test_type; bool map_shared; @@ -269,7 +269,7 @@ void uffd_test_ctx_clear(void) size_t i; =20 if (pipefd) { - for (i =3D 0; i < nr_cpus * 2; ++i) { + for (i =3D 0; i < nr_parallel * 2; ++i) { if (close(pipefd[i])) err("close pipefd"); } @@ -365,10 +365,10 @@ int uffd_test_ctx_init(uint64_t features, const char = **errmsg) */ uffd_test_ops->release_pages(area_dst); =20 - pipefd =3D malloc(sizeof(int) * nr_cpus * 2); + pipefd =3D malloc(sizeof(int) * nr_parallel * 2); if (!pipefd) err("pipefd"); - for (cpu =3D 0; cpu < nr_cpus; cpu++) + for (cpu =3D 0; cpu < nr_parallel; cpu++) if (pipe2(&pipefd[cpu * 2], O_CLOEXEC | O_NONBLOCK)) err("pipe"); =20 diff --git a/tools/testing/selftests/mm/uffd-common.h b/tools/testing/selft= ests/mm/uffd-common.h index a70ae10b5f6206daecc8e19ed3e3bbb388e265aa..7700cbfa397563d2f2bc82be45f= 96f2fc2032bbe 100644 --- a/tools/testing/selftests/mm/uffd-common.h +++ b/tools/testing/selftests/mm/uffd-common.h @@ -98,7 +98,7 @@ struct uffd_test_case_ops { }; typedef struct uffd_test_case_ops uffd_test_case_ops_t; =20 -extern unsigned long nr_cpus, nr_pages, nr_pages_per_cpu, page_size; +extern unsigned long nr_parallel, nr_pages, nr_pages_per_cpu, page_size; extern char *area_src, *area_src_alias, *area_dst, *area_dst_alias, *area_= remap; extern int uffd, uffd_flags, finished, *pipefd, test_type; extern bool map_shared; diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selft= ests/mm/uffd-stress.c index 91174e9425cde2500b459db78cb27adda6647b55..d6b57e5a2e1d7611aa1588ee416= 01ce16117a574 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -180,12 +180,12 @@ static void *background_thread(void *arg) static int stress(struct uffd_args *args) { unsigned long cpu; - pthread_t locking_threads[nr_cpus]; - pthread_t uffd_threads[nr_cpus]; - pthread_t background_threads[nr_cpus]; + pthread_t locking_threads[nr_parallel]; + pthread_t uffd_threads[nr_parallel]; + pthread_t background_threads[nr_parallel]; =20 finished =3D 0; - for (cpu =3D 0; cpu < nr_cpus; cpu++) { + for (cpu =3D 0; cpu < nr_parallel; cpu++) { if (pthread_create(&locking_threads[cpu], &attr, locking_thread, (void *)cpu)) return 1; @@ -203,7 +203,7 @@ static int stress(struct uffd_args *args) background_thread, (void *)cpu)) return 1; } - for (cpu =3D 0; cpu < nr_cpus; cpu++) + for (cpu =3D 0; cpu < nr_parallel; cpu++) if (pthread_join(background_threads[cpu], NULL)) return 1; =20 @@ -219,11 +219,11 @@ static int stress(struct uffd_args *args) uffd_test_ops->release_pages(area_src); =20 finished =3D 1; - for (cpu =3D 0; cpu < nr_cpus; cpu++) + for (cpu =3D 0; cpu < nr_parallel; cpu++) if (pthread_join(locking_threads[cpu], NULL)) return 1; =20 - for (cpu =3D 0; cpu < nr_cpus; cpu++) { + for (cpu =3D 0; cpu < nr_parallel; cpu++) { char c; if (bounces & BOUNCE_POLL) { if (write(pipefd[cpu*2+1], &c, 1) !=3D 1) @@ -246,11 +246,11 @@ static int userfaultfd_stress(void) { void *area; unsigned long nr; - struct uffd_args args[nr_cpus]; + struct uffd_args args[nr_parallel]; uint64_t mem_size =3D nr_pages * page_size; int flags =3D 0; =20 - memset(args, 0, sizeof(struct uffd_args) * nr_cpus); + memset(args, 0, sizeof(struct uffd_args) * nr_parallel); =20 if (features & UFFD_FEATURE_WP_UNPOPULATED && test_type =3D=3D TEST_ANON) flags =3D UFFD_FEATURE_WP_UNPOPULATED; @@ -325,7 +325,7 @@ static int userfaultfd_stress(void) */ uffd_test_ops->release_pages(area_dst); =20 - uffd_stats_reset(args, nr_cpus); + uffd_stats_reset(args, nr_parallel); =20 /* bounce pass */ if (stress(args)) { @@ -359,7 +359,7 @@ static int userfaultfd_stress(void) =20 swap(area_src_alias, area_dst_alias); =20 - uffd_stats_report(args, nr_cpus); + uffd_stats_report(args, nr_parallel); } uffd_test_ctx_clear(); =20 @@ -453,9 +453,9 @@ int main(int argc, char **argv) return KSFT_SKIP; } =20 - nr_cpus =3D sysconf(_SC_NPROCESSORS_ONLN); + nr_parallel =3D sysconf(_SC_NPROCESSORS_ONLN); =20 - nr_pages_per_cpu =3D bytes / page_size / nr_cpus; + nr_pages_per_cpu =3D bytes / page_size / nr_parallel; if (!nr_pages_per_cpu) { _err("invalid MiB"); usage(); @@ -466,7 +466,7 @@ int main(int argc, char **argv) _err("invalid bounces"); usage(); } - nr_pages =3D nr_pages_per_cpu * nr_cpus; + nr_pages =3D nr_pages_per_cpu * nr_parallel; =20 printf("nr_pages: %lu, nr_pages_per_cpu: %lu\n", nr_pages, nr_pages_per_cpu); diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/s= elftests/mm/uffd-unit-tests.c index 74c8bc02b5063f4667c4284c432edc7dee7ba3a5..24ea82ee223184612781adc8524= 60138c4fe28f0 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -198,7 +198,7 @@ uffd_setup_environment(uffd_test_args_t *args, uffd_tes= t_case_t *test, =20 nr_pages =3D UFFD_TEST_MEM_SIZE / page_size; /* TODO: remove this global var.. it's so ugly */ - nr_cpus =3D 1; + nr_parallel =3D 1; =20 /* Initialize test arguments */ args->mem_type =3D mem_type; --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3BD11D47AD for ; Tue, 11 Mar 2025 13:18:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699111; cv=none; b=Uc3e3aPV5hIquyfyY5szLhz5+mSf1wuTtqOQBnJYWGhSeHK363RD/OEmKpgiRLo1MqjRrx/9imS5dcfthNApYpFhTVK8A5sE3sgg9XA+Hswz6ulxt+AFzo06iqCEsARDqpxDfgcvraHd+kO2l5fWfJU34QjSSjeLK6kAxkkxl6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699111; c=relaxed/simple; bh=ZAXSMCvr+IvZnGOVJS0yA66QSG3JhZXcjwBrekeGfBs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HaMIoQBNnBEn+N/LnDn1eefrT6IGInb/qa9iqparaKEIUWVq2ZAdvoAwJlYaAbdfpBDfeUbc8XmWSl/jOamt6gNP/bge4ENfGlYhENeYFmjya287pHJIF7tfXdg2D6wTGK0JjYJxiDzlKlROD0emtsfE0GXNZw22yFHi+FYMqeI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nGHkQ7zB; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nGHkQ7zB" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43ceed237efso20691295e9.0 for ; Tue, 11 Mar 2025 06:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699108; x=1742303908; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=LGBb/Y6S3RxkI/6vwf1UwhFj4ViFPcNM6Jmgh/1tpM4=; b=nGHkQ7zBfBAh0E2oqdVC8DoeXRBzDb5o6fd/qxgNVftEh5BfS8V8XMefPQupXWT6Cw OoQww4SZpH+2vtD0gKBju3YWOhP/JOvNWxnjtmAX5s+LhY3ahfCfVTWaSFD+yjeyK9lF ADOR8NupGkadboMHeDH0b4p0zjHiLs06Z4MNs4l9kHO0Ko6F01ojAkRgm4xdYJWq1M6K 6ORviiK+WXuyCoAXtM06rvSCk66nKR7C++Xlk5Ct5ruvb8JE8RGCaP1ehJ6fteyireFt gqsgKZcmBi23+CC4RMepurGCXka1zQ3mGBvEO2HUgqiN53E/O4MNM6yn3WgURyFj0DzD V4Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699108; x=1742303908; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LGBb/Y6S3RxkI/6vwf1UwhFj4ViFPcNM6Jmgh/1tpM4=; b=fh/Pq/CET2w41xUVUve8E4mTRb+MmVaDZ3qWYCgAHAjX6FZiITEJNnuYOAwLC+jgZC UYNUrhzs4CzUrbJZHPT/hRCtALJGRxG0Jd/e1Nw+sw2fu3Nz8Fl0Au9xwuP9phU0J7JP zAjkB7ZPLcxw60az9zRYoXbO/TKzGGXOoYcoiTbttmSy77iHL3nOnicYPuXsTBkd9xFj 1SEypgTdEVgDFJi3Lbr/jAj4nmG78U1AQ90iOgRBJk1WR8llZn/+PtZmw8O4YHLilOY4 A4fW+JriRrsyrxxHSb8b4peI3ixV0pPGDHG1tJIf9/cERfB6at6RPc+p8ky9JqEIO8n1 JjvA== X-Forwarded-Encrypted: i=1; AJvYcCXIik+28nmWACHK05hXLH/NWl9Ghn2FXocuzjDC45WP4kx0L3lsuWGReWa6bH9fmYiJ0Td3TaetH6t1aYI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+IwA9gNdEymRBfNRw2oRlmA5qEqtx4mVSn4epcSLe7wRYaJyv RMWRx0EpIUHSieuaovifc0Pw1NHqc9xDREyUrO0TbdAmvoBZv8fOCUAzt+WVt7rMUWvghe6snWR Oiuk9j2F7Qg== X-Google-Smtp-Source: AGHT+IEB4Ugao+9oG4PoYlVLqRx0MnCh6L1DYai8LwtyRUN8s3dqA+kO7+QszcVXjAFc8ZgqGgWa+WHaCnWckQ== X-Received: from wmbhc25.prod.google.com ([2002:a05:600c:8719:b0:43c:fce2:1db2]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4e8f:b0:43c:f184:2e16 with SMTP id 5b1f17b1804b1-43d01bd2167mr54372315e9.5.1741699108122; Tue, 11 Mar 2025 06:18:28 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:16 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-5-dec210a658f5@google.com> Subject: [PATCH v4 05/12] selftests/mm: Print some details when uffd-stress gets bad params From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable So this can be debugged more easily. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selft= ests/mm/uffd-stress.c index d6b57e5a2e1d7611aa1588ee41601ce16117a574..4ba5bf13a0108435ce8b53340b9= e17ccd47e859e 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -457,7 +457,8 @@ int main(int argc, char **argv) =20 nr_pages_per_cpu =3D bytes / page_size / nr_parallel; if (!nr_pages_per_cpu) { - _err("invalid MiB"); + _err("pages_per_cpu =3D 0, cannot test (%lu / %lu / %lu)", + bytes, page_size, nr_parallel); usage(); } =20 --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E25B1BEF77 for ; Tue, 11 Mar 2025 13:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699113; cv=none; b=XUNHGdywxZ0PoDI5Szl/sMb1n9PR2oqlBoyxfg1rX0ZFeDJ5PMASjdgeSSMZBw0/k53CzhKA3so/0qURTmFpWgip2xKhdAxknEuxEWxAp5at4duGJvxb+bhLlrFdKn/iKbHP1IBKmvbOprGLXjQKIdTUrL+Rmqen4hpAuo7h+1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699113; c=relaxed/simple; bh=WQLjLeaas6WAwWHU6F3llD+u+5uqTYbAeh753X/DebM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=KSmJh8ykMwAx3VJraBD91NOh7nzHMjfPrBI7h28zNJKBCd9Qw6ayjZlyIlHI1CojoaWGay/nXVwzX+5B2JvjwZ2UNsdoK8x3AVbjqQ6FzvlU8aQOTdWpg/GTGPkvxKrIwgtzce5Nh4Y/vHn40nzG7SZSUFbfX6n/dGuWmDyMnBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=wJkL+yO3; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wJkL+yO3" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43cf64f1dc5so12734775e9.2 for ; Tue, 11 Mar 2025 06:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699110; x=1742303910; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=E6JjfJOQBkddVu8mbUCQ3JSQzc9s8ZEC60spagx9Tws=; b=wJkL+yO3fIf93hkxRU4CwbWrCDY5tFDTWFNH6DBMUqPtX7rKwvOgdqCAngYBtCNlng //5MUduIipEG+b2DFVYOxnw0VBrABqm6/i3pe3da5sSdbssLKWKHedQ2GLcwyAznD1Lw LOjkPWj0d+EpmzVC4bSoEuA/xMzAQQ2K95WADFDbFIPQ+YFIH/guvc5vQvhrHSGhx5Dv efLIy4K0NukjDKXvA4nEKXGhd/Sbe5mDJQ6BFJzkuqVUtNB4Pnz3D4L/s4li+YHCMUhq bqSzsW7qQNSLlzkqf5AZO6j/VJCoCMvAyUJavYLrR3ZvTC7T8YuO9WyJFziS5jUa3Wgu s6/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699110; x=1742303910; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E6JjfJOQBkddVu8mbUCQ3JSQzc9s8ZEC60spagx9Tws=; b=Nx5CO+ajcxDAId2T2sQ6wqziE/ewDPaFOHo1zWdmaTzo5LVKz7KgKtzFGkJ5pI2MMy wcbG/xkVbYBoOzES4jf/YHtiMH/9bYDSygjCS92pabx7rLRfeHjoRI6aegqeduSJ2W54 WkIANS10Kp+98WGdwUFucMRHh8SdNvH98dj588ydTjF0Nq1H0TpoeY+SD4ozW1IoMY7F bX8chlmS16h1wVgwh8PbDlJvxm1yTvLRbrQWkHnCEBqLNziZMEXv+bsR50worZ7bmf9o O92Qw5HYPL1kDStG/Fwu0no8ziRnY8ixslfXdFlCDdnaNj6LVhVwJkePayBPxPHdBVLl Ephg== X-Forwarded-Encrypted: i=1; AJvYcCXL7U/KLiBGMuH8gu583yosx2UWTy80+Po3F/k4jkB1q8tJLeqCekjsYz8klepp4d8/e5O8K8Qhbw4BEaU=@vger.kernel.org X-Gm-Message-State: AOJu0YzvawUkhBWG8daW52q66DCKliw5rGI2CAwxbXPhblyCJo341OTm 49UKeLx4jk7SZQvxnenhZ7wc479/0bYTImWZbcrthd+yJlnuRbMoh1Jep+6B+mk9BXErjIOWFoP YfamFKZhWCw== X-Google-Smtp-Source: AGHT+IEIWvgrPAdW1aYeAn80KnMmveyrFiqXf2KEYlIp8fmgFPw+5h8vHeMIpGYZnJb/sky5I2oxhtfkiMAT0Q== X-Received: from wmbbe8.prod.google.com ([2002:a05:600c:1e88:b0:43c:faa1:bb58]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4316:b0:43c:e70d:44f9 with SMTP id 5b1f17b1804b1-43ce70d46f4mr104149745e9.18.1741699110016; Tue, 11 Mar 2025 06:18:30 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:17 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-6-dec210a658f5@google.com> Subject: [PATCH v4 06/12] selftests/mm: Don't fail uffd-stress if too many CPUs From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman , Mateusz Guzik Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This calculation divides a fixed parameter by an environment-dependent parameter i.e. the number of CPUs. The simple way to avoid machine-specific failures here is to just put a cap on the max value of the latter. Suggested-by: Mateusz Guzik Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selft= ests/mm/uffd-stress.c index 4ba5bf13a0108435ce8b53340b9e17ccd47e859e..40af7f67c4074d901be6608e5d6= 4bd0490026dae 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -435,6 +435,7 @@ static void sigalrm(int sig) =20 int main(int argc, char **argv) { + unsigned long nr_cpus; size_t bytes; =20 if (argc < 4) @@ -453,7 +454,15 @@ int main(int argc, char **argv) return KSFT_SKIP; } =20 - nr_parallel =3D sysconf(_SC_NPROCESSORS_ONLN); + nr_cpus =3D sysconf(_SC_NPROCESSORS_ONLN); + if (nr_cpus > 32) { + /* Don't let calculation below go to zero. */ + ksft_print_msg("_SC_NPROCESSORS_ONLN (%lu) too large, capping nr_threads= to 32\n", + nr_cpus); + nr_parallel =3D 32; + } else { + nr_parallel =3D nr_cpus; + } =20 nr_pages_per_cpu =3D bytes / page_size / nr_parallel; if (!nr_pages_per_cpu) { --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A7B51D86FF for ; Tue, 11 Mar 2025 13:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699115; cv=none; b=G1dX6M11lxkhkX/8U9fZVmKpTsdP7jlyIVUKkd5wiECUEyAsXoei88QU83gMYb4ffSFtBXCTDyGGxfvGv8LEBcZjvxBUXR3aiK60d9BrtuOnFBvKLyh3Z8Q1MNYeQT+pgJVoc2qgKm32H9ZpIfGSlsNk4nkBDIfE9fwXBpmSKEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699115; c=relaxed/simple; bh=oSXuPp+IUOl5G2aP9gTCdmTe3j7rVMOxHg2aJoo6Efg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=a2YC6HhZxZ3FXYSmYb/pkDLvhPcsfhAh7PY1vJ2FpCBQqZPS+GPHo5CT5nUayxzs+YbABsymZAHst9R9NYNGytBaQ5CGcUZuyf3O79rA46CbMjqvKWhPE9jFEabvpTG50GxaS9T6DaIQt9Oc2I49PWrU2976gpsYDXOdthFvrLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=k2yLkTxQ; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="k2yLkTxQ" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43bd8fd03a2so26654925e9.3 for ; Tue, 11 Mar 2025 06:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699112; x=1742303912; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Vce7eh8mPMitMWqdtTQW3Xgxbt0OG8W7iuQCUiRo4Hc=; b=k2yLkTxQ2K7t2n59+V3hFbYpdZD6A/EB8ugtx/QgGx4dtG91o0lsNwbTBFftlyrDcG ePsgnqUCvkeAkHYrhj6BwgbSa1fWnDN+qRvKnxU9L6jlBvk3otMVj1HvPhoXhtWyXQ2i VnNoWZWUXpyDWrhcPhsM7OZgIqBeGCdoRw6VENCQQ+HI2VtPi8iGMoaeHQQxj1iSlLDS DlyBQHd70iZw9jkzdb4vocACpbwwOi1JEoZl5ogskJJeLzl5L4ANuY7D/R5CreBMEvnl GeuBxaep58xgXsyCeYvf+UsrFyfl8qKBcDJDNLNEn9iJQQw6u45ttvXHX9FzaUvz7aOB lXRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699112; x=1742303912; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vce7eh8mPMitMWqdtTQW3Xgxbt0OG8W7iuQCUiRo4Hc=; b=eN+lZN5MgyVDHGgzugUSbHwNrtm3jUJKq55qZNzFgIvyBl2G+7hmAAAWVsQQlf/4fH IPukOm2XhvloOE5kQyU18gMdp3/JCcZmC0i74/fX47HosEKLO62xFrfCvpf2b/eYZ//t lAFqZzphyaKNZhbUVUxJ6AjIrdWIbgntkw2Np2ZKxTcwo5cwCgaAZu3gfDvSuHAcYlMi nantEpW8IDkNuyfcYUJcnnM1ALey6C2wxvpSQq46XVI3sqwmhTAa/FMJeOiwqSALdDZ7 qvnDCVK6Eyt6BGfRHV+Q0piJlsW9yY0VlRYS0RB9Qu3f9xRRgwImNdrRBoqsksdq6qt5 rIcg== X-Forwarded-Encrypted: i=1; AJvYcCXjDxyZ7Y+XzIkrIpttHqLRy+4+QcrGwHFuN05wrQi6Imj5mOuBv/SiyORyYgnF88i2RDcknQ33X0BJZtw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd8ZET/sJL9NP0VlTMGzCQOube/YF+dPqJkZ/hAX7sTdsK6ZKY IwHGylsXeuKzGlKw0vFQ1cS4jtLREn+RKrnkwqbpBKOPP5L+DyXpqWBkw6Igw6fH9Yysv+AMuKI Bsw+VFMfS4Q== X-Google-Smtp-Source: AGHT+IH0f6ArUDAT+Z1aqU0gEtWgWP4WVJVxUFx2+ko5jUv3CK2PIBB6GlZGbkJUJj1SHrJwdvtnC7ZX3WPGDQ== X-Received: from wmbbi10.prod.google.com ([2002:a05:600c:3d8a:b0:43d:7e5:30f0]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:45c6:b0:43c:e7ae:4bcf with SMTP id 5b1f17b1804b1-43ce7ae4f6cmr119062035e9.0.1741699112009; Tue, 11 Mar 2025 06:18:32 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:18 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-7-dec210a658f5@google.com> Subject: [PATCH v4 07/12] selftests/mm: Skip map_populate on weird filesystems From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It seems that 9pfs does not allow truncating unlinked files, Mark Brown has noted that NFS may also behave this way. It doesn't seem quite right to call this a "bug" but it's probably a special enough case that it makes sense for the test to just SKIP if it happens. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/map_populate.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/mm/map_populate.c b/tools/testing/self= tests/mm/map_populate.c index 5c8a53869b1bd287b09a250edf628a66c25c2439..433e54fb634f793f2eb4c53ba6b= 791045c9f4986 100644 --- a/tools/testing/selftests/mm/map_populate.c +++ b/tools/testing/selftests/mm/map_populate.c @@ -87,6 +87,13 @@ int main(int argc, char **argv) BUG_ON(!ftmp, "tmpfile()"); =20 ret =3D ftruncate(fileno(ftmp), MMAP_SZ); + if (ret < 0 && errno =3D=3D ENOENT) { + /* + * This probably means tmpfile() made a file on a filesystem + * that doesn't handle temporary files the way we want. + */ + ksft_exit_skip("ftruncate(fileno(tmpfile())) gave ENOENT, weird filesyst= em?\n"); + } BUG_ON(ret, "ftruncate()"); =20 smap =3D mmap(0, MMAP_SZ, PROT_READ | PROT_WRITE, --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8FCF2222BC for ; Tue, 11 Mar 2025 13:18:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699117; cv=none; b=Pdnur/mYPpDLRHoaVh/tyKA9DCVcfHQVKbR3v0ENAGBRdgfPPLuIycn37Ba0K7OvAdV/+BGZeS7/C1vQxlntFa4qe3NTFB/xmDH2AkgVIzvZADwj/gnOZctvFzfWdLkZLDrWnJxbGDFLJz9z09tfZO8ZFXSOy+pTfR1z+draB/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699117; c=relaxed/simple; bh=0ffvNk6pyNEvDSJ71JGiz95WEqGo3Pzu7Vx603nXPak=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Da94of0uo1eLjB5KQt70zmEaf/29txrscNSQPswrzb6o17x0UD4wMqU1RzwWLLilDvOzeseS6haAQbMGdnVgn4lEneMEeodQfUxuvDnBQdF48DGzklZLN83UauoPqd0e3CrLj5ZXNPVAReiTUoATX8p4DLtL5PFJ6w/joSldYbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yu471ND5; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yu471ND5" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-438da39bb69so38726525e9.0 for ; Tue, 11 Mar 2025 06:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699114; x=1742303914; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vEpPGTTI1xwsz2Fyvp18/EwqSXfTpjR75q3+Kl9ryQ0=; b=yu471ND5enBTBqHrJbxY8o/M7TppQgg9d+D0V12Zxwykl9xD1ialBSGin3kbi5NWpd 2b23svAeQEQY/mP1iC1+pahEfXx/nvQUHMnK+A0gquSZwGApqdNXkbmW88P1qmHJhbw4 uGTtn1MNsoS5GGwlfPVxJO49kirfmqg9/3hTVTbeCfsFsaSUYiYmJ21EpS2ikFg0a7+9 mlssHdfiimWgVZNzWf8Uv2QxYhmt6T6CvkczgNFacudosMfBLVlopW+6SuJCznZJ8ZwV oP/6rKQdZnhE2oqTJsnhv8qkJq6wAl/I8eL6ie8eIACrvrYd2Q+83gdmoY9yUX4h6pDm j/gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699114; x=1742303914; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vEpPGTTI1xwsz2Fyvp18/EwqSXfTpjR75q3+Kl9ryQ0=; b=c7owYc6J7hA4IbESbnQCkYYdcJa1ytd/NwA2W2xI9CPJbm4mQj2OFKrV19Y4WnLfeP dXYrZ6R9Xo2bq2KJkFmsDq363cjXoAfx5XDkGe5NFs8qLMD28nkPNkb9ppddQarN0Wn7 tJeT88X2dKBm/Ex153IV00pAVS1SM8RD7C7vh2P1zLMqI4UgC/Toy7NJP/VAzJVGPfIj zxrFRmSuFEIePfyu7ZpMCJgLopHXSrLr36WdDTo985Yz7iCIA95S73OzYS8OGZWIqPCY LgHeBg34DPb/whMJSjzXC/gCFEzBr1+VHIQiv5elE1yJwqyMg+90XPLebI9FoXoroJD6 CfCg== X-Forwarded-Encrypted: i=1; AJvYcCXuWk7bk0T9C0mqvq6n8aySbg7m+gjm7FwjW5PNIE4PIQsSAZ0zmbwcZytEqSuSyaKZ4GvoG3CD3rgEPbo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1qhvZ73QO3yNIdyXGv1SG0AlpKgy5Ueq0LQCemRtmdUThOo+q bfhim4kvVku+3BRrZcVJPoNmbc/79zjFxrrVR1s4ClNTbSKQLy3vIrSr2C2at5ezvtxS4aQr5Aw FmiMa8FxQGw== X-Google-Smtp-Source: AGHT+IF4wKnonit+EpSv5UW7OYNEJNWqpKGUxuJH1HQv+WZ5yf0iB3xBzk58+Z6A+0FjREeEmIvwD2nZ9cCRYA== X-Received: from wmgg10.prod.google.com ([2002:a05:600d:a:b0:43d:10b:2c42]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1547:b0:43c:fceb:91f with SMTP id 5b1f17b1804b1-43cfceb0aedmr83968355e9.11.1741699114176; Tue, 11 Mar 2025 06:18:34 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:19 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-8-dec210a658f5@google.com> Subject: [PATCH v4 08/12] selftests/mm: Skip gup_longterm tests on weird filesystems From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Some filesystems don't support ftruncate()ing unlinked files. They return ENOENT. In that case, skip the test. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/self= tests/mm/gup_longterm.c index 15335820656b1c143b440b8a1065a025378e22a2..03271442aae5aed060fd44010df= 552a2eedcdafc 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,7 +96,15 @@ static void do_test(int fd, size_t size, enum test_type = type, bool shared) int ret; =20 if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); + if (errno =3D=3D ENOENT) { + /* + * This can happen if the file has been unlinked and the + * filesystem doesn't support truncating unlinked files. + */ + ksft_test_result_skip("ftruncate() failed with ENOENT\n"); + } else { + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); + } return; } =20 --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90669255E23 for ; Tue, 11 Mar 2025 13:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699119; cv=none; b=HmDIlmPj9KOoN/c8p0opsjgvsDlKxc0KFHrjvnLfd2i08569/62FhOjVFoMCIQXBVZlqKauqioP+6RWxa0JkhFMfwDVGJqt9N4LnKbk18KBv0Dk8JRSbC6qrY6LQ5zjOCJ3/uFRr7vpnD9d+xE7/WmrAMoND/T5WjI9RLLnIo/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699119; c=relaxed/simple; bh=TZCEoOVscJhi1eVQtBkTLxAR5uWerpL1QhTHsmZs710=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HVnqYuSM6volUkMRmzGgDAOgdHqA9LbNwICLwU8UyhCNwDRfBhwitZEfLmbxGFQPIqCVk/e2BmiPQHEMbvjZoclrwDx0iGxEawq22mO/TESHi+pO5XLwIiSiVzrojuyApKbHnyq+h0Y15AeDyusqm7YuS0YTxLDNzFVYVDnwzc4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gPIargED; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gPIargED" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43bc97e6360so27363225e9.3 for ; Tue, 11 Mar 2025 06:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699116; x=1742303916; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ezfRKweWcsi8VDsOy21QFyFbC65YGuaZroNiYeoxlPc=; b=gPIargED1npa5FTeBubhvT9SAcepTZ61BqJzmsJ7P3EGcVoCvbdkmQqKt5UtgCZMbB yc3yrxi33zkJH/OhaugWuqtxrs4VLF9cj8UNB8Pu2xWgpmPOPGvyGgwAE9rcVIw39hBH yw1Gi/rHxoq6c9ajpxKuS61ZFgKu6PH8pWBGo5rXFdteiCx6O32eKUPyz44xVXB2YsNC r0OxccIIXrQijIFVSuJxr1PY1XbexowNrwCWG8izUr4Wn+rmqp5vxRb+qgohgBEPUQc8 Kh02e+nax9M/bJBOCjRmbnNu6MYAJc3e7DTmQYMzjz1WOyqsJsxcSLlJ0NbOvbwhZK4p tW7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699116; x=1742303916; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ezfRKweWcsi8VDsOy21QFyFbC65YGuaZroNiYeoxlPc=; b=ACrJLfU1s55lKHBL597XsmOoUNVQfA1vnEzV62iJxA2oWt5Yr8/6K2dzVJfrJBy5bj 5QQ8x6UQCRs1loX/bmLvSMc+8e0ajmlveGK1OnQtvCjpX3DsVYy0z85FoII0xgbLmmUk gGgYKHmNOCl9Z/GvlEhbdZUiJ+7Mr1HOc/3X5oranUcdKOXk7kru3Xe0bzotcUmpjtrz mjxsM6DGBQ1/f2a02kWlYkInWucT4/6T3WRa4hkSwj2IW2sWyLw2kHXPIkENJAsnhuzJ NmOOzJ6T34X7Ut0MTGYYoniTlkNzsRlQlQ2Lg5QGo2oCUK9nT23gC5GKc65kbDhdFEb7 SBGQ== X-Forwarded-Encrypted: i=1; AJvYcCXT3RbYy8U8xxwvPRcUroEaev72VDpwlwgflD3yWc+KrUAQR099HVsBVCWMtE+50uBNzmwf5bDDu5IVFA8=@vger.kernel.org X-Gm-Message-State: AOJu0YzN45CGtxmhaEGcE13ZRG+cr+ajFVEfa7M1KLR2pCNfK7G6RbwG MpG7cDIcRJ6l7bY0LiFVKluxhuU2dVpg1wjVF3KTPCF8KnvFKxC+oND8fZe+oEdJcL96KbQogho 4YwazTkqT8A== X-Google-Smtp-Source: AGHT+IGM8dDbafePeprrNK04mscqi9s1n3LRsj1p3n0Stvsl5Ct+lcHP80x8iiWL53VzzL0Jri/DkBOybzhFEg== X-Received: from wmbet7.prod.google.com ([2002:a05:600c:8187:b0:43c:fad4:7595]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:35d1:b0:43d:53c:1ad6 with SMTP id 5b1f17b1804b1-43d053c1decmr18085815e9.26.1741699116150; Tue, 11 Mar 2025 06:18:36 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:20 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-9-dec210a658f5@google.com> Subject: [PATCH v4 09/12] selftests/mm: Drop unnecessary sudo usage From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This script must be run as root anyway (see all the writing to privileged files in /proc etc). Remove the unnecessary use of sudo to avoid breaking on single-user systems that don't have sudo. This also avoids confusing readers. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/self= tests/mm/run_vmtests.sh index da7e266681031d2772fb0c4139648904a18e0bf9..0f9fe757c3320a6551e39b6d455= 2fd4874b0bf43 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -386,7 +386,7 @@ CATEGORY=3D"madv_populate" run_test ./madv_populate =20 if [ -x ./memfd_secret ] then -(echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix +(echo 0 > /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix CATEGORY=3D"memfd_secret" run_test ./memfd_secret fi =20 --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B9802571A3 for ; Tue, 11 Mar 2025 13:18:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699121; cv=none; b=PAhw86UrjqpEgzZEVxOxFLX39KVwlf65A8nHQ3cemYJdwMaCE1iHtKoPOo9AG2v/MmNIKpwuDc7Rg2jBmHhqMiB/1c5Gw/b9ows5rIYZK6WD0yUcqP3CPdlicGKfq7LAYKMojegXIk4KDHzSew1m3a9Fg/03y3agieTbEV0i6y0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699121; c=relaxed/simple; bh=keuqAf1Yd7pMC60Jehq/im4QvYhNmbzI5DqGZpBJqLI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=B6ZlPmAlgJMOvuuNEFDRN2+My/3OCboNuv8mGR545AT2Te/W0Mt6pURRQ9tfPtOVI3+HTnIkQGXusw2T6GPzISsXywhBLZu8xsXWu3Ge3lvuBtr4tqk3eD7Q4aCDEqWWPDu/77qLCxRgoJYrqlFtsi7jsMdVMrsCdMrY2+PkCt8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=r8u+PQK9; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="r8u+PQK9" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43d00017e9dso9065545e9.0 for ; Tue, 11 Mar 2025 06:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699118; x=1742303918; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=h7ic2pHOinjRIlh+O43kggDBsm61b3OXoKlUUGdMcQQ=; b=r8u+PQK9GbqRfxVUanAZh6A/XMo4EDT2oMZ1q8Uo/0jpRjQuNHIxczEEHPIm9oPzgu c3yIthtIbM+U8OMSBHSotcuAfucj6NmSybVqopKRA+qM3dCPhgcJKO8jxGnOiAU3PqR9 J9Xr+kdubXkcNeLEeNXf8NoRE7dK+gVMblUPc4PrS2yqHmzwIriUFFFnko5gDmv0vYPM VdWX6OK6oV/yMIwc0Cs5TUeyYCg6qi9MvV7kalpzmQIcaK5Omk1ClmiW4LE4LTsUbGHz JIsOXoOo2vnLtzrO/w9C72qZ+RUC/2UiWcX5+aPpYzN9WXwq9KnmNuMxNNQ+rr9X5Z4S nCBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699118; x=1742303918; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h7ic2pHOinjRIlh+O43kggDBsm61b3OXoKlUUGdMcQQ=; b=eZ+pUig2GmXI/Q5Z1Ao+qgYJrxs1bxYpPwUEF7qLQ4aCBaFpgzBkZcfqe6BhbVj9Sv 0JdZuPzWnM7pK0wPZU0ptb/GuMmVmi2I1dvfLq4M6gzD0czSk26It3AfDX0cXvwvMtY1 wJo0F0NqnWEaBpvytJ5KYWZAbvXsCS3dfSVZ/QqgM8FxXEJBe2EBOxwXo7omAg2yHeYf 1GeN0geOM3sZBHxcy+vO4gsqGm1IQ6qmuNAAe/HafYTNQiSqAPXUJuWywQz6N7kS0uQ/ A96RqiOfUGoPsBvI1GwOskh2FXsLzsIpby8iwGhBcWJa7umitaSKET+52A2rSI6+7YCi uiPg== X-Forwarded-Encrypted: i=1; AJvYcCWe8qrlq9ui45vKt8UkFVb44efva9wkjhFALNJOJbwYcNcgt4m8tcC93/TH15BQR2NC3K6HXd/DGO4HpDo=@vger.kernel.org X-Gm-Message-State: AOJu0YxbpbjlV0oL410edDv98RG24DthEuGl1tg/koVUfmXy2xpKLJ/q qctr85vFUQCmu9Tut37aB32S+xtcAcyZGieOSolhUeJTBnAMq65BPtpG2Oj5M+xrFp3xuYw4n0F UxbErG2cUbg== X-Google-Smtp-Source: AGHT+IHZlMGTcKX5RZ/uPw4+acv8n0aHStFuR6vrPyvpA6CiIDxxzLWRCjz5dgJEeQYAtTRRHyrT3C1VMcyAzA== X-Received: from wmbea7.prod.google.com ([2002:a05:600c:6747:b0:43c:f8e5:6033]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3586:b0:43c:ec4c:25b1 with SMTP id 5b1f17b1804b1-43cec4c26d2mr91373805e9.23.1741699118100; Tue, 11 Mar 2025 06:18:38 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:21 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-10-dec210a658f5@google.com> Subject: [PATCH v4 10/12] selftests/mm: Ensure uffd-wp-mremap gets pages of each size From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This test allocates a page of every available size and doesn't have any SKIP logic if the allocation fails. So, ensure it's available and skip the test if we can't do so. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/self= tests/mm/run_vmtests.sh index 0f9fe757c3320a6551e39b6d4552fd4874b0bf43..e86ef8cb37d00e572be8cf0ea9c= c8246d4eecd7e 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -309,9 +309,30 @@ CATEGORY=3D"userfaultfd" run_test ${uffd_stress_bin} h= ugetlb "$half_ufd_size_MB" 3 CATEGORY=3D"userfaultfd" run_test ${uffd_stress_bin} hugetlb-private "$hal= f_ufd_size_MB" 32 CATEGORY=3D"userfaultfd" run_test ${uffd_stress_bin} shmem 20 16 CATEGORY=3D"userfaultfd" run_test ${uffd_stress_bin} shmem-private 20 16 -CATEGORY=3D"userfaultfd" run_test ./uffd-wp-mremap +# uffd-wp-mremap requires at least one page of each size. +have_all_size_hugepgs=3Dtrue +declare -A nr_size_hugepgs +for f in /sys/kernel/mm/hugepages/**/nr_hugepages; do + old=3D$(cat $f) + nr_size_hugepgs["$f"]=3D"$old" + if [ "$old" =3D=3D 0 ]; then + echo 1 > "$f" + fi + if [ $(cat "$f") =3D=3D 0 ]; then + have_all_size_hugepgs=3Dfalse + break + fi +done +if $have_all_size_hugepgs; then + CATEGORY=3D"userfaultfd" run_test ./uffd-wp-mremap +else + echo "# SKIP ./uffd-wp-mremap" +fi =20 #cleanup +for f in "${!nr_size_hugepgs[@]}"; do + echo "${nr_size_hugepgs["$f"]}" > "$f" +done echo "$nr_hugepgs" > /proc/sys/vm/nr_hugepages =20 CATEGORY=3D"compaction" run_test ./compaction_test --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 774C1257AEC for ; Tue, 11 Mar 2025 13:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699124; cv=none; b=AyYYk6ePDHzx+q4shUtMyTbUwwCr9cjsKYiwUof50cUlV4YGMmeyKw53zPBFj43fz9a6HVVwg2c+KAAQaWjmrCNavL+f5K5g0CdVdYgCjh9P/on+3n21ykZpYPM2a2JLWsIGY5bIAQ0RugF7vursPWKhumDxPCAJMtlKBEiXipE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699124; c=relaxed/simple; bh=cpB8G5qu+8qB5CaAmCrhUFZfkRWT/4ipT85Ja0ySsMc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=gCxwGFDtYCqMTK7OFWyfUU1PHoXF6rpSIrWGcEJq1SxM1kZY2IqR1OwnHDaIPEfjU+1a1SGWU35JN7R/+7YcvZsJSQ+tmfZE5yMLDaj/6CVq49S+7rKU0SAZWcJZv+YLescEjVTxrZ3GDwMCgdjNXqFolCoJ6ZVtluT0fCfU2Qs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RVRagUag; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RVRagUag" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43ce245c5acso26256015e9.2 for ; Tue, 11 Mar 2025 06:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699120; x=1742303920; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=AK0S7bcFsX0odpC5RGhRJMkWaOy0j3srCbmbQDGiiBc=; b=RVRagUag7pOLcuZaLduo9a8ik0O+cCOy+ksP98v6w3foNhEejsY7lomibuB1dOzPOv B/2agTO6Xv4f1UceU8u22GOEDCt/Su0ToFd7fmHZyF3Nou/aO8TLUBG0X36O4LsyBEwD W7IuGpdsAqr3L9LIQMBlQbZcnS9Kn4RjO9Fu/aosnt4oxl0rZN3Tko99wdB9hCnO+2nF lqYq1Ep96mzpxVctBwGmPrCkM9RjlWIb9IA4JjE1jOGMi5Z1WXqy6ky54EYv/3aaCIJe Jy1XItIpCxdFSnyHE0XAPHLlRRTQ9YA0B1r3cViip5l73r0lYlwHO8Vkm4zhp9sy9lnd P7CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699120; x=1742303920; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AK0S7bcFsX0odpC5RGhRJMkWaOy0j3srCbmbQDGiiBc=; b=JQBvWX7BPQbsGP0vfYmhbCShk1Ff9pBcEPwdbGIKblNpjnAgbaGyIx0Ppfu71Q+ZCw OSf96uzmA59ewftPd7uChbjhnFH9XrNOOYRK54UxtjZxC27rV0R1C9T1fREYhZ97qI5U tf5ibc/qLtk0uNrQAgVGrEyTbSC7foM32qSfB55sVIhcbN3Q2sxhfmZPxtg7TNYnBG20 1IOzpCetZUbLdzUI7z+Nphjw7NoR4rwjsD8wbylzEFkN0pwS1SibaW7mU6acb75F+NF0 UwbUwia14QaJRZNZ/I5O76in0Kx0wX/ecqPFRfheg5/C/Yq8Z7uPzXZIqLajjD7/RlEr E/uQ== X-Forwarded-Encrypted: i=1; AJvYcCW/Pc/FF/62VAjEfHLZM3ex5nkzqED9b0BZa4y042OS0ygD+hspCcZIJEIGhD9MHS7nbZBqvUsaoOtVHIQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyOm5CwiPc8ldATJp5ur/+Dq14w60IXKtAjmnjbjCmWCzILa/d/ W6UKn4KU8zH21IvulTZIDWB7IQqR3GIO/DCj9qifTHp6827Sie7ySuUiZCScKc4VQL3By8gGW0V 3Aa9XD0aOXQ== X-Google-Smtp-Source: AGHT+IFnEky9E+WTZ67n4oDhD85FHBGvf1ZaUlsC4CSzVhw94LW+c4vdMdF17ZTVjJHaNu8o0hoGt9vNnRMLVA== X-Received: from wmpz18.prod.google.com ([2002:a05:600c:a12:b0:43c:ebbe:4bce]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:444d:b0:43c:fe15:41cb with SMTP id 5b1f17b1804b1-43cfe154379mr72788015e9.15.1741699119995; Tue, 11 Mar 2025 06:18:39 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:22 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-11-dec210a658f5@google.com> Subject: [PATCH v4 11/12] selftests/mm: Skip mlock tests if nobody user can't read it From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable If running from a directory that can't be read by unprivileged users, executing on-fault-test via the nobody user will fail. The kselftest build does give the file the correct permissions, but after being installed it might be in a directory without global execute permissions. Since the script can't safely fix that, just skip if it happens. Note that the stderr of the `ls` command is unfiltered meaning the user sees a "permission denied" error that can help inform them why the test was skipped. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/self= tests/mm/run_vmtests.sh index e86ef8cb37d00e572be8cf0ea9cc8246d4eecd7e..1467594b594c4fb1dceae875fe7= 616ecc3cd9382 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -337,7 +337,7 @@ echo "$nr_hugepgs" > /proc/sys/vm/nr_hugepages =20 CATEGORY=3D"compaction" run_test ./compaction_test =20 -if command -v sudo &> /dev/null; +if command -v sudo &> /dev/null && sudo -u nobody ls ./on-fault-limit >/de= v/null; then CATEGORY=3D"mlock" run_test sudo -u nobody ./on-fault-limit else --=20 2.49.0.rc0.332.g42c0ae87b1-goog From nobody Tue Dec 16 11:09:22 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FC9D1ADC93 for ; Tue, 11 Mar 2025 13:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699126; cv=none; b=iG6OOnaVpA18gE5EgWMQJnFRXjROwR+3oUWZ0dhH/m8NImFfF4NbrDx5zS559vTnsyfvmhfk5f5YDgvY7aKnaVPlJpQUN+GFO3ibw+VOE/DmrpuAP6ti2g3yRxwIIn9IE2RfGB15+SsXRPqGilUVj/UPnA1cJYRHntbQibILmdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699126; c=relaxed/simple; bh=Bvrdg6/K54PEW5JZWuRIH9o+4LbgcalZobFw2iLsFJc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=BGym26RJzpmZAokH3KOEnm+5ljw5fkONCu3QyyrTkB98NbdDnVDYlRp6tKbGBJQiC5jSYVK7LfUY1JCfeFPKfpRw7iforKOAVuPc6wNqK1iRNHeRAuO7wfQ8Klr4kBwZJOar8MPPhDDqnbcNPliSTWaM/CU2WpzdZSRoE7HzG8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZLLQP4AQ; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZLLQP4AQ" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43935e09897so37961505e9.1 for ; Tue, 11 Mar 2025 06:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699122; x=1742303922; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=YKUi+ss9u14qyT/Zwiy2mGBFpcrhT9F3tYQ4X8eVY2g=; b=ZLLQP4AQ/86m29e6rCRtWMtTeJ4eEWH/rlCpuDIVCXqMbKe8fNV+q1YlPeFtxuxIe+ lAr8koA09fyMkn8vlutvIDmUd/99XooEfmYR9a0regP8NemB1GH4ktvpygDyoIYuODsj AFl4V8pwzyMqeK4ZCKYmKEnypV9+1BEKgQTBL5ACML5k8SWU+6u5ExAQnh2n+S7R5R9j xyG7Jv1ypj29SGit1zzZFooCWJY6vRo69jZyCQjHui9JVoa6TQCaH5oKRb+dUCORjpTP xvjiCOnEHtljnCeJWwENRqkIP869oshjj3KTJQBrP+g4v5vM2Pf7ywFYKd9wuh//0Hq/ DobQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699122; x=1742303922; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YKUi+ss9u14qyT/Zwiy2mGBFpcrhT9F3tYQ4X8eVY2g=; b=MmaMnhkX6yGwvlUGR0tF4CzBt4vEGKeXKQsZCnh5KfW7pQS/V0j5/koI/bWw/kSOcC b+v1x1WYepw1pOTzR4J75c6KRtAWXTmMbeAIt9h4OSIhga3x1u0ofl9pK1skQhMYJuU0 snTpzCR/LBIm0gLILl3YTtGqn5CWUIoHm/lDNdfNAdNnpq+ke1c/W/UQY9WL5Il5fDH8 6rWIbt104YcC8vfavqhHUNh8pqokXukVrmVeo5qw7xk3gZHJ4csLmKpFeOYkqBeDTAv+ NFRS9O5huFE05kWDPwgocIH73C+5DfawGZIIhcykMSyj2w75704XiVYqLw+IQ6F+QUtD bvfg== X-Forwarded-Encrypted: i=1; AJvYcCVRTgJIXlw928Xs/aVg6Jo190BepBKQP/G22sbTY5j/wESP0u03xfGryDi9EkonU7FRy3Y07uiM9KDWlCY=@vger.kernel.org X-Gm-Message-State: AOJu0YzbhhbyHkZhOBscVmZkLXdP4AJYw0Jge8gDbrMu0Ip6TpKEQWth mnLWP+b58uE5KWUcfZT8lrvXsbzETfgd/d52JARcmvRzb5jccEhK8IkTrwqZkV1FC+hRFYXzZ8N 3kV06l+uo0A== X-Google-Smtp-Source: AGHT+IFEGPTY7Ml+tuTOynefjzLO+UpkB6moVI+rzTawpqu6Ohcjxyu/ir2TjMNVGvCGq6alb9Lb1cZqdGxcFw== X-Received: from wmpz18.prod.google.com ([2002:a05:600c:a12:b0:43c:ebbe:4bce]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:6d9a:b0:43c:ef55:f1e8 with SMTP id 5b1f17b1804b1-43cef55f398mr97810345e9.13.1741699121899; Tue, 11 Mar 2025 06:18:41 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:23 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-12-dec210a658f5@google.com> Subject: [PATCH v4 12/12] selftests/mm/mlock: Print error on failure From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It's not really possible to start diagnosing this without knowing the actual error. Also update the mlock2 helper to behave like libc would by setting errno and returning -1. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/mlock-random-test.c | 4 ++-- tools/testing/selftests/mm/mlock2.h | 8 +++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/mlock-random-test.c b/tools/testing= /selftests/mm/mlock-random-test.c index 1cd80b0f76c33f04ef01f4dee6602f28b6a7c991..b8d7e966f44c67e5606d384bd66= 0e5a4e5e8fda9 100644 --- a/tools/testing/selftests/mm/mlock-random-test.c +++ b/tools/testing/selftests/mm/mlock-random-test.c @@ -161,9 +161,9 @@ static void test_mlock_within_limit(char *p, int alloc_= size) MLOCK_ONFAULT); =20 if (ret) - ksft_exit_fail_msg("%s() failure at |%p(%d)| mlock:|%p(%d)|\n", + ksft_exit_fail_msg("%s() failure (%s) at |%p(%d)| mlock:|%p(%d)|\n", is_mlock ? "mlock" : "mlock2", - p, alloc_size, + strerror(errno), p, alloc_size, p + start_offset, lock_size); } =20 diff --git a/tools/testing/selftests/mm/mlock2.h b/tools/testing/selftests/= mm/mlock2.h index 4417eaa5cfb78ba2bb0f51d3418c9b768ff0fe90..81e77fa41901a095cc041e05d01= da7dffbf2f4fe 100644 --- a/tools/testing/selftests/mm/mlock2.h +++ b/tools/testing/selftests/mm/mlock2.h @@ -6,7 +6,13 @@ =20 static int mlock2_(void *start, size_t len, int flags) { - return syscall(__NR_mlock2, start, len, flags); + int ret =3D syscall(__NR_mlock2, start, len, flags); + + if (ret) { + errno =3D ret; + return -1; + } + return 0; } =20 static FILE *seek_to_smaps_entry(unsigned long addr) --=20 2.49.0.rc0.332.g42c0ae87b1-goog