From nobody Sat Feb 7 13:41:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27AED288A5; Mon, 10 Mar 2025 19:45:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741635944; cv=none; b=iNlnuJCHMVf5iPWpHOIKNbqRt64uU1kUAuuSBxtpxTlU8lsG6dm+87iqJrzSw3ZEEUR6k4Vmxl1q38C9BTUXLu6Yu7FL2pDPq4HtfJucmKa6yS5Sb36sDa1dAVR2m2KmGlhVdg5UcNl+J9h3waZLOKuU8tud06s91WtCX1c8FyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741635944; c=relaxed/simple; bh=l1FDuMJU96isGCHJ2N/qe2WIo8RAdJvFaAqFz1/i3ss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n0SbeV5yP3NdLtQreG3pJqAWfIHUGkiS0V44CDl1h09le+F6Xlee9V8B8eyCTV6AeG5o4w2u60RM4ZtZLHvqlRI3HrszH4anBi4vElihMsb/O75RR2YLKYidxpZSYw1uQBoLy7N5oH/9MH7NSWRCsm61hH1i6+UW25sPaXD4k1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aMHZn9Rl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aMHZn9Rl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF4C6C4CEED; Mon, 10 Mar 2025 19:45:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741635943; bh=l1FDuMJU96isGCHJ2N/qe2WIo8RAdJvFaAqFz1/i3ss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aMHZn9Rl0i73zM/IkFCkp7C0K5LW0ruLdDYgibz/N09NX1MBYPxP6QOVrWelFeba1 hYMXwqZVtJtczD1dH8Trr8WMSaA2JNtf75/2HzF0PvoIO1e3Kj62hL5C6nFzjcjcZo 6QlEh2p4rgCVFYc3wSTabT9D3NgzWpMJMaBoplWmW2tA/tpRewYcDPVP6g0viFIQD8 dQLlb/Cen36cGKeh7y8E+KEWeoMqwB7E3ZCibjT7mrPP5ZxUtBgVPK8SEQQi4NLAjo AZyvqqMSCmqQ9Wc32rOzeZI9UB8Ww/9Ain4UEEerUVC1U4ycoDKnbN35y8h3VrZqhD gzgqMWh4IBx8A== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 1/3] libapi: Add missing header with NAME_MAX define to io_dir.h Date: Mon, 10 Mar 2025 16:45:31 -0300 Message-ID: <20250310194534.265487-2-acme@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310194534.265487-1-acme@kernel.org> References: <20250310194534.265487-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnaldo Carvalho de Melo Most systems get this indirectly, but some odd cases (some musl libc systems) can't find it, so just add the header where NAME_MAX is defined to avoid that. Fixes: d118b08f7eee6d6f ("tools lib api: Add io_dir an allocation free read= dir alternative") Cc: Adrian Hunter Cc: Ian Rogers Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/api/io_dir.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/api/io_dir.h b/tools/lib/api/io_dir.h index aab73393d2a217ab..ef83e967e48c59f7 100644 --- a/tools/lib/api/io_dir.h +++ b/tools/lib/api/io_dir.h @@ -11,6 +11,7 @@ #include #include #include +#include =20 #if !defined(SYS_getdents64) #if defined(__x86_64__) || defined(__arm__) --=20 2.48.1 From nobody Sat Feb 7 13:41:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5483E1C54B2; Mon, 10 Mar 2025 19:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741635947; cv=none; b=myRewu5QpAyCmNIZumpuRVFpUVX494jBCROHrXHRglu1KBc2GNi28mWrr2mEr4G9E3EryiiL148uQ73DLKv8dpCRaXE8+xasKx56mK/ebAK+F2ozYFal3sL6trEU125o5466XK35exoqJL5IvwHeqD058sZe64Bndn/c5vyg9h4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741635947; c=relaxed/simple; bh=PEz4emfpDKQq21xA68IP+8sMdrnLr+bpnTcP9/ehJtA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bu6KGtWdID1+sAKBQh7HNC0JmWmtV+/C/laHjaznUNk8n8ZS5ZQAq6IF9HQd1XswFiY8d/DJ6eqp5wgYQUFXRogdVjj58F+to2bB0cxkfCgXyYrcM6ppZTHgEffZta8fAl1jk83Rk7KPc2/Z1rMk7eEHRbE5Ab6aMKhyoGoDN0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dVeoX++N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dVeoX++N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16F72C4CEE5; Mon, 10 Mar 2025 19:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741635946; bh=PEz4emfpDKQq21xA68IP+8sMdrnLr+bpnTcP9/ehJtA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dVeoX++N6k/yrc1rkFtu9v6vqQy8tGqg/9Zr4IJMlY+xK8iGlA2iMPo1hrbNkbCPm 5r96tx8leIKss2vMG97G8JI9E4rr9lyYBNtHnBO2HyQ6+76WOJh8ORjY63CoIFOD87 ftkOwi00BwnA5SNOvvAHdhhL6/vBs5vbWnhVUMukJJedXGWBJaNaweUNx5nnE2d5Wz LSc3DtJz5LM7Hsm5TnvTGsq3vd00fz28ZtH2IorWus7Xlj7JZia3M/bIeVC8XrXLZw 2S2fsjyyqCzi6mtGV4Sladm69XQol2a3VXgy0Eum7yvz3ajhB+jSfJNNm5AVPLgha8 bxECLxFXflDSA== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 2/3] perf units: Fix insufficient array space Date: Mon, 10 Mar 2025 16:45:32 -0300 Message-ID: <20250310194534.265487-3-acme@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310194534.265487-1-acme@kernel.org> References: <20250310194534.265487-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnaldo Carvalho de Melo No need to specify the array size, let the compiler figure that out. This addresses this compiler warning that was noticed while build testing on fedora rawhide: 31 15.81 fedora:rawhide : FAIL gcc version 15.0.1 20250= 225 (Red Hat 15.0.1-0) (GCC) util/units.c: In function 'unit_number__scnprintf': util/units.c:67:24: error: initializer-string for array of 'char' is to= o long [-Werror=3Dunterminated-string-initialization] 67 | char unit[4] =3D "BKMG"; | ^~~~~~ cc1: all warnings being treated as errors Fixes: 9808143ba2e54818 ("perf tools: Add unit_number__scnprintf function") Cc: Adrian Hunter Cc: Ian Rogers Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/units.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/units.c b/tools/perf/util/units.c index 32c39cfe209b3bba..4c6a86e1cb54b222 100644 --- a/tools/perf/util/units.c +++ b/tools/perf/util/units.c @@ -64,7 +64,7 @@ unsigned long convert_unit(unsigned long value, char *uni= t) =20 int unit_number__scnprintf(char *buf, size_t size, u64 n) { - char unit[4] =3D "BKMG"; + char unit[] =3D "BKMG"; int i =3D 0; =20 while (((n / 1024) > 1) && (i < 3)) { --=20 2.48.1 From nobody Sat Feb 7 13:41:26 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A592E1C54B2; Mon, 10 Mar 2025 19:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741635950; cv=none; b=FZb9mewM3HaR/O0IxvMWYDqj2FtR61O/OHSiKWlYDaL1XAm+5D2gcYJzUoLTPtPVtOHPMfjgDC5wSNlUTIHGLS8VQPNe27/iY4aMZN6Z0KUnxf6+XwyVbFhvmjHkUVhAE5jAIE+7EU6g/hrG7tb5bYVo/YX7mxrcWZqkj0buPr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741635950; c=relaxed/simple; bh=eWMNKQXpfEBHkUD356t+edleLweO0zbR+YCN2pmhSoU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c14MPQ6AWOi1grXIOXnYBheV+2fD/VwvlVMQSb32EzXFiDP8GgWUxp72n9IdJ/VtuY+tqba/+GnXQHtykLpCqJmRLEV54sVYnV+oDqsr2glKwT9cNZDvWSI6Cp+jJAEEagKrqX+5ck4SPwgOVU+tN/XsB7T2kEnm6vJYQeGciqQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fbpr7KuQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fbpr7KuQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52603C4CEEC; Mon, 10 Mar 2025 19:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741635950; bh=eWMNKQXpfEBHkUD356t+edleLweO0zbR+YCN2pmhSoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fbpr7KuQpkAPVuF6BHJjglrczjMo72vIWGnyysEbBaxp3tJbO7tddCb6u2saAKRGV twvgDS5Sa/ig9WQyyV6MJzq6fegQ2qmTZUA471xlBEL1ORRYGyEqASh6HdKSXhNZDJ hZYThQUotFdSdpo7yryrJTlPHSxyR5PJmVonTN049lGW74wM7nzmzieZab5OUgCDyT OkHVI4MAPMKvOG9J6NgI8AvNGzddmMBgguTQ09WBvery/uyJEdpp2Jc0k+nbCBIKiI vqaa0+yHTbK8M3RJAz4uS1ADD2K4meqkbfQEAYe29pqR1mxhWLPXO5FKJ90x2W1/v6 sUkHdnr1/v2vw== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 3/3] perf hist stdio: Do bounds check when printing callchains to avoid UB with new gcc versions Date: Mon, 10 Mar 2025 16:45:33 -0300 Message-ID: <20250310194534.265487-4-acme@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310194534.265487-1-acme@kernel.org> References: <20250310194534.265487-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnaldo Carvalho de Melo Do a simple bounds check to avoid this on new gcc versions: 31 15.81 fedora:rawhide : FAIL gcc version 15.0.1 20250= 225 (Red Hat 15.0.1-0) (GCC) In function 'callchain__fprintf_left_margin', inlined from 'callchain__fprintf_graph.constprop' at ui/stdio/hist.= c:246:12: ui/stdio/hist.c:27:39: error: iteration 2147483647 invokes undefined be= havior [-Werror=3Daggressive-loop-optimizations] 27 | for (i =3D 0; i < left_margin; i++) | ~^~ ui/stdio/hist.c:27:23: note: within this loop 27 | for (i =3D 0; i < left_margin; i++) | ~~^~~~~~~~~~~~~ cc1: all warnings being treated as errors -- util/units.c: In function 'unit_number__scnprintf': util/units.c:67:24: error: initializer-string for array of 'char' is to= o long [-Werror=3Dunterminated-string-initialization] 67 | char unit[4] =3D "BKMG"; | ^~~~~~ cc1: all warnings being treated as errors Cc: Adrian Hunter Cc: Ian Rogers Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/stdio/hist.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c index 74b2c619c56c8ba3..7ac4b98e28bca82e 100644 --- a/tools/perf/ui/stdio/hist.c +++ b/tools/perf/ui/stdio/hist.c @@ -1,4 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 +#include #include #include #include @@ -24,6 +25,9 @@ static size_t callchain__fprintf_left_margin(FILE *fp, in= t left_margin) int i; int ret =3D fprintf(fp, " "); =20 + if (left_margin > USHRT_MAX) + left_margin =3D USHRT_MAX; + for (i =3D 0; i < left_margin; i++) ret +=3D fprintf(fp, " "); =20 --=20 2.48.1