From nobody Tue Dec 16 19:40:04 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A618227E80 for ; Mon, 10 Mar 2025 12:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741609676; cv=none; b=tiRfbeGFoQeBzeniqM81nNOq6MWz9599RX7TsARX3l6T8Xia/o87OYZwbXd9um35t7UJP4L1yOe5TNAVHKsx2UNbi5dg2mquPApsSKZg5lIDLbaLMxeLfvjj7nyWzYUDdgfwgvjFsdEJ4NcJ69WWpfNi516/DxT1f4xBX4ABc7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741609676; c=relaxed/simple; bh=Zy2fJh3cTHOqRs4mkjI77HUqzP8JFc4VAdL+NBQchrE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HYHCv+ZmuvlQbRKl4+34X2fr5UYoycfgix0WuxBIW2omquep7rDS8T0pQU+0MwcplosnlPEIK2rZCemozzu9TkXo5l52wTEYaLNN60XNHrb9H/B1zpefUmosb6FYRWnU95K2wQTPjIgVnLdBHAOQa3gzacVjB+C5rTkVklve8pE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iL4HlbPh; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iL4HlbPh" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so4392655e9.1 for ; Mon, 10 Mar 2025 05:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741609673; x=1742214473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pP5AGd49889Z3JFGOGRHgkg7HKkdewQ+Zwhw794fEIw=; b=iL4HlbPhDqcg69x6dbhz6ymy9OQPpsErBzXCNa0PCRSylZf3AMCwRGngS8Hazjnu8t e7EPJG86IGMb8vOIbzJI0U6nkl1RmjUfEo031ftqgGp25BiOJRJJKZj2YQKQJkL4zft8 uvpEcMJv44z1vZ9Ltz09MrsV9Rgp1j8+L1rgM4E+1oRxzP/awuT8wKWidmRd6Gpvbmt1 UKrqAq2YiZ5kSCrc2/d5IdW7KbDxAv2HqVUHotxYqUXDJCR+ljyFlrBIr0u9U4Sicrxw QfOiV/n1CDIBYw8+H1YMXe5HOR14DXhnEhaaeM18njiyMetuo6pf3w3JoLtyJsoIDFwX LuoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741609673; x=1742214473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pP5AGd49889Z3JFGOGRHgkg7HKkdewQ+Zwhw794fEIw=; b=mj+cxPTcTPYeTGm4wKUcsXnXNOL9QvAuBf3qjm0WIlM/1aIXqrZz2t9260M2BNVC1o QRQKOBb32tNjNSY/4/ctOdV1VZZvMpjFJXjQAiLJoj3d6lTg2otDHyzzEGSh3zt1+l20 teARSIYoDOVBcCSx3KA8VJtpDsXdBGNzA4TJfk2TA/Z7Tbf+4zEOlWW4LUOhctgOy0mZ TbQynfGRHi2ZmyQQmf1n/cmfOScPbOpg2WQ6unqEPhEwrtADaJ5z2vmTkrFt8/httCaF 6DwZxUO8Q/STvmr8SSVxHOsjIcrNrMCoOlQ9QkjmX2BTCpiJzBFlLMjgAfjWMQAROhZG zuYA== X-Forwarded-Encrypted: i=1; AJvYcCV0zySk8lyrz9/f6UziTh6XUdwgifr0nSxttAmAvP3FyPB3oJYoduECNeNlRSB3cRKG6DO49W475/zyhXg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxmu4nHF31pSxRDOzHv8OULzrowGL3KvOX0ikK5c5yNwZnfO8tk 48mAbmRh8QfC+DijC0/zKim7OiAJG/GmEsoe3JNSILchmSaweLzs X-Gm-Gg: ASbGncvcUQ4IBqNxtDe3WpeicFh7JoHdrLmUEAKoTGOmCLUXk4LUJFRwo6zt8saikjK kIQPbc2eEQGPdrRCeEkKb4+ymjPYgloAZNEpiUNtUqJQ8ZuocV52/d/N8GYKGNx4AuvBzYZlldX YAjqoPAnpI+Au4JXfe+ta/pGHrPV+8xusZuMJCXRRBFjXlNpJI/BO6Hb6dXzLhH+JhLvx+JZfUQ 8ikjpLkjmuP/ZW7A+QRtTiYGjLvEV9ngdOWQz0TdhnLWksopDJPraQV0in3MdoWJV9Up6KHWxrI ZYEMd13dmv7jlj5F7XjobAPg0Jq3ss7R/ila6G67zHSgotnoB9lyJ9gCph3ZFm5lOsJf3Wrfr11 NTvXhF7kYX1HyHCwa X-Google-Smtp-Source: AGHT+IHkdFXutwUlHgJUEeibLtGVxZ9e1BYhqaRmZdU3VrmHHopZkCNH9T65QpbRvqLO+DUNS6Gfbw== X-Received: by 2002:a05:600c:1e08:b0:43c:f680:5c2e with SMTP id 5b1f17b1804b1-43cf6805d78mr26252335e9.13.1741609673265; Mon, 10 Mar 2025 05:27:53 -0700 (PDT) Received: from eichest-laptop.toradex.int (85-195-230-40.fiber7.init7.net. [85.195.230.40]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd6530f26sm171963245e9.4.2025.03.10.05.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 05:27:52 -0700 (PDT) From: Stefan Eichenberger To: vkoul@kernel.org, kishon@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, p.zabel@pengutronix.de, hongxing.zhu@nxp.com, tharvey@gateworks.com, Frank.Li@nxp.com, francesco.dolcini@toradex.com Cc: linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Eichenberger Subject: [PATCH v3 1/2] phy: freescale: imx8m-pcie: cleanup reset logic Date: Mon, 10 Mar 2025 13:27:03 +0100 Message-ID: <20250310122745.34947-2-eichest@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250310122745.34947-1-eichest@gmail.com> References: <20250310122745.34947-1-eichest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefan Eichenberger Remove the switch statement for releasing perst and reset since they are already correctly set at probe and are no-ops for reset_control_deassert(NULL). Call these unconditionally. This does not change the behavior of the driver but reduces driver complexity and allows for easier future modifications. Reviewed-by: Frank Li Acked-by: Richard Zhu Signed-off-by: Stefan Eichenberger --- drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/frees= cale/phy-fsl-imx8m-pcie.c index e98361dcdeadf..5b505e34ca364 100644 --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c @@ -141,15 +141,9 @@ static int imx8_pcie_phy_power_on(struct phy *phy) IMX8MM_GPR_PCIE_REF_CLK_PLL); usleep_range(100, 200); =20 - switch (imx8_phy->drvdata->variant) { - case IMX8MP: - reset_control_deassert(imx8_phy->perst); - fallthrough; - case IMX8MM: - reset_control_deassert(imx8_phy->reset); - usleep_range(200, 500); - break; - } + reset_control_deassert(imx8_phy->perst); + reset_control_deassert(imx8_phy->reset); + usleep_range(200, 500); =20 /* Do the PHY common block reset */ regmap_update_bits(imx8_phy->iomuxc_gpr, IOMUXC_GPR14, --=20 2.45.2 From nobody Tue Dec 16 19:40:04 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931C7227E8A; Mon, 10 Mar 2025 12:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741609678; cv=none; b=JtMTKtRFHrLDER2JuHvB4aJvjurZCkUIhdsq7x2QTjK2lMAz9HU7BMpKkps8Nd9xtSes0Aeq0kcID+x144uQD1XJ/Onr5O/JNXbGoHRepNP5832/bvmexqUAlerb3njNCre0RgyKGGCE8rpS+ykTN1KE6R55oYcO1Y6BuzqdmEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741609678; c=relaxed/simple; bh=nfghLeOpazL62fRqIJWQz1MP6JIaYaoFaN69gx/8b4c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XahLDA/wJ/8JYBlGM3pd+8oWFCdoKioq1AnXgNXCfYidC6MSwZmjXYE6KrvZ9McSIH88V6PllltXIJAzrQwDPmvkX0PCparB3Y96JRvagIqh1SNiM/wEKgR1cWMvHyvyQlrdgAbpv3XlMYusEztvMDvqRt69EKn23ilTWLDHegQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ENbRSXNm; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ENbRSXNm" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cec5cd73bso8836815e9.3; Mon, 10 Mar 2025 05:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741609675; x=1742214475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y07tVQtayKingIMzHvY+mUqyx0BK9tRXRpx87DXqL0Y=; b=ENbRSXNmNy29S2e3KLbciMx5Rk26oTtEFAUBrhn7DVO06ykXtgEJoVFlaxSmvScF3W hmW0noB3yb3scqDQHLT3cxSsGRL3ACG9uLR+xEryteuYFb70kZpdOwlBkVFGjANNKO5E pLFpVoIPr+gjeSxEjUjnGlWKhivBQvn39Uxfsv4kY7MVBwjCbE7lSRxTQfiPdgLIMzvX sg3XmqMS+SnJbZOmC3rXklR/KBabpP/MZGQohgRonzGORH9b3EmdAWe22Ut8d2tcdT9M iOuuFPr5Ynze/Wi+3AiG6Q5F4t89+RfZR4P9Yh3APMvvRfEyy4PckAQ+mQvqtWBq5ued KyPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741609675; x=1742214475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y07tVQtayKingIMzHvY+mUqyx0BK9tRXRpx87DXqL0Y=; b=oI4rmDA9mwi6FpPwANiE1v7zBff3A4OOkvTcdcxcMK5b+f7blaUYgHrOIhcBxMip0z 8vED4IU8fFjAkI1i1gv9vcO2FK57nqOvgvPk5Gt16ax+KmmYy6MBTVxmENUK/mJll/3b mlwRzaJjvfsntTvQTH6fZXdYq1qSuvdhsrsuJ/jlRSBDbelsRc1BS1XPLb1fEfQ4YE3r CUfr+rFnDS76nPMOxzXNwm1nXNuD7ZVRh8ZQDqdWDwq9/lbfrXdWlZ3D2D918ii5PDSM UvciXRqXd8+6JTNTRBLoAy87nbHaALGNfgDzLJA9HigGb3yGRZWKIXzuzZ9isEI0dW4h jHNw== X-Forwarded-Encrypted: i=1; AJvYcCUVjxbDZ+T7mtwC7io0SJZtcJeXJ0bbuZ558Pgbm6HzjJ6e8qUpGxu30HnoneVIlbzp619lfcK2@vger.kernel.org, AJvYcCVp6W3zkuE2m2IStRb+D75IsVeWh0l7Ju9mmhQms3iM8uyXuiMhCfwWkr/2uiLGhmbkYK7aelRSsLLM/z8=@vger.kernel.org X-Gm-Message-State: AOJu0YyfHc7j6vypT//yuwiOgBshmNH9XuawapGvjrj5SRKzBILJ/ndE 1buvt+QoF+PlRtGP0GL6Rm+mFD4oEhSSQ5IqStnmEtnX7hUDXdbq X-Gm-Gg: ASbGncs4hRLuEqTeuhGxSVIBVjzCHl3AsMM2OW80LNSmxkiZEnMlkHYfGwYBZLGVtk2 5o/C/806fnEfxWAMIHQFxo63dfoBAcuMOivDuyDuRLbjmoLbDaWyJD9q0jay1puu0+DPicx5fxR E3IFRPw4DU5dkXgfn0TkYi9/RWI5UaUAbZoFqpASCS6XP3wEBlC8aI453GKoNe+I9BikF33M71a jU1+hNySfWnzixIcOcInd1qceevJDHvG9Mkh95yyj5FbphnLeFEWcFhgCWxUYChR1TdvS7vsWYS gaHHJxoUN8ZyRwtSifTmkSYUYCM1vSRnl0i7Olo2+ie6xQaCy1ZK0J1ieJYeC/PLTpiWF3Dg7Fb 4xQ0WWjJjeMeICrZe X-Google-Smtp-Source: AGHT+IHyEEGGzhCMZxMwRjQ82ccOJZrD+gnc4+NfGxz62Tu6AF+ZAKBbTzzBzG5J8FJd1mZ+MeHucw== X-Received: by 2002:a05:600c:4f41:b0:43c:ec28:d301 with SMTP id 5b1f17b1804b1-43cec28d3c2mr31513105e9.26.1741609674640; Mon, 10 Mar 2025 05:27:54 -0700 (PDT) Received: from eichest-laptop.toradex.int (85-195-230-40.fiber7.init7.net. [85.195.230.40]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd6530f26sm171963245e9.4.2025.03.10.05.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 05:27:53 -0700 (PDT) From: Stefan Eichenberger To: vkoul@kernel.org, kishon@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, p.zabel@pengutronix.de, hongxing.zhu@nxp.com, tharvey@gateworks.com, Frank.Li@nxp.com, francesco.dolcini@toradex.com Cc: linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Eichenberger , stable@vger.kernel.org Subject: [PATCH v3 2/2] phy: freescale: imx8m-pcie: assert phy reset and perst in power off Date: Mon, 10 Mar 2025 13:27:04 +0100 Message-ID: <20250310122745.34947-3-eichest@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250310122745.34947-1-eichest@gmail.com> References: <20250310122745.34947-1-eichest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefan Eichenberger Ensure the PHY reset and perst is asserted during power-off to guarantee it is in a reset state upon repeated power-on calls. This resolves an issue where the PHY may not properly initialize during subsequent power-on cycles. Power-on will deassert the reset at the appropriate time after tuning the PHY parameters. During suspend/resume cycles, we observed that the PHY PLL failed to lock during resume when the CPU temperature increased from 65C to 75C. The observed errors were: phy phy-32f00000.pcie-phy.3: phy poweron failed --> -110 imx6q-pcie 33800000.pcie: waiting for PHY ready timeout! imx6q-pcie 33800000.pcie: PM: dpm_run_callback(): genpd_resume_noirq+0x0/= 0x80 returns -110 imx6q-pcie 33800000.pcie: PM: failed to resume noirq: error -110 This resulted in a complete CPU freeze, which is resolved by ensuring the PHY is in reset during power-on, thus preventing PHY PLL failures. Cc: stable@vger.kernel.org Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standa= lone phy driver") Reviewed-by: Frank Li Acked-by: Richard Zhu Signed-off-by: Stefan Eichenberger --- drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/frees= cale/phy-fsl-imx8m-pcie.c index 5b505e34ca364..7355d9921b646 100644 --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c @@ -156,6 +156,16 @@ static int imx8_pcie_phy_power_on(struct phy *phy) return ret; } =20 +static int imx8_pcie_phy_power_off(struct phy *phy) +{ + struct imx8_pcie_phy *imx8_phy =3D phy_get_drvdata(phy); + + reset_control_assert(imx8_phy->reset); + reset_control_assert(imx8_phy->perst); + + return 0; +} + static int imx8_pcie_phy_init(struct phy *phy) { struct imx8_pcie_phy *imx8_phy =3D phy_get_drvdata(phy); @@ -176,6 +186,7 @@ static const struct phy_ops imx8_pcie_phy_ops =3D { .init =3D imx8_pcie_phy_init, .exit =3D imx8_pcie_phy_exit, .power_on =3D imx8_pcie_phy_power_on, + .power_off =3D imx8_pcie_phy_power_off, .owner =3D THIS_MODULE, }; =20 --=20 2.45.2