From nobody Sun Feb 8 09:11:06 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD194224B04 for ; Mon, 10 Mar 2025 09:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741598393; cv=none; b=ZIO5s032YTO6j93iS0MrRZwHj4j4FZac7xjpPDutRNZABJYgTqYMEQwQl2HysG6n9k9hj2Dj9M8eMLGg05VHzwqvK5a6BSu4HiiKUoChicTneSu8dRKGJz69rXvyvsS3m1Fpn6zaBkT9HGVBjmFcWsDcRFe2tIKCi2sit5k4iAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741598393; c=relaxed/simple; bh=ofu/XDmnupv4JAviLY8SaWPygIQTjFUfrxSbjVFGdzw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lb5zEmf3A/guh38qJ43JDzLxI36kMOOCHsOhGluyUX/URZZphjVRNZlLAkN1vmCDj/y/87qmu6uycRqD1A4syAWRaiO9++MnL27DO5Yk1vyfGCdOCAKOfn9kMgfn+g54gkfvX1qX14CnlUDGAsiOJzh35l2259IyTg9WgUPZcSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X9yvYEcg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X9yvYEcg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741598389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N5e8XPVQftzsj9VqneTTVVLeBZoXHhJpQKjzVqdDaw4=; b=X9yvYEcgLnss63Eu323Nhimykss5Mef2THYW9dDUUPrKMrjEfaYcUsq4sKbCVhErHjQuWe CzGvdVqCWtNixz/L3VEN9WuWphbx3FIvtkMIX+0oml5Q85CmXR+bst74i+LJxVMFqiTm48 aogOldoYmNKm402QMztuF9mpbKCgvMw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321-BkeH7Kd8OvqZGd_uQQDDpQ-1; Mon, 10 Mar 2025 05:19:45 -0400 X-MC-Unique: BkeH7Kd8OvqZGd_uQQDDpQ-1 X-Mimecast-MFC-AGG-ID: BkeH7Kd8OvqZGd_uQQDDpQ_1741598384 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43bd92233acso32348865e9.1 for ; Mon, 10 Mar 2025 02:19:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741598381; x=1742203181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N5e8XPVQftzsj9VqneTTVVLeBZoXHhJpQKjzVqdDaw4=; b=pTIMcnmTxsf5WTVrHJV7xcSp9mvpxBHESvRgv2sKkQkEEguMWK2f5dlq1aitBEc1gZ DmMOxqCXIAd4PLzSXRU59HU/T7tmLEuYesvXgF3BTJKLOTQulwHwGNA5rA1FewICsDhF ARGJNNR8sSMwKXr+yJg//TAXPtXj9ewcOXZsqbhsxffBhzMcmoxsVLRT6yEKXt597zpZ +t/VilU2BJgjbfEn6RSFn1hclDZ9i22mmz9D5qy4iIC+lUv5Wze9gjNFaQWMJVjmwgV4 LFNhGKhVj3iSpHSaXjhTS8nEqHy4THUqSdBK9cOYvT0GYco5d6XpCyJxBtvUfWdBtOJm B8tw== X-Gm-Message-State: AOJu0Yx/h8qV0qQa7uvDdpVgRYlFv5AiESj4hzSH2P66F5PpWWRLfAlP gpjG7VoKBSiYPTFIgryiptXm0zSfiaRnOGpKTKjX+TB56asJGYj1C9U/dStFx/8gMd5+9RuABUW 9xIFddG/CEs5MsVqBPgn4ajs6vqDVd1hAHFu+3x1amGoGUfrvA+RBO8YBPkWxMbBDxfpkKeTXA/ A0yWWw57BvjXaNUAa5ZBt7ZoQnk3Gm1Nxp//YPhpTZTSYW6lQJTNw= X-Gm-Gg: ASbGncv7q4YBMxGykn2+MhOHGSIjOtFwpFkLjNibiR9sqa+PqYlknxwEFwt8M7YQV/g +YkxtNETR5ZzHlqvT5aSknO9iFIq1JWBuqMXJR+JaSoslpyYoBQEaZXwZqEGJNnNOXYKJLTNvZQ wgq8Su1foMhlqo3GYtb+tfwwvCyaSzt9U3zRusn+oKL5PjyYwn5e5KDWB3j0jMS6V25QM+iGNwk 7SLu6jGay8Jewll45q1nSqhu+nzSJavMzJvZ93EehANzFM9gUtop5meTa0n83bcuPPIjQJK5GJy 9CaCVz8JbFbtbdAd6sjWoLZk2cD0EUwluxbbktic4p4= X-Received: by 2002:a05:600c:4fc5:b0:43c:f969:13c0 with SMTP id 5b1f17b1804b1-43cf9691636mr14252115e9.29.1741598380877; Mon, 10 Mar 2025 02:19:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYwaPQhNcEyHI4jeS2gXnFMH/We5pnIXg1uaGo0WIN/FUnIPC+tMOh6jU3BTonbxCUdQr4Rw== X-Received: by 2002:a05:600c:4fc5:b0:43c:f969:13c0 with SMTP id 5b1f17b1804b1-43cf9691636mr14251705e9.29.1741598380400; Mon, 10 Mar 2025 02:19:40 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.49.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ce8a493d0sm77462735e9.1.2025.03.10.02.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 02:19:40 -0700 (PDT) From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v3 1/8] sched/deadline: Ignore special tasks when rebuilding domains Date: Mon, 10 Mar 2025 10:19:28 +0100 Message-ID: <20250310091935.22923-2-juri.lelli@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com> References: <20250310091935.22923-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SCHED_DEADLINE special tasks get a fake bandwidth that is only used to make sure sleeping and priority inheritance 'work', but it is ignored for runtime enforcement and admission control. Be consistent with it also when rebuilding root domains. Reported-by: Jon Hunter Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for = hotplug") Tested-by: Waiman Long Tested-by: Jon Hunter Signed-off-by: Juri Lelli Reviewed-by: Valentin Schneider --- kernel/sched/deadline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index ff4df16b5186..1a041c1fc0d1 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2956,7 +2956,7 @@ void dl_add_task_root_domain(struct task_struct *p) struct dl_bw *dl_b; =20 raw_spin_lock_irqsave(&p->pi_lock, rf.flags); - if (!dl_task(p)) { + if (!dl_task(p) || dl_entity_is_special(&p->dl)) { raw_spin_unlock_irqrestore(&p->pi_lock, rf.flags); return; } --=20 2.48.1 From nobody Sun Feb 8 09:11:06 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0F6B22333B for ; Mon, 10 Mar 2025 09:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599193; cv=none; b=hHycXQny/7IkzdlBARrqW0lzvZeTueo9pMwM73mlGfykjmmvNFxRtO8NW/JxV7fcW4hfSYclZQggWqOTk4lCcOOejgA5+PeMV4H6qzHSaHskVUADDv6ho4zB/oyKKIKD/yku/9FUqkD8vn3IihPPEoLLo9kOJJiUVekn5ej5b2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599193; c=relaxed/simple; bh=wJpaHcARR3YB5XnG3M9UeeHERjXf318a8M9J0vLqzxw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SbzoadQEaar3/+VLQdvx51x4OeJ0/Ss7rYtJOvyuHkGSiEbKWZ1u3ypPji9+TiCY/81mmqxFeh9vtfgy8yWyflwFdtyT4CxyqcI6IY1l9OBGk0nrr7rQ9RsJX31PGWjFj4UanYp68YFSd56BVE1lr2EBtMShXJKQsNhomI88fQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zy0quUPR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zy0quUPR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741599190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C1c5i2Qm2DUrkZQHaLsmF680F9xe+Pb2YDsGrDb31LY=; b=Zy0quUPRV6vQ91+oc8A6DQZal7AkWnKtT5vfPVruvkzgLoSAZKI/lTYMB7zwdAKYbYwzH2 7oReIU6u1ihpbg5BrGGtiM4sDg86q5DqYbhM50WDSG6tQkYNbzeA0SmyyXwQyed0VUYWhC VrMKiobkPphJZdu3ywVBIg9v0x5XxyQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-yTqgadkaMc2guXwOjmX5Lg-1; Mon, 10 Mar 2025 05:33:09 -0400 X-MC-Unique: yTqgadkaMc2guXwOjmX5Lg-1 X-Mimecast-MFC-AGG-ID: yTqgadkaMc2guXwOjmX5Lg_1741599188 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-438da39bb69so27184515e9.0 for ; Mon, 10 Mar 2025 02:33:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741599186; x=1742203986; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C1c5i2Qm2DUrkZQHaLsmF680F9xe+Pb2YDsGrDb31LY=; b=NR5L9/ZnDz+99jRHYTd3xbQLauo9iY4ZC3ntaJho7Sfol79axRJ7U97oI7TNU0w0o5 /FttRjjq0G4Zc42mBb6PN4cOyt7MfRb5tUzKUeIKLijJ+9oDJSOY1B+dfMFcOQK9dHF3 YhjBL6ixFw15+rKoKDQgjWKOFH41iLhX1RQDfNdh0MZtul8lm+lx+8sLTmHnPLq2+z3Q HHoqQ7PjCT/6FPe8Aju9H6yutq88jGsUcIzthbFaajGaui/1S7dVPBFooAAnjtCcNtDe BEolTE0L97TulgewCjMkwRV45nmGO1J8jpzpzSz+wF03ZvDKW0MVzXHNNF17M3H0lJsg kcsQ== X-Gm-Message-State: AOJu0Yw5G4N+FZ0CFdpnr3/2M53yg4JcGojRSu/X8Vl4dKCdoNkpYCcb eA46C5/D1w7K5fzDc0Yw5q3rNZSElzHuVtxiW8UUjwJjV8OUqmf829ceouipvZkVLfB7ThJegxI dkvTARb9djgSwBpcwpFbCEOgVPy/nPJmKUgctX1uqXRskqLY57tyY98Td4eQPe8fncRxFQYRhHV 97DEMu9rPXt+iTjgnrTnCr12keAoKkz4T5/nB3Ok0FNvTQknifous= X-Gm-Gg: ASbGncs9DUY9TViawQs4bvyE3i6RHQ/XmPbE1GJa74WRsxK4/uWRire7Z2XnD1kuK0e Q/wIWvK6crKoCA1LnqCoRejOoacIUuOHlzUHkPgGnrNkKYYTHyWU4JQ9XeGAypzOCbWcIfrMJi6 3SQhlzEri4w7QRO0B5Dthh+3nAnIVhrBCoOQatAMvDMC04pDf8KcmJSF56DyHae21b3Bt2IL0y5 yQzpGTUNbMPvavKniDJVITzQqXtVCg9Ch4sdCCYB3A8o9jTY2C0FW15ojIXf4eAGL9JpVo69vKz 0gQFMRv+H2cHQyBKb23mSU8hmSqoDOlxkbzmGvmO5Q4= X-Received: by 2002:a05:600c:1f92:b0:43c:e5c2:394 with SMTP id 5b1f17b1804b1-43ce5c2054emr52822565e9.0.1741599185884; Mon, 10 Mar 2025 02:33:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLMiRzgA5hzMsBbSiJbAqQMr/pIjjtP9IG0cEEYXnbRD0gQZrY8zGFUbNgAmgSDjVV8Tx22w== X-Received: by 2002:a05:600c:1f92:b0:43c:e5c2:394 with SMTP id 5b1f17b1804b1-43ce5c2054emr52822125e9.0.1741599185397; Mon, 10 Mar 2025 02:33:05 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.49.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43cfac24345sm19535045e9.22.2025.03.10.02.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 02:33:03 -0700 (PDT) Date: Mon, 10 Mar 2025 10:33:00 +0100 From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v3 2/8] sched/topology: Wrappers for sched_domains_mutex Message-ID: References: <20250310091935.22923-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create wrappers for sched_domains_mutex so that it can transparently be used on both CONFIG_SMP and !CONFIG_SMP, as some function will need to do. Reported-by: Jon Hunter Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for = hotplug") Tested-by: Waiman Long Tested-by: Jon Hunter Signed-off-by: Juri Lelli Reviewed-by: Valentin Schneider --- v2 -> v3: Add wrappers back for the !SMP case as sched_rt_handler() needs them --- include/linux/sched.h | 5 +++++ kernel/cgroup/cpuset.c | 4 ++-- kernel/sched/core.c | 4 ++-- kernel/sched/debug.c | 8 ++++---- kernel/sched/topology.c | 12 ++++++++++-- 5 files changed, 23 insertions(+), 10 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 9c15365a30c0..4659898c0299 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -382,6 +382,11 @@ enum uclamp_id { #ifdef CONFIG_SMP extern struct root_domain def_root_domain; extern struct mutex sched_domains_mutex; +extern void sched_domains_mutex_lock(void); +extern void sched_domains_mutex_unlock(void); +#else +static inline void sched_domains_mutex_lock(void) { } +static inline void sched_domains_mutex_unlock(void) { } #endif =20 struct sched_param { diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 0f910c828973..f87526edb2a4 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -994,10 +994,10 @@ static void partition_and_rebuild_sched_domains(int ndoms_new, cpumask_var_t doms_new[= ], struct sched_domain_attr *dattr_new) { - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); dl_rebuild_rd_accounting(); - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); } =20 /* diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 67189907214d..58593f4d09a1 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -8424,9 +8424,9 @@ void __init sched_init_smp(void) * CPU masks are stable and all blatant races in the below code cannot * happen. */ - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); sched_init_domains(cpu_active_mask); - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); =20 /* Move init over to a non-isolated CPU */ if (set_cpus_allowed_ptr(current, housekeeping_cpumask(HK_TYPE_DOMAIN)) <= 0) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index ef047add7f9e..a0893a483d35 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -292,7 +292,7 @@ static ssize_t sched_verbose_write(struct file *filp, c= onst char __user *ubuf, bool orig; =20 cpus_read_lock(); - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); =20 orig =3D sched_debug_verbose; result =3D debugfs_write_file_bool(filp, ubuf, cnt, ppos); @@ -304,7 +304,7 @@ static ssize_t sched_verbose_write(struct file *filp, c= onst char __user *ubuf, sd_dentry =3D NULL; } =20 - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); cpus_read_unlock(); =20 return result; @@ -515,9 +515,9 @@ static __init int sched_init_debug(void) debugfs_create_u32("migration_cost_ns", 0644, debugfs_sched, &sysctl_sche= d_migration_cost); debugfs_create_u32("nr_migrate", 0644, debugfs_sched, &sysctl_sched_nr_mi= grate); =20 - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); update_sched_domain_debugfs(); - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); #endif =20 #ifdef CONFIG_NUMA_BALANCING diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index c49aea8c1025..296ff2acfd32 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -6,6 +6,14 @@ #include =20 DEFINE_MUTEX(sched_domains_mutex); +void sched_domains_mutex_lock(void) +{ + mutex_lock(&sched_domains_mutex); +} +void sched_domains_mutex_unlock(void) +{ + mutex_unlock(&sched_domains_mutex); +} =20 /* Protected by sched_domains_mutex: */ static cpumask_var_t sched_domains_tmpmask; @@ -2791,7 +2799,7 @@ void partition_sched_domains_locked(int ndoms_new, cp= umask_var_t doms_new[], void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[], struct sched_domain_attr *dattr_new) { - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); } --=20 2.48.1 From nobody Sun Feb 8 09:11:06 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48FFA1C5F34 for ; Mon, 10 Mar 2025 09:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599373; cv=none; b=Yd3XBb20fLqsrVIQG9kcS0qIAD/VPzrZvtyiIPb+sQSy7jLsJb9Xkzr9TY2brgcy13vsVfITQ49dDUy6unGkL9B12sfZdwJhxBQA1dutm1G2laME5RwU967ORY1ViNFP2JhP2jJmrx2EpprVjqZ4a8QKqnT0Nwo9iJjcSCphEtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599373; c=relaxed/simple; bh=77Cw6OMirz56mbjUr2uprYqVtTffZBEoqucfaqj42yc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EN/KO1Vz+CxN4IqSY1NnN6ViYsgImTYkZ52GMBUFAhTFn9AEDWUlXeCNR6e3RoHWQExZjcJDGX9lxEMFbwXSiKfIZLnK+Suh/z0A3IvYhCe74mr4OCBamffMaGPmZxallQiB+w053yUnHQx/pNEvabGggLJX6606f5oR0qXLlS0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cXkTth5h; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cXkTth5h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741599369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KKHSd1R9tSOgqW3rsZG1AGAIm0nBc4+9GIVe07dpeHA=; b=cXkTth5hBEZqxBxMiJ3gakFKgTYL704zNTy5ZLE5QvHHeF6E8TVetPxGZh5M+RAWXBjlL9 zyC5Et0OzGhFvD0zN5f6hplPhArVaCH4ZWAziZEF/uN/cH0/jL4zfLnwSAZjg0cJ3/eHZw YAjR7FJ2uiUmnPb8lqtkIcl4maF1WoY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-9FxMArzGOAybXo21BhW_Lg-1; Mon, 10 Mar 2025 05:36:06 -0400 X-MC-Unique: 9FxMArzGOAybXo21BhW_Lg-1 X-Mimecast-MFC-AGG-ID: 9FxMArzGOAybXo21BhW_Lg_1741599365 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-438e180821aso17792315e9.1 for ; Mon, 10 Mar 2025 02:36:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741599364; x=1742204164; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KKHSd1R9tSOgqW3rsZG1AGAIm0nBc4+9GIVe07dpeHA=; b=qUF+dOEKgU5KO0oIq0BqUvhRyenz0V357czJgIe1yzJ0MKPE39h2ep8dOgUJaLbF/v xVNPZowXqVLaXC8LmQX8bhTpRzFnR5gMNqtwMa4BjQ5OOYbTBVwqTPTN4mygSwLfRGL5 T9wCJIA6IXed2WikIcQA65BcZJZNYifBIm5tVHZdT3hXgQCAelWy677Y5LWZislDk8c2 MQZh/WNV8n2bIdyJGT74rqUtzDQiriOYj+smGOSPOUCJ+m1k980sPU8XEFDfB15I8MZW v1j04JdHY1coXZRRbms1uxDUWNKievTJKlPdLn+eBSZN6qSOXXc7pbk3s5a29YQHnJLy MvHw== X-Gm-Message-State: AOJu0YzhBBm1F1bHDaTK3uQlo5tJ6uBKVezSPp4tC1dVfxfVIozev02/ CcD1vqxIu0ydlRN42KOI3L7eOML1dehseId0dioV5OcAt0GaD/0TYMwytg6+p+33XVG0tjTP0tO hIZieelidln+Szb372YEKsXxRDOfKojNgQQmcA0/6wRtGxbMUYSoruc8At65ksaxIHDQudLiVwK DRx2XTiU8NpOOXl9nFjo4spxhhz0C95LiFMM2kumml+MwgOEdP49A= X-Gm-Gg: ASbGnctNbeM1fN/hsBOyzI8tclohrzkzBgzEYaYtshrOEyugw8+9y7iZghfihn/h7yW fpe8SCcYTltnbrNcepy/lG9ubN2c3Ogb34A83kqoo8qQisaXpvdrmtzYw/dPeqGV0wuhMCuqUml Fn+NaJf8W8ZMstxPBoaAk0nHJl9caXRDeRScv4EWAwvLc2jsq0OS1jSTLEL7gv2U8poa0j1X9DI HCLVBekhHBxN+Y7zzmNx0i5P+r6SjMO0U+/XtBeoOLyrElGDp9vnAQEcgACVSg8fqWCAHmrLnZh sz+zfNma/seGnhAiU2YiSS0X+Lwj91c6+J/VkAQaJ7k= X-Received: by 2002:a05:600c:1d03:b0:43c:eacc:9d68 with SMTP id 5b1f17b1804b1-43ceacca125mr38496925e9.20.1741599363985; Mon, 10 Mar 2025 02:36:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBr/2t9MYkgNGGYC9N7JgdhFa6kCeNhMjLpUu+D0hEfBcVB2Xa2/6FHmeUAbv9Uc6aabg6bw== X-Received: by 2002:a05:600c:1d03:b0:43c:eacc:9d68 with SMTP id 5b1f17b1804b1-43ceacca125mr38496025e9.20.1741599363336; Mon, 10 Mar 2025 02:36:03 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.49.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ce715731csm78799055e9.2.2025.03.10.02.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 02:36:02 -0700 (PDT) Date: Mon, 10 Mar 2025 10:35:59 +0100 From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v3 3/8] sched/deadline: Generalize unique visiting of root domains Message-ID: References: <20250310091935.22923-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Bandwidth checks and updates that work on root domains currently employ a cookie mechanism for efficiency. This mechanism is very much tied to when root domains are first created and initialized. Generalize the cookie mechanism so that it can be used also later at runtime while updating root domains. Also, additionally guard it with sched_domains_mutex, since domains need to be stable while updating them (and it will be required for further dynamic changes). Reported-by: Jon Hunter Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for = hotplug") Tested-by: Waiman Long Tested-by: Jon Hunter Signed-off-by: Juri Lelli Reviewed-by: Valentin Schneider --- include/linux/sched/deadline.h | 3 +++ kernel/sched/deadline.c | 23 +++++++++++++---------- kernel/sched/rt.c | 2 ++ kernel/sched/sched.h | 2 +- kernel/sched/topology.c | 2 +- 5 files changed, 20 insertions(+), 12 deletions(-) diff --git a/include/linux/sched/deadline.h b/include/linux/sched/deadline.h index 3a912ab42bb5..6ec578600b24 100644 --- a/include/linux/sched/deadline.h +++ b/include/linux/sched/deadline.h @@ -37,4 +37,7 @@ extern void dl_clear_root_domain(struct root_domain *rd); =20 #endif /* CONFIG_SMP */ =20 +extern u64 dl_cookie; +extern bool dl_bw_visited(int cpu, u64 cookie); + #endif /* _LINUX_SCHED_DEADLINE_H */ diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 1a041c1fc0d1..3e05032e9e0e 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -166,14 +166,14 @@ static inline unsigned long dl_bw_capacity(int i) } } =20 -static inline bool dl_bw_visited(int cpu, u64 gen) +static inline bool dl_bw_visited(int cpu, u64 cookie) { struct root_domain *rd =3D cpu_rq(cpu)->rd; =20 - if (rd->visit_gen =3D=3D gen) + if (rd->visit_cookie =3D=3D cookie) return true; =20 - rd->visit_gen =3D gen; + rd->visit_cookie =3D cookie; return false; } =20 @@ -207,7 +207,7 @@ static inline unsigned long dl_bw_capacity(int i) return SCHED_CAPACITY_SCALE; } =20 -static inline bool dl_bw_visited(int cpu, u64 gen) +static inline bool dl_bw_visited(int cpu, u64 cookie) { return false; } @@ -3171,15 +3171,18 @@ DEFINE_SCHED_CLASS(dl) =3D { #endif }; =20 -/* Used for dl_bw check and update, used under sched_rt_handler()::mutex */ -static u64 dl_generation; +/* + * Used for dl_bw check and update, used under sched_rt_handler()::mutex a= nd + * sched_domains_mutex. + */ +u64 dl_cookie; =20 int sched_dl_global_validate(void) { u64 runtime =3D global_rt_runtime(); u64 period =3D global_rt_period(); u64 new_bw =3D to_ratio(period, runtime); - u64 gen =3D ++dl_generation; + u64 cookie =3D ++dl_cookie; struct dl_bw *dl_b; int cpu, cpus, ret =3D 0; unsigned long flags; @@ -3192,7 +3195,7 @@ int sched_dl_global_validate(void) for_each_online_cpu(cpu) { rcu_read_lock_sched(); =20 - if (dl_bw_visited(cpu, gen)) + if (dl_bw_visited(cpu, cookie)) goto next; =20 dl_b =3D dl_bw_of(cpu); @@ -3229,7 +3232,7 @@ static void init_dl_rq_bw_ratio(struct dl_rq *dl_rq) void sched_dl_do_global(void) { u64 new_bw =3D -1; - u64 gen =3D ++dl_generation; + u64 cookie =3D ++dl_cookie; struct dl_bw *dl_b; int cpu; unsigned long flags; @@ -3240,7 +3243,7 @@ void sched_dl_do_global(void) for_each_possible_cpu(cpu) { rcu_read_lock_sched(); =20 - if (dl_bw_visited(cpu, gen)) { + if (dl_bw_visited(cpu, cookie)) { rcu_read_unlock_sched(); continue; } diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 4b8e33c615b1..8cebe71d2bb1 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2910,6 +2910,7 @@ static int sched_rt_handler(const struct ctl_table *t= able, int write, void *buff int ret; =20 mutex_lock(&mutex); + sched_domains_mutex_lock(); old_period =3D sysctl_sched_rt_period; old_runtime =3D sysctl_sched_rt_runtime; =20 @@ -2936,6 +2937,7 @@ static int sched_rt_handler(const struct ctl_table *t= able, int write, void *buff sysctl_sched_rt_period =3D old_period; sysctl_sched_rt_runtime =3D old_runtime; } + sched_domains_mutex_unlock(); mutex_unlock(&mutex); =20 return ret; diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index c8512a9fb022..c978abe38c07 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -998,7 +998,7 @@ struct root_domain { * Also, some corner cases, like 'wrap around' is dangerous, but given * that u64 is 'big enough'. So that shouldn't be a concern. */ - u64 visit_gen; + u64 visit_cookie; =20 #ifdef HAVE_RT_PUSH_IPI /* diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 296ff2acfd32..44093339761c 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -568,7 +568,7 @@ static int init_rootdomain(struct root_domain *rd) rd->rto_push_work =3D IRQ_WORK_INIT_HARD(rto_push_irq_work_func); #endif =20 - rd->visit_gen =3D 0; + rd->visit_cookie =3D 0; init_dl_bw(&rd->dl_bw); if (cpudl_init(&rd->cpudl) !=3D 0) goto free_rto_mask; --=20 2.48.1 From nobody Sun Feb 8 09:11:06 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A898F2253E6 for ; Mon, 10 Mar 2025 09:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599442; cv=none; b=Gyo0pSyFoWh8YvapNdDbg9412MG+9pcHu3jGhVgAA6sPqpPac7q3eTb6ijOePO9RZEisrTmMDiycT0cCgZScO9fdc77/nYn4jl9J1zk0iafq0I0AiE05CWVBoI1kSv2cnybh0DAb7l/SEZF+87buukWGH+Axxuuii+IrpPbCqME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599442; c=relaxed/simple; bh=dJ0qYuhLvHREJelUpJrsJhya+cYWSalYL5+mpIrhEfU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oTMipmCWyStOzES0Ogw9FBI/plfKitCFPajRcrC3M3yOfkZI9EH+tM4jLi4ashMibuumphN2XlzE1WFCbyVAYcVt/4yNbmjrty5nKV56xnpAewibBPbazjwvMtAQ3Zas1qafUI9Is48RxsGcEeivIeShj6gyjJLCapyvoQ1RtcE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Dp3BRF3M; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Dp3BRF3M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741599439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+C55SaFeRG+WldAEv/0LRZJhn3q8mtrbeietSUyeneQ=; b=Dp3BRF3MHAbraPPM2qHR0TxwoRun2TmMjDWFragdU2gTGm17HTcxQ9BN1shjvkvfWNY+SG yQ8tXmgoe4YCj35rJZhcNe3nMl+9mNnwjqItjf4/b6c/mDfZFeLnh6CqdQZad/7T/Lvfkq 1smMzDHBqiS6HbE+gPe4ZM1kZLWX/FA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-n0__olMSOC2SE5oakBuT9w-1; Mon, 10 Mar 2025 05:37:18 -0400 X-MC-Unique: n0__olMSOC2SE5oakBuT9w-1 X-Mimecast-MFC-AGG-ID: n0__olMSOC2SE5oakBuT9w_1741599437 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3912fc9861cso1515498f8f.1 for ; Mon, 10 Mar 2025 02:37:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741599435; x=1742204235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+C55SaFeRG+WldAEv/0LRZJhn3q8mtrbeietSUyeneQ=; b=TB8RiHnpPkT415wh8dFhXRjuP51DtgnWyRAzIUiwzBV2k6X4nSW/4S10wGh0WPaVhF RMx7ASDQ+P5dYng7S42+0TpO1iWvPaIfPFGi/FRsAHRldxKSaWkfY5OtJbljLqjcQVX9 BbXQG4fplSJC8/RWp19NcsRGImJ6I5l3ACSlom6DyWlkcTSJDrC0Ey7biE94s5WMm3Lg Olx3HLkD1UG6FeRLGpusifla2Q2SAlkD3C82zXj4wUS9ONqtEadnY3c4r7Bx4sUSkcN0 f6LKhZOA5frxST6ov/1k6R5qJ1CI/ije6zHngkdgdW9pmktdRjypzLd89eYGCza8aAPE LRPg== X-Gm-Message-State: AOJu0Yxo3w03P4m3T3r0q3HoyZs2gY1OJMSsvFvoQWN79g1um2y0O0Bl KkZ6vYsVr/nqeMXALggk2vHH7ZcEpwy0ZrJmOjxWWPn5ESAo9LM/BL7j4n5ji7p5bM5lAjwNZjB ivRSyNWh/V7soGHwremLIxvmXkEYZAJ7CTEO4vjgUwlG4sbvWJEWHaM76DA2coj8ucjF7fm6qAm YjDUFn6fxJs+rTJrEO95RNKKkRZSGje3l6J4v7rud5VqpnwKH99Fk= X-Gm-Gg: ASbGncua98MR8blTFBou9muAowQ5bKCKzLy/E+rMQ1N/yr16C8N50hZql8sysSte398 62gzxJoF1wwh1adyx71LciUE+GqvhgJTbERlL0YHm/pxOu5YEqQJuSXa74kLgOGuqBqXaRUZoqt xiBsKtUR0+C+quxTorw4pQIt7CmaeDbxvE26Q/gbpUrPsa5ckDxj9/rVKZ8969CaGPeQ5PFO908 P7AVvbXwy23YOu0gdhDKf0gkvZPRYSOxSvtTuEuK00nT2XnjErW7Wx/7dMwxx459dMl08UBRaXb dTfis12D8Aav2t4ShPPCY3t4ad95rEluGsswbsl9vhA= X-Received: by 2002:a5d:6d8c:0:b0:391:275a:273f with SMTP id ffacd0b85a97d-39132d062ffmr6592140f8f.4.1741599435302; Mon, 10 Mar 2025 02:37:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExIpAItUyYwNwbwrEcWjE6mY/t/AxIyxf0UMVVUy7pCml0YQyGPHbTBqkpFTvPNnlmG/D4tA== X-Received: by 2002:a5d:6d8c:0:b0:391:275a:273f with SMTP id ffacd0b85a97d-39132d062ffmr6592100f8f.4.1741599434809; Mon, 10 Mar 2025 02:37:14 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.49.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43cfcfd2a95sm10234805e9.29.2025.03.10.02.37.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 02:37:13 -0700 (PDT) Date: Mon, 10 Mar 2025 10:37:10 +0100 From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v3 4/8] sched/deadline: Rebuild root domain accounting after every update Message-ID: References: <20250310091935.22923-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rebuilding of root domains accounting information (total_bw) is currently broken on some cases, e.g. suspend/resume on aarch64. Problem is that the way we keep track of domain changes and try to add bandwidth back is convoluted and fragile. Fix it by simplify things by making sure bandwidth accounting is cleared and completely restored after root domains changes (after root domains are again stable). Reported-by: Jon Hunter Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for = hotplug") Tested-by: Waiman Long Tested-by: Jon Hunter Signed-off-by: Juri Lelli --- v2 -> v3: remove spurious dl_bw_visited declaration (Shrikanth) --- include/linux/sched/deadline.h | 1 + include/linux/sched/topology.h | 2 ++ kernel/cgroup/cpuset.c | 16 +++++++++------- kernel/sched/deadline.c | 16 ++++++++++------ kernel/sched/topology.c | 1 + 5 files changed, 23 insertions(+), 13 deletions(-) diff --git a/include/linux/sched/deadline.h b/include/linux/sched/deadline.h index 6ec578600b24..f9aabbc9d22e 100644 --- a/include/linux/sched/deadline.h +++ b/include/linux/sched/deadline.h @@ -34,6 +34,7 @@ static inline bool dl_time_before(u64 a, u64 b) struct root_domain; extern void dl_add_task_root_domain(struct task_struct *p); extern void dl_clear_root_domain(struct root_domain *rd); +extern void dl_clear_root_domain_cpu(int cpu); =20 #endif /* CONFIG_SMP */ =20 diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 7f3dbafe1817..1622232bd08b 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -166,6 +166,8 @@ static inline struct cpumask *sched_domain_span(struct = sched_domain *sd) return to_cpumask(sd->span); } =20 +extern void dl_rebuild_rd_accounting(void); + extern void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[], struct sched_domain_attr *dattr_new); diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index f87526edb2a4..f66b2aefdc04 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -954,10 +954,12 @@ static void dl_update_tasks_root_domain(struct cpuset= *cs) css_task_iter_end(&it); } =20 -static void dl_rebuild_rd_accounting(void) +void dl_rebuild_rd_accounting(void) { struct cpuset *cs =3D NULL; struct cgroup_subsys_state *pos_css; + int cpu; + u64 cookie =3D ++dl_cookie; =20 lockdep_assert_held(&cpuset_mutex); lockdep_assert_cpus_held(); @@ -965,11 +967,12 @@ static void dl_rebuild_rd_accounting(void) =20 rcu_read_lock(); =20 - /* - * Clear default root domain DL accounting, it will be computed again - * if a task belongs to it. - */ - dl_clear_root_domain(&def_root_domain); + for_each_possible_cpu(cpu) { + if (dl_bw_visited(cpu, cookie)) + continue; + + dl_clear_root_domain_cpu(cpu); + } =20 cpuset_for_each_descendant_pre(cs, pos_css, &top_cpuset) { =20 @@ -996,7 +999,6 @@ partition_and_rebuild_sched_domains(int ndoms_new, cpum= ask_var_t doms_new[], { sched_domains_mutex_lock(); partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); - dl_rebuild_rd_accounting(); sched_domains_mutex_unlock(); } =20 diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 3e05032e9e0e..5dca336cdd7c 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -166,7 +166,7 @@ static inline unsigned long dl_bw_capacity(int i) } } =20 -static inline bool dl_bw_visited(int cpu, u64 cookie) +bool dl_bw_visited(int cpu, u64 cookie) { struct root_domain *rd =3D cpu_rq(cpu)->rd; =20 @@ -207,7 +207,7 @@ static inline unsigned long dl_bw_capacity(int i) return SCHED_CAPACITY_SCALE; } =20 -static inline bool dl_bw_visited(int cpu, u64 cookie) +bool dl_bw_visited(int cpu, u64 cookie) { return false; } @@ -2981,18 +2981,22 @@ void dl_clear_root_domain(struct root_domain *rd) rd->dl_bw.total_bw =3D 0; =20 /* - * dl_server bandwidth is only restored when CPUs are attached to root - * domains (after domains are created or CPUs moved back to the - * default root doamin). + * dl_servers are not tasks. Since dl_add_task_root_domain ignores + * them, we need to account for them here explicitly. */ for_each_cpu(i, rd->span) { struct sched_dl_entity *dl_se =3D &cpu_rq(i)->fair_server; =20 if (dl_server(dl_se) && cpu_active(i)) - rd->dl_bw.total_bw +=3D dl_se->dl_bw; + __dl_add(&rd->dl_bw, dl_se->dl_bw, dl_bw_cpus(i)); } } =20 +void dl_clear_root_domain_cpu(int cpu) +{ + dl_clear_root_domain(cpu_rq(cpu)->rd); +} + #endif /* CONFIG_SMP */ =20 static void switched_from_dl(struct rq *rq, struct task_struct *p) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 44093339761c..363ad268a25b 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2791,6 +2791,7 @@ void partition_sched_domains_locked(int ndoms_new, cp= umask_var_t doms_new[], ndoms_cur =3D ndoms_new; =20 update_sched_domain_debugfs(); + dl_rebuild_rd_accounting(); } =20 /* --=20 2.48.1 From nobody Sun Feb 8 09:11:06 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC91722259E for ; Mon, 10 Mar 2025 09:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599496; cv=none; b=SkLbkgDB2FHMrFkO4XNlsEIbOzlaUXs4zrYNThzKGGiD1qcizIyyk6hBxTZG/YWM/0h5+oK3NSIfMvbuQWJrBPLkXlx2o0rp+e7tTWblZ6jlSKY0AtMktovWvVvNOcAyzLNrFLIQy0efii49me7LuCRZ7L+56jOqGflhBcRWkv4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599496; c=relaxed/simple; bh=BHue35hwwG3uT7E8+0hMoxP2lkZ4XCqRtFoZXci5eS4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=luuxMYgVeYtivbVzP0Jxse1t1L9/jn/K/bxcpzdHmfsaaA5EgtH5jocIJUBCSJknZ+r1PGcKPS5ZWtZu6VbMgL+iAJvEybHgQqD7iiKSWT+rjIJSfuEDXoM4yKCGE/i/yNNW3QYx9k3cbafySc5mPQnYkSSAzb3Iqfw8wfogT0M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LzujpqwH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LzujpqwH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741599494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wzT3QSYSjmZ8G9yIANDr+xNeKe7EEcc7gC4o7NwYdRc=; b=LzujpqwHKE812U1FD3si1j0QN8El+SiY/M2c5Q8nFnuIrrVHyMMunLrB+MP6kep+TrhvgH acVUAJPKvuWJrtDFnfN7bjyTBsVMklA+WYCNmf5V07uAD4gb5sANpAWCCWecR1ImcKyvIt IVzGzqOSowFHeY0GEuqfxwXKn8tg23w= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-114-koRBuuwuPoymuTWXKF2krA-1; Mon, 10 Mar 2025 05:38:13 -0400 X-MC-Unique: koRBuuwuPoymuTWXKF2krA-1 X-Mimecast-MFC-AGG-ID: koRBuuwuPoymuTWXKF2krA_1741599492 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cfda30a3cso1570965e9.3 for ; Mon, 10 Mar 2025 02:38:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741599490; x=1742204290; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wzT3QSYSjmZ8G9yIANDr+xNeKe7EEcc7gC4o7NwYdRc=; b=gtZkOoLRrVNzsySUN96//AD7bGIlPbsdmd1qQUUoDfUmrrbdIc+VWI1iQ77ruI7/kE tD6eRdoabxJlYd1N7AxikIjOIDD8h84vakBuEvKKnCF7wW5nkI1tWOw2BzmIPZU9OrN1 98uGYkqsCSxgExLjFSHCcTkUy4c3un6tK4YjMrLxr6muDG0r2bTIOhJ8EsaMouCBU6yC lSaPx/NahsE8qdSeROm++Czmg9fHAWc8T6JenOInbZfi3iDCVhvVFJy2LLyQT2MdV9As H+QyGJ1GP/Xt6ih1MAaAtPD4Etq4uPHtJrqdwlHfVTxUiohCqNvYgUjshcn9u1IEyfU+ Z4rw== X-Gm-Message-State: AOJu0YzJbUbpu9YhT5c0MUdmr26NteJUkUbjMImF2hI2YvurTJiF1AYQ A2ZON8ZdRI+tXo2l2+2QnAKfUU/jO3qJxzFqts5Ak2YjrPwjQr+CtUPtEuQQh+LxT/f5dJukYIl PdHnCMfgtmfMr4L68s8tTogxmaTEnyEOq8bOVNTEpywmk+SR1/vgQ2FG5gebYT9SS/TnkI/NxBh g/+7jG8/RDr/pBtNlc1rzVtRk1uFtPU9MmEpzOg52N0y5TRl6rd5o= X-Gm-Gg: ASbGncs7zvixtiGk4DyltwlzkgV8YzXxZJ8ATJ3oHK4mMsTpKsl824YCXSBDqsO5OYr 80wAupjpx5MgI4czVcuNOiQFATZkWXYoW0ShmAe3OVhBMB3nYgi9nmzZoQmOR7Xz9pqprvvBqMh Ey4/1aU99nRbXUtup1vofKpqtHXK5NyRaCsiHyQcYh95TYCT/cRST/5O8PJiAiuPnG/4ve5ez8m i4cm1cLcb7T8fUkJLIoRmhqwpNr5IYVafkTfLaAR5/PRAdVHcbYcSfGEplbR7no5JMsV78taxMH BpzkdaD6TUwrVc78QAdAPbt9Y7TS+3iU3eA50L+fOHw= X-Received: by 2002:a5d:64e3:0:b0:391:4889:503e with SMTP id ffacd0b85a97d-3914889519cmr2493714f8f.33.1741599489779; Mon, 10 Mar 2025 02:38:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFn7gYGzhHmPcL3pfBYzEcWegmbHHUv/hFVbJA3S4wb9NqXKERnd8N+fs7CM4yauTmldCM7Kg== X-Received: by 2002:a5d:64e3:0:b0:391:4889:503e with SMTP id ffacd0b85a97d-3914889519cmr2493656f8f.33.1741599489271; Mon, 10 Mar 2025 02:38:09 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.49.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfb7aefsm14111154f8f.20.2025.03.10.02.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 02:38:07 -0700 (PDT) Date: Mon, 10 Mar 2025 10:38:05 +0100 From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v3 5/8] sched/topology: Remove redundant dl_clear_root_domain call Message-ID: References: <20250310091935.22923-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We completely clean and restore root domains bandwidth accounting after every root domains change, so the dl_clear_root_domain() call in partition_sched_domains_locked() is redundant. Remove it. Reviewed-by: Waiman Long Reviewed-by: Shrikanth Hegde Tested-by: Waiman Long Tested-by: Jon Hunter Signed-off-by: Juri Lelli Reviewed-by: Valentin Schneider --- kernel/sched/topology.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 363ad268a25b..df2d94a57e84 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2720,21 +2720,8 @@ void partition_sched_domains_locked(int ndoms_new, c= pumask_var_t doms_new[], for (i =3D 0; i < ndoms_cur; i++) { for (j =3D 0; j < n && !new_topology; j++) { if (cpumask_equal(doms_cur[i], doms_new[j]) && - dattrs_equal(dattr_cur, i, dattr_new, j)) { - struct root_domain *rd; - - /* - * This domain won't be destroyed and as such - * its dl_bw->total_bw needs to be cleared. - * Tasks contribution will be then recomputed - * in function dl_update_tasks_root_domain(), - * dl_servers contribution in function - * dl_restore_server_root_domain(). - */ - rd =3D cpu_rq(cpumask_any(doms_cur[i]))->rd; - dl_clear_root_domain(rd); + dattrs_equal(dattr_cur, i, dattr_new, j)) goto match1; - } } /* No match - a current sched domain not in new doms_new[] */ detach_destroy_domains(doms_cur[i]); --=20 2.48.1 From nobody Sun Feb 8 09:11:06 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BADF722425E for ; Mon, 10 Mar 2025 09:39:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599558; cv=none; b=px0KNfG6BSrZsLnA+pw7usC0G9NGImOXV6ktwPkOf7asBsya+ktlYbx5bOmijOw/TdVJx5v7VmM/XCNGHuRFhCQBFkrGURYeVJ0hBm5vHPEAqmFarzLXaMmOqT5ueKiYUkBpRLOYb+DnI4jB5rag23WpBCJbJWcAp0oe5n3dAh8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599558; c=relaxed/simple; bh=bSLpIN8jUdE9hjPba80yyQ52wEXooa6uwUai3Cd9z98=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UPGcj30B+Ec2wjdVtduVzfB1z7zHQI8ARhStlTt/zuQG+XgfL6YxMvRlUB82eqmxbTOfg10kuh1E+k/6u2TbiyrsJA0YxXsCGWV1pTSFFOcdx24+ElNCVGZP/C6nQp6p4kt1uQt+ykLtY1Vb44cVdgemxJzP322xv/N30JqqEYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=InFua6Lj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="InFua6Lj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741599555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SVuaA2xIyG++dtxNPCuZKJBhnBA8DE84LuwYVWooLXw=; b=InFua6LjYlbKGDY0dEj2yDuGUP2WDcoweBguCE9RQ5GAHmnvht7HKBriOJENBr4peWHDBK AP5od1hVtDQF+V9U74oman4Jp/y4HZYo/nbZK1r/2Lp2F9Bwlz5feJCd3hNfVVmIzrgpVH V1hOnX5f3UYMmS4/K1xIrSrydm1gpOQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-59wLjk4XMCCtXQ8KbyruRA-1; Mon, 10 Mar 2025 05:39:14 -0400 X-MC-Unique: 59wLjk4XMCCtXQ8KbyruRA-1 X-Mimecast-MFC-AGG-ID: 59wLjk4XMCCtXQ8KbyruRA_1741599553 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39141ffa913so742088f8f.2 for ; Mon, 10 Mar 2025 02:39:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741599551; x=1742204351; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SVuaA2xIyG++dtxNPCuZKJBhnBA8DE84LuwYVWooLXw=; b=hYMyqto7J7Eo+FN1ivWpVGKhV0OrWKTcSo/RtWJH+muvhzPgqVxYNCELlKjQoKSdQ6 cOpoGIAdlvDTGUzhcnQNSCS8K27fOpW72YUVK26gPUE6doXFmdcCR68Fjc9mvubGFL73 02ZXgWRX+lWWKTO85dT39r0ZrHk+Ffwgl9QsW0pGTeBnJlAEl2dwsDzzly0y2X/1mRD9 hI+1Hk42FyWNZs8WX7/9yhNNUpnflHy104WwebESkLnW1lThVf8dbYqKjRZCg2spd/mx 0bYyy/+9xGyXUx34Xg7I2xJWE9CtPgH1OrDxAqDTFEwfMJoLEP7tHP1EY0GEkk1X8zp3 1mZg== X-Gm-Message-State: AOJu0YyAqwPKYk6TzmNAWMTMVtHEjl/bFaRh+D45ishqgArdzhKSIcrx ulJ3zZSfbGwHHt+idbR3m6TdJR0q5kb+nCO0cwGRoJi+IBeF7M+j0j7jFvm1QXS4c/Ghh3td9La rC1vDCYMSW2HoETyH1qq7ZVRWwEIz/JtmqlsoTvgLHhqjJEn+wrqzig0jq5ed2HOjDe0nKqTfap q85MOBd28qvI2Xu8Tyh6jvIK1czjlOc+sO55jUP59u/GBeRVw8xsg= X-Gm-Gg: ASbGnctN/asWvHSBYCFrBee2Wo+KCaRNEdVYTzfji3hHQ1hr2RiUUYXMkrCMitO5X1a MXo/WtjxvW/aTv7JY78/cC10zH/SfFtH75YDy40CVBA0M3A2kRZMoKVkFdAlFeaukIIAoeMiHEf 29vX8/dbXwkYm5vujRhk11v1MdGQiqhb4TBAR0FN4R7HrS24KJaUWs7nPptxFWG9mdQN+iy0Ur0 D1t45m2f2si550yKv/jS83kboczF1Y+Kx+Z1653yqolI9EDX2gPAy8WaCVb23DT/fWVvy7lbFXB 1Oi+q00V5oynIOkUNj3LP3sqkv1zz6RpA6kPgJqkZk8= X-Received: by 2002:a5d:6d8c:0:b0:391:2a9a:47a3 with SMTP id ffacd0b85a97d-39132b5b802mr7939604f8f.0.1741599551618; Mon, 10 Mar 2025 02:39:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtDGjwhZCXPUTTbyre3WWNNE0mRndLmnRoT0m5vbhow+i+lvg8pi3nxLQvh3LPFdggIS2WXg== X-Received: by 2002:a5d:6d8c:0:b0:391:2a9a:47a3 with SMTP id ffacd0b85a97d-39132b5b802mr7939557f8f.0.1741599551159; Mon, 10 Mar 2025 02:39:11 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.49.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c01ebddsm14627111f8f.60.2025.03.10.02.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 02:39:09 -0700 (PDT) Date: Mon, 10 Mar 2025 10:39:07 +0100 From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v3 6/8] cgroup/cpuset: Remove partition_and_rebuild_sched_domains Message-ID: References: <20250310091935.22923-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" partition_and_rebuild_sched_domains() and partition_sched_domains() are now equivalent. Remove the former as a nice clean up. Suggested-by: Waiman Long Reviewed-by: Waiman Long Reviewed-by: Shrikanth Hegde Tested-by: Waiman Long Tested-by: Jon Hunter Signed-off-by: Juri Lelli Reviewed-by: Valentin Schneider --- kernel/cgroup/cpuset.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index f66b2aefdc04..7995cd58a01b 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -993,15 +993,6 @@ void dl_rebuild_rd_accounting(void) rcu_read_unlock(); } =20 -static void -partition_and_rebuild_sched_domains(int ndoms_new, cpumask_var_t doms_new[= ], - struct sched_domain_attr *dattr_new) -{ - sched_domains_mutex_lock(); - partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); - sched_domains_mutex_unlock(); -} - /* * Rebuild scheduler domains. * @@ -1063,7 +1054,7 @@ void rebuild_sched_domains_locked(void) ndoms =3D generate_sched_domains(&doms, &attr); =20 /* Have scheduler rebuild the domains */ - partition_and_rebuild_sched_domains(ndoms, doms, attr); + partition_sched_domains(ndoms, doms, attr); } #else /* !CONFIG_SMP */ void rebuild_sched_domains_locked(void) --=20 2.48.1 From nobody Sun Feb 8 09:11:06 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 905B02253E4 for ; Mon, 10 Mar 2025 09:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599614; cv=none; b=RPbAuGbYlWnErvI+ut1bilWuRaihiQoFxGNkiuFW/lX64jKleKrwrDhTXqZIM4s8oCkwSi3y0nVE8I6h4fbJu5+An4TLhmWL7KeYJfMqPpp98dGPWzCL5zq3vSQqnSnV2yYUJvPItAtUmmjA5nsjHw2UHGeXK/77hqmIY+RTKjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599614; c=relaxed/simple; bh=cYVuCi9smgjEBwcOQ3WPdNQXmKvk2MX83ZjOV1VFGm8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TRTV12xQaz+g+/oFKOOVrP86HyFI06MXQVWvmZBVLirjFGWhlEWc8B+ogxMOFLD6YOo0bk3SbpU1hRzegU85P0OpaTBQkVWrpAgJhKGsV5aBRXlqAZ4JAf7pMnwyG/bwbwY7yh2BY+USDvUNgX/XkcdlnfUTJR16k8BwJ7HcRHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UmY71huw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UmY71huw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741599610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iUhCbqWkoIL0WYlXStoL+S8I9eid4bkKJk7tnyoFRWY=; b=UmY71huwFT7ztidUH8/t9mSJV2abLJLoXeRDF0nHcn2OzBAoRi0HvxP6ANenJ1pcEuj0iA Ynxg/AT8hjcfx0JXELHGp6d40GruSLn8Kcfghgiw9WYLNP3y/Pvt6KRoEE1ngEKy6K4GGJ QBAcRvkRFigtY5zibR+8OhzFcb6HRfo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-QdUTjT9OOGW8KAEf3lShdw-1; Mon, 10 Mar 2025 05:40:09 -0400 X-MC-Unique: QdUTjT9OOGW8KAEf3lShdw-1 X-Mimecast-MFC-AGG-ID: QdUTjT9OOGW8KAEf3lShdw_1741599608 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39126c3469fso1625922f8f.3 for ; Mon, 10 Mar 2025 02:40:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741599607; x=1742204407; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iUhCbqWkoIL0WYlXStoL+S8I9eid4bkKJk7tnyoFRWY=; b=g7GFQM1M3ZHftddydfpxOuJeOM0EXhI1T7ivWVhO9fMyM3gM8HZtuHiLF0pr1AQ6Db ZTxcLMChkonqcftco/Y3LwArObkZqyCoxs2/X+fTuRQhWY2do61Efz/evBIaRS2rrZ7d qCcJDheKryr6QCWG93zXzqqhoBHXaPoiKWecr6I7n+3zmbomtS3MHC6Rg5In0DEq8h58 wEYhfZQ99wHktj5DO8L2p9hhv/Yo0P3ZlTgq+RH/6m6tm6amCe+ezu3rtdlD98k7Rhvw S1tSI8LRj5TGfnjjxSTR7gHgXcnDR9iqSLAkB1eb75/FAGXcPaA2sO1lVHi86/he2n0C wU+w== X-Gm-Message-State: AOJu0YyCD8piDtSOPN4QWByI9sn0ZsyHKVHXfWAhA/UQ70tuAx4UxKiM CHLIzcIGHPOMMeTExDdHVy8oCi1wcKHzLwhcUYPgxKY4ysFo3TLCIElL+kcR2TJRrzRjO9h1Bv0 /BPMIo4f2bQZvFWwdum1fcIQMSHCmP1PjPZjU6kXJPzpo41lVgu63QfsfZVLDYlXoe3Poo1GBuB JeO0bQP17xbjh6/4BpQWtvsbGFHmjrHHJUwHnlJtBqqQ1VB99r10A= X-Gm-Gg: ASbGncssW+nX7qr1blxCnANPwkEuq1YEGDc2Pglpy7awJiPEjai8eRv/rihatXz6u4f cnhajIVN1MPJh6pDXnM2RA1aavsyHcM7QzUrN+V/EYYyl1zE0jW0bKznL+Q1+8cbBP6qG76xSP1 dS7no5EYATw88jns66GbXrDjqCxH2ZYKmOakpQTzv/a1iC+dAY6ckRtoCxNhDjGvxvTbC+NLpl+ VSJvFFb2KWWJcRwqwALf23sfSzEmG88lWz0hkVv9GNPSXCfppubl+b9H4hAZ2oBQxB04sl7lgPn vK8oDhuKW6bUDinNU0jZ3PmYN8DCkKkZ0BYnsspLens= X-Received: by 2002:a05:6000:1849:b0:391:3fd2:610f with SMTP id ffacd0b85a97d-3913fd26306mr4340087f8f.13.1741599607033; Mon, 10 Mar 2025 02:40:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcsHZY7qjs8N1eVHZwzlGoyokzF396DbRgaw/pRBbS6FjqadMwZdpf2flPxcgdEDc9YGKV5g== X-Received: by 2002:a05:6000:1849:b0:391:3fd2:610f with SMTP id ffacd0b85a97d-3913fd26306mr4340055f8f.13.1741599606572; Mon, 10 Mar 2025 02:40:06 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.49.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43cfcbdd0a7sm11669675e9.11.2025.03.10.02.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 02:40:05 -0700 (PDT) Date: Mon, 10 Mar 2025 10:40:02 +0100 From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v3 7/8] sched/topology: Stop exposing partition_sched_domains_locked Message-ID: References: <20250310091935.22923-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The are no callers of partition_sched_domains_locked() outside topology.c. Stop exposing such function. Suggested-by: Waiman Long Tested-by: Waiman Long Tested-by: Jon Hunter Signed-off-by: Juri Lelli Reviewed-by: Valentin Schneider --- include/linux/sched/topology.h | 10 ---------- kernel/sched/topology.c | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 1622232bd08b..96e69bfc3c8a 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -168,10 +168,6 @@ static inline struct cpumask *sched_domain_span(struct= sched_domain *sd) =20 extern void dl_rebuild_rd_accounting(void); =20 -extern void partition_sched_domains_locked(int ndoms_new, - cpumask_var_t doms_new[], - struct sched_domain_attr *dattr_new); - extern void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[= ], struct sched_domain_attr *dattr_new); =20 @@ -212,12 +208,6 @@ extern void __init set_sched_topology(struct sched_dom= ain_topology_level *tl); =20 struct sched_domain_attr; =20 -static inline void -partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[], - struct sched_domain_attr *dattr_new) -{ -} - static inline void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[], struct sched_domain_attr *dattr_new) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index df2d94a57e84..95bde793651c 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2688,7 +2688,7 @@ static int dattrs_equal(struct sched_domain_attr *cur= , int idx_cur, * * Call with hotplug lock and sched_domains_mutex held */ -void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[= ], +static void partition_sched_domains_locked(int ndoms_new, cpumask_var_t do= ms_new[], struct sched_domain_attr *dattr_new) { bool __maybe_unused has_eas =3D false; --=20 2.48.1 From nobody Sun Feb 8 09:11:06 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7C1B2253FF for ; Mon, 10 Mar 2025 09:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599667; cv=none; b=PuGYdjZIosmspJD7+TDVp+VHzjPb2qJoxIQw34CDnO691urCXHzTCV5t1In+uzWvqV9NZbTsswPRhSfm1LtTopfKP2PMQTMhRbQhEym25Sh/3npciojohOXqYygQadOVIJPiAu22oX6oiiCPhZXhvD0CmN/liePKGty+knHDu7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599667; c=relaxed/simple; bh=D0qnJuVKmT1hoAQ/CBLa54Ot/pfZ5sOIHU5WXg+WzfI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZVbyLR/rdFDdMIfeYNId636XAPKibeVQLOx5qsYqGb9QGKQTgw38jv1vr9IoHV9LdIwD6UnzRtZZkRGY7ZlFi7cYbyGO8OBDwr3vAZwTCpEazu8flJWietv5pVvQwPoTtPz5W31Ow82n83CZ/sky0CRiEyDH+D2BPX74OP4hcpQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XWw04myE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XWw04myE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741599664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JmC4eg+RZE37SxbmWLTbwWm2ZOdazyFKRLy1uOVpLe0=; b=XWw04myE6XrFvRc18xPftt9rcsHyscX4JMtK/3VFh+GrzDK+5zykwsGvg6/wMFNPs2QdE0 b3Fq4NCV912seTCrKCf2tIL553ViN5i8EZOBw41eR7VYZQ5YL+wGJpPL7VMq6I+K4G/Q/5 0YJnZjRe5rUgnQvKAig8y0Qmld4p0DE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-2qQyJSP0MvmRYNwqRHZsNA-1; Mon, 10 Mar 2025 05:41:03 -0400 X-MC-Unique: 2qQyJSP0MvmRYNwqRHZsNA-1 X-Mimecast-MFC-AGG-ID: 2qQyJSP0MvmRYNwqRHZsNA_1741599662 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3912fe32a30so1404977f8f.1 for ; Mon, 10 Mar 2025 02:41:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741599660; x=1742204460; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JmC4eg+RZE37SxbmWLTbwWm2ZOdazyFKRLy1uOVpLe0=; b=l+JErkgCJN+LX8H37TX53Lfpa/YBx2vnVoWL6TkVPVp+BH6Unj8wo+HouK0WfXvoOm 6GCFwb8o2eFaf9toPtbsn4lewxPMl7fYQqYl5zn0CPc6IC8EitWjzxiCYMg1jtcxroM6 +CH6JyVFYPO33UaWeitsH+3CveJSzyyCBJgJ7R1+vx4r0mBJkeJnaQZQaVL8xFXPl8/z D8q6ntE88IJhZwvY5pB58+NC6DrTqkxUT3PE8gAdCd2EIv+PKB7dumacjxuVHiDvCF3U QCgUnQyqfRutg78RMJ2bcverZQDtwLzvH1OXPgwO680rqYHytyY+FZYGKkG3z0s4N8ZL N48A== X-Gm-Message-State: AOJu0YznDeLhanE7SlwKGBcaytbT/XdHBXaDdARDV7Q83NBwRfjvYQh8 8Dn8HgLhY6Kc1KiQlW3c0Enj60JD7suvUSZIQzlZvlvPBT3mor8/Wb8A84a4zI94Xa8vpGOgaa0 RhBcKVwRm6fIjIMlp8aV22u0MKYp4BSiBaSnlkMJJJUrGh30P1jTbyYZkjKk0YZXAIvM0HHgzMT hVGCJlzGkgNwvrWqcG0kMceFUXlVoRFyFztOjN9lqam6eICSrNN6Y= X-Gm-Gg: ASbGncsei7tDh8JGlmEZgwNquo922fMOiBBqvppKOg3+nowvDMDiwGa8PjMXvDUq367 RO0zdqflL6o8D+NNEzs8MkVeNTIrP8lZ3FgCh4OHlTtodjiB9j7vufF3lZ0Rn4pvBiDffcTpMpe /lz1pdCGSoXgEph5iVWBB4hAuY8UPJD9EUWjT4Ggu3tk0NVAOxOcDUEuUn3iMTRi6yC97TeSQ46 4aLPU+ef4j/8rPotEsEslyxVacBxwBuN1OmkDPyrP+DvPKZdBNYgrm3rDbazuvPrOQqS2HMf4Fu lAWdzZQAvL/spplI04BTNUDDZYAz2rvcfq+7tqIureU= X-Received: by 2002:a05:6000:402a:b0:391:6fd:bb65 with SMTP id ffacd0b85a97d-39132d67e24mr8087694f8f.9.1741599659846; Mon, 10 Mar 2025 02:40:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3sT3VxqRqGbVJqED2DrKV+dHBvPin9Rx9+sU0PGy8vpk5mvBzNmpBa8T06MTqckjUtnwpBg== X-Received: by 2002:a05:6000:402a:b0:391:6fd:bb65 with SMTP id ffacd0b85a97d-39132d67e24mr8087654f8f.9.1741599659379; Mon, 10 Mar 2025 02:40:59 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.49.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfb7934sm14529582f8f.12.2025.03.10.02.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 02:40:58 -0700 (PDT) Date: Mon, 10 Mar 2025 10:40:55 +0100 From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v3 8/8] include/{topology,cpuset}: Move dl_rebuild_rd_accounting to cpuset.h Message-ID: References: <20250310091935.22923-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250310091935.22923-1-juri.lelli@redhat.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dl_rebuild_rd_accounting() is defined in cpuset.c, so it makes more sense to move related declarations to cpuset.h. Implement the move. Suggested-by: Waiman Long Reviewed-by: Waiman Long Tested-by: Waiman Long Tested-by: Jon Hunter Signed-off-by: Juri Lelli Reviewed-by: Valentin Schneider --- include/linux/cpuset.h | 5 +++++ include/linux/sched/topology.h | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h index 835e7b793f6a..c414daa7d503 100644 --- a/include/linux/cpuset.h +++ b/include/linux/cpuset.h @@ -125,6 +125,7 @@ static inline int cpuset_do_page_mem_spread(void) =20 extern bool current_cpuset_is_being_rebound(void); =20 +extern void dl_rebuild_rd_accounting(void); extern void rebuild_sched_domains(void); =20 extern void cpuset_print_current_mems_allowed(void); @@ -259,6 +260,10 @@ static inline bool current_cpuset_is_being_rebound(voi= d) return false; } =20 +static inline void dl_rebuild_rd_accounting(void) +{ +} + static inline void rebuild_sched_domains(void) { partition_sched_domains(1, NULL, NULL); diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 96e69bfc3c8a..51f7b8169515 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -166,8 +166,6 @@ static inline struct cpumask *sched_domain_span(struct = sched_domain *sd) return to_cpumask(sd->span); } =20 -extern void dl_rebuild_rd_accounting(void); - extern void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[= ], struct sched_domain_attr *dattr_new); =20 --=20 2.48.1