From nobody Mon Feb 9 10:51:38 2026 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC96C1DED4C for ; Mon, 10 Mar 2025 20:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639393; cv=none; b=nyFV5bnrXXeSEU6lyKQWylcSQyWfE5s8Z7S6qSh8xtz0VjcspBsNubsU/yCvSXOnqSboZbYjhIMwXNcUkgmBx1LJjMxzAYROA9bf6SSVrhNl7klwG2yolS8D3qevK/XROmyBNdKEvzza0PfdsXUqfyq12BBeND4B3hOn6yeK15E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639393; c=relaxed/simple; bh=0xf2lfBMlkwq8GDrukDrWvlzGt+OAqJxAVu2qGUaX1U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ken5yFuWCkKBdUvGK/P1IBC25p4gauTDLBXmB8HIXe4iXLecUEf52M77vSzJ8iyjJ+BmRC2vdQWHXFBj8OTebTn6iDRs6r8gmph7zp1oLJo6I2s/XZdApwatMbOnAU8Ap8MxJIeeAGxsVY6XOfjwbtneJ2GSy204pInILW/cQDU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=n6hqXagm; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="n6hqXagm" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5fe944b3fa0so2154542eaf.0 for ; Mon, 10 Mar 2025 13:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639391; x=1742244191; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=epdj0pGglcLo1fb3QxJPZQv/lE+WglsZbV58ruZDnRA=; b=n6hqXagmka+4Nw0mNflqhQASedNuAW2+qwbRmRCHJlBVF+i5nNZW+qpNmakA64UrhS Ar/SlCFYpaKCmaTUaX6SBuvUi8EAsSip1URPpIQgOIePIuo1CQ5UjiAKz1X6Ae2pJefd jelbsfld/VB82/6WFOcPJIErttJEzUOprv9OskVwyKm02S/Mxh9CgLaGLdRanmoTz/0x eB1x66dzpBWwDAe7HbLSAJpqVMpHWpQ5ya/KWJHJiuAIjA/VlK1EFIyrQyiS4VH5hN2z uVr1Wk9LhuzzsuaypYD6a9d6PfobF0zUa2UEtPifSK7NIMMtaUTJVRwhltRHjwnlEIFs UAHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639391; x=1742244191; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=epdj0pGglcLo1fb3QxJPZQv/lE+WglsZbV58ruZDnRA=; b=Xbb5F+4XV3VPeyEhl+3Jxd0kkwmmQP/1eQbjXjwgTe/X2zwnAnOiDsK/j3hXFoxJHL oSl3FrWMnXRS2SPHqTKOL3JoYHc55/X0TiV3Kqh9iMbq32bxxAEYTH9Y5DdxuVipKys7 /z3GIj7kj/hkESojFl5Am/MDj9IhhRFldPj8nHLQiZVanLEZKqJCPHTvB9B01x9nWEUl Gyu8BPYBy1ZkROdQsXiSWXSDoMVWpocRUNj4I9ueYQoy6Od1BtqsnZjlwh4+8IETnQzp EHmPUa2bvdwPpAiaAz3gkv+BOuN6lFXYvBLlC0pj3L22wTfLPP9a6qpi3+wcXLh7spBy XGkQ== X-Forwarded-Encrypted: i=1; AJvYcCXmwJHnnySr8DwRyeQWOX2rT/c7S1iDTyX6XjRPgOk43TxzNMyfy/7DkDr+lWc73HPbOhPJxCLsqWHEGzk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4kKvpNnz79fOBODLjspNIl7V2t+swqTpfIyYSJIisfumABotG y50lvhmy7ewvidQo5utxF6KLDX+FRa4zUqcaRbBH3APTXml/nuTbHMTBxH2xISE= X-Gm-Gg: ASbGncsf2C1vXTdniREiEzau9reWXpfMAu0AfNApFcrfqEXU6nGFhIwFVe+gQo4ws4j LrP1PKps1Sj3QdJc1I/+Yk4slR7W0aITN/8H6kPKuFaKPIH+Y3n4uonWhot1ApPdIotfvwEm/SH d10L20g2g+ky2cIBR3Xgej2Af3jQBxgLDdzQLkQ89u5BT0YBJ4jNj1qtdwqhNthmf0JcT45Xez2 ZFHWYoYhCr32jke3VRqOIBHvuo73FXR2bhMTiJAQyZAkbTutq/UlZo+5F5xjqD+rE4HBjU4yUee lqz6B55yASYLhlzwHk/n0O/P5CdtNoxMutSKkdWUL5TzlqazEU96qeJifVwpe2QGyMB/knAGdQ5 CCcelSe+f2rM= X-Google-Smtp-Source: AGHT+IF3tmx1kGHFtcRxx4TOJ+aZvJTTIq2iqIl6c/KAO5ngljUPVei58WxV+MNvlmlbqMMyOLaJYQ== X-Received: by 2002:a05:6808:1b26:b0:3f7:ff67:1d9a with SMTP id 5614622812f47-3fa2c78e8e6mr559991b6e.36.1741639390752; Mon, 10 Mar 2025 13:43:10 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:09 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:04 -0500 Subject: [PATCH 1/5] iio: adc: ad4030: check scan_type for error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-1-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner , kernel test robot , Dan Carpenter X-Mailer: b4 0.14.2 Check scan_type for error ad4030_get_chan_scale(). Currently, this should never fail, but it is good practice to always check for errors in case of future changes. Calling iio_get_current_scan_type() is moved out of the if statement also to avoid potential issues with future changes instead of assuming that the non-differential case does not use extended scan_type. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202503040954.n6MhjSsV-lkp@intel.com/ Signed-off-by: David Lechner Reviewed-by: Nuno S=C3=A1 --- drivers/iio/adc/ad4030.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index 9a020680885d93f4da8922e5cfeecc0c7ce23f4d..af7a817e8273496e8856a5ba1a9= c2e66a11f0a84 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -390,16 +390,18 @@ static int ad4030_get_chan_scale(struct iio_dev *indi= o_dev, struct ad4030_state *st =3D iio_priv(indio_dev); const struct iio_scan_type *scan_type; =20 + scan_type =3D iio_get_current_scan_type(indio_dev, st->chip->channels); + if (IS_ERR(scan_type)) + return PTR_ERR(scan_type); + if (chan->differential) { - scan_type =3D iio_get_current_scan_type(indio_dev, - st->chip->channels); *val =3D (st->vref_uv * 2) / MILLI; *val2 =3D scan_type->realbits; return IIO_VAL_FRACTIONAL_LOG2; } =20 *val =3D st->vref_uv / MILLI; - *val2 =3D chan->scan_type.realbits; + *val2 =3D scan_type->realbits; return IIO_VAL_FRACTIONAL_LOG2; } =20 --=20 2.43.0 From nobody Mon Feb 9 10:51:38 2026 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 558D31DF74E for ; Mon, 10 Mar 2025 20:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639395; cv=none; b=IxuDK/ZxzVnS4DwoZE8+OHwH19nUY4XWoI142raxPsY759qeF0ePB7V2mEXdgudjM0F4xoIzv5K7NgznbSW3fnLSRbLyuaMYts70LCy+V2z0x/blLrsR+JVEw7YTt5p5O/jNwJxgxu7nCqxn3Je0qlNSjM8t2p29k42pGnnurxw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639395; c=relaxed/simple; bh=+TwVZuYTQ79b6GanjN1EGzCICapQzRmhbxGUNH4cu2A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h2valk4TW+oqoeZ2ehG0gCb3/gEbf23yl2skuVkgdGklmwvR1DDhqmywZ7Ig6FHrphbtY5ue+0wfHGUim/TKwA8zGNE2bapt6zum26rveKJPswlzfj4mUFfwPSxXjW6rat5p7P0WeUXPrWYaZ+nbPohUN/ZcvNvOcyVH5oAriyo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ogjHy6f7; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ogjHy6f7" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-3f7f7b70aebso711904b6e.2 for ; Mon, 10 Mar 2025 13:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639393; x=1742244193; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/i1+yoCcGTJxasoeXpfqdr+aTaqF2C4mUZj0mRPSSrE=; b=ogjHy6f76y//+fUvR1oAMBdS1vmIRIcT4n99bWIGJXvQCc1Eku4DWaKybQeGj9R4Z9 Kerva0ioQI5XowMFk4hu9pEGcg4PCGtk3riEXP3/oiIr2P/9ZVS0XlTE8vmlUF6Wz57s i4F5RF8VES7stnPQ6cRsTRIqLMfVcIg+6fDa8nm0ozITEEdPsvLfFvfDlgrhKX+ADVnr 48qRB8ssMCEV8P/9RvLghST2qQOkoC+ZY3NJF4V7fmqSyy0F2X5pZ1pybjSWQaiE/CGF JqmqUUd9lKSnD7wUWfAzeVJCpZAdXFrp2PomCDxMe36JJOMAiyF2eP9jONbv4TcVQK0k NZow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639393; x=1742244193; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/i1+yoCcGTJxasoeXpfqdr+aTaqF2C4mUZj0mRPSSrE=; b=WQSW8ETOw5RoRXfZUFn46RKEL8/Rpr8eLPN1S14cINYQfRF1SL/odrHOJMWhYGQQMK nab6kEthhswzRsRPn+tiloIxqGFqvwiqujRpz01dan9z+zEHjhi+eswPrjrv5d2bMcjB iWb+6gYfB8favQtW0dxX96OvjubcA7/7rc0WrPjjPSyIebAyrHmPXUVx6Zf/Ryl0U/6l TaMALw2wCaZzMtA4FqH8W5NCLQPnrjphP6R43bo0H4jHZtgatUopcpUuRqZGvQPLIvrn DXl7WEgZwzPxm9jKZrf8uo0vdwybiKp/gqBJgi4NnsrrFCwG3FSJG241VDzeac64Ivyj +Ebw== X-Forwarded-Encrypted: i=1; AJvYcCWJ4T0tA45uMZNXMOgxgmNIcE3cTQTHnkZ4v2GhYNYl/9slH+IyLQ34AA3/s7aLgAc1ibDQCbXhUUBOd2E=@vger.kernel.org X-Gm-Message-State: AOJu0YzAAEeIx8baaJeBlyoHL9tAyELPGdqZCmLCasP6SPJSc2Wi3KEV oDaUu9Xqg1Dbhn216gOg/yz9wSCcnVEKipDdmMPLRDbFdNRZA+3AlxFuIP4HB9RRAvq3MOrBS5N Q1JY= X-Gm-Gg: ASbGncuORYAQXXZwE2B1ebxT1huAt2cvvRNNvyiRoRl06mmRS1l8jnS9jqGqDlhUk++ WE9GPhwLS6SXvpR4iu9Y8W1EBz46W6yAD1QvOUZVUxydY8Iw33vVtiBAPRFGRdctwbYJrOh9wvX Jo9WAa4TXyWzmc8unEkqWmvJmiGH5wgCON7IMmSi1c393ZMKnqQeLSwG5SO7x6/YKjtudnRxmgS 6CKRazTiZtra6sSeMOo1t0DSGMauwt/ULOyvvEgAKfkY+grEyGIy7a0pDmsdYsPgpgfJM+M0b9h oSQRz29XtJy0lcKLkLJEw/NEEGQjF3mFlxjBCRGiAQ+WRw2oouGEbMizN6sW/91tLaB3oNXsaYC ga3Q6Rqp2MPE= X-Google-Smtp-Source: AGHT+IHBMhf/BYV0XxOJGMPZZruARQUkU+s6sttBVMMSnUfo+mtwN1idPSs1v7/aEHUiuzefAJwfrA== X-Received: by 2002:a05:6808:1b27:b0:3f6:6b64:665f with SMTP id 5614622812f47-3f697bb581bmr7694565b6e.27.1741639393469; Mon, 10 Mar 2025 13:43:13 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:12 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:05 -0500 Subject: [PATCH 2/5] iio: adc: ad4030: remove some duplicate code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-2-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Remove some duplicate code in the ad4030_get_chan_scale() function by simplifying the if statement. Signed-off-by: David Lechner Reviewed-by: Nuno S=C3=A1 --- drivers/iio/adc/ad4030.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index af7a817e8273496e8856a5ba1a9c2e66a11f0a84..f24b46164a477f9b6b5c93ffeba= 0a335f7b3de5a 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -394,14 +394,13 @@ static int ad4030_get_chan_scale(struct iio_dev *indi= o_dev, if (IS_ERR(scan_type)) return PTR_ERR(scan_type); =20 - if (chan->differential) { + if (chan->differential) *val =3D (st->vref_uv * 2) / MILLI; - *val2 =3D scan_type->realbits; - return IIO_VAL_FRACTIONAL_LOG2; - } + else + *val =3D st->vref_uv / MILLI; =20 - *val =3D st->vref_uv / MILLI; *val2 =3D scan_type->realbits; + return IIO_VAL_FRACTIONAL_LOG2; } =20 --=20 2.43.0 From nobody Mon Feb 9 10:51:38 2026 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D0091E0E00 for ; Mon, 10 Mar 2025 20:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639400; cv=none; b=cjL8K1DD89zqv/VHB+EzMWMl/0+/t7Ilh8I3UFqkfqYNR8F3pcPSWWJypgEwJhTX9ExhRoShdX19usbWf1ZBY0kJ5fk5ZgycS4rML8OMkNXtoYoRJNb5kNLkr+TdsUt5Y+doeq9WhTQxMGXIEm9YvMpMyKcTwC6iw+GkcjT2z6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639400; c=relaxed/simple; bh=u5ePsmfcDhDkeOwFNFmtVTRv9Rit4LfnW4jtEHfO+UI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bIAhozCsLN72lRYvTtA3QnEWyYCMteFwO2LUxP5TMvW885IiIFLlfsThh85C6qssgfX09cs7hKEFSo+cGp3oVaRvGUWU3Q9VtooOWIj13/ggOSJte2DqXDsNIQzehjj93JgYn6OydOKW97eMWzw3m9LnrnyS+rhu5dTm3hfagrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=2QBWZ2je; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="2QBWZ2je" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3f8ae3ed8f4so756817b6e.3 for ; Mon, 10 Mar 2025 13:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639396; x=1742244196; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OCuzGiRhkz0CBFkmeuLAdFa7ZCDNUYxNv2hZAmPEZO0=; b=2QBWZ2jeRvH+x2Yd4Cnq3fBFXtxl+lCa8ugpxYp0AlArhQ+9lNadxKS/s5m84keVe1 EqlzsNQknkQTsyq6OVq31gzv0HXvb1z7p4n+r4p33Yr8ZLS6bWDtPEEGlC4eIE2hgk+3 /XK1POM2Kt9QhYhHIfJ8Qy0/ZU/rWoPbrXcZvHFVKm23qOyXG26pGotVOqyZCXNVei2X rskPGKUR3K8uzwYNQpx30afgYf08dabGcvb5WNDqMYuDEpWjwBZ6ST+V0hzwlfSWgLLM DCwSNn1sU3PnKxOoA/8sF+CQJr/KuI8q6Wcx6a3egejludKKaWLsvzLTN2bRUhDaiqgF 7hEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639396; x=1742244196; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OCuzGiRhkz0CBFkmeuLAdFa7ZCDNUYxNv2hZAmPEZO0=; b=TiKymeWFPmQUdhibhVhBjkMzlJe9BNClmrHUmVlyM7KgSjGXYvVnc7wHIHikBuk7ab iUFZfEAmPDEJziaS07BRcdYRebqRfOaT8sXLP3DGqFhnewp1fClBgwSX5C569g08HcOm +woiMWoIXGwwRi4h1Ki3kKaOQIKxQhEUBd8eREtm2zjF0haq/lnH41XOBRBorVx6FPbd gI/7Cc/9M5qsCGbEIkIFO5lJTKoWQ9fNb8BnyPz5GtjAWO1hriCJcRiqBBPRnJu9FZfq 8IHwxusyweFEmd5tSss7Qk1BsYwvzllVNlhTTRxdIzkE/qVR/0YTUHaKxQs+s/qH0ikL LgZA== X-Forwarded-Encrypted: i=1; AJvYcCU+Fo7tWvN829xjiY5dcxOMvnj8aaVyLFfkB5LSg5SOCSZHMO0h5dNyKFadi+AJjQNEiLwsQW+uPglbCko=@vger.kernel.org X-Gm-Message-State: AOJu0YxokrDNwDMtS7Gnd1zyw13g5TGtUacpqm31cKJiPTbtcYBAvEl5 Vy7zmmfVqz0TAPDSrs+H+IWlbCfNzmI51VcnT6bmqJSIGusmjWzVA1Ro7k0Io38= X-Gm-Gg: ASbGncui026/4k1wcAkUpp9uJ1vnHK1EL3YTKw6xBURuHEf9Pyz9UwGxrb9yNrwin6f V3IwuYCbb/1gL272RO931TE8P6mDZPN9vs/pVKxTwsI85HYzlycVKBbWRU+t0K4Oh3YTGN4XlZe p1cHw/Di6NSkaS4MUwT6Ob8zP/ZZ0mUo9GdkKrk+3p82tFem9LgvDzn7UNV3FWiC5lkW4ZeCMXT kAkaMVsND7y++YtZ3L7UBeM1wA4Bf77RAvJq/HB8W9xbm1hb2ZysLQMhnA2peLLqdUPTLyOLO96 8CxeIW1CjA1w8kGulGXOFe8HIhW6pibhxxhjds6+mlYJyUf87Zj5F8JWOqu/ECYaJFnZSb4iVBI j X-Google-Smtp-Source: AGHT+IFyOgnLNUP09CaNVpg3/60xdXC/GRP1hdw7pw4FVDHJLFomixKx8H+hEkS0rIe2cI6usE+vUg== X-Received: by 2002:a05:6808:384a:b0:3f4:1738:f804 with SMTP id 5614622812f47-3f697afe34amr8586223b6e.4.1741639396306; Mon, 10 Mar 2025 13:43:16 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:14 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:06 -0500 Subject: [PATCH 3/5] iio: adc: ad4030: move setting mode to update_scan_mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-3-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Move calling ad4030_set_mode() from the buffer preenable callback to the update_scan_mode callback. This doesn't change any functionality but is more logical since setting the mode is a function of the scan mask and doesn't require an "undo" operation when the buffer is disabled. Signed-off-by: David Lechner Reviewed-by: Nuno S=C3=A1 --- drivers/iio/adc/ad4030.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index f24b46164a477f9b6b5c93ffeba0a335f7b3de5a..c2117c7a296f22aeeec6911c8a8= c74ed576296a0 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -868,6 +868,12 @@ static int ad4030_get_current_scan_type(const struct i= io_dev *indio_dev, return st->avg_log2 ? AD4030_SCAN_TYPE_AVG : AD4030_SCAN_TYPE_NORMAL; } =20 +static int ad4030_update_scan_mode(struct iio_dev *indio_dev, + const unsigned long *scan_mask) +{ + return ad4030_set_mode(indio_dev, *scan_mask); +} + static const struct iio_info ad4030_iio_info =3D { .read_avail =3D ad4030_read_avail, .read_raw =3D ad4030_read_raw, @@ -875,13 +881,9 @@ static const struct iio_info ad4030_iio_info =3D { .debugfs_reg_access =3D ad4030_reg_access, .read_label =3D ad4030_read_label, .get_current_scan_type =3D ad4030_get_current_scan_type, + .update_scan_mode =3D ad4030_update_scan_mode, }; =20 -static int ad4030_buffer_preenable(struct iio_dev *indio_dev) -{ - return ad4030_set_mode(indio_dev, *indio_dev->active_scan_mask); -} - static bool ad4030_validate_scan_mask(struct iio_dev *indio_dev, const unsigned long *scan_mask) { @@ -895,7 +897,6 @@ static bool ad4030_validate_scan_mask(struct iio_dev *i= ndio_dev, } =20 static const struct iio_buffer_setup_ops ad4030_buffer_setup_ops =3D { - .preenable =3D ad4030_buffer_preenable, .validate_scan_mask =3D ad4030_validate_scan_mask, }; =20 --=20 2.43.0 From nobody Mon Feb 9 10:51:38 2026 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FE261E0E0D for ; Mon, 10 Mar 2025 20:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639401; cv=none; b=Wr/C82XlcY9874w9vfQHqUA3EboxI0YNZsQU7tnJT3pkKHSnSY8n89+dCdkwHmuJYovuPqUz3SlIjasJzFD//IIngo+3QxLLNIytHlb3DfEFIZutq7OpmGp4GueQlEmRa0yBXodsLp4NQHZEjg2Cd57KzQN6AUoSr053yaN1cmA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639401; c=relaxed/simple; bh=Hsc2lTWIH/R8fBT/8ZsO+EBhdL1BLa9dPLrp8/P/Dew=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TBkWhFvGwhZEPBfXcpUZ0bbilWAq6cgN1UNooEegvDBs4U//wpuL9pDIoaIOPjh5Cz+0LRoOcaPqBw/IR2tEO9y63Z3KidUEzwgLZugJzMSHMPOGfdVkw3Q+esbFBn1TcShM64kCY+bAtR2RvJ2uaZ8nj+iz/rq1Ybyp3OB1WU4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=J9QOgRqt; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="J9QOgRqt" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3f417de5e25so2140390b6e.3 for ; Mon, 10 Mar 2025 13:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639397; x=1742244197; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fJTMB/Yj7akGz6eUAqBxkpGJJmFrHVTQNNCjxXAAAoM=; b=J9QOgRqtmnBKDpKg2GVjW8tgLoTqw5QGLM2A0OdSA+U2f/ycjdk7+4YGc7apmZVrDq 7pq5BnufK7wh4WGTlXo85NcMxFMxqxMTZBjDiAtOY3b42uSzIkzO2jFUSXCxhz03e4WD 1jiyJIg9o7T9UrdBZV4DZoE6zrK3f4GIvQTZnU6S0POfWZkeNw1q9uGDNJlZo0UliM1D EZkJ1HR0bfGqmirAexTk59rBUzcW95GJOAzHmecs74R4+gF2/z36ISQHrIANJnMaPGu4 nE4Af/38SFZrz0s0vBZi5tgPrDiHrekD6FLTFUtLSYGr/h0rXrnFIAdcKC5cRLX3fMYG 8vkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639397; x=1742244197; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fJTMB/Yj7akGz6eUAqBxkpGJJmFrHVTQNNCjxXAAAoM=; b=r1A8xAbzqIv8vEjdOPW+oc6C+v/QRKxlBmdKM85ITd+8sb/XXa8dZ4Bu+R4Yb/lq3s ij2q2LtMq5zjM8vzEIJgWv4OjGW3aK5/d64gqmTXDNTqRR8Ef5rXkLYOwzWc6rbCqE4H zUjDTbT2CRP9Yxr+SKCpAjMgJdZvNDipNt97V6ScCHPuEFJaHRuaNt9X0J6Q75kuJEG9 6hFuxIklQRd1i+gzkzZbziWmShdxpKOIyCtSfhWXtqFJ5YWsYYIjJB3UZeoRpOAepaL+ 1NNgr8AU+7YUdCW3iZ7IuuNWgKoA3+bGFWVUWlMYzi2MOqAE9LHBRbtuTiW1oY6U0ell xhcQ== X-Forwarded-Encrypted: i=1; AJvYcCXn+9a83tmkjIO+BkEPKYrRFDf9q/L+VxBOfbpgucSW3TYYGnmP1uohw85bsIFtY8oosksQlOEZAjePVtk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3ozmAwJgi9muj6zGxYVP78wGhf1pkalusZJsxNQk2vSznJsUb xyEKxSsPRM/S3KV5QSavLkMZ+00vv4mFUhKp79JwPJF1iypeyuYWehotcv6NmmAYNuruPFq8FPF Dh+4= X-Gm-Gg: ASbGnctYyjn1g6JBvjZASeNrV95tfQmPmARsrmiPx9G2JUBcRS4WJu9GtrQDq7spNES 5MuXxu/g5ppgMcB4hFzIWsfSajkeQywRiMtRp7TdFTZWQCjJ1uvzNTVrWfWgnxEktRLmLnoYtnO Hf62GH//XervnJU4ub9v0L2s1/7C4PFdPNO1RzHlkfI9REaROtMs8YRwABT5BJ7qBsPsQ+uLl8u D4+cT9hKpu4ohccmDjleTLg58PAnD7bSJuspMZwoaMEug8tlGbq65fmBLm1QMMxGrgmOc2iRo5s OrpUXQOYTnlqSIi5AZim8gN2tX0DF1VWI9sQsZO4yuNz2kZnsGTwbIpfZOJdVsBjKqRBnq8EXj6 /u4eQCmybKVs= X-Google-Smtp-Source: AGHT+IE/v8sgTJ1kpxF4TAz8lNU+kyH/TDaACDH4/rifKyICPd/DKFS6AuPRo2wZIJ/52GOdpWETkw== X-Received: by 2002:a05:6808:1894:b0:3f8:1df6:413 with SMTP id 5614622812f47-3f81df607d5mr3628760b6e.1.1741639397012; Mon, 10 Mar 2025 13:43:17 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:16 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:07 -0500 Subject: [PATCH 4/5] iio: adc: ad4030: don't store scan_type in state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-4-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Move getting the scan_type to ad4030_conversion(). Previously, we were getting the scan_type in two other places, then storing it in the state struct before using it in ad4030_conversion(). This was a bit fragile against potential future changes since it isn't obvious that anything that could potentially change the scan_type would need to also update the state struct. Also, the non-obviousness of this led to a redundant call to iio_get_current_scan_type() in ad4030_single_conversion() since it also calls ad4030_set_mode() which in turn calls ad4030_conversion(). To simplify things, just call iio_get_current_scan_type() in ad4030_conversion() where the returned struct is actually used and don't bother storing it in the state struct. Signed-off-by: David Lechner Reviewed-by: Nuno S=C3=A1 --- drivers/iio/adc/ad4030.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index c2117c7a296f22aeeec6911c8a8c74ed576296a0..54ad74b96c9f256a67848330f87= 5379edc828b0b 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -147,7 +147,6 @@ struct ad4030_state { struct spi_device *spi; struct regmap *regmap; const struct ad4030_chip_info *chip; - const struct iio_scan_type *current_scan_type; struct gpio_desc *cnv_gpio; int vref_uv; int vio_uv; @@ -562,11 +561,6 @@ static int ad4030_set_mode(struct iio_dev *indio_dev, = unsigned long mask) st->mode =3D AD4030_OUT_DATA_MD_DIFF; } =20 - st->current_scan_type =3D iio_get_current_scan_type(indio_dev, - st->chip->channels); - if (IS_ERR(st->current_scan_type)) - return PTR_ERR(st->current_scan_type); - return regmap_update_bits(st->regmap, AD4030_REG_MODES, AD4030_REG_MODES_MASK_OUT_DATA_MODE, st->mode); @@ -614,15 +608,20 @@ static void ad4030_extract_interleaved(u8 *src, u32 *= ch0, u32 *ch1) static int ad4030_conversion(struct iio_dev *indio_dev) { struct ad4030_state *st =3D iio_priv(indio_dev); - unsigned char diff_realbytes =3D - BITS_TO_BYTES(st->current_scan_type->realbits); - unsigned char diff_storagebytes =3D - BITS_TO_BYTES(st->current_scan_type->storagebits); + const struct iio_scan_type *scan_type; + unsigned char diff_realbytes, diff_storagebytes; unsigned int bytes_to_read; unsigned long cnv_nb =3D BIT(st->avg_log2); unsigned int i; int ret; =20 + scan_type =3D iio_get_current_scan_type(indio_dev, st->chip->channels); + if (IS_ERR(scan_type)) + return PTR_ERR(scan_type); + + diff_realbytes =3D BITS_TO_BYTES(scan_type->realbits); + diff_storagebytes =3D BITS_TO_BYTES(scan_type->storagebits); + /* Number of bytes for one differential channel */ bytes_to_read =3D diff_realbytes; /* Add one byte if we are using a differential + common byte mode */ @@ -673,11 +672,6 @@ static int ad4030_single_conversion(struct iio_dev *in= dio_dev, if (ret) return ret; =20 - st->current_scan_type =3D iio_get_current_scan_type(indio_dev, - st->chip->channels); - if (IS_ERR(st->current_scan_type)) - return PTR_ERR(st->current_scan_type); - ret =3D ad4030_conversion(indio_dev); if (ret) return ret; --=20 2.43.0 From nobody Mon Feb 9 10:51:38 2026 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEB941E104E for ; Mon, 10 Mar 2025 20:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639402; cv=none; b=HgW6GBsujw1nm8OEfyFsPaCWnPWXF7u/y/9PgXv/MN47rPKQy2bCmzrgL1V1Lu7aS7TcjS9ocOI2uP4kOGN8qteKiK/BFqh4K348xBGN+4JR9Ym5A5x+d+lSosVkd0waX2sKPNHhHAIilcwqFlsSEnCJRMNYs3o+YiPT2Kqmlg0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639402; c=relaxed/simple; bh=fy3YCEIhYXyfAtQCLfJyFl5dLmJOK0fZMwPIbAJdXh4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZdqbcVfn5xVwEniQDNkL3m7J51Vi5ODYGiDhS8nOKagtM44Z9o36GbjdwccR1gMSKvRn/L7/+GN7ISqthkCRliRw5bFlMb3pTkscUu/kQ5sgMoFZp3ByELYg80jLouDglHQQcVPU4e79BogudfuD1Tt1gOjostcTuiA5x3370do= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=gN4ONqFq; arc=none smtp.client-ip=209.85.161.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="gN4ONqFq" Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-601ad30bc0cso831812eaf.0 for ; Mon, 10 Mar 2025 13:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639400; x=1742244200; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J1AkfraDMLpclf5PdJvYaweOQN0fYlysTRqs642bX38=; b=gN4ONqFqXpCZXYZa1f04VYSTCT1ByZqOjVf0zFSLbuSlq8bhjV2K2w2u69iYnsuEpC E40T7+kIbg1abNLY6P5PL8KcjfNBbY149mT/3EY4ZyBrIaJgCsP8uzI1YS7I0mB84rey 1RvzP3jWSmh+alAbtP9WEYy+hnKSbmpQDvP3WQ0Rcx/2t/hxLMdMhsnZZcDfIpxbP/vl iUe7XZVrGv5WKHmgm4HBh9TRO2hr/xlnsv81eEAPzkyN5uODCTLxmxpiw3z95qR/v/Ld zZRYS7YB6pa7dEum1UEAhxdiH/WWVnOGnmKDiNf1hMHy2Q9uAfGraGynpGDYSPRcHXbc XRgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639400; x=1742244200; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J1AkfraDMLpclf5PdJvYaweOQN0fYlysTRqs642bX38=; b=DcSCbbgZjqN/cNs1On4wQmRGc73u2J/Nb0EpHXXH9Dxw9V888rHw5nyY7XmlzVqRol FqEUOYAcKSu085H1T3aOtIMUcNt75fKxWd2eTaTQUAEEnjdwSWnDGXYIU4LLaoAX7Rpb UPHGDD9/P/LmmewnNU3CsxmMKMzLtT3yzgxllKo0Ncz6GCA6op4bwyaBFAP0EEMLPoxG M79d2Um5hjsyznrBvaYuirtz1YlhINKAaLk5akI0aHJ+RrNv+2S+U6v8yLpeSzFysF14 cXvjGV4hekiwhN8QYAV5drVss56x8uWOVz6z4JeHv8xLagshcj5n6/nreumD+DtY9RF7 EtmA== X-Forwarded-Encrypted: i=1; AJvYcCV2C4w4NJoNM7kw7/ZEHX647fmyUIQnLhM5O5UtVk/+b2v/b/GPgQA/LJS4OuYrdwq/95L/U8nN1Qt9ioQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzpixiV+zT2dyDtEOBiqsnvGSNmc0zaudHAc+WfWEng0Hg2nuR4 S5d+dN22LVrDvACfuAKEvLf513dwR481MbWRbOSCimCYTRP4JDqfcJTAP/Mi6pc= X-Gm-Gg: ASbGnctIIj6WC41Y3+gkeg/tqXsLgDvWRP/Kcegm0aoUwmu88ac+Hfto45bzOQx3x0L EL+qAor+v0MgVxzgndSugP5iIyEhEY9INmvqEF/U2mE6tlJnoBfgSRKA3105Ad0E52w8dWwHV9b cyu0R01ZS/mKJ8ifMTgVXN4ZBGFvqSZUoMxJURS0f34EBJb8UjlhmH/6MD7WJ3Xt6/WpFC1hfOY HB+jIqn/tTywNJ2Ml0wq7HS+tV62icdSQkRDbhNDs0ILz99Y1GuX8PNiqJVf+XR8juYCCGjZkye 0hPx0VilVA+OnsIdr7vQGrCO99fNmcfV0kKim/+DucR6HjpPcyH/gVU3X/K25J9WxLIqtTUMWhz v X-Google-Smtp-Source: AGHT+IFjnN7xgqA5S6WxW9zh3aoenUjvYW1xuLxTRrObH49wacCSqx5z5F6Kj5S5n7YLILh9oajgoA== X-Received: by 2002:a05:6808:4448:b0:3eb:5a58:9b6b with SMTP id 5614622812f47-3fa2bdc5125mr556668b6e.11.1741639399765; Mon, 10 Mar 2025 13:43:19 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:18 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:08 -0500 Subject: [PATCH 5/5] iio: adc: ad4030: explain rearranging raw sample data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-5-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add a comment explaining why the raw sample data is rearranged in the in the ad4030_conversion() function. It is not so obvious from the code why this is done. Signed-off-by: David Lechner Reviewed-by: Nuno S=C3=A1 --- drivers/iio/adc/ad4030.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index 54ad74b96c9f256a67848330f875379edc828b0b..636f9f33e66af73d102722b984d= c1230e1417d1e 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -646,6 +646,12 @@ static int ad4030_conversion(struct iio_dev *indio_dev) &st->rx_data.dual.diff[0], &st->rx_data.dual.diff[1]); =20 + /* + * If no common mode voltage channel is enabled, we can use the raw + * data as is. Otherwise, we need to rearrange the data a bit to match + * the natural alignment of the IIO buffer. + */ + if (st->mode !=3D AD4030_OUT_DATA_MD_16_DIFF_8_COM && st->mode !=3D AD4030_OUT_DATA_MD_24_DIFF_8_COM) return 0; --=20 2.43.0