From nobody Sun Feb 8 14:10:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0CB926FD9E for ; Thu, 6 Mar 2025 18:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741285105; cv=none; b=b9LVOHRLz46LCmyWnFMDWU75lTwR+EXy7t+t9w7Ot8nzlgXFWlyudiRa9OW5T2kL9fz5pXe6LFl+hEFzskK+uMZOqREjSIafqS/CSXpXBcoEE/7eo0cDRa6d+rGx337cNBEk7cM/o96LadyKC1Nfq1BwatmN/K2lTJLSJLXO7g0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741285105; c=relaxed/simple; bh=fVbKN+wjjZ4pr7g4zo/O6vgNWA/C+DXje8FsI14Fxt8=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=oAZuvIHN6FIRvwW1+3yX8hTUG2xNodzQLaDi3D1LslIOwmHuTdwsB1Tsj6IiolD5CYsJERzTLkpdo/OwjBXZ9TmhBaWYXplovFECmTZB2VmXlJpwEqXW1uAetMhiqYziSzo+9RoFxpIGwsQ3WDpgj3ZFXrDaYj4iQ6XqXckGO6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D7A2C4CEEA; Thu, 6 Mar 2025 18:18:25 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98) (envelope-from ) id 1tqFne-00000000PJc-3o1T; Thu, 06 Mar 2025 13:18:26 -0500 Message-ID: <20250306181826.773344269@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 06 Mar 2025 13:18:10 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Tomas Glozar , John Kacur , Luis Goncalves , Gabriele Monaco Subject: [for-next][PATCH 09/10] tools/rv: Keep user LDFLAGS in build References: <20250306181801.485766945@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tomas Glozar rv, unlike rtla and perf, drops LDFLAGS supplied by the user and honors only EXTRA_LDFLAGS. This is inconsistent with both perf and rtla and can lead to all kinds of unexpected behavior. For example, on Fedora and RHEL, it causes rv to be build without PIE, unlike the aforementioned perf and rtla: $ file /usr/bin/{rv,rtla,perf} /usr/bin/rv: ELF 64-bit LSB executable, ... /usr/bin/rtla: ELF 64-bit LSB pie executable, ... /usr/bin/perf: ELF 64-bit LSB pie executable, ... Keep both LDFLAGS and EXTRA_LDFLAGS for the build. Cc: John Kacur Cc: Luis Goncalves Cc: Gabriele Monaco Link: https://lore.kernel.org/20250304142228.767658-1-tglozar@redhat.com Fixes: 012e4e77df73 ("tools/verification: Use tools/build makefiles on rv") Signed-off-by: Tomas Glozar Signed-off-by: Steven Rostedt (Google) --- tools/verification/rv/Makefile.rv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/verification/rv/Makefile.rv b/tools/verification/rv/Make= file.rv index 161baa29eb86..2497fb96c83d 100644 --- a/tools/verification/rv/Makefile.rv +++ b/tools/verification/rv/Makefile.rv @@ -27,7 +27,7 @@ endif =20 INCLUDE :=3D -Iinclude/ CFLAGS :=3D -g -DVERSION=3D\"$(VERSION)\" $(FOPTS) $(WOPTS) $(EXTRA_CFLAG= S) $(INCLUDE) -LDFLAGS :=3D -ggdb $(EXTRA_LDFLAGS) +LDFLAGS :=3D -ggdb $(LDFLAGS) $(EXTRA_LDFLAGS) =20 INSTALL :=3D install MKDIR :=3D mkdir --=20 2.47.2