From nobody Sun Feb 8 04:33:47 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F199155756 for ; Thu, 6 Mar 2025 14:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270252; cv=none; b=PEYm8zag7pFcjVZu8GT4deAe16iNsVwynDRhh2daBw/ap/AAWpKGmRrgIzV2oaO3ZZhM62mbicjm7I6UpwMIl2uwg3RGXX6G9MvzetE8lo9GYdfAKdiFdFoeBfsYU5MAwlTzIWhXJIcfim5/DnpjDz+HUiUAxicCFGHyDEsw0K0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270252; c=relaxed/simple; bh=xcnCm892YVWrZWbMShd7y4D6hSOZDUxmmffjBmaQwmw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FqF2eo+xtJuKKYEy5b/YDg3NuFgtAHmpj4VT72SIa2VUs+7G/qTnMZAwCcuxr5ZWFsZT7z0Djvm6vOimtwtY2kpv5pV3jMVPY3a0JWTHNrGaIQtEbZJNh8Eu6Tt1LcOEJckda3R7wNlVb4bv/bdESJLU830bStIqIwpuyE6uqCk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=But92eSO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="But92eSO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741270249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fsKE1JxR4r83PaPSyABYFCVJq9bgn0zVEf+tY5alCNY=; b=But92eSO1pRXl0/iiyyKPjy7fucwuvtZveWw5fL00Jv1dCMF6kohXlorWSWzSfNMBssiEB HEnSrukPXXk6+B2WvRWE/krgAwnISt1zA5mrB/Njf1HzqHZ/SCQwfpuLnQTE6UkgWfkVkN YZrmIAsQZX8E9rD9v456XYObpYit+B0= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-VhrRhwMdNMGSGWbzW1aKFQ-1; Thu, 06 Mar 2025 09:10:43 -0500 X-MC-Unique: VhrRhwMdNMGSGWbzW1aKFQ-1 X-Mimecast-MFC-AGG-ID: VhrRhwMdNMGSGWbzW1aKFQ_1741270243 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c3cca5d865so354687885a.1 for ; Thu, 06 Mar 2025 06:10:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741270241; x=1741875041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fsKE1JxR4r83PaPSyABYFCVJq9bgn0zVEf+tY5alCNY=; b=u/2Tt9q0oEHnbfZ7hqwUP7SPUB0Gcz97GKjKSK1yBH2owMfgNkF2Ug6PIS0UhD1EJf j0GZx5RwCr77rAYaoJSS/TZZ37T8vH1n9UjmxfIVIADVqlqtJw+rqK5XH7sQe4RSdaPd FPG+PVY0cS3wlWoaQ7xQvn/UrrRVQmotQLL0A0kn6aZMigAG96YCCo9D0IuEqjDtsKpD s38MnEc7RqcZ0NRSki7MC10QJfmLFjoB6lMZo2KmsreEBM7YPlUVVFyqU/TcLdLIQ2yr 8tBY71PVit63gWgfV5Sk/MTFx/9kjMSpamngr+/fpmz4kShHyv56G4NIh2D/1ORjZGXf PpUg== X-Gm-Message-State: AOJu0YxOdnzuvVGcdMeURBHOg9+gweas0iyOBcc9Az9KaDPRKFRtivdW LOZ/7BOVuCq8fDfkdk1Cu1OVeYN6OZ/tBGhuW57Bpxl32eKaLEyIhIQKyl2eXwZpb5339lqeDyx mrLyX36bpy4U8Y8xW20XDr7rEymQocwo/cMpnsvGPflpRD4JpZVaVDShjm6wCzpNLeWHWm2S/+L iCtz1tvRNo8J7Xmwldn3w14v7hJaDCU9E68NgmMhtt5IJVfLAZevs= X-Gm-Gg: ASbGnctVwV5eO7VeIQcl2wo6SxbNb6H3YupQ2LTtpbJHdJwJ1ljF6P9Gjb3za46a4UF qX5ImsOhU76zfB2r6uixNoKmL+mbq+Uf+knVONUB9I5HpJM/gVMuH7uQJci+BrFAOKjr2LNW47A WBT1DPsEKiF/ov2baUjw1WlgsrUnFsNJAH4rMcTZLAUuaVx+qoZ2hgh9QeVCJvuuaIFBUSiq7Rq OpHYEwYbPFiz1P3yoVkA0kOCyLsLTC12IWnWpTW9Y3DMgGrJk+vXSDH11HlP0s/XOHEjD32a2Lc D68haw41WQdVCTj8hmtkYF1cIeuhyl6h0lb7b9KvL6mv/ZYvHm83WyoLCiYxbSFHeCEJMKHCoUQ CtOJe X-Received: by 2002:a05:620a:1b96:b0:7b6:c324:d3a5 with SMTP id af79cd13be357-7c3e3a1c910mr432228785a.19.1741270241084; Thu, 06 Mar 2025 06:10:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHdyD8P5f8M2e9rNo87PDZMvWDzY4ue5a2vKgh31vwHmBPocp18qKgVS97FsSXL2hbSExV6Mg== X-Received: by 2002:a05:620a:1b96:b0:7b6:c324:d3a5 with SMTP id af79cd13be357-7c3e3a1c910mr432223185a.19.1741270240727; Thu, 06 Mar 2025 06:10:40 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb (host-89-240-117-139.as13285.net. [89.240.117.139]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c3e551119fsm93658985a.108.2025.03.06.06.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:10:37 -0800 (PST) From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v2 1/8] sched/deadline: Ignore special tasks when rebuilding domains Date: Thu, 6 Mar 2025 14:10:09 +0000 Message-ID: <20250306141016.268313-2-juri.lelli@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306141016.268313-1-juri.lelli@redhat.com> References: <20250306141016.268313-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SCHED_DEADLINE special tasks get a fake bandwidth that is only used to make sure sleeping and priority inheritance 'work', but it is ignored for runtime enforcement and admission control. Be consistent with it also when rebuilding root domains. Reported-by: Jon Hunter Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for = hotplug") Signed-off-by: Juri Lelli Tested-by: Jon Hunter Tested-by: Waiman Long --- kernel/sched/deadline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 38e4537790af..ab565a151355 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2956,7 +2956,7 @@ void dl_add_task_root_domain(struct task_struct *p) struct dl_bw *dl_b; =20 raw_spin_lock_irqsave(&p->pi_lock, rf.flags); - if (!dl_task(p)) { + if (!dl_task(p) || dl_entity_is_special(&p->dl)) { raw_spin_unlock_irqrestore(&p->pi_lock, rf.flags); return; } --=20 2.48.1 From nobody Sun Feb 8 04:33:47 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F26E154BE4 for ; Thu, 6 Mar 2025 14:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270261; cv=none; b=cz/aM4qKgX4/0qiEa8sfWQPR2EKhE+Y86e+BXJHCSTMzHACqS9m3u8OkT9m21LW8Wb6ltXchMfNXfXLxboWalkLa6jabdyUqRXVoDWDbhKd5UgbXxB3a7ox2wQcj0ow3htlCWCG4cOcp1hkgPY66UTnCsyuPgOGrUpwu+aSuc98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270261; c=relaxed/simple; bh=ii6TTr/Kfs0THoD/TLkO2GrRbGTYaTjd5DJR+PvNb0A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EKFK9wsBRWaxfb6vDFo5mCmXT3zViNq0lNnfoZyHI6ZEY2MsVB7i7PVe6iRXBoGeiKcGGJN9fkWXO90GU71Pron0sKjtd1cpCOZP8rQ+7slkjB5OoQz7TW58u1wwHZ1zndojVS4SNzH07qnJopmfMGf0BKUdS2/8Unc2dYzJ27w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dxa05Lfx; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dxa05Lfx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741270259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q7oYHBUSYWKBFrKzxLyJf0TyZmdB6vfG7gH9DRnS/aE=; b=dxa05LfxZZ2mLsvGhsj9ne+oq2RbVAh8MvfDsugSwf75qeBDbAEM3mKE3yCS3yd0xVLY+F 5Wu16ZBYLdOYLhrZIs2BlQ1kBTyucpJ5dko6n3aIrkQAz9iXu39Xew8Y0IS3pHBYCH4xe/ Wgmr1fy/mfXXTg31jVMpFukjqUtgy8I= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-6spfb9PqPVG4znaQjaf-Mg-1; Thu, 06 Mar 2025 09:10:53 -0500 X-MC-Unique: 6spfb9PqPVG4znaQjaf-Mg-1 X-Mimecast-MFC-AGG-ID: 6spfb9PqPVG4znaQjaf-Mg_1741270252 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c0922c5cfdso127764385a.3 for ; Thu, 06 Mar 2025 06:10:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741270250; x=1741875050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q7oYHBUSYWKBFrKzxLyJf0TyZmdB6vfG7gH9DRnS/aE=; b=Z3blYLmT/EhA6Ik20GNVXznPzT7Dl5+7g6PfeEZyAkgbmxXMqJUVMQGiOd+LUYyUSP 4NSy/SGBqr0TR5/gOQiWV1PqTN4NsNOlZHtO4KHDHgbnL0FA3LzQacJzgjGX1IBgP9h4 IQlpyJYiVeDyhV3/mMYFFmYKh0JcUpHMPMyxvn0DcFqHrvNYzCgAUnIAQmuwa5MUfuvE dLlnDdhXIgo2OWQZOF0F8aCCmYJ/KgrVB6NfGBMV2wA+iVC1Db68fc0jUoFoCtpLkevu 8paiTunDumRcu3/pFbNM/oDOdVAwKkW8+84kwVxOfHLHImAXxdlqE+Y1GV1MgZvkmvD2 PYwg== X-Gm-Message-State: AOJu0YyY8ghCdAiRsN6f12KkFi3Iz2U1QDvCGD5cRGJFCje+3IFclAL4 cIHYo7grvzWhjXSQ7QVYK7XI+Y42EZk9nsa1H6GwUOP7EYhQUZUh+gYtTK0yGYKDkt03iRPAa06 2XpLrv6YdU0+cAETmOJIAnOZJn5fXcNgC0zcvav7yxo5nVj3JvU7+eUAbONQo6Y6Cf+WrfWpUOU CVSOAL7LujQPeWR7bLu3GWdmi6HCcmPGlug2sV3m25bPw+WLNBJ+A= X-Gm-Gg: ASbGncuIUuP9gE4HJ+CTP64dQSPWc0EptOCoBc3MiQlV8Pss3y3uqVpn2f9WQ6KKLpR UwF7l2eB8g5WsVkabaCfXvMLQz/qZZScdrczQKmQsg6C5E7DbYNfpbxjThQ/8OCLyDOg9rXnH1o nqbijLkbCGRiCsUsvFby7dILFcr8SoDoSkb7OBtMcmLRRiTjY79CVWGmzsrzcK+1rZkGZYy6i/t zFa5RIygFZwROjdd53jNW9c1SXEKwqG3FT7KmHuMXkcsDasfLkSy0Em4hSmTBehxL+qKFNlJJcA unn45ckbzN5nsiFXQRhLYrjN61zTfMOZ4UDh8ukvhb8y81IHHD4jkMx45cE8eZ0KbznVuXzvevd Sx9DA X-Received: by 2002:a05:620a:4895:b0:7c0:c891:1e77 with SMTP id af79cd13be357-7c3d8e6f70bmr1208831785a.49.1741270250449; Thu, 06 Mar 2025 06:10:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEapf8emAvcjT0ZEquex2SbAKsDJBQjnPQ+wdDeLlrDgq2lW0+5MJIRR1jizGu94GkTg7cprg== X-Received: by 2002:a05:620a:4895:b0:7c0:c891:1e77 with SMTP id af79cd13be357-7c3d8e6f70bmr1208825085a.49.1741270250020; Thu, 06 Mar 2025 06:10:50 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb (host-89-240-117-139.as13285.net. [89.240.117.139]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c3e551119fsm93658985a.108.2025.03.06.06.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:10:44 -0800 (PST) From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v2 2/8] sched/topology: Wrappers for sched_domains_mutex Date: Thu, 6 Mar 2025 14:10:10 +0000 Message-ID: <20250306141016.268313-3-juri.lelli@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306141016.268313-1-juri.lelli@redhat.com> References: <20250306141016.268313-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create wrappers for sched_domains_mutex so that it can transparently be used on both CONFIG_SMP and !CONFIG_SMP, as some function will need to do. Reported-by: Jon Hunter Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for = hotplug") Signed-off-by: Juri Lelli Reviewed-by: Shrikanth Hegde Tested-by: Jon Hunter Tested-by: Waiman Long --- v1 -> v2: Remove wrappers for the !SMP case as all users are not defined either in that case --- include/linux/sched.h | 2 ++ kernel/cgroup/cpuset.c | 4 ++-- kernel/sched/core.c | 4 ++-- kernel/sched/debug.c | 8 ++++---- kernel/sched/topology.c | 12 ++++++++++-- 5 files changed, 20 insertions(+), 10 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 9632e3318e0d..d5f8c161d852 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -383,6 +383,8 @@ enum uclamp_id { extern struct root_domain def_root_domain; extern struct mutex sched_domains_mutex; #endif +extern void sched_domains_mutex_lock(void); +extern void sched_domains_mutex_unlock(void); =20 struct sched_param { int sched_priority; diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 0f910c828973..f87526edb2a4 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -994,10 +994,10 @@ static void partition_and_rebuild_sched_domains(int ndoms_new, cpumask_var_t doms_new[= ], struct sched_domain_attr *dattr_new) { - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); dl_rebuild_rd_accounting(); - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); } =20 /* diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 67189907214d..58593f4d09a1 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -8424,9 +8424,9 @@ void __init sched_init_smp(void) * CPU masks are stable and all blatant races in the below code cannot * happen. */ - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); sched_init_domains(cpu_active_mask); - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); =20 /* Move init over to a non-isolated CPU */ if (set_cpus_allowed_ptr(current, housekeeping_cpumask(HK_TYPE_DOMAIN)) <= 0) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index ef047add7f9e..a0893a483d35 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -292,7 +292,7 @@ static ssize_t sched_verbose_write(struct file *filp, c= onst char __user *ubuf, bool orig; =20 cpus_read_lock(); - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); =20 orig =3D sched_debug_verbose; result =3D debugfs_write_file_bool(filp, ubuf, cnt, ppos); @@ -304,7 +304,7 @@ static ssize_t sched_verbose_write(struct file *filp, c= onst char __user *ubuf, sd_dentry =3D NULL; } =20 - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); cpus_read_unlock(); =20 return result; @@ -515,9 +515,9 @@ static __init int sched_init_debug(void) debugfs_create_u32("migration_cost_ns", 0644, debugfs_sched, &sysctl_sche= d_migration_cost); debugfs_create_u32("nr_migrate", 0644, debugfs_sched, &sysctl_sched_nr_mi= grate); =20 - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); update_sched_domain_debugfs(); - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); #endif =20 #ifdef CONFIG_NUMA_BALANCING diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index c49aea8c1025..296ff2acfd32 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -6,6 +6,14 @@ #include =20 DEFINE_MUTEX(sched_domains_mutex); +void sched_domains_mutex_lock(void) +{ + mutex_lock(&sched_domains_mutex); +} +void sched_domains_mutex_unlock(void) +{ + mutex_unlock(&sched_domains_mutex); +} =20 /* Protected by sched_domains_mutex: */ static cpumask_var_t sched_domains_tmpmask; @@ -2791,7 +2799,7 @@ void partition_sched_domains_locked(int ndoms_new, cp= umask_var_t doms_new[], void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[], struct sched_domain_attr *dattr_new) { - mutex_lock(&sched_domains_mutex); + sched_domains_mutex_lock(); partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); - mutex_unlock(&sched_domains_mutex); + sched_domains_mutex_unlock(); } --=20 2.48.1 From nobody Sun Feb 8 04:33:47 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB015175D48 for ; Thu, 6 Mar 2025 14:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270277; cv=none; b=FXen2OaCewzrSraUVgZBx4zQ8mZjexgqEMjXZHwOMKxcLBIkg19A99q7u5gMbGHh7a+IBvBX2yEeztW8PCS9j8cmqxQo1ySAxsKbxFGrXLGx3kTRwNIiC3exVMXdfLkHKuQpB/mRbPvQw395qIwq0Qvu8/ka+NCakvI5Ua/nhco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270277; c=relaxed/simple; bh=LXp/fN9+DHszGyDRFM3VkrhJz2PUhILAWSbGRUnQ5+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=naQdmePGS0QErzRLrZEpYuOv7ofhUd/YIkia0/I077xTRCIgXRyGgAhBFycEH7Wx445syaMNOGqP6a2P1lBsrqaW5pOyYgW2V/ZG6U5D+GIN1CLog3wpcfdBpbFWTILf5xqv1EQBlL5tuwDABP3uUks9sCnEzYzhXMJeaWYgahs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M6S795in; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M6S795in" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741270274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X8MV1C1a2+zK79i0XF4CH5NW5o5w8GpCx5XUFIKxutk=; b=M6S795inSkYIwxHkuIDVaSTEQTdBA4fMKXbVA0thkYu+pqoJmEqZL59XEePpnzYVaChRkV 5wZfuvAhKZVOCX75y0HKQshEhpoFbxgNMsLdLqXfpIjyWjfOEj/LmUlXnYeFTv5Nb/9ETY WNQNCGzrlUEBwOKjbt01mBHyKABz9MI= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-Cp67a2yYNCWWTNWmttBYxQ-1; Thu, 06 Mar 2025 09:10:57 -0500 X-MC-Unique: Cp67a2yYNCWWTNWmttBYxQ-1 X-Mimecast-MFC-AGG-ID: Cp67a2yYNCWWTNWmttBYxQ_1741270257 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7bb849aa5fbso167045185a.0 for ; Thu, 06 Mar 2025 06:10:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741270255; x=1741875055; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X8MV1C1a2+zK79i0XF4CH5NW5o5w8GpCx5XUFIKxutk=; b=CCk7JWmxO2c/z7ZbF/bMZdsioiRyXFqIM7zvrdnmyM5vAKJiz5XQqmkyvE+kJHbyc2 Qc+L/9riItTUHXMWsneDAYRoXSK1aQj/HBXYZSHiJzqDzm2pk6Ut8eWunNNkytizAYXx gttPRnLb2HoA4PU2o8PpEwP/sN1pBCDGF5ME5q23ClE2eoQvvINcqQdlLAw9nbFBcSQP 1CUdYwy59y1E4fWtjarp8r9ps5bRvdUnPf+0f6+ml7B69zU0S5VamEpsI72vcjGfSbEI 63Y2ZnBZqlUPsgQFJAcTzJun+jfo9x+lr+mTE7xndRMw5y/UP/qNEp//FSEHvU+E2g/W okBA== X-Gm-Message-State: AOJu0YwjriK1Y0IbmtWhHQuQ407NkIkzsKYySGjz7XyRmvIqCk6/DMe/ cpnh+x6WOUMZMRRCEw8GF2fDlsMJnNuBJUu40yOAPMGbFXYKHhxnEufB3pUgvS9il3j2jB/W6TX jUg4J0VUdD9dOpTMRuHe8nlbZGNHrSNzjRU7gc5EE4vvOXzBWwmHa+PZlhGW6XRiHcA9LWk20FJ y+az3G2Db8Lpi/+4Mr5++gVbkp9pkpNnx38JG15Id/ZnyVxAnTlDQ= X-Gm-Gg: ASbGncs7x+26z09+A4x9j29LQnLFcwMU1R0DCPZk1/4js1amcZvvreeGC/ppf2SwTZR 9IVCOHTrJOieU/9EriBEhPjxQp04C/uGqY8hQPUtrhc5x9R6MoOfsQbe8ImdZK6pOcoqOLqffRF 1Kclm26Rc3rozaxopGjkpAMS88B4Srt8Emm+Ub9KF8Q8MCcUzhlxgwKqdYXt8kaK951pwScZ3lD 2D+mXYpaRZozNzQCxlf/OiYQl8L9DSPDPhxo1C1nI9Zn9AWF61XWeCRVJLpBu6E3ZiSHdBT1bOe v6GQ68xib/vOLgyANWW+cH6iiCrmcGz+tar4okkxwP5TCOoYnTpQbryJw+jmPBNNhOGItlss0Ih GQUxd X-Received: by 2002:a05:620a:2b96:b0:7c3:d79c:9c41 with SMTP id af79cd13be357-7c3d8e65e88mr1377359785a.25.1741270255258; Thu, 06 Mar 2025 06:10:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPm2LiZgeTapeQ0CT+twt6oVCSWpc9DToEkJrQ8VVx+C5dqhcQTY9tZvJ2sVdV7BX/IR1LFg== X-Received: by 2002:a05:620a:2b96:b0:7c3:d79c:9c41 with SMTP id af79cd13be357-7c3d8e65e88mr1377353685a.25.1741270254949; Thu, 06 Mar 2025 06:10:54 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb (host-89-240-117-139.as13285.net. [89.240.117.139]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c3e551119fsm93658985a.108.2025.03.06.06.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:10:52 -0800 (PST) From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v2 3/8] sched/deadline: Generalize unique visiting of root domains Date: Thu, 6 Mar 2025 14:10:11 +0000 Message-ID: <20250306141016.268313-4-juri.lelli@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306141016.268313-1-juri.lelli@redhat.com> References: <20250306141016.268313-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Bandwidth checks and updates that work on root domains currently employ a cookie mechanism for efficiency. This mechanism is very much tied to when root domains are first created and initialized. Generalize the cookie mechanism so that it can be used also later at runtime while updating root domains. Also, additionally guard it with sched_domains_mutex, since domains need to be stable while updating them (and it will be required for further dynamic changes). Reported-by: Jon Hunter Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for = hotplug") Signed-off-by: Juri Lelli Tested-by: Jon Hunter Tested-by: Waiman Long --- include/linux/sched/deadline.h | 3 +++ kernel/sched/deadline.c | 23 +++++++++++++---------- kernel/sched/rt.c | 2 ++ kernel/sched/sched.h | 2 +- kernel/sched/topology.c | 2 +- 5 files changed, 20 insertions(+), 12 deletions(-) diff --git a/include/linux/sched/deadline.h b/include/linux/sched/deadline.h index 3a912ab42bb5..6ec578600b24 100644 --- a/include/linux/sched/deadline.h +++ b/include/linux/sched/deadline.h @@ -37,4 +37,7 @@ extern void dl_clear_root_domain(struct root_domain *rd); =20 #endif /* CONFIG_SMP */ =20 +extern u64 dl_cookie; +extern bool dl_bw_visited(int cpu, u64 cookie); + #endif /* _LINUX_SCHED_DEADLINE_H */ diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index ab565a151355..339434271cba 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -166,14 +166,14 @@ static inline unsigned long dl_bw_capacity(int i) } } =20 -static inline bool dl_bw_visited(int cpu, u64 gen) +static inline bool dl_bw_visited(int cpu, u64 cookie) { struct root_domain *rd =3D cpu_rq(cpu)->rd; =20 - if (rd->visit_gen =3D=3D gen) + if (rd->visit_cookie =3D=3D cookie) return true; =20 - rd->visit_gen =3D gen; + rd->visit_cookie =3D cookie; return false; } =20 @@ -207,7 +207,7 @@ static inline unsigned long dl_bw_capacity(int i) return SCHED_CAPACITY_SCALE; } =20 -static inline bool dl_bw_visited(int cpu, u64 gen) +static inline bool dl_bw_visited(int cpu, u64 cookie) { return false; } @@ -3171,15 +3171,18 @@ DEFINE_SCHED_CLASS(dl) =3D { #endif }; =20 -/* Used for dl_bw check and update, used under sched_rt_handler()::mutex */ -static u64 dl_generation; +/* + * Used for dl_bw check and update, used under sched_rt_handler()::mutex a= nd + * sched_domains_mutex. + */ +u64 dl_cookie; =20 int sched_dl_global_validate(void) { u64 runtime =3D global_rt_runtime(); u64 period =3D global_rt_period(); u64 new_bw =3D to_ratio(period, runtime); - u64 gen =3D ++dl_generation; + u64 cookie =3D ++dl_cookie; struct dl_bw *dl_b; int cpu, cpus, ret =3D 0; unsigned long flags; @@ -3192,7 +3195,7 @@ int sched_dl_global_validate(void) for_each_possible_cpu(cpu) { rcu_read_lock_sched(); =20 - if (dl_bw_visited(cpu, gen)) + if (dl_bw_visited(cpu, cookie)) goto next; =20 dl_b =3D dl_bw_of(cpu); @@ -3229,7 +3232,7 @@ static void init_dl_rq_bw_ratio(struct dl_rq *dl_rq) void sched_dl_do_global(void) { u64 new_bw =3D -1; - u64 gen =3D ++dl_generation; + u64 cookie =3D ++dl_cookie; struct dl_bw *dl_b; int cpu; unsigned long flags; @@ -3240,7 +3243,7 @@ void sched_dl_do_global(void) for_each_possible_cpu(cpu) { rcu_read_lock_sched(); =20 - if (dl_bw_visited(cpu, gen)) { + if (dl_bw_visited(cpu, cookie)) { rcu_read_unlock_sched(); continue; } diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 4b8e33c615b1..8cebe71d2bb1 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2910,6 +2910,7 @@ static int sched_rt_handler(const struct ctl_table *t= able, int write, void *buff int ret; =20 mutex_lock(&mutex); + sched_domains_mutex_lock(); old_period =3D sysctl_sched_rt_period; old_runtime =3D sysctl_sched_rt_runtime; =20 @@ -2936,6 +2937,7 @@ static int sched_rt_handler(const struct ctl_table *t= able, int write, void *buff sysctl_sched_rt_period =3D old_period; sysctl_sched_rt_runtime =3D old_runtime; } + sched_domains_mutex_unlock(); mutex_unlock(&mutex); =20 return ret; diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index c8512a9fb022..c978abe38c07 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -998,7 +998,7 @@ struct root_domain { * Also, some corner cases, like 'wrap around' is dangerous, but given * that u64 is 'big enough'. So that shouldn't be a concern. */ - u64 visit_gen; + u64 visit_cookie; =20 #ifdef HAVE_RT_PUSH_IPI /* diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 296ff2acfd32..44093339761c 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -568,7 +568,7 @@ static int init_rootdomain(struct root_domain *rd) rd->rto_push_work =3D IRQ_WORK_INIT_HARD(rto_push_irq_work_func); #endif =20 - rd->visit_gen =3D 0; + rd->visit_cookie =3D 0; init_dl_bw(&rd->dl_bw); if (cpudl_init(&rd->cpudl) !=3D 0) goto free_rto_mask; --=20 2.48.1 From nobody Sun Feb 8 04:33:47 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20004155308 for ; Thu, 6 Mar 2025 14:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270274; cv=none; b=NJPaRWwKAgAoqNouy6xtd/RUdk6dXYVX7F24hUGoym2rdnCELoZOk0vFOhfWZ1746Jd6MnOOszdNWFwU1XOVxNAMVDg28o7YhE8cPt9CTt2ryYr/4p9jmNHNqXXk9t3RhmgVr0JUEMOhdbWxgKxJ0nolwqg212abtwiym2rFOn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270274; c=relaxed/simple; bh=72vgfzS/NoqpzjzSUDCO8wd5QQDPCLgcmhF+lVelQns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DmENOv9P/ikWJCWeCBL9GtqZz2MTpV9RXaczfcqExwj4h+BDXtdq0D+nLSTv31i9vOYMcgQNku/pIC1tF85SOd181/KOl6rE8FxIliWvf7LAVH36MzS9O8z9LRsLMNfF42ikfYMG3fAhZjop7XRD0H3N8ldDnPSvF+2ylXbwj/g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SOZn289U; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SOZn289U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741270272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dAqrxFos5baxMMm+58GJv+qJfXrJ7okyTkO5C9Q+Myk=; b=SOZn289UkmRhMI2o+vpqjTCnStpQIlsvdsPAaShLtwuA7lttgugQqxskM2tkLYo+ny+dkH CD6sFM5z2jwHEsfvk73X20WaLrxkTakB+i/PtroKK7M3mlr4B0MmmO6FBusOF74lZMNdum tnag+ntnoYu2FfSie7IFSlB5jR81gSk= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-xUJKRUB7Nq-868c0ziokpg-1; Thu, 06 Mar 2025 09:11:01 -0500 X-MC-Unique: xUJKRUB7Nq-868c0ziokpg-1 X-Mimecast-MFC-AGG-ID: xUJKRUB7Nq-868c0ziokpg_1741270260 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c3c8f8ab79so127831485a.2 for ; Thu, 06 Mar 2025 06:11:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741270260; x=1741875060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dAqrxFos5baxMMm+58GJv+qJfXrJ7okyTkO5C9Q+Myk=; b=X4yDBaV6Ih81f23zdD2fSZjFdE2iYuDiAaKDRYzZNTen2HQheg8ouJWQNuehr0gIfg 2JKJvLQUP3RN91iWQ6Ltt+H0n32WLw/v3R9QoFIK3NbiXqpfu+tL5Ft98Yu+ptjQO9JY /3EmXY0eWJRXvlZK48zKUGLrmXOjuoQ4d+ecDQUatFOaUOHrVtUImZQamIEjEkdyZ5UY 6+2IIVzyYAVGzUBjAy3zubnhn9ZtylAjUPT/quBQ8y467SltM3iUIElu65xPTBhteSWh ORwh7Hvl2uaej1Nmv8dNi+CpUilHBnzjaHWf58dPHvxB1K0QHInChoHlRdI7JKaaVrHq RrwA== X-Gm-Message-State: AOJu0Ywslj7lUV9VXtVDE/AubNzh1Qi4NulVMgdDPimzu68m5ZStg/Ua L1Y/TKbMi20BY3yGIueSvokJWMqencl4x/yUxkdhOUcrq3plsDRkU4xzvKqy8AWdUhUvvUNgjN/ bGMXFywf17PEs62qG7Z58l8SkYQT0qryZ1iohTPXi3etVZmMrOAkon1MLnivXCsYOoHYygpsqxf TvEQCXNwZt2RVwlqOIFzn2gmEpmIjv8svhxHLkf4rqyMFIUf1vMls= X-Gm-Gg: ASbGnctLkxUpNd2ffIgfsImz1NEhPh9zET6USbKgSJzP0AUP8oCpnt9Vukqw/z2Q7lG fzTdYJfDCGNJZe3BoUzTBfiDemp4D5/Cm7hUIfZLbU5bV4oBzaQE70vMYHIACMNL2dBUP83nPnr jq3K9cEW7lpsAHZVav6YzQzgXoyoN0DCfZs6+SXNVEKaGm3vqICHBNNr47wxYdZBnNB+NIzTtLA ZWOQxT4ydN/93VzXaOCB0cHX2m2rHJVQZFLdWj+gMGhR2wgJD07DoeOLC3zWs3Jt39NRTMFMpnh vS8gnuuVCwl7BvD4CkqTxF08zSYhThiFrBczhMKWF6tcfbGmwy0vn54s23ZR2sSoDbEP4htHcnZ UL4cr X-Received: by 2002:a05:620a:8085:b0:7c0:ac2a:ec2 with SMTP id af79cd13be357-7c3d8bd2980mr967718885a.2.1741270260275; Thu, 06 Mar 2025 06:11:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IG771ZEB7JVBEk+ccelxoIpVf1FwI0733+VbrstNGFZVGij6ibDc85fMk4i+GYeD/BM+tseog== X-Received: by 2002:a05:620a:8085:b0:7c0:ac2a:ec2 with SMTP id af79cd13be357-7c3d8bd2980mr967713185a.2.1741270259808; Thu, 06 Mar 2025 06:10:59 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb (host-89-240-117-139.as13285.net. [89.240.117.139]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c3e551119fsm93658985a.108.2025.03.06.06.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:10:57 -0800 (PST) From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v2 4/8] sched/deadline: Rebuild root domain accounting after every update Date: Thu, 6 Mar 2025 14:10:12 +0000 Message-ID: <20250306141016.268313-5-juri.lelli@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306141016.268313-1-juri.lelli@redhat.com> References: <20250306141016.268313-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rebuilding of root domains accounting information (total_bw) is currently broken on some cases, e.g. suspend/resume on aarch64. Problem is that the way we keep track of domain changes and try to add bandwidth back is convoluted and fragile. Fix it by simplify things by making sure bandwidth accounting is cleared and completely restored after root domains changes (after root domains are again stable). Reported-by: Jon Hunter Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for = hotplug") Signed-off-by: Juri Lelli Tested-by: Jon Hunter Tested-by: Waiman Long --- include/linux/sched/deadline.h | 4 ++++ include/linux/sched/topology.h | 2 ++ kernel/cgroup/cpuset.c | 16 +++++++++------- kernel/sched/deadline.c | 16 ++++++++++------ kernel/sched/topology.c | 1 + 5 files changed, 26 insertions(+), 13 deletions(-) diff --git a/include/linux/sched/deadline.h b/include/linux/sched/deadline.h index 6ec578600b24..a780068aa1a5 100644 --- a/include/linux/sched/deadline.h +++ b/include/linux/sched/deadline.h @@ -34,6 +34,10 @@ static inline bool dl_time_before(u64 a, u64 b) struct root_domain; extern void dl_add_task_root_domain(struct task_struct *p); extern void dl_clear_root_domain(struct root_domain *rd); +extern void dl_clear_root_domain_cpu(int cpu); + +extern u64 dl_cookie; +extern bool dl_bw_visited(int cpu, u64 gen); =20 #endif /* CONFIG_SMP */ =20 diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 7f3dbafe1817..1622232bd08b 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -166,6 +166,8 @@ static inline struct cpumask *sched_domain_span(struct = sched_domain *sd) return to_cpumask(sd->span); } =20 +extern void dl_rebuild_rd_accounting(void); + extern void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[], struct sched_domain_attr *dattr_new); diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index f87526edb2a4..f66b2aefdc04 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -954,10 +954,12 @@ static void dl_update_tasks_root_domain(struct cpuset= *cs) css_task_iter_end(&it); } =20 -static void dl_rebuild_rd_accounting(void) +void dl_rebuild_rd_accounting(void) { struct cpuset *cs =3D NULL; struct cgroup_subsys_state *pos_css; + int cpu; + u64 cookie =3D ++dl_cookie; =20 lockdep_assert_held(&cpuset_mutex); lockdep_assert_cpus_held(); @@ -965,11 +967,12 @@ static void dl_rebuild_rd_accounting(void) =20 rcu_read_lock(); =20 - /* - * Clear default root domain DL accounting, it will be computed again - * if a task belongs to it. - */ - dl_clear_root_domain(&def_root_domain); + for_each_possible_cpu(cpu) { + if (dl_bw_visited(cpu, cookie)) + continue; + + dl_clear_root_domain_cpu(cpu); + } =20 cpuset_for_each_descendant_pre(cs, pos_css, &top_cpuset) { =20 @@ -996,7 +999,6 @@ partition_and_rebuild_sched_domains(int ndoms_new, cpum= ask_var_t doms_new[], { sched_domains_mutex_lock(); partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); - dl_rebuild_rd_accounting(); sched_domains_mutex_unlock(); } =20 diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 339434271cba..17b040c92885 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -166,7 +166,7 @@ static inline unsigned long dl_bw_capacity(int i) } } =20 -static inline bool dl_bw_visited(int cpu, u64 cookie) +bool dl_bw_visited(int cpu, u64 cookie) { struct root_domain *rd =3D cpu_rq(cpu)->rd; =20 @@ -207,7 +207,7 @@ static inline unsigned long dl_bw_capacity(int i) return SCHED_CAPACITY_SCALE; } =20 -static inline bool dl_bw_visited(int cpu, u64 cookie) +bool dl_bw_visited(int cpu, u64 cookie) { return false; } @@ -2981,18 +2981,22 @@ void dl_clear_root_domain(struct root_domain *rd) rd->dl_bw.total_bw =3D 0; =20 /* - * dl_server bandwidth is only restored when CPUs are attached to root - * domains (after domains are created or CPUs moved back to the - * default root doamin). + * dl_servers are not tasks. Since dl_add_task_root_domanin ignores + * them, we need to account for them here explicitly. */ for_each_cpu(i, rd->span) { struct sched_dl_entity *dl_se =3D &cpu_rq(i)->fair_server; =20 if (dl_server(dl_se) && cpu_active(i)) - rd->dl_bw.total_bw +=3D dl_se->dl_bw; + __dl_add(&rd->dl_bw, dl_se->dl_bw, dl_bw_cpus(i)); } } =20 +void dl_clear_root_domain_cpu(int cpu) +{ + dl_clear_root_domain(cpu_rq(cpu)->rd); +} + #endif /* CONFIG_SMP */ =20 static void switched_from_dl(struct rq *rq, struct task_struct *p) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 44093339761c..363ad268a25b 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2791,6 +2791,7 @@ void partition_sched_domains_locked(int ndoms_new, cp= umask_var_t doms_new[], ndoms_cur =3D ndoms_new; =20 update_sched_domain_debugfs(); + dl_rebuild_rd_accounting(); } =20 /* --=20 2.48.1 From nobody Sun Feb 8 04:33:47 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0057F155308 for ; Thu, 6 Mar 2025 14:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270269; cv=none; b=oxnR4MfALCNZQWKLVWsAFFa4wNzDZsNgluo0OKPVCFxJ15Z0wsIOwALzPk1S7iU/w7C5D8eFKVmZG4PuqMrCA0NSE8RAorYgZ98Do42bQR66osDXBNbViHRnvqYC7fA+ygjdbAuSU2BIls1lYvSLn3c4Mmux/d2DOe9nTiBiVoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270269; c=relaxed/simple; bh=cplnuDUbV4SAYo0qglwwGQchejE9iVs1NjhsTNgnpto=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Id0Dadc3Qqut8iugJ0gAYPW+oGc1wjLLZRpoLna/14f50qlyl8Kd9tKl/rEuAKs7FKxZ7G3ab5L+4bUSWszyg1Xet7I5hVZ/Z6plq5orVLzhS5I/LNSCdVhKc3BTq6svf9tqlPS9ibD+vGlxbTMG4W5icqF0LaZjlMPCNGPDIGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dTzLXF9G; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dTzLXF9G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741270266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1kCUje7imDL8b0wxv56NHBIYICMyM6jGJVE452JEQ/Q=; b=dTzLXF9GHpk06HuCwmg1dm85ewtfsGAQQK5/Uf+cmEj5srQaqg5jVnAh4o70W0ICHMvMDE 31pTg0MQMe+zH8qCabMlERLtOIP/03Wem4HBRWIC4sXLQqd/xfBH5w0Aop3hOG5NQwdin2 LnIMAdI5JwMUtp9RxXhPVbtnouKRXM0= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-9nW-f7elNjWlaVCzXQoL4w-1; Thu, 06 Mar 2025 09:11:05 -0500 X-MC-Unique: 9nW-f7elNjWlaVCzXQoL4w-1 X-Mimecast-MFC-AGG-ID: 9nW-f7elNjWlaVCzXQoL4w_1741270265 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c0a89afcaaso147400785a.0 for ; Thu, 06 Mar 2025 06:11:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741270265; x=1741875065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1kCUje7imDL8b0wxv56NHBIYICMyM6jGJVE452JEQ/Q=; b=AtdIfhjzu0OpFcjy3GkSNCyjTvl7eq5sRcQKRJCDD7eX+fTCVCydJzju+fcHaXTicX k135rp/eIb2z4p4UMmYYFym1dtKDjk5WeLxRrPzgZ/qDype45Dz/IXKRHLpKDFFUnBmo 8tRIadQ3X1J9Db8BqCfX3BTWvFod1z3VOcG0DPTVWiXcYv29NUqclar4i+iY9tJvJ7Eh vuFi8GkzEJOZBun1uVzqN43ewGRkNa7p4SB0nUUc6bxfi/nU04hYHC+jpd03Xtg4khX6 Gpbhq4mpiMXUL4rl2N+Qr2GYq/To5enYe0Fyi8ZOJne7iTN88XjJWJ87MQcJJzw/BCbu +MVg== X-Gm-Message-State: AOJu0Yx3pk6pt4jybZc6i9YR0/c5kkm7qYfbVn7HyWiPAniCU4SWIrBE pkPmnYH+4ehg/kSXdOrGcz/qFMMAMVYOAz3yqZ/67Qrq+sK4cG6BQC3IOpf/A/bdOWloldtWYDc i56btQoRbi0tDVLmP5nImQ8Flr8cD2V5s1SN/jnMZxvUUGP3K3GqSz/e19uoIBc99SUk0tUKiHJ YqSIkvlRd7vZIrTvf6GImWYYz987DUTqUDk6a9y8GBYgHsViApcRA= X-Gm-Gg: ASbGnctvdUKViKgoZ9Fydh1KS5NpOyxwlYRBkv+1RC1k02hDSkufTb/r0GkLunEXaLF vki2zeBdqxNE/xclIj2TqPHLcnhYeg2OdCijWwTYNvbtc+n+lsceHYaH/rDkoPck2CZun59hmYz CV8W1WJ6D2Mf17R0FE42hBhP5QdKTVGQnzoEl7L3iUcB80t8/bAPWUhzlBX6CeKcn6OdW61BaCG ZN9CBpNl7rghzWcdb+RDZvess4uIhJy9BtH8AYHv2rg/lOJuGEgWQe1nzfLyLeeoWy/nwpLo4t+ 2Nl0KcV5W6QBi2xtCK1oH7mECBj+PerCg1OsyefkD5/tPQQj1IL07NA9YX7SGQskbzUF0v5sgWi 0deS7 X-Received: by 2002:a05:620a:6287:b0:7c0:9fab:bee with SMTP id af79cd13be357-7c3e39d9226mr498957285a.10.1741270265145; Thu, 06 Mar 2025 06:11:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyPK8COEy50ocv6BjRYPq5igje9OSBoylwKnvL6uU29QylUOyC7S13wYPM+quAriw2L+vvEw== X-Received: by 2002:a05:620a:6287:b0:7c0:9fab:bee with SMTP id af79cd13be357-7c3e39d9226mr498952285a.10.1741270264818; Thu, 06 Mar 2025 06:11:04 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb (host-89-240-117-139.as13285.net. [89.240.117.139]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c3e551119fsm93658985a.108.2025.03.06.06.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:11:02 -0800 (PST) From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter Subject: [PATCH v2 5/8] sched/topology: Remove redundant dl_clear_root_domain call Date: Thu, 6 Mar 2025 14:10:13 +0000 Message-ID: <20250306141016.268313-6-juri.lelli@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306141016.268313-1-juri.lelli@redhat.com> References: <20250306141016.268313-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We completely clean and restore root domains bandwidth accounting after every root domains change, so the dl_clear_root_domain() call in partition_sched_domains_locked() is redundant. Remove it. Signed-off-by: Juri Lelli Tested-by: Jon Hunter Tested-by: Waiman Long --- kernel/sched/topology.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 363ad268a25b..df2d94a57e84 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2720,21 +2720,8 @@ void partition_sched_domains_locked(int ndoms_new, c= pumask_var_t doms_new[], for (i =3D 0; i < ndoms_cur; i++) { for (j =3D 0; j < n && !new_topology; j++) { if (cpumask_equal(doms_cur[i], doms_new[j]) && - dattrs_equal(dattr_cur, i, dattr_new, j)) { - struct root_domain *rd; - - /* - * This domain won't be destroyed and as such - * its dl_bw->total_bw needs to be cleared. - * Tasks contribution will be then recomputed - * in function dl_update_tasks_root_domain(), - * dl_servers contribution in function - * dl_restore_server_root_domain(). - */ - rd =3D cpu_rq(cpumask_any(doms_cur[i]))->rd; - dl_clear_root_domain(rd); + dattrs_equal(dattr_cur, i, dattr_new, j)) goto match1; - } } /* No match - a current sched domain not in new doms_new[] */ detach_destroy_domains(doms_cur[i]); --=20 2.48.1 From nobody Sun Feb 8 04:33:47 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7AF416F0E8 for ; Thu, 6 Mar 2025 14:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270275; cv=none; b=DoUiKdGN0atzi7WRx+ArdSIMiklyJ9ivRd8B8kZsG/1JX2XgcoSkWlH5iJ3+5VARkTrsV3Tov9cS5GAyfzATwXrUSnkWtlIeCMWPkQTimo47r4c7TceuJnr2tHT3cmtXExy5V5DdxOS7zwUdWq3aUYAfoAQ05NzK7BnBY1OFJwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270275; c=relaxed/simple; bh=NJa7eHT7qOxfHmHXZjuOxjXW46aERM5gQU39+V2N3K4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cu5conpcLGRcptxd097X0jcogSracoyD8mZzzt6mA4ub88KyKE1iaE9mUQ7GjFSqfZPSHJ90kZStTKj1bAfO0Lq1d1cPVo6juAz7VgQbg3g3NGIS9DrrcaunuYzbhekEOqS8+cf6jW9yp/TAbtBz80tcN1hRH66O8l4/C0UjcOA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XR9d0zvo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XR9d0zvo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741270272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F4ZIFOGxzinJuVdUFfsoDQG+XLi9wvCEmtCRKGKKMyw=; b=XR9d0zvoauLVYJpJXTIlTMpRYAbUaFDAjO1RhJfw5ejzixNBUWNXVcfgfXKa9AZt5xk0t/ cuEtN+cqOO7sjF6hdQ5Vyyhy7xcALJPlVX2+vC+ZhmVSQtCmqKInlPUW95K8Fboq3FtKpe nVca3SQxHgxAsnLdUxRvhICMGivVqgY= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-70-tHegkQNcNkWElUAdByRULA-1; Thu, 06 Mar 2025 09:11:11 -0500 X-MC-Unique: tHegkQNcNkWElUAdByRULA-1 X-Mimecast-MFC-AGG-ID: tHegkQNcNkWElUAdByRULA_1741270271 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7bb849aa5fbso167106785a.0 for ; Thu, 06 Mar 2025 06:11:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741270270; x=1741875070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F4ZIFOGxzinJuVdUFfsoDQG+XLi9wvCEmtCRKGKKMyw=; b=Hqq0oeG6wxEPFwd1WLR7lIBz/aHq8f5Q2uUvo29+nFDfo9uKADD4iCBmumrCB63lOj LUrqDOxVDRNAOR8g0O6fFc0fdb29jNIu2P4ll096a58i8K1nn/tqyCYZo9+wv9dcViUI kgkfZXlmc78/hv6MXOLsSyMqn/re3VmmZA5oiCd8k6CSPTPUxWMxDPC5MOFESLvSXZ+I 6u4QRNz22oGPJB7G2KdpJQLroC6E6ktu0ZSLATWXlnGywUFfYsrUhyuQ/LOTvySmYEW3 MgZWUR0gt8BcNVrWz5QzguVgHkprmPzCzHaMK2h1r4W1lydTU6DHzln+BZ8Ydel98ObG n7TA== X-Gm-Message-State: AOJu0YzlClzCDRxIw04rRdDSw8kwP6hfnj/nDg9T/YNEEEWRqlcAdHXr 6pB6ifCTfLv0AHn05C9yFWgqzXjj7cPwGRcRONLoDEcXXWswki8dY3LYzWJp4hGImrHsqa5Xsxn Yg7ud9pKF6+F4Ck+3vT+ufRrOdk907tl0Gqwk+xZNKfXZxbQS3LjLOspVzd8qTnCwjyBBfBmQ2B uFHM2Lv9omc5LSheFLLChiRKvFjGF48hKt6z9sPjoSBNhxWGYidhQ= X-Gm-Gg: ASbGnctaALV4CoI0V4cCIyTbARLWnCuvNWWkFFMCrSgqimx+dD1aWvpxtz65FUV+Gc3 O7mEekflYxQlO7FnoofLGPerXKNofQzD5dWLNA5s+2Paz6CxzJsxvo1ferVn0kYMQdqMhJNhPy8 I9IHHkEprgWecHaC5T7sALlQbCzkIwLdvjsNrUfl4xjBlK5KVd6RxxMklaja0kET3cnSmd5n6Yl RzRiROXG82wzA9eWxxNoTQJPQXzJxum0XDfO/jXIw6vjvgH/NHzQfH17zhOLy9XsDXCP5La87gM bM5vrTGW2qUwnXff5uIGLdiqA1G7RdOCp6a/GrO9ovVjC9yM3WWMjhVDS8Q41JKl0jR/CuXy9dg Vsn73 X-Received: by 2002:a05:620a:2609:b0:7c0:7ff8:231a with SMTP id af79cd13be357-7c3d8e680dcmr998091385a.29.1741270269945; Thu, 06 Mar 2025 06:11:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGNuuK35swKKToS86/qmvAp2EsJ5mnlJsJBrB3uSoXbOl1vHKoKvdXC/bxVXHHhC8AQP5Gqw== X-Received: by 2002:a05:620a:2609:b0:7c0:7ff8:231a with SMTP id af79cd13be357-7c3d8e680dcmr998084685a.29.1741270269556; Thu, 06 Mar 2025 06:11:09 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb (host-89-240-117-139.as13285.net. [89.240.117.139]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c3e551119fsm93658985a.108.2025.03.06.06.11.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:11:07 -0800 (PST) From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter , Waiman Long Subject: [PATCH v2 6/8] cgroup/cpuset: Remove partition_and_rebuild_sched_domains Date: Thu, 6 Mar 2025 14:10:14 +0000 Message-ID: <20250306141016.268313-7-juri.lelli@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306141016.268313-1-juri.lelli@redhat.com> References: <20250306141016.268313-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" partition_and_rebuild_sched_domains() and partition_sched_domains() are now equivalent. Remove the former as a nice clean up. Suggested-by: Waiman Long Signed-off-by: Juri Lelli Reviewed-by: Shrikanth Hegde Reviewed-by: Waiman Long Tested-by: Jon Hunter Tested-by: Waiman Long --- kernel/cgroup/cpuset.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index f66b2aefdc04..7995cd58a01b 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -993,15 +993,6 @@ void dl_rebuild_rd_accounting(void) rcu_read_unlock(); } =20 -static void -partition_and_rebuild_sched_domains(int ndoms_new, cpumask_var_t doms_new[= ], - struct sched_domain_attr *dattr_new) -{ - sched_domains_mutex_lock(); - partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); - sched_domains_mutex_unlock(); -} - /* * Rebuild scheduler domains. * @@ -1063,7 +1054,7 @@ void rebuild_sched_domains_locked(void) ndoms =3D generate_sched_domains(&doms, &attr); =20 /* Have scheduler rebuild the domains */ - partition_and_rebuild_sched_domains(ndoms, doms, attr); + partition_sched_domains(ndoms, doms, attr); } #else /* !CONFIG_SMP */ void rebuild_sched_domains_locked(void) --=20 2.48.1 From nobody Sun Feb 8 04:33:47 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF30B1632F3 for ; Thu, 6 Mar 2025 14:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270280; cv=none; b=Op/aRLiN5CxsMbqzeOQCnNSlnPob8sOi845L2NcabybztE1KV9PqFz2/hZHvHJoJ0j/klcQ2raCbY96qEI8q0PDraue5O9nCEO2AvbDkOQ+W+0PB+69QVdy3X/YpTKncdScqBrnnnWOWfGn/rAqHPhexyQ6tufa9lFMqkYqbaBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270280; c=relaxed/simple; bh=4bDzmWrpSp48TdjMHbBbRLXbqjOIhNsg93No87cP2Y8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YFNtFr49QNa1gEaaQC86rPRxOCI7XtVPWZc5uYc+1PtEYJol6iDwscffk7Kxfk3R4K8Io5Tb4R3h1+bKTp75kvvP8LeyZFdYMrvyjsU1haiwHDeJyDUC1SvmjEiS+jm5unGkFXuseIjz2znWMrCDEEbSajBqgsBwzse0odbiBHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WwIbjDSh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WwIbjDSh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741270278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h7Wvt9bCpxa9m5FhJrFhPuBa/FfAz6U7Ug8gygH663s=; b=WwIbjDSh5KKNJBZAl3tou/t70pSlFkKx9wxip1l/Na+V8MZrlX7UsBaJSDRSksKuVbuR9w 8bga1NzrWS4lriw86ZLml15XH8HPicgUl27vMDmfV0dUBbUmki8RHm8/u7RRX9vmUz2Lka iBg8KwP0hBvdOk19CNGix+bUqP+XT0Q= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-EH6XF9fjPAysG1QMsQOeow-1; Thu, 06 Mar 2025 09:11:17 -0500 X-MC-Unique: EH6XF9fjPAysG1QMsQOeow-1 X-Mimecast-MFC-AGG-ID: EH6XF9fjPAysG1QMsQOeow_1741270276 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c3b78c7c4aso108863985a.1 for ; Thu, 06 Mar 2025 06:11:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741270274; x=1741875074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h7Wvt9bCpxa9m5FhJrFhPuBa/FfAz6U7Ug8gygH663s=; b=ibkeCA9UQyq34pnfBb7HAZY6QjyzONOp+ZRV/oL0IYNMi7RTUPEfnnfbvz94HI5kAm Lr8gs7Fot6/d8B2oYTFrs7Zvq6rKLgK3B99fUPu1+T0mZgZoqVG/CFbS1nVuhIgOMnZu LQJG29Yh8L6K1kGmaoXb6NoMUu4GpO2CaUOVLj/0LzrUEX9v9xquGuntT7ud+sGY7KOo XXFWsBZkd1v+gbYm8yJA0QOgQozk/eZOl9HjWG6V8Cg1DPRyzvkjn6WTBWKObXFFK6Jv P45ULw4AN33JcF+TeXKZiogIqfl+XA+FXfSyNPPeLid/tAmHPFhTc08gbMPYTz99Iqmo CYvw== X-Gm-Message-State: AOJu0YyUtSvR/Xzik83EzOWCNwFevZvkbER999/R5fW9djq9pvExJCh1 ovfG3AxfnvBxrDsUriTrYrO4YMmbqYDGjZ077p0VBnAbUPqJV9hFL2lTlrkFGTzH1K7UIEoxCDn 52DoCLe9xrBR6qKO21DeA41MI10tBmjK2EeqwnzyG/lD8IxjNOXSByIWk9ggtNczF/GQjBplv14 tjJWKm0mG5e+JDEUT02hgkNnF3P04CPkhSpjp+VsKx/5zeBKEVw6E= X-Gm-Gg: ASbGncv2Uszy3D6HUH9P/XbnSxc5O7CIR2DsWsHO8059pf1TbCmNiukgAWwXAU4btoC zfGaCDMbZt3IpVR94R6AW4qC3SzOYvZvjZN8q6ts8o8Ru7kQnnLmARqeSggS68W7svJD06BIMyU Kt7S9fUGzCfeYtc+0qTrqT5ELwUuRagC5WBF2NHatBDB00mpjZIXex96zlHQ/BK1zoRNAhYOBIa VQJg17Qgz+uSdku6Kw5WF+JISUwJSFPWQdI3BMCcwcG5hSsclk+V6qAqKdY8B0/5p2dFfeinzkp z7mgLNmswcwWpreUCqj+PU56bMMvvY1rGCPsE0tJyHNytzYFa60IJx9P0XK8ML10dzSYfmrxaNH 4chXc X-Received: by 2002:a05:620a:270e:b0:7c3:d282:d2e6 with SMTP id af79cd13be357-7c3d8e6f751mr1067267085a.29.1741270274209; Thu, 06 Mar 2025 06:11:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGavNGLBZnGI8W2c5FsjQ9kPKpnQpHBXP0YguyX+7DGXw75Fqnh1vbSyiUv74NnxEk0kp8WQ== X-Received: by 2002:a05:620a:270e:b0:7c3:d282:d2e6 with SMTP id af79cd13be357-7c3d8e6f751mr1067260585a.29.1741270273836; Thu, 06 Mar 2025 06:11:13 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb (host-89-240-117-139.as13285.net. [89.240.117.139]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c3e551119fsm93658985a.108.2025.03.06.06.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:11:12 -0800 (PST) From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter , Waiman Long Subject: [PATCH v2 7/8] sched/topology: Stop exposing partition_sched_domains_locked Date: Thu, 6 Mar 2025 14:10:15 +0000 Message-ID: <20250306141016.268313-8-juri.lelli@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306141016.268313-1-juri.lelli@redhat.com> References: <20250306141016.268313-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The are no callers of partition_sched_domains_locked() outside topology.c. Stop exposing such function. Suggested-by: Waiman Long Signed-off-by: Juri Lelli Tested-by: Jon Hunter Tested-by: Waiman Long --- include/linux/sched/topology.h | 10 ---------- kernel/sched/topology.c | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 1622232bd08b..96e69bfc3c8a 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -168,10 +168,6 @@ static inline struct cpumask *sched_domain_span(struct= sched_domain *sd) =20 extern void dl_rebuild_rd_accounting(void); =20 -extern void partition_sched_domains_locked(int ndoms_new, - cpumask_var_t doms_new[], - struct sched_domain_attr *dattr_new); - extern void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[= ], struct sched_domain_attr *dattr_new); =20 @@ -212,12 +208,6 @@ extern void __init set_sched_topology(struct sched_dom= ain_topology_level *tl); =20 struct sched_domain_attr; =20 -static inline void -partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[], - struct sched_domain_attr *dattr_new) -{ -} - static inline void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[], struct sched_domain_attr *dattr_new) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index df2d94a57e84..95bde793651c 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2688,7 +2688,7 @@ static int dattrs_equal(struct sched_domain_attr *cur= , int idx_cur, * * Call with hotplug lock and sched_domains_mutex held */ -void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[= ], +static void partition_sched_domains_locked(int ndoms_new, cpumask_var_t do= ms_new[], struct sched_domain_attr *dattr_new) { bool __maybe_unused has_eas =3D false; --=20 2.48.1 From nobody Sun Feb 8 04:33:47 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C97EE1519A5 for ; Thu, 6 Mar 2025 14:11:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270292; cv=none; b=MSgubZrYoK0ZSQ/+Hwcxr1sd/8nZEMugjUniAV4ySDPVXNdJzXsVMv9Y4Ilih8y9mp4tTz93L1gczgEl1QrOgqeRWGOkHa+iQvYOovWVGxAyoLTM55Et81eMlMxzuzws2mKXLLJ4DAYS+54KC9QVkBt1xGMLjx1GZoehCpbwOQk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741270292; c=relaxed/simple; bh=C/Cc8iMh5RhuOM/HCUsSqAmjstO6BDzi53uIK0zWZm0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gi4L7mxqOb3E2V/JzBxq3xCvUWdfEaX4o6WvDT9jVQDvPFXCURgJ85+BV7ggS6YaxvoamRshJG0NC1KFApH45tS/IqKdolMYXRraxGs2XIUj6yDUqz0ja3zXGqw37l/+wFn9kdtpbyF0FiOqagfrZx06IW+NQimluY9uwqxfHS0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fvNLdiCY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fvNLdiCY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741270290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R3M6FX8T2xhunhC57UXeJA8V9v8swCagmqmFMiwHiP0=; b=fvNLdiCYjWS4wF/8FLvaE+rya27Z6cKjQOFhw+FH9Jb2WyFHBJYpd9eO23b7J0eultbkJi Gzwl76xchIKZ5IJxv1V791ynDxT1MD0k7kRIaH+Uho5ap71bKX0Ut3ayobdRCJn859nuB6 xuI69BTHdQkyBiWVLiuSZ4aQspOWbX0= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-GOWGrsV6Nay7NRqpVKHikw-1; Thu, 06 Mar 2025 09:11:23 -0500 X-MC-Unique: GOWGrsV6Nay7NRqpVKHikw-1 X-Mimecast-MFC-AGG-ID: GOWGrsV6Nay7NRqpVKHikw_1741270283 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c0c1025adbso192026285a.1 for ; Thu, 06 Mar 2025 06:11:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741270279; x=1741875079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R3M6FX8T2xhunhC57UXeJA8V9v8swCagmqmFMiwHiP0=; b=f+3j41ShFsmpi60g4vNxF4do/UKHxJ0hjUetdX6hjImZgu9C/NYR7dyxqEOCV871+G yg8UMTTsyI7FwGnpFStaqPYL7v5plnpBb3EzDmbz4kIAJ/h7WuNTtJdX2zR3eIz8plys xpDKgJ8V01Qq7FxSkr6bOggr55+ObE16WWQaJewRISYjRDEfAq0DosVKgz6S5cpT+MxU /5Ym/k7GUc7Z59XB/pBTJoB90I8t5pGuXIy1Yy2aZrss5E8oM6B5hEPgORbDIQCHpsvE Z2DkSSHM/gRa8Dd4hDMC/d2iciIOLO8yoBbBBOrgdIMBdJ1WjStQrs9SZUEtXvikG1w6 6Q+Q== X-Gm-Message-State: AOJu0Ywv2B01W1qD5YtKSJKszMYgmM7B/0S6VkdkpZ4GAmntEc5JorBC c8ME9Dcoh4IBvSIJ6HX4zJLAn0y+Klg9svu5CgtqibC6Q4pVq/miSjJ013Cj6wNCSjLC4M6sMv4 PJFPlJVHlvmNhBfcRPraxylAJlVbCrj0Hxf5prDNLQB+5eIXEd1uzSEitnGY97emjHDHC1vAkC+ eP7alH+cVTDHl5SS92G+NWK2UBb430zj0KBMjiiqHlXIVKkl/kWOk= X-Gm-Gg: ASbGncvZ/PUzBNO3pf+mTuDj+7WNp7GemHUId4vQpE4+KLThFM067mhQm0roJ9OQlAB qH29HSpdc7L/8odw0tUBsALrqiVfuZi19yzMMYTZRYunw+lmhcnP/fOw6u7YoUZ1JtsGyaz9N8U Nbfpsn97IH3Pvhir00hQjqwqHItqgKvjRM3pb1XVuwXXNZfw7aBIuiJjmLcBDmqGYIa4OIvC2Zv f4ieZZVAPIXUuDXNmgldhA79Rfk4aZF3zb63bEE6kdl4jLZeHu7IS7nnxndfuQxOoEZnPykvjgS QgCM/hMq7rxtQA1BEiKdmMw0XVHTGQg5HLZp1B67E1Y75D49FIQOI88Q/pVYLXXSF/VuzSJj/8Z NqDoC X-Received: by 2002:a05:620a:8706:b0:7c3:c1df:149a with SMTP id af79cd13be357-7c3d8ec7c89mr1017804085a.46.1741270279380; Thu, 06 Mar 2025 06:11:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/+GQVLhu46C/Nyd3wxyeBeqf/hT0BoGgJcoGKjcpXDkjFLsMk+xW8l/y0hrRplEO9PyuSkg== X-Received: by 2002:a05:620a:8706:b0:7c3:c1df:149a with SMTP id af79cd13be357-7c3d8ec7c89mr1017797085a.46.1741270278850; Thu, 06 Mar 2025 06:11:18 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb (host-89-240-117-139.as13285.net. [89.240.117.139]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c3e551119fsm93658985a.108.2025.03.06.06.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:11:16 -0800 (PST) From: Juri Lelli To: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Qais Yousef , Sebastian Andrzej Siewior , Swapnil Sapkal , Shrikanth Hegde , Phil Auld , luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it, Jon Hunter , Waiman Long Subject: [PATCH v2 8/8] include/{topology,cpuset}: Move dl_rebuild_rd_accounting to cpuset.h Date: Thu, 6 Mar 2025 14:10:16 +0000 Message-ID: <20250306141016.268313-9-juri.lelli@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306141016.268313-1-juri.lelli@redhat.com> References: <20250306141016.268313-1-juri.lelli@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dl_rebuild_rd_accounting() is defined in cpuset.c, so it makes more sense to move related declarations to cpuset.h. Implement the move. Suggested-by: Waiman Long Signed-off-by: Juri Lelli Reviewed-by: Waiman Long Tested-by: Jon Hunter Tested-by: Waiman Long --- include/linux/cpuset.h | 5 +++++ include/linux/sched/topology.h | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h index 835e7b793f6a..c414daa7d503 100644 --- a/include/linux/cpuset.h +++ b/include/linux/cpuset.h @@ -125,6 +125,7 @@ static inline int cpuset_do_page_mem_spread(void) =20 extern bool current_cpuset_is_being_rebound(void); =20 +extern void dl_rebuild_rd_accounting(void); extern void rebuild_sched_domains(void); =20 extern void cpuset_print_current_mems_allowed(void); @@ -259,6 +260,10 @@ static inline bool current_cpuset_is_being_rebound(voi= d) return false; } =20 +static inline void dl_rebuild_rd_accounting(void) +{ +} + static inline void rebuild_sched_domains(void) { partition_sched_domains(1, NULL, NULL); diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 96e69bfc3c8a..51f7b8169515 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -166,8 +166,6 @@ static inline struct cpumask *sched_domain_span(struct = sched_domain *sd) return to_cpumask(sd->span); } =20 -extern void dl_rebuild_rd_accounting(void); - extern void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[= ], struct sched_domain_attr *dattr_new); =20 --=20 2.48.1