From nobody Wed Dec 17 00:19:28 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 513B61DC9AC; Thu, 6 Mar 2025 07:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247681; cv=none; b=rRAAjDUSa5oHr7Dmq5RK9MzRn6pjpYL15MHQ2kyuRWQYTBf+RHHp+qR7BJ4qa7xORxZ0Yn3lqAO3eNuyWcOF41Q6948OkYyYHQeOQwtvqVErfmHIKRkLrzSdzkfXdzcfO0fsbTXAMvA2Sm5AmUAKS5f6T02256nEqmo/KnERb2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247681; c=relaxed/simple; bh=KC3evV8+E4TMmXJsaHaV+xF+Zlwo3/sRwLFbnpUYLeo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ly8O6aDpEoVHRKoscY62tptgzByNArx+zJK2Om29iEj1WjpTA7ZpnOk3llw8/11Wc3rIuJAbQKKbxzxgd15qVByk69ps4gzzFjecAbe6jCNXCQwRYgKuhTdE6w79BHEx8BpN7ictuSXvsEMGzQhx2An9Ra/ux7aD3PSbet1oPNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=go+JhxrR; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="go+JhxrR" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-22356471820so4364015ad.0; Wed, 05 Mar 2025 23:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741247679; x=1741852479; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=go+JhxrRUJSSfrZ/FwhTFvySsf4+mxsyT/o1VHK/EcJ1MOrZBPjqwSAI7MABc88IY2 TE4HUW7T+UM9BQOb3SCg7uqFkpgJS3namxTtSVZprDEF5TZooHjqVu7ncNKKQYBjy2jk 8Xf51w69UaB9lxgUiqfu+JNkn4UpeZT5Hh0Mz5MProhHlhNv7srmGpCzrV8eF6s6Qudk BEoLXWIje89jGbFLOzLRY/geO81jEAElup0PmPxGo2y14+0kctcmq2AJM4QOmV7XhGrq IvZwWeqt0QzZbcXCFaVGv1TeKcqGy+jxJfAbpqhQUPx3F/kkBPQnyUEYvWqjgWesNtP5 NXZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741247679; x=1741852479; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=qZbGuD3O94SsApI9oKWsv6X17qM4R9xEHKQuB4PXOEVuAghUE93R7tMBmEH1vZNQO0 9GyiDoN+NDYpltO3KYMvQxT+CXkg1lQwCHVqTd/Gpu9hQRTzj9rX3CZMfFFhpg9WD5kf nVz32cpsTgg7Ej9jEAH5T98AkMmkuNaronw8f3bJvz/zhjlsfh0aZHHcCeFFcXEyP2Rh zcYp6yFROLmZ+v7hZvQ8IBQdLpRoAxqVQnWsjQY9il7b/xYSuHAlHkTTJZih33RCi/jb vepklqsrmbHKZaDC8athUbb28LZSvN0fvhMy6n8PmnD7VTXxBZHQMgO7TF46LG/D2LcR +0lQ== X-Forwarded-Encrypted: i=1; AJvYcCVUHS0aqbDr5U7JfyqIIv354Ie/2bZBOKEMJk4UucuowXws+eOy/EtaCc1xooVGUIW4rJdA+JNzMEct@vger.kernel.org X-Gm-Message-State: AOJu0YxzW4BRstwQb4M54walSwRfYmxe2UBy7P66NZ1+AXofAHiQIg5M DO3YbCD4VoQK+15FEjsjGkIrGK+fdZCK/O6XZecHIx4ATQPT0jg/ X-Gm-Gg: ASbGnctSriaSPmSeFkl3o8XGSqCY/ZfRZDtAgUUL6SihOhH46T+FFpAAxaFww7B4dfL zTL2shBGRW8WpsxZVYm8NTIWnMUCiE9/Lo4Pkbs7zYziMqQPnnD/fuRxhhb6Z4+ZaBLcgQh/Ken 1POs7JFBVl2g4bJIKQvHVZKEzH3BKu737bwFMlUP6bACsB3jCA/aQY+VZGH8W0ynvdmB9l8d49S p3Jxy2Euu3llX/dxTyeEi1oog6MfLsjBL0cHWxg0quwW0CiZwz/Z7vn9bI5P2+bB5VtEzaiN4VK uTk/Vx0CI1cyBlWjtI8vnpsT/fnBig3lVgiFFdTdUMj1mBQ51tD6p30= X-Google-Smtp-Source: AGHT+IFlRA1ASdPJHVciwnsTAixFnm9+f7L02Rxbp3y0Ul030LzW40hSSZUseZYzvsv3j9+MbuLuQA== X-Received: by 2002:a17:903:230a:b0:220:ca39:d453 with SMTP id d9443c01a7336-223f1c81e80mr96320715ad.17.1741247679382; Wed, 05 Mar 2025 23:54:39 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22410aa448dsm6085485ad.210.2025.03.05.23.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 23:54:38 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v7 1/5] dt-bindings: i3c: silvaco: Add npcm845 compatible string Date: Thu, 6 Mar 2025 15:54:25 +0800 Message-Id: <20250306075429.2265183-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250306075429.2265183-1-yschu@nuvoton.com> References: <20250306075429.2265183-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Need to add a new compatible string to distinguish between different hardware versions. Reviewed-by: Frank Li Acked-by: Krzysztof Kozlowski Signed-off-by: Stanley Chu --- Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml = b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml index c56ff77677f1..4fbdcdac0aee 100644 --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml @@ -14,7 +14,9 @@ allOf: =20 properties: compatible: - const: silvaco,i3c-master-v1 + enum: + - nuvoton,npcm845-i3c + - silvaco,i3c-master-v1 =20 reg: maxItems: 1 --=20 2.34.1 From nobody Wed Dec 17 00:19:28 2025 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F12F1F8736; Thu, 6 Mar 2025 07:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247684; cv=none; b=YtIynk0Eu0vnr6ceV42cMY3AT4sprRSMxAkPOfay5cSGWIuWGlDZHdmQq1XxDilbqDBJ5E7I8b4rU79QD0CRcHkmxeR0lnsxoWIyx1IZNUZn0I9wbxRW4shVCH8eDO0G4zDYPEquyy6Ok9e6v5Ql3vaLVjVzOkXcX1gwMm9zE48= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247684; c=relaxed/simple; bh=o2lq1LUKE9RuAg/hZz1ZlOwXz2aoqXlZrwNR0bKCDAQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fUd+TWV15KeKzbPy3ISk6ITQxetwrIAZjdRcsVEFLRu75RTV/O1aK4UjqSBq1ODLhNNZVKO+8l7fOuf6g+xxTAPLwjZ6E/MPeSiCEM3wBREtdEOeMVENj0Jz96Yus77Fpr8k76fBrzqcFCD9mn7thz2U013DDzJwBX8+RQ2ACcU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YVNv+YRh; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YVNv+YRh" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-22337bc9ac3so5811075ad.1; Wed, 05 Mar 2025 23:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741247682; x=1741852482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8z+sL0RW4cJTOyML1J6fde/KORBWPqtZnRc7ageiDm8=; b=YVNv+YRhA2yX8kD+dMKwQoVdaqzymCCZTZ4WOmF/IBNuxNhtFNIHIGCbUBKCZRAOku ZeTSOItG7tejyJ6Zj5DSBfKlRBAteEO6h6eDKdBecriz2dZPtHfQug9+CBLpl8rGflQv boTLax/NUQa00qcsw3PoWprujNDyOlPOQlGlitZXprI3838MlqllDEEQnVt6szAMvItR Ww7ZBRSGyScrZKasS2RdbEyZBXKWd0/Tcmf+0HikeJaJGaE8gvjo1cK+l1YidloFZxK+ wzK+QiXuPs1rfoZE32fFJpLAcDe3epqK08lDNIuIyRl3nzJW2rDvSeuXk35yPDDMWS3A us9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741247682; x=1741852482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8z+sL0RW4cJTOyML1J6fde/KORBWPqtZnRc7ageiDm8=; b=ayZG5MmtRH6EGpB3mxYoHwhE5oa8iMtZULRFX89K5QoGyGt/9qA33c8jsTKKVBd3Mo rkF3BaJz48i5FrpUL+QAbNqrG01ZXDAk3k5wu3I8LDYSqEkNWuc2ANeAyKpqfG9DJo/B 0fwdRONCajmsX7XMrUmIiR1uBolCOlsy0ej3uOyhPgDJtG2ORWjVRNedlgQSP1sRPUgk OqVMvSdz+ipetSNtb1s6YC4T/mONLvNVfaF8ZuqpAd/2vFcHMG9Nxx5P/dWTGGyDVGLI dpUtWtH4jG0UhSvdOvcKDY73WZmZ1xcv2KFMsp3AxiLWiTPpyM+zPFQk+icxQAC+F8i9 o1nA== X-Forwarded-Encrypted: i=1; AJvYcCU5K1JaTZ4H9N9CT9Sg+k4i5pkAQBVEqrhhzsLC8+n8JVgvyjMqisjMfMBk3oQgdcYRQbW1FYz2q9dM@vger.kernel.org X-Gm-Message-State: AOJu0YwaYZ0eBw7tnVZeK9+mS1Tnq+iod9743pEahpU41EC26fVV9X+3 DWZbektoOFLwTkd8TR3rqGnVRqSbm0Uo8ZE+aa4Ppaydi+Ahy4As X-Gm-Gg: ASbGncv/4au3pE/5E/QGvX7ljG+31mJznOp3XGwfJSJAfemSPTxuRpD1pzI06/grK6v sjOOjvNxk7dZrpIEg3oh6+V2cC7waD5ZDVqQmtZzc3Wqig2Ao+vFC1iFik/rYl3APjlWFDn/6f2 azzlYUf/stRScl+3pv+qZ4nsmzqmYh0Gjla/vZ9V3v6isNJunoGWeVTqjjJaeTcQAYHVcyWWkaZ TctaI3xre1pfCakoqQw0WAyF0lvlLij71WzCz74Ce1MyNp+97Bm3QglGX20YyTd1JKluDXr16iK uRDjNU2ui5DygeFp6KS7oYMY08t7p3yHx+THFDTC4zl3KlHN0JKjarI= X-Google-Smtp-Source: AGHT+IGXAIOce42vV0eof1Rl6r+EywEWrktnOVXaG5lMZQPu7G/rBfveA9yLXalq4mL2qutxXfLdqg== X-Received: by 2002:a17:903:230e:b0:223:3396:15e8 with SMTP id d9443c01a7336-223f1c81638mr107329295ad.22.1741247682439; Wed, 05 Mar 2025 23:54:42 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22410aa448dsm6085485ad.210.2025.03.05.23.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 23:54:42 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v7 2/5] i3c: master: svc: Add support for Nuvoton npcm845 i3c Date: Thu, 6 Mar 2025 15:54:26 +0800 Message-Id: <20250306075429.2265183-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250306075429.2265183-1-yschu@nuvoton.com> References: <20250306075429.2265183-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu Nuvoton npcm845 SoC uses an older IP version, which has specific hardware issues that need to be addressed with a different compatible string. Add driver data for different compatible strings to define platform specific quirks. Add compatible string for npcm845 to define its own driver data. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202503061400.GGr64rkR-lkp@int= el.com/ Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index d6057d8c7dec..40269b692aa8 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -158,6 +158,10 @@ struct svc_i3c_regs_save { u32 mdynaddr; }; =20 +struct svc_i3c_drvdata { + u32 quirks; +}; + /** * struct svc_i3c_master - Silvaco I3C Master structure * @base: I3C master controller @@ -183,6 +187,7 @@ struct svc_i3c_regs_save { * @ibi.tbq_slot: To be queued IBI slot * @ibi.lock: IBI lock * @lock: Transfer lock, protect between IBI work thread and callbacks fro= m master + * @drvdata: Driver data * @enabled_events: Bit masks for enable events (IBI, HotJoin). * @mctrl_config: Configuration value in SVC_I3C_MCTRL for setting speed b= ack. */ @@ -214,6 +219,7 @@ struct svc_i3c_master { spinlock_t lock; } ibi; struct mutex lock; + const struct svc_i3c_drvdata *drvdata; u32 enabled_events; u32 mctrl_config; }; @@ -1817,6 +1823,10 @@ static int svc_i3c_master_probe(struct platform_devi= ce *pdev) if (!master) return -ENOMEM; =20 + master->drvdata =3D of_device_get_match_data(dev); + if (!master->drvdata) + return -EINVAL; + master->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(master->regs)) return PTR_ERR(master->regs); @@ -1958,8 +1968,13 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { svc_i3c_runtime_resume, NULL) }; =20 +static const struct svc_i3c_drvdata npcm845_drvdata =3D {}; + +static const struct svc_i3c_drvdata svc_default_drvdata =3D {}; + static const struct of_device_id svc_i3c_master_of_match_tbl[] =3D { - { .compatible =3D "silvaco,i3c-master-v1"}, + { .compatible =3D "nuvoton,npcm845-i3c", .data =3D &npcm845_drvdata }, + { .compatible =3D "silvaco,i3c-master-v1", .data =3D &svc_default_drvdata= }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl); --=20 2.34.1 From nobody Wed Dec 17 00:19:28 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662451FC7FC; Thu, 6 Mar 2025 07:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247688; cv=none; b=KvjXmaKVZD1E55gmzkA5ARG6A416OAzb5YDFIQYFxV/0wluJnsszJJNQDAKPYEjul2/QsHQCUo8yolXz2ll5roosQ3I/f8qBIP/0/xMXYCq6fQtg0jpnJL3TyHxthWV0S1x2vGK+SGYs4TeKFuteBDmYSx63Wn4fpQi7VuudwbY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247688; c=relaxed/simple; bh=BGdtgGjecU9Y9WjgrE1NhOVjSWJFz3oecpoqxxs/E08=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Mqt+psYhR9cTztw/iOHGXGjXj/69ufFqYvXE5ciqSqmz3zqHRbA/j9hHHU+Od2RQNlOXGgxVevTx8sIaLERgVk3xlwH2ZmqC3xOIqoaMTwdJjjo2I5VNFrhZlgp6LWbqYYBnekLEZklhbP3kSFzFZEQj2O9uDXa1R9RWTXrhS9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PwY36xIL; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PwY36xIL" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2234e5347e2so4976605ad.1; Wed, 05 Mar 2025 23:54:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741247685; x=1741852485; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YEZQpIQJFkHZeLv9/Dqh07QChyI7uFyuz8YE5XUUtDc=; b=PwY36xILoh3vLj3BZnyin25OCuHS66AProq84e7HMMvr6/pAdIUHs9p/7nC+lY98DZ UssiJ/+ihfiPjWZXXYKFtpxsTW0EjsW38j5QxrApAojByIB4bNOyCFCoiwHJEuFCs94Y +xIf66r5vG9OR453xF5NAWg5U6Vcq6R/CyFUR3cuyq06oc0pVT6rUD9HtpzPFM9vk0gL N6qzk//ptgK0QJ9cHLzoQx9LLp5e6EJ9QoWFaT019Wwp/NW4s68OTcA16vKG/GCxo4ne Azp5GSsrKmC4I50g1df/NP3PKLyBBgr0vjqeGvPQ9mAFIRJ5LgXVt4HdgGxshFtBJIZh 5cnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741247685; x=1741852485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YEZQpIQJFkHZeLv9/Dqh07QChyI7uFyuz8YE5XUUtDc=; b=nHsDYn+QQHdD3xeS4brszQaCXAVqyrSf4mG81xJSEFVeRv6zjCqXTDCrEob6POQab1 Qw18c3vO8sGglxqurFrm1R8DAc8s/wUe+hGqL0uM3KGsi+u1Xf8Uak5mQ7tTyjI8o6Ql sJac/d/96D5O0rj6iKCX6wa7orpw4rTJ5Y0g4OCdCT2z9/XJSw/UoLy9Pp8+b15D1z2q pNQBfVhyFpLtZOu66t25sMlTNe7Z5fCtQ665oYTgM9O27HsbNLf+g6/GfZsmzEa0+f+L 9uPcFIvWFqJcd0f4gy83+hHkR0w8sdJo+li1ohsQ/z5fA7QZAsmO/UKPPQyZtDEjvvQs CB4A== X-Forwarded-Encrypted: i=1; AJvYcCWGeBRur3V0t10IPbO3301qWvLUbtrcpdWlOh1oJJX7KNmnLc5NoR4X2+xRQOpw9uDaboZDSFtuynzr@vger.kernel.org X-Gm-Message-State: AOJu0Yx7cWucFYlPko2c05TSHfr5hgXUPRAJ1cGy449X+XwJRPLL0CGP ocY9n6o/FapXRUOIwI43Dt6R9M3O3UnjrQAGGAedrRcOj+pamSEy X-Gm-Gg: ASbGncvihuQVHfObwapFipFCcNPJQNJRraO1FUDusMpfMBQGU/MW4yD4CMNRxBjDSp9 c5OyrqLiHdYh60FXpFRGNH+guNlGRgAWODdkxnokibSSAT5aGODNEsOQPKbEZ6n+f/pwoQFOycD wsWGOdLwReRRCHg//PShAR3h+QSA2j4I6aSzSd7s3IdBTgIZpEftIIjRZ09wUR3ZyOMcX2KYWHO 9lTxxb7uNAEfDOKUnSiSphBmGt9HBmyzC8dYKlt2aazPCRw+hGbb1Egi3ukOZaZJoOlnsdXgwJz gKeN4XVU211OhKqKJ2XU5ezGZabpOMorjRbGH1gEF+XmTrR1FH0Cww8= X-Google-Smtp-Source: AGHT+IFcL0+B3Hx4sm17S7HaaAzS7pgvJFy07ZpdfXIMFxdeHGAgASq3H6x7BYZUzd2tuu/iirTDGQ== X-Received: by 2002:a17:902:e950:b0:224:11fc:40c0 with SMTP id d9443c01a7336-22411fc412fmr15782245ad.11.1741247685528; Wed, 05 Mar 2025 23:54:45 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22410aa448dsm6085485ad.210.2025.03.05.23.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 23:54:45 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v7 3/5] i3c: master: svc: Fix npcm845 FIFO empty issue Date: Thu, 6 Mar 2025 15:54:27 +0800 Message-Id: <20250306075429.2265183-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250306075429.2265183-1-yschu@nuvoton.com> References: <20250306075429.2265183-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu I3C HW stalls the write transfer if the transmit FIFO becomes empty, when new data is written to FIFO, I3C HW resumes the transfer but the first transmitted data bit may have the wrong value. Fill the FIFO in advance to prevent FIFO from becoming empty. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 71 +++++++++++++++++++++++++---- 1 file changed, 61 insertions(+), 10 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 40269b692aa8..cba89a685e13 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -113,6 +113,7 @@ #define SVC_I3C_MWDATAHE 0x0BC #define SVC_I3C_MRDATAB 0x0C0 #define SVC_I3C_MRDATAH 0x0C8 +#define SVC_I3C_MWDATAB1 0x0CC #define SVC_I3C_MWMSG_SDR 0x0D0 #define SVC_I3C_MRMSG_SDR 0x0D4 #define SVC_I3C_MWMSG_DDR 0x0D8 @@ -133,6 +134,16 @@ #define SVC_I3C_EVENT_IBI GENMASK(7, 0) #define SVC_I3C_EVENT_HOTJOIN BIT(31) =20 +/* + * SVC_I3C_QUIRK_FIFO_EMPTY: + * I3C HW stalls the write transfer if the transmit FIFO becomes empty, + * when new data is written to FIFO, I3C HW resumes the transfer but + * the first transmitted data bit may have the wrong value. + * Workaround: + * Fill the FIFO in advance to prevent FIFO from becoming empty. + */ +#define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) + struct svc_i3c_cmd { u8 addr; bool rnw; @@ -236,6 +247,11 @@ struct svc_i3c_i2c_dev_data { struct i3c_generic_ibi_pool *ibi_pool; }; =20 +static inline bool svc_has_quirk(struct svc_i3c_master *master, u32 quirk) +{ + return (master->drvdata->quirks & quirk); +} + static inline bool is_events_enabled(struct svc_i3c_master *master, u32 ma= sk) { return !!(master->enabled_events & mask); @@ -894,7 +910,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_= master *master, u8 *addrs, unsigned int *count) { u64 prov_id[SVC_I3C_MAX_DEVS] =3D {}, nacking_prov_id =3D 0; - unsigned int dev_nb =3D 0, last_addr =3D 0; + unsigned int dev_nb =3D 0, last_addr =3D 0, dyn_addr; u32 reg; int ret, i; =20 @@ -937,6 +953,25 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c= _master *master, if (SVC_I3C_MSTATUS_RXPEND(reg)) { u8 data[6]; =20 + /* + * One slave sends its ID to request for address assignment, + * prefilling the dynamic address can reduce SCL clock stalls + * and also fix the SVC_I3C_QUIRK_FIFO_EMPTY quirk. + * + * Ideally, prefilling before the processDAA command is better. + * However, it requires an additional check to write the dyn_addr + * at the right time because the driver needs to write the processDAA + * command twice for one assignment. + * Prefilling here is safe and efficient because the FIFO starts + * filling within a few hundred nanoseconds, which is significantly + * faster compared to the 64 SCL clock cycles. + */ + dyn_addr =3D i3c_master_get_free_addr(&master->base, last_addr + 1); + if (dyn_addr < 0) + return -ENOSPC; + + writel(dyn_addr, master->regs + SVC_I3C_MWDATAB); + /* * We only care about the 48-bit provisioned ID yet to * be sure a device does not nack an address twice. @@ -1015,21 +1050,16 @@ static int svc_i3c_master_do_daa_locked(struct svc_= i3c_master *master, if (ret) break; =20 - /* Give the slave device a suitable dynamic address */ - ret =3D i3c_master_get_free_addr(&master->base, last_addr + 1); - if (ret < 0) - break; - - addrs[dev_nb] =3D ret; + addrs[dev_nb] =3D dyn_addr; dev_dbg(master->dev, "DAA: device %d assigned to 0x%02x\n", dev_nb, addrs[dev_nb]); - - writel(addrs[dev_nb], master->regs + SVC_I3C_MWDATAB); last_addr =3D addrs[dev_nb++]; } =20 /* Need manual issue STOP except for Complete condition */ svc_i3c_master_emit_stop(master); + svc_i3c_master_flush_fifo(master); + return ret; } =20 @@ -1226,6 +1256,24 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, SVC_I3C_MCTRL_RDTERM(*actual_len), master->regs + SVC_I3C_MCTRL); =20 + /* + * The entire transaction can consist of multiple write transfers. + * Prefilling before EmitStartAddr causes the data to be emitted + * immediately, becoming part of the previous transfer. + * The only way to work around this hardware issue is to let the + * FIFO start filling as soon as possible after EmitStartAddr. + */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FIFO_EMPTY) && !rnw && xfer_len)= { + u32 end =3D xfer_len > SVC_I3C_FIFO_SIZE ? 0 : SVC_I3C_MWDATAB_END; + u32 len =3D min_t(u32, xfer_len, SVC_I3C_FIFO_SIZE); + + writesb(master->regs + SVC_I3C_MWDATAB1, out, len - 1); + /* Mark END bit if this is the last byte */ + writel(out[len - 1] | end, master->regs + SVC_I3C_MWDATAB); + xfer_len -=3D len; + out +=3D len; + } + ret =3D readl_poll_timeout(master->regs + SVC_I3C_MSTATUS, reg, SVC_I3C_MSTATUS_MCTRLDONE(reg), 0, 1000); if (ret) @@ -1314,6 +1362,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, emit_stop: svc_i3c_master_emit_stop(master); svc_i3c_master_clear_merrwarn(master); + svc_i3c_master_flush_fifo(master); =20 return ret; } @@ -1968,7 +2017,9 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { svc_i3c_runtime_resume, NULL) }; =20 -static const struct svc_i3c_drvdata npcm845_drvdata =3D {}; +static const struct svc_i3c_drvdata npcm845_drvdata =3D { + .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY, +}; =20 static const struct svc_i3c_drvdata svc_default_drvdata =3D {}; =20 --=20 2.34.1 From nobody Wed Dec 17 00:19:28 2025 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66AC71FDA65; Thu, 6 Mar 2025 07:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247690; cv=none; b=Hwo7RCqI6kbdTA+0Q97oFfjb9fn/VwnkAmLjWvLaGDIDM2OLNSTs0z3CquZ/beupwqHzAJBe1gryHDK4y11NT/0VZEAQkGBkcl7DQ9BqXiBIm/IDPAa2kfgGlsGMpPn+4cKPeKMLmCTSAzEHQUzNOPtYAkwZOUKzsIHZggEmc8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247690; c=relaxed/simple; bh=a1jTTNqDWm6Rt73APC9vmSVtKjdWQslgAYtvB0Wstws=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=u7hi45Xq76+ghqBzWmN4eB3oU/j6wNrNJeQvjGcbmEKdttIeJkQL+JkL7KShrnt6XnbPJhl7DHa6Zna2tP3EttHIT8AHPMGU7bPGc0BftlTEz8b7tmGEzOHnEdYOybjPvo6c/iYAnwwj3uaHSu6sgac9D5zPYCuvWf+IO6bRPDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WWif9Adb; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WWif9Adb" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-22401f4d35aso5050055ad.2; Wed, 05 Mar 2025 23:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741247689; x=1741852489; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w2+tfajWqV/BpF+HlwJ7tnoTx43eUOwV3JjZ5iyWcbQ=; b=WWif9AdbMUiFRt7hYlsQiakjdhkdE43aEtI3Mlt9OxhFibNypbIlP2ymHclAXdxe6H RgPA2knT2RccRDerbhEi8CdjQdIt5HIEfg3HhbYq0KDyN+nBx3J3x4Tkq1+rO9vBh3G6 X7TnDmcfwTKqfG+aHS35bOFvwVah2MJULlNRgTxmIy79zzR6GzxIovWH0+nCWn1gXhIX axFw6K0gbiAS8Tp6rr7UloHS93mCyzjhwq5D1s2ZgTk++95vvniCH98jfwO6SVPc4NCF He6i+Wh3KRhVYcSxSa/y+OEKVaPU4SnvLKigySjM164PEnjt2wt4PanNGaPVxn2bf4mI EPHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741247689; x=1741852489; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w2+tfajWqV/BpF+HlwJ7tnoTx43eUOwV3JjZ5iyWcbQ=; b=ANatyzMIR4D5PA6No3pgBhb8F1cMxp7Bxm0JlN/BG1uOf1RLake35x/c2qzo70zRx5 yNB5rQ38xL6x8UOOcnrWN05ytHdlfgyySwADfdp/zXwycgKn/KIjchTtsdWhc41UJjAP cubeEVDxTHOJvWe14mCX24hjoYp1ZEbo0s5TETavO/2EedutT18hgdHqr2qxB2ZvNq// PNsi98ahpWWtyGOPSWFiwPS79fvcaRhHunhiJdf9sGbPqQB0NXLY6oKBGhPNzYXtgif1 bqdEcFZcld+ak9FFU3lhw5j2QCuQ97PlEq7gbW8+MHm76Vazy8BUYCH2K2uEzgmojpA3 qqyw== X-Forwarded-Encrypted: i=1; AJvYcCVTL6HwDEm/BtFCWzjjkv9iUzf7lk656J0i+TxpXgbCoyB+90jjdZkkLboaAMxIUEiRGAl7fIlnMcvt@vger.kernel.org X-Gm-Message-State: AOJu0Yznkyn3fXXcvg0tNFck1ASLYTCFK3R+QcJMwcE2pnQxZwZHDq1U L4XTfrappyB33R03LTbqX1e1tZQCHf+IuRkiJ8P92YQ7yHbber2FtWLWoA== X-Gm-Gg: ASbGncsdrDQlyNnZpbhHkSEZLYGcjCX8dnYVoLksu1536KeNahUWgouJugvEZhnCBJ1 OaGDVzKGybtf8SfjIIoTQBrQ6j6/kZEVNjcX4rYfnEbMA9seucYrBQY9pjYWw9Wh1Xh7SjjjMtl UP5CF1kh5vtZhKUcra/hpRivRjAH11OZwlnesg4EjC6M7mSoiYp1/prQKEgeFZ4oIaAf9MC7L6g /RoHj+AhrimWBc+poarLrg8SsAbjiALeIOsa3j1wTDuWQOqikNW/6+Yl9zWMLl9kXCtD7DIkjis /MZV7+w7pEXzhhJy2FyTErQNXAiDfqIhtAZjcZLE3d7M+UpLpxo4SD0= X-Google-Smtp-Source: AGHT+IF5txJTRwnyckdazVXegR2kdBARmrqG1Lso7rQth72ORrfeInWjkigbGtMEweDgwRomphqtbQ== X-Received: by 2002:a17:903:8cb:b0:220:d7f9:9ea8 with SMTP id d9443c01a7336-223f1c979bamr117875855ad.26.1741247688596; Wed, 05 Mar 2025 23:54:48 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22410aa448dsm6085485ad.210.2025.03.05.23.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 23:54:48 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v7 4/5] i3c: master: svc: Fix npcm845 invalid slvstart event Date: Thu, 6 Mar 2025 15:54:28 +0800 Message-Id: <20250306075429.2265183-5-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250306075429.2265183-1-yschu@nuvoton.com> References: <20250306075429.2265183-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu I3C HW may generate an invalid SlvStart event when emitting a STOP. If it is a true SlvStart, the MSTATUS state is SLVREQ. Check the MSTATUS state to ignore the false event. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index cba89a685e13..1cab5b8594de 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -58,6 +58,7 @@ #define SVC_I3C_MSTATUS 0x088 #define SVC_I3C_MSTATUS_STATE(x) FIELD_GET(GENMASK(2, 0), (x)) #define SVC_I3C_MSTATUS_STATE_DAA(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 5) +#define SVC_I3C_MSTATUS_STATE_SLVREQ(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D= 1) #define SVC_I3C_MSTATUS_STATE_IDLE(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 0) #define SVC_I3C_MSTATUS_BETWEEN(x) FIELD_GET(BIT(4), (x)) #define SVC_I3C_MSTATUS_NACKED(x) FIELD_GET(BIT(5), (x)) @@ -143,6 +144,12 @@ * Fill the FIFO in advance to prevent FIFO from becoming empty. */ #define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) +/* + * SVC_I3C_QUIRK_FLASE_SLVSTART: + * I3C HW may generate an invalid SlvStart event when emitting a STOP. + * If it is a true SlvStart, the MSTATUS state is SLVREQ. + */ +#define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) =20 struct svc_i3c_cmd { u8 addr; @@ -586,6 +593,11 @@ static irqreturn_t svc_i3c_master_irq_handler(int irq,= void *dev_id) /* Clear the interrupt status */ writel(SVC_I3C_MINT_SLVSTART, master->regs + SVC_I3C_MSTATUS); =20 + /* Ignore the false event */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FALSE_SLVSTART) && + !SVC_I3C_MSTATUS_STATE_SLVREQ(active)) + return IRQ_HANDLED; + svc_i3c_master_disable_interrupts(master); =20 /* Handle the interrupt in a non atomic context */ @@ -2018,7 +2030,8 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { }; =20 static const struct svc_i3c_drvdata npcm845_drvdata =3D { - .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY, + .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY | + SVC_I3C_QUIRK_FALSE_SLVSTART, }; =20 static const struct svc_i3c_drvdata svc_default_drvdata =3D {}; --=20 2.34.1 From nobody Wed Dec 17 00:19:28 2025 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 814162036F5; Thu, 6 Mar 2025 07:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247694; cv=none; b=AMChA7HYSSg8mEinJY+/+pFXf6URLH4j1fHkSbDnEsLkbepJnX3EQu/PPgHvkNbw9YQk6ypr+yfhKm3IyHk8bwRrwsAdhWdDDqCN0Nf8lNOxHa3FuI2XkMkysWSA3mooO1pGZQaVivKYqnS3vxLSfKf6kOwDiGwD43s/NaFEBEI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741247694; c=relaxed/simple; bh=zhogwmaQprEJIOZabiKKa/2rYvbETYpUnpa2KFbJWEo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=isrldIyy7Nu72P0XO3BpEWyHmkY2Mj5i8PPgQOnOx2YKFhqAP6g5QCQhNx7fjTG4F3gXHYfSjmY/nVaQzUXB1eikkqsBNhdsjpBQGm+Mp+zPDsVoYYf86CrzwcAnupMHq4q2ejv0Ih80C33PnvuOed+j83DC2B5b9e3gdV5u/Aw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gIkB2eni; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gIkB2eni" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-223cc017ef5so5287775ad.0; Wed, 05 Mar 2025 23:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741247692; x=1741852492; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YeHU0+uQ+ewEIetG9U1VzF4scs/x4AYkl7k9gMV2eYc=; b=gIkB2eniK6WwiI9lOmcRvSWVB6Hw+lRt1KBLKy1ViTE2XDiciZ+am1YgcCyUYMm14f RbrH0AZBL6a0U/6zL3JopkoYRMHyiUGh2w4j9viutvKzzyndfvhwB1eZfFyppCr1wK5j 5c4BqYb5O88rxxUC/oKFuDyb+A7gasNSUPzY/RWJ2l3S/BMmoMTbB3knwB4JXSl6LUAy eI6pRlICQhwXAiD/nJyvH6a58Z32eonXDlwR12Xkzhs1b7ofR+ydsC0YxO6G3dDmqp7A ntP48C6JdOcfLWS01LWVAvqwsdkNu/GfqNB8QRF3sI4h77ItsHq2yOhtI5ZJ80Ih8wYR KMlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741247692; x=1741852492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YeHU0+uQ+ewEIetG9U1VzF4scs/x4AYkl7k9gMV2eYc=; b=k93p9+oE8cdpUwIVHXs5V2iyOpvKLeLhMEHMN6Fpik6G9Jo8dcsLctbzhuebkhDnwS eu8Cc0OvmAbRyhNPeXF5PashlbqbjNYbRjRCFLB8RvIbS0+6WVomL6O0gnDKkc6Yo+FL ckgUJJTVp21Hri25ibo/GmtF3tipyq2nF/6rAHVRWChZnW9gwY2f4lCFLGyjy8J+IYgG O+Sla3QuQQdjdxxabEAQHqVSnjGnIo8p3XH57rP2h3UTPFEowNCELW0n6KC3yh6PSkB2 EeCsYdarBeO38OacN+RS000p7xae1mJ3Tia8Wwv3zMOxUXlMeq+6g9wMJ9f6tGc4YR8s lKOg== X-Forwarded-Encrypted: i=1; AJvYcCXOEYlUmQIAcn8VHf8cq4z9YRdhPl9p/Y517WVuTg/Cy39AS1HtGtdnTrtdxX/7kt4gimnF9AT4FGII@vger.kernel.org X-Gm-Message-State: AOJu0YzaJmxuVmfXbInl8008oLbs5PP6EIgw6Z/w2Lfx7c96HjrLfjh5 fVGWZ2wn5W7WmFGZR9OAcI+9jh7lPv65aaq84LEbtNKl9WH6jGFW X-Gm-Gg: ASbGncugJcCQegWh8Ej4Ty6ivJ18DSA88+kBVpMkG1Yegb4Bz6lteBt9dZFrhNZDDEd VAHXG0zQvWXA1ZwR/SkVH48Xpj7wT6+MQfIY3KxoRr7/smeB71bkU4wh13UTFtEwUHxVo2QKeHf /YZbpCi+09kTj0hUPr8YFkASAkbkdp30KhhfpFpeNZpfOySZF3mAOry9KqAptwRvqMWy7SOUbj9 Pqt2gnc4F0HzCgTG/DDAKZrFD5tLfpCivVcx7501RBTqzd4zVhIAjUDdvpa1S2vhj6cqJs4am7E ppEvyrP/PDqcof8QsTKsRJZ5Zj+akfH1aXnHhShOkqbhGkr6Bs8N61s= X-Google-Smtp-Source: AGHT+IGNTTEhiHJu3DzwlvrowX7noAbEyvQn1CqmoH1Ut3T89pAMQ/uSrN2Xy6F5yWg7r2FyzlOwew== X-Received: by 2002:a17:903:fa7:b0:223:5525:6239 with SMTP id d9443c01a7336-223f1d0fe68mr106221875ad.38.1741247691779; Wed, 05 Mar 2025 23:54:51 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22410aa448dsm6085485ad.210.2025.03.05.23.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 23:54:51 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v7 5/5] i3c: master: svc: Fix npcm845 DAA process corruption Date: Thu, 6 Mar 2025 15:54:29 +0800 Message-Id: <20250306075429.2265183-6-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250306075429.2265183-1-yschu@nuvoton.com> References: <20250306075429.2265183-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu When MCONFIG.SKEW=3D0 and MCONFIG.ODHPP=3D0, the ENTDAA transaction gets corrupted and results in a no repeated-start condition at the end of address assignment. Workaround: Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA process is completed, return MCONFIG.SKEW to its previous value. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 30 ++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 1cab5b8594de..c086e0e38279 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -32,6 +32,7 @@ #define SVC_I3C_MCONFIG_ODBAUD(x) FIELD_PREP(GENMASK(23, 16), (x)) #define SVC_I3C_MCONFIG_ODHPP(x) FIELD_PREP(BIT(24), (x)) #define SVC_I3C_MCONFIG_SKEW(x) FIELD_PREP(GENMASK(27, 25), (x)) +#define SVC_I3C_MCONFIG_SKEW_MASK GENMASK(27, 25) #define SVC_I3C_MCONFIG_I2CBAUD(x) FIELD_PREP(GENMASK(31, 28), (x)) =20 #define SVC_I3C_MCTRL 0x084 @@ -150,6 +151,16 @@ * If it is a true SlvStart, the MSTATUS state is SLVREQ. */ #define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) +/* + * SVC_I3C_QUIRK_DAA_CORRUPT: + * When MCONFIG.SKEW=3D0 and MCONFIG.ODHPP=3D0, the ENTDAA transaction gets + * corrupted and results in a no repeated-start condition at the end of + * address assignment. + * Workaround: + * Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA + * process is completed, return MCONFIG.SKEW to its previous value. + */ +#define SVC_I3C_QUIRK_DAA_CORRUPT BIT(2) =20 struct svc_i3c_cmd { u8 addr; @@ -259,6 +270,13 @@ static inline bool svc_has_quirk(struct svc_i3c_master= *master, u32 quirk) return (master->drvdata->quirks & quirk); } =20 +static inline bool svc_has_daa_corrupt(struct svc_i3c_master *master) +{ + return ((master->drvdata->quirks & SVC_I3C_QUIRK_DAA_CORRUPT) && + !(master->mctrl_config & + (SVC_I3C_MCONFIG_SKEW_MASK | SVC_I3C_MCONFIG_ODHPP(1)))); +} + static inline bool is_events_enabled(struct svc_i3c_master *master, u32 ma= sk) { return !!(master->enabled_events & mask); @@ -1144,7 +1162,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_c= ontroller *m) } =20 spin_lock_irqsave(&master->xferqueue.lock, flags); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config | SVC_I3C_MCONFIG_SKEW(1), + master->regs + SVC_I3C_MCONFIG); + ret =3D svc_i3c_master_do_daa_locked(master, addrs, &dev_nb); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config, master->regs + SVC_I3C_MCONFIG); + spin_unlock_irqrestore(&master->xferqueue.lock, flags); =20 svc_i3c_master_clear_merrwarn(master); @@ -2031,7 +2058,8 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { =20 static const struct svc_i3c_drvdata npcm845_drvdata =3D { .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY | - SVC_I3C_QUIRK_FALSE_SLVSTART, + SVC_I3C_QUIRK_FALSE_SLVSTART | + SVC_I3C_QUIRK_DAA_CORRUPT, }; =20 static const struct svc_i3c_drvdata svc_default_drvdata =3D {}; --=20 2.34.1