From nobody Sat Feb 7 16:05:42 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0646C78F3A for ; Wed, 5 Mar 2025 19:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741203413; cv=none; b=g1bm2A5m9dKdHZxjDRa3e8ZJT9ukcOxfmxDD3JDe2K7ADCCFuM5Q0vOTYbQXv/jOsNYCISb0uU/99ZRDuo6uJGz/jS4z98nn5lrcZg9krmEeTdQFYECKefNF0etbo5BE5NTDYDqqGN/wkUazp11orRKnvq2Cs3qxSm49tco09AU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741203413; c=relaxed/simple; bh=f+EcBHq0gIuPChKTRpZ/xjUmV0aa5c76pyhQGIXjb54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=imRk5oVJdHB/ntuqX+g6YkNH7wyHDIbMDxJCa6h0Uu9G9HUDGwQeDJieDmWa1ItklO9wMPROPhrIorVRZmYbnUtQ03XP2DQkys0k50qayIBcC6xHbSgKzWBTD288r3YVFFeALeF/MWBmuuSii2LH4pplsEmIPo+WjVP4qwRLvOE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gX5xc6TG; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gX5xc6TG" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2fe82430bb4so1882168a91.2 for ; Wed, 05 Mar 2025 11:36:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741203411; x=1741808211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sk/Vps+XrXsj0EE9YsBttNsi6jhkGXsUnHgeSBsXBQE=; b=gX5xc6TGRvMFclW3JZ57E1R8cc86YMI6wAQ3vT6pcwYlVeSStdC07s2cZ5GyNZLHBL 654BjVhAYib0L1Cp/nvK4/CCZNakwknhgJ6emQyyx1s/uneySuyovr3LhAade8OTu0Uf zqaeIpC9qkG/pJTVMrh1MrqiEL9SDmguOPG5pgMduMxo9JJZExK7PY1JLOMuOTYW3U4F kgIEvsddYJtDfLmtm8cu3fw1Haj/ntwP8H4F8uzu3p3GH6ugMzVZikNSXQA4CV4OQM8v tLardeaNBg/S94A59dlkAjmXPeCeNP21b5T40ZZFFQAbK7xR68k5KJmKvtf6VYBEuxAi cmOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741203411; x=1741808211; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sk/Vps+XrXsj0EE9YsBttNsi6jhkGXsUnHgeSBsXBQE=; b=iC+hjjykmg8pdHCpRYTn+s47VbOKNV4R0bADhienriAF0C07IJ098+Agui2FFEOuEf B8++ckYwOEUgGEHeIJmieF/6OrDPsq2fLw+RVL9pJiX7pXKyb4Rqo4MVffFs+fbX/+0F vhltMFsn/2vNCfEHXcLdDKnCaVO+5BzQ9CMXucrZPB5hWJ0PoqXPFP6+I5aYllmwWhSG U9oz26LeWS9Dz9YAtRd+hZzOjqYmNQ09hMFVeUMlPX8FcTrd/JCVUNgZMkUarx9liX6N zf6h6gPz4C1JW86jTLRN2/M9qo+kNyBYNNr/mL5ZsELe9Vty6qYt5bH/gZK7KRiEJawM ZL5A== X-Forwarded-Encrypted: i=1; AJvYcCX66lMwOEjayMMxRU3TiK9owXbN7MaZ3LPxsnKyzBQmG7iNpzbPHbHLDHagZkD3rQ8VEyDsnngbdOb+oIA=@vger.kernel.org X-Gm-Message-State: AOJu0YwTHNROrieT2FLwfjOPntJu6IYw1VnPoYy+3UsfcKbXcELZx62d q88MIAJzAPeVA+pNwEfekQBCadoN+/eIYYAmW0tFthbNMR8vfOIP X-Gm-Gg: ASbGncuUG4IYlNfVLjpvIU2FwYoz7nswsS7dVkgWeVHEu2pNwoNUkIh/jQ0wDh/o+ol nytUcepnxVKQenOJogD11rYT2CrbNiBXenJdoa3Q/9+OvbebubnWZjJmZDZGFdnyJmm10qqNUm2 Ri63RzCK2iiwGY2zVLWRPwSvRJnN0KgOrHvQ4af6xCwlLN+9tzeQsHLFWrxvmWw2nLigRPJLb10 KC/gQ/1afBcwtLTe56XeycQPo/I3pcWx61xtBHUaPfwIKJ9m5a62UT6UGnBATY2Pa5uFj0chF8b UPZ+QZ0EPlShI1FNUYB9ZRvIw4pILSkjC+WtX+6coZ8gRM4oCAFHH7vpBvoV X-Google-Smtp-Source: AGHT+IFQ9HwEoVTVlmufm04/RgIQIMt5CoKXcTADkaczq5WVDkpG/N4C0fD8ORB3wOOwpnFJIdaf5w== X-Received: by 2002:a17:90b:5344:b0:2ff:4be6:c5bd with SMTP id 98e67ed59e1d1-2ff4be6c6ecmr2272508a91.8.1741203411157; Wed, 05 Mar 2025 11:36:51 -0800 (PST) Received: from localhost.lp.veng.com.ar ([200.10.125.114]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e7a2bbesm1898148a91.37.2025.03.05.11.36.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 11:36:50 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org, dan.carpenter@linaro.org, arnd@arndb.de, niharchaithanya@gmail.com, jiapeng.chong@linux.alibaba.com, linux-kernel@vger.kernel.org, Gaston Gonzalez Subject: [PATCH v2 1/4] staging: gpib: fix kernel-doc section for write_loop() function Date: Wed, 5 Mar 2025 16:32:16 -0300 Message-ID: <20250305193614.39604-3-gascoar@gmail.com> X-Mailer: git-send-email 2.49.0.rc0 In-Reply-To: <20250305193614.39604-1-gascoar@gmail.com> References: <20250305193614.39604-1-gascoar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a colon character in the kernel-doc section of write_loop() in order 'leng' to be picked as argument by the kernel-doc compiler. This change fix the following warning: warning: Function parameter or struct member 'leng' not described in 'send_command' Signed-off-by: Gaston Gonzalez --- v1 -> v2: no changes in this patch. drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 50faa0c17617..eeabbdb39057 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -232,7 +232,7 @@ static int write_loop(void *dev, char *msg, int leng) * * @board: the gpib_board_struct data area for this gpib interface * @msg: the byte sequence. - * @leng the byte sequence length; can be given as zero and is + * @leng: the byte sequence length; can be given as zero and is * computed automatically, but if 'msg' contains a zero byte, * it has to be given explicitly. */ --=20 2.49.0.rc0 From nobody Sat Feb 7 16:05:42 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0526A1A23B1 for ; Wed, 5 Mar 2025 19:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741203446; cv=none; b=FD3H5/LRF11tPpE/Y2qnv8guj0f779fNEKlNkcBD2xaI8Gk1pxbBldGm+8vPCgZQ1aQOprG9li9MC48NXNa79UzeJ8bowkAW5nxQeezoRbss64HyZgR2nuGvyuUSj3HU2UMfRHCM2Ca9ILqNEonf+EWec0Lz53yEwi3OXbuqrT0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741203446; c=relaxed/simple; bh=NiSAOPAgkdb/WErvFuPt8dYjPkHrz80Z5l1d8QBlXxY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dogNK0v5sEwZ21RJZO/D1v+DV1Ek1yPoWItQgIRGUrmMIDCqLQYN8HIzf5ZVrG1g4f/5AnPyWOFDz+X2zIRWh4JGFefX9/o1bgNqpsjj01ozv+ASl4tQM0NI7/7shisNgLZ0AhXLBANBvVR6ofoaLHtriB+PwcRnFRujHVxJNV0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jImYgd9P; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jImYgd9P" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-22400301e40so1881775ad.1 for ; Wed, 05 Mar 2025 11:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741203444; x=1741808244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3HZfT3BJ97SDi73Ze6YNCLhdfpk5R2Zm48aUE8tr5nI=; b=jImYgd9PGpn8uTDmZiA+x6xDKd+XFV+7AeY9BKFETZPtYBVU3QwkXORp1S9lQBj+vo NQv9zIqWuPxs9Ip2lwSxLnnWK3ldfBny+mVfGVjw5tumUYjtPbAMnWwq9dKTMr5ZkxCd V8pZZpAGw/IWeDBZ7xL8DjlMIw3S0isG+PfTRFMw6kwK0IJFhTiwj0ghu5GV2CBMxDyU Ohgdk16auEYdwoW62Wmf7XHfLWUQD7Q8E5KBKUjlUex3gv4/UoHaxHhCrNN4f4uaYrxi WFZ7J71Hla8xnNas+DmhfEhDgwpj+uf0NTRj1gHIQVuYSsT8SRDFpR7/2uHNOmDlyetU 2hfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741203444; x=1741808244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3HZfT3BJ97SDi73Ze6YNCLhdfpk5R2Zm48aUE8tr5nI=; b=dmj5OhSBLAIAqUM3pe2urX/EGWw/mt8Fw2nPMmXp9sXF3wwyMT+/ob6T24c3iNfA9y cPjzDzUQlkmo4yQscUInCL+jEzupmIkqJcYOmFlLh2+VPCFc5VqlML+yOQE5TVGIb/o6 NnW/BKuTDIxJw5o4Zje4LYLMp60fYHaE4rgnCPMmM33m7pcG/NdjXJcT+lBLSWf1JIaS RVPOUJH9TCiNLYV/66P1CjbBtx/7Nou9tujFWDYO6oaGYqRFN4xgfQgbV/1agg/6j/Xw SLhg39hLyYhppk61bjlYe3HqP2VlnjwSjSH73/49sB837Jox8KKi3a9U5kx2iqFCGhle vMZQ== X-Forwarded-Encrypted: i=1; AJvYcCXxbiI/4jJr1X43X0AWtQwejiOJCfoYz1/25J1nP8wnS4S0sfd63lhA+d+ywhUtOhjh9IyoP8HRfg30tC8=@vger.kernel.org X-Gm-Message-State: AOJu0YyFdZwcNKq9yhpVwK9hwKIXXuUH782MvI/q9K+14qQo4ujzMIdv njBNK2cqJvpHbTMOB+f+TWRN5yJwWWd60L6ncVAg4t/pMAN/7ZKtfyOsFg== X-Gm-Gg: ASbGncsl/YBU8shCq0QOOMglcj/Jj3WNzyCtcLcaBPxO3RKJs/1zTJB5XRmmCuWuVA9 8DEBMQpvKbQcpmZGHI/8XWqDi48jrKLAUALRMMdZFFKINPsjpYsNvoRPC6auSS9kd3HU0RqS+rR UHjS8hQjNpvicyObfM/IblgPMNoqicIkdQxhOJpVew38gFF4JvGUt6e1MhHsmox3q+2JU2qtCB0 h1QDOOqtLtllSXEFbgpvdtHDtVOqc+PsrXzh2dTLv5IXJI922FgClMaocoYwpj5vJerRi1/KZ3k XR69UuAA+nUjVrqH5HVr/D4iV1WdVManwKazNX6cP3O0nJgsCBzVV9kPfAJI X-Google-Smtp-Source: AGHT+IHsMPQdEsN+BrWmog6Gj2bXAKJEAfY6RuvXg31gY6PlWFrf/eyHD0qoGNGZW7v0mj/fHoDj7A== X-Received: by 2002:a17:902:e881:b0:21f:1365:8bcf with SMTP id d9443c01a7336-223f1d33ae6mr27861905ad.10.1741203444288; Wed, 05 Mar 2025 11:37:24 -0800 (PST) Received: from localhost.lp.veng.com.ar ([200.10.125.114]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e7a2bbesm1898148a91.37.2025.03.05.11.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 11:37:23 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org, dan.carpenter@linaro.org, arnd@arndb.de, niharchaithanya@gmail.com, jiapeng.chong@linux.alibaba.com, linux-kernel@vger.kernel.org, Gaston Gonzalez Subject: [PATCH v2 2/4] staging: gpib: fix kernel-doc section for function usb_gpib_interface_clear() Date: Wed, 5 Mar 2025 16:32:18 -0300 Message-ID: <20250305193614.39604-5-gascoar@gmail.com> X-Mailer: git-send-email 2.49.0.rc0 In-Reply-To: <20250305193614.39604-1-gascoar@gmail.com> References: <20250305193614.39604-1-gascoar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add '@' character in kernel-doc comment in order 'assert' to be picked as argument by the kernel-doc compiler. This change fix the following warning: warning: Function parameter or struct member 'assert' not described in 'usb_gpib_interface_clear' Signed-off-by: Gaston Gonzalez --- v1 -> v2: no changes in this patch. drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index eeabbdb39057..090857824d07 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -621,7 +621,7 @@ static int usb_gpib_go_to_standby(gpib_board_t *board) * usb_gpib_interface_clear() - Assert or de-assert IFC * * @board: the gpib_board data area for this gpib interface - * assert: 1: assert IFC; 0: de-assert IFC + * @assert: 1: assert IFC; 0: de-assert IFC * * Currently on the assert request we issue the lpvo IBZ * command that cycles IFC low for 100 usec, then we ignore --=20 2.49.0.rc0 From nobody Sat Feb 7 16:05:42 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A32C253B7C for ; Wed, 5 Mar 2025 19:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741203475; cv=none; b=EoBx9mj2PZiiXtANcwi2xIEMG7TUJvigC8F1CE8vEY8Dhr4e7gwHzXkw3tOZlpIxDwh7KH5YuDLweB15sWN2jFQwXKpr/gHp/xu2y8NFUMy/4JHEKG+6fWKMrGXSuwgSzBbTtoWQLSoJxxThfVgL10an0q3zrx/bGJJ71z6WpvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741203475; c=relaxed/simple; bh=r/JCkE1A/VLSmSiv7YzZkQknfhDehP9WWEoKTpqyRXk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S4KT+yxkf7QKM9/+jC+hKDpN0byIR9FhbirAQsNJ1Xvpvf9aXWmFd2R4g4diW88ivetAyEsiundD5AJ7iLNiMSh65hg49JEjZCqq6I0zEYlRqEJeXu4LpjxrzvXfpgWcd3hPWAaOfgg4E4QWeLZWdQ+ZI+XaX76NBQs0M0errkY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g92+gyt8; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g92+gyt8" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2ff53b26af2so227295a91.0 for ; Wed, 05 Mar 2025 11:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741203474; x=1741808274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XVL5x+1w+5pdmFPSNp6O0gS3bmjeUt72DJ16wn3q7tw=; b=g92+gyt8PafJK68hqTKBTTJ5LyaNNmL4ZOUOB5icOMxcbVjR/Fwt6lyJTh8erMX1IO HaR5b8seqw1SNUHUiThPzOWiNjkp3ugfgO5CkXEN6bNS/abP4AiqCuQG13QeyAniqQHP NjRg1iCedZBzGRuhC0ROOHxkX2Nb/2JWpetB6F2iSTpV7Qb42pwDlGfQ3ZWUIciXYues MSu2snhsDSMdpAvs3olSotqnRN7ez0fZwn+0KuvPtY2s1ZF58kF7ZBSHM1Ibg/rXERFC 4eR9m+GXJMC/PODAHaU834sZmsi4R6T2dOEbnc8n+mzZPIqESHElmIS9JVfQmsDc+OFG UfLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741203474; x=1741808274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XVL5x+1w+5pdmFPSNp6O0gS3bmjeUt72DJ16wn3q7tw=; b=AKtfkFCIKhXLFF4jhJdqv3kTjkUjsxTlRbwzmG4NlSuKrU/xEm+V+TLoRN2M3Z5UMU aOm2xcDLtqRGe8UBh82FrcsJmT7lbQEPnMWYmPeKLBuWLUCNSUOn2OFYvsPILCZI8S6d EfDD/1A4w2anwunXS6iNOhCbyOhUyvqb/FFO1jASuisKwppjbS1HaInZSwYa0L0mfql+ pv/wGjxL5IY8I4pRTKA5TRalvhSMRhIngdIcAmN4Gs0O8yR8Tdiy5pgckQ3bEptZ5Wte kNzi3qNhOx1Ty1Ns0+RPF8tteSJcelSboBRT3CguwxhetEzMslDDqbTvHiSCNlQXyUOg 6tvw== X-Forwarded-Encrypted: i=1; AJvYcCUYoppatg9/ETy5kUfV1Aysow4pEFE7jYhgWbTAorYl6x1C9MA3N3fq9KYM+ZbplQlWRuLwAeT8IQpM2aE=@vger.kernel.org X-Gm-Message-State: AOJu0YzYPc/Wit5XnAp52UQA0avR1rg1FQivf52Jc/ja7clADw0JRdo6 CuqWGiOdCcjDleCRJTOkoSIKCP7XztZmn//MDOng993v1xaYvNlc X-Gm-Gg: ASbGncvGkxUAMvLTI/ROan4FrUIytyQtVJXWRVrGrReIyVWLPN+LAi0gwBGLr9gEtPm 6n2wxM5UedWFQ6VgZOVo1/cp5oLcLxmOJ0Wa3vhysX2qzvPXondk/vGt5c3C4ortpVfav/+PzN3 7U21gF7N9eqQ+3Utd77d/mNltbEt1VMQH37QbCdxTCyGZNJo/va9d3lAVJJY759XYrhDZrgvUAW ymZdIQtwVTWeDEI/Co6HbWRd/C+jFO3WDOLy500aD6gSv4gkT2bquZP3WjX8sqKpvs2eRRg2keC 0vx3YhMAgWsXG9ai9sfe/d49J2YrsggvVPIS3TABeUIJvh67YUd65N1QJLEx X-Google-Smtp-Source: AGHT+IHNsyo24/zrvRg4XtHFBGu5hJ7yR3l2dvNxqCeNbui3/L/DlOgNcf1xKJT/5yBT8maOJNvE1Q== X-Received: by 2002:a17:90b:1a8f:b0:2fa:6055:17e7 with SMTP id 98e67ed59e1d1-2ff497df3d2mr2866356a91.8.1741203473716; Wed, 05 Mar 2025 11:37:53 -0800 (PST) Received: from localhost.lp.veng.com.ar ([200.10.125.114]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e7a2bbesm1898148a91.37.2025.03.05.11.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 11:37:53 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org, dan.carpenter@linaro.org, arnd@arndb.de, niharchaithanya@gmail.com, jiapeng.chong@linux.alibaba.com, linux-kernel@vger.kernel.org, Gaston Gonzalez Subject: [PATCH v2 3/4] staging: gpib: fix kernel-doc section for usb_gpib_line_status() function Date: Wed, 5 Mar 2025 16:32:20 -0300 Message-ID: <20250305193614.39604-7-gascoar@gmail.com> X-Mailer: git-send-email 2.49.0.rc0 In-Reply-To: <20250305193614.39604-1-gascoar@gmail.com> References: <20250305193614.39604-1-gascoar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function name field in the kernel-doc section for the usb_gpib_line_status() is defined as 'line_status'. In addition, after the kernel-doc section, there are three macro definition instead of the function definition. These issues trigger the warning: warning: expecting prototype for line_status(). Prototype was for WQT() instead. Fix the warning by renaming the function in the kernel-doc section and by moving the macros to the beginning of the file with the rest of macros definition. Signed-off-by: Gaston Gonzalez --- v1 -> v2: remove extra blank line added by mistake in v1. drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 090857824d07..4a8e5905daf9 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -78,6 +78,10 @@ module_param(debug, int, 0644); dev_dbg(board->gpib_dev, format, ## __VA_ARGS__); } \ while (0) =20 +#define WQT wait_queue_entry_t +#define WQH head +#define WQE entry + /* standard and extended command sets of the usb-gpib adapter */ =20 #define USB_GPIB_ON "\nIB\n" @@ -644,17 +648,12 @@ static void usb_gpib_interface_clear(gpib_board_t *bo= ard, int assert) } =20 /** - * line_status() - Read the status of the bus lines. + * usb_gpib_line_status() - Read the status of the bus lines. * * @board: the gpib_board data area for this gpib interface * * We can read all lines. */ - -#define WQT wait_queue_entry_t -#define WQH head -#define WQE entry - static int usb_gpib_line_status(const gpib_board_t *board) { int buffer; --=20 2.49.0.rc0 From nobody Sat Feb 7 16:05:42 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A678253F1A for ; Wed, 5 Mar 2025 19:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741203488; cv=none; b=KlWVtXf1gz5EerDGfFSEqI5oqclJcX2Cn6/ILSvBmKRqH3LL4WLIyWpJjnHeM/+i9DYgQZq9A2lWZ6rKnYcdUAYK8j89+zpuNIfI5mcbTQ/5QD+fVaQs60eMz7/kDFFr8GKYmPuk/J1cis4NLCC9WYk473tUVP/A06AxTlzsyVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741203488; c=relaxed/simple; bh=j/iTviw7PJPcpETuVwwtmw6HSTOe+M0fePl8x0v8b/A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QEOx5q7T5bTZBNHaOnhe5ho3RPkjai7hm03SEH05BD40FzRENMC9sZnenttRB1jIj9XcyeJHV7xqH8toOQT/SmAfehIdMwd/3Cg6vJMgg8zDDqZn/dg7ISQiwReSRAexsAQm/hz+2K8UCpRmdtr2J51gmpVtLdwDxoPaAVRGTpY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gbHwSQGm; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gbHwSQGm" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2feae7e56c6so1881832a91.1 for ; Wed, 05 Mar 2025 11:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741203487; x=1741808287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d7sXbP8vy3+v83lKPy6uZAVEBdTCaE0ovfzAtTI97R0=; b=gbHwSQGmCgmUuaFQcCwH2meZbXW/K1VBc6r4qOISuvS3mddy8RQlZWUdEMKbYwyuh3 0O3VPblYEeNDzEDcIytmzo/QYYetFEpvVaADwvISrCi2FBEwvLBHs36KxRlOO8IUu9t5 G+HqIgjayoP34CGME9zvKMm+3cdXHSG3XYKICpvLg4/7WUE7p7Bc8rSqejTta6SMJZRA M0bH8Z/VYHCd//M4K76UYJKagH9Zh3v6m42OQP5tNJ2IEaki05oG8N6v2P5/ZjbjcCWk Sb0daFnf/t28HXBSsa7c2YbzItse8IxiW7jkuiMr0ohOnA4zeRHvdqpw0n1T+7gMYeWM sfLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741203487; x=1741808287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d7sXbP8vy3+v83lKPy6uZAVEBdTCaE0ovfzAtTI97R0=; b=mNg1DNNmTA2TK0As0FSXT8d+EWrCX/c/7r29TYkJjneXXctQe01EKTiNnGOitPa2dv g4m2Up4FDxHfB4l8lImchB2XHS+/dwtPgpJpbzZ89koydjLEPRVM7u8ckNUjefTmq3E4 iO43oBVeXDpGqMLFlBfD+Ro512O1HGvEMDKoF0j2FPrj/1ZHSikrN9gtazkI8pIhaW9G N6rH56j08XPd3YWQGgve5epNw7sfnPu5A8QUJN8oEZtZOMYuYffP97tlpFwc9GkWBHfa /nxuJ9KRt9H85eB37meaSeg2YXf9bEvw0jn7s/TS1diPUw5ykYMZZrARfGkWBL51rw1v D2lw== X-Forwarded-Encrypted: i=1; AJvYcCUk5bafEAl4R24YdrDz+dxjx8HwozBXQ4Mp1GW+anLYREYo3y7ypck0YncY10N06TyW2cRtD8z//zY3Kfg=@vger.kernel.org X-Gm-Message-State: AOJu0YwTaQDkhxSV7jPqpPBq0PjLXMFaNvLOMvQqasIzRf1HoxqwtZx1 VeZTM7mLAnJjPLBFthxAh8riMaLQ7qNZ1AiVS0KW+vU//dxy3tdBVAlHww== X-Gm-Gg: ASbGncu/ZTKctu2BL0c2UQ2UHzu82wssPrCZyXDOle4ReR+dA1k0Ml+Cb02QRZCnJjE xEw/A24T+MkcTQcLThppKyrnpRXXB5JDx59JzNqg9E3STwodrrDkyHwehCXqSS2tkgmQCoEp5Aa Eyg4oIZWlPxJDuk2qeKHkKPkNxhB1bRougPS8rF41z6LVmlmI9oBw5hVEDlw0Px2lTJJSacvjGO W0GQ8xy3IIqlUaGQX2eW3qK9jYqP2Nk3bjbopxjvwk5fR28WyjP/psaL/b4wCbgfMVWyj4LOXpX qim31yQ7ZUJF5ASFouvXAENRwLmhMMXRRY5JJySanZWf7vru9sndlZjZkV5h X-Google-Smtp-Source: AGHT+IHsjbx1miPTQBNrX7ZjboroAqHyYvjM19R16VWGXNXNp7juxMRcFLx8vf3UD4OuEm12sLJK7g== X-Received: by 2002:a17:90b:3a91:b0:2fe:b879:b68c with SMTP id 98e67ed59e1d1-2ff49824430mr2883031a91.6.1741203486654; Wed, 05 Mar 2025 11:38:06 -0800 (PST) Received: from localhost.lp.veng.com.ar ([200.10.125.114]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e7a2bbesm1898148a91.37.2025.03.05.11.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 11:38:06 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org, dan.carpenter@linaro.org, arnd@arndb.de, niharchaithanya@gmail.com, jiapeng.chong@linux.alibaba.com, linux-kernel@vger.kernel.org, Gaston Gonzalez Subject: [PATCH v2 4/4] staging: gpib: remove commented-out lines Date: Wed, 5 Mar 2025 16:32:22 -0300 Message-ID: <20250305193614.39604-9-gascoar@gmail.com> X-Mailer: git-send-email 2.49.0.rc0 In-Reply-To: <20250305193614.39604-1-gascoar@gmail.com> References: <20250305193614.39604-1-gascoar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove commented-out code in function write_loop(). Signed-off-by: Gaston Gonzalez --- v1 -> v2: no changes in this patch. drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 4a8e5905daf9..08c64b111a1f 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -217,18 +217,7 @@ static inline int usec_diff(struct timespec64 *a, stru= ct timespec64 *b) =20 static int write_loop(void *dev, char *msg, int leng) { -// int nchar =3D 0, val; - -// do { - return skel_do_write(dev, msg, leng); - -// if (val < 1) { -// return -EIO; -// } -// nchar +=3Dval; -// } while (nchar < leng); -// return leng; } =20 /** --=20 2.49.0.rc0