From nobody Sun Feb 8 21:46:42 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5636F24BBFD; Wed, 5 Mar 2025 13:02:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741179723; cv=none; b=SuzXyGw54Xswc7y3426On77lBNE9e34GIyKzNaszPJKrDukWGeemw2IajTwZKctbnSu6Q1gC1nlTipO+7Pq1YBoLdYlPExr1iuVdvVqN1B4Hya5UNkuS3GDLFzTF+vURCEDmaioJhS0dHS6HaORUYafK1rcesDxWEiUIXw3ZMuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741179723; c=relaxed/simple; bh=4JWZqjchoPQmjQPxBt4VU0a0UJxF0OETHkFQ4AKXrUw=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hhQfWLPJ0Wj8tCXfy/MM4foW94V2mDPKBJOtGnEeFuRhdpe53QIsXjYPGjFxicfxTWUP3pVjFv+9Te/9MxjwrxnJAFEw1HzB2OWMvPO2/C7qy5hQ4FzqQQwvzTXZWg2EcO5iy1iazXxf/Y04jUOXue6KzceHFXxlINGYyZj2fOc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Sr5VY8Zd; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Sr5VY8Zd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741179722; x=1772715722; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=4JWZqjchoPQmjQPxBt4VU0a0UJxF0OETHkFQ4AKXrUw=; b=Sr5VY8Zd3xwYjJ4qGNQxlmE1O3m8CEJ7I+zIsdcAYKAnJdI67lbSNc55 4MQk9rvImpk3BGvSpsiHnRchmcLzanLsxGNAARuwBXgrZNyxlOJM/F5rj k3vLkkk0YeWopePThzD+UloVNlMz3YFN0pPIY3hkyVzsBovsN7cbFIugB /nvFkdgomKGnRsZy0QRDSsS9OdzWnPNgwU6LAFPPeRK9THgBHkFCpkgjT b0QiJHsursW7jNxk3xFhsKg/WBZuSP+SaymGWn/he+6tPMSpr1szX5eA/ ErozQR0t0M6k/qHl2RYCJD2Tfsyg+/kMfhku91vyyyBF5tjtsolDnQVhq w==; X-CSE-ConnectionGUID: 2q2bcEzWR8yXESc4SHnsOA== X-CSE-MsgGUID: O3sh55gxQyK6jpb51ilHvg== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="45795113" X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="45795113" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 05:02:01 -0800 X-CSE-ConnectionGUID: gsGF0Ys0QYy8/BfBgQNbIg== X-CSE-MsgGUID: GDYzCSjXQsWja89CicvqQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="123277137" Received: from mohdfai2-ilbpg12-1.png.intel.com ([10.88.227.73]) by fmviesa005.fm.intel.com with ESMTP; 05 Mar 2025 05:01:53 -0800 From: Faizal Rahim To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Simon Horman , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Furong Xu <0x1207@gmail.com>, Russell King , Vladimir Oltean , Serge Semin , Xiaolei Wang , Suraj Jaiswal , Kory Maincent , Gal Pressman , Jesper Nilsson , Choong Yong Liang , Chwee-Lin Choong , Faizal Rahim , Kunihiko Hayashi , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Subject: [PATCH iwl-next v8 08/11] igc: add support to set tx-min-frag-size Date: Wed, 5 Mar 2025 08:00:23 -0500 Message-Id: <20250305130026.642219-9-faizal.abdul.rahim@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305130026.642219-1-faizal.abdul.rahim@linux.intel.com> References: <20250305130026.642219-1-faizal.abdul.rahim@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support to set tx-min-frag-size via set_mm callback in igc. Increase the max limit of tx-ming-frag-size in ethtool from 252 to 256 since i225/6 value range is 64, 128, 192 and 256. Co-developed-by: Vinicius Costa Gomes Signed-off-by: Vinicius Costa Gomes Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc.h | 1 + drivers/net/ethernet/intel/igc/igc_defines.h | 1 + drivers/net/ethernet/intel/igc/igc_ethtool.c | 5 +++ drivers/net/ethernet/intel/igc/igc_tsn.c | 37 ++++++++++++++++++-- drivers/net/ethernet/intel/igc/igc_tsn.h | 2 +- net/ethtool/mm.c | 2 +- 6 files changed, 43 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/in= tel/igc/igc.h index d9ecb7cf80c9..4dfd133b4d6f 100644 --- a/drivers/net/ethernet/intel/igc/igc.h +++ b/drivers/net/ethernet/intel/igc/igc.h @@ -42,6 +42,7 @@ void igc_ethtool_set_ops(struct net_device *); =20 struct igc_fpe_t { struct ethtool_mmsv mmsv; + u32 tx_min_frag_size; }; =20 enum igc_mac_filter_type { diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/eth= ernet/intel/igc/igc_defines.h index 22db1de02964..038ee89f1e08 100644 --- a/drivers/net/ethernet/intel/igc/igc_defines.h +++ b/drivers/net/ethernet/intel/igc/igc_defines.h @@ -551,6 +551,7 @@ #define IGC_TQAVCTRL_PREEMPT_ENA 0x00000002 #define IGC_TQAVCTRL_ENHANCED_QAV 0x00000008 #define IGC_TQAVCTRL_FUTSCDDIS 0x00000080 +#define IGC_TQAVCTRL_MIN_FRAG_MASK 0x0000C000 =20 #define IGC_TXQCTL_QUEUE_MODE_LAUNCHT 0x00000001 #define IGC_TXQCTL_STRICT_CYCLE 0x00000002 diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/eth= ernet/intel/igc/igc_ethtool.c index b64d5c6c1d20..529654ccd83f 100644 --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c @@ -1789,6 +1789,11 @@ static int igc_ethtool_set_mm(struct net_device *net= dev, struct igc_adapter *adapter =3D netdev_priv(netdev); struct igc_fpe_t *fpe =3D &adapter->fpe; =20 + fpe->tx_min_frag_size =3D igc_fpe_get_supported_frag_size(cmd->tx_min_fra= g_size); + if (fpe->tx_min_frag_size !=3D cmd->tx_min_frag_size) + NL_SET_ERR_MSG_MOD(extack, + "tx-min-frag-size value set is unsupported. Rounded up to supported= value (64, 128, 192, 256)"); + if (fpe->mmsv.pmac_enabled !=3D cmd->pmac_enabled) { if (cmd->pmac_enabled) static_branch_inc(&igc_fpe_enabled); diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/etherne= t/intel/igc/igc_tsn.c index 0a2c747fde2d..2ec5909bf8b0 100644 --- a/drivers/net/ethernet/intel/igc/igc_tsn.c +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c @@ -6,6 +6,12 @@ #include "igc_hw.h" #include "igc_tsn.h" =20 +#define MIN_MULTPLIER_TX_MIN_FRAG 0 +#define MAX_MULTPLIER_TX_MIN_FRAG 3 +/* Frag size is based on the Section 8.12.2 of the SW User Manual */ +#define TX_MIN_FRAG_SIZE 64 +#define TX_MAX_FRAG_SIZE (TX_MIN_FRAG_SIZE * (MAX_MULTPLIER_TX_MIN_FRAG + = 1)) + DEFINE_STATIC_KEY_FALSE(igc_fpe_enabled); =20 static int igc_fpe_init_smd_frame(struct igc_ring *ring, @@ -128,6 +134,7 @@ static const struct ethtool_mmsv_ops igc_mmsv_ops =3D { =20 void igc_fpe_init(struct igc_adapter *adapter) { + adapter->fpe.tx_min_frag_size =3D TX_MIN_FRAG_SIZE; ethtool_mmsv_init(&adapter->fpe.mmsv, adapter->netdev, &igc_mmsv_ops); } =20 @@ -278,7 +285,7 @@ static int igc_tsn_disable_offload(struct igc_adapter *= adapter) tqavctrl =3D rd32(IGC_TQAVCTRL); tqavctrl &=3D ~(IGC_TQAVCTRL_TRANSMIT_MODE_TSN | IGC_TQAVCTRL_ENHANCED_QAV | IGC_TQAVCTRL_FUTSCDDIS | - IGC_TQAVCTRL_PREEMPT_ENA); + IGC_TQAVCTRL_PREEMPT_ENA | IGC_TQAVCTRL_MIN_FRAG_MASK); =20 wr32(IGC_TQAVCTRL, tqavctrl); =20 @@ -324,12 +331,34 @@ static void igc_tsn_set_retx_qbvfullthreshold(struct = igc_adapter *adapter) wr32(IGC_RETX_CTL, retxctl); } =20 +static u8 igc_fpe_get_frag_size_mult(const struct igc_fpe_t *fpe) +{ + u8 mult =3D (fpe->tx_min_frag_size / TX_MIN_FRAG_SIZE) - 1; + + return clamp_t(u8, mult, MIN_MULTPLIER_TX_MIN_FRAG, + MAX_MULTPLIER_TX_MIN_FRAG); +} + +u32 igc_fpe_get_supported_frag_size(u32 frag_size) +{ + const u32 supported_sizes[] =3D {64, 128, 192, 256}; + + /* Find the smallest supported size that is >=3D frag_size */ + for (int i =3D 0; i < ARRAY_SIZE(supported_sizes); i++) { + if (frag_size <=3D supported_sizes[i]) + return supported_sizes[i]; + } + + return TX_MAX_FRAG_SIZE; /* Should not happen, value > 256 is blocked by = ethtool */ +} + static int igc_tsn_enable_offload(struct igc_adapter *adapter) { struct igc_hw *hw =3D &adapter->hw; u32 tqavctrl, baset_l, baset_h; u32 sec, nsec, cycle, rxpbs; ktime_t base_time, systim; + u32 frag_size_mult; int i; =20 wr32(IGC_TSAUXC, 0); @@ -501,13 +530,15 @@ static int igc_tsn_enable_offload(struct igc_adapter = *adapter) } =20 tqavctrl =3D rd32(IGC_TQAVCTRL) & ~(IGC_TQAVCTRL_FUTSCDDIS | - IGC_TQAVCTRL_PREEMPT_ENA); - + IGC_TQAVCTRL_PREEMPT_ENA | IGC_TQAVCTRL_MIN_FRAG_MASK); tqavctrl |=3D IGC_TQAVCTRL_TRANSMIT_MODE_TSN | IGC_TQAVCTRL_ENHANCED_QAV; =20 if (adapter->fpe.mmsv.pmac_enabled) tqavctrl |=3D IGC_TQAVCTRL_PREEMPT_ENA; =20 + frag_size_mult =3D igc_fpe_get_frag_size_mult(&adapter->fpe); + tqavctrl |=3D FIELD_PREP(IGC_TQAVCTRL_MIN_FRAG_MASK, frag_size_mult); + adapter->qbv_count++; =20 cycle =3D adapter->cycle_time; diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.h b/drivers/net/etherne= t/intel/igc/igc_tsn.h index a2534228cc0e..975f4e38836e 100644 --- a/drivers/net/ethernet/intel/igc/igc_tsn.h +++ b/drivers/net/ethernet/intel/igc/igc_tsn.h @@ -14,7 +14,7 @@ enum igc_txd_popts_type { DECLARE_STATIC_KEY_FALSE(igc_fpe_enabled); =20 void igc_fpe_init(struct igc_adapter *adapter); -u32 igc_fpe_get_supported_frag_size(u32 user_frag_size); +u32 igc_fpe_get_supported_frag_size(u32 frag_size); int igc_tsn_offload_apply(struct igc_adapter *adapter); int igc_tsn_reset(struct igc_adapter *adapter); void igc_tsn_adjust_txtime_offset(struct igc_adapter *adapter); diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c index ad9b40034003..4c395cd949ab 100644 --- a/net/ethtool/mm.c +++ b/net/ethtool/mm.c @@ -153,7 +153,7 @@ const struct nla_policy ethnl_mm_set_policy[ETHTOOL_A_M= M_MAX + 1] =3D { [ETHTOOL_A_MM_VERIFY_TIME] =3D NLA_POLICY_RANGE(NLA_U32, 1, 128), [ETHTOOL_A_MM_TX_ENABLED] =3D NLA_POLICY_MAX(NLA_U8, 1), [ETHTOOL_A_MM_PMAC_ENABLED] =3D NLA_POLICY_MAX(NLA_U8, 1), - [ETHTOOL_A_MM_TX_MIN_FRAG_SIZE] =3D NLA_POLICY_RANGE(NLA_U32, 60, 252), + [ETHTOOL_A_MM_TX_MIN_FRAG_SIZE] =3D NLA_POLICY_RANGE(NLA_U32, 60, 256), }; =20 static void mm_state_to_cfg(const struct ethtool_mm_state *state, --=20 2.34.1