From nobody Sun Feb 8 10:22:00 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC32B189BBB; Wed, 5 Mar 2025 03:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146282; cv=none; b=hw6RT9nXzhA2ANkPwYY65HPbiw1of5GRTnc2gN8XegCi2rnwskSqHXhEpn6ST3+AIuaJnRk0vktSEVqFOaF8eCwaMHxmf03gj0niuUV1ZcRc4pJNyzyxnjMyUitw3Trs53A6PVOdEH/AQfvS8+reGyTNzZJl3j/yFDFzh0rrBVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146282; c=relaxed/simple; bh=KC3evV8+E4TMmXJsaHaV+xF+Zlwo3/sRwLFbnpUYLeo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WXOXlg6SkDK5Qm/BNTzAxr+gVPvqNVXIUW1nmnTscLn8cjnZi46OZlM5f2XWuBcZ3y3ed7h5HftqrmTUw3Z6nVd8XvhLlrLO+Nrxod6AL/mBEZH6wYZIAqiA+1oJLGGpiGhJvgDWagjRtjtysU9c4UrAiH3hdIsjNFb6rsYoJiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LnbeATC2; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LnbeATC2" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2233622fdffso119430735ad.2; Tue, 04 Mar 2025 19:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146280; x=1741751080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=LnbeATC2RRqM6hf/Su7vMiom9zxS7u8gBjYWbLYBDYxhIi9CNdYWvsczXjn3AIheO7 tWqTVyFWTbVAVdl5FS7agyhrTPl5E+jra3SvxC4onija+CoG1k1Xi8nuWW4WCdLxjtHb TMf5APyjQ8mgekR46rvJhuF5hKI3EHMguHDN+WVUXDtGdBXdcNs0036ujQB8fTvgKA8N 7D7jE5RNm00aXqhKjkI1qX1ZfTmIipszKGhhwLCuQdPK8gyTi3AFfAOPiUK2JyTzJBHU fuplOqo4NjrXGiGAk8ENo9O5JdJ8A11PvMNlqi0DbTj1cgIKDSWLudy3Q4VeJVXa9XNZ NbcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146280; x=1741751080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=Xzrn5mlBTrW/GqkxhZdzf/dffjzurZm6aY6xcmormJl/FT19AEknFEhj4/0LypkDoc J+4LKQQZBrPaoFlK1Zqh0fHDS4S/vpbwz5MLJLnQd3gvcUgkIl3DdjiGrEhwXGMsU8dw HmfjI0sJZU3c1ozbgVxzVMOOGuIfuYOrps33VbmHizo1UF0GmJo48Tl9qeZapNVqemca enHzXnAtTNvLhOOOTS5mb0tVgM9gcw+NcVqIdHzuYKZs8pij0eV6kDCzh7/IGr1JdoTy E2XG/aszYloDHCYKyxZ04/5GriI1n3Pr9rJOPLZCr3HcenRxcoVtceoxZvmRSng1lnss OXIg== X-Forwarded-Encrypted: i=1; AJvYcCXNKOCgWGJTPAP+is1ItOC3H8fah9CCd3bBAPQwZZmgetMvf5wU9l0d9HisXPGsdYx8wlpVyYQj3Phc@vger.kernel.org X-Gm-Message-State: AOJu0Yx+Kk+KfNwU5dm34iGKQlG479fpUeVQ5tbKBZhHRTHYFox8Hyi6 uEedMukCYiHTWc2YKRhpl2y4SzIbjOHPKJjMbUbjZxD07khWfP0c X-Gm-Gg: ASbGncsk3rQCknj/Nn8IdgMn5u3bNRtkSjQW705FizmsTgL0PCH0GJcesmNOHSQGul4 D04csK5yPpk6PgteumBTajGqbZC22RvjeYPf4gz9MiH1P2Xz8qN+AgTclQUXphjBFPye1BrJu/V ciQVEQbTWbvaN/eAUogpUc2fd2J3WcN2mEOW8JSSW/0dqEHIYtALGWibJsLMn0ki+/ygjAE9qD0 e4BZjdTxCxATPuJIxm+vNkdRxG0SHI+jAnchXhIkoLlAGLJlsQVwLg12qhX4B4oavvG6M2rmJO6 SV6UWwYKos3jbDXsVzblYz+G2JRVUySWX3aEviOwt7AufAx0ThXsNcc= X-Google-Smtp-Source: AGHT+IEtVqtQQnVo8PHaSXN1K3Sc2Cf8P+sKm3QdUVwoE0JuCrOF0cXwevOrjax0u+LApJLfkKso+w== X-Received: by 2002:a17:902:ec82:b0:223:5c33:56a8 with SMTP id d9443c01a7336-223f1d26109mr25099565ad.35.1741146280016; Tue, 04 Mar 2025 19:44:40 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:39 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 1/5] dt-bindings: i3c: silvaco: Add npcm845 compatible string Date: Wed, 5 Mar 2025 11:44:10 +0800 Message-Id: <20250305034414.2246870-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Need to add a new compatible string to distinguish between different hardware versions. Reviewed-by: Frank Li Acked-by: Krzysztof Kozlowski Signed-off-by: Stanley Chu --- Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml = b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml index c56ff77677f1..4fbdcdac0aee 100644 --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml @@ -14,7 +14,9 @@ allOf: =20 properties: compatible: - const: silvaco,i3c-master-v1 + enum: + - nuvoton,npcm845-i3c + - silvaco,i3c-master-v1 =20 reg: maxItems: 1 --=20 2.34.1 From nobody Sun Feb 8 10:22:00 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7CCD18DF8D; Wed, 5 Mar 2025 03:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146285; cv=none; b=hNTvTtSs+88XhyO5QPEE534Lpb34HvPg5E8wKkp4wAUUiKvMm5GOPX/dkgCueaApWPNituONzGvE3FYrsp+JSTVrm6sMDAiBmiQM9TsgwDyDu3HB7IO72OEdp/I697Rof97AB31o5c477LrQZSX0Row6VkB//MY7vIoIHOr7xP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146285; c=relaxed/simple; bh=FwM1Ixf0fNp1sGAgh6/aGjBRduhxfLm9u0al2RJZu2U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kw1FibGFVENvN8eDw1A1RdLs55lrMTdmATLBM3GVmsMz9ZYDfOhJxpwnRVkkmjz4wkBAN1e4eimn0qJlUacEfiaQrhPncAjK6Z45SFxRO/yLJmcu9mpoXn3WnwyzJwATfL70zoG5nwqG1qax9nchA/hp3OXW7K4R8GZpxecjaS4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L7gF/zpK; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L7gF/zpK" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2238d965199so62610605ad.2; Tue, 04 Mar 2025 19:44:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146283; x=1741751083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VxSorQjSMBJHTcXavhQOvOimi4+hQN1XV3dQDpeZRl4=; b=L7gF/zpKFpBWbWIK1Nda4TP3esmfJncSxJZS8YG8aSUPG4p6JKU90JGjNyac+qlRqg 5JUA1s31eAhnFeFhyxKrz1TH8vp4rW1lccVKGFXT3G3W4Mhksc7HD5BW0ujv21W8ucEy d1V2QVgpEs6c3K8/uK2+b1Cay32Jy6fVlvhvOHN0zy7scLOqjJjg5ZDEEKrcrePaPBl9 5GF7b0t8oCcqyQ7Ga3+ZPHBN5YfzaMzKnSWGoQAxc3wRNyjtU3kmsPE/G3byKjJhnXOV r470mhdhvs4KJKsW+KFD3o95MgDuwT0+O4un4WeS5GJCBV5L7x7k2OH1bb9KHhPR3GC3 gttg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146283; x=1741751083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VxSorQjSMBJHTcXavhQOvOimi4+hQN1XV3dQDpeZRl4=; b=Q/9WDLKWabD7hVAhlz+RhN9iKH0REenvcsbNLIbY7AWJqzQGpO8EfgbaemOdiviiw2 4G7LIocmjKd1JtPR2uVZ6til8jTLgFF9SGLPWb0Gp+zQ7+XFMbWhLpzZug4fljlzofxt Os5IdKoSefAAxi4/F8XTm4Rvtffp1X7NHzE4bluPBXBBWWXGs9W8CZ/w1BfwAt/9zfKY SEbEHGP5uduVG0rjx9O31pSYhvvZJTYWs6xx2hXTaKLOSJ29Xw/nPtvDHtd9TyoR2Bki gSGbQHmnfjj8Nt0q+/w8vzf9EIKvJTQbhntaJkuef83toe9DMyvkM0dYvpbj6whHdyVj ovhw== X-Forwarded-Encrypted: i=1; AJvYcCVHr7N7IEWHwUlL595NBPOe+LKabrVwBacGf6Xt7raV0D1pMgNWyR5kue6il3Nu1vWJDawOsPr9DzlS@vger.kernel.org X-Gm-Message-State: AOJu0YxkLuFC8dJ8zqsWkvw7SiHc7YxWiGoyrv2dYmqn58Mi2eEPb5jC VgtJSEamwptphb1HmseOImfkGVHfyPJgLnHs4LCN+uaCpmf/FYIs X-Gm-Gg: ASbGnctB0o1G3o51BAtdXExTNczR9Gw8q21lVuRU0VL1/nxImfTYH7iMLS639+mWXhr I/RWiWGlkGXpFQOABqnMDgrkNfyqzu8SzSKT69rZlTW5s8U7uEJA71CWVrh9nPDgHjvQPIDPZju TMMucX7hep2MHTNsaotfpHr55WnjUcYpK0BEJhSy+tu52FK+FFSNWRU98ovEx8q2R+dXpXgxLS+ DpkMq+FPaa9afkdsxt1H4EQoNx7oRucS3iB46WNn054nwfaIFNl7UiHz+LG7hi6YeZE+C6r0b4E ZDPkZap90DkncpkxWNI4ee2bY899OWUg/frM/sQ65UC5gGtmoQR9P9E= X-Google-Smtp-Source: AGHT+IEN4FhUYURRgYRRhgTu3XPVnsiW8vehuNjd+QA5rMsT8ISHbmnMzH5qpu1A6/3fHjlDi0Nr1w== X-Received: by 2002:a17:902:ec90:b0:21f:4c65:6290 with SMTP id d9443c01a7336-223f1c7d39emr24886825ad.1.1741146282851; Tue, 04 Mar 2025 19:44:42 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:42 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 2/5] i3c: master: svc: Add support for Nuvoton npcm845 i3c Date: Wed, 5 Mar 2025 11:44:11 +0800 Message-Id: <20250305034414.2246870-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu Nuvoton npcm845 SoC uses an older IP version, which has specific hardware issues that need to be addressed with a different compatible string. Add driver data for different compatible strings to define platform specific quirks. Add compatible string for npcm845 to define its own driver data. Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index d6057d8c7dec..7cafdc8fd1ad 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -158,6 +158,10 @@ struct svc_i3c_regs_save { u32 mdynaddr; }; =20 +struct svc_i3c_drvdata { + u32 quirks; +}; + /** * struct svc_i3c_master - Silvaco I3C Master structure * @base: I3C master controller @@ -183,6 +187,7 @@ struct svc_i3c_regs_save { * @ibi.tbq_slot: To be queued IBI slot * @ibi.lock: IBI lock * @lock: Transfer lock, protect between IBI work thread and callbacks fro= m master + * @drvdata: Driver data * @enabled_events: Bit masks for enable events (IBI, HotJoin). * @mctrl_config: Configuration value in SVC_I3C_MCTRL for setting speed b= ack. */ @@ -214,6 +219,7 @@ struct svc_i3c_master { spinlock_t lock; } ibi; struct mutex lock; + const struct svc_i3c_drvdata *drvdata; u32 enabled_events; u32 mctrl_config; }; @@ -1817,6 +1823,10 @@ static int svc_i3c_master_probe(struct platform_devi= ce *pdev) if (!master) return -ENOMEM; =20 + master->drvdata =3D of_device_get_match_data(dev); + if (!master->drvdata) + return -EINVAL; + master->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(master->regs)) return PTR_ERR(master->regs); @@ -1958,8 +1968,13 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { svc_i3c_runtime_resume, NULL) }; =20 +const struct svc_i3c_drvdata npcm845_drvdata =3D {}; + +const struct svc_i3c_drvdata svc_default_drvdata =3D {}; + static const struct of_device_id svc_i3c_master_of_match_tbl[] =3D { - { .compatible =3D "silvaco,i3c-master-v1"}, + { .compatible =3D "nuvoton,npcm845-i3c", .data =3D &npcm845_drvdata }, + { .compatible =3D "silvaco,i3c-master-v1", .data =3D &svc_default_drvdata= }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl); --=20 2.34.1 From nobody Sun Feb 8 10:22:00 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B32219068E; Wed, 5 Mar 2025 03:44:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146288; cv=none; b=Ah7G7EWFNx5Zu+auP/q9dAo9EC3HXHv1Ot236JbC5P2F5G2YWYDsAMlS9yS/mzc3RZz+jqtyhSgkDhFP+JPxa91j6/+OtAwH6hiW/XXZOIf01yiEEWLxEmjOmZzdIc8zlujJs0z84OKfmSsM+xCiecamyy94PsI3X7YqYPU3C5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146288; c=relaxed/simple; bh=iecFRRQddV3zIspJB1emZmnoR5LziWLenNDIFNA16Kg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IAbR7+rOnliAxq+6K32+MkpJPYROP4Oil/xob5cjuOt6kDsWqzwRnX+6MBXLni4Afye0O5/aA0hxb/xO++jFYuLYM0Aqkv1NtgkGc4zE3poFY+AGKrmq1nFGPTk7sq2s1XviihQctjcHV/luPURQsW9B1P7kxjLvYzRk4unBZM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BrHw848X; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BrHw848X" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-22349bb8605so122796845ad.0; Tue, 04 Mar 2025 19:44:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146286; x=1741751086; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K5XgaLNVCOBJH6qLNdTYPllzrDzuWjs4hTrWU2in37A=; b=BrHw848XMc5XVHdHBCExEXxM0GSWzuuIBHrTqqZn/18l+zTl/nIPD0+osiK2TxrbOF s85DXxR3YFlHFhYw5jFU/TGUDLZAMHjHlJSDwbzP7bCFgdsi51WW7tB58sjrRfuzNZTI 4eDvPZ5EEvrJUUUG2ucOMeSgKgwOa1S/ekTZTTb6DrkSWvoFgDrbb7EXUkQ3SOk/PNWV /X3mYhDlQ/yr1lZfCojAyhOC5d+HAzMU10p+KAiepWIygHP0LUmTnCA3MQAwHMolu3xj jmtJXl0zTLpDkjcIMIKCFNir1+/vtGkrbSKZZQsD3XT4MJm5JIPsTHwQdRU6m+GFDCTG QIgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146286; x=1741751086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K5XgaLNVCOBJH6qLNdTYPllzrDzuWjs4hTrWU2in37A=; b=LZhFTGt5OjOkJfhvZ/eHLwMc/s1vG04FIb6+5cF9WL2nyf6mi1bDwTK4tpUHyENkxP krddpYFl2Gh2G5J9jPsLIK75IjWMB9aO/E/tG3JtDJsLiaAEd3vRsger/HEIRpwCU2nx kDRBRNZ9dvPHK+jTNX8yry2ZO2QMvQUBXdMAjOrn6b4qx+jlarq87NqpuxyyaSftG9uq EdOqmGDU4Jgj5r1DIZzfY1zHHsxPnMcTPiPYQ8II3aj9UhrTR1+84vDYK08uMGFwS5XA Vtdy7faq8Vk+95jdMIQoBXGtXUYBlct/k9fjJvvjssGKAGO4r9D6TkkGpShnkYHxO4vk vRXw== X-Forwarded-Encrypted: i=1; AJvYcCWvVQBAJ2BPATzQrZLoKtwuiRr7MgrcqBV0UuW4igi+/ytRL0ALmQrSHZdJXRHuDlfHNzhxoEn3EK8M@vger.kernel.org X-Gm-Message-State: AOJu0Yz91jfW3CvpTUflxIn1cgCMt5ELeowwt8PcXoKjfQYsO+5u+0fy UpXxKSuTpZM2QnSWXmrjnagz3+7OdfoPUjNf7+C15ep74+rkqOCB X-Gm-Gg: ASbGncsBcMLOvXB7AJsogunq8Oer4g86glJiw+WuDjZwdVZJOrCu7yXrvZC6xrY0OY2 m0erHg6ejeOlHNiZECbFmme1jBPIqLHzRsefEYqmefZADvyp95SIpCIeHvswhvCdFlna/rvfifK SCBnnJlOIWQiT4DLTeEtSaIb6/uUVahFV+wcKr6JJfhHj5n/NnQfaIDk68w+hfPyDn/qHcQQBrq ayLKRdZDD+lgtKZJpLS7Pc1HBpi6IpDCHVvAh793lPdVUKjfZxv2MSHrV/6u3tdqSIlav8H/kjb SwduQbMm6pNZlXXmQX5BTdnYVGGQONb1ximTD0bdjEJOyQ2dgdDfXiw= X-Google-Smtp-Source: AGHT+IGPoR5eAIQW9xdEo8WStH1w40nmyMmwzBz1XdEZxtqBN5FLjqj3BW1bdcFkkK22otVnGbjCBA== X-Received: by 2002:a17:902:ecca:b0:215:8809:b3b7 with SMTP id d9443c01a7336-223f1c6b194mr22922005ad.7.1741146285606; Tue, 04 Mar 2025 19:44:45 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:45 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 3/5] i3c: master: svc: Fix npcm845 FIFO empty issue Date: Wed, 5 Mar 2025 11:44:12 +0800 Message-Id: <20250305034414.2246870-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu I3C HW stalls the write transfer if the transmit FIFO becomes empty, when new data is written to FIFO, I3C HW resumes the transfer but the first transmitted data bit may have the wrong value. Fill the FIFO in advance to prevent FIFO from becoming empty. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 71 +++++++++++++++++++++++++---- 1 file changed, 61 insertions(+), 10 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 7cafdc8fd1ad..46b032b61f3c 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -113,6 +113,7 @@ #define SVC_I3C_MWDATAHE 0x0BC #define SVC_I3C_MRDATAB 0x0C0 #define SVC_I3C_MRDATAH 0x0C8 +#define SVC_I3C_MWDATAB1 0x0CC #define SVC_I3C_MWMSG_SDR 0x0D0 #define SVC_I3C_MRMSG_SDR 0x0D4 #define SVC_I3C_MWMSG_DDR 0x0D8 @@ -133,6 +134,16 @@ #define SVC_I3C_EVENT_IBI GENMASK(7, 0) #define SVC_I3C_EVENT_HOTJOIN BIT(31) =20 +/* + * SVC_I3C_QUIRK_FIFO_EMPTY: + * I3C HW stalls the write transfer if the transmit FIFO becomes empty, + * when new data is written to FIFO, I3C HW resumes the transfer but + * the first transmitted data bit may have the wrong value. + * Workaround: + * Fill the FIFO in advance to prevent FIFO from becoming empty. + */ +#define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) + struct svc_i3c_cmd { u8 addr; bool rnw; @@ -236,6 +247,11 @@ struct svc_i3c_i2c_dev_data { struct i3c_generic_ibi_pool *ibi_pool; }; =20 +static inline bool svc_has_quirk(struct svc_i3c_master *master, u32 quirk) +{ + return (master->drvdata->quirks & quirk); +} + static inline bool is_events_enabled(struct svc_i3c_master *master, u32 ma= sk) { return !!(master->enabled_events & mask); @@ -894,7 +910,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_= master *master, u8 *addrs, unsigned int *count) { u64 prov_id[SVC_I3C_MAX_DEVS] =3D {}, nacking_prov_id =3D 0; - unsigned int dev_nb =3D 0, last_addr =3D 0; + unsigned int dev_nb =3D 0, last_addr =3D 0, dyn_addr; u32 reg; int ret, i; =20 @@ -937,6 +953,25 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c= _master *master, if (SVC_I3C_MSTATUS_RXPEND(reg)) { u8 data[6]; =20 + /* + * One slave sends its ID to request for address assignment, + * prefilling the dynamic address can reduce SCL clock stalls + * and also fix the SVC_I3C_QUIRK_FIFO_EMPTY quirk. + * + * Ideally, prefilling before the processDAA command is better. + * However, it requires an additional check to write the dyn_addr + * at the right time because the driver needs to write the processDAA + * command twice for one assignment. + * Prefilling here is safe and efficient because the FIFO starts + * filling within a few hundred nanoseconds, which is significantly + * faster compared to the 64 SCL clock cycles. + */ + dyn_addr =3D i3c_master_get_free_addr(&master->base, last_addr + 1); + if (dyn_addr < 0) + return -ENOSPC; + + writel(dyn_addr, master->regs + SVC_I3C_MWDATAB); + /* * We only care about the 48-bit provisioned ID yet to * be sure a device does not nack an address twice. @@ -1015,21 +1050,16 @@ static int svc_i3c_master_do_daa_locked(struct svc_= i3c_master *master, if (ret) break; =20 - /* Give the slave device a suitable dynamic address */ - ret =3D i3c_master_get_free_addr(&master->base, last_addr + 1); - if (ret < 0) - break; - - addrs[dev_nb] =3D ret; + addrs[dev_nb] =3D dyn_addr; dev_dbg(master->dev, "DAA: device %d assigned to 0x%02x\n", dev_nb, addrs[dev_nb]); - - writel(addrs[dev_nb], master->regs + SVC_I3C_MWDATAB); last_addr =3D addrs[dev_nb++]; } =20 /* Need manual issue STOP except for Complete condition */ svc_i3c_master_emit_stop(master); + svc_i3c_master_flush_fifo(master); + return ret; } =20 @@ -1226,6 +1256,24 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, SVC_I3C_MCTRL_RDTERM(*actual_len), master->regs + SVC_I3C_MCTRL); =20 + /* + * The entire transaction can consist of multiple write transfers. + * Prefilling before EmitStartAddr causes the data to be emitted + * immediately, becoming part of the previous transfer. + * The only way to work around this hardware issue is to let the + * FIFO start filling as soon as possible after EmitStartAddr. + */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FIFO_EMPTY) && !rnw && xfer_len)= { + u32 end =3D xfer_len > SVC_I3C_FIFO_SIZE ? 0 : SVC_I3C_MWDATAB_END; + u32 len =3D min_t(u32, xfer_len, SVC_I3C_FIFO_SIZE); + + writesb(master->regs + SVC_I3C_MWDATAB1, out, len - 1); + /* Mark END bit if this is the last byte */ + writel(out[len - 1] | end, master->regs + SVC_I3C_MWDATAB); + xfer_len -=3D len; + out +=3D len; + } + ret =3D readl_poll_timeout(master->regs + SVC_I3C_MSTATUS, reg, SVC_I3C_MSTATUS_MCTRLDONE(reg), 0, 1000); if (ret) @@ -1314,6 +1362,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, emit_stop: svc_i3c_master_emit_stop(master); svc_i3c_master_clear_merrwarn(master); + svc_i3c_master_flush_fifo(master); =20 return ret; } @@ -1968,7 +2017,9 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { svc_i3c_runtime_resume, NULL) }; =20 -const struct svc_i3c_drvdata npcm845_drvdata =3D {}; +const struct svc_i3c_drvdata npcm845_drvdata =3D { + .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY, +}; =20 const struct svc_i3c_drvdata svc_default_drvdata =3D {}; =20 --=20 2.34.1 From nobody Sun Feb 8 10:22:00 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E443192D6B; Wed, 5 Mar 2025 03:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146290; cv=none; b=UNThTrZ2pF6EbMmZ0PdM64wJRJzGDnGcOt6iSYKgyW8K04F8aD3u+Sr36gc9YGaKRhZuPzbhGnxSuu3Ld7IGTDmjFrCcPQHvH6qwP1kyIYJYIzx/0wXQVtlr4X6+H+0GTiqJXMjsFPDd6PrEgwLOXn7u18q3patyalePdpQtoHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146290; c=relaxed/simple; bh=mIk0IRH1OW9MDPjRzX0QhIQFS2iXhEpe42K081Z5Vxc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AsCHftMfWJW2pyNqDb0/uJHzX92FXpHYFuFmpa+3wlceWRX+zlMPHKPXrMmy8tymjvUGSpIhBoFplMYEgpWYNVTUQj7lHOhrSfXGwlPYDJNrPfo1Z3ht8/j8gnjjV6EKH0EVqq796jZJk/OG93AErP5q8ljAWQfAhSx6/hoTxrQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=To067iNB; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="To067iNB" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-22349bb8605so122797105ad.0; Tue, 04 Mar 2025 19:44:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146288; x=1741751088; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rWiOwn7nT5PFN7bTmIow5wbcXHHUl8L4grOIfv03884=; b=To067iNBBLYIgHQnrLXQS9rjKlrCFAE+bsFvJRlJDNwDBW4a99VJWSqaVL+ZNlz2K9 b+XJQgYo+NLYq/X2I6o29Jtn/fOdGgDY5HENOPUWzm+X/ED85BqrNBNTwJYkkv36P2II zRc09igp+BxDPuFXM0izaz5zc+LpMFfVxUR9sUqgRzwJu3oaMOOR/DvJMcT8HBffVFuQ hGkyKG7SeZOyvxqauXUvzGE3X63IyTHWNfkFMZyY8WTk2Y+R/Nq2RyYzdBePYcgNxMmM GZH6zs0QeIe3lXU/TMtBdBX6AMmGQSwLGRpGqFaOVB+gNwx0KGnkIzpUwTR99HbsvdKZ hz7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146288; x=1741751088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rWiOwn7nT5PFN7bTmIow5wbcXHHUl8L4grOIfv03884=; b=ZPCQ5qcZI6dvP1rGR3xK1yjAsgec4W/7eHtWyXOIkoctEvXhW6FIKOEuOUaQ0GlZ8i I/dWLRw2GZir+y7uIyesFWE2n/qmH6AWlsbFUrtDeqe3nR4KhI4Zltz66g8fOWmMJGEJ NNgIGG0wQ6UPqD20dTzRUCep/3HDxuqhMCnzh+w2uhtacGIXMfo49DAZDrDy/pOIVKzU K6u5SSOwB068G2RWgGwxIp9JesIkG1YjCPeJh1D7moH/NMEl7tGeLqjnRjuLrn4xPh6l +zdzYlNNBKG/2MZZpr5v30Rzb8/d49+6F+hK5H8eJMiwO3M5ui5Q4b2dIbVXGaZEpNLP rfmQ== X-Forwarded-Encrypted: i=1; AJvYcCU0d+6roE4UjyOxJD4KN4wg2hP0i5uCbv585uD9MbZAiG8eCRt2b262h64KPQry+Dw7Qtzr50mauZxE@vger.kernel.org X-Gm-Message-State: AOJu0Yxy9W0yQsvdGlOoF5F7H3ugi7cGmQnS+CoXCo/80KXlzMqmJUmX Odaeb9sUYA+Lylfb8O3BRi10zHZg5olKKebdlADGXyztj61gK09e X-Gm-Gg: ASbGncsNVP90iB0Z9QAPHemud52tGMX7iLzc6uyPiiIDTM3jtuyD1xe6exzkKTc4jAb 7SmW83STuqqeKuKG/mtlkmU6hrm2qObjzyb7gENOt0YffclrA4dsgo3wLT8a48BYWHxKj4j2+qy VbYmsmg0RGbvXkP0LH/F2z5Sp1KvntXxFVR/rVGNiR6RiODJK04/98upXKE6ET+RnkqEgmnew6t 10LQUi1cWftXO4x48/JIMSfEVClgAZ7pdo0xVOgv5fSUn7S0WsYvN/kAGdCGYWEkjepa4CVJ+D6 8olRGAoBbfuevfMad9E1vJpma0dOTBMU3I269/KBgY+0J8Tb+pMsra8= X-Google-Smtp-Source: AGHT+IF6e7ShP+dFYnCi3KFWoYYWdUXK08szUlSs8mu7o0gUCi5hQ15jqTxbMjAROfk9XAz/T2tSVg== X-Received: by 2002:a17:903:2312:b0:21f:9c48:254b with SMTP id d9443c01a7336-223f1c9945amr28241945ad.24.1741146288312; Tue, 04 Mar 2025 19:44:48 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:48 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 4/5] i3c: master: svc: Fix npcm845 invalid slvstart event Date: Wed, 5 Mar 2025 11:44:13 +0800 Message-Id: <20250305034414.2246870-5-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu I3C HW may generate an invalid SlvStart event when emitting a STOP. If it is a true SlvStart, the MSTATUS state is SLVREQ. Check the MSTATUS state to ignore the false event. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 46b032b61f3c..5c29912e0a69 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -58,6 +58,7 @@ #define SVC_I3C_MSTATUS 0x088 #define SVC_I3C_MSTATUS_STATE(x) FIELD_GET(GENMASK(2, 0), (x)) #define SVC_I3C_MSTATUS_STATE_DAA(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 5) +#define SVC_I3C_MSTATUS_STATE_SLVREQ(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D= 1) #define SVC_I3C_MSTATUS_STATE_IDLE(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 0) #define SVC_I3C_MSTATUS_BETWEEN(x) FIELD_GET(BIT(4), (x)) #define SVC_I3C_MSTATUS_NACKED(x) FIELD_GET(BIT(5), (x)) @@ -143,6 +144,12 @@ * Fill the FIFO in advance to prevent FIFO from becoming empty. */ #define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) +/* + * SVC_I3C_QUIRK_FLASE_SLVSTART: + * I3C HW may generate an invalid SlvStart event when emitting a STOP. + * If it is a true SlvStart, the MSTATUS state is SLVREQ. + */ +#define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) =20 struct svc_i3c_cmd { u8 addr; @@ -586,6 +593,11 @@ static irqreturn_t svc_i3c_master_irq_handler(int irq,= void *dev_id) /* Clear the interrupt status */ writel(SVC_I3C_MINT_SLVSTART, master->regs + SVC_I3C_MSTATUS); =20 + /* Ignore the false event */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FALSE_SLVSTART) && + !SVC_I3C_MSTATUS_STATE_SLVREQ(active)) + return IRQ_HANDLED; + svc_i3c_master_disable_interrupts(master); =20 /* Handle the interrupt in a non atomic context */ @@ -2018,7 +2030,8 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { }; =20 const struct svc_i3c_drvdata npcm845_drvdata =3D { - .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY, + .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY | + SVC_I3C_QUIRK_FALSE_SLVSTART, }; =20 const struct svc_i3c_drvdata svc_default_drvdata =3D {}; --=20 2.34.1 From nobody Sun Feb 8 10:22:00 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FBFE18A6D5; Wed, 5 Mar 2025 03:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146293; cv=none; b=LYlOo5Yj/0cYBif3kWrA2xJ1TBzlVvcSBlxcqqNiHYVqNkKfEZIdHhrH7HvYYrBz3BqPQJOJYoWsqoAyhzi39yO6aA1MtcwAFibkaowkNN5qnv+mQY1wku9gKSNqsoAtqJejPIlggdNLFE5XPDR1ue4QNpddEMiT/zPn9Mchw94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741146293; c=relaxed/simple; bh=G6B56ZsAoR/bIh1JopEk7s/pj+lVV13//00JyF8B6Qo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uVOfMXPJJigAlHpTT45Fl4BsC/PguCb8kkHVXmjs5B2LOWXo7kRTSZGR+zQ40GVYLzHB/D8BDRT/73equKREwDbYx1KYXAmf3hw3UO0ZcIe2XMS0GfQ693P+AHKd0oBHoJ0GxjFggazJBp6akxrWIxGbnyV3zGA4xTJPekAuTeI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ng6AnIrA; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ng6AnIrA" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-22339936bbfso94647325ad.1; Tue, 04 Mar 2025 19:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146291; x=1741751091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FSYH5+SwcmtCe+p0n+lRYfrltYt+gVN39RZaCf2MCi8=; b=Ng6AnIrAIhRf4cqhhF10DZnupgtIbc66jh/XZx8DHsFA36VePuYxT9NpP6nArZeD2n yOa+S7SWx6OT0m+RAHsKaLqfmwqmNwxoIQgyYXp9UDhXKKN33Xopu1GSofHyImDblHMg CpXrDMuPxLpNYCKX0frGW0lWjr3hslJWXw4hmIfuR495m0us27Du4d/Z3D+bXNx1Sroh /GQ2MkaWndc4f0GCeZ+sXDII6PpSH37QwjxyrsjC8Nm2weGkQi3+4PMEmT1j53ZBGJ/0 YfjgCIa7I3bHXP93js+Eqz4ZGbwo4dpkfUQeNrl6AqQ+kWEESnclZi/dZxSLAAQs9JXJ CpMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146291; x=1741751091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FSYH5+SwcmtCe+p0n+lRYfrltYt+gVN39RZaCf2MCi8=; b=uY9ENssMDJ5kSg6JIUwQwq8iBmjyrmcJL4N0LtDuMKyKjBDSXaRUPuZqYVP3ZNLdHU vbNUXV9ihSX4SPsosDM0dfv0DchqDbWRaN19UWO7jGXKYyQlSAbMCUC/41YQG4Ju5kIj uf3ad+ihx1HmyON0CO+etQ+W/8nwvzIHPbmHGJNxYfniL/rHqzA6k6ovd2me6JT6GOMI uP5v3K6E95ITHjlSE3Ihc5yr3NN7HHIzxK5SE3oZBUOao+RajpH+Yft0CcGzsSLn3vC+ CGIZSezJSknPisZZT9EzBsSUEyCYAn1tZEx0mvb22eY+QfcKi8zAZo7vtfbbUi23rNmb WfDQ== X-Forwarded-Encrypted: i=1; AJvYcCVVOHtXa9jXE8N8nX5GRgiFPTi/29UIv6xVpmUgULlkFfOTLsOjNLE36s4EAkqM4SjkIEcxu6IDyf1h@vger.kernel.org X-Gm-Message-State: AOJu0Yxc1L/upqkSeY/k8h0/It2ywMZShaHVWmeekzVcRQ4PefMF8PSn SJrpWo4+RM4n7mtfDTB+j63+F9STYptgUSywpHSLrStCP/WFouJ7 X-Gm-Gg: ASbGncsYH6jY5dQGcR9TxUSPn8cvAx9wOczdjHGYVCUP8xSq8dudPB05ywnQAiPYEov 9SsasH1cKklcl5oHOLaSeDwQszb0bhJpi0/3+yWeRzZxXeqM/WiL9/q4VPz5coWMCUadC/SIKFN LJfiLgelD4InRXd6urjnHcSnaxoJcAijTpRuJmlMedNIKMa+4zUVa3OZu+b5aJcMmHIllmcn3IL E0IJZLEqKVz91EZJgreq8eo16EZsVZs7YNM9Yv3YW07IU0oS9PVriVzoeftTksfALy6ro8J/Igz 2TDb2Q6zM+nxxYIDPjJuBfyzVmrlB15oIKNxXrXR0ztEzUc8WQ4DJhA= X-Google-Smtp-Source: AGHT+IEY/W5EzK2xQM9ApeNVjlE0dvEXpH3lZiSewWlXGQlloKZ5FWhsNbQOOWfviYkdHfIw/kEpyg== X-Received: by 2002:a17:903:11c3:b0:215:4a4e:9262 with SMTP id d9443c01a7336-223f1c6af8fmr20720365ad.8.1741146291089; Tue, 04 Mar 2025 19:44:51 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:50 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 5/5] i3c: master: svc: Fix npcm845 DAA process corruption Date: Wed, 5 Mar 2025 11:44:14 +0800 Message-Id: <20250305034414.2246870-6-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu When MCONFIG.SKEW=3D0 and MCONFIG.ODHPP=3D0, the ENTDAA transaction gets corrupted and results in a no repeated-start condition at the end of address assignment. Workaround: Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA process is completed, return MCONFIG.SKEW to its previous value. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 30 ++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 5c29912e0a69..df7eb038c6c9 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -32,6 +32,7 @@ #define SVC_I3C_MCONFIG_ODBAUD(x) FIELD_PREP(GENMASK(23, 16), (x)) #define SVC_I3C_MCONFIG_ODHPP(x) FIELD_PREP(BIT(24), (x)) #define SVC_I3C_MCONFIG_SKEW(x) FIELD_PREP(GENMASK(27, 25), (x)) +#define SVC_I3C_MCONFIG_SKEW_MASK GENMASK(27, 25) #define SVC_I3C_MCONFIG_I2CBAUD(x) FIELD_PREP(GENMASK(31, 28), (x)) =20 #define SVC_I3C_MCTRL 0x084 @@ -150,6 +151,16 @@ * If it is a true SlvStart, the MSTATUS state is SLVREQ. */ #define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) +/* + * SVC_I3C_QUIRK_DAA_CORRUPT: + * When MCONFIG.SKEW=3D0 and MCONFIG.ODHPP=3D0, the ENTDAA transaction gets + * corrupted and results in a no repeated-start condition at the end of + * address assignment. + * Workaround: + * Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA + * process is completed, return MCONFIG.SKEW to its previous value. + */ +#define SVC_I3C_QUIRK_DAA_CORRUPT BIT(2) =20 struct svc_i3c_cmd { u8 addr; @@ -259,6 +270,13 @@ static inline bool svc_has_quirk(struct svc_i3c_master= *master, u32 quirk) return (master->drvdata->quirks & quirk); } =20 +static inline bool svc_has_daa_corrupt(struct svc_i3c_master *master) +{ + return ((master->drvdata->quirks & SVC_I3C_QUIRK_DAA_CORRUPT) && + !(master->mctrl_config & + (SVC_I3C_MCONFIG_SKEW_MASK | SVC_I3C_MCONFIG_ODHPP(1)))); +} + static inline bool is_events_enabled(struct svc_i3c_master *master, u32 ma= sk) { return !!(master->enabled_events & mask); @@ -1144,7 +1162,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_c= ontroller *m) } =20 spin_lock_irqsave(&master->xferqueue.lock, flags); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config | SVC_I3C_MCONFIG_SKEW(1), + master->regs + SVC_I3C_MCONFIG); + ret =3D svc_i3c_master_do_daa_locked(master, addrs, &dev_nb); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config, master->regs + SVC_I3C_MCONFIG); + spin_unlock_irqrestore(&master->xferqueue.lock, flags); =20 svc_i3c_master_clear_merrwarn(master); @@ -2031,7 +2058,8 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { =20 const struct svc_i3c_drvdata npcm845_drvdata =3D { .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY | - SVC_I3C_QUIRK_FALSE_SLVSTART, + SVC_I3C_QUIRK_FALSE_SLVSTART | + SVC_I3C_QUIRK_DAA_CORRUPT, }; =20 const struct svc_i3c_drvdata svc_default_drvdata =3D {}; --=20 2.34.1