From nobody Sat Feb 7 22:55:23 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDBBD1459F6; Wed, 5 Mar 2025 02:32:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141927; cv=none; b=OO6V86JDSb7KgV3Ir2jNt/seM/zdwCZTCF9bw1xzOCicLJ6QWV/i/xb79cIrg4sViR3g4txRuCRk1chdE3Dy8avt7hL0YWZj5i+/zr+bjv/6x/Y4oQmsc7ELXQq/JHaNyVPQ4SKQ1blBrcpA5/4JZiTwHxI/Yx37FoOolZCM0vg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141927; c=relaxed/simple; bh=husec6zC4tUCCXa7D4qH5d0n86OjErX8zVMGoZSzfh0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R35hGLbK8zcNwOgyRd0bGxXjuDMMPEwqD23JR4nEhJsc6y3l10DUaXbpS9icWvtV/L08ShJkNVqlY8kD4qxu6kJDpUU7V2BAhb3nvWEuYcX7t5/2N3SAipzfnzsMxKUwvuVa8Mif5FuIrfgj5+mo5FPOtsW89e7cy0iytcVEMc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=l19vOjYX; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="l19vOjYX" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=IJAI6KslVQAVb2DdkL1bXABJp7NmDgP1UiInuoXkB2w=; b=l19vOjYXGlgBq0Y0 jpT5g/LrFyLCejZdOvCVZ6gj2AR93VkUmfOtsAQ97ynBAO6RlR7T/hPGLxTJuX4d6a5ZZxk+xpu/2 Lghqetcss8RaR+8wOvjN3Yz7ULpEXnv8uZg+5B6owi5PO1qWJEMtNPMB4IRGsfEa2eiIQt9dskx8K 9SceZS/Yly8WZ4vP70/QMnNjE4v6xs5pDpsdDD7ygyJDknAIPFOTNy4k9UFxBG2Qywr4cRHpj55mC FBkHJMwAsLVnS7gUl/QCbZF0iWpHkC9SXv1RpdRmQ1wSxQG1pZD+iuGX3P3dhYehOZTvl2bS4SEoC gSZPQbDKvG6rV17teQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tpeXj-002ic7-1Q; Wed, 05 Mar 2025 02:31:31 +0000 From: linux@treblig.org To: irogers@google.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, adrian.hunter@intel.com, kan.liang@linux.intel.com, namhyung@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 1/6] perf core: Remove perf_event_attrs and perf_event_refresh Date: Wed, 5 Mar 2025 02:31:15 +0000 Message-ID: <20250305023120.155420-2-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250305023120.155420-1-linux@treblig.org> References: <20250305023120.155420-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" perf_event_refresh() has been unused since the 2015 commit f63a8daa5812 ("perf: Fix event->ctx locking") perf_event_attrs() has been unused since the 2017 commit f91840a32dee ("perf, bpf: Add BPF support to all perf_event types") (Note the _ prefix version is still used) Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Ian Rogers --- include/linux/perf_event.h | 10 ---------- kernel/events/core.c | 24 ------------------------ 2 files changed, 34 deletions(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 8333f132f4a9..3ed023e63d6a 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -1136,7 +1136,6 @@ extern void perf_event_free_task(struct task_struct *= task); extern void perf_event_delayed_put(struct task_struct *task); extern struct file *perf_event_get(unsigned int fd); extern const struct perf_event *perf_get_event(struct file *file); -extern const struct perf_event_attr *perf_event_attrs(struct perf_event *e= vent); extern void perf_event_print_debug(void); extern void perf_pmu_disable(struct pmu *pmu); extern void perf_pmu_enable(struct pmu *pmu); @@ -1147,7 +1146,6 @@ extern int perf_event_task_enable(void); =20 extern void perf_pmu_resched(struct pmu *pmu); =20 -extern int perf_event_refresh(struct perf_event *event, int refresh); extern void perf_event_update_userpage(struct perf_event *event); extern int perf_event_release_kernel(struct perf_event *event); extern struct perf_event * @@ -1841,10 +1839,6 @@ static inline const struct perf_event *perf_get_even= t(struct file *file) { return ERR_PTR(-EINVAL); } -static inline const struct perf_event_attr *perf_event_attrs(struct perf_e= vent *event) -{ - return ERR_PTR(-EINVAL); -} static inline int perf_event_read_local(struct perf_event *event, u64 *val= ue, u64 *enabled, u64 *running) { @@ -1853,10 +1847,6 @@ static inline int perf_event_read_local(struct perf_= event *event, u64 *value, static inline void perf_event_print_debug(void) { } static inline int perf_event_task_disable(void) { return -EINVAL; } static inline int perf_event_task_enable(void) { return -EINVAL; } -static inline int perf_event_refresh(struct perf_event *event, int refresh) -{ - return -EINVAL; -} =20 static inline void perf_sw_event(u32 event_id, u64 nr, struct pt_regs *regs, u64 addr) { } diff --git a/kernel/events/core.c b/kernel/events/core.c index bcb09e011e9e..c3d9ad84bb52 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -3224,22 +3224,6 @@ static int _perf_event_refresh(struct perf_event *ev= ent, int refresh) return 0; } =20 -/* - * See perf_event_disable() - */ -int perf_event_refresh(struct perf_event *event, int refresh) -{ - struct perf_event_context *ctx; - int ret; - - ctx =3D perf_event_ctx_lock(event); - ret =3D _perf_event_refresh(event, refresh); - perf_event_ctx_unlock(event, ctx); - - return ret; -} -EXPORT_SYMBOL_GPL(perf_event_refresh); - static int perf_event_modify_breakpoint(struct perf_event *bp, struct perf_event_attr *attr) { @@ -13639,14 +13623,6 @@ const struct perf_event *perf_get_event(struct fil= e *file) return file->private_data; } =20 -const struct perf_event_attr *perf_event_attrs(struct perf_event *event) -{ - if (!event) - return ERR_PTR(-EINVAL); - - return &event->attr; -} - int perf_allow_kernel(struct perf_event_attr *attr) { if (sysctl_perf_event_paranoid > 1 && !perfmon_capable()) --=20 2.48.1 From nobody Sat Feb 7 22:55:23 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B28F61519B8; Wed, 5 Mar 2025 02:31:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141911; cv=none; b=hqcZUnwjCR9oNfprwA5f/e8zKI0/v3acVuTooO1IJQasOaGlxlKIVvug1j4/ZDN06asrprbf1rs7qs+wFokaTitVDVUWAnyN+qkW4RhTF8ZHreSE2NETVr8NyUISlhbn+SX1eXBjFlL3vWUTr6PHOmnp0RysTdfLb2EKfDJ6i1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141911; c=relaxed/simple; bh=7fhh67LYhq45a0aUpnYryOepQlK24N1EWs5FHFehNUA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ruzBErPCgZtFfQodRzc+oF2ObrA9d8iHg3ihX45m01xeu/MYCYuwFCX5mcS3SnK9oNdiJn4lHzeZfj8BYpcsNJw1hjJyKSLWAaOiNkIJJxXufmxpptXdpg+M1KowM07pC6lyNBhFaDQbsvslvptV/XiI81/1ujyK2Xe5p4KLbaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=pZr1C1gZ; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="pZr1C1gZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=BgsGMifzhNygoMh7yl563AYJnAUXiTMgUBTo6PD8vEQ=; b=pZr1C1gZxkkM1tzk jji1Kt1Nw9s1XAVBL82fq1ucdmS3vggfDCVfWRVQ11EVckll7XWWnIhVwWd0oZjXpornmTu2nBl4R pzP9G1jInTQrYKfk9+ARouvmPW95wU0G8YEictDfPJ2rnHeOxxw8qKB9j9FOuC4rmljkq5jT2159k Q4gG/FtpzEGdDIMm8Jc3gyLSP6Ou8F82S0SXRl+M0vJMoQrq3153faXz5c8x22yr0VOWxdG4bh/yU J4sydvLA8eGw9+CKAfXhaKoYhcRyftRDwRUS/dI6dOnE7XRfb1UAy4Z3DIOhWjktYCkFG1KDwYnEf EuScZNpM4UIu/JonYQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tpeXj-002ic7-2y; Wed, 05 Mar 2025 02:31:31 +0000 From: linux@treblig.org To: irogers@google.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, adrian.hunter@intel.com, kan.liang@linux.intel.com, namhyung@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 2/6] perf util: Remove unused perf_color_default_config Date: Wed, 5 Mar 2025 02:31:16 +0000 Message-ID: <20250305023120.155420-3-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250305023120.155420-1-linux@treblig.org> References: <20250305023120.155420-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" perf_color_default_config() was added in 2009 by commit 8fc0321f1ad0 ("perf_counter tools: Add color terminal output support") but has remained unused. Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Ian Rogers --- tools/perf/util/color.h | 5 ----- tools/perf/util/color_config.c | 11 ----------- 2 files changed, 16 deletions(-) diff --git a/tools/perf/util/color.h b/tools/perf/util/color.h index 9a7248dbe2d7..0319546decca 100644 --- a/tools/perf/util/color.h +++ b/tools/perf/util/color.h @@ -30,11 +30,6 @@ extern int perf_use_color_default; =20 =20 -/* - * Use this instead of perf_default_config if you need the value of color.= ui. - */ -int perf_color_default_config(const char *var, const char *value, void *cb= ); - int perf_config_colorbool(const char *var, const char *value, int stdout_i= s_tty); int color_vsnprintf(char *bf, size_t size, const char *color, const char *fmt, va_list args); diff --git a/tools/perf/util/color_config.c b/tools/perf/util/color_config.c index dc09ba7cb31e..301031ddc025 100644 --- a/tools/perf/util/color_config.c +++ b/tools/perf/util/color_config.c @@ -35,14 +35,3 @@ int perf_config_colorbool(const char *var, const char *v= alue, int stdout_is_tty) } return 0; } - -int perf_color_default_config(const char *var, const char *value, - void *cb __maybe_unused) -{ - if (!strcmp(var, "color.ui")) { - perf_use_color_default =3D perf_config_colorbool(var, value, -1); - return 0; - } - - return 0; -} --=20 2.48.1 From nobody Sat Feb 7 22:55:23 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4676313D246; Wed, 5 Mar 2025 02:31:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141909; cv=none; b=hZQnwVMWt11rvOqbTv33TPVBiHIP9wF/n1cAazlJ9o54uHYeC2j3OkrXKkxw53MvwKNAfjwFCggMKj6YZ4ZQ4elhb6JyFMlWzFGjKIQKxVbI4yF1P82HqhtcEjoAQlBDAvfN37AWHHGkSSzmva1Knyb5iCoP6dOZA+tosIglODU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141909; c=relaxed/simple; bh=AyUtY8EH5UDNbyxsA8HRMam21nN63MmotaxvrpbIjW0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H4OxPgC6CkXdluPdj4WOu67PvmXjWtyt8ONg0Z5Z7GqMlVpZHnEuuOQjDjSa8cSmL28ZddQyHmAcOKSvoVT3mv3YjF7+j8/yGCmCInD0cbJa8DyV/paWirsPEGJkOXYBMTKp2+54O2ct6qf3UI4NWzX+1ctQvloLDadpCTqYsqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=WgKX1Gtb; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="WgKX1Gtb" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=kh3PdUqQv4yuFnWuzC0+SLXgYE4BaGgxZrXdphcypfg=; b=WgKX1GtbiuLCealw ivaJddyw16qqhG56IqKBFKjkk9qnEWfpdnQU/DSpkvNQD7VMtkKtHq9JKPnklDVZtiTnR7UgQg8Za MRJB5m9/ps3m+Hq3WqcreAHTrKNkeQrNn2rMvzINnW4OlMn7WZejBB0V+g0UPk8PGJgwW5sUb/PqE MFEmdXkKpn4YtIu4TiVm8IX6Ct5CxL2uuEPunLv66PvI3vyb418NKQHOmZEGfM/nuV9zg3zZmER1g GmsFLbj4x9qe4jVQT2lUyA1mp8im7BwJeqEQ9Ieb6TnsZdgmHtdvOWWWKq41VgrQVNSkIlj8h1vrC cPRta8Jb7ypIW7T6tg==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tpeXk-002ic7-1H; Wed, 05 Mar 2025 02:31:32 +0000 From: linux@treblig.org To: irogers@google.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, adrian.hunter@intel.com, kan.liang@linux.intel.com, namhyung@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 3/6] perf util: Remove unused pstack__pop Date: Wed, 5 Mar 2025 02:31:17 +0000 Message-ID: <20250305023120.155420-4-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250305023120.155420-1-linux@treblig.org> References: <20250305023120.155420-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" The last use of pstack__pop() was removed in 2015 by commit 6422184b087f ("perf hists browser: Simplify zooming code using pstack_peek()") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Ian Rogers --- tools/perf/util/pstack.c | 14 -------------- tools/perf/util/pstack.h | 1 - 2 files changed, 15 deletions(-) diff --git a/tools/perf/util/pstack.c b/tools/perf/util/pstack.c index a1d1e4ef6257..141ffa129c69 100644 --- a/tools/perf/util/pstack.c +++ b/tools/perf/util/pstack.c @@ -63,20 +63,6 @@ void pstack__push(struct pstack *pstack, void *key) pstack->entries[pstack->top++] =3D key; } =20 -void *pstack__pop(struct pstack *pstack) -{ - void *ret; - - if (pstack->top =3D=3D 0) { - pr_err("%s: underflow!\n", __func__); - return NULL; - } - - ret =3D pstack->entries[--pstack->top]; - pstack->entries[pstack->top] =3D NULL; - return ret; -} - void *pstack__peek(struct pstack *pstack) { if (pstack->top =3D=3D 0) diff --git a/tools/perf/util/pstack.h b/tools/perf/util/pstack.h index 8729b8be061d..712051b8130f 100644 --- a/tools/perf/util/pstack.h +++ b/tools/perf/util/pstack.h @@ -10,7 +10,6 @@ void pstack__delete(struct pstack *pstack); bool pstack__empty(const struct pstack *pstack); void pstack__remove(struct pstack *pstack, void *key); void pstack__push(struct pstack *pstack, void *key); -void *pstack__pop(struct pstack *pstack); void *pstack__peek(struct pstack *pstack); =20 #endif /* _PERF_PSTACK_ */ --=20 2.48.1 From nobody Sat Feb 7 22:55:23 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E78D71459F6; Wed, 5 Mar 2025 02:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141920; cv=none; b=QWv3FJPzR1SNs36QjNmP1GgY/Thamurr/8o6XrBP+k6cEktYhEyD3vhT9s2P8ckTDz2CipJ6om84mQwvGFV1OtV05T25q33yZHgNyPhWaUkQM9dyOhKsywcCs0mbYquvltdDlKTJsMEtLFujwqPwHh9J4R65a9WyyZnbPj0sECE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141920; c=relaxed/simple; bh=rLOczdifouOnE21lGnWehKPUyymxn3peQNqZvHdvK1Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rZZiLjyhW2534LrjvP3plDINlby6kAaeOPlrqJ3oamMjyCFsDxERR14FqJ8ubAjcugXOeKeFNbtx3fGW+cJhVNN7w30J7qrvL3Tml2jf5UCKXdx3zndc2AF9i/q6gsC1WbJdI+iPxFzSOJwjTA6MT2zszG5/pITv+XNfrhtzTSw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=AIj//zYg; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="AIj//zYg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=1ZNzGNcG5qMwlIr3Iama8mJIXqtu/L/N8tr6WxHkcsk=; b=AIj//zYgpbZUA0/c XcmAH6ecGzUCZekF47D/XE9OV1hvC/K+UfSSNLW5yuthfhrC9Zvgtytcmtx48bx/Yeqz0bH5QL3Z5 bcJJRUZjzESWK7TbMgydTvUB+RLa/W7PcTKnOY+lilJ0G0vNgQCPreMPXAHJEy0998R2Aq774fgWG D86tgNp0wvf5pk3sHNKdWY5hX0DNOVpA9Mnt/RDRipzGLUos1vqCa4xojqZpveoPRFvvfbeWwtyfk X/rrKU35iNdFN52dtnM+8jLca4mL56bm1MBuMxl7wsNXJLdvIN8HuCf9yoZuIPxiRQKiHLry3cnU7 qr3BN2pP2iYWhvxstw==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tpeXk-002ic7-2Z; Wed, 05 Mar 2025 02:31:32 +0000 From: linux@treblig.org To: irogers@google.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, adrian.hunter@intel.com, kan.liang@linux.intel.com, namhyung@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 4/6] perf util: Remove unused perf_data__update_dir Date: Wed, 5 Mar 2025 02:31:18 +0000 Message-ID: <20250305023120.155420-5-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250305023120.155420-1-linux@treblig.org> References: <20250305023120.155420-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" perf_data__update_dir() was added in 2019's commit e8be135751f2 ("perf data: Add perf_data__update_dir() function") but has never been used. Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Ian Rogers --- tools/perf/util/data.c | 20 -------------------- tools/perf/util/data.h | 1 - 2 files changed, 21 deletions(-) diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c index 98661ede2a73..164eb45a0b36 100644 --- a/tools/perf/util/data.c +++ b/tools/perf/util/data.c @@ -158,26 +158,6 @@ int perf_data__open_dir(struct perf_data *data) return ret; } =20 -int perf_data__update_dir(struct perf_data *data) -{ - int i; - - if (WARN_ON(!data->is_dir)) - return -EINVAL; - - for (i =3D 0; i < data->dir.nr; i++) { - struct perf_data_file *file =3D &data->dir.files[i]; - struct stat st; - - if (fstat(file->fd, &st)) - return -1; - - file->size =3D st.st_size; - } - - return 0; -} - static bool check_pipe(struct perf_data *data) { struct stat st; diff --git a/tools/perf/util/data.h b/tools/perf/util/data.h index 110f3ebde30f..1438e32e0451 100644 --- a/tools/perf/util/data.h +++ b/tools/perf/util/data.h @@ -97,7 +97,6 @@ int perf_data__switch(struct perf_data *data, int perf_data__create_dir(struct perf_data *data, int nr); int perf_data__open_dir(struct perf_data *data); void perf_data__close_dir(struct perf_data *data); -int perf_data__update_dir(struct perf_data *data); unsigned long perf_data__size(struct perf_data *data); int perf_data__make_kcore_dir(struct perf_data *data, char *buf, size_t bu= f_sz); bool has_kcore_dir(const char *path); --=20 2.48.1 From nobody Sat Feb 7 22:55:23 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FA6317C21C; Wed, 5 Mar 2025 02:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141943; cv=none; b=UlAmhOekuLBAZ3rxrgmTgZR2c+5QYvu7K/3YYENyE56z6Nh5vknsyPdEtgEROTuUziZPGQ8VeNIQCBPcYFiwJ5ItphXEL0AFIiAlhnYm+Al4TN8PlvBUufyr669qcZQK7GXgOnWwwIuB02ihlH7EwYpP7ABL+InDH02H0l7AlNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141943; c=relaxed/simple; bh=gtY9+UCrKfBAYr3VbGghd4UuT5UYq3r4nfVQ+LcpLg4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WnUpQGyAnE0ZdIJg+OiJJTwJ+EJKDx2Pnh0gHzuQvq/IF0gulTaGs3kOv4ha2ZLdPBQPxf0aXXohHG61BD2b+Mpm/mgjLeXw5Z14+in4OpqWdwo74ScNPq3NSPjhoHeNHybB3UdUeOoUbpwV4GT3cmWr/Z3gzegHa9XkU65has8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=LlkwqTaV; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="LlkwqTaV" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=XrjNBrn8ne791SZzERKUz4fcgRlN8A9ah5iqdRUk17Y=; b=LlkwqTaVMANh09bY tSioio6jmnt49G9pGnoJHNA0MlSxvXDKqlt8IQMJXz9Z4kuw0flxk9CiTKGrCQ7tiOwQvKNLhkUA2 t7CT4kpAYQrY+goVI+8AEoJ32+gf9jM0iOnDAg75Xyq8+LM5V3KDq5ihG/63OR11Pvqemm6tgAVos Esu8ku3J5tz6SilYkKnr+fvLpEeOstyD9haWiPNlUpCo064J7ewjpZAtwntPn1LUAuYeXbfpFGs8W cP5ADL+72ib+AobPj2Utmt6TY6F+N+3WJu4WYlw3ubJVAKIsLiUFsIc1vy+VkyDq+itW2Q8VHUIhz LLvkQ/Niaf01PKJxCg==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tpeXl-002ic7-0t; Wed, 05 Mar 2025 02:31:33 +0000 From: linux@treblig.org To: irogers@google.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, adrian.hunter@intel.com, kan.liang@linux.intel.com, namhyung@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 5/6] perf util: Remove unused perf_pmus__default_pmu_name Date: Wed, 5 Mar 2025 02:31:19 +0000 Message-ID: <20250305023120.155420-6-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250305023120.155420-1-linux@treblig.org> References: <20250305023120.155420-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" perf_pmus__default_pmu_name() last use was removed by 2023's commit e3edd6cf6399 ("perf pmu-events: Reduce processed events by passing PMU") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Ian Rogers --- tools/perf/util/pmus.c | 29 ----------------------------- tools/perf/util/pmus.h | 1 - 2 files changed, 30 deletions(-) diff --git a/tools/perf/util/pmus.c b/tools/perf/util/pmus.c index dd7c2ffdab38..9b5a63ecb249 100644 --- a/tools/perf/util/pmus.c +++ b/tools/perf/util/pmus.c @@ -714,35 +714,6 @@ bool perf_pmus__supports_extended_type(void) return perf_pmus__do_support_extended_type; } =20 -char *perf_pmus__default_pmu_name(void) -{ - int fd; - struct io_dir dir; - struct io_dirent64 *dent; - char *result =3D NULL; - - if (!list_empty(&core_pmus)) - return strdup(list_first_entry(&core_pmus, struct perf_pmu, list)->name); - - fd =3D perf_pmu__event_source_devices_fd(); - if (fd < 0) - return strdup("cpu"); - - io_dir__init(&dir, fd); - - while ((dent =3D io_dir__readdir(&dir)) !=3D NULL) { - if (!strcmp(dent->d_name, ".") || !strcmp(dent->d_name, "..")) - continue; - if (is_pmu_core(dent->d_name)) { - result =3D strdup(dent->d_name); - break; - } - } - - close(fd); - return result ?: strdup("cpu"); -} - struct perf_pmu *evsel__find_pmu(const struct evsel *evsel) { struct perf_pmu *pmu =3D evsel->pmu; diff --git a/tools/perf/util/pmus.h b/tools/perf/util/pmus.h index a0cb0eb2ff97..8def20e615ad 100644 --- a/tools/perf/util/pmus.h +++ b/tools/perf/util/pmus.h @@ -27,7 +27,6 @@ void perf_pmus__print_raw_pmu_events(const struct print_c= allbacks *print_cb, voi bool perf_pmus__have_event(const char *pname, const char *name); int perf_pmus__num_core_pmus(void); bool perf_pmus__supports_extended_type(void); -char *perf_pmus__default_pmu_name(void); =20 struct perf_pmu *perf_pmus__add_test_pmu(int test_sysfs_dirfd, const char = *name); struct perf_pmu *perf_pmus__add_test_hwmon_pmu(int hwmon_dir, --=20 2.48.1 From nobody Sat Feb 7 22:55:23 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 777C835893; Wed, 5 Mar 2025 02:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141951; cv=none; b=Syq2QHeBIbdLNIQ9wBA3nT8ABkxU3OOGRNhMAM8iq/qNw2VTUfyXnpIuRIQVBCKcU04GJpYgKOBRInnmfsVamzBGB5UYddk758rOK19pt81sP1zU07i+Sewq/Uu4vYpAVqm4Tp5556M+Ui4dT2RV2dlNKABaBxnkYK4JPvc6uqY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741141951; c=relaxed/simple; bh=pm9Hd8/8WvBThhO6P9C3fMd6GbaDgDRpAYLM1zSCS+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q+W8ZAWPFuDi8QtVn42Ks4G5YQ5JB6yW48vFVBMClqXGZ3FFlTnlwIkv9V8E+k4PFwWed638/jGS5Yl0nhuSuLWaWtk0XknPUBuA4AT7ySa4oQNzHuELOdFhjm2GYaH9xkVvzWDERYoUJ/wOsQY1PRUIt0BPgL8Mfwwt1YTQ/EI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=naXFAD64; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="naXFAD64" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=6JUxpMTZb+VPOA3fx/psHXWyFCWtLj0EBW/8vAJ1oRE=; b=naXFAD64uWqbNum3 nHJUuPWJzKxtYzt5FQF6+2ekCyslbQVDOAfW4Dj+if2XooHUNec4BM+FpS1Fo8GlBr2Z7j2d84Oga 61L9TagYy9p+hmVDeuAV8aGSUwM9gKhHZxoYkAHUhXi9Z1Cn8GO/Xy4dGZGb6aHoSbSIB7++gfB0i +armomG729M7y/OwxFOSVmG2h86k9TdAOp/I6b+d4rR3u8k+s5YZUiHadpvG+JFoHcDIR1msZ2LaQ sj5Q8Uf/GqFFExHdNiXCw8awP5Nnjs2LHGQPPxINvg5nf2QkJhSmgQK7LnfVgD+813N+dwQIdvAMw NXCuguqLZkpbWiJyuA==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tpeXl-002ic7-2O; Wed, 05 Mar 2025 02:31:33 +0000 From: linux@treblig.org To: irogers@google.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, adrian.hunter@intel.com, kan.liang@linux.intel.com, namhyung@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 6/6] perf util: Remove unused perf_config__refresh Date: Wed, 5 Mar 2025 02:31:20 +0000 Message-ID: <20250305023120.155420-7-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250305023120.155420-1-linux@treblig.org> References: <20250305023120.155420-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" perf_config__refresh() was added in 2016 by commit 8a0a9c7e9146 ("perf config: Introduce new init() and exit()") but has remained unused. Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Ian Rogers --- tools/perf/util/config.c | 6 ------ tools/perf/util/config.h | 1 - 2 files changed, 7 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 2d07c9257a1a..ae72b66b6ded 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -856,12 +856,6 @@ void perf_config__exit(void) config_set =3D NULL; } =20 -void perf_config__refresh(void) -{ - perf_config__exit(); - perf_config__init(); -} - static void perf_config_item__delete(struct perf_config_item *item) { zfree(&item->name); diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index a727c95cb119..987b47cf54c3 100644 --- a/tools/perf/util/config.h +++ b/tools/perf/util/config.h @@ -49,7 +49,6 @@ void perf_config_set__delete(struct perf_config_set *set); int perf_config_set__collect(struct perf_config_set *set, const char *file= _name, const char *var, const char *value); void perf_config__exit(void); -void perf_config__refresh(void); int perf_config__set_variable(const char *var, const char *value); =20 /** --=20 2.48.1