From nobody Mon Feb 9 15:40:12 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3024F259CBD for ; Wed, 5 Mar 2025 19:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741201236; cv=none; b=b8ZoXMujzGdNMYe9jQfrqU6/3428QVwNqnDcf+UpII5strXPUXPBybyHdaw/VF6e23dZeSoFy7KnCTkguYlQDY9yBkQvt+18D78xSZD802gHOiC8JYllDvYTwWqBSH9LCA7BS73T3qptbad+AdbFhQd5lhRGRQZP8eVtlZ89mk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741201236; c=relaxed/simple; bh=XqBCX8Awi0cTfRB3XQlg6rx/x/9DYRXHoSNppqPAaJA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=XXxGmo8ei66OMp0NZABlLxM4iyINRUNnZziyDZOLjECxN9aAmD7K52qv/8orJcrmDAL8NK9w+jPHJ464G3TnLsFK4r9nyhnn7c5kZS8e/bYoq8CXVKLUud7mwMu6r0ExQ38vEyzE8DCYT18UMmJsVyT8jGuoyC5myn6kcXAfWmY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Icpk5cXu; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Icpk5cXu" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43bc48ff815so8304135e9.0 for ; Wed, 05 Mar 2025 11:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741201231; x=1741806031; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=J3s04uk/MYPIMD8i0vFq7N20J3NLR2AUb/nVzvTEo4k=; b=Icpk5cXu/yVhylkAVgxYb/RSzkkNAgCBYMJq2ENNdLkxTC3nXLjxmBHnmZOLQD3tbw RNZHKu0zfwqzjF74DVsdZ3T351JcW2ZVNFFtRoFrTxkw/h7qGnxS216N5gl92713pKl6 92rdwyqbEWdGitGt+r0uLSYHwU/EPnT5E34Jhs8hLsleMlCywSquFG7U6Jshmq+8ozWY qO9SwRP2ypCu9fOLVo39QZbL1EVGCv5eo36kyK7m1cEpiUWWjaSqO5C1/g73I2XzXBnq TFMZpim7bMZ7unwAj0Fxq3aWrurkOYVJKGSTkvSivP2FR/ajNaTNMtqLEYMCKkglwwae BG1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741201231; x=1741806031; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J3s04uk/MYPIMD8i0vFq7N20J3NLR2AUb/nVzvTEo4k=; b=kmEw5+Xmhl4/0quSqRSAB6uzCAIMVqSuZZLv2TxWl/cTNNAs9lKJ+gJSBaeiOfeBR+ zDQxbAtYcm5Na6ZHhKt+9rYRX1KPXZPGmnUmaNRQLB+GfLZ1pFvbVo2wCpNVJDuIMWVC Ed91uQt0PPBOFkIzOQYq67Ag0c0/crb8cm7JvkfidR2rZjv8qUf9qEK6xUc1y+8cdbGT P89gOb6bxQkJHzugW3CP5DI386aOOmRM77K/caLJIqSpLZAERfGcDzwj6LJZQ1zvEsE4 X0NDn8DzQlpnYF6NZyi42ZjuKo1a4NVdJsev/zpzo5tGQ1NjzlyXBLZb/sVakgd01Nnr WowQ== X-Forwarded-Encrypted: i=1; AJvYcCWDCVKFjQXMFHmqQeqf2M3iPzGJ+B2ihCl4ZN72KNdBR8d3vqaAChO8AS50grGUWhKiuatafQmHycHtPV8=@vger.kernel.org X-Gm-Message-State: AOJu0YwHvfrgs2FTsVO0CM94flJ0IqeJJ1jYafxc6X1EkR7uT2Rd8mFB f6sz3a71xp0mGNMnPprjqikmvtDnAJC5Oo4bMgvqWnjsro4+v4mVdUwarezFk4A= X-Gm-Gg: ASbGncskEOL2CkhGFFYQ+oaXd5PjcBjFZYGgXIvc9NsfDJqevmz5V1pMvDb5+IVxNCS eU40KJzPu59ZJqtJKL1ISzfWEdsrx5JPQZCgaHzE8VeuXJUH9O7WFEmNauTOigCK6gy73qjkB1N MfITKG96Yi8B1lWf9ELdbYkPWg6RWz38YbbaLXRk2MT7d2f/FLtXeMZjuSkYa/gIX55oYFbQz94 nFi5oku9884of3L8jCyLAA9/+ehc2FA1ALbM6hjaUos3liWzEoHccoUFWNyqnqXrYfiDevw+XwP NSHd4HN+jqNqC8TogbkVrQ1SrCdzC3wV0A1JNZYr3hcRhmUlazj+3xIGGDxYsjyejg== X-Google-Smtp-Source: AGHT+IFZIf0ShjodZV9SXe9KIzUsNCGaxeZkBM+JlLaQ4dzxNWtZ8wDlalDdkrt1996Bfra1hUS4kQ== X-Received: by 2002:a05:600c:3ba3:b0:43b:c7f0:6173 with SMTP id 5b1f17b1804b1-43bdb38ac7fmr3967455e9.4.1741201231333; Wed, 05 Mar 2025 11:00:31 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47b7d12sm22301290f8f.58.2025.03.05.11.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 11:00:31 -0800 (PST) From: Neil Armstrong Date: Wed, 05 Mar 2025 20:00:29 +0100 Subject: [PATCH] clk: qcom: gcc-sm8650: Do not turn off USB GDSCs during gdsc_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250305-topic-sm8650-upstream-fix-usb-suspend-v1-1-649036ab0557@linaro.org> X-B4-Tracking: v=1; b=H4sIAEyfyGcC/x2NywqDMBAAf0X23IU1kvr4leIhmm27B2PIJqUg/ rvB48Awc4ByElaYmgMS/0RlDxXaRwPr14UPo/jKYMhY6shi3qOsqNvwtIQlak7sNnzLH4suqEU jB4+Gxn701lHbE9RWTFyV+/Oaz/MCnvCzyXcAAAA= X-Change-ID: 20250305-topic-sm8650-upstream-fix-usb-suspend-20979d5a0170 To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1547; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=XqBCX8Awi0cTfRB3XQlg6rx/x/9DYRXHoSNppqPAaJA=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBnyJ9OrHzygs1MaL3K6SUN+pgrmhbN8UHEfJAEQMiy KyySA0KJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCZ8ifTgAKCRB33NvayMhJ0W3zEA CTDch2Mv6ErRc/9lErIQNvEQMHlIsrO7XVNTrjelc0Uv7ohpl3gJ2MqPisijgOxHPTjpKZ1zquDlp3 +1NfLIJPyniN4nGgBMkxRDr/jmwcKlrYE5a4EmBaLgf9dAtfoOGLexO7qkcCxZ2AnJn/zoIyJZv2d3 GiJXmeHNl9o1aA7tYTQHFdyKT+K9KcmjmKvnygCYm+0QcKzfvt4QbtnHKUeRyKwygzhcOYVSvygBXa tozsF1RjDZuq2EGtFECECenCO3V0ru+Rvyj+O1YMvuhdip7dFxoH94c8HcVZDR9SC5sfNYde1kQs7+ TpjJMQ3YnUUQlvkBmm5VH6C+RFqmT+WchEml/V0R2F3h89aZp+A0obtW2cj1P1Gl93Fcq5RCqgx9QC AG+FEF6MuNuL6BzJ/tFDEMWYQrSaHI8pjrNifF14kZwe2j4HPKIyALGfpx9MO1tGE3SavdH70sXdil 2dZBudANtzhPRwLrEYxakOVjJn93Bk7iKUxeMCN/sW101Bdv998+Z+r5asM1CeABUqU5tCKCIb4mmd Rutdz4vzDiKKW3aC6O4RtX+Khu99UgH3u2+ynCqwbZrjQZUfsHcNhTmbfpNhfISPcPzgrLq29RcsPF FK2GG6ErFnZtDFWy8DY3ySJFlzPy+6jS3ZM6U7eiu5bGPk/pDkmTKfz61kgg== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE With PWRSTS_OFF_ON, USB GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of USB controller from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Fixes: c58225b7e3d7 ("clk: qcom: add the SM8650 Global Clock Controller dri= ver, part 1") Signed-off-by: Neil Armstrong Reviewed-by: Taniya Das --- drivers/clk/qcom/gcc-sm8650.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8650.c b/drivers/clk/qcom/gcc-sm8650.c index 9dd5c48f33bed5b944a0b25959ef69e7862d0449..fa1672c4e7d814e1e08c79f9cda= 9463bf1cd1598 100644 --- a/drivers/clk/qcom/gcc-sm8650.c +++ b/drivers/clk/qcom/gcc-sm8650.c @@ -3497,7 +3497,7 @@ static struct gdsc usb30_prim_gdsc =3D { .pd =3D { .name =3D "usb30_prim_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 @@ -3506,7 +3506,7 @@ static struct gdsc usb3_phy_gdsc =3D { .pd =3D { .name =3D "usb3_phy_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, }; =20 --- base-commit: 7ec162622e66a4ff886f8f28712ea1b13069e1aa change-id: 20250305-topic-sm8650-upstream-fix-usb-suspend-20979d5a0170 Best regards, --=20 Neil Armstrong