From nobody Thu Apr 2 00:48:40 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E1DD25523D for ; Tue, 4 Mar 2025 19:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741116395; cv=none; b=PD39LolwUb4namQuzs/wEywq0zRcqXtnksZEd70BP8phApl3VIwtk6VSx6XtH4S1Nf7F7bpus5PuGkhlSPAETgg+QOM+Ixu6QGbfs9qnVVp7g00aaIrA7XYywMTEOSra/+rSRd9e09QyFMEIlIV7MHveM/FNPTlWCHBoaTODN7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741116395; c=relaxed/simple; bh=NEykYa6nBJlJKdA+LxhOzDhIzGTSaWYAg1h4SZwvuT4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O4ezf0PGHQxrbUrjKPiYHh3fmQTJBdcXNCJAaQ+5UYNr+AioGha0qY5c+Mr7ZKoAByvPb3hp9WEAAAG4rJzdWAhGU+/SApQhV+vA7ao8PLjIBS0NNLhBgwMpAgDDeHj5q5n3NA85Ng61txORTldjN4NlLMtEdKCINR40LxMEgX4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HV0Io9mz; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HV0Io9mz" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-223600d7968so15824785ad.0 for ; Tue, 04 Mar 2025 11:26:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741116393; x=1741721193; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=umdvFfee2QDZToWwgiz0AxJQsONRmaXngrebXX30i3U=; b=HV0Io9mzz1GVUXcPhlfewLY7/jyL/vkWQh9qvX1k/uOJduCUTALGJjwlVBctS6ZleN Mt/mOVC4G+iOWFq42zwBdPSrxv/i3/ngXar3kInwX5e7wduGzcAMlIpUStTMaAXqtCA+ 7A1QIg5tly6t8FWsmYgwxrjb3+GcywhDpb1pyt3I8InVkRvW/AM3pNeLfBGAQQTFYAm0 7nePt33AuexrbU+faqFGSlRDi7aM2S4rXFh6U2fKi1Nz+7fzmK/FUaYWoMnbrGpi8U1T vmDNM7UWdffQdF21S5mZwyz470kH0SKnwN6VwVunabe9rPj90xwDcImYv6oVNlNs8CvK 0f9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741116393; x=1741721193; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=umdvFfee2QDZToWwgiz0AxJQsONRmaXngrebXX30i3U=; b=O6DTKWs02i16gJdaM5qxY+pniTmqYNuB8M+tJCi2GIzKWVF4FCANbRtQI6Ter9HMeN 4ukilhJ459NqpdP9vjUBOWaw5jBvolckvW2yL3dH31bs6/rw6cw0BwpsNYVuLzhpUXha S6E9pe1wbnd5U8v6LqR/oxaOXiMrAPQ5BVyvn1nw84M4WNXsOugDDf8DZvxffzh+qFTj XOMitgcqBdQLPhE5bGfd/Y4iIeumsg/OpwaidizDJXLkJT4UDM8HgtyD6KP2GkIa5B1i WqQ9C4OZDKUM2Z3Unx6JwW2wEM9db8CM5kA76686ADMCT+tCK0DlSQas9suIMhIp0IY2 e9Tw== X-Forwarded-Encrypted: i=1; AJvYcCUp8XYVjEjQqDHC9PYAFjIkEmk0p6gL+0TrdBmF+CvKJROtBXL3cJmMaKWKDbzQ0+xhYaycbwWzrl1YI5Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yw54ksnzgPURSWCC///vJmLccIFWZFAbBYCEAbT6kS6eMIK+TWr K27CxQxLp9gxQrYieAo6XqiJFXUw9ApSzbkwnmIZQMupvlWeqz/Lx0r9IA== X-Gm-Gg: ASbGncvGqwWiJoOojM6CzOmN+JJ1Y6Xyn1u5aPxPBFmxdR100hn3DT+dQObEguRJgtj UvOZEa22xA7m2pKjYPNwkeKG4UjW89WNjFNOI+6dFTxn+OaTAbGMDB4++coFCKgnmGmKSFRb8Bo YdQjfuzPRyxG09IRa2IOx2VpyLqXFgnPSTIMpy3N/SZT0eHdo7gDPS9rMlv1v1NZxbv6k9bX0s/ 6RVVwyjzlB2Ibwdc8/hSKLhKB4bcYG6DdMztM4Ew8O47IRz5zNgHIMwMiqt6GlrScAkAAW2JeZS jW0QII7t+QGB2ZqSKIBEpSR/QNI/KsOMu97I3L8duVGy+RMsP9CHgZJr8A== X-Google-Smtp-Source: AGHT+IEqlNsMhgysH3ZLbRHN5sn24UmXlsfGwKRCgpcjb42zOsTM+0OVba8x8VgswqlxUdO5C6PZJg== X-Received: by 2002:a05:6a00:21cc:b0:730:915c:b77 with SMTP id d2e1a72fcca58-73682b5b913mr54352b3a.1.1741116392829; Tue, 04 Mar 2025 11:26:32 -0800 (PST) Received: from localhost.localdomain ([2802:8012:1f:3200:f1d1:c186:ba5b:8f06]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-734d444a9fasm9341920b3a.60.2025.03.04.11.26.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 11:26:32 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org, dan.carpenter@linaro.org, arnd@arndb.de, niharchaithanya@gmail.com, jiapeng.chong@linux.alibaba.com, linux-kernel@vger.kernel.org, Gaston Gonzalez Subject: [PATCH 1/4] staging: gpib: fix kernel-doc section for write_loop() function Date: Tue, 4 Mar 2025 16:25:37 -0300 Message-ID: <20250304192603.40565-3-gascoar@gmail.com> X-Mailer: git-send-email 2.49.0.rc0 In-Reply-To: <20250304192603.40565-1-gascoar@gmail.com> References: <20250304192603.40565-1-gascoar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a colon character in the kernel-doc section of write_loop() in order 'leng' to be picked as argument by the kernel-doc compiler. This change fix the following warning: warning: Function parameter or struct member 'leng' not described in 'send_command' Signed-off-by: Gaston Gonzalez --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 50faa0c17617..eeabbdb39057 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -232,7 +232,7 @@ static int write_loop(void *dev, char *msg, int leng) * * @board: the gpib_board_struct data area for this gpib interface * @msg: the byte sequence. - * @leng the byte sequence length; can be given as zero and is + * @leng: the byte sequence length; can be given as zero and is * computed automatically, but if 'msg' contains a zero byte, * it has to be given explicitly. */ --=20 2.49.0.rc0 From nobody Thu Apr 2 00:48:40 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EAEE1D7E35 for ; Tue, 4 Mar 2025 19:26:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741116416; cv=none; b=Qf1f8pS2JgOf0OFs3eN48kaoXo9oUQlyK2jp9ucc00vt/kf4BdTpmUOhUgbXx5aN9wTWcLKYMWB8iSrGqzFDl9j3l5mxjCMzOoN6WLDYdkNkurUq6y7Lx6edSQ01VJ2cxHkj7v98OPkVNrqeF4YpvfNSl0OeqijR4zuV+1o227o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741116416; c=relaxed/simple; bh=DAdX4OpccQ4N/WOgqzCYspVQp1sfDjoox8PLWuX0yz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=flRmWQ+eNyBP9UCDhA94uXwlwkOauN1xkgIdJZe5HozS5CuFTRIUNlFNOGt8vL/QwUgLMMxfbopj8KrV2d0jmI2+hNAHBq+evr7hW9vrwdo5F7girgm9QL6hIFV8VCrOc+u+fjFGhI2YU48AxBL9PdM3pGvjJG/p298Qjnlrfzc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TDkEp5qA; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TDkEp5qA" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2238266483dso9327135ad.1 for ; Tue, 04 Mar 2025 11:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741116414; x=1741721214; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0a3i+UFmRGSl/m+YRIPURF4olKZ+jWt/8woe5airEEw=; b=TDkEp5qARYBm1F2GzXRC0kXZR2uUmhIu7/oCWSbHE+Ipp93g3gxZmphTmjMOkglinw 2ljaZ0JHqAWd992JgT8vtM0y6RhjpJFlX97jmBRU/nXwtyapzK4x6TZKiSbvDFO06LFF 7jv5Bsf0w7zNJWn2WPNGFE9TCNs/OD+YiS6djEbaNbxOL2zstkquCAcE+o6itamLA0Jy SMjeQPGMKaSBiR7d5gz2xshcePDz28+kF7+3sK88xmsh1134t0xsfKb4WlWNTfm8EpZ5 jEml6quOCRsTQGl4BNfu23OBUXVPS09Ol09zH2+RgaO6C23/0alX2QWdxi3Jd25Evmh+ Ymmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741116414; x=1741721214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0a3i+UFmRGSl/m+YRIPURF4olKZ+jWt/8woe5airEEw=; b=PFfPK+oUV4wr9FMtWDOYuXmajxwYvJ44ysCRxnbPweALgXi9L/QsWJ4Qnkjo1DzaUs pjtb2C0YgbJ+2cbo24f2YbdTk9feSjLh5J0mVRf7hhciePoEDeuXiiDatnRTuMWTF7us wiMshOWA1DGPZZDwghatZ/x8zusgdTr3T9Tsc5RUJTpTqk47rbiYqqk0TQt01WqND+Gc 924Yg9jHSxhjOSTNhmwm+33LzMGN8dtMGuSuzW7PCa9A9AUUhUGPzp+GH0AvpCx/MLsn rmr1WRVOLjcJnClJmqV0zd+lZZlIp1/wG+njafVtfQoLSOVNzVT2zAVgDWmf7A1To+F3 GmWg== X-Forwarded-Encrypted: i=1; AJvYcCWOXwXvkmsy5xdszkcynq+lViuFk7EVAXJZFCgTHfgM7/y7IZFqDmdX6KlscWq1W3fPn7OC3ZqxNO6ljTs=@vger.kernel.org X-Gm-Message-State: AOJu0YzRpwH2DgsxQY2/em8f/7/deZ0FU50618sjRYHnJBzGOy1lM+v9 hOGFYH8Ll/R5bBQFQfoOmLwMubmuvNa82z09YcqRRY93IvSiwirl X-Gm-Gg: ASbGncueMQLvo73f6Hdze2dHEHVkiaTE1jY8xePpAFyopq6qVV+Qxad4GMPiwLTsz8i WDP+YsU5ZEI/Nh4TMS1GHPztPxe2UQ8JVhwQ00zn5k8hwYrpQBm/4jAuQbID6X9HgyxZdgHQaRZ di1CyNGcSRwE83VtqqJ1lTgZ2RO0AtEI8qn7HVF8c1KcEi7c2iUpTM2X0AI9c5LEofIjowAhazf LKW1Ft1UtpA+PyDg/0FtNtuPFlntYCVXcXToKpoIqVkPHbDlRR3gr0TqpqQioixtj5GB5cAygEY c9wQxLzsAv5z0qQdsSOTkVVSgeJbtvVFQAbSE/gXfcX4qHTr4aziV7LFdA== X-Google-Smtp-Source: AGHT+IHsR5Gyj3IQ6WCJBUcHLaPvJEGRp0u+lrdzKgsHJz4jWIFjmVkczlI+pasHGBKFEHhUmAp9cQ== X-Received: by 2002:a05:6a00:21cc:b0:730:915c:b77 with SMTP id d2e1a72fcca58-73682b5b913mr54849b3a.1.1741116414537; Tue, 04 Mar 2025 11:26:54 -0800 (PST) Received: from localhost.localdomain ([2802:8012:1f:3200:f1d1:c186:ba5b:8f06]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-734d444a9fasm9341920b3a.60.2025.03.04.11.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 11:26:54 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org, dan.carpenter@linaro.org, arnd@arndb.de, niharchaithanya@gmail.com, jiapeng.chong@linux.alibaba.com, linux-kernel@vger.kernel.org, Gaston Gonzalez Subject: [PATCH 2/4] staging: gpib: fix kernel-doc section for function usb_gpib_interface_clear() Date: Tue, 4 Mar 2025 16:25:39 -0300 Message-ID: <20250304192603.40565-5-gascoar@gmail.com> X-Mailer: git-send-email 2.49.0.rc0 In-Reply-To: <20250304192603.40565-1-gascoar@gmail.com> References: <20250304192603.40565-1-gascoar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add '@' character in kernel-doc comment in order 'assert' to be picked as argument by the kernel-doc compiler. This change fix the following warning: warning: Function parameter or struct member 'assert' not described in 'usb_gpib_interface_clear' Signed-off-by: Gaston Gonzalez --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index eeabbdb39057..090857824d07 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -621,7 +621,7 @@ static int usb_gpib_go_to_standby(gpib_board_t *board) * usb_gpib_interface_clear() - Assert or de-assert IFC * * @board: the gpib_board data area for this gpib interface - * assert: 1: assert IFC; 0: de-assert IFC + * @assert: 1: assert IFC; 0: de-assert IFC * * Currently on the assert request we issue the lpvo IBZ * command that cycles IFC low for 100 usec, then we ignore --=20 2.49.0.rc0 From nobody Thu Apr 2 00:48:40 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CCA625523D for ; Tue, 4 Mar 2025 19:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741116489; cv=none; b=KQxO8y+5Bj+/xoJOTYP89yRBgbIeAGLkYYptiYudc9j3yaZ9hmW5p8/fz7f2Ry07Dr6OJpcPtM/72gcwtnyaORwre27gwFwY3zOOy7+E2mORERK/tRWrw0U+Y8grpa1Adkemwdqcb/qf0e1o1eFOLlOQuFoFkN8sf2WN4TYjDFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741116489; c=relaxed/simple; bh=R9opTtkqiR3EVB5DiuJYrC8B6crJ7i7OxRy9XNgNAB8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Km22ViYj/eLugBLBNXx+o+8wvjr8wNm2oS7adeXn5FlczxopH7ov08QbxC7qyCbhuBFXccah+sGlaBus+RBYNU3UWnFNnYiIh65iCj2+HduwJc/7+VZdi2QgLKWudeOGLBtLx7sBt8k5VXK/RWy9pnmZMd7WFEkgtacJ9cXOJUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K/d7Upz3; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K/d7Upz3" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2232aead21aso15999375ad.0 for ; Tue, 04 Mar 2025 11:28:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741116487; x=1741721287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=epmOVtfS9+Yo2ZaSmvnox3J1qzYW8Hx3jkXGEoYH3uA=; b=K/d7Upz3A8fA4nJHoSzfZNAARmoNXH5f3vCkMaEL4UJf98B36zhEvX8/gEeyhBtGQq /uXyfcpvlyotiObErqQXjY+CB4rlVrzxa+FCd+ZMT7jXd2PYiE43y3TLBp1k489rqge5 v03wxR0cJrpbbPhjN1H15MgNoZz37J6zQlOr/GKjVmcOy13xT2e8rqt3kpt2YQiQBIdn hDXGcb85hj/MIL3Mo4i7NZCIrGerss8nKovPMUsZFoEGO+RQppHe9HfHwnN56jvyQSVm h/+PhEAawoer6PwRg5/lfoSY2u8c2xMXh8T63dwkATNo1aNMwp/bO9BI0fGY2RPWo/nF fJ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741116487; x=1741721287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=epmOVtfS9+Yo2ZaSmvnox3J1qzYW8Hx3jkXGEoYH3uA=; b=q3XLTs6U26iCigRMU16l+YoShvrqh3ZTLhRxnufyU6sb4/9ZWx41N0WdxIMbHWY7H5 kBuGGF+9z5Ttu1i/HZBZODq2+Ck7DIL0PyK4ccRyWmR2lZ1R45OqOengX/rTbgXhRGhR PYHf/f/v5rGfsvl0Equ5wQDpvS5jvFwStDXeRshOkt8/ibazze3PU777Ua955n68edhO crERnDcw6I/qKs/xZy4FSnlB4g0egawVfKYJbLoD9HqvfebYX5cxNS+CoirSCttNrByX 0tKQUemgo6wY7eXLWp6SoxXjN8v2nVZagHNQqJW0w3WMK8mf1N9ptXBOXHEecbUoKM/x EJ2w== X-Forwarded-Encrypted: i=1; AJvYcCXnKLG0yY8mqkwkCnXTIZwzEhx1HGfDtuG0y8GSrSrWxyPor7hhxFgFqWj6qSrVWm9+qosA4+SfpTFXNsc=@vger.kernel.org X-Gm-Message-State: AOJu0YxyftqOATPwY8dQ7cZqyg+OCmwy1RWb5UksUfoAE4IcYkehu0eb auHACw8S9Z7ecZjEyGRHn86NlqHSMJp3XrAsAT9OKZskaqgrZD0b X-Gm-Gg: ASbGncvZy7hjb3pMS7oNHKLv+Wl5RniSHCCYkpLk/D6LgXnh2CE24AwjK+WTef7SRRC XFQtG/VI4TUPoQqTZF5m5qxInQL3w+Sy+FVxQwYiGYh5Ff04BwiLQ0l+qTdOdtaTiA2t3G1VyHQ g2pe6ddmen3VrZl+vF78ObaBXAmqGOzBdoPfMUD7e+Ardth19B5hLvG9EIiSwtyarH0bYZM+uD1 eAkaD2glfJTq0YfilqufjLQTE/AIMCs+bf4P63aiJ1OK3pQ3w1gmFQ/1RsUY9AcOXq9ZRNA8Vqy jvlzGCQe/ZulnpJPYmd0i3RtgZI1AaZTQayHuYK5tgfEllrSc2WoxOXrfg== X-Google-Smtp-Source: AGHT+IEdX0BHGO1aNI4wvVQv2mPr+fwnaDksYZRGrdWeJn/GT7+TqDieWrNAWkuFEHO7F4AFLt2RNw== X-Received: by 2002:a05:6a00:244f:b0:72a:a7a4:99ca with SMTP id d2e1a72fcca58-73682b4e2a4mr73072b3a.2.1741116486856; Tue, 04 Mar 2025 11:28:06 -0800 (PST) Received: from localhost.localdomain ([2802:8012:1f:3200:f1d1:c186:ba5b:8f06]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-734d444a9fasm9341920b3a.60.2025.03.04.11.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 11:28:06 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org, dan.carpenter@linaro.org, arnd@arndb.de, niharchaithanya@gmail.com, jiapeng.chong@linux.alibaba.com, linux-kernel@vger.kernel.org, Gaston Gonzalez Subject: [PATCH 3/4] staging: gpib: fix kernel-doc section for usb_gpib_line_status() function Date: Tue, 4 Mar 2025 16:25:41 -0300 Message-ID: <20250304192603.40565-7-gascoar@gmail.com> X-Mailer: git-send-email 2.49.0.rc0 In-Reply-To: <20250304192603.40565-1-gascoar@gmail.com> References: <20250304192603.40565-1-gascoar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function name field in the kernel-doc section for the usb_gpib_line_status() is defined as 'line_status'. In addition, after the kernel-doc section, there are three macro definition instead of the function definition. These issues trigger the warning: warning: expecting prototype for line_status(). Prototype was for WQT() instead. Fix the warning by renaming the function in the kernel-doc section and by moving the macros at the beginning of the file with the rest of macros definition. Signed-off-by: Gaston Gonzalez --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 090857824d07..f7dd0809b06c 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -78,6 +78,10 @@ module_param(debug, int, 0644); dev_dbg(board->gpib_dev, format, ## __VA_ARGS__); } \ while (0) =20 +#define WQT wait_queue_entry_t +#define WQH head +#define WQE entry + /* standard and extended command sets of the usb-gpib adapter */ =20 #define USB_GPIB_ON "\nIB\n" @@ -131,6 +135,7 @@ module_param(debug, int, 0644); =20 #define INBUF_SIZE 128 =20 + struct char_buf { /* used by one_char() routine */ char *inbuf; int last; @@ -644,17 +649,12 @@ static void usb_gpib_interface_clear(gpib_board_t *bo= ard, int assert) } =20 /** - * line_status() - Read the status of the bus lines. + * usb_gpib_line_status() - Read the status of the bus lines. * * @board: the gpib_board data area for this gpib interface * * We can read all lines. */ - -#define WQT wait_queue_entry_t -#define WQH head -#define WQE entry - static int usb_gpib_line_status(const gpib_board_t *board) { int buffer; --=20 2.49.0.rc0 From nobody Thu Apr 2 00:48:40 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58130255251 for ; Tue, 4 Mar 2025 19:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741116498; cv=none; b=GWacKL2gwKWhyoG1/WpvApyqeKh1R8M3d4BOg03tNLbulhicSUYBqvmCtEUdt48t3gUn8ttpn+CCW7zSB9dH7ck3+C7xi+vqJ+GZXr4+BBvhWKdg/S44hb+wYwsMHddOz/JurW7VvtadfMSKwPZG7F67kSYF2DAaxVZLzfngBMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741116498; c=relaxed/simple; bh=LORQsVwLTnGVfVFh5m2kwdKQtDUywERLd2dudQi76wM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lW1LlIKoxqPtZvIrCj/FqH8GDvsc04uASorTxEFAITzEW8O1EOoo755opJLEziKMuwHHuFRUghUjs/Ou7dcqQTwnFkCVwLgOaE2COrfytt0Px8Ei9DrFwt8We5KnZcZO9PXJhtVywcV3jnFwRNj32Uab2FUG73grhw2OF6ZgtE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ic4s4ObN; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ic4s4ObN" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2234a03cfa4so12967065ad.0 for ; Tue, 04 Mar 2025 11:28:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741116496; x=1741721296; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nfwpAjfF81ZoEEByv81hbUTcL55kAuRlyaiSfIzemn4=; b=Ic4s4ObN3ZoQbro1Gw3h/ELOHrJszLWMK2OkhUU0Zc6rWFNw3k15++dFy21KHUqR69 3ic3crFm4RilEX/UDYm3rp9rmFjbxrfb1gwovU6ywrPFFS6V6G0MBTMqcA/WM1SmjnO0 2wopJToMahptgwtnXx0oAVrjnwI40eltjlEKVEUjKxaK7gw1O9+IPpdMf7Xm4SnTQjFr i5HsLRPH8g9G3P/J0xwbAVpFdLUlPgEHsAMkVl0iA0SptEtgQLQx9+GB3DhqlIOAZiEi hCyhK43TJVk8qnyMCHFb0/CExwSjSy0mgYsuYGDzoTc2fes2BgpFWfnDPFAV2L04y9O3 kW0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741116496; x=1741721296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nfwpAjfF81ZoEEByv81hbUTcL55kAuRlyaiSfIzemn4=; b=cpeDoN6tC13Y10/zjIzurkiQXH4H+4nfOfk4ThX43wFv2xA4DzKZmX0q0mHJaUAAIB ITo2DFvQmXQi/PsSrIElp4ki9YYoT7omSo/YK1XRZ80QJlB3dRK9GacmvB/G5kAkfcUS 9nKM3C5n7hd2/OzcPxkMyjTOGfgBjVZXC6ea8jXiie2RFtwXwODPYvOeyjPSzfrrUU30 QzA4mX7S29YibZhkuksVFBj0E0tulg177a7Hf7sPQiQS3/vp7B/XEpmVkTNfPD6f41ir e3T17DDVr4V+VLsA1UniNkRStbuURyKVU9Duh/EaJnCrq8VNo9salcOVxOyI19n6Engx ajQA== X-Forwarded-Encrypted: i=1; AJvYcCXGusIvZwbyT5ZXak0GdqpE2J2jBLCgf+vMhjywJq/ZHhekq96hFHr47HZvTrTEFB19ePdjThNCoq4otYk=@vger.kernel.org X-Gm-Message-State: AOJu0YxzOM+B4uzus8wXFxhgW5wbC4i6EFvm91Q9PQhrv/VVa7iP9Gpc OTQQYKMNvEEqPfGIbPnKQL2XtlD4KIPj4AMo9g0lI0Vf2aM4FIZq X-Gm-Gg: ASbGncviaF3Q4cSV3k2w+GV2NbgC8BGacDbhEv/XjoLneRIzWtDKUlOQajaNrnQTuP8 BivbfwPA26P9uVG3lyi8IPX7nXqSUCTunuMCW6+fJ2eyoVSRTq2HvTEb4aSJuxDr5q6IyNQufRh xs0ZeS/Pe9pv6s7OjeI4PkhNnULBz4uo5F6GSZH1Es4JuhKAXS9jD3ze/acNlm9iiVY4yQURFiS PJELo2LmWW7w6gVB6oZPwEwsmT7X4Njqvu/XxE6H1wOC5igj9tzbmskLcGw4SUWhoWZPBlWzU1e ST2xZ9/ze4OX9r/psfykwMmdLD4mzopC3dNS9zXQj0DXCdypttZZuGGvKA== X-Google-Smtp-Source: AGHT+IFC/HtEpOI88jDvCz6XWpDsB1WUEG9zN3cdBySAyd4AF5z+1Dg8su7AkiLyDrWInkTaZatviQ== X-Received: by 2002:a05:6a00:cd1:b0:730:9467:b4b8 with SMTP id d2e1a72fcca58-73682c9afe5mr41447b3a.4.1741116496118; Tue, 04 Mar 2025 11:28:16 -0800 (PST) Received: from localhost.localdomain ([2802:8012:1f:3200:f1d1:c186:ba5b:8f06]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-734d444a9fasm9341920b3a.60.2025.03.04.11.28.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 11:28:15 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org, dan.carpenter@linaro.org, arnd@arndb.de, niharchaithanya@gmail.com, jiapeng.chong@linux.alibaba.com, linux-kernel@vger.kernel.org, Gaston Gonzalez Subject: [PATCH 4/4] staging: gpib: remove commented-out lines Date: Tue, 4 Mar 2025 16:25:43 -0300 Message-ID: <20250304192603.40565-9-gascoar@gmail.com> X-Mailer: git-send-email 2.49.0.rc0 In-Reply-To: <20250304192603.40565-1-gascoar@gmail.com> References: <20250304192603.40565-1-gascoar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove commented-out code in function write_loop(). Signed-off-by: Gaston Gonzalez --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index f7dd0809b06c..bb22ee2cc5e1 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -218,18 +218,7 @@ static inline int usec_diff(struct timespec64 *a, stru= ct timespec64 *b) =20 static int write_loop(void *dev, char *msg, int leng) { -// int nchar =3D 0, val; - -// do { - return skel_do_write(dev, msg, leng); - -// if (val < 1) { -// return -EIO; -// } -// nchar +=3Dval; -// } while (nchar < leng); -// return leng; } =20 /** --=20 2.49.0.rc0