From nobody Sun Feb 8 07:08:31 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C13D427C840 for ; Tue, 4 Mar 2025 15:38:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102724; cv=none; b=aANp+3gaB2EKQ6C2l0PVbAjeSpTtTnBE6PAO2R8TrMbCGDGBNLw3rR8AFcuI2jzGgx+ET/cLBTBUFk2Zb7Hh5BQ7frbPum9P0C6yQPRqck3yLT7j8RDIeCXuPt662/7dDps8qjGBeytShqaGhOPQF+xKwkUFdGMIYzeIJoW6wgk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102724; c=relaxed/simple; bh=n4HhF0iE5d/zFnVCBm46vTJrbP1QNpIud73Lm3o314M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Dow2YIrMetIryjGXQrIpYJDVE1I4pD3buG33fygC6zoyU3N0wID7oG5LanFJ6DS9x5ioEzIAqOR+xUXJXd4xjnK8k1f/s7S0Upq9cOfCQA08E2ZI8R32nfWiLijSqv0XixnR+kSefCJdTe9pNgfSSArmS/RwNvJiOE1Q2VHZADg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=O5Gbhjvy; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="O5Gbhjvy" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43bc4b1603fso14512295e9.0 for ; Tue, 04 Mar 2025 07:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102721; x=1741707521; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bDY1B2OgIPZSJkU1XkPMYSxsKEiRbouQuwYY7R8HO+0=; b=O5Gbhjvyz1AbPH2XY5j8usKVLea3mIH8afcb1jSDErxdguD/2ZgCi9YaQvXRXJU4nS c/hG42fQ9ixjctO6Ae+Nx69F0j7DDfE9YTp3gf3aVKTUC4fJQSofvi2/O7QAJgZtC9FY 8BCC87kqSq0GyYbo3EgH5jrnGsGSli/8Jo3UVgbhf+G0012VnwLXnz4W48rj9Nd/42ug wS2JidLH+p8Ug97ruqcBc06XyRAbMZg80jXtVfhW4CxmWlkadtmSLWm1sxr/b/9NUQrp GvYt3IVOaqcpjYCdG7JrCdazwg6cxBWA/rFnEnsgZ80W+dSuKSSVgJxO6raVRsRhozlc dGpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102721; x=1741707521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bDY1B2OgIPZSJkU1XkPMYSxsKEiRbouQuwYY7R8HO+0=; b=aQHnS2DttPKfsZyuIlilhIcEjOfGh84oKcONABkATAPuzzJjbszUE2OGlyfCk6rSOG NdZnSyKrw7Ybh+eyKV2SFjpzfNdfmNAYKl6pHaW6IGmzgHMP5lyZQ99fjTCxNG6pxoTu 0hmWn9ct65DYmaZsKHxnaKoWdBwGN4SxNRE++9RAgl5YW/NlqERTeuQY2mX/Xy4Bt9Ul 7+Th1WX5KZfnE48pB0VeWJy4x6QaLyZCVHbSccv3A9cpqv7HlcmJr39hZGf63poucprL HGmJOPAjC2uBwkwHmotnUCPdQ4HvPCcVHAqNyEpWJyIuu3tY7T8eMSKoyR0uqrGVIsvt ahjg== X-Forwarded-Encrypted: i=1; AJvYcCVZX32wmlPwkubkce0ypKUK6Owt5mDD84xFKJGPB8uQ1iVuGoskTQmD9iE2WawaaLDfDaOXbwZLjlysdqM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxkv1jwasySTZmPMjTosLNpWE/k5tt2ntKBOa0rSD5OkuOxKi3Q rEYP7jHQXgXWo6GSpMwnwB8+d+/KcVMP95OdaP+zY7TL12stz5MdTT+HGmxOa+4= X-Gm-Gg: ASbGncuiDu00EzUcFMyrv1lr+Eg9f3/xNP6YjPdLp+OYcNa9U2rGHV0OJE1dQ17fSod LLkWEM4Z5NDPlpINqLCv67kef8qvneA7byraOYNm3rrRaW17hJqwYheHnvTmQ8R7+1pEiVCacGg HrAyqTnTeTIbESthD0c9pGlDVSiqENc9yXOOPw2ZZH219yd4/sVg0lb10sKAfn8Gc4ZLAw0/ySK Cv4eJ1O05w+NmKQ3K8fW05JOZUgBU3VZiufBZ0hDhFZrspbHfiGRYQX7zPFh3/bUWACq1a+FYFB x6aByU7Asr66Oy3VCykfTgwStcvmbsQCshATCt56RONoUA4= X-Google-Smtp-Source: AGHT+IEK7jyhUNwdxioelGYxeSf+GoJMffZJrLOw6owQIFfGVyUvngoXcwDOhtyH+GDoI3MOes9CWg== X-Received: by 2002:a05:600c:4685:b0:439:9a5b:87d4 with SMTP id 5b1f17b1804b1-43ba67047bemr148306905e9.13.1741102721047; Tue, 04 Mar 2025 07:38:41 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:40 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Waiman Long Subject: [PATCH 1/9] cgroup/cpuset-v1: Add deprecation warnings to sched_load_balance and memory_pressure_enabled Date: Tue, 4 Mar 2025 16:37:53 +0100 Message-ID: <20250304153801.597907-2-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable These two v1 feature have analogues in cgroup v2. Signed-off-by: Michal Koutn=C3=BD --- kernel/cgroup/cpuset-v1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 25c1d7b77e2f2..3e81ac76578c7 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -430,12 +430,14 @@ static int cpuset_write_u64(struct cgroup_subsys_stat= e *css, struct cftype *cft, retval =3D cpuset_update_flag(CS_MEM_HARDWALL, cs, val); break; case FILE_SCHED_LOAD_BALANCE: + pr_warn_once("cpuset.%s is deprecated, use cpus.partition instead\n", cf= t->name); retval =3D cpuset_update_flag(CS_SCHED_LOAD_BALANCE, cs, val); break; case FILE_MEMORY_MIGRATE: retval =3D cpuset_update_flag(CS_MEMORY_MIGRATE, cs, val); break; case FILE_MEMORY_PRESSURE_ENABLED: + pr_warn_once("cpuset.%s is deprecated, use memory.pressure instead\n", c= ft->name); cpuset_memory_pressure_enabled =3D !!val; break; case FILE_SPREAD_PAGE: --=20 2.48.1 From nobody Sun Feb 8 07:08:31 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67552283692 for ; Tue, 4 Mar 2025 15:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102729; cv=none; b=jpxDzRN5LXtHv5vFkRKIU3DGEhfnD7FCXPQDgIobh0QhUbDRuJ0/Rvh/gJ2NQ8rpEVCS/klmQ7HHBevfz1zlt2D+rxUVAjZOrl5eig411vCde3V/s08NqRdRZnpsqlnTFLlpJgF7Fs6wYIyq1CRWS/sN/uUrLNHgKxIXFJwpRBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102729; c=relaxed/simple; bh=j/4wLCwQln8i7pXmi4m03KiQwQyMuLnJxfUl/0RP5OU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aJg8pvot9TmRQ+FoZ4mpsowAOHkQ38QP987aRcEK9dDX4mKiUJw1MxJZWhAKf7TFvwQtZkUsVhucBnzZiLIvZcZ/GhuCjYXQcwr6Kqk8zfLoS9XWpRgD4QL4DLpzZnzqhDJ4c2H2jE/vrMVrW9coqqPVQSkqSLp5oYRDlv+7/LU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=N2HYJLli; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="N2HYJLli" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-390ec7c2cd8so2962282f8f.1 for ; Tue, 04 Mar 2025 07:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102726; x=1741707526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OFPt2CI1XVgWzStHf0nCdXSR4n5UutvMSPTp/cgKSsU=; b=N2HYJLliJ9A/Tj6vHsUxVN93UT6Fy84xy/lYFyQ6ldK6DNjsMaczFQGZMBa5eG3til TxjVJcEVt109Wx4/gTU7rImxV+PeSWDaAAZPLZ8IF7lrNqPHMhwBqva0pe3wU/rfMRf0 A0cO8qitFhDk7ArJRt0GzDrNfy+8cUP9v3HdBFeinJIn3MTFE+NMe0BFFgRVbKMb7wEb FxJRXU7CFz0yeLT6Xh+yKL+NCGqb2SIO5c7DIq4iKi9ckOJOjXMXuI3AJ0HEAwt8wJ0s tUSYJc4nUVdesSKpY99OtF7rygHU51W7uItPGvwpXKmG1aV7Wv57WtRvJ401A80GcQoF PVfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102726; x=1741707526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OFPt2CI1XVgWzStHf0nCdXSR4n5UutvMSPTp/cgKSsU=; b=fv4o/eu6KXpWK7j3y60RM6PIfrJ8y8eqZDeNXT9QGz283IUJbCdzJwNoVYj/quumxg av4WEeX0EaNZ0YNrPgXQvcNbIfGu0dKG9sypXoTjOgTidKJaMu6ZK8KE5ukIw3gHO1J8 DuZPm/qC5tu5EjCeX6Q9vjeEYLLZqFPDEg4C1wntxUnAPA+bkRyump+1tww+89gozoOL 4ttPOf1VD0fgOTGU0XnD3NQc/1ocVuWrs5ckroK/shbWnWX0noWw+SGSmEYWhvYStpNQ Y5vGemZDvzeGGQKsOeL9HHoe5Wotc98j09oXumLgI0YbbSaUuF9U2H1YF5DuHtC+6NyM QU+g== X-Forwarded-Encrypted: i=1; AJvYcCWYJ4tayYEwcG8F5By/GBXr5ff4ENyAITM4+nhZhK4Y0cqHPcQtGuzFgn644FEIURJeUDjIxI5LcxkzPyo=@vger.kernel.org X-Gm-Message-State: AOJu0YzFQehu2DgeUyyyl6ffYTnNmTmcirpnN+cGOSpIAiNSHYb6O6sy m1YyH74ja5OjmhkuwnU3dW+jRqa6L7/qbZTZfmr0hETTDW6w1QKIMuiMTYV+BNw= X-Gm-Gg: ASbGncs/gOhBUnVmMTXAO+dJg8drX87Ske2PTfHpm6p5cKEf8GR6UJe1lugyaXDsKo/ wD2/bA/IkC6yq/7A9x704/oa56Qklw6Btuxna1jdKms6t9U/2gUsqJFdKPshcfij0wpYgxY4UzE n7/yj+MRGY29PAplN9qMzwv8Pbklp1bpHijHdfsEXVWAyw/2LaoJ0Qqa5pMmKaZXGY/x0u3kSPQ SF0eeykB1HAiuuU+eGDZFoQ1/AUN8FIgrWMNak8fgMAEvMlDExQ2WV0Bf8vDzCsNWjKGENyjHG9 rZT6DUWuSUIvYv5yp6pRKbEQ/Jzpkswc4aISxmp/JjmI++0= X-Google-Smtp-Source: AGHT+IFzh8tpm5PJ+6KB1qG+RR0gOraUB8vKw1xBf/Zc44nQ/d4j9J/DEIN5yaKw5Z2Ch0s1pQhPNw== X-Received: by 2002:a5d:5849:0:b0:391:268:6475 with SMTP id ffacd0b85a97d-391026866f1mr5796830f8f.20.1741102725724; Tue, 04 Mar 2025 07:38:45 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:45 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Waiman Long Subject: [PATCH 2/9] cgroup/cpuset-v1: Add deprecation warnings to memory_spread_page and memory_spread_slab Date: Tue, 4 Mar 2025 16:37:54 +0100 Message-ID: <20250304153801.597907-3-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable There is MPOL_INTERLEAVE for user explicit allocations. Deprecate spreading of allocations that users carry out unwittingly. Signed-off-by: Michal Koutn=C3=BD --- kernel/cgroup/cpuset-v1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 3e81ac76578c7..9aae6dabb0b56 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -441,9 +441,11 @@ static int cpuset_write_u64(struct cgroup_subsys_state= *css, struct cftype *cft, cpuset_memory_pressure_enabled =3D !!val; break; case FILE_SPREAD_PAGE: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval =3D cpuset_update_flag(CS_SPREAD_PAGE, cs, val); break; case FILE_SPREAD_SLAB: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval =3D cpuset_update_flag(CS_SPREAD_SLAB, cs, val); break; default: --=20 2.48.1 From nobody Sun Feb 8 07:08:31 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29C8D2836BF for ; Tue, 4 Mar 2025 15:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102733; cv=none; b=mGCyMNq6rJoNxg/yRvdYz/TzTrF1aklSXWRohaazujW2todhQuCsbF8kCAIimmjtpX28iH4dfJ4E9nvxpQOH7aZrc8IIEo53lDLHhkGz3sW/xYuwdLDzq8JSI9yx1kzqMdyviYzqG3g79NbpbAT8LBe5hSFbyv0MH7M+UvtnWS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102733; c=relaxed/simple; bh=7wYWG9ZVBBfm6qGUhQl1CLl2MgF3R1Q5kOXcuHck6Es=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dEUZJzFW9/XfKO+VWidGupujd0Bmpbp03wTkYWncuNI1vQI+iY1vV3p+FXjRe3Le39+JAoFcc3zpxW5kyjPUWrWA1J5U+T162Wd3MAUwWjC5JsiHS2kjNSB7fbsfsZUc4TXPk/n8B9oH7Jz1XQmJUarvyirJqyw8RQqsOGOMVUw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KXppXQkD; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KXppXQkD" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43bcfa6c57fso2512295e9.0 for ; Tue, 04 Mar 2025 07:38:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102729; x=1741707529; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U3wpAZuZ4KSnXLbNZ2vVh3tj9jZngNuo0DCz+MLkfDs=; b=KXppXQkDk92JQzy4v8GmbTtE/SQwvZcjp9mxH5CnBZD0Ct1HgT8D6MfFKmyp9bNVvn bCd2aQtt8D0SjeXq0Oc5MLpuq3g1LieVC/EBNfKgcA59dBAJKVYJXwQd+f6/GAIm9/m0 rwOyD/nWBci8Vdb67QEUsZ3nnXTatRKAvBfHDt6shbRGUKtS3yq6PjkUVw8vy7cfKH1S gobZTYmTgBK0hjnyJ935+55kW3goVuJYaCtFNtxc3yCehR83a4NKnRf26R0fnhpeImEF /F+GtfKR+7dp296RxtwxL0wmTtrWhviygtM91yL9hFO5ju+DKY+olPXolzXKg1FNyq4/ Ujxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102729; x=1741707529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U3wpAZuZ4KSnXLbNZ2vVh3tj9jZngNuo0DCz+MLkfDs=; b=jqD3wqWgnvAI+RHYYDcKGMA+TY2RmeuAwK0txxuYYY/sk5S/zMPwRNVMSK2mmrcaf6 EZySif7LH4RtfSrVow+vJHXu7fq1qtM7USx/hcj0mqKezSo8Fj4Z4oVy4mpELEx+MYaZ YyYzL1wDFb5TTBNp1BrGtRPpbgwUCFSTg4nrb+GNZfECt8XIYmMzgTTVl16vufV5XFEj rUB2NCtm4PtulY1iYNFy83MDGftd0ICqHwNhLUuPLWR28KU/9O/7IBflOds4E5FBiHzK XP7XZX+Ieh2u1U9fXdoDV0jlMgR5u2fIirS1ZKEvnZw6xZZh0LLD/32CVyUNEkwZCUyg mSOw== X-Forwarded-Encrypted: i=1; AJvYcCU0a66RH6mgzleyOsD0rSQrrWnJYNEMFq64Qdxjg3TkRm/23Wjhf5+YG8WHAGPUBk0vPeY2YjFXesVs4Us=@vger.kernel.org X-Gm-Message-State: AOJu0YwYHqxONx1g+OPjl9iKbEUT8QdjQkQ3wt8/i37rxyLOl1JtHj/L hS6R2733tcWOFLZT4tJvcK3MLhTxLDIzm8gEGl4R7vg2HSxTN2WMwH8n/Z7/6zk= X-Gm-Gg: ASbGncuxYgRocLAK3eGzFA/ApOaea/He3BHTQNp7hYycdct24Cv0LfyCPQJ9zN+BnUv lf/7qkkBhrj9OPukWbGx421Rqvz1JdWJLklT91HdqVK7XJYbet2KK6FDQ9o7NQuNLAuSYOhXPrR 2TE++WeychaxaoXWADfJNo9PouZcGfiCYl8GPaWD6tpjN6efKlEZr8LGCA8/WlbWxigaT+w4Qtv dL3a5GaoOn0mj04eeXQce8P2hX36nHTVZpo2qWM9ZosMt4bC5OTW8bIyePjKRrxDW0lhB8MCnq1 Q9O3Nm2KR90zjyGqOHn2Gdq18D5mDkGHvKm9GYpS9hVInqs= X-Google-Smtp-Source: AGHT+IGuIQECszQqXO1I3O177p66zxaZAZdsZPbssWdo0WGLgBAu3ofXHTqWUVYSmtGpaEjf12Uqqw== X-Received: by 2002:a05:600c:19cd:b0:439:8346:505f with SMTP id 5b1f17b1804b1-43ba6747836mr136899675e9.20.1741102729333; Tue, 04 Mar 2025 07:38:49 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:49 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Waiman Long Subject: [PATCH 3/9] cgroup/blkio: Add deprecation warnings to reset_stats Date: Tue, 4 Mar 2025 16:37:55 +0100 Message-ID: <20250304153801.597907-4-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It is difficult to sync with stat updaters, stats are (should be) monotonic so users can calculate differences from a reference. Signed-off-by: Michal Koutn=C3=BD --- block/blk-cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 9ed93d91d754a..b77219dd8b061 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -659,6 +659,7 @@ static int blkcg_reset_stats(struct cgroup_subsys_state= *css, struct blkcg_gq *blkg; int i; =20 + pr_warn_once("blkio.%s is deprecated\n", cftype->name); mutex_lock(&blkcg_pol_mutex); spin_lock_irq(&blkcg->lock); =20 --=20 2.48.1 From nobody Sun Feb 8 07:08:31 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAC892857DD for ; Tue, 4 Mar 2025 15:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102736; cv=none; b=M+G/sbs+XEniAMQoTKFOhQhg77Amzrrsw0djvZW6MtvlNvdVNf0doCA8z5tbXxc4ppQXoymSFEyqsDMJyO7aIpKTEdwa+DHWmzUGKPIDZATmxCteuVJfh1KGgGbOo388wuBvu/90U1sg+cx1eWLUNePkkI7LnSGPsHYC3jCW4Qo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102736; c=relaxed/simple; bh=sBkomMAtTTGImKblWaof3H+sklb+CZPuq62TvsZ9BT8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h4TZWi+KyGplBMs+u4WNG6htGLroe3G0jOhuygu5yOR8QyJwmlZ1Ji+6w+sovWmnb9L66sr8kceVON7mzvoCRLWs27hbWMqqW8BgyRfr5DtqSmqceEPz6rmpWFj5qMbApBojpW+UdMtjkG6z0bKN2jxIzVvvq1snBdV9P4mFd3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ggFXJvHB; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ggFXJvHB" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43948f77f1aso37984965e9.0 for ; Tue, 04 Mar 2025 07:38:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102732; x=1741707532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NEhwpcuno0WFjY8t9/+hary0RYULU8RVoeuO+wPInIQ=; b=ggFXJvHBhk3FyOTugMTLumv9ejhutG93f2c2njr6QhGBm/HpbSfBjnShqdQnZLjEay IrNcwvkou/rQNukBMJ0xRX9qpPYt0lbfP3Zqc0+Czb58++kGoiqZ0zzHFP4BpnjAFFz3 DV+u0dp/I2Kl9Ru1/GC5+n3M0VIXZh2MPR9mt3614qMuBLatnBZt8YYt02b2XC3BJFY4 wbyLyU5dWlkDHSg+NU4QAXhVpFYyN8UFtnhX9mSjCU57kiVW/J1bArNbm5hCbsnoF1do nk8bih0klWP0Le1l6FCGeBxFwLMSGBp1pQ4b2w0mezqruH2+3tL6wT6VCvV1faX67TqZ oSww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102732; x=1741707532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEhwpcuno0WFjY8t9/+hary0RYULU8RVoeuO+wPInIQ=; b=tNv+4DPP09M7Hljjfz0SUSMY/RU7jwS9CQLf0Go4BEwKmuukRZ2KI/cEWwSVQ0kiFj 1jLL+iSNZLzmL13Mj7Y3d1XBSCsvdU8ZvJ2b/cW2ChjDBpD6nzLpv8yUTFeo1ePoVrLU 8+uS8atMiKVB+x5XWnuPxrM6BqgQn1cebsd+sPXvA5C834Uvs/cjMkmqqBYBCzsTbdeW VpOKYo3DGRjHqIuaI2qS4jabkqvsrhi1CNucogof4PmWRAvhqJiEPBTcjVg+pDz8fpUX 9RTwFI7SHoaWemKj4Pxm3wywYH+FzVpOxpjmoWJBkW5yVqTigHQe9ykmjiZ75HFGaHaR 2y6A== X-Forwarded-Encrypted: i=1; AJvYcCW1yrpfle9mbbcDN7MgkoFB2ehKK90U7pcnK4Xo3yeaKoUAmxzZKwMBI9p+ubYIMj+x2RL1J7yzTGavFxE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3JIETSnB30qWIb/yuJ6wBGvLCo63Lil9x0VRHCAlPh6G8kna1 P3BWtc+XBTN0NrDqLcnNMheZmATvfj4Ec8IEvZeeTmYfv7ssZOsq3lveBxc8C70= X-Gm-Gg: ASbGncunrNjwXnSCfNnVF9iPvPgBZZiFoECF3z9LK81i3eUcIo+IXgkmE44ONTt2Yuq hbXzs0Vmmn5N62vszp25VmVI6YzZ8OrPJwFX2r1UPNzPO+RsmhzbkzphqX8+zEy2DLDsQbpvj1Y XL140tKioNrCAo00ZvPiY4hkgq+nb7WAxAtOjilFDmVloiVVgdVyREZjxJvYBvztI0qdWFvG0js 9gDHC42TUxCVFrDXgdIMt6CmOC2NX6Ve3DdztBIURdEeOqXZMZm9HtcYQKiIDNh/Rcez2DY0RNd OOA2mkhCyNZTyiXAYyh9+2AovCT45anDW8X5n82moUAWbe4= X-Google-Smtp-Source: AGHT+IEK7ULJaNBAjTgJI8C4sH5VL3JYp9ZcoPsT94hUTXeN1rzXj0hOcFllyp1216i8WCkMP8FL8A== X-Received: by 2002:a05:600c:3ca3:b0:439:930a:58aa with SMTP id 5b1f17b1804b1-43ba665e31dmr166089505e9.0.1741102732343; Tue, 04 Mar 2025 07:38:52 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:52 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Waiman Long Subject: [PATCH 4/9] cgroup: Print warning when /proc/cgroups is read on v2-only system Date: Tue, 4 Mar 2025 16:37:56 +0100 Message-ID: <20250304153801.597907-5-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable As a followup to commits 6c2920926b10e ("cgroup: replace unified-hierarchy.txt with a proper cgroup v2 documentation") and ab03125268679 ("cgroup: Show # of subsystem CSSes in cgroup.stat"), add a runtime message to users who read status of controllers in /proc/cgroups on v2-only system. The detection is based on a) no controllers are attached to v1, b) default hierarchy is mounted (the latter is for setups that neven mount v2 but read /proc/cgroups upon boot when controllers default to v2). Signed-off-by: Michal Koutn=C3=BD Acked-by: Waiman Long --- kernel/cgroup/cgroup-internal.h | 1 + kernel/cgroup/cgroup-v1.c | 7 +++++++ kernel/cgroup/cgroup.c | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-interna= l.h index c964dd7ff967a..95ab39e1ec8f0 100644 --- a/kernel/cgroup/cgroup-internal.h +++ b/kernel/cgroup/cgroup-internal.h @@ -168,6 +168,7 @@ struct cgroup_mgctx { =20 extern struct cgroup_subsys *cgroup_subsys[]; extern struct list_head cgroup_roots; +extern bool cgrp_dfl_visible; =20 /* iterate across the hierarchies */ #define for_each_root(root) \ diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c index e28d5f0d20ed0..5c59b01024019 100644 --- a/kernel/cgroup/cgroup-v1.c +++ b/kernel/cgroup/cgroup-v1.c @@ -673,6 +673,7 @@ struct cftype cgroup1_base_files[] =3D { int proc_cgroupstats_show(struct seq_file *m, void *v) { struct cgroup_subsys *ss; + bool cgrp_v1_visible =3D false; int i; =20 seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\tenabled\n"); @@ -684,12 +685,18 @@ int proc_cgroupstats_show(struct seq_file *m, void *v) for_each_subsys(ss, i) { if (cgroup1_subsys_absent(ss)) continue; + cgrp_v1_visible |=3D ss->root !=3D &cgrp_dfl_root; + seq_printf(m, "%s\t%d\t%d\t%d\n", ss->legacy_name, ss->root->hierarchy_id, atomic_read(&ss->root->nr_cgrps), cgroup_ssid_enabled(i)); } =20 + if (cgrp_dfl_visible && !cgrp_v1_visible) + pr_warn_once("/proc/cgroups lists only v1 controllers, use cgroup.contro= llers of root cgroup for v2 info\n"); + + return 0; } =20 diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index afc665b7b1fe5..3a5af0fc544a6 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -171,7 +171,7 @@ EXPORT_SYMBOL_GPL(cgrp_dfl_root); * The default hierarchy always exists but is hidden until mounted for the * first time. This is for backward compatibility. */ -static bool cgrp_dfl_visible; +bool cgrp_dfl_visible; =20 /* some controllers are not supported in the default hierarchy */ static u16 cgrp_dfl_inhibit_ss_mask; --=20 2.48.1 From nobody Sun Feb 8 07:08:31 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DC1F2836B6 for ; Tue, 4 Mar 2025 15:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102739; cv=none; b=WCLFJL+TDYBKQjdatjD+U8nMtWjdMH/iuv2VEoCkZ4kmLzY/AvbCbEsHXpbQiwA4XXX/oJdvGcjF+KeUn5YPzVTskcCPaffh3LA4gNMaUuNS9XY53NwlfImJgfkfL+wH4ppGeWErbsT08Q/QtN4mnjTTdk+MK5pqT1rQLGxixqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102739; c=relaxed/simple; bh=cHns8fqxRp7euip5mPfMcCQkmw1AJFKlvqhDmvw49+I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tjVASjotAekdjcZNy3r1gboZZp2FzpDJCfK7PTTv7W7Fp570aLT3Hw7SwHLaSijl1HUnuuNCPgViiUFw15JfbYsgOHoovgNqJB28TZ6yQNV9uJme/4EZKIyhrdmIE4P4SGMm2yBc1FW9vq2Fxy/K1y9peOvlnPbmb3L+rLczgo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=MSKlbFbn; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="MSKlbFbn" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43bcf9612f4so3332465e9.3 for ; Tue, 04 Mar 2025 07:38:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102736; x=1741707536; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wBPZZxD2lIKyHp8wqmCpoZT9q9nUxOdWhcx01NnsOjw=; b=MSKlbFbnpfmgz5nTwVs4Oufvas/KA4uM8n/f8oKuhd0j8Cwhhr6BwiXr9DWVb5PqaX uY+3ytvDvyPecRbxdLSJW08F3hJ59jTE4HIBM1p295lyRMQhUvBrZfRbtdaSA4H0IEEN AzPXgGtJZAuHmpWFDWmX7vw8fUayakPRoU2j+gPF1Y7R/0HWxSF9p4xGonAqC8Zb9fm7 WifCTiRhX8J4re/aRNwWYFHhSAKSaVIz9LnzB1Mn97OUs2OejYMZdWdSgCYobWz8Hhod C5KmKSam97nGoHYyfD9EBpXjhFXrUqnShXakh8FYTp4n6C48JTohRc2cw67bf067eug1 fFdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102736; x=1741707536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wBPZZxD2lIKyHp8wqmCpoZT9q9nUxOdWhcx01NnsOjw=; b=Qnj5dJV+P5jzutoxyIyWpmFmGycyuoEtrTLwYdY5PbvlEG5qu/i7pqtjMQ//g9gpUL yZwxvjYc/QreED3XMkO0qKKT0eCCiIcWOsDkB9zcOPfQd5WCjG80JQ/2cT7Gbw30PE/s qp+rD2puoVc12W01+n779LV9IabnantBqYJ/5IKN7jWn6dR9nhYusKs88x+vmOmThUhl FVtNodk6SoD/wQ+4lhVbJG/SSVwL7k+LQgzcH5STozLk96I37j/jEHm8MLa4uvt05oi+ lrD3o1itqY9O9iz65UuRQXCpn91McGZriDhKF0jKYiz5D9c8BWKD5cfDWMM49iMdf9Dk Jm4g== X-Forwarded-Encrypted: i=1; AJvYcCXvjysMW4CAuqDNBS4pVda4Ft9cK/r23lfppT8/zDblNsR5j2JaZf9M2NzeEHsetD/ojlTCTKopv4yVlAc=@vger.kernel.org X-Gm-Message-State: AOJu0YxaVME06iNUGynrSDmRuIeIYipIOpbEtzNS/VjY2AaX/GZ+bJMP J449DlgBnwrYs3ebe8Cs+FX0t2Soym0lvYtiMTEziLZIjgF3NPx2mQumDJQQL0Y= X-Gm-Gg: ASbGnctehpioATSmUF+SEVPEXVLznTlmMG9zonP/9VQ4nY/Tr/3khQZtELX1vmxZCis dmnvN8iLNktgo4tJ9x1D+06MjndskkGpv4PZFDiRKi+pLMMLTsFQO6IjekrVeIs8/b4SyC+I4u9 fInf63r9yI95stJC+uhXXYb8eo0w6PxqJOgQ+HtnalOO9XACn3MvHVyKTC1QsB9NxNy+iL5NGS0 domxNR9725riLd/qkk72u4Q706iUq97uPnKr874aEfr1QcVwdmc+0u7Szu3+awq9YGKX4daOcaT MPu4Ytjx8L8Rp/0TcEkKogjbhY56hjcT39MheZS84wZq49o= X-Google-Smtp-Source: AGHT+IFobiCmJ5R4HiRsL7pd40Q47J6t9IkNByEpgJJ+za6Nh1z2wpG/Yd/Pf+T6IGoi+Jf+ap0SAA== X-Received: by 2002:a05:600c:a47:b0:439:969e:d80f with SMTP id 5b1f17b1804b1-43ba6773869mr156464875e9.31.1741102735859; Tue, 04 Mar 2025 07:38:55 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:55 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Waiman Long , Paul Menage , Paul Jackson Subject: [PATCH 5/9] RFC cgroup/cpuset-v1: Add deprecation warnings to mem_exclusive and mem_hardwall Date: Tue, 4 Mar 2025 16:37:57 +0100 Message-ID: <20250304153801.597907-6-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The concept of exclusive memory affinity may require complex approaches like with cpuset v2 cpu partitions. There is so far no implementation in cpuset v2. Specific kernel memory affinity may cause unintended (global) bottlenecks like kmem limits. Cc: Paul Menage Cc: Paul Jackson Signed-off-by: Michal Koutn=C3=BD --- kernel/cgroup/cpuset-v1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 9aae6dabb0b56..05d3622ea41e5 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -424,9 +424,11 @@ static int cpuset_write_u64(struct cgroup_subsys_state= *css, struct cftype *cft, retval =3D cpuset_update_flag(CS_CPU_EXCLUSIVE, cs, val); break; case FILE_MEM_EXCLUSIVE: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval =3D cpuset_update_flag(CS_MEM_EXCLUSIVE, cs, val); break; case FILE_MEM_HARDWALL: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval =3D cpuset_update_flag(CS_MEM_HARDWALL, cs, val); break; case FILE_SCHED_LOAD_BALANCE: --=20 2.48.1 From nobody Sun Feb 8 07:08:31 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8DBB27C86F for ; Tue, 4 Mar 2025 15:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102741; cv=none; b=LO3Op/gB+eqYdBz0XldoATu8FE3mg6j3ATi1WVgsjKIp/468VrGBTYT+qaep2mOrMciQP9TONENiLfSDzTxnM30aycNKCfBFZy/tCVRwWCPpN9preuH9qN85wfA1aYsqEcPyFX0YYpAoU8NFqqX7BJ/Z/GYI08TNk9DdMMuk+6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102741; c=relaxed/simple; bh=MdgvuPV/x8WhlRRCw7Trx9k9ojx5GfL3R2IFVSBLDBQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dpCVLXhOREfGdNEtZuppCRwKmMizs6QRnGEn1CXVfEELo8jidKz9cuTyGCTh9f/DCxL0ejIH9OI4nrci+Cheuy3Df4gK+Qy34i/cXm1JFnkrwVmtyh4N3jLlTETxh1NEKdRDTlijE4OMO6xh1LFcR4CEOHmRiPfeNxdKYNQER7s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=VsTqcrWL; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="VsTqcrWL" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-438a39e659cso39745015e9.2 for ; Tue, 04 Mar 2025 07:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102738; x=1741707538; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TgXxWXRYbTk04GQd58ITj+iG+NER5RZZsNgCYR7jvUU=; b=VsTqcrWLiRztdJqD+hckVkKPe1yjJ76YHIAWTRnEf737KnahCd6bqo1dAMJhSD/VSq 4DqQnPNAKhRzX3Aiuw2/i0mBSgSDxhHYlcFJE1hAEabP7ANQgTGDT0PO1kYBuR48XpPR AS77lJoAKkkEL4LWLzf5vY9QXoEGyrZrV9bTL2apQMJJZN1DjVsNg2IW1h2XvQ4Jz8IS uUQMzvihGsce8JQ79fkjhCOLS4Sivt0c82bu8seSHuRQI6SqLzXJbnuf+iHkWSwa0kyJ RHuOVB+bgpMcJqNyaPTYocI+uPnPQ/trxh2ggCGW8iwzNejTjizmJuIi0Z/9Z8iPtyow hZ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102738; x=1741707538; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TgXxWXRYbTk04GQd58ITj+iG+NER5RZZsNgCYR7jvUU=; b=mwM2ri+nTjFd0rqMc2mGskaOMgiGC/SZ9aRTgvmM/s0X+IFtJTd4TOAeqaRRCLoKyD hVny87sZcvAdm3IjXrZe5f+Bt9cxT0tEOcuGrdX/E95eDdLbyr2WawWFAAELXylQSfXv f4RAdMEtS3XkIF55L5sZD8LDi/EOROvR3VHmu9uMiwyYGStkXl+jAeJEpPr9+f8aK8fs 7LQbtYoYNphmPS0aQR1j8v3JVZKzDJ8dyXJoCWC8YBvV8EprvhgD7HNTKhlAosSKrbuH ugs1nsqBSk0+8yGOpVY+vxy/ZsTl3pltaSy4WXVeujuDmO0nWzctY3Nn6oiJHIZI3i+z 5Elw== X-Forwarded-Encrypted: i=1; AJvYcCXwCk7pFm1jGsq92ArbewmSM17ctv/joopE0BnfkPd1kSuZ5LPYHkiRrH4aqDrJcHeAIcaLp4DOGh9wMqE=@vger.kernel.org X-Gm-Message-State: AOJu0YwUB0fASe+S31mdZ+jynh60ZokHJz11CQD+wYMQGR5cEqY7V5XD OgThgLIsa7f3mFYi++IeFEXB6KJ0YFiXo2x91duO2vBxpQC9lACo7Gtlf1tdIvM= X-Gm-Gg: ASbGnctac5gJ04X8zkW5gV9juLHhvgRFiP6zVR/cT94y6xq++cFflM8BIBny4gcSKfB VtqA8d1sFi20oy9gep3zBPPB8y2FcxUnt6F429Q8dWZHAJ+65K5EvMkJbJhtA4oZ5RnO6s1Gt7R c+zea9q8oM7Mu7VEqoyqsLdAKw5D+Vc/4nKFgoCtkLNhT7rmbo5FI5bLHQcCFRI2/LqbGCsY/Z3 auU1HibD6vLzwyhyfJn967M5OHSJGGllSdtdJFDVcPfZdhWQr3KTLVGLA49qHsFSGtk2qJNoutz y3aXODKyUJpLufvBQ5Y0f7f4XjQH7uKuml2h82Q1bvaJqD8= X-Google-Smtp-Source: AGHT+IGFdMgALKsPh/yOBcPEpPtHnNxwQeHrF4SOqKDJXo/p70nI+zMPXEdR7SegUyRy3tSFD06IsQ== X-Received: by 2002:a05:6000:2ce:b0:38d:d9bd:18a6 with SMTP id ffacd0b85a97d-390eca07164mr13871828f8f.42.1741102738265; Tue, 04 Mar 2025 07:38:58 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:58 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Waiman Long , Paul Jackson Subject: [PATCH 6/9] RFC cgroup/cpuset-v1: Add deprecation warnings to memory_migrate Date: Tue, 4 Mar 2025 16:37:58 +0100 Message-ID: <20250304153801.597907-7-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Memory migration (between cgroups) was given up in v2 due to performance reasons of its implementation. Migration between NUMA nodes within one memcg may still make sense to modify affinity at runtime though. Cc: Paul Jackson Signed-off-by: Michal Koutn=C3=BD --- kernel/cgroup/cpuset-v1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 05d3622ea41e5..6155d890f10a4 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -436,6 +436,7 @@ static int cpuset_write_u64(struct cgroup_subsys_state = *css, struct cftype *cft, retval =3D cpuset_update_flag(CS_SCHED_LOAD_BALANCE, cs, val); break; case FILE_MEMORY_MIGRATE: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval =3D cpuset_update_flag(CS_MEMORY_MIGRATE, cs, val); break; case FILE_MEMORY_PRESSURE_ENABLED: --=20 2.48.1 From nobody Sun Feb 8 07:08:31 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B0828FFD9 for ; Tue, 4 Mar 2025 15:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102743; cv=none; b=FG2jBcUsmQlboV1NnzxIj5Enwc85iHqcaXSQS0zWhCPyBECs+sFEBLZhrlmHgmOfO0EBgSe+0mltFXqRHPeZePrn/IQZU5eEmeMNmiYYvzvY6akWcwoA4ZAkQ6ulvczQrg25aIrGfH//y7TwWbMJVTm36Ne2syFzWAFp0T9vc8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102743; c=relaxed/simple; bh=m52peCNVice4dNNY5xbCz5VOoTIMY+0qmJAW8b2N3QY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NTd2fXi+oIGrEdzGFBNLwfC4fAGX1ZH0sjwlGk1xEwlj9GYzM7CaiY5qzlFeY7aP4VvQCAY1/i5/hyhYVWl45BOSlwjEbuELSilefbLyjmFp24G9BZ4PdtCx3Qz6JR7QswYw7dykZ9CJa745UmjW+aClAK0ya2BZnktLGbLI9vk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CIjlrGVD; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CIjlrGVD" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43bbc8b7c65so27180245e9.0 for ; Tue, 04 Mar 2025 07:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102740; x=1741707540; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K0SMnkypgJ+E0WuuzIPm19tlt9b9dHVVlixZH4mmHVo=; b=CIjlrGVD0tl2N1dEl0VymJokuUjMCJi27QUmXaxHeMRaLwon9MBFTUQSJLV9rbUAm9 avvwf5k/Pc1u5vYR1tpZihY+tzq0nyhjjeP2DmbTdKrEAfkvOSt5S3tZ0jdE3dVMm7DH dv6tswX6zFpK7r7/mP+iViWiapeG+9ty+cT4W3kDycLoo+mBRVL52aeWFAwvBUvAZbjC 3skbz+xMJQjhnrGSZnNIkmXl2Q9RcBhPb3ZG8dXDXe6FgBR7d7J7h/SQicnuPAwPYgZE oTlvsQlzzir8ZRPxynCEJreh5tFrBVqRbnLIoYsbgW6HGeAXemeL4RuOKh/T/wKxUbAe w4jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102740; x=1741707540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K0SMnkypgJ+E0WuuzIPm19tlt9b9dHVVlixZH4mmHVo=; b=T6yNTriM4CyJKWmfSqUC3T0Gb87D0ua0D2tonHwD6G5DQbDgwWecj/3eeDvyyV7iKe sFCm3Ui0k/eUTvNklalqu7MxgwIRnLXRniAr0IsrlnyXBcpWWpH4pRu9BD3GBw920whW ggD966zVdz4zAVcOx6PZHNvcpiq+752+sGc8mxeW/AZh3cayZypXuRDI2CSJWRqdJeJO SSd9b0Pw0qABr8YD0bxw80AmPaeTAUZzTn3MGGWZKIGdn87r5qVPn9b2L0ZUWL2MoJHl 0y9KjhwuiYkxmTh+fr+VuAIA3oi8/BhwQ4aNJKdOosCiuk+TksQe37ZpEcU1bywueZjR 2Riw== X-Forwarded-Encrypted: i=1; AJvYcCUX420VsnIRWuw4YKduIly233U5P3ajSMSyL4gAE0mqp0AMDWl7a15ckNOLMdJgNS+aEyiJCzzeEMLsTYk=@vger.kernel.org X-Gm-Message-State: AOJu0YzuTFbJ5IQ/s1bY/O6XMTdNSjNVvJPm8xvxJrIoRXxM7uSRX81+ xGd31qGzUOBhUR0lyv/IwKHLHTzdkIp1yslsPHYPp9R8+7SnYhxR5F03mToPPBE= X-Gm-Gg: ASbGncunzU+1kVtXUUXEINP3vHyBoKMdbgiW+4xnbWm3HgXMY+f8kXiHZCjVAERUzhq uhq5xfG78Hy19+IznSSrUiC++C8nSX1jaKfnmpRZNaHH1HcmzOvtxICNso06sNxllHnN3e8f+aM uCSD/9PZilssWEl5kVVG2OC35dKG1h/KZAHotDe4MNUw8o+pJxewlpK0H942+kga/kCwl8wubAY aRqDcVd0rG4LvTVtu88Mh8caNlgKWmv8X6bHvc1Ba0V+gAypxcI5p0F0fqbwfURYJGNu+rPb1Sn PeXOBjjRmu5OZnI0UIicm4OXVZunf3GRNxtDc/S33lLWsQM= X-Google-Smtp-Source: AGHT+IHVsiEQmN3Y21537PIQvBH5PobiQYRSPlH0O79ylXjcUAzUwaUszPliAbCkCArUCFHUG5m/LA== X-Received: by 2002:a05:600c:4685:b0:439:a0a3:a15 with SMTP id 5b1f17b1804b1-43ba67045camr187495795e9.14.1741102740250; Tue, 04 Mar 2025 07:39:00 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:39:00 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Waiman Long , Hidetoshi Seto Subject: [PATCH 7/9] RFC cgroup/cpuset-v1: Add deprecation warnings to sched_relax_domain_level Date: Tue, 4 Mar 2025 16:37:59 +0100 Message-ID: <20250304153801.597907-8-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This is not a properly hierarchical resource, it might be better implemented based on a sched_attr. Cc: Hidetoshi Seto Signed-off-by: Michal Koutn=C3=BD --- kernel/cgroup/cpuset-v1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 6155d890f10a4..ada6fcdffe0b5 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -175,6 +175,7 @@ static int cpuset_write_s64(struct cgroup_subsys_state = *css, struct cftype *cft, =20 switch (type) { case FILE_SCHED_RELAX_DOMAIN_LEVEL: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval =3D update_relax_domain_level(cs, val); break; default: --=20 2.48.1 From nobody Sun Feb 8 07:08:31 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 261B1290BC1 for ; Tue, 4 Mar 2025 15:39:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102746; cv=none; b=GgEPnwb7W4tBBHagh7WnbEhHtZVp65wtC3rMIbCmUVZEEAAUIlZg5efX4ALJF7SIAjNKh0zEkHmxknNgibOzHagWfm2kM2si8TERFYSPlO41IDlcmyGGc/Tik7BVGgSh6pMegsoQ/BpqfaPmz4SgM95XdKYrmT7sl4dd1CdNv4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102746; c=relaxed/simple; bh=uEBo2XwkWIu1kEQdFfc+UP0MGpzG764Wn7p6Ra7wCqU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Dz3m3Ch1U7WuWyiyDU8msf/V89UuzzNRP3iL+4objCBpWLTcfvW9o+qrR614XU2FzIq9xOBgEAKyLal36miNVttF1DzefzO4Jq+pE8bVQLYnapIxKO3y8WOelbO1PDr5yGtBb5b15JUs9f5g1FEg7oY1yfJychnDu+q2XaRjceE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QgTw9Ucc; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QgTw9Ucc" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43bcc85ba13so6784875e9.0 for ; Tue, 04 Mar 2025 07:39:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102742; x=1741707542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mhMHstYP/DAcPBOLk4EEWApjXQhALePsm/Er/3v899M=; b=QgTw9UccyVFux+Vzt527ZlRdEEyF6sGd6zoXTXS0p45mPX9AzYejJpkn2vqR7TsLpx R52dwdvY571HVzEMMaFSL6H9goHxavWIFiL7FS8K4VxUFvHSP25zU1TmLdfEfitFzC/f GOhvhPpio+foB3nG1G2wj7z+mLTUKtvGH6AWSQqU/qr3INofgfHz4uzZFWBLs9iyqDjz 74STZli9eGyHQlKwYEG5OBAf59pLUHkhdvJPlNhI2KW2uoj/q02A0L2PmPwC/F/FjAhw 81qFOHe8SDmPP1exWfvOrNvZeNPqe+yRULlrBJn20zOSzMnvO9GUr5RRcGrpnLLR4cF1 V4gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102742; x=1741707542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mhMHstYP/DAcPBOLk4EEWApjXQhALePsm/Er/3v899M=; b=aFvXETZsrLN0+zwd/O47X0sJZXJZTGSCh/qOX9LybgdYtdNvwQwdxbA0OJaY3MR6Xl xMS4T+OjbUAyiYX1cagJZanumcLPGm6nN7bgMhNv20Gu5Za89ZAW6r3RTM5Zqjr/Qfh4 Ib6mcynIRU3ZhAyHOcXn4TcAGSm/ZXaS9I/NceOGBNYQYvhqWZwuJDBxF2QgvS9fIRq1 ++w2npzai/v7MwdbfBA+v0wiyFaoingU7weRUsE9Yi+H9KLXvDFTK81iZxKnwLo/qQY2 sEIL3yaOunirj5WZ6qZpBeEcej15c7ErhPBEtT4frq02N8SdNWt526bRH6DqC5+a6OxE 1cvw== X-Forwarded-Encrypted: i=1; AJvYcCWzS+9hV1Wraz4oq5yHbOL3jk1wwErkg/Q9rjw6+/H5O3VqgF+mKGh3Jss2rtc+lWsV+ioGbbGw/wdTHN8=@vger.kernel.org X-Gm-Message-State: AOJu0YzliYMGXyKRkno3xHrQUxETTlTGnuz7GhOJmoHgGQZynJEqfzs9 UIle0KjXXEH066EbsZWJcOv+n5ORGYUS/2uVqQ6GU7WEUQXJWNouQx58W0j2Szc= X-Gm-Gg: ASbGncsyixW/OvNojyNWQNg3LYgHOKGvl8GIMRLxju1JkA0zpO4WIGOiqtqtHoWux84 NbBiPRSCcIbUMPthfAOioSNfp7NMr7Wot7y4hHm6Wn0V0dKinvE+lTsG0fIN6xeWQ/thh0f5Vx2 475bG0RuWWzWiLwMi2b2H1hRgOsH48yMAPYni7lbCxfRkSXO/VcPCyijFIuEBZ4qjOfnSD0lsa9 96J2Q7cMhWA6I4nV9iywA4Zn+eH5eJa6lvZvGvbGQ9pYXbB9G8xy1H/eOX/EOABTp10836qdEDc zAXu7N7DFqZQ7aTHWnNZ6NwWgY/FiloERTK1pF88tWCwQ0Q= X-Google-Smtp-Source: AGHT+IGgG3j37XPpBlw8fV8aejT9Y282Zg84Ylxu78/13gmSg1k/Grk33Ygxi04T6savqD/zyfoG5w== X-Received: by 2002:a05:600c:478a:b0:43b:c7bb:84ee with SMTP id 5b1f17b1804b1-43bc7bb85bfmr53809865e9.2.1741102742506; Tue, 04 Mar 2025 07:39:02 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:39:02 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Waiman Long Subject: [PATCH 8/9] cgroup: Update file naming comment Date: Tue, 4 Mar 2025 16:38:00 +0100 Message-ID: <20250304153801.597907-9-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This changed long time ago in commit 8d7e6fb0a1db9 ("cgroup: update cgroup name handling"). Signed-off-by: Michal Koutn=C3=BD --- include/linux/cgroup-defs.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index 17960a1e858db..561a9022ec100 100644 --- a/include/linux/cgroup-defs.h +++ b/include/linux/cgroup-defs.h @@ -619,9 +619,8 @@ struct cgroup_root { */ struct cftype { /* - * By convention, the name should begin with the name of the - * subsystem, followed by a period. Zero length string indicates - * end of cftype array. + * name of the subsystem is prepended in cgroup_file_name(). + * Zero length string indicates end of cftype array. */ char name[MAX_CFTYPE_NAME]; unsigned long private; --=20 2.48.1 From nobody Sun Feb 8 07:08:31 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFEEE290BD0 for ; Tue, 4 Mar 2025 15:39:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102748; cv=none; b=eYhi2EHYrLBKkFNYK3BgH/2Evf0OzJ9Z8UBtQMO0aY9fpp1tnsm9LKLqD8Jxw9zTr0DuFnfdfMKgsfOoRsQefhAEPUCgwi+ws0YGTFUxjToijVaTdnYg6+h9ZX1SAUq8iWdQfgX/PQjcazBHJ7ozjg73Zs+GQDDeqEilTjcXTss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102748; c=relaxed/simple; bh=LvkOijoEyLqDMsqQX+Kl7wQP+Lfreox2ddu/WO8YtBM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iSwyB3o3KaPn7lwl3yawtoK22HcfwIgzrq7qdjPkyKDqK1ivEcrFLKlBdz/vb/5ckxazZrkeD6PyFTt1qGvma50UZuQQxJa+Ilb8E3/OF8SoK1dVFeWXYwESGahqrbyYX0oBgoEW2T3afaUZHbJZ4SUwHd745/z7auaWHDWrRwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ReG+dyPC; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ReG+dyPC" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43bd03ed604so2249675e9.2 for ; Tue, 04 Mar 2025 07:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102745; x=1741707545; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LkXOSC9ROskp3x3ku4mQvAAKFjUVG2MCmIDW0NJqpNc=; b=ReG+dyPCRDFzyYsj4zAYWz+OKEE+rGOqNz3/dsxcIS6XEcShSVkTOBrrbwHt7layU1 q17uB35yxIqgEEh4Uaa/dDkymiADB3WLoC0pnAt6Iwr+pmCS/Bkcl7yiDnuPs9E1yjb5 SXZdxDMirB3pe52gx2v8nfSuWl2Yq1T4XtaBXmHBZ2+TjCkwGbPn3wQe3nQYG6NrFT9I WdmTKAY058SuNpiA3IMy/wg3MYne/Pll5dQ2t4RclcRQHwHLhMI5NUnJOBtziqWaq2Nn 2kdHJzoN/WidBmWxXxgReZFzcvWtWXErsTqmFYkdvUtxtyJ/Zkydf1TZ9KGLRlk7N35I omBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102745; x=1741707545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LkXOSC9ROskp3x3ku4mQvAAKFjUVG2MCmIDW0NJqpNc=; b=u1LKYnChKlcrR4s/7BKzMkw1LQ1rlMtiyeZX8BtOmrTU2kmvYXmOZOJ8E6QPnNMW12 WbcQOsUs9Ztnfu2cJuRqjM5VsY6QyK/BcztwhC1J/uKc0jynOxzVMTgmeWK2UrEvKNmS yES0XVaxo93VtLCu8xV49ebAJegU0Br5ken7yvMhq7KNRpQj5J48lzP7dT27IoILJlqu PpqfwiKVucJJNDuA4spc9g7JQjuwjP7+jlz1hvpi7WtzAkapGWSVBM1WBzq8tnHUD+vq c3FnXrcIRxTeRsz3md/11ahUcJosOFDYcSCn0onPNlGXFD8aSGykCLFqUdSZiRDCIrFi 75Wg== X-Forwarded-Encrypted: i=1; AJvYcCUAiiVVDZh+g0HnP0pY+gDYH2uygEUGriQ4Pls47BAyYy5vWnntmT/YLHtJf3Ye7nb+q0EszEY1XNMxDxc=@vger.kernel.org X-Gm-Message-State: AOJu0YxUPE2v1XhbDwHgJD2tJPvqtBWeUGP81Vb+c/8x7eKngC9gJBIv /09HGTmgFvkObe2HXUbOOXdPXYuhy8JWEGcKsIJncJfpWl4sjgvJAXLhiWFksg4= X-Gm-Gg: ASbGncu4XwT20yXyD3/1/x1SUPrDMWCsOlq2Vkz00LjVDk/xP/wGj5JRhRatxUTc0rl jPxBaeVAKDtwLmaYZO2NkI2bfuAgFSQVa29krRRZ1oGlfea9hN5ARA4UAweOgvmYh5VS49uqYTx Tt79VE3WZZt3Ais1MIreR6QPmdXnIBheXL5D+PUUvBBa5AfgaSsGzaWKIqM8hqjiab3RS19eHvb +fmzixGhIIvow6rMXXkSBkADsyFdJFJRPou8zFVFjlgFltKM22loovBZ1fRubhtbyY9/UwK2Re5 xMY4J98QcgrcQBFdVQlaJcZaPhfx1ATINX9GoT/u1C+/YpY= X-Google-Smtp-Source: AGHT+IFd0Y1kfVUDwA+rIlXltUNEpd+BRYNRN/rGxGNdGzkzrMQ0wTVhTLyq8Q5ZNmhBP5e9sRDWeQ== X-Received: by 2002:a05:600c:44d6:b0:43b:c0fa:f9c9 with SMTP id 5b1f17b1804b1-43bc0fb002cmr75491345e9.7.1741102745403; Tue, 04 Mar 2025 07:39:05 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:39:05 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Waiman Long Subject: [PATCH 9/9] blk-cgroup: Simplify policy files registration Date: Tue, 4 Mar 2025 16:38:01 +0100 Message-ID: <20250304153801.597907-10-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Use one set of files when there is no difference between default and legacy files, similar to regular subsys files registration. No functional change. Signed-off-by: Michal Koutn=C3=BD --- block/blk-cgroup.c | 7 +++++-- block/blk-ioprio.c | 23 +++++++---------------- include/linux/cgroup.h | 1 + kernel/cgroup/cgroup.c | 2 +- 4 files changed, 14 insertions(+), 19 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index b77219dd8b061..db6adc8a7ff41 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1771,12 +1771,15 @@ int blkcg_policy_register(struct blkcg_policy *pol) mutex_unlock(&blkcg_pol_mutex); =20 /* everything is in place, add intf files for the new policy */ - if (pol->dfl_cftypes) + if (pol->dfl_cftypes =3D=3D pol->legacy_cftypes) { + WARN_ON(cgroup_add_cftypes(&io_cgrp_subsys, + pol->dfl_cftypes)); + } else { WARN_ON(cgroup_add_dfl_cftypes(&io_cgrp_subsys, pol->dfl_cftypes)); - if (pol->legacy_cftypes) WARN_ON(cgroup_add_legacy_cftypes(&io_cgrp_subsys, pol->legacy_cftypes)); + } mutex_unlock(&blkcg_pol_register_mutex); return 0; =20 diff --git a/block/blk-ioprio.c b/block/blk-ioprio.c index 8fff7ccc0ac73..13659dc15c3ff 100644 --- a/block/blk-ioprio.c +++ b/block/blk-ioprio.c @@ -113,27 +113,18 @@ static void ioprio_free_cpd(struct blkcg_policy_data = *cpd) kfree(blkcg); } =20 -#define IOPRIO_ATTRS \ - { \ - .name =3D "prio.class", \ - .seq_show =3D ioprio_show_prio_policy, \ - .write =3D ioprio_set_prio_policy, \ - }, \ - { } /* sentinel */ - -/* cgroup v2 attributes */ static struct cftype ioprio_files[] =3D { - IOPRIO_ATTRS -}; - -/* cgroup v1 attributes */ -static struct cftype ioprio_legacy_files[] =3D { - IOPRIO_ATTRS + { + .name =3D "prio.class", + .seq_show =3D ioprio_show_prio_policy, + .write =3D ioprio_set_prio_policy, + }, + { } /* sentinel */ }; =20 static struct blkcg_policy ioprio_policy =3D { .dfl_cftypes =3D ioprio_files, - .legacy_cftypes =3D ioprio_legacy_files, + .legacy_cftypes =3D ioprio_files, =20 .cpd_alloc_fn =3D ioprio_alloc_cpd, .cpd_free_fn =3D ioprio_free_cpd, diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index f8ef47f8a634d..8e7415c64ed1d 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -113,6 +113,7 @@ int cgroup_transfer_tasks(struct cgroup *to, struct cgr= oup *from); =20 int cgroup_add_dfl_cftypes(struct cgroup_subsys *ss, struct cftype *cfts); int cgroup_add_legacy_cftypes(struct cgroup_subsys *ss, struct cftype *cft= s); +int cgroup_add_cftypes(struct cgroup_subsys *ss, struct cftype *cfts); int cgroup_rm_cftypes(struct cftype *cfts); void cgroup_file_notify(struct cgroup_file *cfile); void cgroup_file_show(struct cgroup_file *cfile, bool show); diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 3a5af0fc544a6..e93b0563a8964 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -4447,7 +4447,7 @@ int cgroup_rm_cftypes(struct cftype *cfts) * function currently returns 0 as long as @cfts registration is successful * even if some file creation attempts on existing cgroups fail. */ -static int cgroup_add_cftypes(struct cgroup_subsys *ss, struct cftype *cft= s) +int cgroup_add_cftypes(struct cgroup_subsys *ss, struct cftype *cfts) { int ret; =20 --=20 2.48.1