From nobody Sun Feb 8 22:01:16 2026 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 552D11FF1CE for ; Tue, 4 Mar 2025 10:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741085370; cv=none; b=iqQW42PNOu3lWt0fC42qygYaTNVBhHl7MW24GivBDepXpe8cmx1uhLGcLeRCPvk9Syx6V8VymvfyeMsjwO075rTqFKxELYFjz2CTlCQVO2wUzxM/47dsyQF3R+9s8O0ls+fqBXUhL4qQOZYCQeLivfGrImV8WFSt4EbZWNw1Rec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741085370; c=relaxed/simple; bh=l9iOVVNLgYNfXAh4nO6CDsbNDWmbRtmzDTNYnXr2cRE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lffBBVaPw0AOXoiqD3JXJpD9z87rzeKloZWkY/2HchMoi2ScyqcQcjYG0BBnl9SAIveBdgPUxIk+nY3OilPmHsjphKD4Ycz/VyWtMmSCbgq/TuVc8QwilvKqJCeKgpkxmn7yG3WT+5exoxBScgSU5n/sHVD53hKrYzBMP//DDyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=cRxGjEbY; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="cRxGjEbY" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VLzLYngtKKspnDi/wOo+/r3FDbyAZpJFWovD3xrE0yY=; b=cRxGjEbYPkBRHUnlJf9CfpNVJj z+kkvPCSR0yL4UzkOrHqift05faaUBg6CVHRJf37h3aPYsT2X3bwTyl/8YcmJXHCk83OOwSCHf2RR uAxEhdz9htk+aRY9uMGjkJgZ/suGUglJiGtYGE0TbGCPj8U94T/+M0H0UuitY3ICA1DNDr5WAyNHJ a+Iz9TiISGae62JuueF7VoLopuGmfBaFpPzjxyssDEs5NeojtFzb1RdTSWbA/ncx5r5LWdOy5zstL LTaOBAlDinAKMmXcm7O1wjrs14RszqdCATc5zHNFICZkk7FVoqfYExcaEqFzyRDMorLR1fr7g5exb ZhPu7PSA==; Received: from [175.114.83.198] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1tpPpr-003fel-HX; Tue, 04 Mar 2025 11:49:22 +0100 From: Changwoo Min To: tj@kernel.org, void@manifault.com, arighi@nvidia.com Cc: kernel-dev@igalia.com, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH v4 1/2] sched_ext: Change the event type from u64 to s64 Date: Tue, 4 Mar 2025 19:48:59 +0900 Message-ID: <20250304104900.154618-2-changwoo@igalia.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304104900.154618-1-changwoo@igalia.com> References: <20250304104900.154618-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The event count could be negative in the future, so change the event type from u64 to s64. Signed-off-by: Changwoo Min --- kernel/sched/ext.c | 20 ++++++++++---------- tools/sched_ext/scx_qmap.bpf.c | 16 ++++++++-------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 986b655911df..686629a860f3 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -1489,53 +1489,53 @@ struct scx_event_stats { * If ops.select_cpu() returns a CPU which can't be used by the task, * the core scheduler code silently picks a fallback CPU. */ - u64 SCX_EV_SELECT_CPU_FALLBACK; + s64 SCX_EV_SELECT_CPU_FALLBACK; =20 /* * When dispatching to a local DSQ, the CPU may have gone offline in * the meantime. In this case, the task is bounced to the global DSQ. */ - u64 SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE; + s64 SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE; =20 /* * If SCX_OPS_ENQ_LAST is not set, the number of times that a task * continued to run because there were no other tasks on the CPU. */ - u64 SCX_EV_DISPATCH_KEEP_LAST; + s64 SCX_EV_DISPATCH_KEEP_LAST; =20 /* * If SCX_OPS_ENQ_EXITING is not set, the number of times that a task * is dispatched to a local DSQ when exiting. */ - u64 SCX_EV_ENQ_SKIP_EXITING; + s64 SCX_EV_ENQ_SKIP_EXITING; =20 /* * If SCX_OPS_ENQ_MIGRATION_DISABLED is not set, the number of times a * migration disabled task skips ops.enqueue() and is dispatched to its * local DSQ. */ - u64 SCX_EV_ENQ_SKIP_MIGRATION_DISABLED; + s64 SCX_EV_ENQ_SKIP_MIGRATION_DISABLED; =20 /* * The total number of tasks enqueued (or pick_task-ed) with a * default time slice (SCX_SLICE_DFL). */ - u64 SCX_EV_ENQ_SLICE_DFL; + s64 SCX_EV_ENQ_SLICE_DFL; =20 /* * The total duration of bypass modes in nanoseconds. */ - u64 SCX_EV_BYPASS_DURATION; + s64 SCX_EV_BYPASS_DURATION; =20 /* * The number of tasks dispatched in the bypassing mode. */ - u64 SCX_EV_BYPASS_DISPATCH; + s64 SCX_EV_BYPASS_DISPATCH; =20 /* * The number of times the bypassing mode has been activated. */ - u64 SCX_EV_BYPASS_ACTIVATE; + s64 SCX_EV_BYPASS_ACTIVATE; }; =20 /* @@ -1584,7 +1584,7 @@ static DEFINE_PER_CPU(struct scx_event_stats, event_s= tats_cpu); * @kind: a kind of event to dump */ #define scx_dump_event(s, events, kind) do { \ - dump_line(&(s), "%40s: %16llu", #kind, (events)->kind); \ + dump_line(&(s), "%40s: %16lld", #kind, (events)->kind); \ } while (0) =20 =20 diff --git a/tools/sched_ext/scx_qmap.bpf.c b/tools/sched_ext/scx_qmap.bpf.c index 45fd643d2ca0..26c40ca4f36c 100644 --- a/tools/sched_ext/scx_qmap.bpf.c +++ b/tools/sched_ext/scx_qmap.bpf.c @@ -776,21 +776,21 @@ static int monitor_timerfn(void *map, int *key, struc= t bpf_timer *timer) =20 __COMPAT_scx_bpf_events(&events, sizeof(events)); =20 - bpf_printk("%35s: %llu", "SCX_EV_SELECT_CPU_FALLBACK", + bpf_printk("%35s: %lld", "SCX_EV_SELECT_CPU_FALLBACK", scx_read_event(&events, SCX_EV_SELECT_CPU_FALLBACK)); - bpf_printk("%35s: %llu", "SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE", + bpf_printk("%35s: %lld", "SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE", scx_read_event(&events, SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE)); - bpf_printk("%35s: %llu", "SCX_EV_DISPATCH_KEEP_LAST", + bpf_printk("%35s: %lld", "SCX_EV_DISPATCH_KEEP_LAST", scx_read_event(&events, SCX_EV_DISPATCH_KEEP_LAST)); - bpf_printk("%35s: %llu", "SCX_EV_ENQ_SKIP_EXITING", + bpf_printk("%35s: %lld", "SCX_EV_ENQ_SKIP_EXITING", scx_read_event(&events, SCX_EV_ENQ_SKIP_EXITING)); - bpf_printk("%35s: %llu", "SCX_EV_ENQ_SLICE_DFL", + bpf_printk("%35s: %lld", "SCX_EV_ENQ_SLICE_DFL", scx_read_event(&events, SCX_EV_ENQ_SLICE_DFL)); - bpf_printk("%35s: %llu", "SCX_EV_BYPASS_DURATION", + bpf_printk("%35s: %lld", "SCX_EV_BYPASS_DURATION", scx_read_event(&events, SCX_EV_BYPASS_DURATION)); - bpf_printk("%35s: %llu", "SCX_EV_BYPASS_DISPATCH", + bpf_printk("%35s: %lld", "SCX_EV_BYPASS_DISPATCH", scx_read_event(&events, SCX_EV_BYPASS_DISPATCH)); - bpf_printk("%35s: %llu", "SCX_EV_BYPASS_ACTIVATE", + bpf_printk("%35s: %lld", "SCX_EV_BYPASS_ACTIVATE", scx_read_event(&events, SCX_EV_BYPASS_ACTIVATE)); =20 bpf_timer_start(timer, ONE_SEC_IN_NS, 0); --=20 2.48.1 From nobody Sun Feb 8 22:01:16 2026 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A210F1FF1CE for ; Tue, 4 Mar 2025 10:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741085375; cv=none; b=K6/Jy2Tw6ceJQB0aCJ1AAVd3iECf/03UhKr6uDDzdDil6++zkOGuHGo+nKSzGxt696J5/+IcJvnDoyKHeBdOMuVN9QzzLbLL7EDqvg+oCGEV4M3FA9sHMZgc5edWZJO5c2a61dqWcdePkEjRQWRhHYiZ1CmuiUzc7B/evZq79ZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741085375; c=relaxed/simple; bh=e9wTY6GpniqjtOjPPzJ79qkW1wxFcngg2oaLOnGdkxQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q1tc0Nh3Jkn6hTiKL7jmuys65iXUjvIH7yBE1wo3aNTMtBYlbLI56iCYLmtSrxYrAfsqON6rX1JtjzbXMRu/K1DV1iLVZfqW/KiXxsPa0UCJPMQPPgCt2hq/9nKY8y/wSkWcZJw4Kv/UP3hWFAgUXxGQlc5QTpqG8tulLrNRqPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=MXYgIneL; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="MXYgIneL" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MlGHBLA3wNIQKGRJHUwflnJkc/ehF+MF4bZqo1RCWXo=; b=MXYgIneLqS6ngMRkjzOYi06maM oNwR9+Rd9JxXtAjrTXt59Cr6AYrNKvCnZJIsmIPUmSz/fMFedGP4YSk6U7sWtIm1G8N9DCexAIsnE Amk44AZ5UDLm+zDqHxUQ+AKYfj/xAPbj19YcBLTIG3Ly3jbP6yHfdt7/eRepzO6t1CKu8LeTHEYqZ KgLTybogYO+1pEjGoHCMSa3PuFGXCBcMqCAqRj1qr2F+vRQaBCRKz7HLR2UaSQY5BQ9SusIFF1aRs dbQUbcBwPkj8gB2Ot1hbtcjuw8hjVfAeR2dyDBrZa6OLMgJzWgqZ3osgUsr25BzvTeWD1ncjyM/L6 2urWuS8g==; Received: from [175.114.83.198] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1tpPpx-003fer-L0; Tue, 04 Mar 2025 11:49:28 +0100 From: Changwoo Min To: tj@kernel.org, void@manifault.com, arighi@nvidia.com Cc: kernel-dev@igalia.com, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH v4 2/2] sched_ext: Add trace point to track sched_ext core events Date: Tue, 4 Mar 2025 19:49:00 +0900 Message-ID: <20250304104900.154618-3-changwoo@igalia.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304104900.154618-1-changwoo@igalia.com> References: <20250304104900.154618-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add tracing support to track sched_ext core events (/sched_ext/sched_ext_event). This may be useful for debugging sched_ext schedulers that trigger a particular event. The trace point can be used as other trace points, so it can be used in, for example, `perf trace` and BPF programs, as follows: =3D=3D=3D=3D=3D=3D $> sudo perf trace -e sched_ext:sched_ext_event --filter 'name =3D=3D "SCX_= EV_ENQ_SLICE_DFL"' =3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D struct tp_sched_ext_event { struct trace_entry ent; u32 __data_loc_name; s64 delta; }; SEC("tracepoint/sched_ext/sched_ext_event") int rtp_add_event(struct tp_sched_ext_event *ctx) { char event_name[128]; unsigned short offset =3D ctx->__data_loc_name & 0xFFFF; bpf_probe_read_str((void *)event_name, 128, (char *)ctx + offset); bpf_printk("name %s delta %lld", event_name, ctx->delta); return 0; } =3D=3D=3D=3D=3D=3D Signed-off-by: Changwoo Min Acked-by: Andrea Righi --- include/trace/events/sched_ext.h | 19 +++++++++++++++++++ kernel/sched/ext.c | 2 ++ 2 files changed, 21 insertions(+) diff --git a/include/trace/events/sched_ext.h b/include/trace/events/sched_= ext.h index fe19da7315a9..50e4b712735a 100644 --- a/include/trace/events/sched_ext.h +++ b/include/trace/events/sched_ext.h @@ -26,6 +26,25 @@ TRACE_EVENT(sched_ext_dump, ) ); =20 +TRACE_EVENT(sched_ext_event, + TP_PROTO(const char *name, __s64 delta), + TP_ARGS(name, delta), + + TP_STRUCT__entry( + __string(name, name) + __field( __s64, delta ) + ), + + TP_fast_assign( + __assign_str(name); + __entry->delta =3D delta; + ), + + TP_printk("name %s delta %lld", + __get_str(name), __entry->delta + ) +); + #endif /* _TRACE_SCHED_EXT_H */ =20 /* This part must be outside protection */ diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 686629a860f3..debcd1cf2de9 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -1554,6 +1554,7 @@ static DEFINE_PER_CPU(struct scx_event_stats, event_s= tats_cpu); */ #define scx_add_event(name, cnt) do { \ this_cpu_add(event_stats_cpu.name, cnt); \ + trace_sched_ext_event(#name, cnt); \ } while(0) =20 /** @@ -1565,6 +1566,7 @@ static DEFINE_PER_CPU(struct scx_event_stats, event_s= tats_cpu); */ #define __scx_add_event(name, cnt) do { \ __this_cpu_add(event_stats_cpu.name, cnt); \ + trace_sched_ext_event(#name, cnt); \ } while(0) =20 /** --=20 2.48.1