From nobody Tue Feb 10 04:03:33 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6B2F2857F1 for ; Tue, 4 Mar 2025 17:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107938; cv=none; b=Z3UPUPFJzV4oFtjDft2dASB8ms1kE6wr1yHo/d2o4zmxDNUYcZlq0lSdyBxSLroqhBl1REc4aSKjxCrOi69r9eIcE8q9qIV0kKTwrnnGgqLMkCHaGQpGmFw6B6JfoAMRjxxkzBAgnInyOTncy6ETy2F1HznhoNaaKUV1JQpTHK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107938; c=relaxed/simple; bh=ako7uKkoy0pcKOqw3JaomEgmXiZMMPwkguXI68dLj6c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=piU4q9HhVuTUY/Cnmtu+ySsBNdFoRMq3lGalnIGn7HtA5ua4oWUSpV9Aotuwq9rITy8r4SOEHeLABfsG19zBKWus8ldgRv6/VZEQJ6wX9uZN7PojL3sV5sTSGJJGT5ijXMtdm+47yGfaABeg4z3x2USpStxniL63xCfJT+poRqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bgPOHsqR; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bgPOHsqR" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5e0813bd105so9364089a12.1 for ; Tue, 04 Mar 2025 09:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107934; x=1741712734; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=bgPOHsqRQxEF2wX44C1FeYmeboblVNTv4TRe0zTDsWDyWKxbYq4M0KU4YMxFBKkZvh AVpwTrTIA8prX++JKc1bK1LzaGP0VaiwOK41bYz5yYmUNxKMgfPkaVr6IiUW4qRrPzzm hRwtkBuQMPcWiTrRUD7x7Ov5vef6tyuGjTqSJQ7t0ofbReduJp0qJLEHjNrIkarf9QC+ +xVaMmW53ODzxCKWIe+BaQL0B/191VL87RFNcUANzzpIsUn0w6BatW0ZWD5k81gMGfe1 k7sws2WpIkGrenpZA0Ghaknwn2TYt7slPg7pKzUHMefnnXa1UIrnh+jAU4LGH9/WGYzh V8Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107934; x=1741712734; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=xGVaDiVKwd2uRaFR5xQQKpxEAJ/YyW3hTRC0WB+BbtgurZq7wi9ncLoxOZupVmxK3h 7JwGed/KPnXVfh24zNj5628CkRwhJeQ+KuiK3uEeWe3Nq7RtOiFgNNTwupNdBq3dO6aK ZMFq/CDd5ZQpzjWaJ1OvZ2/hU8Utuc4iqSyE4AMKYicHBeu1liZwXzSG6B10FEf2kUim SW6uCQjhqrxfGEXX/RnksLNoAnFlDrDGRwjDcAm/ARF/dxtJzCep7bx5GbfGhVbKtUry HuD0Q4/VlTT1mysgjE22Rq32WpsMZliU4H8t+974YWRQKOR1Lq1Iyjy/lH26S/cbqVJs hx3w== X-Gm-Message-State: AOJu0YwhcOU5SrumvZ87zfLJVZSsHykw+rBjMHCEXJprcXoxMgJsjqcS lQL0Iza3OTncOYwFzS5a/2nM6ISTTyI1+iz0VS0MH6YHk9eirRVAmm1yG+R9b/c= X-Gm-Gg: ASbGnctO2G1ln1tBo71BWtC6VAnHTDEOesIGvkpAbHcuPOULklgBk49MxXV7Y2HbLwt IzfPHIzI+cdHQ1PGO+G0+vnKkM3REh0A0Ca8E2lXUZ8foGoXupTxtVHQsT7abKnS6W0QZqmkWQA OZFiXM5mANyWnXpoyRNzEt7nLhcoymty5jQaEYyUfcDq6LjuBqUvuwub4chak2x6ti5+t9qfdbE dB+Q8fGH9SNZs+KAxAVtXdpVm0AWPQeUJ30Cd+P9r/0XMPpAoXfPJ9SD8sxg2TiVqMyiGMpDey0 TcJx9/RqmA5JsLyBo+55broaJpXpwOJAd90adH0Eile35wREivVB+3VgP23QGcbc3w/LAfuegAz yIywU2gVTEDbWpF9eARbF5MVZtDOX X-Google-Smtp-Source: AGHT+IH7IWkH6sGgCqXOqo1X+qUMKDFtMNOejwKoQaGxlKvxwXw1Icl3WBZaF1ebexseFdyLVEv5Qg== X-Received: by 2002:a05:6402:847:b0:5e4:cd5c:50f6 with SMTP id 4fb4d7f45d1cf-5e4d6afaf1dmr21403911a12.18.1741107933866; Tue, 04 Mar 2025 09:05:33 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:33 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:32 +0000 Subject: [PATCH v2 04/16] rtc: ds2404: drop needless struct ds2404::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-4-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-ds2404.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c index 3231fd9f61da49bdaf00e46486fc34836094ee78..217694eca36c3432a8db3b87437= 4e347eeb802d9 100644 --- a/drivers/rtc/rtc-ds2404.c +++ b/drivers/rtc/rtc-ds2404.c @@ -31,7 +31,6 @@ struct ds2404 { struct gpio_desc *rst_gpiod; struct gpio_desc *clk_gpiod; struct gpio_desc *dq_gpiod; - struct rtc_device *rtc; }; =20 static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pd= ev) @@ -182,6 +181,7 @@ static const struct rtc_class_ops ds2404_rtc_ops =3D { static int rtc_probe(struct platform_device *pdev) { struct ds2404 *chip; + struct rtc_device *rtc; int retval =3D -EBUSY; =20 chip =3D devm_kzalloc(&pdev->dev, sizeof(struct ds2404), GFP_KERNEL); @@ -190,9 +190,9 @@ static int rtc_probe(struct platform_device *pdev) =20 chip->dev =3D &pdev->dev; =20 - chip->rtc =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(chip->rtc)) - return PTR_ERR(chip->rtc); + rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 retval =3D ds2404_gpio_map(chip, pdev); if (retval) @@ -200,10 +200,10 @@ static int rtc_probe(struct platform_device *pdev) =20 platform_set_drvdata(pdev, chip); =20 - chip->rtc->ops =3D &ds2404_rtc_ops; - chip->rtc->range_max =3D U32_MAX; + rtc->ops =3D &ds2404_rtc_ops; + rtc->range_max =3D U32_MAX; =20 - retval =3D devm_rtc_register_device(chip->rtc); + retval =3D devm_rtc_register_device(rtc); if (retval) return retval; =20 --=20 2.48.1.711.g2feabab25a-goog