From nobody Sun Feb 8 23:37:05 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA74C286292 for ; Tue, 4 Mar 2025 17:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107935; cv=none; b=f4UXAmRONkZUv7C3vIaITMkTyGM8FOqMZ7KzWApOXRJ6yj8Y7mVIJf/e4lcnxxIRNrldHJ4J5RbD8sB9VOVnXUmhqOJCAPJiPfDRbmRs+5TyzFCM029JtX7BBANzA39Xm+RIHrNT81AxR7Jl/G4RneTtwYhk6aRkP3uLzDWYLxM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107935; c=relaxed/simple; bh=uYPyL/IWo3+zxsKwPHXxHCdTPQr36Ok0GjwhGtYCZ8I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OXReRNV20JcHKq5uH425drqQQvdvKbYpBqb1Z8od9+M7hEnQWG/ipPmGlM6diEWpLHuHqQ9nw7Q8r+JmsSU4ehY5F8N8YE6WPrnjIxIsBwaD5ox6njieB9V1a5HWtUhYESO9xPb79bfhZSD7ajo8ieO8ryNAmAtN8bnPujm/3XE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LWwuzUgF; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LWwuzUgF" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-390fdaf2897so3096680f8f.0 for ; Tue, 04 Mar 2025 09:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107932; x=1741712732; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M1Zs+DHu4keoQ7nH0HfotkX9qiVtwoVoQvIhvtnI4DA=; b=LWwuzUgFnhYf5w853jXU4MbTtJG5AKP1cFGZ/rJ82kPJ6qEzUkYAnP7WpAzjw4caml CD9bu06MA2LmxelRdj4Wxtn1sFMXfvwP9BtZSMRcQ1pLoeAPQhC2/bo4tNPpci7HrFfw Dsy4ab1qeCOIN1l6SSS2f4NgX2ZjLweg2stZA0fvO8Xmwvpc1/jmpkPzVVHYH2yE79ob D5biFz0mJCIs5QHsQom5/OR1YrpojGaURub+qHWxfWI64nGNsABh8Fl0g5BpM8nFzf4r 2/Qx6kTt2bI4scSFCzRpYyGVKRWSx7hmZ9z1A3sRKCSuocug2QrVMj/AcgIBNkkW8A24 WLtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107932; x=1741712732; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M1Zs+DHu4keoQ7nH0HfotkX9qiVtwoVoQvIhvtnI4DA=; b=Ndv8ebPF9tYW+/any1d+fd2+dNWUtLztLzgTUE+wT7reCd/5rkWhfvS1Sc6puwQyEi SBD8VgIOn+KFHS4olLtPIPQgbF3EJ4bSQsngZQk4uqVXUUt2TgxhGg5LCygOR7DJ7Be2 9WZXpKePv/LdyA4mSD1bS+eug9Uf8MU3SFYoUcA2FNJcM/P++yXLAwI3mv2Zq0AzJc5G vkH+31HcA7uYqP+xR6AmIUv+ooEaNgdXIEKmPqNUwvDIvUSzl0ntW6s0FILiS5UxkJUq bXbUOLQMzkubVgG0fx39o1KNuinFAcwbB0QnfFZSyt2U5SP7mUj8iEPEttErH2yIPPv9 mGlQ== X-Gm-Message-State: AOJu0Yx5Fc2eeMXwR7dUbujTlXPX3h18Q3JnvfGm9YpDkKsEG42sa7D4 uU7xUeBmkvx+mCErrKu+gKfbR9WdatOEC5Ad90MlSVo+eP98UYsiYMjNG9KfNaE= X-Gm-Gg: ASbGncsggpRNGvGhLjWw4XIc0Qk+1RiowjV31gV7cKpHk0ukS75g/cEkRIRG8L1Aw9F 19r3D9tCQC3ETrd+Anz56713xOsm8n/rO6ti7jC/JwY87cwek4O1DTa14EwtGO0jI8PCyuCsPUu Z5T+UmLCH4a2M4bpKvK1u9HMsfE6gd8tnV2gJhmz3d3LztXHQTo4n9sh9+sGzi7Me3TYCkcg9uj 9UltBo0kfGKWe00ty7JjGJPTCst5SsGyS+Lp2xwR2/FHb+QNDJq1tjyfi08/MJe/7fh2GH+sclN FQgXWcCx72IrzAslBt9uvUk504l9qi8cs+BTNk7qA9JAScEk/j1txU+Z3+EqpuOmd4+/rUzboZp mhLshDyD9d2tvBTCr+piIy3qGdGkQ X-Google-Smtp-Source: AGHT+IHSc8pjwattEBJyeHF3OjOkT41+G9Y/Rh1pozPSubIjG3eC8i5kYIqu87xMZCHZm4ULB7j+yA== X-Received: by 2002:a05:6000:1faf:b0:391:888:f534 with SMTP id ffacd0b85a97d-3910888f656mr7939190f8f.20.1741107931986; Tue, 04 Mar 2025 09:05:31 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:31 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:29 +0000 Subject: [PATCH v2 01/16] rtc: max77686: drop needless struct max77686_rtc_info::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-1-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 When this driver was converted to using the devres managed i2c device in commit 59a7f24fceb3 ("rtc: max77686: convert to devm_i2c_new_dummy_device()"), struct max77686_rtc_info::rtc became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-max77686.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 7bb044d2ac25aeaaf2404b47b7e7bd485ae3d39e..6b0d02b44c8097453f704cbec9f= 02580fb869ca3 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -85,7 +85,6 @@ struct max77686_rtc_driver_data { =20 struct max77686_rtc_info { struct device *dev; - struct i2c_client *rtc; struct rtc_device *rtc_dev; struct mutex lock; =20 @@ -691,6 +690,7 @@ static int max77686_init_rtc_regmap(struct max77686_rtc= _info *info) { struct device *parent =3D info->dev->parent; struct i2c_client *parent_i2c =3D to_i2c_client(parent); + struct i2c_client *client; int ret; =20 if (info->drv_data->rtc_irq_from_platform) { @@ -714,14 +714,14 @@ static int max77686_init_rtc_regmap(struct max77686_r= tc_info *info) goto add_rtc_irq; } =20 - info->rtc =3D devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, - info->drv_data->rtc_i2c_addr); - if (IS_ERR(info->rtc)) { + client =3D devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, + info->drv_data->rtc_i2c_addr); + if (IS_ERR(client)) { dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(info->rtc); + return PTR_ERR(client); } =20 - info->rtc_regmap =3D devm_regmap_init_i2c(info->rtc, + info->rtc_regmap =3D devm_regmap_init_i2c(client, info->drv_data->regmap_config); if (IS_ERR(info->rtc_regmap)) { ret =3D PTR_ERR(info->rtc_regmap); --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9611728D043 for ; Tue, 4 Mar 2025 17:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107936; cv=none; b=DLQ4p+JYgRlu0193gfXbu/QOKh3DBOVJSY41fuF1Q6rKzrL6Ebgdx/I+fydC6dpgRMjE7fc8JRb/cqRm3d72Tu8DNXzIxT0Z2OTCLTyN9Hmg365rY70SOb5QfqPIadcDuRGqhawYyt9VTSXx1Qq6yW0rCb5mbeg2vSlNL2+emmg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107936; c=relaxed/simple; bh=HyCZnj76UJVLp2TFtsvoqPrnKIyS4fiKrwZnWeOiCGk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZErpmp6sXXGr2CVTskhQckkuRWCsoQGuFeCt23DYmKbL1+6/Bc0/xIN3fvYW0hJG5fjjwQbGXzza3GjtMAnnxgzgyIEOD9HIHDTgN+G0eTwwp+N2s9rWPIfE+qadv1UeIFcCr9ePvivYqgISiBWAMyD9EiwZpfw4YWnbft0TJVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JjpaGvfe; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JjpaGvfe" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-abf4b376f2fso584937266b.3 for ; Tue, 04 Mar 2025 09:05:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107933; x=1741712733; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VXesqtK3A8i6ZSMFwP8n6Z6kZDUFNsTogrZxF0Gh9Ac=; b=JjpaGvfeXND1gsfIdIOi5Nk7vBOmHveBguX5rdh4QUFLQh/gyAB5LEutlmL96XIt9u 2H8jEpvgTzvhzDBaaHd8+NTKZ8Gw+dpwXAzMGO5jf4c6/vEqqPDi/rsea2Ya4rpaKKly YYRodY3e0yyZn0VpGqyWfqZ355MXDsBQU4LrjsEBg2CzLff6NG//KhZOwc2Uc9AtxSFA sTLXJRhgPZLcOL+bqUN/usZut+CpNv04Yxx1VhvjOcoKPQ5EC/3+wAXg0Gbn9vw3As04 EBwD0AOM+JMZIZvL5K6qyH7KqtUJr5sDZPiCkwOTH3/nStZPSmJ5G/iFR3+wLfocgEaF 7yfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107933; x=1741712733; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VXesqtK3A8i6ZSMFwP8n6Z6kZDUFNsTogrZxF0Gh9Ac=; b=h/+16S3+Q6zJ7q2k/gtzZwT4/UA2RTqVeM8ZTuHqqevMhHIkn82YWvurwZfu5u5q+N eZnfbquQIOlD55TwrMctPGY1hQgqx9bJ6OJmBEk8rEen1cmQvBQoW3BHSJm4TX9WZXAu JuGemkjTgFOXRugI1sdgkMXvTiw9+VM7Jk1LFNb3AD3uKXm8SPqaWA3BOmHPHDy+f33c tQ3AXLMiHMCNO+FPbs0pnLI5e02VoajR7VsUXSfHww48i5t5sRonVEKrmmzd12TIeeP3 eeMnQQV9F7oWRIvvO12PGhBXREQCLUfmRVAHvvd67ZUeDp6lv3he9ccogMrSLS129Qua 7BIg== X-Gm-Message-State: AOJu0YzHbpEeeTNHkuFSCajekXqbPtk3VtJEwUvz5ff2TkQN4CmXxnfW MMIF8k7M09x4FSwVjOZ7V31Bvz+vJ6BeH5581uKipK1YH7AcsDhAdrROsO82be8= X-Gm-Gg: ASbGncuT2C4ZrYEmp/KtmnOZMpoox5rfyllppDygZgyovgA9F8ucNQ4H/103dEzpR3a wFAsxqlbYUbwkKYlJVDB8h3bUnLK0RU7xDaaxVFk+l/uIGzzdUNNKVYc6CNPp1NhVsXXl5hwAU4 4EaLAoM77s8qZ+xkmdpKw1Yn1pKnglGk3EYjh0eL8+8EF05YJRi4Rct55bdLmbv+BcXQivBXHjv kecEm1bQ+TRiC90b2kssjVbVP9+DN9Iu/i5UtuCFFRD3y6IRvdGamH1YekDM4AtWGFoG6bxx8kH ZUZStHepVH03V/fZspCsfwbNnbi5+DijVej7RT+awmcfLcg9447Fdy3FpoiLKKbBxeDh/2PVesi 0AZURqxqu+KwEA8WiwQqjNjXiISZK X-Google-Smtp-Source: AGHT+IHVbcY6l9+JTAHHIw3fmIWanoQo+sapqWdolutCogJsq5sGcHSbYPT4D1lGvFYrwfxZJsMGVg== X-Received: by 2002:a17:906:f5aa:b0:abf:59a3:df19 with SMTP id a640c23a62f3a-abf59a3fa56mr1580793966b.57.1741107932647; Tue, 04 Mar 2025 09:05:32 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:32 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:30 +0000 Subject: [PATCH v2 02/16] rtc: s5m: drop needless struct s5m_rtc_info::i2c member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-2-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 When this driver was converted to using the devres managed i2c device in commit 7db7ad0817fe ("rtc: s5m: use devm_i2c_new_dummy_device()"), struct s5m_rtc_info::i2c became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andr=C3=A9 Draszik --- v2: * fix arguments to devm_i2c_new_dummy_device() - too eager sed //, and gcc didn't notice, only clang :-( --- drivers/rtc/rtc-s5m.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 36acca5b2639e272dd9baed06ea5582f635702b0..88aed27660348a05886f080a284= 8fcabbf9666d0 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -146,7 +146,6 @@ static const struct s5m_rtc_reg_config s2mps15_rtc_regs= =3D { =20 struct s5m_rtc_info { struct device *dev; - struct i2c_client *i2c; struct sec_pmic_dev *s5m87xx; struct regmap *regmap; struct rtc_device *rtc_dev; @@ -640,6 +639,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) { struct sec_pmic_dev *s5m87xx =3D dev_get_drvdata(pdev->dev.parent); struct s5m_rtc_info *info; + struct i2c_client *i2c; const struct regmap_config *regmap_cfg; int ret, alarm_irq; =20 @@ -675,14 +675,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) return -ENODEV; } =20 - info->i2c =3D devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, - RTC_I2C_ADDR); - if (IS_ERR(info->i2c)) { + i2c =3D devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, + RTC_I2C_ADDR); + if (IS_ERR(i2c)) { dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(info->i2c); + return PTR_ERR(i2c); } =20 - info->regmap =3D devm_regmap_init_i2c(info->i2c, regmap_cfg); + info->regmap =3D devm_regmap_init_i2c(i2c, regmap_cfg); if (IS_ERR(info->regmap)) { ret =3D PTR_ERR(info->regmap); dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C090B28D0B2 for ; Tue, 4 Mar 2025 17:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107940; cv=none; b=BBQxSpdepe5or4+3LFrMB+rIjVQgYDJVyjEYxEM8gV3Xqx9JGpF4H9z0W7e1ZPW7tumE1/i8SOXajXbTrhhJwokmhTNyGheFdVAXIaWxEdMDhNH4aZrPq2rhvTZLMPju0Hh9TBap7fjre0t0FUqVl4uHAMrn6wRb+ikZjL0Ud7o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107940; c=relaxed/simple; bh=ivQXoPCDvr4W65W9v8GXK5+RniJhnQQTUBGH5MrKnmo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qfBoTsghkkX/0oN4CWF5ZR3NmWWyCIoraKB3M6EoqlyE7vtRvL9vkIBC41CrO0nNthk1GQMMTjZ28jKc1HHjQftIxAT4mNNP3aqPX1Rh0wZsu8meDY2Ba0jwuzeTWn8VDPch1dZlW116vzB+dCAWRgg5/DdhdCcKEORZwCoOkzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jCztyC70; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jCztyC70" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-abbd96bef64so923010566b.3 for ; Tue, 04 Mar 2025 09:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107935; x=1741712735; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=jCztyC70CPhDV2/Nt1knWpEikWy5/LpEkyynF4etebkW8UcIoQLdwPw+PvjQhxfm1E a2KM10bMoMS6C4GpXRZq97z3TXUjgo6v+GIVYJ+7UwJgH9mgYZZvcMiwtoihJSaVjkpL sg+ZB+dFmJ4SVrsIVge22fvi7DbktqRJHHi8sG2JWat+y7hHSHXMj77rMsQxkjoWo9hw mXEZLxnrmntEVaGWMBCrX6Yc82MQ1v87m29Bpk4ylpK5p58Qjd6qKVUTWse1ulPiLECs s9S788utMoPGt3PB1l8JIHL+XdQ3OggzDO50J4aMrOyuWQM/7zURWWHOwR5PWTkSLdVq AYDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107935; x=1741712735; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=sw2PWRz8lO59/vBBdowY0K9wmbrqp38U6MYtknRWWNj/agVBSkdixKaoR9SGuKt0nl mE3nfqLcWsl/dG90M5D14J6wRycMF9gapTPBz88AjoEbDAsBFEI1PzAZ0CMKC70p+IVm cyT35iLDRoN5wd99W0QO0IS+u6mgZH3hN/1gmAh5Bm6HosalfbTSwXEFuqTi0QuOlxPz UrB5x8m/IJEMBpMf8WP5zOQu+2rq6QkbJ484ZqDF3RqJJ/PbZGd27LkVjm9AaOvZtbDm u8geEBYNl/5Hwi7VgcS7rH7MHckvvon9I+LCLzyBPKE745jn9e3KdCFDjhypAIGjygMC TN2g== X-Gm-Message-State: AOJu0YwQ319vvy3q3UgQNJH4nSNFzDbTb7LikMnvcSIvgwBKWkQZDVhp 6WJIlwGwqHPplzg1blqf+wVGvQixwcRlphogSD8EYtly50x8XWwWY+fPo6wM5ew= X-Gm-Gg: ASbGncsJiTnroMHvbBC4MdMrqV23Rt+0WeCguSJ7nMI+uRt+w/WU7ex9oh0Yvomr48h yC0kvhMHF1Ivwf6Z7DXBPPAQcOzPt5vttCp2lJ5KCBr+Uw7etu+0d9KtfCYHMGDp+gNkYwsfWye YvwvF87ci5eEQJZz7X7nD6f1ach3FnljABCLJwuTt7+ysenfkyUWenaRbD9AKJt7RN4HO+2AyEE dNZbVl7FicqoTL1EnAmdpko35XGGp5iq18394EQq1WeGCXgYbVvOyPoF5I/QDVWW/GPiApccGAA pOo4jHktBGfWl3eJjI/zmE72a0aSy62VZ9ghIvtP+L/kvwEG1Sud8Ah9HF5eqCsikK24znaTlLE 9fLESMlFJp8EBoGNvyR0Nrdf+RR+x X-Google-Smtp-Source: AGHT+IFwDsDh5i25qijWXwIP4x1jml1OHqbOIRoS6nzVQBGxqFZ6SJJ2B5idZS+kqD7e/PzkpEaGBA== X-Received: by 2002:a17:907:9490:b0:ac1:cceb:d9b0 with SMTP id a640c23a62f3a-ac20d8bcf0bmr3896666b.16.1741107933256; Tue, 04 Mar 2025 09:05:33 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:32 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:31 +0000 Subject: [PATCH v2 03/16] rtc: aspeed: drop needless struct aspeed_rtc::rtc_dev member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-3-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-aspeed.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-aspeed.c b/drivers/rtc/rtc-aspeed.c index 880b015eebaf796f68ed82c29998f345e1fd418b..0d0053b52f9b90a61725bf29435= bfc8071977f9e 100644 --- a/drivers/rtc/rtc-aspeed.c +++ b/drivers/rtc/rtc-aspeed.c @@ -8,7 +8,6 @@ #include =20 struct aspeed_rtc { - struct rtc_device *rtc_dev; void __iomem *base; }; =20 @@ -85,6 +84,7 @@ static const struct rtc_class_ops aspeed_rtc_ops =3D { static int aspeed_rtc_probe(struct platform_device *pdev) { struct aspeed_rtc *rtc; + struct rtc_device *rtc_dev; =20 rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) @@ -94,17 +94,17 @@ static int aspeed_rtc_probe(struct platform_device *pde= v) if (IS_ERR(rtc->base)) return PTR_ERR(rtc->base); =20 - rtc->rtc_dev =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(rtc->rtc_dev)) - return PTR_ERR(rtc->rtc_dev); + rtc_dev =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); =20 platform_set_drvdata(pdev, rtc); =20 - rtc->rtc_dev->ops =3D &aspeed_rtc_ops; - rtc->rtc_dev->range_min =3D RTC_TIMESTAMP_BEGIN_1900; - rtc->rtc_dev->range_max =3D 38814989399LL; /* 3199-12-31 23:59:59 */ + rtc_dev->ops =3D &aspeed_rtc_ops; + rtc_dev->range_min =3D RTC_TIMESTAMP_BEGIN_1900; + rtc_dev->range_max =3D 38814989399LL; /* 3199-12-31 23:59:59 */ =20 - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); } =20 static const struct of_device_id aspeed_rtc_match[] =3D { --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6B2F2857F1 for ; Tue, 4 Mar 2025 17:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107938; cv=none; b=Z3UPUPFJzV4oFtjDft2dASB8ms1kE6wr1yHo/d2o4zmxDNUYcZlq0lSdyBxSLroqhBl1REc4aSKjxCrOi69r9eIcE8q9qIV0kKTwrnnGgqLMkCHaGQpGmFw6B6JfoAMRjxxkzBAgnInyOTncy6ETy2F1HznhoNaaKUV1JQpTHK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107938; c=relaxed/simple; bh=ako7uKkoy0pcKOqw3JaomEgmXiZMMPwkguXI68dLj6c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=piU4q9HhVuTUY/Cnmtu+ySsBNdFoRMq3lGalnIGn7HtA5ua4oWUSpV9Aotuwq9rITy8r4SOEHeLABfsG19zBKWus8ldgRv6/VZEQJ6wX9uZN7PojL3sV5sTSGJJGT5ijXMtdm+47yGfaABeg4z3x2USpStxniL63xCfJT+poRqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bgPOHsqR; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bgPOHsqR" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5e0813bd105so9364089a12.1 for ; Tue, 04 Mar 2025 09:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107934; x=1741712734; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=bgPOHsqRQxEF2wX44C1FeYmeboblVNTv4TRe0zTDsWDyWKxbYq4M0KU4YMxFBKkZvh AVpwTrTIA8prX++JKc1bK1LzaGP0VaiwOK41bYz5yYmUNxKMgfPkaVr6IiUW4qRrPzzm hRwtkBuQMPcWiTrRUD7x7Ov5vef6tyuGjTqSJQ7t0ofbReduJp0qJLEHjNrIkarf9QC+ +xVaMmW53ODzxCKWIe+BaQL0B/191VL87RFNcUANzzpIsUn0w6BatW0ZWD5k81gMGfe1 k7sws2WpIkGrenpZA0Ghaknwn2TYt7slPg7pKzUHMefnnXa1UIrnh+jAU4LGH9/WGYzh V8Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107934; x=1741712734; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=xGVaDiVKwd2uRaFR5xQQKpxEAJ/YyW3hTRC0WB+BbtgurZq7wi9ncLoxOZupVmxK3h 7JwGed/KPnXVfh24zNj5628CkRwhJeQ+KuiK3uEeWe3Nq7RtOiFgNNTwupNdBq3dO6aK ZMFq/CDd5ZQpzjWaJ1OvZ2/hU8Utuc4iqSyE4AMKYicHBeu1liZwXzSG6B10FEf2kUim SW6uCQjhqrxfGEXX/RnksLNoAnFlDrDGRwjDcAm/ARF/dxtJzCep7bx5GbfGhVbKtUry HuD0Q4/VlTT1mysgjE22Rq32WpsMZliU4H8t+974YWRQKOR1Lq1Iyjy/lH26S/cbqVJs hx3w== X-Gm-Message-State: AOJu0YwhcOU5SrumvZ87zfLJVZSsHykw+rBjMHCEXJprcXoxMgJsjqcS lQL0Iza3OTncOYwFzS5a/2nM6ISTTyI1+iz0VS0MH6YHk9eirRVAmm1yG+R9b/c= X-Gm-Gg: ASbGnctO2G1ln1tBo71BWtC6VAnHTDEOesIGvkpAbHcuPOULklgBk49MxXV7Y2HbLwt IzfPHIzI+cdHQ1PGO+G0+vnKkM3REh0A0Ca8E2lXUZ8foGoXupTxtVHQsT7abKnS6W0QZqmkWQA OZFiXM5mANyWnXpoyRNzEt7nLhcoymty5jQaEYyUfcDq6LjuBqUvuwub4chak2x6ti5+t9qfdbE dB+Q8fGH9SNZs+KAxAVtXdpVm0AWPQeUJ30Cd+P9r/0XMPpAoXfPJ9SD8sxg2TiVqMyiGMpDey0 TcJx9/RqmA5JsLyBo+55broaJpXpwOJAd90adH0Eile35wREivVB+3VgP23QGcbc3w/LAfuegAz yIywU2gVTEDbWpF9eARbF5MVZtDOX X-Google-Smtp-Source: AGHT+IH7IWkH6sGgCqXOqo1X+qUMKDFtMNOejwKoQaGxlKvxwXw1Icl3WBZaF1ebexseFdyLVEv5Qg== X-Received: by 2002:a05:6402:847:b0:5e4:cd5c:50f6 with SMTP id 4fb4d7f45d1cf-5e4d6afaf1dmr21403911a12.18.1741107933866; Tue, 04 Mar 2025 09:05:33 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:33 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:32 +0000 Subject: [PATCH v2 04/16] rtc: ds2404: drop needless struct ds2404::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-4-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-ds2404.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c index 3231fd9f61da49bdaf00e46486fc34836094ee78..217694eca36c3432a8db3b87437= 4e347eeb802d9 100644 --- a/drivers/rtc/rtc-ds2404.c +++ b/drivers/rtc/rtc-ds2404.c @@ -31,7 +31,6 @@ struct ds2404 { struct gpio_desc *rst_gpiod; struct gpio_desc *clk_gpiod; struct gpio_desc *dq_gpiod; - struct rtc_device *rtc; }; =20 static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pd= ev) @@ -182,6 +181,7 @@ static const struct rtc_class_ops ds2404_rtc_ops =3D { static int rtc_probe(struct platform_device *pdev) { struct ds2404 *chip; + struct rtc_device *rtc; int retval =3D -EBUSY; =20 chip =3D devm_kzalloc(&pdev->dev, sizeof(struct ds2404), GFP_KERNEL); @@ -190,9 +190,9 @@ static int rtc_probe(struct platform_device *pdev) =20 chip->dev =3D &pdev->dev; =20 - chip->rtc =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(chip->rtc)) - return PTR_ERR(chip->rtc); + rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 retval =3D ds2404_gpio_map(chip, pdev); if (retval) @@ -200,10 +200,10 @@ static int rtc_probe(struct platform_device *pdev) =20 platform_set_drvdata(pdev, chip); =20 - chip->rtc->ops =3D &ds2404_rtc_ops; - chip->rtc->range_max =3D U32_MAX; + rtc->ops =3D &ds2404_rtc_ops; + rtc->range_max =3D U32_MAX; =20 - retval =3D devm_rtc_register_device(chip->rtc); + retval =3D devm_rtc_register_device(rtc); if (retval) return retval; =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8517628D0AE for ; Tue, 4 Mar 2025 17:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107940; cv=none; b=pSjBJAd163ku67wNAQFtIFfSpkMYgb9NKYec5zFQeHq5UiIdBKwdINFrKI3tdsloqPfvKshvyi3GqJ7AhLLkzSgZ5tU3SQ2ZiHsgDSw/Kf9igKvvRbbZiJTYwllBjwzNeFrBxvhU1p2mKPS1yBQA90dARa2FxmokpClzllY7BSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107940; c=relaxed/simple; bh=bdvX1BNhSG2fpjHo2VIxHhZrYGN28llP3/MopMlEtfo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LTy3gaizYIqKG5TsechVw4pBAf8mzDolG+3ZQarDlvpzZ7J3bkef1+PrJGZ+0oKmecy7WEE5fbMuuV8tB+wepoQHFlMA3Kd3gbAMqS9fYlulIlWTU86p8Gfal4bIyiNO9PnqiRuvZJbZufo2a9ZzNDBa7y8X+ChzerIaMiQGx/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zgH5+x53; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zgH5+x53" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ac0cc83e9adso20066b.0 for ; Tue, 04 Mar 2025 09:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107934; x=1741712734; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=zgH5+x53GgY567EAqrqQQRqhEWpQo4fbGGD9KCWkD13ACPz0pLbH0oILvZkJP/nOZy 3YVf4fEp8SBgheguN4RmtUYH+sS+Dput4mpcyDGPR/mkh08N+fdLLuiKbJHIDLHxQMcJ JuWy8ukcyWnUriTTB0ZlqmmSWiU9bPn88QAqT+Vnnfdg8cdZWm0ZSH8VXxVCLUuQ5M58 KVR1eVChRiJZNLjExmO+1aDTcBvfKiVJsVyz/zn1vJlCzqafEFVPUkbjByDTx1dXDbp6 hE9aZNR5sxcQRuzbjNlVfad39mh04vBdFVRdPYhfYhrkHbCiETHwOOYzquwiqDsRykp7 4JHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107934; x=1741712734; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=ZuSuP9fC5ySU9ViAkr9o5brZfSLRaLb/r/frSogl/3PZS0KDDW75qhR3OVCDQbDQxJ SlTYqv2EO7TLxEKXFUbH7q2+WPtuxnknZFlsZEkuCFS7IhIXekYyfhaTwbc9PU+nRPIU soYH8MOF2e0twmmpO8CtNijCDrscrZ2Z4M0idlOupxUurtu+K2f2eETMLsJDewEDPmil TCSkVmrej9PgYa2BQR71mPpaDFLiTgkJSa1dgQA7Toxfz/IKYHFH0nujacW1MIEulugC /wbuGfMC8O1Fjzo9y6Qs3OF0UWjAsUAQIm4RHDrmqqH6AcAXNdzcUD/fP4n5TWnWlYZY yN0A== X-Gm-Message-State: AOJu0YwJP6eDwBdi6ySdcj4R5bQLCSpDGicUuGeK9Oh7MsM82IRMcrre WvYFx86ssqQ4juC5dz7meynQNMJKKzLFnho01J9piQpJtiAa7ayNnmiu11r97Ng= X-Gm-Gg: ASbGnctl3EYut13j/TEMWz9tXVlDequBC91SQdUmnvCJgJ4PUtluHH89hXagxO0QCPk 943Txm8J67eG8t9+VzZKszncyMd7h7oBeuwBDXbbePF6luAKb0TsWjnCWSLyv6nJjJllfBWdTqV mOxErnOYKLI1IMBopskikJPMGlpddRlxub7B6P5uNJk9O//zIxzw9yme68CV52pN11AZkfaSkZ2 mvHbXKEm1C8wJ16uyMucWBPRkdolEO3fo1t6mMOOIsYWGu1lX15qx1kcNtRysV1TuRxKe0R1az8 rMfZSCiguHSySjcBosA3mNHYIwNM00JaXuoCgq9uYze8P6eGZn/KwYHuR2NR26Pd1taHnUyCpsG ep1hgtrmbQlD8kNw1FcfC6TZq1aJo X-Google-Smtp-Source: AGHT+IGsdjvAcycMp31oFEdsdwWFqJQmXbxtDBoL5DRz6SC3HgSNRmbkL1ZXNDzmFm2b5aF1OyYNnA== X-Received: by 2002:a17:906:c150:b0:abf:4a62:6e5b with SMTP id a640c23a62f3a-ac1f0e60023mr427555766b.5.1741107934486; Tue, 04 Mar 2025 09:05:34 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:34 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:33 +0000 Subject: [PATCH v2 05/16] rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-5-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-ep93xx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-ep93xx.c b/drivers/rtc/rtc-ep93xx.c index 1fdd20d01560ef4fae2b996cf366b4f812329225..dcdcdd06f30d1ff6d0939f6bcad= 2c17c03c5a65e 100644 --- a/drivers/rtc/rtc-ep93xx.c +++ b/drivers/rtc/rtc-ep93xx.c @@ -28,7 +28,6 @@ =20 struct ep93xx_rtc { void __iomem *mmio_base; - struct rtc_device *rtc; }; =20 static int ep93xx_rtc_get_swcomp(struct device *dev, unsigned short *prelo= ad, @@ -123,6 +122,7 @@ static const struct attribute_group ep93xx_rtc_sysfs_fi= les =3D { static int ep93xx_rtc_probe(struct platform_device *pdev) { struct ep93xx_rtc *ep93xx_rtc; + struct rtc_device *rtc; int err; =20 ep93xx_rtc =3D devm_kzalloc(&pdev->dev, sizeof(*ep93xx_rtc), GFP_KERNEL); @@ -135,18 +135,18 @@ static int ep93xx_rtc_probe(struct platform_device *p= dev) =20 platform_set_drvdata(pdev, ep93xx_rtc); =20 - ep93xx_rtc->rtc =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(ep93xx_rtc->rtc)) - return PTR_ERR(ep93xx_rtc->rtc); + rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - ep93xx_rtc->rtc->ops =3D &ep93xx_rtc_ops; - ep93xx_rtc->rtc->range_max =3D U32_MAX; + rtc->ops =3D &ep93xx_rtc_ops; + rtc->range_max =3D U32_MAX; =20 - err =3D rtc_add_group(ep93xx_rtc->rtc, &ep93xx_rtc_sysfs_files); + err =3D rtc_add_group(rtc, &ep93xx_rtc_sysfs_files); if (err) return err; =20 - return devm_rtc_register_device(ep93xx_rtc->rtc); + return devm_rtc_register_device(rtc); } =20 static const struct of_device_id ep93xx_rtc_of_ids[] =3D { --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7822C28D049 for ; Tue, 4 Mar 2025 17:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107941; cv=none; b=FcyT1D8pipPsRGK2ZUAGqTYUUyLmFlM1ZN+5DzCOqRxoU673b4MUjF5db6IYtd+fo1HQg/DOHJN/ImgKy8IPYHdUJDC9rIaz2SAWflD1+laeoqWUUHt1Az0V3ggZfIEjWTh8WE0s+xmpE547h3L9VDacxxOcU7vLXv1vBZNbJ7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107941; c=relaxed/simple; bh=5X/V6j0KylZQYS62rYIRbOgl5vZsHZpGMMFoDJktKBs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RfuirFs4EZqx9SBC3mgtppwuQKZIXEM5o3tp2T3qo9R7HfHi7tMkhlriIcIsdL7/ru3eNhok1cdGljeBjDCQurT1stOarmeZC/yp4r7+dKH6otm8EgwZZkpqD8MH71HI/EP9GyeqrbvunbsgFp6Sd9EN8SVZtwNGXQQ0qDf1cgk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xQzxr+/i; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xQzxr+/i" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ab744d5e567so998012966b.1 for ; Tue, 04 Mar 2025 09:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107935; x=1741712735; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LQ1rnmYNsg12IhA38qEJtyyMHRjZg5dsRkHMsIbiHfY=; b=xQzxr+/itgIRLv26IdzqbvN2KzIxpaBes8rvZIGhFUVBPxXQOcBugDgufa9uDOvCgg lWAHsyvVwG3IlvCkPdq2k99TqYN8FPvGtHm9y0MUKc1aLAeWgGk4PbLy4LkTg/I7y3rH 1rkqFG6o+N+XTH1VEL2OSrgeK+hNYLH+yripsc+i49MEYZT91UXSbQD22qfp8uxJwbTX 372emBqGRsl9yNXwyjzq2LBDYXqcT0ee+o4o3GskDqJaprn13m0JVldN7vrTEZz7f17L WaeMVWkaYIbanusqA0l1LddOTAYZ+WAGRQFfouLLVzwrmNcl/hg4ZRc+3dufDhPfhAfh BV0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107935; x=1741712735; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LQ1rnmYNsg12IhA38qEJtyyMHRjZg5dsRkHMsIbiHfY=; b=NHZxrnwonA/M6ldVRRYE/GlaVtkbIj7JF5frMXl6EsccbpNxdahzVRTkRZRLDdDwPt wiibFwHez6JkH5FcUccct0IYwKfIS6yHGvh7wnvIQLAxle5aEa4YqznT96R+rXvtg838 e0AchQAv381YD1A45BnxPbcZvQASbQWCjrqekB/5Fp2TNHsoOsDSJR76Gw1AxIh3IKaS PbpOg+2LC6FUwkLp+Vpw+g/fDjHj9ir9hdyudzKwsJV5FtH2358i3xwZPSBNLBKc17LJ EtatgGgwgxypfu14+DnMgP25OKzjBKhVpPI7OpeFSclSOeYWLXe5FtAW0DfTIL9CL/tS 1zmA== X-Gm-Message-State: AOJu0YwcFBmB0IOnn0zBvNLIVsm9LUXGcbmR5ldJMkTNUzkJFJIM89Ka 4QjcEPlfe4jIdltsTUOYjIEJO9bMMsHaHU1xrXKDNK5ZKkZuOH4Adq+V0BA03g4= X-Gm-Gg: ASbGncseC+Urdn3zzB0H3g0hL1WoQSq47otG8gl0+eujYA5/Gd0VDmLSDTCaIoK9GpN 6Yb+LpeZDNqJI4WFjHRsCHAsUPKKlmLCkEdGsV8QwfGc53wt37vzIBsJ/v+ENDFbIT+ezQ0eFh6 s5JkdsVrcgR11X8vOqKIg+LCZACEyM1CFgDi6oXYSheOzJ2tuuN/bkzI++R4TYucoHEQNYmPhY0 0+BVPH7Ei6hnJpEbRTLt4+rDuS/hDwXlsiOh12Mds6gA4BLrq2NTiAUqsD7shC4AZDL1YamOnZm SG9CUpnVzGzbl+UCTGsSPu+6OPZAZYTxVXmydkBg5DG6wVB9AReW5rQGcwbQmrRRmp/MRlTSctL omIe2u8zlX6oCsTsgbzJIEpMWiMlm X-Google-Smtp-Source: AGHT+IEctYzZlVVwQPucj8CUHKEVuZPV8n583Yq6QohmEvkW8JU3S9SRTA4/uuDakASHnMKJ8bAleA== X-Received: by 2002:a17:906:3814:b0:ac1:17fe:c74f with SMTP id a640c23a62f3a-ac1f11e6c1dmr291303166b.21.1741107935167; Tue, 04 Mar 2025 09:05:35 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:34 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:34 +0000 Subject: [PATCH v2 06/16] rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-6-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Linus Walleij Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-ftrtc010.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index cb4a5d101f537e20a685bb022e6f6516b0df8271..02608d3784958e69ec0ecbdb9fc= c8b333b19e7cc 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -28,7 +28,6 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:" DRV_NAME); =20 struct ftrtc010_rtc { - struct rtc_device *rtc_dev; void __iomem *rtc_base; int rtc_irq; struct clk *pclk; @@ -113,6 +112,7 @@ static int ftrtc010_rtc_probe(struct platform_device *p= dev) struct ftrtc010_rtc *rtc; struct device *dev =3D &pdev->dev; struct resource *res; + struct rtc_device *rtc_dev; int ret; =20 rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -160,29 +160,28 @@ static int ftrtc010_rtc_probe(struct platform_device = *pdev) goto err_disable_extclk; } =20 - rtc->rtc_dev =3D devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc_dev)) { - ret =3D PTR_ERR(rtc->rtc_dev); + rtc_dev =3D devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) { + ret =3D PTR_ERR(rtc_dev); goto err_disable_extclk; } =20 - rtc->rtc_dev->ops =3D &ftrtc010_rtc_ops; + rtc_dev->ops =3D &ftrtc010_rtc_ops; =20 sec =3D readl(rtc->rtc_base + FTRTC010_RTC_SECOND); min =3D readl(rtc->rtc_base + FTRTC010_RTC_MINUTE); hour =3D readl(rtc->rtc_base + FTRTC010_RTC_HOUR); days =3D readl(rtc->rtc_base + FTRTC010_RTC_DAYS); =20 - rtc->rtc_dev->range_min =3D (u64)days * 86400 + hour * 3600 + - min * 60 + sec; - rtc->rtc_dev->range_max =3D U32_MAX + rtc->rtc_dev->range_min; + rtc_dev->range_min =3D (u64)days * 86400 + hour * 3600 + min * 60 + sec; + rtc_dev->range_max =3D U32_MAX + rtc_dev->range_min; =20 ret =3D devm_request_irq(dev, rtc->rtc_irq, ftrtc010_rtc_interrupt, IRQF_SHARED, pdev->name, dev); if (unlikely(ret)) goto err_disable_extclk; =20 - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); =20 err_disable_extclk: clk_disable_unprepare(rtc->extclk); --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E397C28F936 for ; Tue, 4 Mar 2025 17:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107941; cv=none; b=d458bUjsEOtrG3dd69UCEk1CywJauf+3IaCHRfQmj18eCEKDxsVaFGl1VhHBZmYaPr0/7HZB5xN+qoQ4UjahE8NBMHWEjUo5vdkXyVu3cbndv7Nj1LBUcR5rLhgwptiR0CwJxymWg/w0JR6sM8Au8RVxL20aKa+vDlzmh7zF5DQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107941; c=relaxed/simple; bh=96lokglM16xoW0bhDeFwQgKQck5a27ZC3KAyN/gWBFc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IZ600rSuM5nyoac6rMA8WsCU+6eRy3D9HuW1UsN9nh5t3S8C3p7YycvK/Xyg6iynR2LQ2mp0Lvv6tw6aBPyOhEQKB3FHm2goxAHB3GLgUOkMfLj0aJOjQcpZUna8+/6q9wXj6p82juYfeVPVJrTbjmK64mms3BkW8UhZSIjxyHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Yzzuqai5; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Yzzuqai5" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5dee07e51aaso10982851a12.3 for ; Tue, 04 Mar 2025 09:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107936; x=1741712736; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=Yzzuqai5vbcBrELh8YrsFumNOnIb7D0hIK5fEOQVxJZe7mhnE64OqM6RSzRTqBgrFM rfbqFtT18mU/GNf6WRXhnYAs6pneEoRn8nNvhb9H3kzZdpRYeI3+bVTV0GYuOIwpjJNz RPCdFyDc5w18TadzAqpPImIMYBoxzoKJZvcxXEelBJ7Wjncqwf1heXTwvIITWu5dmI5T VRZlrK759CWXe0evHhMOPKlKpZqC+bS8MIPU6+bsC8bJNnFpr0hdB3qflWh2gQj8RwGA RGY3nd5LDdqIycbu4vjjKvrelcjBFc049sJpjjb0D69fzvG3ZWdIpGa+o2CavYnGifMP v0/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107936; x=1741712736; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=HiON5lIt5VKeoWwwXR3Xy+aDT5qDnmeUueLeIc/Oi/BerU5c9pBGdgBvoV3XOPWqUM ia+sn2Cgc5ND3zK3tKii7/RzDuQGc2wZo5JKWgxqOjQo5Y/Qj8TWhge3bIQjNFaY8H/d PoXDFiJJtIDdV+O9cyg3RPkATnFKbXJTuKnhwLkrD/s8J9FEAJMO5JzYdVRBpOwmx5lf n68IGuGEmkfYC7R1VjVyey+NyVDQdaUAA/xkiJ/UgjcOPzoykDYPtQPhtW0zwm5ZV1lo qWtpbW8iLfLS0olvl6x04iarsxwizsRoBaV1Z2DkBu74/INmDS4DcNTVoQ4P7AYlRX3f Sqsw== X-Gm-Message-State: AOJu0Yx8e6tUG3xwgPGXSXEU5X1Fy0c3CvHkUdL2AlSd6RB4pLDgL2Je asE08r2JJCwq41oAcvtEFiOB9xfYTst7EjFztrg3qS09eaXEG58Hf8/Gs3jgxzw= X-Gm-Gg: ASbGncu9NSmTjrZB7PWinmjnMkpEnHvlHoQ3wOLXMfCGw+dxZmia0x8EbToFCsWSX2l tKVjnQPtOZ9MXl/KxLX+ndeKsw7tB5mo9dW6csr9ErNmyHzsOw3VWEL7zD0wIahMVPddwiwKGFi tGionLQdXB2PyNBXzJe7zU4FhomZsNvY58LRBeotNoUcCWc8zTeiAK1PmKVlP1xk2r8huYVOu8u ovvCypiimG28+E2HtrNrtWAqtn7QcgDWhxdvvENN7wTNHxNpBVxz96Z2JLFHHIXkc117AdM6oGn uHbqCZwgqtTruY/DFPWRb/ZHeP+keGDSshIGVo/hEYAIqZCtzH+EGJ1VRqE2oRFcuiFRZEaqMpM 08YOBMZsZvKml9P85WpE0KlProYMq X-Google-Smtp-Source: AGHT+IEZSM7e60umftuoTA+5yHKxOw5bEfyTXKI9tFiIm+4qyPCIhcf70tbw/wLp28VjnQQVfyBtmQ== X-Received: by 2002:a17:907:c2a:b0:abf:6b30:7a94 with SMTP id a640c23a62f3a-abf6b58f60cmr1276559166b.45.1741107935884; Tue, 04 Mar 2025 09:05:35 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:35 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:35 +0000 Subject: [PATCH v2 07/16] rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-7-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-m48t86.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-m48t86.c b/drivers/rtc/rtc-m48t86.c index dd4a62e2d39c73b1c8c3f50a59fd4fffc0b45105..10cd054fe86f9e6be74eb282222= b2751dd91cc7e 100644 --- a/drivers/rtc/rtc-m48t86.c +++ b/drivers/rtc/rtc-m48t86.c @@ -41,7 +41,6 @@ struct m48t86_rtc_info { void __iomem *index_reg; void __iomem *data_reg; - struct rtc_device *rtc; }; =20 static unsigned char m48t86_readb(struct device *dev, unsigned long addr) @@ -219,6 +218,7 @@ static bool m48t86_verify_chip(struct platform_device *= pdev) static int m48t86_rtc_probe(struct platform_device *pdev) { struct m48t86_rtc_info *info; + struct rtc_device *rtc; unsigned char reg; int err; struct nvmem_config m48t86_nvmem_cfg =3D { @@ -250,17 +250,17 @@ static int m48t86_rtc_probe(struct platform_device *p= dev) return -ENODEV; } =20 - info->rtc =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(info->rtc)) - return PTR_ERR(info->rtc); + rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - info->rtc->ops =3D &m48t86_rtc_ops; + rtc->ops =3D &m48t86_rtc_ops; =20 - err =3D devm_rtc_register_device(info->rtc); + err =3D devm_rtc_register_device(rtc); if (err) return err; =20 - devm_rtc_nvmem_register(info->rtc, &m48t86_nvmem_cfg); + devm_rtc_nvmem_register(rtc, &m48t86_nvmem_cfg); =20 /* read battery status */ reg =3D m48t86_readb(&pdev->dev, M48T86_D); --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB7A528F952 for ; Tue, 4 Mar 2025 17:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107941; cv=none; b=XpxFO6Ktn1mBAPcZoiUCYbfcnuaCtJ71MyZmV3NqSPx3zvlIKbH38ocr1b5lBdtfbe0mAyXxvfAyHxbxifqZqMoMcBk3spmZ4eo8ewdTnfAkBJzoeNw7xDWhCLQEU/cBPywionpeHDMxe17hI2orTeUjcFoZBsEwCemxSv4GEC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107941; c=relaxed/simple; bh=O7YHK/iXPLW7JvXPCw3QSGcpCg8mcQhvQ7AlODxEgPY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gpAPLNgnfNT92ZWG9Gb1Mw8a09XfZQmwTEd4mVgoigEhR3gq7QVVoP3eoey2x9q4gtFAkfm6abwCOn4UToR9QeU7rY0X+mjB0EUISeFz+GBmEUv04hG5l1r/2ZzH4Nt0c0Hv0Zc9sEzyh5N6MAH52fqaIrIQdZKb8eRtt5uih9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Zx4BAc4r; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zx4BAc4r" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ac202264f9cso95920966b.0 for ; Tue, 04 Mar 2025 09:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107937; x=1741712737; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=Zx4BAc4rD08UzQOxlyt4V6dca3NMcXY+9B2U2agt8A0yB5Tk9EQZHVQXwJD8wPZOst 0FWKB/cHLxMjrD1arJ+tY1YT2UsZpDYi99GzoBWiaxNGss8fFAyuU5K1lrz3tGGJ2Ulo KQy3WaNsfbEnOBtXwnkAcvj8tr3Hp6sYeUbFLqjGeNnAekFkma6/AxGm0t+prNeRT4RO Z/bcWJBKWlwPXCdTrp1jY92L8m9OIfow1PlpJjnQ1FoUMk6lHRnX3EvAFkox6ivocrwK kMaKVtYnDZf5s0q45ys7iseZlfAEyABzobEXqH0GUEw8cq3mUjUKwlJ30lSfU7ktOmdP Gl0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107937; x=1741712737; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=EJyFLOxjGeVRWyzZ4+KsPrkBfq+P1BHqd5QaKbpSet1LAjhLsrJK2UErWp3k9unXcN pkDS/1woZOCsNMTCTTARATcz8RSVkqJw77PTNpSG0BJrxRQDeSUIWcQoPG3CMApl6wgW K9sEMXkiKbM4/NOBKnGQXRlsfCpDW9ny0KphWBhr7fwZ28afMM79N3+o0stnWWWUWIBF M0if95NEUExBEiwnfyeGo4UIueVc0MSgdh7PK4l1cCd+HSlwYgJl93Ffe0QtgwQkYD0Q ai943u6RNIm49ApAr+JmLmlpMtPwfUnQAuEqIc4u7Kx/p4KDeORHnN4I5hZ6TODCKaEA DtVg== X-Gm-Message-State: AOJu0YwnHrbIOPOtp3heVjH75EVAR6tIw/lyrJ1095H7PyQB8OtZkbt6 a3o6k4FW6gR5m8yGogB53cOojrtih5q50m2QCiZP3TYLt0tPmTMpeyvUY9m97r8= X-Gm-Gg: ASbGncvlN4YljIvi/SnCcQH9wZcy9lCtzbfsSyYVNcldhf4sQt+6VigUt/6GTNgqbpp 5h8GkvEAMHEWyqET35sBJFYv4g/qFnso6kFnWyWNtVasXq/cOi+Zfk+pvnRWZjROHM51+25Ho4B 0JZCVVG21MdP+Jj0+vtuYHFpJnZ/FHV+35kQTFhZy3LwGQMt+wyRO22J0AC4n7kESrl3GJCfmKc QSzH4PM4vTc1R6dxpMX8IGZslAjIRTsWdRsXKLwRCIUfOGRsVy8i0mPRXYahZ97AHvXVki+XnB9 XE7gG6OoFeubzjcmlk3uRHajSbRFiu8MfDUQ/9nKJRf64PtlOgOekTvozxFu2Iuw/AOUE3lCjYS KUyOdTMdtx5kTzqXRT9JsmCTUKMJ0 X-Google-Smtp-Source: AGHT+IH4UfROsxQRuhFhpuKVUGIkJvl9GfdlUj4CrGm+kiSC0tb2f0MQezXBSz1TfcCGXXToQh+ymA== X-Received: by 2002:a17:907:7210:b0:abf:778c:58c6 with SMTP id a640c23a62f3a-ac20dab329fmr1852966b.16.1741107936481; Tue, 04 Mar 2025 09:05:36 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:36 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:36 +0000 Subject: [PATCH v2 08/16] rtc: meson: drop needless struct meson_rtc::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-8-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-meson.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index db1d626edca5fbb590f26c1cdd0774d350244a99..47e9ebf58ffc2f2b6c65932f8ec= 3773a213a62ef 100644 --- a/drivers/rtc/rtc-meson.c +++ b/drivers/rtc/rtc-meson.c @@ -59,7 +59,6 @@ #define MESON_STATIC_DEFAULT (MESON_STATIC_BIAS_CUR | MESON_STATIC_VOLT= AGE) =20 struct meson_rtc { - struct rtc_device *rtc; /* rtc device we created */ struct device *dev; /* device we bound from */ struct reset_control *reset; /* reset source */ struct regulator *vdd; /* voltage input */ @@ -292,6 +291,7 @@ static int meson_rtc_probe(struct platform_device *pdev) }; struct device *dev =3D &pdev->dev; struct meson_rtc *rtc; + struct rtc_device *rtc_dev; void __iomem *base; int ret; u32 tm; @@ -300,16 +300,16 @@ static int meson_rtc_probe(struct platform_device *pd= ev) if (!rtc) return -ENOMEM; =20 - rtc->rtc =3D devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc)) - return PTR_ERR(rtc->rtc); + rtc_dev =3D devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); =20 platform_set_drvdata(pdev, rtc); =20 rtc->dev =3D dev; =20 - rtc->rtc->ops =3D &meson_rtc_ops; - rtc->rtc->range_max =3D U32_MAX; + rtc_dev->ops =3D &meson_rtc_ops; + rtc_dev->range_max =3D U32_MAX; =20 base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) @@ -365,11 +365,11 @@ static int meson_rtc_probe(struct platform_device *pd= ev) } =20 meson_rtc_nvmem_config.priv =3D rtc; - ret =3D devm_rtc_nvmem_register(rtc->rtc, &meson_rtc_nvmem_config); + ret =3D devm_rtc_nvmem_register(rtc_dev, &meson_rtc_nvmem_config); if (ret) goto out_disable_vdd; =20 - ret =3D devm_rtc_register_device(rtc->rtc); + ret =3D devm_rtc_register_device(rtc_dev); if (ret) goto out_disable_vdd; =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23D1528FFDB for ; Tue, 4 Mar 2025 17:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107943; cv=none; b=THIfhyu+y2yBm5TEyTJpeXZ7o2eChhYfN2llrVev2D7LNpJ8PLLxqQqJMDBhkf35R+pL9TTWWYwQpwFKRzROClWfeZz+UreJEHBQ/+vG79GZzwN5EiOHL2JZK8Da8q/LUQkEXrGPNrZx+fjB/rjuk6didY+kr/h3d5DrLtozyLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107943; c=relaxed/simple; bh=UGMJ3GCPyVV/uGz6DNqBy2mH3s73qryTRoU1mvi31cQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p727IJ2R/LOgc9j660AEYnI2OdVkBhBJQZHopNe0E6e83O9PDaDGh/PLK2T2rtosP1yJ08/hb7KoLSvU+7KO5DGzf7+mWkB7FMAE8IeCq960+WJqVDFE4Wo6o/yUsvBh9A6nw0omIvfnUoB4UrGDs+K2TO9dDqZ/d+Sk1ORydr0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UTDnTvR9; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UTDnTvR9" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-439a4fc2d65so63366785e9.3 for ; Tue, 04 Mar 2025 09:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107937; x=1741712737; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=UTDnTvR97lbQChwnawl2/OUY6d2PQLZraBs7YRMGLL03EvYfholAzz3x8d7k2a/N+f qI15DarsYcaoyzYx9O8qlwSC6L3O47FwYY2MjTCYUug5dU8sNI4QEdtNc3xThqpLcJbJ UPz0r2TDWjVzN4b7byUxB6GTwPKhWPbgC8iKA+8SoHZuvF5bX9gAfLrQ33DPykxQsDVt B1L7fupERgwY7sXiI9w48uWRPAkIJKLQ5ZUAzLlMmlSbvXlZRJB0miy+MqL5X0Wqxdul cnwhMG+4KjG0lJcK6xNNQ80kmyxocuNWh11pj5UTJYLysfvK5j1Dqv/eHzEqAyT/D0Td iTRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107937; x=1741712737; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=X5FVmAebMboc/JRN0hO/6sgeX1x08BRYy+tWDppYCwIbePHQI6x5ix88CIYFRrLuQf j9w/txZXbc14wJRFjvTg3JH+Wh7HedTBWAQjrr3pXBCtQgeZlHqq+TO1xVdgY5o5gWlq aqPqa1X7pe7eIvFfMHMyy1AeOAgIjip7ANmVO5Hcw3Q7PoCSQPgSUbyJKvPd3gfhPsma IRr99F0Rb+Bs6MuMxLJkQr0/BwJLcAGdz4hf4odQmSh9Ia/xW69LafbEwYcXaprvBSUg dzc3TCn4S5jkUOcE6h9IuYwctxO5jlkXgZE//bzP/l4JxnVZY2w9CIrrYmrVgeJQ6HM7 4+pw== X-Gm-Message-State: AOJu0YzqHh6N4jseOAYXmESYZ9R8wL78ux/YVSUYQS25pIFcixPW4dwe mpZ+TuErQk0R5GwOYL+sSYv8EGVH0VEdxSklTDIncj/V6Xdq0ng9Hb1+9uteK+Y= X-Gm-Gg: ASbGncvdD/2oUZ7VQOThXNJH3yhfROrlbbQMWjLO+daTXOSJZGT8jbmBJBIrD+5iQtu L8iV7NmNO+CCu1sdMTym+h21oC1eR5W/dO6Gow26WSh1fWHDksC2UQdQNQohE8WheIy2Qf44121 D3nKvOMRGh++VHmtTEpATnxiGLdgwNg6nOsVWxgAtSUVnUbpg3a/9hsPKrCcNZ2VtlR78UZog9/ zVzYNkmbqRwB2HbBL6ZRm5eI2WbPA4hz0XmCNDdMy0NGinqiK27WWjTfyJ3Ggfbm2E0C4QwEY4N RZs8nmj5y5Mmc+282JwQOcG1ON/dP67fEnFMULYa6iYft3PPtlItkg47aPniZarR27eW4hcHEU3 CPqylQtAM+EQ97ItYJfPiqvVRe1dv X-Google-Smtp-Source: AGHT+IHZdsv7jYfFsjyY3TIB4euke/dHgzMkeAeSorD4HntlJXvk76kkhxE/lHiggYkJdsJqp3nEfg== X-Received: by 2002:a05:6000:10c1:b0:38d:df29:e14f with SMTP id ffacd0b85a97d-390eca069a5mr17165829f8f.43.1741107937298; Tue, 04 Mar 2025 09:05:37 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:36 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:37 +0000 Subject: [PATCH v2 09/16] rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-9-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-meson-vrtc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-meson-vrtc.c b/drivers/rtc/rtc-meson-vrtc.c index 5849729f7d01d7ec7868ff3bbdc5ed599aaa8238..7d38258cbe376e5a1b2af6250cb= 6d04c313175fb 100644 --- a/drivers/rtc/rtc-meson-vrtc.c +++ b/drivers/rtc/rtc-meson-vrtc.c @@ -13,7 +13,6 @@ =20 struct meson_vrtc_data { void __iomem *io_alarm; - struct rtc_device *rtc; unsigned long alarm_time; bool enabled; }; @@ -65,6 +64,7 @@ static const struct rtc_class_ops meson_vrtc_ops =3D { static int meson_vrtc_probe(struct platform_device *pdev) { struct meson_vrtc_data *vrtc; + struct rtc_device *rtc; =20 vrtc =3D devm_kzalloc(&pdev->dev, sizeof(*vrtc), GFP_KERNEL); if (!vrtc) @@ -78,12 +78,12 @@ static int meson_vrtc_probe(struct platform_device *pde= v) =20 platform_set_drvdata(pdev, vrtc); =20 - vrtc->rtc =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(vrtc->rtc)) - return PTR_ERR(vrtc->rtc); + rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - vrtc->rtc->ops =3D &meson_vrtc_ops; - return devm_rtc_register_device(vrtc->rtc); + rtc->ops =3D &meson_vrtc_ops; + return devm_rtc_register_device(rtc); } =20 static int __maybe_unused meson_vrtc_suspend(struct device *dev) --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B72F28D06A for ; Tue, 4 Mar 2025 17:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107943; cv=none; b=ZePn45p9cHenrcnczOstXQsBhS5olSTG5NCaJU89qKwjYUG/P4BuXPa65Ck4XYSzUp0RobPVwVigpFCK190FSqXoBYOUsYHPJzO45q0wKM3sdRn6r1PwM8XDfOTBjBKMxf0Sk7qCnNVTC1yhQyeH9dN2jnRwAiHk3f1bRGPgHXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107943; c=relaxed/simple; bh=w6Ez2HJK0lLtjno5cUxK05/kYeMcWHjoaFlGGgugd14=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g9CS8B/OI5D+DxQeyVofw9JcLx9ddylG9qnmeRqAyN1OcAbcdpCoh1gjNPZj301zZQ6clZJHHAQsfNNg92JDnWC2gWODN7ImPkfFrlUXsrBuOlBHMTkyxARaru6MpEXRqQ8Jau+VAVoZQlY3/oE24Ks0sEH6Fl85WjyawOMQypA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n4wQBx0N; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n4wQBx0N" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5e0573a84fcso7977603a12.2 for ; Tue, 04 Mar 2025 09:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107938; x=1741712738; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l1dbxTlHkaw5uSKNsqDfe9Jgr4Kg+vWUXd+ullz5kUQ=; b=n4wQBx0N1w5ENAaX/0C2H1OLJrJ2AZ4Sa1Y8rwOYtPRxSx3d1wWcB+1K3jeM85jw4y iKOTh3c0HII7ikEh9wkb7DcikKMjlhoLdoR1gvCLTSVDKwYFDAx06ruJ7O+s+KQW+5uV 2XVLhhVJAj4o/ZRBNdX6Z0v+jGoP/8yU2+mVnbKb6Mk0YdmHyLAR/WglgvAzp27IJaAd /0jXs2AR/Lw2KDvdkB/2wxfQ2Ib1Sy3j+K/sfLSxMZ2reJAaNft7G7BHRdOPgLCkKCP7 MB+eQybiTh5qGX1R2PMfyG+R8DskFbK51x3SnN7SuIfS+fQdRzJhVKzZcT0b7NqdWLMn SEow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107938; x=1741712738; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l1dbxTlHkaw5uSKNsqDfe9Jgr4Kg+vWUXd+ullz5kUQ=; b=Lv5VSNC86rwiaMg9E935ae3LWEEQSUQesqCjTOWWndCU5Vu+iIiyidTzwVxfkyEUbU 9S18uU0z/DHHVG7n0DXS1XPxG6kSlQ1D52TJRgCU8LtQmtz5u3h35JRLAbVA7mtXjkAO sXAJk1bqEWbB2lmN21oxOBQo3hIE1yhw93t9j2E9fhsNLSLNdP+CIO0CFNuiy/VcN4rg Z3WTVCqDaR8rMprzmBB2CwNkCFnUcEtXOq86/Ed1mJfHsY2VqL7jaVLf0a7jdyY9pnn7 EDWqaHHpelJLmiIqkQqcfBIT3fEJSlB7nsldL6EAqzW0QXKjMo7PVQtRE1dNJcHnvkUJ B4Ng== X-Gm-Message-State: AOJu0YxNzJ/6MiFdJtHyzRdCW7QYURUN19ix29oKOPagROknSKmyi+w5 CyTEVOiW9ZMG2wBicLMDgtEmgYecfyIBNYrkM11TkYO3l0aEZFWz1Vv36Q0rFJA= X-Gm-Gg: ASbGnctMqiP9D4OnGG9YbR27P3xz0bJu1jI4rZurdRejyEpUiCnj87URODe/aOVhJm1 ZsD+tWYaxZinK5W2GvvglKQkMMDBycdBVaR23qINyq8RmOVkcYrX6zmYKuYd44jO3agboD35O1w 2JPwrOyQyFRMWBdmJ5ofw1gDUgK0gIPcqeIXXRFKV0M1bvVoBkAxsVoFPTixPlMsoCE8gqC1ZSY Emg7G6SIjnHrXZCbXmYQ4W9utkgdXJ0wtMghA2HwQeFfIa4ZvFUIp41WD2wFKgTjV97NbAwYEIv xKmaovX5xlMhkXM6ytFsfz6SbN74Xc1r6sdHyw7r31fYHLpNG+CzjyYxT3q39UnZsOMFz+wRP+N CD2qZlEhR0cgxSXVx6omg58qc9++b X-Google-Smtp-Source: AGHT+IHF998NpSXE/Qa2EdiSn4vtx17I0lnFV/wyKnxAJsCHaDM1j6HSEMvcUwtHdnvoXlFd/CgYog== X-Received: by 2002:a05:6402:d0b:b0:5e4:c532:d693 with SMTP id 4fb4d7f45d1cf-5e4d6b8535fmr16782448a12.31.1741107937989; Tue, 04 Mar 2025 09:05:37 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:37 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:38 +0000 Subject: [PATCH v2 10/16] rtc: pl030: drop needless struct pl030_rtc::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-10-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Linus Walleij Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-pl030.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c index 39038c0754ee55a952e5986afe711cffff35840b..e7c81740061bb60c4d8447d6522= 819685bea9180 100644 --- a/drivers/rtc/rtc-pl030.c +++ b/drivers/rtc/rtc-pl030.c @@ -21,7 +21,6 @@ #define RTC_CR_MIE (1 << 0) =20 struct pl030_rtc { - struct rtc_device *rtc; void __iomem *base; }; =20 @@ -86,6 +85,7 @@ static int pl030_probe(struct amba_device *dev, const str= uct amba_id *id) { struct pl030_rtc *rtc; int ret; + struct rtc_device *rtc_dev; =20 ret =3D amba_request_regions(dev, NULL); if (ret) @@ -97,14 +97,14 @@ static int pl030_probe(struct amba_device *dev, const s= truct amba_id *id) goto err_rtc; } =20 - rtc->rtc =3D devm_rtc_allocate_device(&dev->dev); - if (IS_ERR(rtc->rtc)) { - ret =3D PTR_ERR(rtc->rtc); + rtc_dev =3D devm_rtc_allocate_device(&dev->dev); + if (IS_ERR(rtc_dev)) { + ret =3D PTR_ERR(rtc_dev); goto err_rtc; } =20 - rtc->rtc->ops =3D &pl030_ops; - rtc->rtc->range_max =3D U32_MAX; + rtc_dev->ops =3D &pl030_ops; + rtc_dev->range_max =3D U32_MAX; rtc->base =3D ioremap(dev->res.start, resource_size(&dev->res)); if (!rtc->base) { ret =3D -ENOMEM; @@ -121,7 +121,7 @@ static int pl030_probe(struct amba_device *dev, const s= truct amba_id *id) if (ret) goto err_irq; =20 - ret =3D devm_rtc_register_device(rtc->rtc); + ret =3D devm_rtc_register_device(rtc_dev); if (ret) goto err_reg; =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69E8628D0A8 for ; Tue, 4 Mar 2025 17:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107945; cv=none; b=KllQDzHihhAZ8yykNN8AnpL10DN4gOvonzuwZzJ3hmIZyJVTDLo52Gw2KPosN/ioUviqNmFy4fMsMOSdk+9fl4G1lErH+tNSHVJyGjwmtwmfGAiyejGX7tiKtRg+STTchE5SHbAfARIo78j0GgpRt5WfjHoWeuM17rip2DkiRxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107945; c=relaxed/simple; bh=cZSNlyCPP2sZ0NzEjW15iAl44WPa7AMx/oJSQqQslPI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jGuauloifUprCCCeYtykNGHnafzVD9YRszOMsJG+ZzZeRF+sm+MW3Di+h0WJLLGzC3D9Hf4qvyeIFyMDGqPvHAzD8mPA10hTZN2VRSI5flYxFmXD5B5pyROt9lKaTnwdK7fLREgST7LHzIYOKQ8p+RSyS7b+WsZK2PT3nLR/ZZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vN+tBiVF; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vN+tBiVF" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5e04cb346eeso10157543a12.2 for ; Tue, 04 Mar 2025 09:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107939; x=1741712739; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IaB5zKXHk0fgCsI3Zx6BuQOTGpJ5CFC8NMnIRZG9Bxw=; b=vN+tBiVFjj9NWy+sR30STVTJVQOlPMontgXnreD0UEF0FNIK216w43cEBCt6q32RPV WtpmUi506tjlDhwpBvjX7hdBdGtjuTWAmUSzQ8vdtcS600TzBFdORn1ImbxFH5Wmfx5O 3saOW6xogD3aqViv04SG7QnMpEK7NmEgb/Peq8nimajzbXH3EUTLNcJws9TfukGm9+kz tsPfySBeawqp2msWq98PcSx+/N/UQQQL0w9DYbcB1VutoWpGkVHJj1FVOxnD5wdLFKHj 17sknKc3r+K4tPXuoGV8BtP6KZWFAm9uIe4r7Lx85tY8izSqkB15mqyUGmdUMtIvGhyl s3hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107939; x=1741712739; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IaB5zKXHk0fgCsI3Zx6BuQOTGpJ5CFC8NMnIRZG9Bxw=; b=R1+ZjSLVq+VWktINHHkwVdALUfmdWwZXdDozSB4eBiZeyPQ8aqCKFvq291cdI4pezG Lt2Hhd8pPDMeU3xBykjJXX/0HQFIOaqIWwEj8yKwq6oG02iDDWBZp5YRe5hX9FV7I133 oyJq/sGj2gP3Lu9dhdTappLGZSN5MQWY+gYam0J060iAv03g09QAyWrb7gqG+/wvZ3lf sIt5xNTa4ZHUIOU0QvOCiugXqwTyDiamtSJ15gGFfgxi1PUSEyos0uEUPqrbuS1IRtzJ edYD2GpKlmnllH3E1BPuacy6LJDcq6H2L8VQr7YKGyEYWF5KFiZNKCSsBhyh/1BoZvA4 JX4Q== X-Gm-Message-State: AOJu0Yy9bcXppkGG8ispt7EE+zDpY92XlyoaOe+ePHJMcJTJmj+rcE43 ZF68rdA1+BQgD5irNWRwUEQsEJjDjF0Ts9+sCYAbAhwaljLJ3J+lkQQY0Sj/160= X-Gm-Gg: ASbGnctKqYYOLYHMv3MckitgzW0m8YFfDMFICgleKCPqRUZxokdPs3+0j+sFcO1paz3 DXGqZaKn2IZRQwFxY4b75lzcZG7Ie0XVUjq5QbxFKaUaY5DWD5HoDOLFJVQselVdj8/PzyG4uxr w2gt7KpftBDeUMIviQA70HT+nIjwz6PkplGmyauJo0s1kKJ1KQ2PJbAosvbLt4haY16CkPKTD8X Rz9rwfcMCphrRHmEoCOPyrW35PtSMoWWWyLdXNQwnWBJMimPmidK6xEl0zLKnnGELS58gyCJb3N 5NR8AAmQs/O53HL/V7+fOWj6axNcGgpRnM3UBZmk9aOQYVWOznfGo6902XUwxaKFiAdbuM9xMGh WBy4jk4MUuxddllhqWf+m7Q3yN8C6 X-Google-Smtp-Source: AGHT+IEthaeTae6V+bsrtEeJOclicWZ8u/xfJHzWX8LHXk81mGbjX6FsBTkNnwrP87t1Gku2pvbmyw== X-Received: by 2002:a17:907:6ea5:b0:ac1:e1a7:44af with SMTP id a640c23a62f3a-ac1e1a747c4mr790541466b.49.1741107938652; Tue, 04 Mar 2025 09:05:38 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:38 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:39 +0000 Subject: [PATCH v2 11/16] rtc: rx8581: drop needless struct rx8581 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-11-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Since this now means that the structure has just one member only left, there is no need anymore to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation for the containing struct, reducing runtime memory consumption. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-rx8581.c | 85 ++++++++++++++++++++------------------------= ---- 1 file changed, 36 insertions(+), 49 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index b18c12887bdc3705ea4cee9b8d75086a05b24e71..20c2dff01bae833ae4e100cc38c= d5f030017be75 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -52,11 +52,6 @@ #define RX8571_USER_RAM 0x10 #define RX8571_NVRAM_SIZE 0x10 =20 -struct rx8581 { - struct regmap *regmap; - struct rtc_device *rtc; -}; - struct rx85x1_config { struct regmap_config regmap; unsigned int num_nvram; @@ -72,14 +67,14 @@ static int rx8581_rtc_read_time(struct device *dev, str= uct rtc_time *tm) unsigned char date[7]; unsigned int data; int err; - struct rx8581 *rx8581 =3D i2c_get_clientdata(client); + struct regmap *regmap =3D i2c_get_clientdata(client); =20 /* First we ensure that the "update flag" is not set, we read the * time and date then re-read the "update flag". If the update flag * has been set, we know that the time has changed during the read so * we repeat the whole process again. */ - err =3D regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err =3D regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; =20 @@ -92,20 +87,20 @@ static int rx8581_rtc_read_time(struct device *dev, str= uct rtc_time *tm) do { /* If update flag set, clear it */ if (data & RX8581_FLAG_UF) { - err =3D regmap_write(rx8581->regmap, RX8581_REG_FLAG, - data & ~RX8581_FLAG_UF); + err =3D regmap_write(regmap, RX8581_REG_FLAG, + data & ~RX8581_FLAG_UF); if (err < 0) return err; } =20 /* Now read time and date */ - err =3D regmap_bulk_read(rx8581->regmap, RX8581_REG_SC, date, + err =3D regmap_bulk_read(regmap, RX8581_REG_SC, date, sizeof(date)); if (err < 0) return err; =20 /* Check flag register */ - err =3D regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err =3D regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; } while (data & RX8581_FLAG_UF); @@ -137,7 +132,7 @@ static int rx8581_rtc_set_time(struct device *dev, stru= ct rtc_time *tm) struct i2c_client *client =3D to_i2c_client(dev); int err; unsigned char buf[7]; - struct rx8581 *rx8581 =3D i2c_get_clientdata(client); + struct regmap *regmap =3D i2c_get_clientdata(client); =20 dev_dbg(dev, "%s: secs=3D%d, mins=3D%d, hours=3D%d, " "mday=3D%d, mon=3D%d, year=3D%d, wday=3D%d\n", @@ -160,25 +155,23 @@ static int rx8581_rtc_set_time(struct device *dev, st= ruct rtc_time *tm) buf[RX8581_REG_DW] =3D (0x1 << tm->tm_wday); =20 /* Stop the clock */ - err =3D regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + err =3D regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, RX8581_CTRL_STOP); if (err < 0) return err; =20 /* write register's data */ - err =3D regmap_bulk_write(rx8581->regmap, RX8581_REG_SC, - buf, sizeof(buf)); + err =3D regmap_bulk_write(regmap, RX8581_REG_SC, buf, sizeof(buf)); if (err < 0) return err; =20 /* get VLF and clear it */ - err =3D regmap_update_bits(rx8581->regmap, RX8581_REG_FLAG, - RX8581_FLAG_VLF, 0); + err =3D regmap_update_bits(regmap, RX8581_REG_FLAG, RX8581_FLAG_VLF, 0); if (err < 0) return err; =20 /* Restart the clock */ - return regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + return regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, 0); } =20 @@ -190,29 +183,27 @@ static const struct rtc_class_ops rx8581_rtc_ops =3D { static int rx8571_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 =3D priv; + struct regmap *regmap =3D priv; =20 - return regmap_bulk_read(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_read(regmap, RX8571_USER_RAM + offset, val, bytes); } =20 static int rx8571_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 =3D priv; + struct regmap *regmap =3D priv; =20 - return regmap_bulk_write(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_write(regmap, RX8571_USER_RAM + offset, val, bytes); } =20 static int rx85x1_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 =3D priv; + struct regmap *regmap =3D priv; unsigned int tmp_val; int ret; =20 - ret =3D regmap_read(rx8581->regmap, RX8581_REG_RAM, &tmp_val); + ret =3D regmap_read(regmap, RX8581_REG_RAM, &tmp_val); (*(unsigned char *)val) =3D (unsigned char) tmp_val; =20 return ret; @@ -221,12 +212,11 @@ static int rx85x1_nvram_read(void *priv, unsigned int= offset, void *val, static int rx85x1_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 =3D priv; + struct regmap *regmap =3D priv; unsigned char tmp_val; =20 tmp_val =3D *((unsigned char *)val); - return regmap_write(rx8581->regmap, RX8581_REG_RAM, - (unsigned int)tmp_val); + return regmap_write(regmap, RX8581_REG_RAM, (unsigned int)tmp_val); } =20 static const struct rx85x1_config rx8581_config =3D { @@ -249,9 +239,10 @@ static const struct rx85x1_config rx8571_config =3D { =20 static int rx8581_probe(struct i2c_client *client) { - struct rx8581 *rx8581; + struct regmap *regmap; const struct rx85x1_config *config =3D &rx8581_config; const void *data =3D of_device_get_match_data(&client->dev); + struct rtc_device *rtc; static struct nvmem_config nvmem_cfg[] =3D { { .name =3D "rx85x1-", @@ -276,31 +267,27 @@ static int rx8581_probe(struct i2c_client *client) if (data) config =3D data; =20 - rx8581 =3D devm_kzalloc(&client->dev, sizeof(struct rx8581), GFP_KERNEL); - if (!rx8581) - return -ENOMEM; - - i2c_set_clientdata(client, rx8581); + regmap =3D devm_regmap_init_i2c(client, &config->regmap); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); =20 - rx8581->regmap =3D devm_regmap_init_i2c(client, &config->regmap); - if (IS_ERR(rx8581->regmap)) - return PTR_ERR(rx8581->regmap); + i2c_set_clientdata(client, regmap); =20 - rx8581->rtc =3D devm_rtc_allocate_device(&client->dev); - if (IS_ERR(rx8581->rtc)) - return PTR_ERR(rx8581->rtc); + rtc =3D devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - rx8581->rtc->ops =3D &rx8581_rtc_ops; - rx8581->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; - rx8581->rtc->range_max =3D RTC_TIMESTAMP_END_2099; - rx8581->rtc->start_secs =3D 0; - rx8581->rtc->set_start_time =3D true; + rtc->ops =3D &rx8581_rtc_ops; + rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max =3D RTC_TIMESTAMP_END_2099; + rtc->start_secs =3D 0; + rtc->set_start_time =3D true; =20 - ret =3D devm_rtc_register_device(rx8581->rtc); + ret =3D devm_rtc_register_device(rtc); =20 for (i =3D 0; i < config->num_nvram; i++) { - nvmem_cfg[i].priv =3D rx8581; - devm_rtc_nvmem_register(rx8581->rtc, &nvmem_cfg[i]); + nvmem_cfg[i].priv =3D regmap; + devm_rtc_nvmem_register(rtc, &nvmem_cfg[i]); } =20 return ret; --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83A61290BBF for ; Tue, 4 Mar 2025 17:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107945; cv=none; b=jRNMdl2uLUun059GiP/ehlvSlnw2O1peDrKlt2T+ABrG4Plqi7QkD48YIWYjkGeZRhzQSiF82tTiQ/9ZPWDn7AxBT/LDFI+vEpetX6Ft4ZJr+M+spBb03gp7rqbS38Xz6PeQLAdKK25/7YCK7fXZdPf/58mrOIhhFxEjXmnWIQk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107945; c=relaxed/simple; bh=wcWeDWs75X61m+m4siXkgCaNrKLjTdrfe/93knsU6io=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O7dEPAJSjRB1SCO9TKBu4RI3T19eYSowp/xH+UDg1MJe94T/yiTHhz6N2KdCWNVTLGE8VDFfOywYgijXxzzrNqk8/90TbogbzD3b3QhTFZeUiMimlEc/5XL+JPxnLTLCtxv5v04xfujUp6wZ9wITjlAO7bozN3gfPhgP+qisuBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qMj5jSd5; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qMj5jSd5" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-abec8b750ebso1023447466b.0 for ; Tue, 04 Mar 2025 09:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107939; x=1741712739; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=qMj5jSd5vyjtXimunQXFhiA4f7t6jK4K7e7WqiKUpeu5qXdOxYNMaKhmhZ8Xz+3YWl Qw7aPsb8vkp35rzAvE4L0a4zMCg16fn24ck8hJX8FT9BBhMBoic2FYVv+gcdMTLNScK7 qVTIGwPMVOlBwE64r/NG5W+1nF1tPC/TnIWtu0b5ULy2LO7pB64htAs1v+KJlTVjRIzc 9i/Ht897sOcHhPgFE/17PGSKXpIWj3IHzOyVhSMFe0VhsEI60Vc8lL6XLChkK4dqyidJ ryYxfx15svRW6/DFhMoB5AyKA51iY1zj51cfQDXDZk/Vje/ffjJa1bI/46KmgD0gjnEC tR6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107939; x=1741712739; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=sPZ4Q78S+qNZjbM3TAuD3UriD+paUKe7BXtBv04vN2r4DOA/f52CR044csXEaWqiPe yujWB3CqE7Yixq6VyZvWw52XC6hiGXV2h/ZZOgMUwgv+wgRfgEMqOsB3eMP+wgTu3kzE H4GcgZLwrvsRGx88/6Rk2I0rKN06dtG4Ufpaoi0DQvIbhRt3YzFkSrKAyGE0l9wB/UiF qlFNbbJkkkD2doyIP4wbWjRES2i6tQ0hAG0rYNVmhwLzbGeZfXyFJpJkwUxHv2MKWV5V o8qx23m34hF2Wn39/guy5eqMg0/pe4Es1jeUXnR1NAzWwSClJABQR0i9YLFKfwd9vOuJ SMdA== X-Gm-Message-State: AOJu0YziO59XXUdcZl60Kxe4yFALAncffjndTTufFrWTESp72Or3+p6z 20+/j94eGO8DDoduc6dGgvKBqqo/3v9/Asm0pV3J60hbAVzsrJlItq8L1JWQBgE= X-Gm-Gg: ASbGncvWe2bYfJewQpTzoM+dqxgoWyi3Z3gqxcuRmKiz/HHTRqZTcDf1N81Ws73nFTN FXgmdh2l1lrW0xAjmNHQq4TmxyU6a1k6PhM2hKKahogXATt/SlhAXL2v3yOG40EUOISn1Tb5TAQ 6AtscF6AOfqpgW7cbVrKpIp15rZjY0uvpB//mCEwlsBu2R18ZWpUey5bwQMd8QwyxtzCa8Kehdg rq6gha57j/oz8EZsHq/JzIS7K52u+c7nhVvCx0VkflEwguUpQmp8dk6FQbwEuwwd2qAWH6MFz2V DpPOxYh+nOpfBg1YM4E8dhtm33zaLfyfLxXfGtXosRndbn83Bton0mfcXW5Wi9qPZb/6V0XELbY cfcQ8a65EamVs/mHwgemMXhJjMdst X-Google-Smtp-Source: AGHT+IEZqUVJFopMcdCw0Fa6138jis8STGfKBc9DN3g8sZLmJaNDRTq42x6nu+WBoJl/BXVMQfaxGw== X-Received: by 2002:a17:907:97d5:b0:aba:246b:3954 with SMTP id a640c23a62f3a-abf268263f9mr1810089466b.47.1741107939344; Tue, 04 Mar 2025 09:05:39 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:38 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:40 +0000 Subject: [PATCH v2 12/16] rtc: s35390a: drop needless struct s35390a::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-12-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s35390a.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index e3dc18882f41445c41fbea56edbd5c869514880c..3408d2ab274194e39cde38a8356= 7d37bd53f6632 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -63,7 +63,6 @@ MODULE_DEVICE_TABLE(of, s35390a_of_match); =20 struct s35390a { struct i2c_client *client[8]; - struct rtc_device *rtc; int twentyfourhour; }; =20 @@ -422,6 +421,7 @@ static int s35390a_probe(struct i2c_client *client) int err, err_read; unsigned int i; struct s35390a *s35390a; + struct rtc_device *rtc; char buf, status1; struct device *dev =3D &client->dev; =20 @@ -447,9 +447,9 @@ static int s35390a_probe(struct i2c_client *client) } } =20 - s35390a->rtc =3D devm_rtc_allocate_device(dev); - if (IS_ERR(s35390a->rtc)) - return PTR_ERR(s35390a->rtc); + rtc =3D devm_rtc_allocate_device(dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 err_read =3D s35390a_read_status(s35390a, &status1); if (err_read < 0) { @@ -480,17 +480,17 @@ static int s35390a_probe(struct i2c_client *client) =20 device_set_wakeup_capable(dev, 1); =20 - s35390a->rtc->ops =3D &s35390a_rtc_ops; - s35390a->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; - s35390a->rtc->range_max =3D RTC_TIMESTAMP_END_2099; + rtc->ops =3D &s35390a_rtc_ops; + rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max =3D RTC_TIMESTAMP_END_2099; =20 - set_bit(RTC_FEATURE_ALARM_RES_MINUTE, s35390a->rtc->features); - clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, s35390a->rtc->features ); + set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); =20 if (status1 & S35390A_FLAG_INT2) - rtc_update_irq(s35390a->rtc, 1, RTC_AF); + rtc_update_irq(rtc, 1, RTC_AF); =20 - return devm_rtc_register_device(s35390a->rtc); + return devm_rtc_register_device(rtc); } =20 static struct i2c_driver s35390a_driver =3D { --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27355290BCD for ; Tue, 4 Mar 2025 17:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107945; cv=none; b=UKfDJivORq2GMmltaCvk4Yn4pCQJoVX9YlNWEc9tKaySZWfMBLEMDzXhsQvp6qj2aO6vV6ETisi92rACk9tSraOQddK32Hvlc2ruC1zY3D/tdovwi46O+jbuIq04ntPR0rUUrn2iTymC2R5XNC0J9wN54B+3WXW3AT3B4Yh7YQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107945; c=relaxed/simple; bh=M4Ze9HORH9tUnnjpPlWigivxQdkAcaAxYcFUsuXXVuQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mQc6ec6hI2IHCDhJAxl7shmifXqDygTF31E1oVZ4xpBu2KkQySmsXIrNeMfk8/tjZLKkky24Z+yZRSlttiR07b72eD33d2dZZ2IZzieAHcY7SPrXcaUeTvrDJAIrMnxjGkZbFLS95PH3BkVaq5CfESt1SxicM5vuDkIPtj0t7UY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BoIbshlp; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BoIbshlp" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-abf5358984bso537639366b.3 for ; Tue, 04 Mar 2025 09:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107940; x=1741712740; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hsaGEw76ofDXd3Q1RIPfSv8CJUvwC0w+ueATTj/NegM=; b=BoIbshlp0G00gd27VwrJ6i2hu7nG72FbP/83qvMN+QuKU0ebLPzqQNEEZ+uV+1Sm1t 4uN1xglWjnFCOA26onxYUtgtHp3yOycVeYpgimSVPixkuc27yEwk51n1gFXwO5hl+SK3 wbOUAqdy1IuXnDIqGpPX2EExxNgVkoX53kD6y7zMa6Y/2upyI+JFFH0Z5xqDFVOdWw+q eObY8R+0joo+1Y4FNzje2j3AV2fN92qdthcDEVpZ7pKF8ujo2kY07B9+6gZUaetowcl/ DKI9CqsoLJWsTI60Ev9TslXZDD5H/ERQ2jgJkM+xCD0GPNsNoenSNSQeGxkVzkJ3JeyX unRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107940; x=1741712740; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hsaGEw76ofDXd3Q1RIPfSv8CJUvwC0w+ueATTj/NegM=; b=Ts7VUcZu+48wKcfJR3xu9hd9DlDltvzbLzBtmEoi6EX0JE3CI0NxeH1Qsin1sLAbHE RE94UANuOf316kE0nX3WvV1220kLJU6okRyHJnYe3p4xcIpojG9jFpcbbv7zyzo7ZsBG BzRO6pAc76vHwxIdDDl4oQZBHOXOWniI59xXU4LxEpLbSS020AHrrDzEC3SBs0GCNw43 1SPX6dg5irGGsV+J62CLUcVk2tRKt5NZB5Ra6uGSk3JLegi07NAvdHPnDAayc30X2OXE 8ozyLBHYJa36TiaxrXS6xJRjEycRqCq3GzBVuuMN3G1MjSATDKy3NoSo6pjPJ2ORYUtt kMaw== X-Gm-Message-State: AOJu0YzJd45W2rOFgbLGghS1DKJa40pELEeskIoRTV6Zd1oytOBvRZmi +XA46xWKZt5Xwi1KZF8Kv7UCzJM04NNIdIo0WWF0a2VqQ0I+DBsjKSGWr7R/UcQ= X-Gm-Gg: ASbGnctB3e0lP596mXNNIm1Lu0QKjA5kmj7VWpzxzGA5Epx6mkVQMPtOskhQuxP7tT2 k23K6tEfJSFMf97vR4mAK4njeXLJ8iwlhKtEiRfUhH1UqFAYnCJH2FrKA28jcmls3pAKUg4y0zn edTGA70FysVYTzB0OkA0u6BlZH6cyDDOTc/d9ejnmXtPFEItRVyAPYCS6Rdhp3ozBBJ/X/UzW2b W5WEXiRY45+DB943jLMKihfMSPrw3BAI3tmD6Ktm6B9FxwwFBoJfqsZ4XPcR5HcaSvSKJyb43IN JuYd55p7SQRr2oT/uwKDlKBLDU8Rt4+K+5IpYuScXAuyCQPL8lvapf9bZZExgaASmR7J5ZxL7ES 35EBoErRKYu0+sqgQPe3zNpnuF5NO X-Google-Smtp-Source: AGHT+IFl6TTi8U8Sph/F6W/xnjfer4H7R9+DXzK4OCCEVcy7pkMVR63rOrht0Su/bmOb+eKFGQTbhQ== X-Received: by 2002:a17:907:1c8b:b0:abf:38a:6498 with SMTP id a640c23a62f3a-ac20db16fb1mr2300366b.55.1741107940186; Tue, 04 Mar 2025 09:05:40 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:39 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:41 +0000 Subject: [PATCH v2 13/16] rtc: sd2405al: drop needless struct sd2405al::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-13-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Tested-by: T=C3=B3th J=C3=A1nos Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-sd2405al.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sd2405al.c b/drivers/rtc/rtc-sd2405al.c index d2568c3e387659dfea598cd2ef6bddc5c076cbb9..00c3033e8079b5f10aaabcc7a1d= 3f19771263a02 100644 --- a/drivers/rtc/rtc-sd2405al.c +++ b/drivers/rtc/rtc-sd2405al.c @@ -42,7 +42,6 @@ =20 struct sd2405al { struct device *dev; - struct rtc_device *rtc; struct regmap *regmap; }; =20 @@ -167,6 +166,7 @@ static const struct regmap_config sd2405al_regmap_conf = =3D { static int sd2405al_probe(struct i2c_client *client) { struct sd2405al *sd2405al; + struct rtc_device *rtc; int ret; =20 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) @@ -182,17 +182,17 @@ static int sd2405al_probe(struct i2c_client *client) if (IS_ERR(sd2405al->regmap)) return PTR_ERR(sd2405al->regmap); =20 - sd2405al->rtc =3D devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd2405al->rtc)) - return PTR_ERR(sd2405al->rtc); + rtc =3D devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - sd2405al->rtc->ops =3D &sd2405al_rtc_ops; - sd2405al->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; - sd2405al->rtc->range_max =3D RTC_TIMESTAMP_END_2099; + rtc->ops =3D &sd2405al_rtc_ops; + rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max =3D RTC_TIMESTAMP_END_2099; =20 dev_set_drvdata(&client->dev, sd2405al); =20 - ret =3D devm_rtc_register_device(sd2405al->rtc); + ret =3D devm_rtc_register_device(rtc); if (ret < 0) return ret; =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FB112BEC24 for ; Tue, 4 Mar 2025 17:05:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107946; cv=none; b=OccPSXVOYEEjfJvyGccJfowfsBfdTF59ayzuJoqJ7A5PTeITG2UCWC80CVh+sJ6uN1RBnDdlcv/FQLeMA8XzN+F9oBQGNEpYtgzhSIzkSsdtHM6au1+a89VphTdFet6MKpILJA3Pqfp00nzb+k4OBFHkMXQ7cOWZVe7zzofG+ls= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107946; c=relaxed/simple; bh=REGjPiVOjqVZBOjhJUgX7G6ANaxzAPJnC5dNaRot8Ec=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p4yLyOfNvnWSElFXbyEiZUY8OZLjstU8YUthPhYNhY3g3VFNXGbAxyVNC7G1Z6sf8xpIxVnCu1A9oTliHzxo/5/Laz8GqNaWTbMxpcRUUMLcLL6ujZ1ONzFVdQxkifIHw8q+aUwMpviVln0t5xaQJrNoMPppg9pdVZWhZ00rngA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yi69Q1Mb; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yi69Q1Mb" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5e57c81d5d0so2306671a12.2 for ; Tue, 04 Mar 2025 09:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107941; x=1741712741; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jDySvxIgslRZrTqVd7bcfGaor7CHMjwsKayUWf5uR70=; b=yi69Q1Mbb1GkjLEkC7jzKQv1xUdlusqv87QLBkdgvqCAx3CnAQrv1jpGc/bDIFqX/Y yGdr2jngu80ttpJmYLHwqJMKS/3cky1zgiecRkteFQUpOQ3CcJnILv4GLF5uMeJtOiAl TAu6rx1ocIguFuTz0RXsT5Wyp/WXPPVQRUiWSPyCgSiTCdZ/5a132G0y26FOWVtsB/E2 utVsUxE1O73TNJRqF4RVDRo12oWzrFGWkgr1drWvYtBgt578P46KQeRBHR4ouzoxAuSC TmbpiyA2qbGQXrkLyR4IEZLgbASIR8eljgxN19gtenJ+HAPeKu4XmSVa/QjXz60JJXcB kXbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107941; x=1741712741; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jDySvxIgslRZrTqVd7bcfGaor7CHMjwsKayUWf5uR70=; b=VWB7dyioUv9JLhV96s+12s8iEyjJWtsjqcoCY1c4TrbvFaLl+N8W9sEnwSaMlSXkhb +ArfZ7D2EK6q+4YCiilq+W/vO9P6vEs6PVMNhaGyEEVhm6rR/iJ/S1t8eMgRModtQJ60 PUO9eOZBpGHwcQ9xPVQlcE+6pQkGaU4RUsMwzKDLDWehO8Dp+HbLtZ5SEsq3kOh/GIUm u3Q7lrYBH2TZttc3jyiOVzoxF9y91kaGNtSya3XvPTkcvPM0qtP594rzZqYb4EwZsF79 1mhu1S1Uiktrl9wd1d/T2fRtfiIW1hjeKFv8NpntFGVWxjFnXPGFBAydJKQuyEOgvyHN kGGA== X-Gm-Message-State: AOJu0YzsYb+SGKxgRgUAX9wFD+AMaD9YcRc1GTPgd6XeQGnNClyxJ1TJ bNL+XMdeU6XnF9wMApPhkXceUjX9FAB9F3y7DW/QFkMd5pJiPrtKwPH5/ixnovE= X-Gm-Gg: ASbGncvWWZI3/6xS5xw0exLCkfqqhoGUqXNTpr5bgMBTOUxnDJlkXIC+9wIK1t/4WlC M+P8AfiKYKBVSpCB63qhGsRFP5s2wGdHRGBbKJ6wVGGdOlAuOak9JHtSECfCiaJFxbIupE0nUGH hjzCXZcqTb9kX8rgJFwmAqiOQ/qDAOYWQ3LFr+K1oMutXOe9VT48GJF3UP3/wLMSHgaU0Ssz23o sNazo9GnQKSl0gQjoIcYy/ougrIhlvXhNFshtNl2Xiow1w73t1PgBgGZs/Oytz+GTJSMY8f94lF hfQZHJvHNGYZ+/r6TGrF8LczwAmrGTJjA12cVD0nl5AKfXZATSwKI8uSu2T2JXCYs34Hw0xidEQ qEzQyAFbZ5/OaQ4pQ/gDGTB/10bRj X-Google-Smtp-Source: AGHT+IGw6DMujSSlMe4X/Gi0vjiilArq9AgwOJMWr49ZazH2bLzcdxFw+AmPTscolQ+3wmW3ZQIPiA== X-Received: by 2002:a05:6402:50d4:b0:5e5:9543:fc0d with SMTP id 4fb4d7f45d1cf-5e59543fd82mr4097180a12.31.1741107940802; Tue, 04 Mar 2025 09:05:40 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:40 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:42 +0000 Subject: [PATCH v2 14/16] rtc: sd3078: drop needless struct sd3078 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-14-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Since this now means that the structure has just one member only left, there is no need anymore to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation for the containing struct, reducing runtime memory consumption. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-sd3078.c | 71 +++++++++++++++++++-------------------------= ---- 1 file changed, 28 insertions(+), 43 deletions(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index fe27b54beaad1c06b70bf7f22e44c3f6da087267..10cc1dcfc7748144f51ef674939= 506feee1fb471 100644 --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -36,11 +36,6 @@ */ #define WRITE_PROTECT_EN 0 =20 -struct sd3078 { - struct rtc_device *rtc; - struct regmap *regmap; -}; - /* * In order to prevent arbitrary modification of the time register, * when modification of the register, @@ -49,14 +44,11 @@ struct sd3078 { * 2. set WRITE2 bit * 3. set WRITE3 bit */ -static void sd3078_enable_reg_write(struct sd3078 *sd3078) +static void sd3078_enable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, KEY_WRITE1); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, KEY_WRITE2); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, KEY_WRITE3); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, KEY_WRITE1); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, KEY_WRITE2); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, KEY_WRITE3); } =20 #if WRITE_PROTECT_EN @@ -69,14 +61,11 @@ static void sd3078_enable_reg_write(struct sd3078 *sd30= 78) * 2. clear WRITE3 bit * 3. clear WRITE1 bit */ -static void sd3078_disable_reg_write(struct sd3078 *sd3078) +static void sd3078_disable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, 0); } #endif =20 @@ -85,11 +74,10 @@ static int sd3078_rtc_read_time(struct device *dev, str= uct rtc_time *tm) unsigned char hour; unsigned char rtc_data[NUM_TIME_REGS] =3D {0}; struct i2c_client *client =3D to_i2c_client(dev); - struct sd3078 *sd3078 =3D i2c_get_clientdata(client); + struct regmap *regmap =3D i2c_get_clientdata(client); int ret; =20 - ret =3D regmap_bulk_read(sd3078->regmap, SD3078_REG_SC, rtc_data, - NUM_TIME_REGS); + ret =3D regmap_bulk_read(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "reading from RTC failed with err:%d\n", ret); return ret; @@ -123,7 +111,7 @@ static int sd3078_rtc_set_time(struct device *dev, stru= ct rtc_time *tm) { unsigned char rtc_data[NUM_TIME_REGS]; struct i2c_client *client =3D to_i2c_client(dev); - struct sd3078 *sd3078 =3D i2c_get_clientdata(client); + struct regmap *regmap =3D i2c_get_clientdata(client); int ret; =20 rtc_data[SD3078_REG_SC] =3D bin2bcd(tm->tm_sec); @@ -135,10 +123,10 @@ static int sd3078_rtc_set_time(struct device *dev, st= ruct rtc_time *tm) rtc_data[SD3078_REG_YR] =3D bin2bcd(tm->tm_year - 100); =20 #if WRITE_PROTECT_EN - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); #endif =20 - ret =3D regmap_bulk_write(sd3078->regmap, SD3078_REG_SC, rtc_data, + ret =3D regmap_bulk_write(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "writing to RTC failed with err:%d\n", ret); @@ -146,7 +134,7 @@ static int sd3078_rtc_set_time(struct device *dev, stru= ct rtc_time *tm) } =20 #if WRITE_PROTECT_EN - sd3078_disable_reg_write(sd3078); + sd3078_disable_reg_write(regmap); #endif =20 return 0; @@ -166,36 +154,33 @@ static const struct regmap_config regmap_config =3D { static int sd3078_probe(struct i2c_client *client) { int ret; - struct sd3078 *sd3078; + struct regmap *regmap; + struct rtc_device *rtc; =20 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; =20 - sd3078 =3D devm_kzalloc(&client->dev, sizeof(*sd3078), GFP_KERNEL); - if (!sd3078) - return -ENOMEM; - - sd3078->regmap =3D devm_regmap_init_i2c(client, ®map_config); - if (IS_ERR(sd3078->regmap)) { + regmap =3D devm_regmap_init_i2c(client, ®map_config); + if (IS_ERR(regmap)) { dev_err(&client->dev, "regmap allocation failed\n"); - return PTR_ERR(sd3078->regmap); + return PTR_ERR(regmap); } =20 - i2c_set_clientdata(client, sd3078); + i2c_set_clientdata(client, regmap); =20 - sd3078->rtc =3D devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd3078->rtc)) - return PTR_ERR(sd3078->rtc); + rtc =3D devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - sd3078->rtc->ops =3D &sd3078_rtc_ops; - sd3078->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; - sd3078->rtc->range_max =3D RTC_TIMESTAMP_END_2099; + rtc->ops =3D &sd3078_rtc_ops; + rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max =3D RTC_TIMESTAMP_END_2099; =20 - ret =3D devm_rtc_register_device(sd3078->rtc); + ret =3D devm_rtc_register_device(rtc); if (ret) return ret; =20 - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); =20 return 0; } --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58CA72BF12C for ; Tue, 4 Mar 2025 17:05:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107947; cv=none; b=HcvSynp/pfmgc3pj6dZtdAux1qLZaRFIoAGRjpleiDK4G0RtwG9RqDq29T2VXJnH6f5QKg8C1YdOAhnDKG62m9XaUlpH+vJF0h+sWuzu073FrRkECVLAh80I8bHI0f5CnwRqmX+Cwkiky9s9eB79jrHIpNcMhUSXNsd86SIeBhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107947; c=relaxed/simple; bh=9NiX1CWV0hfu5OaTJtAP498kfcNRuxNWGXOfalDiImQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uaz2VWiLsC0vhL9vhc/vMQZUIry8HVsFdog8E+Dtw9JwXhIbJNtME6tBjfcXdk25rHHcv/06P6LcZva0whbBOSUMaPgZ8Z673jgZLbT5XsmFY5kOEiNHGKaOGbhvprVqUFrE6PDfJNUFZgy+9GDFa5GEif5k+0QDC2+sIbT6/7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HWeitVD2; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HWeitVD2" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-390cf7458f5so5518206f8f.2 for ; Tue, 04 Mar 2025 09:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107942; x=1741712742; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2+a3Z9er7HS5GhzYho010S7pznnO0QcQ46P/wgZR3Rg=; b=HWeitVD2KfHXmID+JZ0Qw97az5c4S5wCuYWb/qh1PoKs3mkNUER/F7p/d2srKVNvrw 7ZYwQzQlTbXJa+xJ1M+/Ky4NUxfnWNkCM23LmrZ9u/uVq0m3aN1IDMHt/pS5bda4Py+N rUogfWzaLnd3LHPLBPTYgoOHncg7K/TdqS9RJMyi2p614MxjDcngJa541Opm1ep/FJTp QrU1MWqry/N6+b90kHydMqqzugCEFH84hc/Z+WLTQuQfzDmRsgwULR5jtnHco0A6KQVK nceYkki+sOCjkti7fvQUAEumI6GeS7B2g3iAKA08eIGN7Waj8J3W7ZoiZMxZ4nZ8Syy2 L9NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107942; x=1741712742; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2+a3Z9er7HS5GhzYho010S7pznnO0QcQ46P/wgZR3Rg=; b=Fk8QpHoxoSXANa+ApYncRTeyP34w1Ks7JEgaaNecGh679cy3v7sFNn+OsIV0PjrVFH sSkTIDlzCuz+nZZitHF7t1EjFhh2zlDkkByx1+oUd/5ODaqIvlx0poBW/rJ04i3mJUuU IF5z6NxYUouoHKq28Qlxs8gmCm7RDaKVpS2PhGCuVazbX6F+z1WmbRSpXCiE3D26i5iz HNg+94cdy/wMtQJ4D9JM6Mcr1GFiXhV7q0EnciiErBIgKKqqtgz7zce70kaNXSy2Hpwf 6DZnoHFN2h7F6kbcpC8Wq5MRZZYjHI6Upv2B8UMmRYwd7PjPlxw5k6+eD16IKN7f4mCV ICdA== X-Gm-Message-State: AOJu0YxaWZFM6NQHEoxfoGI/Nz62RB8gQhhql0DvrZOxmrWDk168KKtR slF6j50fcFhpY3NkoNdi5qXpO/bkgap4Ma/sExn5DlpjoBT1+tRw06jsIaSafSU= X-Gm-Gg: ASbGncvPFYaEAkMOn0ar3q5Pokf/77OF1j+hsnkdFOVvPjjh/VXJKPUVT9LqsKB2keW 2SHAWDmtnBzTdsSXHz9yEMmxyNrxr89y6amKm08sbemyJ8D3DdwGkGq4Pf657VgAqHsoirmitLu m7Llc5n8S72JKWbULI6oWe7BRh9NXgeRyXO5iSt9bCh3n0vbCEVK6moXmNcwT7HHPoNp2jVo9Xw AkvLnPL2x7rkwQt/681FyvSgJLOZlTjDuNiymu9bN4iaiLb19E2wkEz8Djv9VbFww1L5ckSFXmr O0lHmRiol5Mwh2bZGmXbeIWlyhWavNpnmR2ld1Q2ZxAY5wA3dXmI2lY8eAo3xa75eR16SwnkF18 AGiW1flCYDBd+JEev26iANxuSQthT X-Google-Smtp-Source: AGHT+IFBi6JjsYJDnSEwMCPY80NtpnY/0pWo317IbLvcMp22I1j/lVgkodnN+FQ/p9Zn6V6GISOI9g== X-Received: by 2002:a05:6000:178c:b0:390:debd:70c3 with SMTP id ffacd0b85a97d-390eca25fbdmr19248281f8f.54.1741107941433; Tue, 04 Mar 2025 09:05:41 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:41 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:43 +0000 Subject: [PATCH v2 15/16] rtc: max77686: use dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-15-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-max77686.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 6b0d02b44c8097453f704cbec9f02580fb869ca3..69ea3ce75b5a5426d4a56b97977= 3be71c4ee7562 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -704,10 +704,9 @@ static int max77686_init_rtc_regmap(struct max77686_rt= c_info *info) } =20 info->regmap =3D dev_get_regmap(parent, NULL); - if (!info->regmap) { - dev_err(info->dev, "Failed to get rtc regmap\n"); - return -ENODEV; - } + if (!info->regmap) + return dev_err_probe(info->dev, -ENODEV, + "Failed to get rtc regmap\n"); =20 if (info->drv_data->rtc_i2c_addr =3D=3D MAX77686_INVALID_I2C_ADDR) { info->rtc_regmap =3D info->regmap; @@ -716,28 +715,24 @@ static int max77686_init_rtc_regmap(struct max77686_r= tc_info *info) =20 client =3D devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, info->drv_data->rtc_i2c_addr); - if (IS_ERR(client)) { - dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(client); - } + if (IS_ERR(client)) + return dev_err_probe(info->dev, PTR_ERR(client), + "Failed to allocate I2C device for RTC\n"); =20 info->rtc_regmap =3D devm_regmap_init_i2c(client, info->drv_data->regmap_config); - if (IS_ERR(info->rtc_regmap)) { - ret =3D PTR_ERR(info->rtc_regmap); - dev_err(info->dev, "Failed to allocate RTC regmap: %d\n", ret); - return ret; - } + if (IS_ERR(info->rtc_regmap)) + return dev_err_probe(info->dev, PTR_ERR(info->rtc_regmap), + "Failed to allocate RTC regmap\n"); =20 add_rtc_irq: ret =3D regmap_add_irq_chip(info->rtc_regmap, info->rtc_irq, IRQF_ONESHOT | IRQF_SHARED, 0, info->drv_data->rtc_irq_chip, &info->rtc_irq_data); - if (ret < 0) { - dev_err(info->dev, "Failed to add RTC irq chip: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "Failed to add RTC irq chip\n"); =20 return 0; } --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 23:37:05 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91FB72BF134 for ; Tue, 4 Mar 2025 17:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107947; cv=none; b=TZJqohBw6ei5PEz+fqDH/ANyGg1aXe6RCjIbo0R/Go/yQ3+JOCZhIHtm5RSNKWdZFFNBaw0gb5PMUD7dDgtdK+olK4rY6YdOd/3Nft7x6y2Du5OVXO4hdf/VSv9uw2KVMZL79uGkceKhip/0xIlAMfBgkxk4Qw2NBWmRf+hjSGQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741107947; c=relaxed/simple; bh=1+UZb0QJk2ChT7YBKoTmCJG5wrAK+GA3H4NxSsqsqCU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qUIXvdvQ+UuTSrTGMZDn3he1RjArhJTzmeuhnIZqsT2hID8IEG/AytF7zX/9sAcnMWyFJqUB/yJYymkVcxyNj8ZZhmrLbZY9/tU14LYbL2jbyIhd3b5xgSr6BHUDRINMi/lalPm9qOSNUKM7iAfIri+I4uJOygh2UPMSAU7gJSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=d3oco5Em; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d3oco5Em" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-abf5358984bso537645966b.3 for ; Tue, 04 Mar 2025 09:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107942; x=1741712742; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dKiEbfv2wxdcP+dRwBnTiew8ux2INId3e+zLxFho3GE=; b=d3oco5Em6LpOvP0G9jtoTAJeG32NkODP1cxZWrmD2Dvc1pQj0TvHv1OqugA/e/+qY6 QYY3pspflFFEXZMkD1EfJ4ZLZ1WN0pvlKUp3MuSGP7GBS/4lMMHw42SFEEZrgeHgE5o/ k57vTk++rBCCGzoWPv8ZhZRbnVX+GWF9yZ2qt9mwEamr84NPJ1fht5uzeiymeM/sGPai ETDC5rNMNoy1cW6BxAwhUPg6iEJi+CKGChHkMJC8zpyV9C62UYDpe5sTIsE2YVqMoTo6 3/SYAjE8orpFqrPhfKtL0JG1JAOJoQYYftiIyqeaEvya6Ss7c4VRbbclz9iLRYA/1Bdl mGyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107942; x=1741712742; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dKiEbfv2wxdcP+dRwBnTiew8ux2INId3e+zLxFho3GE=; b=PD4snTJsm/frEUaKBzFroBM/R8KPCZOGq+oMyVR5Itxv7OVMW5Tyu8lpcV/5MtEFMr LKmqSVBGpBhXIyqUF8z9/MUYR0R9Q4JVt7bYe8FwgcqCzOyVZ+jMLM3KRwzmfLx2BMAR tMRLakh0vp1ECk4XNGsTGysxyGO8oolECpGq0xRLNbEmgR99vLqzTc3v6D3hccSo6h4I qPmkq+wXZfU93oYoZNAgjkclzqBv/9QiKFF+Ogf8bWaHxCHE+1L3Br778wlHhYjRhNOy UfbjEXHlbDp5+5EWS3z8UL5oCiRd8De80Gm4tFmzkkS8GpZSDLRGoFjw4haoeq+0bxM5 zQXg== X-Gm-Message-State: AOJu0YwMGSmKm3PFcrVuf7dYuD5bio/cn6Cyn7s72ZLzZfysEVTsOpQ1 7sYuLEI2hW0aCDunPAw3E1zSrkOdW36virlpGMuUdqaRkEGmuimbph0uvIr2gho= X-Gm-Gg: ASbGnctcUs60rrkHM/iy8Dt7jEYYvqUO2z9WDteMz2SWA951TRGo6uLozvSJxCzKDNg jZlnIo2XzCNY10cAKzmqwKimR1nyDOyIegyHzKNc/M/n0q2Z8nd4SEWTnWdkqURu2Q/uC2JPz5h 5Ra4zwc1wy1SkorztETWhwCdiEhfXbdnS9O8rUOY8VkLYbnvJrmZT7XnFWJyuOCvu5VrSyM+Iq8 yJ0yEwLuCxbcgHieCkPZXHlXXc/ybZ95plNICVpbsRdt89DogpNJV0xAyMYo6nmZOBKJxcrI6O3 SYGHMm4r+4SwSmIi7P5kyyst8XYFRBUjK6SuqNKsdNkF4OWWgJeFMx12g1idcjP8Jxsce35pMxX +uIo4jvHX3shCDsFYwrwqEW5zO0/i X-Google-Smtp-Source: AGHT+IFbhvINfL30hs3YpvAxvNGhpuF08a7SPp+ErND7dZCCpi05AobDmHrT2jaUznfQQ+NeOSHQXw== X-Received: by 2002:a17:907:2d0d:b0:abf:777d:fb7a with SMTP id a640c23a62f3a-ac20da97c7dmr2947466b.46.1741107942351; Tue, 04 Mar 2025 09:05:42 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:41 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:44 +0000 Subject: [PATCH v2 16/16] rtc: s5m: convert to dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-rtc-cleanups-v2-16-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s5m.c | 50 +++++++++++++++++++++--------------------------= --- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 88aed27660348a05886f080a2848fcabbf9666d0..db5c9b641277213aa1371776c63= e2eda3f223465 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -626,11 +626,10 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *= info) } =20 info->rtc_24hr_mode =3D 1; - if (ret < 0) { - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", - __func__, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "%s: fail to write controlm reg\n", + __func__); =20 return ret; } @@ -669,26 +668,21 @@ static int s5m_rtc_probe(struct platform_device *pdev) alarm_irq =3D S5M8767_IRQ_RTCA1; break; default: - dev_err(&pdev->dev, - "Device type %lu is not supported by RTC driver\n", - platform_get_device_id(pdev)->driver_data); - return -ENODEV; + return dev_err_probe(&pdev->dev, -ENODEV, + "Device type %lu is not supported by RTC driver\n", + platform_get_device_id(pdev)->driver_data); } =20 i2c =3D devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, RTC_I2C_ADDR); - if (IS_ERR(i2c)) { - dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(i2c); - } + if (IS_ERR(i2c)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c), + "Failed to allocate I2C for RTC\n"); =20 info->regmap =3D devm_regmap_init_i2c(i2c, regmap_cfg); - if (IS_ERR(info->regmap)) { - ret =3D PTR_ERR(info->regmap); - dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", - ret); - return ret; - } + if (IS_ERR(info->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap), + "Failed to allocate RTC register map\n"); =20 info->dev =3D &pdev->dev; info->s5m87xx =3D s5m87xx; @@ -696,11 +690,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) =20 if (s5m87xx->irq_data) { info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) { - dev_err(&pdev->dev, "Failed to get virtual IRQ %d\n", - alarm_irq); - return -EINVAL; - } + if (info->irq <=3D 0) + return dev_err_probe(&pdev->dev, -EINVAL, + "Failed to get virtual IRQ %d\n", + alarm_irq); } =20 platform_set_drvdata(pdev, info); @@ -724,11 +717,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) ret =3D devm_request_threaded_irq(&pdev->dev, info->irq, NULL, s5m_rtc_alarm_irq, 0, "rtc-alarm0", info); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", - info->irq, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to request alarm IRQ %d\n", + info->irq); device_init_wakeup(&pdev->dev, true); } =20 --=20 2.48.1.711.g2feabab25a-goog