From nobody Mon Feb 9 21:21:28 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3FC714A4CC for ; Tue, 4 Mar 2025 01:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741052671; cv=none; b=EYdk+J6ds2DIM7NrmKEWi6SrdU7jBlqr5Hv2W7C8rAhIG0ytH6au6CZKMuYaSVBhNwRuTQD7XluH4KbhdejY0JeVZ9M3JhmLzO86drw+x2gXnqnzW1+njpQRnllzl18HuVLj0fRSgnoZpE9c6Vo2k8P+viyEutyXZc8lNZHlmQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741052671; c=relaxed/simple; bh=sVknEgGNvct3p8aN+CRi6/k6aF+awKULL5O/9DK0SkA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MvsNTmoDrhBCF+rMv+vr6GZiRhLW5oXzh8ovnoynuhk4EcWO9zz9h6yVklUBxwU6It14lVfPcTyU5yfFD1P04pGeHv/Zhq0psk77F0nDmjbiHUEUz99IWVfNZtcaJlUm8rnwLiN4GasrKRm8az6tWAZHGLoykP734+ZQoyBz9ME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ak4uWnPZ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ak4uWnPZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1741052664; bh=sVknEgGNvct3p8aN+CRi6/k6aF+awKULL5O/9DK0SkA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ak4uWnPZXqtzuQ1GE+TpAm/gdOwpFUg1+TvLQS8H7koUNRxZjYQ+xSUf74miLb04e KnZP5d2MhRpyvKRYn3i3XxNTODrfdGY87iM1H2KhA8PdTd2jVbhQyyTCaQeclXF5s6 4ljvESwXIUKgKEIrRhL8zdZfwZ09VlgiPPax/1qpcgsXeOd9XVx2lUK9p0eJ/FFCfu qzV0lRs8pUBp1EWWgQnQdROrb6OumxNWt7LZVQ6meN25gjlWfR+zuvE5VRB0IFfD0V J13fkfpXCiCHWT+KdpW04Ptp01E7/AKz+Kd0dUWYi0FJVz57cSyzQKahZRJpD2VBwy dUg8UMTZ7k/DQ== Received: from localhost (unknown [188.27.58.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with UTF8SMTPSA id 468E817E1023; Tue, 4 Mar 2025 02:44:24 +0100 (CET) From: Cristian Ciocaltea Date: Tue, 04 Mar 2025 03:44:07 +0200 Subject: [PATCH v4 08/12] phy: rockchip: samsung-hdptx: Provide config params validation support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-phy-sam-hdptx-bpc-v4-8-8657847c13f7@collabora.com> References: <20250304-phy-sam-hdptx-bpc-v4-0-8657847c13f7@collabora.com> In-Reply-To: <20250304-phy-sam-hdptx-bpc-v4-0-8657847c13f7@collabora.com> To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: Algea Cao , Sandor Yu , Dmitry Baryshkov , Maxime Ripard , kernel@collabora.com, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-Mailer: b4 0.14.2 Implement the phy_ops.validate() callback to allow checking the PHY configuration parameters without actually applying them. Signed-off-by: Cristian Ciocaltea --- drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 23 +++++++++++++++++++= ++++ 1 file changed, 23 insertions(+) diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c b/drivers/ph= y/rockchip/phy-rockchip-samsung-hdptx.c index 7e1d1c10758249aa5bbddbdaae0108bba04f30df..47db1395051f5d900197871694b= ab90ca4d6e38e 100644 --- a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c +++ b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c @@ -1482,6 +1482,17 @@ static int rk_hdptx_phy_verify_hdmi_config(struct rk= _hdptx_phy *hdptx, if (!hdmi->tmds_char_rate || hdmi->tmds_char_rate > HDMI20_MAX_RATE) return -EINVAL; =20 + u32 bit_rate =3D hdmi->tmds_char_rate / 100; + int i; + + for (i =3D 0; i < ARRAY_SIZE(ropll_tmds_cfg); i++) + if (bit_rate =3D=3D ropll_tmds_cfg[i].bit_rate) + break; + + if (i =3D=3D ARRAY_SIZE(ropll_tmds_cfg) && + !rk_hdptx_phy_clk_pll_calc(bit_rate, NULL)) + return -EINVAL; + return 0; } =20 @@ -1789,10 +1800,22 @@ static int rk_hdptx_phy_configure(struct phy *phy, = union phy_configure_opts *opt return 0; } =20 +static int rk_hdptx_phy_validate(struct phy *phy, enum phy_mode mode, + int submode, union phy_configure_opts *opts) +{ + struct rk_hdptx_phy *hdptx =3D phy_get_drvdata(phy); + + if (mode !=3D PHY_MODE_DP) + return rk_hdptx_phy_verify_hdmi_config(hdptx, &opts->hdmi); + + return rk_hdptx_phy_verify_dp_config(hdptx, &opts->dp); +} + static const struct phy_ops rk_hdptx_phy_ops =3D { .power_on =3D rk_hdptx_phy_power_on, .power_off =3D rk_hdptx_phy_power_off, .configure =3D rk_hdptx_phy_configure, + .validate =3D rk_hdptx_phy_validate, .owner =3D THIS_MODULE, }; =20 --=20 2.48.1