From nobody Mon Dec 15 21:26:26 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AAC4264F8C for ; Tue, 4 Mar 2025 21:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122381; cv=none; b=UNMiQYKb7OJYsD7nCDx/otTF/r2m0SMzNg1vRbGqyJAhkGr1VLkfmRXA6u3uCNZjf8yazl0Cz38bVj3YOGyfP3tSIEG8nSMbUwTXfkGLe5P0wlI2K4HD8FZSzLzqWgOfgr4OPpNe4LnPbaidYI4TBzcNb5z+hVjly5sWSGBAYVs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122381; c=relaxed/simple; bh=qdWoCRSaEyGwiB1pCeMHCVglO9KpvJz3OeotRemVCtM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lFVKi53V+21fYBK4DBmOGJOOR4CEsB8YybH+9RJfXLi4tPNjJfTt8L4Bson/Wly6ADW92l7PHrzlJhpnxpDMRf82RTqMwCyXvtwKvHoH3VDVmEB2NKsOrI774honXngkKl9nEMFQyGtGF6JuOZgeBbI1IXluLgIbBp+BsBYCnDs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aHeWtWhL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aHeWtWhL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741122378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rEUADPvt5vUb0DPdb4ydVYz2t+TuARR2y9RFIuVvjk4=; b=aHeWtWhLyGgHV2pB6aOPTz1XMmW8cwLNRM8f+bG8uMgzo+PXEKrrnzM0cXgCjrPV9bL6aF k7kQs9tKOm40TEdVggvf63oqIS2I+XaKivFRDNS/ATz6odH3nTXoB8JrhWTb+INqfUT/X2 oOt6FSylusId95Gp4aEmsQ27yn4AAjE= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-aD6fIKblM1CdoJFJ_B3qKg-1; Tue, 04 Mar 2025 16:06:02 -0500 X-MC-Unique: aD6fIKblM1CdoJFJ_B3qKg-1 X-Mimecast-MFC-AGG-ID: aD6fIKblM1CdoJFJ_B3qKg_1741122358 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 551FA1800989; Tue, 4 Mar 2025 21:05:57 +0000 (UTC) Received: from asrivats-na.rmtustx.csb (unknown [10.2.16.107]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6AFF81800361; Tue, 4 Mar 2025 21:05:49 +0000 (UTC) From: Anusha Srivatsa Date: Tue, 04 Mar 2025 16:05:31 -0500 Subject: [PATCH v5 1/7] drm/fsl-dcu: move to devm_platform_ioremap_resource() usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-mem-fixes-v1-1-fb3dab8d901f@redhat.com> References: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> In-Reply-To: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> To: Stefan Agner , Alison Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Marek Vasut , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Raphael Gallais-Pou , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jonathan Corbet Cc: Dan Carpenter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, Anusha Srivatsa X-Developer-Signature: v=1; a=ed25519-sha256; t=1741122340; l=1621; i=asrivats@redhat.com; s=20250122; h=from:subject:message-id; bh=qdWoCRSaEyGwiB1pCeMHCVglO9KpvJz3OeotRemVCtM=; b=XXW32Rtiy4P6fBUnnYgHXkX7nAGj1GjI07HhKOKSoEKm4jsLZoO7bPwhhWNtFaji8/Ow4zIKQ 6AVOybQONpRBfLZVnq68Jsf/krtVTSz4PdAUmbzyTxKxsRlvlmRH7zz X-Developer-Key: i=asrivats@redhat.com; a=ed25519; pk=brnIHkBsUZEhyW6Zyn0U92AeIZ1psws/q8VFbIkf1AU= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res =3D platform_get_resource(pdev,...); -ioremap_res =3D devm_ioremap_resource(...); +ioremap_res =3D devm_platform_ioremap_resource(pdev,0); Cc: Stefan Agner Cc: Alison Wang Reviewed-by: Maxime Ripard Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fs= l-dcu/fsl_dcu_drm_drv.c index 03b076db9381a5db0bff6576cda2772495a61fed..3bbfc1b56a6557e2f54d2b7ed09= 9531053871341 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -260,7 +260,6 @@ static int fsl_dcu_drm_probe(struct platform_device *pd= ev) struct fsl_dcu_drm_device *fsl_dev; struct drm_device *drm; struct device *dev =3D &pdev->dev; - struct resource *res; void __iomem *base; struct clk *pix_clk_in; char pix_clk_name[32]; @@ -278,8 +277,7 @@ static int fsl_dcu_drm_probe(struct platform_device *pd= ev) return -ENODEV; fsl_dev->soc =3D id->data; =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - base =3D devm_ioremap_resource(dev, res); + base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) { ret =3D PTR_ERR(base); return ret; --=20 2.48.1 From nobody Mon Dec 15 21:26:26 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E583E265639 for ; Tue, 4 Mar 2025 21:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122376; cv=none; b=Vqq0WM/a+HlJ3DeMxWpn6D0dyFckbs5IHvvtw8/qabIQ7cyP1XM+rEB0DgIVjor2HzetpBzAYAD1t3JhNPNXiJy/AbZggOUj0E28uICX0Wejw6ueMMUiFHTTLkgzPBYxI9CaogCC4LvaFZDfDDeCdamDl8mub3sY8LkmmgKPjVA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122376; c=relaxed/simple; bh=oMnZPC9HfrwqOolnznL0vrEyroxHYMcgs+Plnnla5aQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I7sWVUOS9eb/pAdMr/j40XdYJLeVrwmG3nygWxP2mgapH4ILqnoQsjk8ImBkyHJ7oY/NYYzUWV7ZpEf197ykh2qSKfo9IhPoDSjd41GhGGTpqKwv7uQjPoibw6wzQHEqo++KQXIGoIt/SLKBVxvSxnL71Ggp0vPmBirajL1wkH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ftNLJaiy; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ftNLJaiy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741122373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LQce4qpcRmddUf2QLSsjxR1D9l6diq/uQYF6rsz7TN8=; b=ftNLJaiyj7lx7MeLkKnWL54eV33CuTbbR8tQ7yooKQRMlmwI46nuon6ohXPFxKmXtMzWtc +nnCa0SoLeqim15RORViXHzf2FllPtLcc+n5hXtbBqsIi3rHsksbbl948qij5JoqBY8ZRZ 3prlrwYjUgdCjmV3PzUXtqt54J9WOz0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-aGf9to6LNquqNmDuxHVF4Q-1; Tue, 04 Mar 2025 16:06:10 -0500 X-MC-Unique: aGf9to6LNquqNmDuxHVF4Q-1 X-Mimecast-MFC-AGG-ID: aGf9to6LNquqNmDuxHVF4Q_1741122365 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BDD911944EB8; Tue, 4 Mar 2025 21:06:04 +0000 (UTC) Received: from asrivats-na.rmtustx.csb (unknown [10.2.16.107]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8257C1800362; Tue, 4 Mar 2025 21:05:57 +0000 (UTC) From: Anusha Srivatsa Date: Tue, 04 Mar 2025 16:05:32 -0500 Subject: [PATCH v5 2/7] drm/hisilicon: move to devm_platform_ioremap_resource() usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-mem-fixes-v1-2-fb3dab8d901f@redhat.com> References: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> In-Reply-To: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> To: Stefan Agner , Alison Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Marek Vasut , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Raphael Gallais-Pou , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jonathan Corbet Cc: Dan Carpenter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, Anusha Srivatsa X-Developer-Signature: v=1; a=ed25519-sha256; t=1741122340; l=2968; i=asrivats@redhat.com; s=20250122; h=from:subject:message-id; bh=oMnZPC9HfrwqOolnznL0vrEyroxHYMcgs+Plnnla5aQ=; b=62rURfdaBIFw7DrCUv9fnUH7p6ysEIVMO/4/Yg5GBDo21fhkxUh+Ifx+cAee6vXqZcsPQaymk krpxTrF8eWhBfqfD4RXviNahensiujDCY2uf/vUOK9KH3kGTS8MeCB8 X-Developer-Key: i=asrivats@redhat.com; a=ed25519; pk=brnIHkBsUZEhyW6Zyn0U92AeIZ1psws/q8VFbIkf1AU= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res =3D platform_get_resource(pdev,...); -ioremap_res =3D devm_ioremap_resource(...); +ioremap_res =3D devm_platform_ioremap_resource(pdev,0); Cc: Xinliang Liu Cc: Tian Tao Cc: Xinwei Kong Cc: Sumit Semwal Cc: Yongqin Liu Cc: John Stultz Reviewed-by: Maxime Ripard Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 4 +--- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm= /hisilicon/kirin/dw_drm_dsi.c index 2eea9fb0e76bf3ead8f5914e6ebb65b5b3603b9a..e80debdc41763357cb2cf321205= c0dfac80a911e 100644 --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c @@ -825,7 +825,6 @@ static const struct component_ops dsi_ops =3D { static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi) { struct dsi_hw_ctx *ctx =3D dsi->ctx; - struct resource *res; =20 ctx->pclk =3D devm_clk_get(&pdev->dev, "pclk"); if (IS_ERR(ctx->pclk)) { @@ -833,8 +832,7 @@ static int dsi_parse_dt(struct platform_device *pdev, s= truct dw_dsi *dsi) return PTR_ERR(ctx->pclk); } =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - ctx->base =3D devm_ioremap_resource(&pdev->dev, res); + ctx->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(ctx->base)) { DRM_ERROR("failed to remap dsi io region\n"); return PTR_ERR(ctx->base); diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/= drm/hisilicon/kirin/kirin_drm_ade.c index 2eb49177ac42bc6dba692328cca5c99d5925041c..45c4eb008ad5d639340f769ad02= 2d186ec454722 100644 --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c @@ -844,7 +844,6 @@ static struct drm_plane_funcs ade_plane_funcs =3D { static void *ade_hw_ctx_alloc(struct platform_device *pdev, struct drm_crtc *crtc) { - struct resource *res; struct device *dev =3D &pdev->dev; struct device_node *np =3D pdev->dev.of_node; struct ade_hw_ctx *ctx =3D NULL; @@ -856,8 +855,7 @@ static void *ade_hw_ctx_alloc(struct platform_device *p= dev, return ERR_PTR(-ENOMEM); } =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - ctx->base =3D devm_ioremap_resource(dev, res); + ctx->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(ctx->base)) { DRM_ERROR("failed to remap ade io base\n"); return ERR_PTR(-EIO); --=20 2.48.1 From nobody Mon Dec 15 21:26:26 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73888277028 for ; Tue, 4 Mar 2025 21:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122385; cv=none; b=mW7gyksUTsZWccDtvemi+bM4DtYB6shO207KywBxq+wKaTkDosRtKPjExBzo0EHl3ecx+sw6cG8NWLg8e2NLBjwjLfcOy79jTjZzHklMvZVE6c6DN+YRsvFjj1b/7Eny+/aSnt6MZflfGkAdWEBmPRJCb5ypzar15NCHR2K6law= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122385; c=relaxed/simple; bh=+h+zwJrqhz4KcKBFOtg5ltWWvHHlCjpJOJiBG2cNAao=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=arO/8G57+KiuCMXYBCAzH++kYLJAuqtTRIPFpr2l6i9xo74kZYOEE8uFazvmJHXSXxvY3HzOITggrO3MW0kLRnALIUIzc1q/PKBGZhKwXkRlq3NDCSfZpmLJ3q9p2sCnSZhGkdWAqDooNUz6kOh47Rnru6foHv7FUKAPUaCrKDA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qu6tF5jt; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qu6tF5jt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741122382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kpyWlOaModCxFl+Tqqpp85hFGJYXyqIGL3Cy6JBVo+g=; b=Qu6tF5jttYQ7BnvvaaRPzqntCV387EAkTRUZEAKlwcWWeCpVkjyh2o/rgZc3l+3jX6HDwU YtVmaUR5Hfbe7ogVJ6PSwiEb+bAnp7SpU1GTd8K71yNZoji92OVCEPfrDPk/XTixc5/3AU BoA9k//y4g2BkQpWadh44vLVoIMZzOw= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-te3uQEo3M4ObyRfhV2_LKA-1; Tue, 04 Mar 2025 16:06:17 -0500 X-MC-Unique: te3uQEo3M4ObyRfhV2_LKA-1 X-Mimecast-MFC-AGG-ID: te3uQEo3M4ObyRfhV2_LKA_1741122372 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 087A1180087F; Tue, 4 Mar 2025 21:06:12 +0000 (UTC) Received: from asrivats-na.rmtustx.csb (unknown [10.2.16.107]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 145DF180035F; Tue, 4 Mar 2025 21:06:04 +0000 (UTC) From: Anusha Srivatsa Date: Tue, 04 Mar 2025 16:05:33 -0500 Subject: [PATCH v5 3/7] drm/mxsfb: move to devm_platform_ioremap_resource() usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-mem-fixes-v1-3-fb3dab8d901f@redhat.com> References: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> In-Reply-To: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> To: Stefan Agner , Alison Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Marek Vasut , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Raphael Gallais-Pou , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jonathan Corbet Cc: Dan Carpenter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, Anusha Srivatsa X-Developer-Signature: v=1; a=ed25519-sha256; t=1741122340; l=2524; i=asrivats@redhat.com; s=20250122; h=from:subject:message-id; bh=+h+zwJrqhz4KcKBFOtg5ltWWvHHlCjpJOJiBG2cNAao=; b=wtZWHnIqYTSgvPovPt4G5kDpdKBEDOzLh/gzDiSQOIa73OTtOq0t6bLXZLZdfVFHYPGYjMfNO bfXMkr1jyPMAtlajMl+saWTZMd2Mh3QHno9fmjOMJAGTKlFpdU0qBIO X-Developer-Key: i=asrivats@redhat.com; a=ed25519; pk=brnIHkBsUZEhyW6Zyn0U92AeIZ1psws/q8VFbIkf1AU= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res =3D platform_get_resource(pdev,...); -ioremap_res =3D devm_ioremap_resource(...); +ioremap_res =3D devm_platform_ioremap_resource(pdev,0); Cc: Marek Vasut Cc: Stefan Agner Reviewed-by: Maxime Ripard Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 4 +--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdi= f_drv.c index 8ee00f59ca821cea8e823e7100fb4d7534283994..fcb2a7517377e9a5bbd2997c578= c579b1b079f92 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -134,7 +134,6 @@ static int lcdif_load(struct drm_device *drm) { struct platform_device *pdev =3D to_platform_device(drm->dev); struct lcdif_drm_private *lcdif; - struct resource *res; int ret; =20 lcdif =3D devm_kzalloc(&pdev->dev, sizeof(*lcdif), GFP_KERNEL); @@ -144,8 +143,7 @@ static int lcdif_load(struct drm_device *drm) lcdif->drm =3D drm; drm->dev_private =3D lcdif; =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - lcdif->base =3D devm_ioremap_resource(drm->dev, res); + lcdif->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(lcdif->base)) return PTR_ERR(lcdif->base); =20 diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsf= b_drv.c index 59020862cf65e5cc488903f1263ed16dfbce06f9..377d4c4c9979ad9538cfec54648= 27a82936f811b 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -215,7 +215,6 @@ static int mxsfb_load(struct drm_device *drm, { struct platform_device *pdev =3D to_platform_device(drm->dev); struct mxsfb_drm_private *mxsfb; - struct resource *res; int ret; =20 mxsfb =3D devm_kzalloc(&pdev->dev, sizeof(*mxsfb), GFP_KERNEL); @@ -226,8 +225,7 @@ static int mxsfb_load(struct drm_device *drm, drm->dev_private =3D mxsfb; mxsfb->devdata =3D devdata; =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - mxsfb->base =3D devm_ioremap_resource(drm->dev, res); + mxsfb->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(mxsfb->base)) return PTR_ERR(mxsfb->base); =20 --=20 2.48.1 From nobody Mon Dec 15 21:26:26 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B6BD25FA14 for ; Tue, 4 Mar 2025 21:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122393; cv=none; b=N5fp+lASEAIIlkzzgXBuDG+Bh1XnYvtvGTR2VjTDAKefnuhDAR4EdymISuAsxgR3+Vpf4LH1d4r1JvbDF4iT8XCwaKT6H84spi7BukmWtZKzP0aAFJL/0kYAQL/CpkhwHykIR2/qEABeJ8G1R6nSTWV1qp9jBijsDRojKHs2b7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122393; c=relaxed/simple; bh=e7EAZ+KmeNfJYACxac/4HIs+1oMWt3cBSpu13fis9p8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jvz5IDTXLmiMTA6L4PyWLXX9OGV5+w3R+6mIjUIh3lgVVqj42r1v1S5djNu9vgp5jR3G2Wbl/LoDsl2yq5SRoJJFPG3yf81YoLMgamDZEFkk25lIV0dlWLyyqogyoXbDQeyhnAZgIs6oSz8QkmNMf5F7h+5ckvBHoK19NcIvnBg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VoZIvOuJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VoZIvOuJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741122390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFcCMfK9kRbxA/PdPW3zdXiOiPSBPDlYqROSR09dnjM=; b=VoZIvOuJqjJ/1XesMkpXcc1+QhYT0HDVsC/fEka953HTvT8vFbjWjSKD5XKVcOSbUBoyr9 lycFwd3Ay6j/0nXTJ8yFp5xL8abqGImpvkCJZeg1PKhtCDo+TcMYh583EUVXsFjXo1zBhE Ck2aJSbT83xcGK36G4vBGFsJvxCxHvQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-72bfiqqMOMyR2qhrhalNTg-1; Tue, 04 Mar 2025 16:06:25 -0500 X-MC-Unique: 72bfiqqMOMyR2qhrhalNTg-1 X-Mimecast-MFC-AGG-ID: 72bfiqqMOMyR2qhrhalNTg_1741122381 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5580D1944F05; Tue, 4 Mar 2025 21:06:20 +0000 (UTC) Received: from asrivats-na.rmtustx.csb (unknown [10.2.16.107]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 53ECE1800361; Tue, 4 Mar 2025 21:06:12 +0000 (UTC) From: Anusha Srivatsa Date: Tue, 04 Mar 2025 16:05:34 -0500 Subject: [PATCH v5 4/7] drm/sprd: move to devm_platform_ioremap_resource() usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-mem-fixes-v1-4-fb3dab8d901f@redhat.com> References: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> In-Reply-To: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> To: Stefan Agner , Alison Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Marek Vasut , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Raphael Gallais-Pou , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jonathan Corbet Cc: Dan Carpenter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, Anusha Srivatsa , Dmitry Baryshkov X-Developer-Signature: v=1; a=ed25519-sha256; t=1741122340; l=2864; i=asrivats@redhat.com; s=20250122; h=from:subject:message-id; bh=e7EAZ+KmeNfJYACxac/4HIs+1oMWt3cBSpu13fis9p8=; b=ys/SsEsGmjzQgZea8LqbK2IhVs/FOKEF4L1GqDD5qjRUNKHNm91m1YLg4jFnTkR1dD3lLNNAL HGHnws6i/2dCqW2OhErTnr6CHplGcJYBRtOI1xOmBwTrTcoixbwqQZE X-Developer-Key: i=asrivats@redhat.com; a=ed25519; pk=brnIHkBsUZEhyW6Zyn0U92AeIZ1psws/q8VFbIkf1AU= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Replace platform_get_resource + devm_ioremap with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_2@ identifier res; expression ioremap; identifier pdev; @@ -struct resource *res; ... -res =3D platform_get_resource(pdev,...); <... -if (!res) { -... -} ...> -ioremap =3D devm_ioremap(...); +ioremap =3D devm_platform_ioremap_resource(pdev,0); v2: Address the return handling properly since the new API returns error pointers and not NULL. Cc: Chunyan Zhang Cc: Dmitry Baryshkov Signed-off-by: Anusha Srivatsa Reviewed-by: Chunyan Zhang (v1) Reviewed-by: Maxime Ripard (v1) --- drivers/gpu/drm/sprd/sprd_dpu.c | 13 +++---------- drivers/gpu/drm/sprd/sprd_dsi.c | 13 +++---------- 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dp= u.c index cb2816985305fd19eac27413c214681a5a1e9ffa..a3447622a33cd612e34be038e83= 3222567bdcd2c 100644 --- a/drivers/gpu/drm/sprd/sprd_dpu.c +++ b/drivers/gpu/drm/sprd/sprd_dpu.c @@ -784,19 +784,12 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu, { struct platform_device *pdev =3D to_platform_device(dev); struct dpu_context *ctx =3D &dpu->ctx; - struct resource *res; int ret; =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(dev, "failed to get I/O resource\n"); - return -EINVAL; - } - - ctx->base =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!ctx->base) { + ctx->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(ctx->base)) { dev_err(dev, "failed to map dpu registers\n"); - return -EFAULT; + return PTR_ERR(ctx->base); } =20 ctx->irq =3D platform_get_irq(pdev, 0); diff --git a/drivers/gpu/drm/sprd/sprd_dsi.c b/drivers/gpu/drm/sprd/sprd_ds= i.c index 8fc26479bb6bce0aa94914f49d0986a7e19326c1..23b0e1dc547a5023ee6ad7d5e1c= 49e2cec986bf0 100644 --- a/drivers/gpu/drm/sprd/sprd_dsi.c +++ b/drivers/gpu/drm/sprd/sprd_dsi.c @@ -901,18 +901,11 @@ static int sprd_dsi_context_init(struct sprd_dsi *dsi, { struct platform_device *pdev =3D to_platform_device(dev); struct dsi_context *ctx =3D &dsi->ctx; - struct resource *res; =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(dev, "failed to get I/O resource\n"); - return -EINVAL; - } - - ctx->base =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!ctx->base) { + ctx->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(ctx->base)) { drm_err(dsi->drm, "failed to map dsi host registers\n"); - return -ENXIO; + return PTR_ERR(ctx->base); } =20 ctx->regmap =3D devm_regmap_init(dev, ®map_tst_io, dsi, &byte_config); --=20 2.48.1 From nobody Mon Dec 15 21:26:26 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97D47278116 for ; Tue, 4 Mar 2025 21:06:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122397; cv=none; b=LbZcOQt+kPb2FH36NR9Hh2nb0gsqm4uUz4DYoxp5yXExbQLMubqWNzmibuq+t0wH4a5qyJaDjqmhtpr128xLq2QWCtUp4dNgzLPIR158UBnlk5XueyvDLEebeB4b9Pz7EylxTijILSawkdykih44Sa++a0/CvsuPxm5iGa7Q0Jk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122397; c=relaxed/simple; bh=OciEGN0PmQ5giMoZ/vtKKE95gSivISgO/bMA/S68d1g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Eyc/9ss9eqYgIwd/WvgS0paPOxN+fQRvlqD8NiO9lHWBnefS5kk4Bu7hWCRS7yd69Wn8ewZs3dDidqpdynA2yrgYev9EpRLnIZZYcJrokoR99Cfg1kMfJqy3g+lUwF4CG3NcFgWy4Ke1zW6jaX5jVYLuUxUU5x5DCTy8HbzTPBA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=C2Q0F0Ky; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C2Q0F0Ky" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741122394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=arZ4Phoc4QRHLAgOYAvWa44V8ixn492Zd9/qUyKIGVo=; b=C2Q0F0Ky5DQvCQX4zMdPtNx0hHaRtIai4eCMwYy37SnQMzpV2detIBjPT9v3kLTNr//SvH B+w3OOmr/ifjH+Xnf5PGjUxkALg7w9yVuqYTksC4SBTq11zK13RAn0+WtLTvB/Gm83Tghc TaD5wUd/0rSAeCPDuEBfiSgF+f+B6t0= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-zoPGBDoAMrigwwTW2qD1iw-1; Tue, 04 Mar 2025 16:06:31 -0500 X-MC-Unique: zoPGBDoAMrigwwTW2qD1iw-1 X-Mimecast-MFC-AGG-ID: zoPGBDoAMrigwwTW2qD1iw_1741122387 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 017EB180099D; Tue, 4 Mar 2025 21:06:27 +0000 (UTC) Received: from asrivats-na.rmtustx.csb (unknown [10.2.16.107]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A1411180035F; Tue, 4 Mar 2025 21:06:20 +0000 (UTC) From: Anusha Srivatsa Date: Tue, 04 Mar 2025 16:05:35 -0500 Subject: [PATCH v5 5/7] drm/sti: move to devm_platform_ioremap_resource() usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-mem-fixes-v1-5-fb3dab8d901f@redhat.com> References: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> In-Reply-To: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> To: Stefan Agner , Alison Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Marek Vasut , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Raphael Gallais-Pou , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jonathan Corbet Cc: Dan Carpenter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, Anusha Srivatsa , Raphael Gallais-Pou X-Developer-Signature: v=1; a=ed25519-sha256; t=1741122340; l=9164; i=asrivats@redhat.com; s=20250122; h=from:subject:message-id; bh=OciEGN0PmQ5giMoZ/vtKKE95gSivISgO/bMA/S68d1g=; b=pTj0/PXEB22n1FQLUFIR8/LAGy1sIrANZpDm5HxggUTcvee4ua1syGzPNDCXXuVF8uYVzrV0g CW9SR7c/ykUDW1xoVMHHFjUE9sXUTfTT+8rzenx7K3T3io+nJmqDqip X-Developer-Key: i=asrivats@redhat.com; a=ed25519; pk=brnIHkBsUZEhyW6Zyn0U92AeIZ1psws/q8VFbIkf1AU= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Replace platform_get_resource/_byname + devm_ioremap with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule@ identifier res; expression ioremap; identifier pdev; constant mem; expression name; @@ -struct resource *res; ... -res =3D platform_get_resource_byname(pdev,mem,name); <... -if (!res) { -... -} ...> -ioremap =3D devm_ioremap(...); +ioremap =3D devm_platform_ioremap_resource_byname(pdev,name); and @rule_2@ identifier res; expression ioremap; identifier pdev; @@ -struct resource *res; ... -res =3D platform_get_resource(pdev,...); <... -if (!res) { -... -} ...> -ioremap =3D devm_ioremap(...); +ioremap =3D devm_platform_ioremap_resource(pdev,0); v2: Fix compilation error. v3: Handle returns properly since the new API return error pointers and not NULL Cc: Raphael Gallais-Pou Cc: Alain Volmat Reviewed-by: Maxime Ripard (v2) Acked-by: Raphael Gallais-Pou (v2) Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/sti/sti_compositor.c | 14 +++----------- drivers/gpu/drm/sti/sti_dvo.c | 14 +++----------- drivers/gpu/drm/sti/sti_hda.c | 13 +++---------- drivers/gpu/drm/sti/sti_hdmi.c | 15 +++------------ drivers/gpu/drm/sti/sti_hqvdp.c | 14 +++----------- drivers/gpu/drm/sti/sti_tvout.c | 14 +++----------- drivers/gpu/drm/sti/sti_vtg.c | 14 +++----------- 7 files changed, 21 insertions(+), 77 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_compositor.c b/drivers/gpu/drm/sti/sti= _compositor.c index 063f82d23d80c4ba83624a0066a18416a2b37351..8c529b0cca8b48fca532cd15e1f= 36fbe5bcbc71e 100644 --- a/drivers/gpu/drm/sti/sti_compositor.c +++ b/drivers/gpu/drm/sti/sti_compositor.c @@ -177,7 +177,6 @@ static int sti_compositor_probe(struct platform_device = *pdev) struct device_node *np =3D dev->of_node; struct device_node *vtg_np; struct sti_compositor *compo; - struct resource *res; unsigned int i; =20 compo =3D devm_kzalloc(dev, sizeof(*compo), GFP_KERNEL); @@ -194,17 +193,10 @@ static int sti_compositor_probe(struct platform_devic= e *pdev) =20 memcpy(&compo->data, of_match_node(compositor_of_match, np)->data, sizeof(struct sti_compositor_data)); - - /* Get Memory ressources */ - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (res =3D=3D NULL) { - DRM_ERROR("Get memory resource failed\n"); - return -ENXIO; - } - compo->regs =3D devm_ioremap(dev, res->start, resource_size(res)); - if (compo->regs =3D=3D NULL) { + compo->regs =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(compo->regs)) { DRM_ERROR("Register mapping failed\n"); - return -ENXIO; + return PTR_ERR(compo->regs); } =20 /* Get clock resources */ diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c index 4dcddd02629b6a1052be8fb8333bd3aa17c083c5..74a1eef4674eeabc445b53b380e= 325f785242024 100644 --- a/drivers/gpu/drm/sti/sti_dvo.c +++ b/drivers/gpu/drm/sti/sti_dvo.c @@ -511,7 +511,6 @@ static int sti_dvo_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct sti_dvo *dvo; - struct resource *res; struct device_node *np =3D dev->of_node; =20 DRM_INFO("%s\n", __func__); @@ -523,16 +522,9 @@ static int sti_dvo_probe(struct platform_device *pdev) } =20 dvo->dev =3D pdev->dev; - - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "dvo-reg"); - if (!res) { - DRM_ERROR("Invalid dvo resource\n"); - return -ENOMEM; - } - dvo->regs =3D devm_ioremap(dev, res->start, - resource_size(res)); - if (!dvo->regs) - return -ENOMEM; + dvo->regs =3D devm_platform_ioremap_resource_byname(pdev, "dvo-reg"); + if (IS_ERR(dvo->regs)) + return PTR_ERR(dvo->regs); =20 dvo->clk_pix =3D devm_clk_get(dev, "dvo_pix"); if (IS_ERR(dvo->clk_pix)) { diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index 14fdc00d2ba03d4f96ba407ac8e576decb6f32c0..eedccdf70833145d8cc31658891= 5db2c766bb31a 100644 --- a/drivers/gpu/drm/sti/sti_hda.c +++ b/drivers/gpu/drm/sti/sti_hda.c @@ -750,16 +750,9 @@ static int sti_hda_probe(struct platform_device *pdev) return -ENOMEM; =20 hda->dev =3D pdev->dev; - - /* Get resources */ - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "hda-reg"); - if (!res) { - DRM_ERROR("Invalid hda resource\n"); - return -ENOMEM; - } - hda->regs =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!hda->regs) - return -ENOMEM; + hda->regs =3D devm_platform_ioremap_resource_byname(pdev, "hda-reg"); + if (IS_ERR(hda->regs)) + return PTR_ERR(hda->regs); =20 res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "video-dacs-ctrl"); diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index 164a34d793d86f114394048667ae3189e1c39242..37b8d619066ef14a2def26e2e4f= 90a9c2194238d 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -1380,7 +1380,6 @@ static int sti_hdmi_probe(struct platform_device *pde= v) struct device *dev =3D &pdev->dev; struct sti_hdmi *hdmi; struct device_node *np =3D dev->of_node; - struct resource *res; struct device_node *ddc; int ret; =20 @@ -1399,17 +1398,9 @@ static int sti_hdmi_probe(struct platform_device *pd= ev) } =20 hdmi->dev =3D pdev->dev; - - /* Get resources */ - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "hdmi-reg"); - if (!res) { - DRM_ERROR("Invalid hdmi resource\n"); - ret =3D -ENOMEM; - goto release_adapter; - } - hdmi->regs =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!hdmi->regs) { - ret =3D -ENOMEM; + hdmi->regs =3D devm_platform_ioremap_resource_byname(pdev, "hdmi-reg"); + if (IS_ERR(hdmi->regs)) { + ret =3D PTR_ERR(hdmi->regs); goto release_adapter; } =20 diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvd= p.c index 0f658709c9d0d398c4eed65202443db9d0b41f8c..03684062309bbb9915d47fa6e64= 75cbb6c7beaaa 100644 --- a/drivers/gpu/drm/sti/sti_hqvdp.c +++ b/drivers/gpu/drm/sti/sti_hqvdp.c @@ -1356,7 +1356,6 @@ static int sti_hqvdp_probe(struct platform_device *pd= ev) struct device *dev =3D &pdev->dev; struct device_node *vtg_np; struct sti_hqvdp *hqvdp; - struct resource *res; =20 DRM_DEBUG_DRIVER("\n"); =20 @@ -1367,17 +1366,10 @@ static int sti_hqvdp_probe(struct platform_device *= pdev) } =20 hqvdp->dev =3D dev; - - /* Get Memory resources */ - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - DRM_ERROR("Get memory resource failed\n"); - return -ENXIO; - } - hqvdp->regs =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!hqvdp->regs) { + hqvdp->regs =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(hqvdp->regs)) { DRM_ERROR("Register mapping failed\n"); - return -ENXIO; + return PTR_ERR(hqvdp->regs); } =20 /* Get clock resources */ diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvou= t.c index af6c06f448c4819def8cc0d0836e30f991529690..6a464b035de800509fb6dc7c878= 0b5e1128643c1 100644 --- a/drivers/gpu/drm/sti/sti_tvout.c +++ b/drivers/gpu/drm/sti/sti_tvout.c @@ -838,7 +838,6 @@ static int sti_tvout_probe(struct platform_device *pdev) struct device *dev =3D &pdev->dev; struct device_node *node =3D dev->of_node; struct sti_tvout *tvout; - struct resource *res; =20 DRM_INFO("%s\n", __func__); =20 @@ -850,16 +849,9 @@ static int sti_tvout_probe(struct platform_device *pde= v) return -ENOMEM; =20 tvout->dev =3D dev; - - /* get memory resources */ - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "tvout-reg"); - if (!res) { - DRM_ERROR("Invalid glue resource\n"); - return -ENOMEM; - } - tvout->regs =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!tvout->regs) - return -ENOMEM; + tvout->regs =3D devm_platform_ioremap_resource_byname(pdev, "tvout-reg"); + if (IS_ERR(tvout->regs)) + return PTR_ERR(tvout->regs); =20 /* get reset resources */ tvout->reset =3D devm_reset_control_get(dev, "tvout"); diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c index 5ba469b711b5318e9e9e6d8df127fb8933d1fac1..ee81691b32036d2090204985118= 41f6da053e17d 100644 --- a/drivers/gpu/drm/sti/sti_vtg.c +++ b/drivers/gpu/drm/sti/sti_vtg.c @@ -380,23 +380,15 @@ static int vtg_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct sti_vtg *vtg; - struct resource *res; int ret; =20 vtg =3D devm_kzalloc(dev, sizeof(*vtg), GFP_KERNEL); if (!vtg) return -ENOMEM; - - /* Get Memory ressources */ - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - DRM_ERROR("Get memory resource failed\n"); - return -ENOMEM; - } - vtg->regs =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!vtg->regs) { + vtg->regs =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(vtg->regs)) { DRM_ERROR("failed to remap I/O memory\n"); - return -ENOMEM; + return PTR_ERR(vtg->regs); } =20 vtg->irq =3D platform_get_irq(pdev, 0); --=20 2.48.1 From nobody Mon Dec 15 21:26:26 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 700822777FB for ; Tue, 4 Mar 2025 21:06:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122404; cv=none; b=H6UgQx10INVugyEUnz6EHV97/wHaXeZcKkSnJ77vCKhdJMyIMYb7VCv61tHVyZk0p1Zw1KAnjC73kNAuGVUYoeSbiUuTMMuOUorRnklIOUVS5dkDgZIX6o7TTR+xBxSzr4DsJXRyShLTYxVxj7+EgwzieLc9QifkiUKbEAofoI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122404; c=relaxed/simple; bh=/1uyauwGTyarRS5zbo7VigxpNs57qz5tT34D8A+G7fo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LLc6BnYDWiC6EkJJoc8vR4oPzskTxtQg5hVxdM4rYqL9CIe3hck20wY4ukvIGpY3sXQmyEGqWr1DQ2GDg2HjqkHED+wWyEbow4lGZi2UTy+RTydRbmARqxWSatfspvJyUX0AUkd5mb3+2cjM23c/IooIUP6WjGpAYmYpSR1zDV0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dSeSGW03; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dSeSGW03" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741122402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MO1oDsAGx4BA8WWOCDr9myR5I52bhpUx7oLdchtJUhA=; b=dSeSGW03BPjW5/vtYMU0oIk94KYuBPgx6zcPJL8/2rDTGLH5/PFpiwyDPNEu2/MiSZak9p Xp++U3mR6SRgGNW+ZU0h1Rwq3wdod/VLZk55rFysf7/2lI6WrhILR2bKcDvdfar2DVkN87 ydmDFSOlyf4qknwYOHD1hs/6ptNEU10= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-bXja5sp3M1KshUiRQ4-eaw-1; Tue, 04 Mar 2025 16:06:38 -0500 X-MC-Unique: bXja5sp3M1KshUiRQ4-eaw-1 X-Mimecast-MFC-AGG-ID: bXja5sp3M1KshUiRQ4-eaw_1741122394 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF5F5180098B; Tue, 4 Mar 2025 21:06:33 +0000 (UTC) Received: from asrivats-na.rmtustx.csb (unknown [10.2.16.107]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4D8B81800361; Tue, 4 Mar 2025 21:06:27 +0000 (UTC) From: Anusha Srivatsa Date: Tue, 04 Mar 2025 16:05:36 -0500 Subject: [PATCH v5 6/7] drm/tegra: move to devm_platform_ioremap_resource() usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-mem-fixes-v1-6-fb3dab8d901f@redhat.com> References: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> In-Reply-To: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> To: Stefan Agner , Alison Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Marek Vasut , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Raphael Gallais-Pou , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jonathan Corbet Cc: Dan Carpenter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, Anusha Srivatsa X-Developer-Signature: v=1; a=ed25519-sha256; t=1741122340; l=1560; i=asrivats@redhat.com; s=20250122; h=from:subject:message-id; bh=/1uyauwGTyarRS5zbo7VigxpNs57qz5tT34D8A+G7fo=; b=iOHYkEofhz7g9PAkjQS/oPydE4OY11I24guknaXWtgIJGT0Hu6eIxQuqc/nqFl3SLCuPDTj4P uGEGQF4mNSBAi6wNhTvjhD1i8NY46NNANbT1yyugwJIcBrmfMVmAeKV X-Developer-Key: i=asrivats@redhat.com; a=ed25519; pk=brnIHkBsUZEhyW6Zyn0U92AeIZ1psws/q8VFbIkf1AU= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res =3D platform_get_resource(pdev,...); -ioremap_res =3D devm_ioremap_resource(...); +ioremap_res =3D devm_platform_ioremap_resource(pdev,0); Cc: Thierry Reding Cc: Mikko Perttunen Reviewed-by: Maxime Ripard Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/tegra/dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 9bb077558167293c8e47ca9578cef13172b0b22f..b5089b7722676cfaee5d28216af= 4ae706a47f895 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -1564,7 +1564,6 @@ static int tegra_dsi_ganged_probe(struct tegra_dsi *d= si) static int tegra_dsi_probe(struct platform_device *pdev) { struct tegra_dsi *dsi; - struct resource *regs; int err; =20 dsi =3D devm_kzalloc(&pdev->dev, sizeof(*dsi), GFP_KERNEL); @@ -1636,8 +1635,7 @@ static int tegra_dsi_probe(struct platform_device *pd= ev) goto remove; } =20 - regs =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - dsi->regs =3D devm_ioremap_resource(&pdev->dev, regs); + dsi->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(dsi->regs)) { err =3D PTR_ERR(dsi->regs); goto remove; --=20 2.48.1 From nobody Mon Dec 15 21:26:26 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A76F8264F8C for ; Tue, 4 Mar 2025 21:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122410; cv=none; b=fsoEfU1EikFJl7vH6/cs7QA7WtRmL4NaOaNjJQNjeRxD/yG8kcHbGmxq/qFRzFjoi8r/lSnZx0OqMYgYw1ka5t2Gufy5YNpOr8lIZjdK3VU0c9YzGRiCzHIPTAW6i+q5Zg6qgyGejRmiNaOnz2MmlE+nnCA6lk7OZd8eT6gZc1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741122410; c=relaxed/simple; bh=a+9vSiehl6gknw6Mmbey4xtGtLQG5CCHOmYcTZZMmdo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uHKm5o8rP67TIZpKthLHFzE/NuwrP7PZIX/ZAE2RSsDadO8o0777ksPbUgfEzpAdalO9FanP1YWr0KoAo7MgcpoiP3M9x73x/ZYB3CvY74MweAOiEwXjuBqCA0Rkl/rDONS5cgT8zVVq/gSubwP7JxVOZ59HnlCtqCm6d4jNZgU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SvdDZrkv; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SvdDZrkv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741122407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXScMvqY7wnhyHgtPtCu0A5GRSUf3CJsowbwzHCyWmo=; b=SvdDZrkvTkeJpGEYQGrpP78rEBKhUCp+MZlU6ExMVfyEK9mXv2OYTKEORdr7m4L0KcwA5F AeeoubUAFfWAETM7IwftAJXhBvz2zX0B6qslEl0rTUVWwQZOaGnXEkpnFNx8H5clDIXlrK JRAdGXpKlEV6bfFTmsxesQD1HxQSORE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-0cKN8XxRM0mrXwnxQn2CEA-1; Tue, 04 Mar 2025 16:06:44 -0500 X-MC-Unique: 0cKN8XxRM0mrXwnxQn2CEA-1 X-Mimecast-MFC-AGG-ID: 0cKN8XxRM0mrXwnxQn2CEA_1741122400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7190E1954B1C; Tue, 4 Mar 2025 21:06:40 +0000 (UTC) Received: from asrivats-na.rmtustx.csb (unknown [10.2.16.107]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 18CB7180035F; Tue, 4 Mar 2025 21:06:33 +0000 (UTC) From: Anusha Srivatsa Date: Tue, 04 Mar 2025 16:05:37 -0500 Subject: [PATCH v5 7/7] Documentation: Update the todo Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250304-mem-fixes-v1-7-fb3dab8d901f@redhat.com> References: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> In-Reply-To: <20250304-mem-fixes-v1-0-fb3dab8d901f@redhat.com> To: Stefan Agner , Alison Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Marek Vasut , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Raphael Gallais-Pou , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jonathan Corbet Cc: Dan Carpenter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, Anusha Srivatsa X-Developer-Signature: v=1; a=ed25519-sha256; t=1741122340; l=1624; i=asrivats@redhat.com; s=20250122; h=from:subject:message-id; bh=a+9vSiehl6gknw6Mmbey4xtGtLQG5CCHOmYcTZZMmdo=; b=8rCBCsNcZ8amMTaIWFiJodYpFjxHIQvmmD9mzX+B3axhphImg2RnoMahA4QjvfU1qzgfFB9SV k3E4bSlMe1pCQkwPPjO0buETRRr0CC9j9KMOdGq2ajbFFEFxqaUT8Ct X-Developer-Key: i=asrivats@redhat.com; a=ed25519; pk=brnIHkBsUZEhyW6Zyn0U92AeIZ1psws/q8VFbIkf1AU= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Update the Documentation to be more precise. v2: Update for clarity v3: Further details in Todo Cc: Thomas Zimmermann Signed-off-by: Anusha Srivatsa Acked-by: Thomas Zimmermann --- Documentation/gpu/todo.rst | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 256d0d1cb2164bd94f9b610a751b907834d96a21..c57777a24e03d91b1ffe04365f7= 356f2d938befd 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -441,14 +441,15 @@ Contact: Thomas Zimmermann =20 Level: Intermediate =20 -Request memory regions in all drivers -------------------------------------- +Request memory regions in all fbdev drivers +-------------------------------------------- =20 -Go through all drivers and add code to request the memory regions that the -driver uses. This requires adding calls to request_mem_region(), +Old/ancient fbdev drivers do not request their memory properly. +Go through these drivers and add code to request the memory regions +that the driver uses. This requires adding calls to request_mem_region(), pci_request_region() or similar functions. Use helpers for managed cleanup -where possible. - +where possible. Problematic areas include hardware that has exclusive rang= es +like VGA. VGA16fb does not request the range as it is expected. Drivers are pretty bad at doing this and there used to be conflicts among DRM and fbdev drivers. Still, it's the correct thing to do. =20 --=20 2.48.1