From nobody Sun Feb 8 06:54:38 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FDDB214A78 for ; Mon, 3 Mar 2025 14:39:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012786; cv=none; b=YPzXonI/XvoOOjiNAwx/TkXdzz4MJKLZqCxXSa4Tj4zk02wFzIqdcPhH4vf1beQ/tvA/YeW2XJjZQei1lOdWswPGhOPSFpFFFZvXvgby7CE76/q56v4PwoybvJBecpzlxDNPEbf3RkyRI76wfHw2UWKxhwk0gJXGpUinXyj577s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012786; c=relaxed/simple; bh=bDltFn72XGX7/YGKM/jJc61Zk89Uap7Gcrzn0no2Mj0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FC7/5WbnwkIZ79+NYZo0uuOS0mvK2/JTyPkczamXGqbUAc1LS2+r1l/ABWBzc0KT46pVjb9MQtGWdmfY2uY7p+FiWh+6xAv0wE4AWL9kQ3cUh5DiZXm+kwrBs6PhLvHfr3inxF286G+f7M3++9UvO+2GgXjyu+6wDLu+z0h4ihE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=LaFLFzVF; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="LaFLFzVF" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=NCcGpHSW32vENYyHk+1Go1rb3MBFVM15qU2VwPxGLTQ=; b=LaFLFzVFca63tNHt MFHhSQTdHARen5gH5yOeqOLa3VG6YqaBHlCXpqlPLlpoxWXOSIn8kbhLof3VXLRZvdmv+8gQyk4rm 8Cc6AoVCi442tCpUZDIaJYcRReofzgvKEJUPyOL84WCBPmzUGmac9QPMCKp5tiiw87PmNiXtZ/J65 AYiuxY5I5LdHPZmDoUTtaIplSoP9xF5ToT7bZHRYsXIqC1XHTnW3eFgADE9VLPx6ODx+CLZ9jldM1 QhT3LP6VBaYQcPqsXL2kjaqpF4E1dt6tiZikN4RcJ3XEgZFdFwBdY/CSI4sSzTMbRSBsBJLERL68b +nunWdvbPnbLp6Px9g==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tp6x2-0028PG-19; Mon, 03 Mar 2025 14:39:24 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, Felix.Kuehling@amd.com, christian.koenig@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, austin.zheng@amd.com, jun.lei@amd.com, kenneth.feng@amd.com, linux-kernel@vger.kernel.org Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "Dr. David Alan Gilbert" Subject: [PATCH 1/6] drm/amdgpu: Remove ppatomfwctrl deadcode Date: Mon, 3 Mar 2025 14:39:17 +0000 Message-ID: <20250303143922.36342-2-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250303143922.36342-1-linux@treblig.org> References: <20250303143922.36342-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" pp_atomfwctrl_get_pp_assign_pin() and pp_atomfwctrl_get_pp_assign_pin() were added in 2017 by commit 0d2c7569e196 ("drm/amdgpu: add new atomfirmware based helpers for powerplay") but have remained unused. Remove them, and the helper functions they used. Signed-off-by: Dr. David Alan Gilbert --- .../drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c | 78 ------------------- .../drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.h | 3 - 2 files changed, 81 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c b/driver= s/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c index 82d540334318..6120f14caab0 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.c @@ -158,84 +158,6 @@ int pp_atomfwctrl_get_voltage_table_v4(struct pp_hwmgr= *hwmgr, return result; } =20 -=20 -static struct atom_gpio_pin_lut_v2_1 *pp_atomfwctrl_get_gpio_lookup_table( - struct pp_hwmgr *hwmgr) -{ - const void *table_address; - uint16_t idx; - - idx =3D GetIndexIntoMasterDataTable(gpio_pin_lut); - table_address =3D smu_atom_get_data_table(hwmgr->adev, - idx, NULL, NULL, NULL); - PP_ASSERT_WITH_CODE(table_address, - "Error retrieving BIOS Table Address!", - return NULL); - - return (struct atom_gpio_pin_lut_v2_1 *)table_address; -} - -static bool pp_atomfwctrl_lookup_gpio_pin( - struct atom_gpio_pin_lut_v2_1 *gpio_lookup_table, - const uint32_t pin_id, - struct pp_atomfwctrl_gpio_pin_assignment *gpio_pin_assignment) -{ - unsigned int size =3D le16_to_cpu( - gpio_lookup_table->table_header.structuresize); - unsigned int offset =3D - offsetof(struct atom_gpio_pin_lut_v2_1, gpio_pin[0]); - unsigned long start =3D (unsigned long)gpio_lookup_table; - - while (offset < size) { - const struct atom_gpio_pin_assignment *pin_assignment =3D - (const struct atom_gpio_pin_assignment *)(start + offset); - - if (pin_id =3D=3D pin_assignment->gpio_id) { - gpio_pin_assignment->uc_gpio_pin_bit_shift =3D - pin_assignment->gpio_bitshift; - gpio_pin_assignment->us_gpio_pin_aindex =3D - le16_to_cpu(pin_assignment->data_a_reg_index); - return true; - } - offset +=3D offsetof(struct atom_gpio_pin_assignment, gpio_id) + 1; - } - return false; -} - -/* - * Returns TRUE if the given pin id find in lookup table. - */ -bool pp_atomfwctrl_get_pp_assign_pin(struct pp_hwmgr *hwmgr, - const uint32_t pin_id, - struct pp_atomfwctrl_gpio_pin_assignment *gpio_pin_assignment) -{ - bool ret =3D false; - struct atom_gpio_pin_lut_v2_1 *gpio_lookup_table =3D - pp_atomfwctrl_get_gpio_lookup_table(hwmgr); - - /* If we cannot find the table do NOT try to control this voltage. */ - PP_ASSERT_WITH_CODE(gpio_lookup_table, - "Could not find GPIO lookup Table in BIOS.", - return false); - - ret =3D pp_atomfwctrl_lookup_gpio_pin(gpio_lookup_table, - pin_id, gpio_pin_assignment); - - return ret; -} - -/* - * Enter to SelfRefresh mode. - * @param hwmgr - */ -int pp_atomfwctrl_enter_self_refresh(struct pp_hwmgr *hwmgr) -{ - /* 0 - no action - * 1 - leave power to video memory always on - */ - return 0; -} - /** pp_atomfwctrl_get_gpu_pll_dividers_vega10(). * * @param hwmgr input parameter: pointer to HwMgr diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.h b/driver= s/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.h index e86e05c786d9..0d62903d5676 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.h +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.h @@ -217,9 +217,6 @@ struct pp_atomfwctrl_smc_dpm_parameters { int pp_atomfwctrl_get_gpu_pll_dividers_vega10(struct pp_hwmgr *hwmgr, uint32_t clock_type, uint32_t clock_value, struct pp_atomfwctrl_clock_dividers_soc15 *dividers); -int pp_atomfwctrl_enter_self_refresh(struct pp_hwmgr *hwmgr); -bool pp_atomfwctrl_get_pp_assign_pin(struct pp_hwmgr *hwmgr, const uint32_= t pin_id, - struct pp_atomfwctrl_gpio_pin_assignment *gpio_pin_assignment); =20 int pp_atomfwctrl_get_voltage_table_v4(struct pp_hwmgr *hwmgr, uint8_t vol= tage_type, uint8_t voltage_mode, struct pp_atomfwctrl_voltage_table *voltage_table); --=20 2.48.1 From nobody Sun Feb 8 06:54:38 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D73E812FF69 for ; Mon, 3 Mar 2025 14:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012771; cv=none; b=MmeKWoYhOBiBFmiJy0B0goqn8DssuYnw9ybn/SyXbeT6DYHH0dzMx8nq/8bnQqW5X703aQvZhkBkdmfT6qNr7yepRj4XY/vgCffDxJwio4xke9/esKajY1aIU+K/g9TCmLllHmqmGshpRT14j2P3VYQDUJVOX7VuMgBlKLXhbYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012771; c=relaxed/simple; bh=wuCxEcHiHWMbshLJqy+PE4V7Hlt/Y9N7pXTFmE39aXE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EY1j/dZx2P67WaWJ7EPT6t2nI9v892boIutnmNogFEqCwdgoPt8f+3CVK1/KAq93RiCjZ8C1Bo/ngb1HvwEa4JJu+iLv1VFvQDKQom4ltcPpGk+zQxnO6zCbHLKK0jmagc9p74/z/u2+0zuKEO8vom/M4JkTYPqjzi54uLf0xr0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=ljOeIPFo; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="ljOeIPFo" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=zcWTq0+tIXCR7i1Bn8SpUwbeuy7hHsMrsLtvUfkNYic=; b=ljOeIPFoWhayaeSJ rHzpOtXpgkuRPEiKmG2zVC85wjomyNbcZ6lGe2Luo+7Vs5YvEcwxRqVn3fNs+ZJ048QDCVk7+g22f bvlZCLpvIaz19Atyeix5qtly+EMyojwJOzjHhe+gzVPNPPsvK3w7QHwE0c/fBu3Q7iwYLIQXVWp7z 0KLfyg1j5o6Zrt1p5GBJ0r3x76+D/r8wRSWGJEZFaRSYxtcvVtMIm7U3RTwtDeGnYaEQUEf6PbpVe g7LjIQQ1uvnHNRfpSwXhfbs1Gx+Q/yGZoHUrxFdF7/tRdKv2nQzRpBPxp2r0cnn70NqZvnWLo0vjE rNw364LqKRK1RqZdlA==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tp6x3-0028PG-0W; Mon, 03 Mar 2025 14:39:25 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, Felix.Kuehling@amd.com, christian.koenig@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, austin.zheng@amd.com, jun.lei@amd.com, kenneth.feng@amd.com, linux-kernel@vger.kernel.org Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "Dr. David Alan Gilbert" Subject: [PATCH 2/6] drm/amdgpu: Remove phm_powerdown_uvd Date: Mon, 3 Mar 2025 14:39:18 +0000 Message-ID: <20250303143922.36342-3-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250303143922.36342-1-linux@treblig.org> References: <20250303143922.36342-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" phm_powerdown_uvd() has been unused since 2017's commit 47047263c527 ("drm/amd/powerplay: delete eventmgr related files.") Remove it. Signed-off-by: Dr. David Alan Gilbert --- .../gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c | 10 ---------- drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h | 1 - 2 files changed, 11 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c b/dri= vers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c index 90452b66e107..a59677cf8dfc 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c @@ -149,16 +149,6 @@ int phm_apply_clock_adjust_rules(struct pp_hwmgr *hwmg= r) return 0; } =20 -int phm_powerdown_uvd(struct pp_hwmgr *hwmgr) -{ - PHM_FUNC_CHECK(hwmgr); - - if (hwmgr->hwmgr_func->powerdown_uvd !=3D NULL) - return hwmgr->hwmgr_func->powerdown_uvd(hwmgr); - return 0; -} - - int phm_disable_clock_power_gatings(struct pp_hwmgr *hwmgr) { PHM_FUNC_CHECK(hwmgr); diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h b/drive= rs/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h index f4f9a104d170..915f1b8e4dba 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h +++ b/drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h @@ -396,7 +396,6 @@ struct phm_odn_clock_levels { }; =20 extern int phm_disable_clock_power_gatings(struct pp_hwmgr *hwmgr); -extern int phm_powerdown_uvd(struct pp_hwmgr *hwmgr); extern int phm_setup_asic(struct pp_hwmgr *hwmgr); extern int phm_enable_dynamic_state_management(struct pp_hwmgr *hwmgr); extern int phm_disable_dynamic_state_management(struct pp_hwmgr *hwmgr); --=20 2.48.1 From nobody Sun Feb 8 06:54:38 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D745C212D66 for ; Mon, 3 Mar 2025 14:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012772; cv=none; b=NzD4D3nGFQZcmW0ij3RVqnuh/JzbN/x//gdVKw5z6NAOPpOo0kcE25IsHJQs+gyXKMuFDi7hJcNBOkc/tKAW6YPzZgbXVuBQS3tT4uPxbf68TaZnCUepq8QJK2lwboP0eAJeMPsdyW8ILfflP4tsDCw/zqSMBql41iF8vu5MicI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012772; c=relaxed/simple; bh=5mpCI9pZ8PWgc2rvH58GV05R+qnTGASobuPPyYIZp/M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R2bIp9PpDNnde/aGkdw101xPXHsiJOYV5JWkv/CtVNrQA9wBWoiTm2mvf43Xree1Bofuambsxa4H5wdWt4uVSwPbpCuA3KxJuxpiPTJuoPvHsCs0Wn6u2cHQlXyH7DzpGLdw4FcY4mUZtVY+EsJr/h4e0U39qu110wF8aBA3cA4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=DXWP884M; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="DXWP884M" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=qbdK8IAgZW0guOrlqWaSI9e2yk+YFc7AzO9kJtOtkKA=; b=DXWP884ME7zSWaQT ibmvA8hYDJxaTuupNJ+p4U6szKySOsv8IY/tLkUC4NNAfnnlS4DUfv0kUo5/57G6BKSF9h27c+6Ba zALa8HLisBxxoUUCVHJiOr4Wn9q6kOBqXvVdYfL1vUXOjSk7cRPm8vHN08kc10v9trS5EK+O7H8pA VrquZOAwMigcKYPosfSojg1jOiEboldREKyzyg0kxRvFZh/boRUhmyxtjP5Iu8XyxLCqm1xhKShKh tMVZX66rSSjbu2I0tYbIiHFsmsknRGJPsWeuWpn3GHEyrkuh7+uqB2td31hxiQwnVrGRWVx31rUHZ KKV2UOusAKJJWobVEw==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tp6x3-0028PG-3C; Mon, 03 Mar 2025 14:39:26 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, Felix.Kuehling@amd.com, christian.koenig@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, austin.zheng@amd.com, jun.lei@amd.com, kenneth.feng@amd.com, linux-kernel@vger.kernel.org Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "Dr. David Alan Gilbert" Subject: [PATCH 3/6] drm/amdgpu: Remove powerdown_uvd member Date: Mon, 3 Mar 2025 14:39:19 +0000 Message-ID: <20250303143922.36342-4-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250303143922.36342-1-linux@treblig.org> References: <20250303143922.36342-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" With phm_powerdown_uvd() gone in the previous patch, there's now no longer anything that reads the powerdown_uvd member of the pp_hwmgr_func. Remove it. There are a few assignments to it; a boring NULL which can just go, and two functions, but those functions are called explicitly anyway so the assignments to the member go. One of those (smu7_powerdown_uvd) wasn't static previously; make it static. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 1 - drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.h | 1 - drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 1 - drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu8_hwmgr.c | 1 - drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 1 - 6 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c b/drivers= /gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c index a8c732e07006..9a821563bc8e 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c @@ -1642,7 +1642,6 @@ static const struct pp_hwmgr_func smu10_hwmgr_funcs = =3D { .apply_state_adjust_rules =3D smu10_apply_state_adjust_rules, .force_dpm_level =3D smu10_dpm_force_dpm_level, .get_power_state_size =3D smu10_get_power_state_size, - .powerdown_uvd =3D NULL, .powergate_uvd =3D smu10_powergate_vcn, .powergate_vce =3D NULL, .get_mclk =3D smu10_dpm_get_mclk, diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.c= b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.c index f2bda3bcbbde..5e4c80f7b20a 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.c @@ -55,7 +55,7 @@ static int smu7_update_vce_dpm(struct pp_hwmgr *hwmgr, bo= ol bgate) return smu7_enable_disable_vce_dpm(hwmgr, !bgate); } =20 -int smu7_powerdown_uvd(struct pp_hwmgr *hwmgr) +static int smu7_powerdown_uvd(struct pp_hwmgr *hwmgr) { if (phm_cf_want_uvd_power_gating(hwmgr)) return smum_send_msg_to_smc(hwmgr, diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.h= b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.h index fc8f8a6acc72..e56abbadc78b 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.h +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_clockpowergating.h @@ -28,7 +28,6 @@ =20 void smu7_powergate_vce(struct pp_hwmgr *hwmgr, bool bgate); void smu7_powergate_uvd(struct pp_hwmgr *hwmgr, bool bgate); -int smu7_powerdown_uvd(struct pp_hwmgr *hwmgr); int smu7_powergate_acp(struct pp_hwmgr *hwmgr, bool bgate); int smu7_disable_clock_power_gating(struct pp_hwmgr *hwmgr); int smu7_update_clock_gatings(struct pp_hwmgr *hwmgr, diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c b/drivers/= gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c index 632a25957477..8da882c51856 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c @@ -5754,7 +5754,6 @@ static const struct pp_hwmgr_func smu7_hwmgr_funcs = =3D { .patch_boot_state =3D smu7_dpm_patch_boot_state, .get_pp_table_entry =3D smu7_get_pp_table_entry, .get_num_of_pp_table_entries =3D smu7_get_number_of_powerplay_table_entri= es, - .powerdown_uvd =3D smu7_powerdown_uvd, .powergate_uvd =3D smu7_powergate_uvd, .powergate_vce =3D smu7_powergate_vce, .disable_clock_power_gating =3D smu7_disable_clock_power_gating, diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu8_hwmgr.c b/drivers/= gpu/drm/amd/pm/powerplay/hwmgr/smu8_hwmgr.c index 7e1197420873..9d3b33446adc 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu8_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu8_hwmgr.c @@ -2044,7 +2044,6 @@ static const struct pp_hwmgr_func smu8_hwmgr_funcs = =3D { .apply_state_adjust_rules =3D smu8_apply_state_adjust_rules, .force_dpm_level =3D smu8_dpm_force_dpm_level, .get_power_state_size =3D smu8_get_power_state_size, - .powerdown_uvd =3D smu8_dpm_powerdown_uvd, .powergate_uvd =3D smu8_dpm_powergate_uvd, .powergate_vce =3D smu8_dpm_powergate_vce, .powergate_acp =3D smu8_dpm_powergate_acp, diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h b/drivers/gpu/drm= /amd/pm/powerplay/inc/hwmgr.h index 227bf0e84a13..c661185753b4 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h +++ b/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h @@ -257,7 +257,6 @@ struct pp_hwmgr_func { int (*get_pp_table_entry)(struct pp_hwmgr *hwmgr, unsigned long, struct pp_power_state *); int (*get_num_of_pp_table_entries)(struct pp_hwmgr *hwmgr); - int (*powerdown_uvd)(struct pp_hwmgr *hwmgr); void (*powergate_vce)(struct pp_hwmgr *hwmgr, bool bgate); void (*powergate_uvd)(struct pp_hwmgr *hwmgr, bool bgate); void (*powergate_acp)(struct pp_hwmgr *hwmgr, bool bgate); --=20 2.48.1 From nobody Sun Feb 8 06:54:38 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846572139DB for ; Mon, 3 Mar 2025 14:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012774; cv=none; b=YhBiMfWPMJXzgp8eHiB1pPrqQtWo1kSg0Np74IcrVK8FPJENos9/dksF3uYUwUq1BdlHF4MiK1Ahy+lZjiA71koeJwIJ4szQYES8XMN9qL4PwP6DDY2PED5ZYinJ4jSAtoYorziyPI9Q32PHzxP5RkbD5oeeqZLp7AzzO66u8OQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012774; c=relaxed/simple; bh=fIfj58Ul8EwY9c+AHQLHHbF/BQwHxUja+x8dJWwhoX4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ROh34dPVUtS6NUSBagh1buy67w0tqDtvJDWOKuQwTOaJCE5xGrWu4NcGwRETZ/dEDF3qYMAk5EVebQQEI0VfoMYOiGt54CdcXv2ktCpMMZzJPw1bEUqsoBnzDHsgjPVFhkGccfietAlMRcN+CDuGWJGsG9iPMheKrEd6YGhIH+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=K6sirqud; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="K6sirqud" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=Cdlfgnw8G3+c2z4nhjgVDSllq75qCcu4juCsqIjCRVU=; b=K6sirqudCWNyvGUV /HTVqPM3WYWKlwJk6yB1/38dSP70Im0Cm/yvMBZwLWIL/eYN48TVSc26B6c8i15hLfJ8OtvFou7KL JIctFSYAvAAakwQmItCIQjHAo4RElyzFmj493wDm89Bg5mPU+Q2oyCqJc5jLYf5+2RA9TV4lGHuyl GX4Uop2w1DjcNh1vyjrWbukIHUMYPeuA7LNh+LVhm20X/KiQ6lqBhx/8t3VF6EOIMuLJZvqneXfqm yEH7tOknyWujF3edoOtlVCgyQBU5Io+0s2PW7MKmCQ/4FB2F2Spuz0kuIXGHulBLTTwyKdAPo6v4i yL88hIl2jwOYzNqgsg==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tp6x4-0028PG-2R; Mon, 03 Mar 2025 14:39:26 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, Felix.Kuehling@amd.com, christian.koenig@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, austin.zheng@amd.com, jun.lei@amd.com, kenneth.feng@amd.com, linux-kernel@vger.kernel.org Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "Dr. David Alan Gilbert" Subject: [PATCH 4/6] drm/amdgpu: Remove unused pre_surface_trace Date: Mon, 3 Mar 2025 14:39:20 +0000 Message-ID: <20250303143922.36342-5-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250303143922.36342-1-linux@treblig.org> References: <20250303143922.36342-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" pre_surface_trace() has been unused since 2017's commit 745cc746da42 ("drm/amd/display: remove dc_pre_update_surfaces_to_stream from dc use") Remove it. Signed-off-by: Dr. David Alan Gilbert --- .../gpu/drm/amd/display/dc/core/dc_debug.c | 120 ------------------ .../amd/display/include/logger_interface.h | 5 - 2 files changed, 125 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_debug.c b/drivers/gpu/d= rm/amd/display/dc/core/dc_debug.c index af1ea5792560..650e89825968 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_debug.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_debug.c @@ -51,126 +51,6 @@ DC_LOG_BANDWIDTH_CALCS(__VA_ARGS__); \ } while (0) =20 -void pre_surface_trace( - struct dc *dc, - const struct dc_plane_state *const *plane_states, - int surface_count) -{ - int i; - DC_LOGGER_INIT(dc->ctx->logger); - - for (i =3D 0; i < surface_count; i++) { - const struct dc_plane_state *plane_state =3D plane_states[i]; - - SURFACE_TRACE("Planes %d:\n", i); - - SURFACE_TRACE( - "plane_state->visible =3D %d;\n" - "plane_state->flip_immediate =3D %d;\n" - "plane_state->address.type =3D %d;\n" - "plane_state->address.grph.addr.quad_part =3D 0x%llX;\n" - "plane_state->address.grph.meta_addr.quad_part =3D 0x%llX;\n" - "plane_state->scaling_quality.h_taps =3D %d;\n" - "plane_state->scaling_quality.v_taps =3D %d;\n" - "plane_state->scaling_quality.h_taps_c =3D %d;\n" - "plane_state->scaling_quality.v_taps_c =3D %d;\n", - plane_state->visible, - plane_state->flip_immediate, - plane_state->address.type, - plane_state->address.grph.addr.quad_part, - plane_state->address.grph.meta_addr.quad_part, - plane_state->scaling_quality.h_taps, - plane_state->scaling_quality.v_taps, - plane_state->scaling_quality.h_taps_c, - plane_state->scaling_quality.v_taps_c); - - SURFACE_TRACE( - "plane_state->src_rect.x =3D %d;\n" - "plane_state->src_rect.y =3D %d;\n" - "plane_state->src_rect.width =3D %d;\n" - "plane_state->src_rect.height =3D %d;\n" - "plane_state->dst_rect.x =3D %d;\n" - "plane_state->dst_rect.y =3D %d;\n" - "plane_state->dst_rect.width =3D %d;\n" - "plane_state->dst_rect.height =3D %d;\n" - "plane_state->clip_rect.x =3D %d;\n" - "plane_state->clip_rect.y =3D %d;\n" - "plane_state->clip_rect.width =3D %d;\n" - "plane_state->clip_rect.height =3D %d;\n", - plane_state->src_rect.x, - plane_state->src_rect.y, - plane_state->src_rect.width, - plane_state->src_rect.height, - plane_state->dst_rect.x, - plane_state->dst_rect.y, - plane_state->dst_rect.width, - plane_state->dst_rect.height, - plane_state->clip_rect.x, - plane_state->clip_rect.y, - plane_state->clip_rect.width, - plane_state->clip_rect.height); - - SURFACE_TRACE( - "plane_state->plane_size.surface_size.x =3D %d;\n" - "plane_state->plane_size.surface_size.y =3D %d;\n" - "plane_state->plane_size.surface_size.width =3D %d;\n" - "plane_state->plane_size.surface_size.height =3D %d;\n" - "plane_state->plane_size.surface_pitch =3D %d;\n", - plane_state->plane_size.surface_size.x, - plane_state->plane_size.surface_size.y, - plane_state->plane_size.surface_size.width, - plane_state->plane_size.surface_size.height, - plane_state->plane_size.surface_pitch); - - - SURFACE_TRACE( - "plane_state->tiling_info.gfx8.num_banks =3D %d;\n" - "plane_state->tiling_info.gfx8.bank_width =3D %d;\n" - "plane_state->tiling_info.gfx8.bank_width_c =3D %d;\n" - "plane_state->tiling_info.gfx8.bank_height =3D %d;\n" - "plane_state->tiling_info.gfx8.bank_height_c =3D %d;\n" - "plane_state->tiling_info.gfx8.tile_aspect =3D %d;\n" - "plane_state->tiling_info.gfx8.tile_aspect_c =3D %d;\n" - "plane_state->tiling_info.gfx8.tile_split =3D %d;\n" - "plane_state->tiling_info.gfx8.tile_split_c =3D %d;\n" - "plane_state->tiling_info.gfx8.tile_mode =3D %d;\n" - "plane_state->tiling_info.gfx8.tile_mode_c =3D %d;\n", - plane_state->tiling_info.gfx8.num_banks, - plane_state->tiling_info.gfx8.bank_width, - plane_state->tiling_info.gfx8.bank_width_c, - plane_state->tiling_info.gfx8.bank_height, - plane_state->tiling_info.gfx8.bank_height_c, - plane_state->tiling_info.gfx8.tile_aspect, - plane_state->tiling_info.gfx8.tile_aspect_c, - plane_state->tiling_info.gfx8.tile_split, - plane_state->tiling_info.gfx8.tile_split_c, - plane_state->tiling_info.gfx8.tile_mode, - plane_state->tiling_info.gfx8.tile_mode_c); - - SURFACE_TRACE( - "plane_state->tiling_info.gfx8.pipe_config =3D %d;\n" - "plane_state->tiling_info.gfx8.array_mode =3D %d;\n" - "plane_state->color_space =3D %d;\n" - "plane_state->dcc.enable =3D %d;\n" - "plane_state->format =3D %d;\n" - "plane_state->rotation =3D %d;\n" - "plane_state->stereo_format =3D %d;\n", - plane_state->tiling_info.gfx8.pipe_config, - plane_state->tiling_info.gfx8.array_mode, - plane_state->color_space, - plane_state->dcc.enable, - plane_state->format, - plane_state->rotation, - plane_state->stereo_format); - - SURFACE_TRACE("plane_state->tiling_info.gfx9.swizzle =3D %d;\n", - plane_state->tiling_info.gfx9.swizzle); - - SURFACE_TRACE("\n"); - } - SURFACE_TRACE("\n"); -} - void update_surface_trace( struct dc *dc, const struct dc_surface_update *updates, diff --git a/drivers/gpu/drm/amd/display/include/logger_interface.h b/drive= rs/gpu/drm/amd/display/include/logger_interface.h index 058f882d5bdd..4c01514b926c 100644 --- a/drivers/gpu/drm/amd/display/include/logger_interface.h +++ b/drivers/gpu/drm/amd/display/include/logger_interface.h @@ -40,11 +40,6 @@ struct dc_state; * */ =20 -void pre_surface_trace( - struct dc *dc, - const struct dc_plane_state *const *plane_states, - int surface_count); - void update_surface_trace( struct dc *dc, const struct dc_surface_update *updates, --=20 2.48.1 From nobody Sun Feb 8 06:54:38 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF1731FAC4D for ; Mon, 3 Mar 2025 14:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012772; cv=none; b=ss0yK/wys7cgYlgZQmGF5fwa2n80lVrx3+GXPmSEdhra6oekuKdGO3GMUDOZcxiQCNWqePBca6XX2Mlqpj/vpHC+5gfSPFTVl+fN79cxEkiEmaZVXwyPdIPFxPo1kCkKHRXwzkWK6Qtc6F1pBBht7+FR8KUyZVF56sTfuARn09U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012772; c=relaxed/simple; bh=lAs3NA0uKrcszg6+DqY96fPmkb6rDQ24C4lgsIDav1M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oFVtUt4mjfDI96TPGrR2zE9A5RSYGavhXh6yG4RxrtWrfDlosTp8/OXxKWla7A1yn1amLnBclaBQW6ArnEuwxNXJQ9wHM61gcuVZphj9LmWy3o+rwtMCj0uMQvgTcdqouljbOavrXcnRviT4Jbp4H+xeBka9I2tEZHK02d+qaM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=rlZZuBnk; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="rlZZuBnk" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=txe/FCPWRDijIRM2J14dylswI3oOXHv8ky3SGbNbIgE=; b=rlZZuBnkzyt7ZRBK UJhcYmaIGcN34uExHJWZiEVDTy9IHDpVje+oEdAM8PhH79alsdHMRT+fVVpuaIE6DLYc5Sfjvm1kF 4KnE766bfqoojTDSnSvfGxO3PvF9m81LqFUhnC0MzyJ5Nr4Jvz1zLkpDqlQD8siA2+MQ6GDv7t7gF weVDLqeVVmJ81AHpd+7B6nWuCReFEqgHK3VMuqtya3eXvRUmQojn2mqc8NNe8lg+SpBc1WsYkdL35 ZnJLQcs8xYs9yYmVpxqj2tGOl5axCuxNh78fHJc5OEw4nyaZBpVGMEjNkOghGporvJ5NTH9uxq5VD O6QuHGamPTtU2PirEg==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tp6x5-0028PG-1c; Mon, 03 Mar 2025 14:39:27 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, Felix.Kuehling@amd.com, christian.koenig@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, austin.zheng@amd.com, jun.lei@amd.com, kenneth.feng@amd.com, linux-kernel@vger.kernel.org Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "Dr. David Alan Gilbert" Subject: [PATCH 5/6] drm/amdgpu: Remove unused print__rq_dlg_params_st Date: Mon, 3 Mar 2025 14:39:21 +0000 Message-ID: <20250303143922.36342-6-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250303143922.36342-1-linux@treblig.org> References: <20250303143922.36342-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" print__rq_dlg_params_st() was added in 2017 by commit 061bfa06a42a ("drm/amdgpu/display: Add dml support for DCN") but has remained unused. Remove it. Signed-off-by: Dr. David Alan Gilbert --- .../drm/amd/display/dc/dml/display_rq_dlg_helpers.c | 11 ----------- .../drm/amd/display/dc/dml/display_rq_dlg_helpers.h | 1 - 2 files changed, 12 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_helpers.c b/= drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_helpers.c index 412e75eb4704..12ff65b6a7e5 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_helpers.c +++ b/drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_helpers.c @@ -122,17 +122,6 @@ void print__data_rq_misc_params_st(struct display_mode= _lib *mode_lib, const stru dml_print("DML_RQ_DLG_CALC: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); } =20 -void print__rq_dlg_params_st(struct display_mode_lib *mode_lib, const stru= ct _vcs_dpi_display_rq_dlg_params_st *rq_dlg_param) -{ - dml_print("DML_RQ_DLG_CALC: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); - dml_print("DML_RQ_DLG_CALC: DISPLAY_RQ_DLG_PARAM_ST\n"); - dml_print("DML_RQ_DLG_CALC: \n"); - print__data_rq_dlg_params_st(mode_lib, &rq_dlg_param->rq_l); - dml_print("DML_RQ_DLG_CALC: \n"); - print__data_rq_dlg_params_st(mode_lib, &rq_dlg_param->rq_c); - dml_print("DML_RQ_DLG_CALC: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); -} - void print__dlg_sys_params_st(struct display_mode_lib *mode_lib, const str= uct _vcs_dpi_display_dlg_sys_params_st *dlg_sys_param) { dml_print("DML_RQ_DLG_CALC: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_helpers.h b/= drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_helpers.h index ebcd717744e5..2bc64c4081dc 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_helpers.h +++ b/drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_helpers.h @@ -35,7 +35,6 @@ void print__rq_params_st(struct display_mode_lib *mode_li= b, const struct _vcs_dp void print__data_rq_sizing_params_st(struct display_mode_lib *mode_lib, co= nst struct _vcs_dpi_display_data_rq_sizing_params_st *rq_sizing); void print__data_rq_dlg_params_st(struct display_mode_lib *mode_lib, const= struct _vcs_dpi_display_data_rq_dlg_params_st *rq_dlg_param); void print__data_rq_misc_params_st(struct display_mode_lib *mode_lib, cons= t struct _vcs_dpi_display_data_rq_misc_params_st *rq_misc_param); -void print__rq_dlg_params_st(struct display_mode_lib *mode_lib, const stru= ct _vcs_dpi_display_rq_dlg_params_st *rq_dlg_param); void print__dlg_sys_params_st(struct display_mode_lib *mode_lib, const str= uct _vcs_dpi_display_dlg_sys_params_st *dlg_sys_param); =20 void print__data_rq_regs_st(struct display_mode_lib *mode_lib, const struc= t _vcs_dpi_display_data_rq_regs_st *rq_regs); --=20 2.48.1 From nobody Sun Feb 8 06:54:38 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846B92139DC for ; Mon, 3 Mar 2025 14:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012774; cv=none; b=NYZYGeqMPVQhNf39vKbrNWd4gAJBfA0ICCgGLwFpaZ3lFiDTups0BxpO4MyODW/d6ItE4KFN8MAgfxADRZQNpqLluO8tZDiS+LP0oHBaYHlDUD8EHf9343ejqTwDZKALd3OXAkOj1Uy+CK7KKegwhjn2cEn2a9k5gU2puoFYlis= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741012774; c=relaxed/simple; bh=Oo9bx0i6Wcsv6riylCg9LyziEli1nqxqvY5u016eLrg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W8LSPO8VdQLLrZbSPzDEAh0qGCludGZBWjcAQn1CvjVEQcZqqrsNl57d6iZNryA4eSS/6N2B//3mz7fP1KNa8NdVu3aYHyBIiiDyJF0D6OQDHf+8s7rRlTKj293q8vLgJkzMI9aFLcaeS5NxuARpK042Zc7aiamJSQZo6hzg28E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=Vawew98O; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="Vawew98O" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=om6Pe7ZZ4TBnXEpqWdlBwdRqDe/1mArlAqj9LsmmXJo=; b=Vawew98OoN6iqkCZ 3SymbqPYpKg9wEpCizX63v5Jpc1MWJgAKrKvvBcrG9/LDsQB+zMiF+7jJrolzuCoYimZ29qwK24DK SUzGbFgyEW/fZBmOXt881aEN1Y04Nxk7XdTMzb48hjbzWQOzrSVjtILKDVfQ2yftTk1ZRC/79eb8V BHqRigfOfBQ8f9bWEsNFJzRuCulRHUwkkeB0nFH9jBZeb6AvMIm1v/uYqNpCCYL2ctZgDucWgUgVD WGd3vdOV163eoWsY5lxSA7zqx2i29qH/fdJCmQA4DJIn1SeuvbWH9DH+yUjIZmEJI99Iq1u/EkiXR LfnhT+1PScUJxL0RVQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tp6x6-0028PG-0i; Mon, 03 Mar 2025 14:39:28 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, Felix.Kuehling@amd.com, christian.koenig@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, austin.zheng@amd.com, jun.lei@amd.com, kenneth.feng@amd.com, linux-kernel@vger.kernel.org Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "Dr. David Alan Gilbert" Subject: [PATCH 6/6] drm/amdgpu: Remove unused pqm_get_kernel_queue Date: Mon, 3 Mar 2025 14:39:22 +0000 Message-ID: <20250303143922.36342-7-linux@treblig.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250303143922.36342-1-linux@treblig.org> References: <20250303143922.36342-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" pqm_get_kernel_queue() has been unused since 2022's commit 5bdd3eb25354 ("drm/amdkfd: Remove unused old debugger implementation") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 -- .../gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 13 ------------- 2 files changed, 15 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/am= dkfd/kfd_priv.h index 2c22e335a02e..bc26a2609f64 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h +++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h @@ -1363,8 +1363,6 @@ int pqm_update_mqd(struct process_queue_manager *pqm,= unsigned int qid, struct mqd_update_info *minfo); int pqm_set_gws(struct process_queue_manager *pqm, unsigned int qid, void *gws); -struct kernel_queue *pqm_get_kernel_queue(struct process_queue_manager *pq= m, - unsigned int qid); struct queue *pqm_get_user_queue(struct process_queue_manager *pqm, unsigned int qid); int pqm_get_wave_state(struct process_queue_manager *pqm, diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drive= rs/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c index bd36a75309e1..2b30ed0cecb6 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c @@ -652,19 +652,6 @@ int pqm_update_mqd(struct process_queue_manager *pqm, return 0; } =20 -struct kernel_queue *pqm_get_kernel_queue( - struct process_queue_manager *pqm, - unsigned int qid) -{ - struct process_queue_node *pqn; - - pqn =3D get_queue_by_qid(pqm, qid); - if (pqn && pqn->kq) - return pqn->kq; - - return NULL; -} - struct queue *pqm_get_user_queue(struct process_queue_manager *pqm, unsigned int qid) { --=20 2.48.1