From nobody Sun Feb 8 14:22:28 2026 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D0BF1F4167; Mon, 3 Mar 2025 14:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741010576; cv=none; b=ocSCzbdzChZFOjmwAzWMUEbbIJvE76tKUKqNp4ssxEiOGIemvQ/CeEBqIPVUIypx/VP7zMOUXxeiN3LVNAo+Qx9iZ82Mo8dI6IQ63VZ6P5al8qedhl+3kQShBFRF843DlRwAoHjklQ4cBDFfCVfb+5xyU2csXteWmMJbY6fmo04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741010576; c=relaxed/simple; bh=un//m18e0EyZu6pJVZ/eIwmeKA7wLXFC7L5MaYP//fo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=dqG/N64ukZ7Mt8pQsyOjVoMm6sPa7UzB7BwfL2HiVUZaJ0CSJwOJHPmACnAIZpx1aul4TirJugN2bGd2WiY9OYIW2v3xCBcOyk4IA9VQffa7A8/zcxu/zqbqQXHN4fEo/MR1XiLQEkk+H16A0BBhCqMIYy3NrZ8mGZ/tZZ4LY/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=nai7Wcce; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="nai7Wcce" Received: from ldvnode.intra.ispras.ru (unknown [10.10.2.153]) by mail.ispras.ru (Postfix) with ESMTPSA id 02E6340CE182; Mon, 3 Mar 2025 14:02:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 02E6340CE182 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1741010564; bh=vqgSkFlCQVJ4CaUUmVwPWsAun4vxgHbAxdBt/2bRvcU=; h=From:To:Cc:Subject:Date:From; b=nai7WcceMGUZcGUxKsLVw+ByZ0zB426L99V6BXimgqOYhZ0gpVanAUZ6qjH6bN2NQ JPdn355SI9GJztXnYg9j9JJcOl8euBD3CbkJPzwu8husGgSvIqsokUvUxf07nI7x8M QOwFvGitGwy4NiKVWp8R2jIDFXoYzmRY26HJDwZA= From: Vitalii Mordan To: Alexandre Belloni Cc: Vitalii Mordan , Nicolas Ferre , Claudiu Beznea , Arnd Bergmann , Johan Hovold , Boris Brezillon , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Fedor Pchelkin , Alexey Khoroshilov , Vadim Mutilin , lvc-project@linuxtesting.org Subject: [PATCH] rtc: at91sam9: fix call balance of rtc->sclk handling routines Date: Mon, 3 Mar 2025 17:02:29 +0300 Message-Id: <20250303140229.642959-1-mordan@ispras.ru> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If rtc->sclk was enabled in at91_rtc_probe(), it must be disabled in all error paths to ensure proper cleanup. However, if devm_rtc_register_device() returns an error in at91_rtc_probe(), the rtc->sclk clock will not be disabled. Use the devm_clk_get_enabled() helper function to ensure proper call balance for rtc->sclk. Found by Linux Verification Center (linuxtesting.org) with Klever. Fixes: a975f47f6e9a ("rtc: at91sam9: use clk API instead of relying on AT91= _SLOW_CLOCK") Signed-off-by: Vitalii Mordan --- drivers/rtc/rtc-at91sam9.c | 28 +++++++--------------------- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c index 38991cca5930..f4b7cf37397f 100644 --- a/drivers/rtc/rtc-at91sam9.c +++ b/drivers/rtc/rtc-at91sam9.c @@ -375,21 +375,16 @@ static int at91_rtc_probe(struct platform_device *pde= v) return -ENOMEM; } =20 - rtc->sclk =3D devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(rtc->sclk)) + rtc->sclk =3D devm_clk_get_enabled(&pdev->dev, NULL); + if (IS_ERR(rtc->sclk)) { + dev_err(&pdev->dev, "Could not get and enable slow clock\n"); return PTR_ERR(rtc->sclk); - - ret =3D clk_prepare_enable(rtc->sclk); - if (ret) { - dev_err(&pdev->dev, "Could not enable slow clock\n"); - return ret; } =20 sclk_rate =3D clk_get_rate(rtc->sclk); if (!sclk_rate || sclk_rate > AT91_RTT_RTPRES) { dev_err(&pdev->dev, "Invalid slow clock rate\n"); - ret =3D -EINVAL; - goto err_clk; + return -EINVAL; } =20 mr =3D rtt_readl(rtc, MR); @@ -405,10 +400,8 @@ static int at91_rtc_probe(struct platform_device *pdev) rtt_writel(rtc, MR, mr); =20 rtc->rtcdev =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(rtc->rtcdev)) { - ret =3D PTR_ERR(rtc->rtcdev); - goto err_clk; - } + if (IS_ERR(rtc->rtcdev)) + return PTR_ERR(rtc->rtcdev); =20 rtc->rtcdev->ops =3D &at91_rtc_ops; rtc->rtcdev->range_max =3D U32_MAX; @@ -419,7 +412,7 @@ static int at91_rtc_probe(struct platform_device *pdev) dev_name(&rtc->rtcdev->dev), rtc); if (ret) { dev_dbg(&pdev->dev, "can't share IRQ %d?\n", rtc->irq); - goto err_clk; + return ret; } =20 /* NOTE: sam9260 rev A silicon has a ROM bug which resets the @@ -433,11 +426,6 @@ static int at91_rtc_probe(struct platform_device *pdev) dev_name(&rtc->rtcdev->dev)); =20 return devm_rtc_register_device(rtc->rtcdev); - -err_clk: - clk_disable_unprepare(rtc->sclk); - - return ret; } =20 /* @@ -450,8 +438,6 @@ static void at91_rtc_remove(struct platform_device *pde= v) =20 /* disable all interrupts */ rtt_writel(rtc, MR, mr & ~(AT91_RTT_ALMIEN | AT91_RTT_RTTINCIEN)); - - clk_disable_unprepare(rtc->sclk); } =20 static void at91_rtc_shutdown(struct platform_device *pdev) --=20 2.25.1