From nobody Sun Sep 7 12:25:10 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5361620B7E0 for ; Mon, 3 Mar 2025 11:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741002464; cv=none; b=IYvzYPpm3GrBWRqux4g1Em5ffoRHPWpPGMx8h4YPN6Si47E2Fum9idIcC6cv9wXlDHsIf1RkDjS3ZYVNUT0U465bHQlrbEYTXgQb9hGj5MO7gamua0Gmhk4UJJXgpgNtAfh1HfHTuSpkr+sqklCi4eHX5YMUJVfaNsKAZwOA6vY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741002464; c=relaxed/simple; bh=aFcJsLIM3cdSSP2ZKtYFolUMMu1Z1B26+vDxNxrArwM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LotCfkF7LRH4XoO1QxTio4/p7BEcEiLXl31kAyC/OUz6Ux/QnXTX9/6d4eWSgMtuy2FbSHZ65oPjazdK0tkQ3i6m6UOp+kYp/e3OLLuQ2WJ6a8Y6/5E1UvhG5g+pe2637ZvwytA0iOqY02MHpDF8213jxavvQE57YAJuaCIKEno= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=AGX6qDMP; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="AGX6qDMP" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-390f5556579so1369438f8f.1 for ; Mon, 03 Mar 2025 03:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741002460; x=1741607260; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fD2W5spHwFZMZCXHsDH3WDbcND7HpNlEPuCt+X3A6+A=; b=AGX6qDMPKzBrT9uAU9WUWlrmLa/+HkboYORSa73/SFeeqQ0BFjy13DC4NiQhQXKWJh 8yUinCsNqAjGnKGUMz7AYnSXMvHq5x2q2dtiUmlvEyRH1LE9xS4LP6gAxlg1BjM2MoT9 +S0Mk7SmkXdDg9D/qi3XIrKTDDQdcDLabvnTcEeCUXl+K9Cw7+RWvjKz/YbyNo3NjxvP 7Ie/zqY4uZVhKQy5Qix+UIlnwK5UPT6ZXXGrEt2y3h1OLALc/K0HBrbnAm+QPK3xCNbj vLce8pDOz0pNrG7ezs30i/W7DYOOnIzlMaaZP6xOTxZImtlFpvbhKoqvxaKnVNHqQ08A SIEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741002460; x=1741607260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fD2W5spHwFZMZCXHsDH3WDbcND7HpNlEPuCt+X3A6+A=; b=nFJCUd3Xlakj47ZwK5znpidCekRZgllXnuuJpOPRutI91+xFG3Ol87WiCXjmQM15M5 sgCcfUfY8xVEldCmzMhWGT0eOjg+5xkM/V4W1UuL/jD8/rvudymIiZTZOiaz32ymUUfe a0n3UCO6LSzhRzWjFKxxh1gfsd0+g6APsF1ObgwDKBT8CXeQVsjGC5dS/8j2kotyejIU UfCPgGUBAqQiZEobSj3rYkXddJNY6XGR3m6ROPwn1a+V2JiYgLS5Obs0N/xe7adxuWTb 4UKJ7cmEH5SKfIhsyotzX/eWjTGXJEP0AIhi7Q+1Hlo5o48gHSEWN1pJPgLjzZ0l1IC6 WZ2Q== X-Forwarded-Encrypted: i=1; AJvYcCVFkmA3+jBDvxeIvX4uECbpe2wxc4vTNgzhC0YZ+AZd//o2veFbqYZyR3FwGVm3ljie2b55TlhRWWtHZxI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8J/Q/Fk+FAWfnIxKYvgcBkY4rRE3MdR8BloaX5H6xiXmSI4vo BiXC0V//gkuMuNuByDBxPKkq8CfMXFGzA1NZK4SuAe/cZsIQNcpaMxt7KaWIIso= X-Gm-Gg: ASbGncvLpYrYTMf64bykbjPxZspr97Gw3dKc8qmmnaxSznrMcRKtxXRcbHxFaAjX2y3 0dvasvLmjyLfZDjyIiNAfTBZpBCbb7zzUTGGt9cfdz+kkICcdtZZAW39chmErfvkAAdz8Xwf8Yc iUYGrmzpSnBqd6QtdzQ+4P6l6LxWfXjC7HGDL74LEBax0ZIQMDwx7YwML4pMKS/6oK6we9D8U0d 5X9tAqL35IamAtSjX/uzu8RujWjFcf9uUuBgscWDa8QKfi8tUwEPb+Hg35vNXxDCtdVF4HMcOrJ T68M2dx927pVbPNi9y4MPt3ikWtATAHb+b1LdEz/p3VYDUnuVTMNc7JN53fI1RGvNiRAbWd64xK 3SUkd8pcSIeM/aXJBVBPtm8nsDw== X-Google-Smtp-Source: AGHT+IElYqKKYXWK0QS+vSvd1EzRFOK/gfCXSM63txcjRymmf2gCmddJGZCNMDVgYWJ66ef9goIAiQ== X-Received: by 2002:a05:6000:1847:b0:390:fdba:ac7 with SMTP id ffacd0b85a97d-390fdba0c01mr5447474f8f.51.1741002460636; Mon, 03 Mar 2025 03:47:40 -0800 (PST) Received: from localhost (amontpellier-556-1-148-206.w109-210.abo.wanadoo.fr. [109.210.4.206]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47b6ceesm14101702f8f.45.2025.03.03.03.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 03:47:40 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jonathan Cameron Cc: Andy Shevchenko , Cosmin Tanislav , Dumitru Ceclan , Guillaume Ranquet , Lars-Peter Clausen , Michael Hennerich , Michael Walle , Nuno Sa , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/8] iio: adc: ad_sigma_delta: Disable channel after calibration Date: Mon, 3 Mar 2025 12:46:59 +0100 Message-ID: <20250303114659.1672695-11-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250303114659.1672695-10-u.kleine-koenig@baylibre.com> References: <20250303114659.1672695-10-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1372; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=aFcJsLIM3cdSSP2ZKtYFolUMMu1Z1B26+vDxNxrArwM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBnxZa1Fla+gzXLCTT/KwY3Cm6Y677bJqeMMk3Jr pPPpuRIgiaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZ8WWtQAKCRCPgPtYfRL+ TuwvB/oDIs1C/+avbqlmD/ajiAhUAHnJVsoJGiLUjXEcP6OGyC8yiuj5gKTQK7rO3WhoSMr90Kv 0NjN6uyKG4p5cR/qAg+DxdArV2cGa0yThd+juLb+5+NLkYCuC47Jtsi+1BfnMEgwZ+WZt2l+lPW zNViNP+m7lR+UoOtcsllw5EJ5/0rspBxOVtXPCswhNUcQFj9IdT+O+3FMwMvhQKty2n5hyuFOI8 8x6nHDSIl/XUZIzycmnNVt2aK2CsFjeg0FQIWh7OfnwyvDn72yyzCumw9VDjiYoBgo/Mhzk9IMk cPuJejXqM1SpvQ+boXQBD1mtyT/L4nnJ2z0zGOgRA3Q/wcpm X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The function ad_sd_calibrate() enables the channel to calibrate at function entry but doesn't disable it on exit. This is problematic because if two (or more) channels are calibrated in a row, the second calibration isn't executed as intended as the first (still enabled) channel is recalibrated and after the first irq (i.e. when the calibration of the first channel completed) the calibration is aborted. This currently affects ad7173 only, as the other drivers using ad_sd_calibrate() never have more than one channel enabled at a time. To fix this, disable the calibrated channel after calibration. Fixes: 031bdc8aee01 ("iio: adc: ad7173: add calibration support") Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/iio/adc/ad_sigma_delta.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_de= lta.c index 5907c35b98e5..d91a3ba127e3 100644 --- a/drivers/iio/adc/ad_sigma_delta.c +++ b/drivers/iio/adc/ad_sigma_delta.c @@ -339,6 +339,7 @@ int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta, out: sigma_delta->keep_cs_asserted =3D false; ad_sigma_delta_set_mode(sigma_delta, AD_SD_MODE_IDLE); + ad_sigma_delta_disable_one(sigma_delta, channel); sigma_delta->bus_locked =3D false; spi_bus_unlock(sigma_delta->spi->controller); =20 --=20 2.47.1