From nobody Sun Feb 8 21:33:02 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 970361EF0BD for ; Mon, 3 Mar 2025 09:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740995066; cv=none; b=j1EmuX2PsN4ANOwuf6a0DDcHfHDPsxLDWpFddytuum8utNjC9VgILmUIdPHI3Mw80huWqhS9Xtf14xp9WgHbahYPeL/DlC8X+cOyOQEiesybVTy5xXMJOXhBdLxdk42ke68igpJSp3qcHcThUyqBq0bhFoajhAQlRitRrSwZwGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740995066; c=relaxed/simple; bh=g5Iu7zUxCMT66zFNaSWVY9N6SGSRLvL3jvyTzGGX3hk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ddx1koifLR86IyOFYp4WaVgmuiqrEMNnJrLoqjwJRb+VF7C5lxMwB5kvkZExDP4Ga8461ZS4Hv6pdhacXv7IDeROEHcMWEH2XHGm3wYPygGwAyzlw8xlgGDz82tqwqL1Xvr/L1O6wgMbflqL0LEmuQFWFFaQzBz+mOM9A6x3k9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 1275c6aef81411efa216b1d71e6e1362-20250303 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:ec3fcc8f-aa44-4f71-894d-eccf03347660,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.45,REQID:ec3fcc8f-aa44-4f71-894d-eccf03347660,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6493067,CLOUDID:4081698c0a2419bf5e3690921fac3194,BulkI D:250303172844BQY8HYXC,BulkQuantity:2,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil, BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 1275c6aef81411efa216b1d71e6e1362-20250303 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1108455076; Mon, 03 Mar 2025 17:44:16 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH 1/4] mm/vmalloc: Remove unnecessary size ALIGN in __vmalloc_node_range_noprof Date: Mon, 3 Mar 2025 17:44:07 +0800 Message-Id: <20250303094410.437985-2-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> References: <20250303094410.437985-1-liuye@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The same operation already exists in the function __get_vm_area_node, so delete the duplicate operation to simplify the code. Signed-off-by: Liu Ye --- mm/vmalloc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index dc658d4af181..20d9b9de84b1 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3798,7 +3798,6 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, shift =3D arch_vmap_pte_supported_shift(size); =20 align =3D max(real_align, 1UL << shift); - size =3D ALIGN(real_size, 1UL << shift); } =20 again: --=20 2.25.1 From nobody Sun Feb 8 21:33:02 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3591F0E50 for ; Mon, 3 Mar 2025 09:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740995067; cv=none; b=Ne/9AMe/bZk8bTkas5Iq+tQH5a8X0StQFQdBII1KSOP8d8+wAr444pNrC+45GVMjlNzru4++n1hJDaGMn5IbF46H0RAD/C/4qoLtW0RPxK3kjINPkXYLwhMNRtdGTtiI4Lqekk4pUJdhKvL/KtFsn6CkMpYMsXMpiggejoPwims= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740995067; c=relaxed/simple; bh=YI01+IEJet/MxoYaPsQ1OyLXLV2hr0fROikgH+VyV1g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CMN/DKkdy8kYrXX184qG9uLPAxLZZJ1VJr6BYG7l9+0I/sqL4+cwgSrT1YMQDuZw3OXQiygZwYm1+oXGRrg0NhdPyYANLKNqn7gIBw3G6QqTRX2friLMG4B2Qyf9hupwtshrGZZcn6/xgMY1g/GGGgGqf5BtyNllLbMIjKZqhDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 1304a892f81411efa216b1d71e6e1362-20250303 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:640f4a1d-b6e1-4b54-99b6-4f59c703312a,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:640f4a1d-b6e1-4b54-99b6-4f59c703312a,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:b8ca024c1d5b539e7fd0599ac9ff1127,BulkI D:250303172843XSIG1O9W,BulkQuantity:2,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: 1304a892f81411efa216b1d71e6e1362-20250303 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1306028357; Mon, 03 Mar 2025 17:44:17 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH 2/4] mm/vmalloc: Size should be used instead of real_size in __vmalloc_node_range_noprof Date: Mon, 3 Mar 2025 17:44:08 +0800 Message-Id: <20250303094410.437985-3-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> References: <20250303094410.437985-1-liuye@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to the logic of the code, this should be size instead of real_size. Although there is no functional problem at present, it is recommended to modify it to enhance readability. Signed-off-by: Liu Ye --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 20d9b9de84b1..e311ee33f9ef 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3801,7 +3801,7 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, } =20 again: - area =3D __get_vm_area_node(real_size, align, shift, VM_ALLOC | + area =3D __get_vm_area_node(size, align, shift, VM_ALLOC | VM_UNINITIALIZED | vm_flags, start, end, node, gfp_mask, caller); if (!area) { --=20 2.25.1 From nobody Sun Feb 8 21:33:02 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC3711F12F6 for ; Mon, 3 Mar 2025 09:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740995067; cv=none; b=cCYyGsDJZhv1WebvxUAjFwjRoWTAG6+EN0g17YPn2gKl5nipWwo1THSciYZLgrBfgunza27Hngws22R59L8ObAFr0lXU9/L1l3Y4uIc8VFJ3GerBqRB5dTPIjY0TlMylrYzhYaPnLU17kkv3qj8zmL0mdCtFutujG7YN39VQK7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740995067; c=relaxed/simple; bh=JmbXDUeQQzLzo44I2b+w3Xm/hHA3EJBuvahO5cGdQCk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fbWAVk0EWqJ4konSucmUr0N9DKi4aGGrsppTDfNCPgdfF6koI7b4PVJ0R564OESwhHeOg/oCestrNRCOwv5/ABOzS39Ogt+GzAJakEfU+QLxjT4zdjMf3jP/yIiSwwarY6DP3JTfnWwqEmUtqZefkm53n/8id3GmLKKj4ChQy0w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 138b381cf81411efa216b1d71e6e1362-20250303 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:5383d249-2c70-42eb-b87c-0d7c4c43adca,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.45,REQID:5383d249-2c70-42eb-b87c-0d7c4c43adca,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6493067,CLOUDID:25d1d2012f27b339e62b923a1ac414a9,BulkI D:250303172846IT4R4S2D,BulkQuantity:2,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil, BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 138b381cf81411efa216b1d71e6e1362-20250303 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 154557428; Mon, 03 Mar 2025 17:44:18 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH 3/4] mm/vmalloc: Remove the real_size variable to simplify the code in __vmalloc_node_range_noprof Date: Mon, 3 Mar 2025 17:44:09 +0800 Message-Id: <20250303094410.437985-4-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> References: <20250303094410.437985-1-liuye@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The use of the real_size variable causes code redundancy, so it is removed to simplify the code. Signed-off-by: Liu Ye --- mm/vmalloc.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index e311ee33f9ef..b4d2010e5105 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3770,7 +3770,6 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, struct vm_struct *area; void *ret; kasan_vmalloc_flags_t kasan_flags =3D KASAN_VMALLOC_NONE; - unsigned long real_size =3D size; unsigned long real_align =3D align; unsigned int shift =3D PAGE_SHIFT; =20 @@ -3780,7 +3779,7 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, if ((size >> PAGE_SHIFT) > totalram_pages()) { warn_alloc(gfp_mask, NULL, "vmalloc error: size %lu, exceeds total pages", - real_size); + size); return NULL; } =20 @@ -3808,7 +3807,7 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, bool nofail =3D gfp_mask & __GFP_NOFAIL; warn_alloc(gfp_mask, NULL, "vmalloc error: size %lu, vm_struct allocation failed%s", - real_size, (nofail) ? ". Retrying." : ""); + size, (nofail) ? ". Retrying." : ""); if (nofail) { schedule_timeout_uninterruptible(1); goto again; @@ -3860,7 +3859,7 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, (gfp_mask & __GFP_SKIP_ZERO)) kasan_flags |=3D KASAN_VMALLOC_INIT; /* KASAN_VMALLOC_PROT_NORMAL already set if required. */ - area->addr =3D kasan_unpoison_vmalloc(area->addr, real_size, kasan_flags); + area->addr =3D kasan_unpoison_vmalloc(area->addr, size, kasan_flags); =20 /* * In this function, newly allocated vm_struct has VM_UNINITIALIZED @@ -3869,9 +3868,8 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, */ clear_vm_uninitialized_flag(area); =20 - size =3D PAGE_ALIGN(size); if (!(vm_flags & VM_DEFER_KMEMLEAK)) - kmemleak_vmalloc(area, size, gfp_mask); + kmemleak_vmalloc(area, PAGE_ALIGN(size), gfp_mask); =20 return area->addr; =20 @@ -3879,7 +3877,6 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, if (shift > PAGE_SHIFT) { shift =3D PAGE_SHIFT; align =3D real_align; - size =3D real_size; goto again; } =20 --=20 2.25.1 From nobody Sun Feb 8 21:33:02 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B441F0E4B for ; Mon, 3 Mar 2025 09:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740995066; cv=none; b=BqlBHmY5I5TD2OD6htlXYvPUR3+0gFuO1jl+qBKLYDWjAXsxYyjXZhpOxOcaH7gr3KUgKIOfffWwk56qSwhL5ZCPBRC88KqcdjGLO8PUEbfbO/8swxLrZpnJ7LdBWhZJ/8n9hneXVQA9mrYL8qt4J5SzPezOTck9jR++wfBlfcM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740995066; c=relaxed/simple; bh=+XSsamOTQEQcCb+/kENBt2T0PIW2kJOQLD1ZnP+CGyA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XLar0jS4J2qCeqafNXGnUu9RS+N3FgCdzDY1GsvFPTju4yheq9lNNT7geEJbKD51Ay1TNMFzkeWAVckjA4t79LVhH+BjMFxAeKqMErIHHlJoED53KUb3bskHtPQTS4tklGgohcPZKqWW2WRsxBikzQBbaFZ9BMIh4gOZBhSjHAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 1414a804f81411efa216b1d71e6e1362-20250303 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:6b2933d0-3783-4a12-99a9-67185eebebbc,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:6b2933d0-3783-4a12-99a9-67185eebebbc,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:9825fa440eeca6b013ca017a2ce8db47,BulkI D:250303172846P4IK2XY7,BulkQuantity:2,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 1414a804f81411efa216b1d71e6e1362-20250303 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1860039833; Mon, 03 Mar 2025 17:44:19 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH 4/4] mm/vmalloc: Rename the variable real_align to original_align to prevent misunderstanding Date: Mon, 3 Mar 2025 17:44:10 +0800 Message-Id: <20250303094410.437985-5-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> References: <20250303094410.437985-1-liuye@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The real prefix is generally used to indicate the adjusted value of a parameter, but according to the code logic, it should indicate the original value, so it is recommended to rename it to original_align. Signed-off-by: Liu Ye --- mm/vmalloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index b4d2010e5105..a8488452b70b 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3770,7 +3770,7 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, struct vm_struct *area; void *ret; kasan_vmalloc_flags_t kasan_flags =3D KASAN_VMALLOC_NONE; - unsigned long real_align =3D align; + unsigned long original_align =3D align; unsigned int shift =3D PAGE_SHIFT; =20 if (WARN_ON_ONCE(!size)) @@ -3796,7 +3796,7 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, else shift =3D arch_vmap_pte_supported_shift(size); =20 - align =3D max(real_align, 1UL << shift); + align =3D max(original_align, 1UL << shift); } =20 again: @@ -3876,7 +3876,7 @@ void *__vmalloc_node_range_noprof(unsigned long size,= unsigned long align, fail: if (shift > PAGE_SHIFT) { shift =3D PAGE_SHIFT; - align =3D real_align; + align =3D original_align; goto again; } =20 --=20 2.25.1