From nobody Thu Dec 18 12:31:47 2025 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6963B1D516A for ; Mon, 3 Mar 2025 06:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740981996; cv=none; b=NGAUOyV+8SBJTQlLo71l0iT8cWGSXbgsGc30ixu492T1TKfslpht2LTAX0kR9jm/P/y78oPTyL7yj7IVoPhpuo811LJ98NNBbyO114egebvStoIf1xrzVh8mBLHyUs9j0ZJ0CgE4iOtqhw4RYcioAJrROp5ylidsHD1N/CBmhGI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740981996; c=relaxed/simple; bh=/us0I5iveZd6LPpiy2t629pqANkvq1Lg5LO7gggkaTY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sC3YZ54JaZchfWBTCf+47F/leN+6UrXr3FuDVhT0Qr1Pxbwa8ZhUySofA4IQWp710WJ6hDh0todBHLQ0looFTzfXtd/SJ3f9/q8DSmnDEMq5BqR5IcepAVY2yE+4Owpq08UTAtqJs300fA3XQ+XcFAxZDBXs2uiZTXpWg6LEr5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=aAYvj18k; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="aAYvj18k" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 522KZxQP002167; Mon, 3 Mar 2025 06:05:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=iDyZnbw6q3m26QApS 6v/kxgI2ZGZQYcS8SKc10ZKlnk=; b=aAYvj18ke2sGH3XXXYGkeB5yT0ifxSgOA 4iA8tlp0S6a/HoyxJeeOfwxajlv/8HmYwE0m5vewgn3Rfqxpz4fu/IWtvFSuFlyd 9t4rUPCzfz0jMd/TrcyFX48JdVb9vb2ay3RfX7LpsnAjiD5bfJaTE8HipjFA5RAz U8baOlET56D1+yFDbC5aVtsFUJgFQgolWrRETFma4HM5nStW+h1534C3L1ZoV7uo ZT8YJBTtHYqg9n0PhYsoDhirJEpoAadiN+zkr3Y0VeXmz2GTuH0Gk1k7zbFR12/K 99zdV+NKeLYZH4Ttx48CFZ+ve5VtdaLPPzzcQNqhTFXSYYR0T6k5g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 454xgp9mk0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Mar 2025 06:05:33 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 52365WZX017056; Mon, 3 Mar 2025 06:05:32 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 454xgp9mjx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Mar 2025 06:05:32 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5234DE5k013784; Mon, 3 Mar 2025 06:05:31 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 454e2kdm93-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Mar 2025 06:05:31 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52365Tkk58130720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 Mar 2025 06:05:29 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9AE4820040; Mon, 3 Mar 2025 06:05:29 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 37D9C20043; Mon, 3 Mar 2025 06:05:25 +0000 (GMT) Received: from li-80eaad4c-2afd-11b2-a85c-af8123d033e3.in.ibm.com (unknown [9.199.156.78]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 3 Mar 2025 06:05:24 +0000 (GMT) From: "Nysal Jan K.A." To: Peter Zijlstra , Andrew Morton , Ingo Molnar Cc: Michael Ellerman , Mathieu Desnoyers , Segher Boessenkool , Stephen Rothwell , linuxppc-dev@lists.ozlabs.org, "Nysal Jan K.A." , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , "Liam R. Howlett" , Rick Edgecombe , Mark Brown , Kent Overstreet , Michal Hocko , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH v2 RESEND] sched/membarrier: Fix redundant load of membarrier_state Date: Mon, 3 Mar 2025 11:34:50 +0530 Message-ID: <20250303060457.531293-1-nysal@linux.ibm.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20241029055133.121418-1-nysal@linux.ibm.com> References: <20241029055133.121418-1-nysal@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UOAZLirGGRJNyCiUHQl3oF-vv_RPPjQN X-Proofpoint-ORIG-GUID: Rgov3vtjYDdJBNTDqz-k0DfKqnlP3zmS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-03_01,2025-03-03_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1011 adultscore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503030040 Content-Type: text/plain; charset="utf-8" On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE is not selected, sync_core_before_usermode() is a no-op. In membarrier_mm_sync_core_before_usermode() the compiler does not eliminate redundant branches and load of mm->membarrier_state for this case as the atomic_read() cannot be optimized away. Here's a snippet of the code generated for finish_task_switch() on powerpc prior to this change: 1b786c: ld r26,2624(r30) # mm =3D rq->prev_mm; ....... 1b78c8: cmpdi cr7,r26,0 1b78cc: beq cr7,1b78e4 1b78d0: ld r9,2312(r13) # current 1b78d4: ld r9,1888(r9) # current->mm 1b78d8: cmpd cr7,r26,r9 1b78dc: beq cr7,1b7a70 1b78e0: hwsync 1b78e4: cmplwi cr7,r27,128 ....... 1b7a70: lwz r9,176(r26) # atomic_read(&mm->membarrier_state) 1b7a74: b 1b78e0 This was found while analyzing "perf c2c" reports on kernels prior to commit c1753fd02a00 ("mm: move mm_count into its own cache line") where mm_count was false sharing with membarrier_state. There is a minor improvement in the size of finish_task_switch(). The following are results from bloat-o-meter for ppc64le: GCC 7.5.0 Reviewed-by: Mathieu Desnoyers Reviewed-by: Michael Ellerman Reviewed-by: Segher Boessenkool --------- add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-32 (-32) Function old new delta finish_task_switch 884 852 -32 GCC 12.2.1 ---------- add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-32 (-32) Function old new delta finish_task_switch.isra 852 820 -32 LLVM 17.0.6 ----------- add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-36 (-36) Function old new delta rt_mutex_schedule 120 104 -16 finish_task_switch 792 772 -20 Results on aarch64: GCC 14.1.1 ---------- add/remove: 0/2 grow/shrink: 1/1 up/down: 4/-60 (-56) Function old new delta get_nohz_timer_target 352 356 +4 e843419@0b02_0000d7e7_408 8 - -8 e843419@01bb_000021d2_868 8 - -8 finish_task_switch.isra 592 548 -44 Signed-off-by: Nysal Jan K.A. Reviewed-by: Mathieu Desnoyers Reviewed-by: Michael Ellerman Reviewed-by: Segher Boessenkool --- V1 -> V2: - Add results for aarch64 - Add a comment describing the changes --- include/linux/sched/mm.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h index 928a626725e6..b13474825130 100644 --- a/include/linux/sched/mm.h +++ b/include/linux/sched/mm.h @@ -531,6 +531,13 @@ enum { =20 static inline void membarrier_mm_sync_core_before_usermode(struct mm_struc= t *mm) { + /* + * The atomic_read() below prevents CSE. The following should + * help the compiler generate more efficient code on architectures + * where sync_core_before_usermode() is a no-op. + */ + if (!IS_ENABLED(CONFIG_ARCH_HAS_SYNC_CORE_BEFORE_USERMODE)) + return; if (current->mm !=3D mm) return; if (likely(!(atomic_read(&mm->membarrier_state) & --=20 2.48.1