From nobody Tue Feb 10 20:50:01 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EE1421480C for ; Mon, 3 Mar 2025 15:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741014919; cv=none; b=SzqUh+bT901FlKavrQiZI/jX7JdetklUWpckSL6Wct2QReJhLxAfYH0njl+NtNx/+Sn03T5KRtCDVx2Gf1Q9v2Ld+xTFSzSt+KQGSFsmXN3hZY/T5s3tBzdmUffsYLGTkyHY5ngXM9oO8lUaZDx19seiDmRewZF/i4LJw7kQFK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741014919; c=relaxed/simple; bh=80huhgGXFEbENAM104XVYwfft3r9+sKb5+LZQUUxkp8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JSjOqg5WcVjpEOjciSEPG0kjW9uwVpypDUMETQbAYtd371pmMAin/J/oYnSxZ1xfg2xCcUZNxMgHZx0L8EdaGGYYOKx0I4yTgpCEPzdjxYrpSMbto+84jryEYLgCb+rTSnKeabB+UJWwlYnCD4/Kndelq1+01kxVScytK0rTQCY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zSFZ1fxn; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zSFZ1fxn" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2235c5818a3so48420485ad.1 for ; Mon, 03 Mar 2025 07:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741014917; x=1741619717; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WVHIeMwosUPS7NCbAFkat8Xssywx3I7J7mm+tnW6eUI=; b=zSFZ1fxnw20vgfqQanGITADfLy1UQGbpujwpzgv0PvhhSpfXAMRqS08uqzJlsXLjgM xSNzAgxeQZVoNHqRc+TYXObLWRoE7TNAiSRUyu4TEcKhjKh+4twbOrvFnPvJVAi2VzLE GEV/iBAK+8zNiKCAnyYop8ZFToj5/4/S74PRJBSHPFdivCVxHbPi5K/7yI+xLIRkK+KE 17cYTVNdrbRg9jaQj8lKCIpLiGusuUA11ai/ayDI9ZadrhbUp92f1rTR4KBZJuTU2lsS VS9TE8+Scr+WTXPWN2dWwdBAWAC/elVwTtSwwz8Vgc/tXsiKYCAqYlniy/66BUMKQo+3 AO4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741014917; x=1741619717; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WVHIeMwosUPS7NCbAFkat8Xssywx3I7J7mm+tnW6eUI=; b=EACp93OFcJ1IWDaWYCSoA3mTMckkcDrMuUyHAM/bB7aPEKZ5R+dylS1cpjgflWHhKZ gyeLUpu5l90XAAC112cQn6FJXkFG3Me9xExdE4d9ndSNhrdk3DzCOUyMs1kuKpV6QjIX CI0iMur1/CdrzdsNDPxERdD2SNAM71ptJIThj97hLYZ6zl9pbg/7Y3xWxT1iFLfUD66L F1ZGOttyUTfKUC8VUY3R895EpqLn8eBxI9VHf7pB87f854ypu5hm0GMOaZ1mIsGvBaQW O6gU8lKb0kqjZe84P1PB9TdaConso+s9FRmL5Y2LCu62ayGyg2p/V/hx2d4pf2tK2OzT uJog== X-Forwarded-Encrypted: i=1; AJvYcCVCDmimDNTbLlAQwTdEfpYqrMVe6SvSVhL+jM+qh4Rz3UNIGuDHgajgUEj68G4oDtXk1EgGD4CUfFGOqCM=@vger.kernel.org X-Gm-Message-State: AOJu0YwX5nqPgKk3rVHW4Zn8uj+7BBhGgxpsE1c5FROhBBThTIniBtVt JzG7gwtW/mjZeSoYXGS8dFgklRNFocOIFYHyvOu1FliNJdTfNtYXAtmE/7fYE5msJ8jXh8ZrUL4 o1IfF5w== X-Gm-Gg: ASbGncvoI27ycODGRnzaLYh4pujfjSsVIL3DPvMZ3b0HSsCdBL28ebMmRPSgbk8NkWO OcMBGrh3S5v6/tgWDj3PnUiL5q4jO96gRggtx/XqM1kNnDBO/jqnYI2/nrp7tUPsYj1VR2eNox6 wCssWxgP6AkXmBzZqLVRnPtwJ9TPwtNCvH1Wbh4cwUEJzWRvtms0QWmqY+yeWcVRRSv4FDerVGJ a6Kl+NJdmpm5jo4t2j64KbSk1WHMN9HE32KfhfzxoBErAOIPaarj+oEU2/LEKcno2xMcwYVTlCi WrqYsCf4gRT2H47OBdluo7LssdwpAwqq86AWgI/Ndw== X-Google-Smtp-Source: AGHT+IEDCCxneyDGrxpoVa1e/lVrsWKBTEfTydvZL1WgtRjC43I4z0Oh76p6iCNwl8fDaA8IUbPUsQ== X-Received: by 2002:a05:6a00:23c4:b0:736:65c9:918d with SMTP id d2e1a72fcca58-73665c992b7mr2534582b3a.8.1741014917092; Mon, 03 Mar 2025 07:15:17 -0800 (PST) Received: from [127.0.1.1] ([112.64.60.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736584b3cffsm1851984b3a.4.2025.03.03.07.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 07:15:16 -0800 (PST) From: Jun Nie Date: Mon, 03 Mar 2025 23:14:33 +0800 Subject: [PATCH v8 04/15] drm/msm/dpu: polish log for resource allocation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250303-sm8650-v6-14-hmd-deckard-mdss-quad-upstream-oldbootwrapper-36-prep-v8-4-eb5df105c807@linaro.org> References: <20250303-sm8650-v6-14-hmd-deckard-mdss-quad-upstream-oldbootwrapper-36-prep-v8-0-eb5df105c807@linaro.org> In-Reply-To: <20250303-sm8650-v6-14-hmd-deckard-mdss-quad-upstream-oldbootwrapper-36-prep-v8-0-eb5df105c807@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jun Nie X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1741014878; l=2320; i=jun.nie@linaro.org; s=20240403; h=from:subject:message-id; bh=80huhgGXFEbENAM104XVYwfft3r9+sKb5+LZQUUxkp8=; b=IbXsTCj9eEmPtD1AnyWyOeyRklNL6/w5i/ZK87g7/5tkipc8JeXMZmfHHBbvcawzwQ6ZQn44i xX0VT/Un90HBQaDQH1FPpRZd/PyrWnD8Jh8B5kV4ILQAVktUgA9hjUn X-Developer-Key: i=jun.nie@linaro.org; a=ed25519; pk=MNiBt/faLPvo+iJoP1hodyY2x6ozVXL8QMptmsKg3cc= It is more likely that resource allocation may fail in complex usage case, such as quad-pipe case, than existing usage cases. A resource type ID is printed on failure in the current implementation, but the raw ID number is not explicit enough to help easily understand which resource caused the failure, so add a table to match the type ID to an human readable resource name and use it in the error print. Signed-off-by: Jun Nie Reviewed-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/d= isp/dpu1/dpu_rm.c index a67ad58acd99f5c14b9ec34806b83c7a58b71e16..24e085437039e677e0fb4bbd755= a8cb3852300a4 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c @@ -802,6 +802,21 @@ void dpu_rm_release_all_sspp(struct dpu_global_state *= global_state, ARRAY_SIZE(global_state->sspp_to_crtc_id), crtc_id); } =20 +static char *dpu_hw_blk_type_name[] =3D { + [DPU_HW_BLK_TOP] =3D "TOP", + [DPU_HW_BLK_SSPP] =3D "SSPP", + [DPU_HW_BLK_LM] =3D "LM", + [DPU_HW_BLK_CTL] =3D "CTL", + [DPU_HW_BLK_PINGPONG] =3D "pingpong", + [DPU_HW_BLK_INTF] =3D "INTF", + [DPU_HW_BLK_WB] =3D "WB", + [DPU_HW_BLK_DSPP] =3D "DSPP", + [DPU_HW_BLK_MERGE_3D] =3D "merge_3d", + [DPU_HW_BLK_DSC] =3D "DSC", + [DPU_HW_BLK_CDM] =3D "CDM", + [DPU_HW_BLK_MAX] =3D "unknown", +}; + /** * dpu_rm_get_assigned_resources - Get hw resources of the given type that= are * assigned to this encoder @@ -862,13 +877,13 @@ int dpu_rm_get_assigned_resources(struct dpu_rm *rm, continue; =20 if (num_blks =3D=3D blks_size) { - DPU_ERROR("More than %d resources assigned to enc %d\n", - blks_size, enc_id); + DPU_ERROR("More than %d %s assigned to enc %d\n", + blks_size, dpu_hw_blk_type_name[type], enc_id); break; } if (!hw_blks[i]) { - DPU_ERROR("Allocated resource %d unavailable to assign to enc %d\n", - type, enc_id); + DPU_ERROR("%s unavailable to assign to enc %d\n", + dpu_hw_blk_type_name[type], enc_id); break; } blks[num_blks++] =3D hw_blks[i]; --=20 2.34.1