From nobody Mon Feb 9 00:19:56 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAE6C21577C for ; Mon, 3 Mar 2025 13:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741007940; cv=none; b=MMm3iaRtyPEceTRNJGkFpy9/wFqi25VD+wDcfLbmCGYmQg5pTQ3hnGknqV7WtbdRH2rJ1JDyTRStm+sevzKV5V6uDhvqThfNtOGfMWxyaxqZY9TWvofVedEN/YemlzRzEgbxW09EDZ3Jdqz0vzGvhxDq6heXkJFkhP9+Gy0jLQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741007940; c=relaxed/simple; bh=wmxkqe1vFjcLK2jMM+NTo3KMs+4giqwo4Tu94x6rZ5Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lqw94idJ8qYk2KdHdMkNVziv031Zi4XkkwusI8TsFcuaTjoUz8P7ybOVAJBQmSqs2w8IQ29iCuROtWi+L/PX/oJ8ikgGPVEw02ffcfgzzrO9QbqMesXKabH9lWQ0gvKn3LyQfWMM+RZUgvYvsox6JhNaP/oAomRZduRvOaEzPcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=LShH7kHX; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="LShH7kHX" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4394036c0efso27993365e9.2 for ; Mon, 03 Mar 2025 05:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1741007936; x=1741612736; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qYy3OxmCTfeXmKWW1VbewLs6rP6H3oG1fco894i6r5M=; b=LShH7kHXmNlqf3fu8ym+f1rFLE08mRQ2xXbmsVZYGziaWTsfyeSYIWsA3cpZ1/PmuU jdexayHHhJcOa6t/4RZYk4f1A56R0BC1w8paigKzJXkWCmxTMzRU5X6xxOm79PfmhtX2 OOOu96YJkMSOADEEdGN7XoKCYIWsL8dTFwOlAkcp+9XM8fJma7gkoWaUWKIUzR1nAPUs LqATWxDmmFjuUkKO0mezr5jdt59VEcxGVtMK1eb7KvmfaDmt9WcthKEQCdv5unD0OcUl 8sz04IZZ1qsoq9O/bvs1VHCpCWWRZ5EFAura1CzU6WFU0fIvqUkdSwS5b66/Z++DfSB5 vx+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741007936; x=1741612736; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qYy3OxmCTfeXmKWW1VbewLs6rP6H3oG1fco894i6r5M=; b=I2lH1oNjSEcbWOdHKYhzeB59j5oSG34iR8Yo2s3syeXT9qM38JaQPua3objR/iHoP8 en5SRbtrbeT71hfLL53YoBCV1P/Zdd9nkqjLz4CZbrFT3fovHlabRNVleNOs155sjPJr GresrDL3MZNwpXtLxNONUez7JDhZIsGCjXMUmntFyHHY2vlJDeHP7oj5Arevxwc/0+ej dnZK2NjUH1VzF+y6N3eQMdn5sM+PPMIyE0AiQ/QoL6E3c3jO256N/BuRB4oAm0XZZn6o iJ07v/GF5+HMBpjij+kwvXxYNQqy5BNdmClHPsbrLGvkej301he4qtJCMdvs69yLMqKV g1kQ== X-Forwarded-Encrypted: i=1; AJvYcCXyiUGK5GELf4gKENTIveB6dLhH/WmV8jhpb/XLF97ZDlhZTV0PzkVLkeNSSgoGOucowRHUytStz4kZW8A=@vger.kernel.org X-Gm-Message-State: AOJu0Yxomj7qvYyqh9rpqs7tCRSyz6m2NVmonfWZZtKMwwtB6Wc1ZbIW MiAHDggWIXcClg+zWBl5xGX9ItzXV5NSh7abKPVbsu60ChABt8y2J2lzhIY8kBg= X-Gm-Gg: ASbGncuMngFep510z54QV2BcJxsv/G0w363tkXwQaUEvrC6GbxAgktSQ+YBquXKto0Z lhjVkJvsNXw6pcU85bH/EJPJ6TqLafT0vfUy7/fRTQ1tjQoEnzNXS3QjIkunB0QlAYgg8ZAvk7p iikqQZnMYFwyRyw/JWTVoDE9B5Qw1pYa5lR91vuJJOPWVEqihdu53KFY6yDOmw0XAM+1TZqOxzV TKt0CYaS1AI+GuiQNr9x8HFf9uri4Lqy3Djm5QNOa0CiBm2j3qqvNhs0Q13c5/8hDZNvNxkll25 DD6gtPJxIG6lwytjFZD7x1iTXv3wquRuknpnsA== X-Google-Smtp-Source: AGHT+IGrzVhEnfUuDCVxi9rV1+Y2pAX00HYe4ND5tnilxpFNSHjqZm+Q1tO//4HTCcPKf55lo23WTw== X-Received: by 2002:a05:600c:4ed4:b0:439:98ca:e3a4 with SMTP id 5b1f17b1804b1-43ba67475aamr98841885e9.19.1741007934650; Mon, 03 Mar 2025 05:18:54 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:664a:9e92:6aa8:6007]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba538b9fsm194821915e9.17.2025.03.03.05.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 05:18:53 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 03 Mar 2025 14:18:40 +0100 Subject: [PATCH 15/15] gpio: aspeed-sgpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250303-gpiochip-set-conversion-v1-15-1d5cceeebf8b@linaro.org> References: <20250303-gpiochip-set-conversion-v1-0-1d5cceeebf8b@linaro.org> In-Reply-To: <20250303-gpiochip-set-conversion-v1-0-1d5cceeebf8b@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Michael Hennerich , Laurent Pinchart , Mun Yew Tham , Joel Stanley , Andrew Jeffery Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1486; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=o1RQkjcxzC+TGloaGMTPuFJzidyh+RPMXxMLz3aV4DI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnxaws57keqtznwsHgFtxTpm4rRaKKUe8Z3RX1S ld6SfCwJGCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ8WsLAAKCRARpy6gFHHX ckXIEADQhVFh09Iq4tEU1jISNlnEkfP7k1ELSZ2IXMcW2dvNP7VqR81V0ZYPQcclqaZcCttaM/0 1t5g/NVwoezK7o4qVsmqkqEYmN/nvkOX0UsVySyJw/0dXUPT/CQHlKIC/erIqkDom3R1svtUd31 J8c4lXQO8LVXCkp4nJAkRYT4Pp8L7ABPoI8raUIP2VV8rjcwdbiVm9WCmlKM4tWAcJUCSL+WNdq P08bBozKKrLOq69Uc92O0nJlOwBqmO4bFPrWVqNuqZLcX4lyWblxe8aftcHYJPVLMNkJ/VGuhSd scoDcPInDpwb45deB+pQKPmVX+r5jj6vzMfSsD3gtmzzVSbaRkjTrA9B2rqjxRO5+w1AwLup7eD dcPbHDmqiZewAlMFEyYu18B6DBXl0+p/kcCHFQHuX+RX7QW5f0TyiwikwKokqYPCvwXVRCDPUUW 8Ro4zYv2Q4eoLzFPK7GbnD8MQO83Fy90ZIxjT4Hsw21lBZiOmicK28b5uSHvoAziBQurQ/M9+r9 tMPeMyCpRPfCCwKF4H7RofC7RJGan9UoZtnZ66gpzw7ne2jNJ0rx2YSXzVoxYEwFv+RX2NRP0UD SxJc01SMF9zx33J3w0C77IRMrapFhhJcw6Ls1/VbuDECgOkpKtB9qH0Cr/4U9XQuMfQ3uo+w/Gt pwY99gL8+uSpR2g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Jeffery --- drivers/gpio/gpio-aspeed-sgpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-aspeed-sgpio.c b/drivers/gpio/gpio-aspeed-sg= pio.c index 5ce86de22563..00b31497ecff 100644 --- a/drivers/gpio/gpio-aspeed-sgpio.c +++ b/drivers/gpio/gpio-aspeed-sgpio.c @@ -209,13 +209,13 @@ static int sgpio_set_value(struct gpio_chip *gc, unsi= gned int offset, int val) return 0; } =20 -static void aspeed_sgpio_set(struct gpio_chip *gc, unsigned int offset, in= t val) +static int aspeed_sgpio_set(struct gpio_chip *gc, unsigned int offset, int= val) { struct aspeed_sgpio *gpio =3D gpiochip_get_data(gc); =20 guard(raw_spinlock_irqsave)(&gpio->lock); =20 - sgpio_set_value(gc, offset, val); + return sgpio_set_value(gc, offset, val); } =20 static int aspeed_sgpio_dir_in(struct gpio_chip *gc, unsigned int offset) @@ -596,7 +596,7 @@ static int __init aspeed_sgpio_probe(struct platform_de= vice *pdev) gpio->chip.request =3D NULL; gpio->chip.free =3D NULL; gpio->chip.get =3D aspeed_sgpio_get; - gpio->chip.set =3D aspeed_sgpio_set; + gpio->chip.set_rv =3D aspeed_sgpio_set; gpio->chip.set_config =3D aspeed_sgpio_set_config; gpio->chip.label =3D dev_name(&pdev->dev); gpio->chip.base =3D -1; --=20 2.45.2