From nobody Wed Feb 11 06:38:05 2026 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A25F1E5B99; Sun, 2 Mar 2025 15:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740930152; cv=none; b=iw27hFsMzK/j3AYcg78u5j79AhU5t8tZ2x0Y7pnV1FXBJ6jxPhRarQn/50qoKPWk3a4K6Ch+25ajf6ExJntiuMEJjBbNzyqtSy+tIrdkdQcn0j+6P4I3qN9u0/xvPyIvLAQN9fB9Vk21rTYjfcUMq2ie3UwlKkPjm0IjiZ2o6A4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740930152; c=relaxed/simple; bh=VXUTh34TX1miTwMK5vqmpftNHqzI23BV359QO4L5zCA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U2SrxEE5mlqsNVQ3zD5AmP7I/JigwK0FVdWb1l+4jbXncyGO1wzBViHw05AGXUOem8Eg0lbwCRFR4x7OiZjEPKR5OaXqC1ZitHFJfHZ/FaWmCO8Ag8BLaVPJHLRINZ82eg8eC28qNczxwVayTyzA7An9FKP/bBl1XKGkfgWKvfg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=hYNsEq4q; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="hYNsEq4q" Received: by mail.gandi.net (Postfix) with ESMTPSA id 93CC444416; Sun, 2 Mar 2025 15:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740930142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pdu+llpCHIijzzSuA4AKVEUxnoDKFr7+qiRqelIM65s=; b=hYNsEq4qi6NcLtZ1QvMXr9woIHKhmH+712Ae82G5dQv7greIF/ulZUWLGUmdSaW1I5afJO X8H1+Jz0OthWLEBLhrMxAoRfVKbg9BV4Ow+0C8plLBsWJiqqEtflHK9vsE8/5tEFuon9Xd WXB08a6I07LnV+G+QZ3LrqYTzXvZckeP4xH+EjJWNC69P2nt50zH+vwkLzHqGa9vMXKayl dTRAcBk9RPhHLfApkOHjlRT8LY2wclKrXbfQf+Lgxcg4g+6mD6YRBhkxslBdSpAOPx8tWU kIEM8X3I8u5UpI29sphi4BsVAvZTlEjImaACwS3fFE+l6xGR8WoNMU6KlOEUPQ== From: Olivier Benjamin Date: Sun, 02 Mar 2025 16:41:02 +0100 Subject: [PATCH v2 1/2] arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250302-camera-v2-1-312b44b4a89c@bootlin.com> References: <20250302-camera-v2-0-312b44b4a89c@bootlin.com> In-Reply-To: <20250302-camera-v2-0-312b44b4a89c@bootlin.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Thomas Petazzoni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Olivier Benjamin , oren@taumoda.com, Dragan Simic , Ondrej Jirman X-Mailer: b4 0.14.2 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdelieeitdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephfffufggtgfgkfhfjgfvvefosehtjeertdertdejnecuhfhrohhmpefqlhhivhhivghruceuvghnjhgrmhhinhcuoeholhhivhhivghrrdgsvghnjhgrmhhinhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgeeugeeivddvveevvedvudefjeevffdtuefgffekieelheehfeeihefgleefieelnecukfhppedvrgdtudemvgefgeemvggtfeekmedvgegvtdemfhehtggvmehffeegvdemieehkeejmehfieehieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemvgefgeemvggtfeekmedvgegvtdemfhehtggvmehffeegvdemieehkeejmehfieehiedphhgvlhhopegludelvddrudeikedruddrvddtngdpmhgrihhlfhhrohhmpeholhhivhhivghrrdgsvghnjhgrmhhinhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudefpdhrtghpthhtoheplhhinhhugidqrhhotghktghhihhpsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehmvghgihesgihffhdrt giipdhrtghpthhtohepughsihhmihgtsehmrghnjhgrrhhordhorhhgpdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdhrtghpthhtohepohhrvghnsehtrghumhhouggrrdgtohhmpdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepthhhohhmrghsrdhpvghtrgiiiihonhhisegsohhothhlihhnrdgtohhm X-GND-Sasl: olivier.benjamin@bootlin.com Add the description of the rear/world camera (IMX258) on the PinePhone Pro to the device dts file. It receives commands on the I2C Bus 1 at address 0x1a and transmits data over CSI-MIPI. The I2C address for IMX258 can be found in the IMX258-0AQH5 Software Reference Manual, page 24, section 2.3.1: 0b0011010 =3D 0x1a. Section 3 indicates the module has 4 pairs of data lines. While 4-lane mode is nominal, 2-lane mode should also be supported. The pin muxing info was extracted from the PinePhone Pro schematic v1.0 as well as the RK3399 datasheet revision 1.8. Table 2-3 in section 2.8 of the RK3399 datasheet contains the mapping of IO functions for the SoC pins. Page 52 shows GPIO1_A0, page 54 shows GPIO2_D4. For I2C power, the PinePhone Pro schematic page 11 quadrants A4 and A5: RK3399_J.AA8 and RK3399_J.Y8 get power from vcaa1v8_codec, so turn it on The IMX258 also uses the following regulators, expected by its driver: - vana (2.8V analog), called AVDD2V8_DVP on P.18 q.C1 and derived from VCC1V8_S3 on P.13 q.B2 - vdig (1.2V digital core), called DVDD_DVP on P.18 q.C1 and shown on P.18 q.D3 to be equivalent to VCC1V2_DVP derived from VCC3V3_SYS on P.13 q.B3. Note that this regulator's voltage is inconsistently labeled either 1.2V or 1.5V RK3399_J.AG1 is GPIO4_A1/I2C1_SDA, RK3399_J.Y6 is GPIO4_A2/I2C1_SCL This is the default pinctrl "i2c1_xfer" for i2c1 from rk3399-base. For the reset (RESET) signal: page 11 quadrant D2 | p.18 q.C3-4 | p.18 q.C2 RK3399_E.R25 -> GPIO1_A0 -> Camera_RST -> MIPI_RST0 -> IMX258.12 For the powerdown (PWDN) signal: page 11 quadrants B4-5 | p.18 q.C2 RK3399_G.AF8 -> GPIO2_D4 -> DVP_PDN1_H -> IMX258.14 Helped-by: Dragan Simic Co-developed-by: Ondrej Jirman Signed-off-by: Ondrej Jirman Signed-off-by: Olivier Benjamin --- .../boot/dts/rockchip/rk3399-pinephone-pro.dts | 93 ++++++++++++++++++= ++++ 1 file changed, 93 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 04ba4c4565d0a205e2e46d7535c6a3190993621d..7f8fe7577d240f330328b6ea44e= a6b06bbc8595b 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -114,6 +114,16 @@ vcc3v3_sys: regulator-vcc3v3-sys { vin-supply =3D <&vcc_sys>; }; =20 + avdd2v8_dvp: regulator-avdd2v8-dvp { + compatible =3D "regulator-fixed"; + regulator-name =3D "avdd2v8_dvp"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt =3D <2800000>; + regulator-max-microvolt =3D <2800000>; + vin-supply =3D <&vcc3v3_sys>; + }; + vcca1v8_s3: regulator-vcc1v8-s3 { compatible =3D "regulator-fixed"; regulator-name =3D "vcca1v8_s3"; @@ -136,6 +146,16 @@ vcc1v8_codec: regulator-vcc1v8-codec { vin-supply =3D <&vcc3v3_sys>; }; =20 + vcc1v2_dvp: regulator-vcc1v2-dvp { + compatible =3D "regulator-fixed"; + regulator-name =3D "vcc1v2_dvp"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt =3D <1200000>; + regulator-max-microvolt =3D <1200000>; + vin-supply =3D <&vcca1v8_s3>; + }; + wifi_pwrseq: sdio-wifi-pwrseq { compatible =3D "mmc-pwrseq-simple"; clocks =3D <&rk818 1>; @@ -312,6 +332,8 @@ vcc3v0_touch: LDO_REG2 { =20 vcca1v8_codec: LDO_REG3 { regulator-name =3D "vcca1v8_codec"; + regulator-always-on; + regulator-boot-on; regulator-min-microvolt =3D <1800000>; regulator-max-microvolt =3D <1800000>; }; @@ -420,6 +442,45 @@ regulator-state-mem { }; }; =20 +&i2c1 { + clock-frequency =3D <400000>; + pinctrl-0 =3D <&i2c1_xfer &cif_clkouta>; + assigned-clocks =3D <&cru SCLK_CIF_OUT>; + assigned-clock-rates =3D <24000000>; + status =3D "okay"; + + wcam: camera@1a { + compatible =3D "sony,imx258"; + reg =3D <0x1a>; + clocks =3D <&cru SCLK_CIF_OUT>; /* MIPI_MCLK0, derived from CIF_CLKO */ + clock-names =3D "xvclk"; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&wcam_rst>; + /* Note: both cameras also depend on vcca1v8_codec to power the I2C bus.= */ + vif-supply =3D <&vcc1v8_dvp>; + vana-supply =3D <&avdd2v8_dvp>; + vdig-supply =3D <&vcc1v2_dvp>; /* DVDD_DVP is the same as VCC1V2_DVP */ + reset-gpios =3D <&gpio1 RK_PA0 GPIO_ACTIVE_LOW>; + orientation =3D <1>; /* V4L2_CAMERA_ORIENTATION_BACK */ + rotation =3D <270>; + lens-focus =3D <&wcam_lens>; + + port { + wcam_out: endpoint { + remote-endpoint =3D <&mipi_in_wcam>; + data-lanes =3D <1 2 3 4>; + }; + }; + }; + + wcam_lens: camera-lens@c { + compatible =3D "dongwoon,dw9714"; + reg =3D <0x0c>; + /* Same I2c bus as both cameras, depends on vcca1v8_codec for power. */ + vcc-supply =3D <&vcc1v8_dvp>; + }; +}; + &i2c3 { i2c-scl-rising-time-ns =3D <450>; i2c-scl-falling-time-ns =3D <15>; @@ -462,6 +523,28 @@ &io_domains { status =3D "okay"; }; =20 +&isp1 { + status =3D "okay"; + + ports { + port@0 { + mipi_in_wcam: endpoint@0 { + reg =3D <0>; + remote-endpoint =3D <&wcam_out>; + data-lanes =3D <1 2 3 4>; + }; + }; + }; +}; + +&mipi_dphy_rx0 { + status =3D "okay"; +}; + +&isp1_mmu { + status =3D "okay"; +}; + &mipi_dsi { status =3D "okay"; clock-master; @@ -495,6 +578,10 @@ mipi_in_panel: endpoint { }; }; =20 +&mipi_dsi1 { + status =3D "okay"; +}; + &pmu_io_domains { pmu1830-supply =3D <&vcc_1v8>; status =3D "okay"; @@ -507,6 +594,12 @@ pwrbtn_pin: pwrbtn-pin { }; }; =20 + camera { + wcam_rst: wcam-rst { + rockchip,pins =3D <1 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; + leds { red_led_pin: red-led-pin { rockchip,pins =3D <4 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>; --=20 2.48.1