From nobody Sun Feb 8 00:34:42 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2630C1F09AE for ; Fri, 28 Feb 2025 18:04:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740765894; cv=none; b=n+UFI81mnwV5saIMZ6KwQBeonM/aKdta+49H5C3KmNNdRWpKr3AR/iYyxrkSI8isqs5fjmmWQVDFuc70rpaqXfVzcPBgg2yXTECreDH4CBvONP7yeN4el1fUoMNlleaMvvv1SnE28a/Xt4O0BzPqZCnzg5NPOS2OP4A0YE06uxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740765894; c=relaxed/simple; bh=p5YNSl+tACPhKTbX5xBy7X2QQnkmsEDw2DUatYNaNT0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DVadKGmEBzAT4updzn/8M0RCId5tuk3eMv7p26iqQ7RJOWVZ/lXY4KwrOM1ToQlPPH1mA+dWIV2lMiQ+LSQdzUQVvT4/lx5P4zTCI/Bsjiv6osFkozCUEIQH/AVXu+ElQzcmK7T3DaZ3It+2ps2Z/djXVt1d+66OPBrX9eP+QJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HxJuChTO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HxJuChTO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740765892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VGAryNfhIHltDXBhImLJg9FkqIv+XeRGH9VzW685p/w=; b=HxJuChTOrgWrGB99PcTwZ0DsB1jjAiz129YOJ/eAy5iToHB/F+dCxG1rnLEpMP6xjxnlYL e1+gIeKGzOBxIsDuj/AP43aPzAy9qOkVUF7C6ubtLUC3e4ob0Ky7zPNQDNIsDDwWyt9JiC BA3ASyjdCyCwuNLMlR+d1Y/REp0Rjkk= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-270-62DDB3_fObiAsG_nmvzUfw-1; Fri, 28 Feb 2025 13:04:50 -0500 X-MC-Unique: 62DDB3_fObiAsG_nmvzUfw-1 X-Mimecast-MFC-AGG-ID: 62DDB3_fObiAsG_nmvzUfw_1740765890 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c0b9242877so579899785a.3 for ; Fri, 28 Feb 2025 10:04:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740765890; x=1741370690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VGAryNfhIHltDXBhImLJg9FkqIv+XeRGH9VzW685p/w=; b=E9lLilVUYeDcR7BYuzbcxIPr9GQRLsAKKGUi1fG4KQsJDKaQpBkqPgX8jHusiDmbhe bbXvVeL8YMpQVvhytrrc9ox5Han8hbj4F9IIxQetlZi5P/fMiRoK0L67mN8jMQRpWQKb 7RAO01PGh7SZCmK6G2XhHDzU5CEvWVmSm5nYNG72UK4wVhHOExDKTtGYEo9g4aS3fiGZ KNoJ7/h/o2tpcW1pybmDC3xF0dl9bd9glIdjT1+st+n6sCpKxQcSxY6R0GzSwneA5PWc siD89ngtRQrXlXEPdI+f4wT1nHge0yxKa042901kr800xbYfG151ZcQAUGtADJxO7JFw Dtxw== X-Gm-Message-State: AOJu0YzNZbN06gm8MJAbKC2Vv+40jlfJ0E4U9Lbu2dDtNQD59NshIb80 6VtZraNnCzZqlFN1aqnMAiHRe/AnWdnIX7dS0bWXhEy0nWbuZtuWt4cr7GCiGs8txGGiaAD24S0 J+6T6nqIvJC7IgOWUy9GNPCnjeP6OMxaSLDhJ2N9zVQ7XOukn183B/GcY+fZbww== X-Gm-Gg: ASbGncuOD6FeeOcLBop57U03d5MoyI4qU+3AacLsTf6Yhxkm96580c34exBhr1nUJs9 UDZMJTwGOlp2hBoNGsu7HOAZWvM4BWpJbeubNHPWaot1YxAJeCEB2gw7ojikN2WBSwH20f0ADoB ifW/HqEcrJJxETVESv6x709FZEq+XWQTMQnOmqRqjy6e285afTEQQZjh/HpsbM5GqhYf/z9Lp20 NXNIIhrFlgI+hzhYUxUxIwCCZPFAI2puSeKRewjwzyxyf5g24blfYMut35QFpkTvBMWm+CFNUYO KPvdDoVKZArnHuJgj8KlnViTBovzbmW+/SCmswhHuz/TfSPNcdajzlSRW4Z6nnU0kfffBcyR7cY = X-Received: by 2002:a05:620a:f15:b0:7c0:b523:e1ad with SMTP id af79cd13be357-7c39c66d27emr632612385a.47.1740765890049; Fri, 28 Feb 2025 10:04:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEj/2QsRAB/VCS/BBKQ2yHSEMwWhZUBp2Kj5DgJewvlBgCUKZXnHJSnP4yCZQbD/+GMC6zkJA== X-Received: by 2002:a05:620a:f15:b0:7c0:b523:e1ad with SMTP id af79cd13be357-7c39c66d27emr632608985a.47.1740765889755; Fri, 28 Feb 2025 10:04:49 -0800 (PST) Received: from rhdev.redhat.com (2603-9001-3d00-5353-0000-0000-0000-14c1.inf6.spectrum.com. [2603:9001:3d00:5353::14c1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c36fee8a08sm274654485a.6.2025.02.28.10.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 10:04:49 -0800 (PST) From: Jennifer Berringer To: Srinivas Kandagatla , Sebastian Reichel Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Jennifer Berringer Subject: [PATCH v4 1/2] nvmem: core: add nvmem_cell_size() Date: Fri, 28 Feb 2025 13:03:25 -0500 Message-ID: <20250228180326.256058-2-jberring@redhat.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250228180326.256058-1-jberring@redhat.com> References: <20250228180326.256058-1-jberring@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This function allows nvmem consumers to know the size of an nvmem cell before calling nvmem_cell_write() or nvmem_cell_read(), which is helpful for drivers that may need to handle devices with different cell sizes. Signed-off-by: Jennifer Berringer --- drivers/nvmem/core.c | 18 ++++++++++++++++++ include/linux/nvmem-consumer.h | 6 ++++++ 2 files changed, 24 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index d6494dfc20a7..4d0cbd20da48 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -1624,6 +1624,24 @@ void nvmem_cell_put(struct nvmem_cell *cell) } EXPORT_SYMBOL_GPL(nvmem_cell_put); =20 +/** + * nvmem_cell_size() - Get nvmem cell size in bytes. + * + * @cell: nvmem cell. + * + * Return: size of the nvmem cell. + */ +size_t nvmem_cell_size(struct nvmem_cell *cell) +{ + struct nvmem_cell_entry *entry =3D cell->entry; + + if (!entry) + return 0; + + return entry->bytes; +} +EXPORT_SYMBOL_GPL(nvmem_cell_size); + static void nvmem_shift_read_buffer_in_place(struct nvmem_cell_entry *cell= , void *buf) { u8 *p, *b; diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h index 34c0e58dfa26..a2020527d2d3 100644 --- a/include/linux/nvmem-consumer.h +++ b/include/linux/nvmem-consumer.h @@ -54,6 +54,7 @@ struct nvmem_cell *nvmem_cell_get(struct device *dev, con= st char *id); struct nvmem_cell *devm_nvmem_cell_get(struct device *dev, const char *id); void nvmem_cell_put(struct nvmem_cell *cell); void devm_nvmem_cell_put(struct device *dev, struct nvmem_cell *cell); +size_t nvmem_cell_size(struct nvmem_cell *cell); void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len); int nvmem_cell_write(struct nvmem_cell *cell, void *buf, size_t len); int nvmem_cell_read_u8(struct device *dev, const char *cell_id, u8 *val); @@ -117,6 +118,11 @@ static inline void nvmem_cell_put(struct nvmem_cell *c= ell) { } =20 +static inline size_t nvmem_cell_size(struct nvmem_cell *cell) +{ + return 0; +} + static inline void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len) { return ERR_PTR(-EOPNOTSUPP); --=20 2.47.1 From nobody Sun Feb 8 00:34:42 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B92FF26FDB1 for ; Fri, 28 Feb 2025 18:04:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740765896; cv=none; b=tqf62xDLP0Qvnp8mVv9U99pEAgPppdjY+wP56ThHzr/vvV0eWhS7tbAhB7ivQVWN7wmS2fEvltszMuzK3V/yEfs6mE96sTmIvDSTf/QI9KxbueGwvH1csQ7gh4Sg3moVQprFKBR1nu1BAJjblVMetHTjO/S+vwBTKI/l1To1jt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740765896; c=relaxed/simple; bh=scfmeAIOAJYjZm7Jb+84QkPQyC4V8osgVIoJao20Z88=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kdeC4dz9mQX3y+QMVrlBBQPwtcosHNYVmoWophj1bUFiMjCg5Tb/yOEXze5leL/KvGLbq4hm6ZVcf5Izcv2LGlnWgUo+2r+2oMzwlgRNqNb3ubsTTcr91h6M41NBgZcLDTCKMxqQpd2t2dyt6CfoUQToRS77oIS3mAt5K+kmwa4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=drsSSEV1; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="drsSSEV1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740765893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PAMkimjaX5T169DBm7Y9jGqkQ+vg8U81DkhhnBduopw=; b=drsSSEV1sT9mw7otbLgCY28AShbwzlYWTgBZSZRVl4CidTmSTzXJQWA1Pt+CiIKjR+1Pj8 WmqSkRxLpJnEVUcuoUh9lmuVJoxklvcvmf5xrQfMEhOffg/bI8gtFh+tMXVN2uoM+3k1rl HzJfiNjRHo8fu307nNXm8eLh2pZaYUo= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-1ArMy8TqMSizM5o1PGX4Aw-1; Fri, 28 Feb 2025 13:04:52 -0500 X-MC-Unique: 1ArMy8TqMSizM5o1PGX4Aw-1 X-Mimecast-MFC-AGG-ID: 1ArMy8TqMSizM5o1PGX4Aw_1740765891 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c096d6602cso609212085a.0 for ; Fri, 28 Feb 2025 10:04:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740765891; x=1741370691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PAMkimjaX5T169DBm7Y9jGqkQ+vg8U81DkhhnBduopw=; b=oEyj3VqC9JaeQbPawhPfZ2Gl0LBTI6wqxJ5AWA83iRXHUJ0EGgaI0KfPJiYngtsxUK xvjNMRvwlw7+o7zwWaVm3O+xyfK0FuqyJnsrRhiGE6BM/C00d9YcfwyeeIcpXBXtgkHb F6BHkcnKEY8QuXTsrxcGdULZI/5M05yxf/qu29zcjxvQoBjqkKxFJXdekcgXNTuS2+Rp 3S6KU9ejuZv1k5+0RrSYIKILBoFamRZznXOIMl18Fvo2ES+OK/LcONmHFW6TeRvTl2si MnN+6NPHAqeOjM9MyunAUYmjz10xoKOJilz2rLW0wFoo6w/0t1Gf1IhiGeU4YySM0dNh 61/w== X-Gm-Message-State: AOJu0Yy3H05T49Ojclcj0y1rNKZYnM0ySHd85lEnNhQowyF7pY080X8c MKjwi87nY1ASHCCapsg1ssWRREJLkXxvdVCscSuc/85pjrwU7/9PO5A93zRi6aRjGZyV+P2jEmw JZZgPoXNWD/pkFtveWPNy7qpuUdB6EK//cHZUdBn9KFKKgpZb2Ql6pVsGwqm0bA== X-Gm-Gg: ASbGnctLzyKz3Iu/2AbdnjnlPFueeLeaehgt/f+w2MLeqQduhKF8vzjaLjnWmXoCco2 wTlQjFAR1TkBqtMyTsuEKk05VaWl2AbGhsS2jQ2tjM9BAGrNqZZ6SM1mPhKGHTSmjQZOaHByaeM Bp+3I4cpMLtti4HNh37YrPd1yhc3A6q+jJwt4kkpSdqAyBvw/Q7Hgh9VSO4AmzhYiE9ttC/xHu3 U1xISNozdDcoOR288ojWH/fD1TXEwy0peFQBAW9Usbtx3BC18+uLpXin0UHW4Ptvz19pG12PkyE b3uNnryXta+CDswX8BcDWhhlRa+EHG2bl/uG85dqh+J5Q+htgdHPjZvPI1nraoaWgOWVk2X0g0A = X-Received: by 2002:a05:620a:394e:b0:7c0:ab10:1132 with SMTP id af79cd13be357-7c39c656e05mr626151285a.38.1740765891351; Fri, 28 Feb 2025 10:04:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTh85sVtk5oi8HSf7ZrK+kyN9/o2F13SCQKm1m3pZ9EncsS4obYl1hjRjtWWMtTxJIGo4z9g== X-Received: by 2002:a05:620a:394e:b0:7c0:ab10:1132 with SMTP id af79cd13be357-7c39c656e05mr626146785a.38.1740765890866; Fri, 28 Feb 2025 10:04:50 -0800 (PST) Received: from rhdev.redhat.com (2603-9001-3d00-5353-0000-0000-0000-14c1.inf6.spectrum.com. [2603:9001:3d00:5353::14c1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c36fee8a08sm274654485a.6.2025.02.28.10.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 10:04:50 -0800 (PST) From: Jennifer Berringer To: Srinivas Kandagatla , Sebastian Reichel Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Jennifer Berringer Subject: [PATCH v4 2/2] power: reset: nvmem-reboot-mode: support smaller magic Date: Fri, 28 Feb 2025 13:03:26 -0500 Message-ID: <20250228180326.256058-3-jberring@redhat.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250228180326.256058-1-jberring@redhat.com> References: <20250228180326.256058-1-jberring@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some devices, such as Qualcomm sa8775p, have an nvmem reboot mode cell that is only 1 byte, which resulted in nvmem_reboot_mode_write() failing when it attempts to write a 4-byte magic. Checking the nvmem cell size and writing only the lower bits of the reboot mode magic is needed for these devices. Signed-off-by: Jennifer Berringer --- drivers/power/reset/nvmem-reboot-mode.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/power/reset/nvmem-reboot-mode.c b/drivers/power/reset/= nvmem-reboot-mode.c index 41530b70cfc4..112e6cf77d1b 100644 --- a/drivers/power/reset/nvmem-reboot-mode.c +++ b/drivers/power/reset/nvmem-reboot-mode.c @@ -20,11 +20,18 @@ static int nvmem_reboot_mode_write(struct reboot_mode_d= river *reboot, unsigned int magic) { int ret; + u8 *magic_ptr =3D (u8 *) &magic; + size_t cell_size; struct nvmem_reboot_mode *nvmem_rbm; =20 nvmem_rbm =3D container_of(reboot, struct nvmem_reboot_mode, reboot); + cell_size =3D nvmem_cell_size(nvmem_rbm->cell); =20 - ret =3D nvmem_cell_write(nvmem_rbm->cell, &magic, sizeof(magic)); + /* Use magic's low-order bytes when writing to a smaller cell. */ + if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) && cell_size < sizeof(magic)) + magic_ptr +=3D sizeof(magic) - cell_size; + + ret =3D nvmem_cell_write(nvmem_rbm->cell, magic_ptr, MIN(cell_size, sizeo= f(magic))); if (ret < 0) dev_err(reboot->dev, "update reboot mode bits failed\n"); =20 --=20 2.47.1