From nobody Mon Feb 9 21:37:30 2026 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CC05272904 for ; Fri, 28 Feb 2025 14:07:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751657; cv=none; b=Ehz+w9O8z3W/bEJSY/k2tJB0j844xUiql22VYZAn0blPegkn2BhHHj2Psr58YeaBJtdq/iKoWht7blFWEW49cXOl+o/cN7hJ0Z/Js2/Xe3eJ6MibO9LN4ngGqChuOB49G92p69I10h6KF/3vN3d9Mlwjkbm99YRd3ktBW2Wbqw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751657; c=relaxed/simple; bh=v9dyh7vGu2dacgwW0mj5cIBOkYcMAu4WL7myCF88UoA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EY0TuH/pT1Tu18/LYamZ/wzmJ/tQPbqI1OLNw1bfOEGmntHb1KZEbDIIsSMYw/3A92u6ZrqbvVPvZUvXq8MSAazEfd5Y+z1W5yhOTF2zVlusfOposce++hQu3L92H9EiTXx3NNmhrtgmRpg+QnkkFB/KgN/2r6U7FMPn/zK1Qko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=psEjhImf; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="psEjhImf" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5e08064b4ddso2800597a12.1 for ; Fri, 28 Feb 2025 06:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751652; x=1741356452; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ucCmymGJlfsI4F5PNnMG7qiqKtfzqtFmwv0m9GhXqKs=; b=psEjhImf2z84Zyymr3jbDWSwcYu5wLvmzNG5Roh6x2DrxXe9THSO4gG6ngM8t8t0rN yDWLM7aqWx8COqo9pvgwZotIU0b5zrL9jSEgYObInU2IafnBc7laTM79iC9aYSxcv2Px lQFUYj1ZD7ZYqeJhwY5xWZg7Qj/ZJ0kDT37yFx6bDwsWMWTLrf9nzHtpke//CQ0qygpO 2S6U81Mi9ZHfpk0YQ4WC4Sue43tVFZLjEXOrzdZJKdM/vtV0uhCjeGu8vWhGz3U+8On9 TPzL+LrvVv20TXxvYA3/GRm4N895UZfD+3tbOVkIuh0Whyq+0nB3IXAtWV0GIZx3ofWu BZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751652; x=1741356452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ucCmymGJlfsI4F5PNnMG7qiqKtfzqtFmwv0m9GhXqKs=; b=t2Y0+v7QlR/xMa/W2iSe87WYY7sp18iXVkNXG6WL/fCZ2O9rPQUMvE9Ph3Q4/CWKj9 BDpIVpSgxJ82cy2ZtAhgyYkGtkgRy8zHfPJT/VxEPOaWzmJAP88YfnlxKa1+yvD92sSn I9Z/OMkq5qQ+B/NVVGroRjNRRMxe+U/7QA1K2jroPRvzzIY+lcntLcFhDEQEab1OV8Sd ZfnQDOqoVwKqUoqEw9AHnmlDpyN0slt7kWHxCgcb1u7vUPam15i2+wOxZgpBAllmWlxh gTv/CqwCzVwewggznp7EIg7uSugDqar4wfoAlo6ebY97Z987dUWkWIHBUPUAkY5So6b5 U7IA== X-Gm-Message-State: AOJu0Yw+gdGPEdSCL1BaLXbldARFmlrGA9sUZvYibUr2aQwuADMH4Nhl nvPXUVGbKgoJ7eKSaTykGJpdflaSkvhzBzH4nfr7Z1Q13LROI17MRLW9heDCFq0= X-Gm-Gg: ASbGncuQo2RGk2QUp2JILUlvh65RBLsEbQ27IzCEi/SrWe5oMRSRoWg8tNarEl409N/ MKxiTxR7V2sIjqFeTXn0s1HSa2AVuREpurO5Lo1hKyVFihluU0CcoYyuUKLPbjLT/61KAcLgiOu 5nLNXDqpdNw+hRRbH9IWXLkdDcjjewwm79yVTqQ1wxw6BzIVmzldkCNfGaG41XH0K78ZM7/JyTs klix0kNq7CAS+jkU0cwtSoPFPoAJ3TCcehiHVrdUU3dMFfURZ3qrJIYkWOKd2+4sNzVc8JvsZB4 B+FP1XX09nTtIMFzraYGLdEsbjc9G2XRLe2lK8kcE26SWRAQajMiBpceQECe22h/6qWA7HBDY7n WOVxYYIBlUg== X-Google-Smtp-Source: AGHT+IHUtKBxx/Kb6wMivayuykLjA27f1K+WzySysSQHyW8EvpaAIClZC0PRyUOpjP+2MS95jX29jw== X-Received: by 2002:a05:6402:35cd:b0:5db:f5bc:f696 with SMTP id 4fb4d7f45d1cf-5e4d6ad3e14mr2592499a12.5.1740751652457; Fri, 28 Feb 2025 06:07:32 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:32 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:31 +0000 Subject: [PATCH 18/18] rtc: s5m: convert to dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-18-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 50 +++++++++++++++++++++--------------------------= --- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 77dd61c30681b8f0a2f23063ad5f7eb52f5b7158..4c66e38145b02638c48685580c7= 943bdf79bfbd4 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -626,11 +626,10 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *= info) } =20 info->rtc_24hr_mode =3D 1; - if (ret < 0) { - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", - __func__, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "%s: fail to write controlm reg\n", + __func__); =20 return ret; } @@ -669,26 +668,21 @@ static int s5m_rtc_probe(struct platform_device *pdev) alarm_irq =3D S5M8767_IRQ_RTCA1; break; default: - dev_err(&pdev->dev, - "Device type %lu is not supported by RTC driver\n", - platform_get_device_id(pdev)->driver_data); - return -ENODEV; + return dev_err_probe(&pdev->dev, -ENODEV, + "Device type %lu is not supported by RTC driver\n", + platform_get_device_id(pdev)->driver_data); } =20 i2c =3D devm_i2c_new_dummy_device(&pdev->dev, i2c->adapter, RTC_I2C_ADDR); - if (IS_ERR(i2c)) { - dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(i2c); - } + if (IS_ERR(i2c)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c), + "Failed to allocate I2C for RTC\n"); =20 info->regmap =3D devm_regmap_init_i2c(i2c, regmap_cfg); - if (IS_ERR(info->regmap)) { - ret =3D PTR_ERR(info->regmap); - dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", - ret); - return ret; - } + if (IS_ERR(info->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap), + "Failed to allocate RTC register map\n"); =20 info->dev =3D &pdev->dev; info->s5m87xx =3D s5m87xx; @@ -696,11 +690,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) =20 if (s5m87xx->irq_data) { info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) { - dev_err(&pdev->dev, "Failed to get virtual IRQ %d\n", - alarm_irq); - return -EINVAL; - } + if (info->irq <=3D 0) + return dev_err_probe(&pdev->dev, -EINVAL, + "Failed to get virtual IRQ %d\n", + alarm_irq); } =20 platform_set_drvdata(pdev, info); @@ -724,11 +717,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) ret =3D devm_request_threaded_irq(&pdev->dev, info->irq, NULL, s5m_rtc_alarm_irq, 0, "rtc-alarm0", info); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", - info->irq, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to request alarm IRQ %d\n", + info->irq); device_init_wakeup(&pdev->dev, true); } =20 --=20 2.48.1.711.g2feabab25a-goog