From nobody Tue Feb 10 04:14:06 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D7D526E94F for ; Fri, 28 Feb 2025 14:07:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751653; cv=none; b=ddXkMAYk0JBq8kQQiZe4qDC+5l4Z6fJ5acNuizdFgI+U0uQRGfnUSABmn+xAsJ7Myh6EF13MvFT5q3wiJHaucqcxqOUnebcw2Rxbs5c/30apkj5KUHjoJiD/cVzLbRQp/9tKmV5kOj0ajh2TpxnYTHyuH8vJ4CmBuja/ndT8QIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751653; c=relaxed/simple; bh=wcWeDWs75X61m+m4siXkgCaNrKLjTdrfe/93knsU6io=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XCmSq+B+TjTv514RuBHCSZ/GUgnxImaBmIqCkfMI/seLnNDl01mPVk+8B3gLKBLXSkzga3kNfMZKTmy7atfjEBTFmnFvCI+zRFSeouzyRWgV5E8N4PFUok3x8aCDWoZIz8fsHox1l5HKQ000odRDT/DOOqMK47PExHNIImKC5jQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tIkP3JAb; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tIkP3JAb" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5e04064af07so3923189a12.0 for ; Fri, 28 Feb 2025 06:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751649; x=1741356449; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=tIkP3JAbCYhrYFOvnjaeq/dbjJ2fYEWvHO8pFId005Ye5HsqEYCJIwTnArTYJ+nei/ u4dh0WqEivGHiSn6n0O94Bj43dMAfp/YJPge5ypbvZ5U6O/CRGd0gAZGDSfiAAdp2DBd UJwJQi4xBfOAy0LCaFCiCDlhEB5iSD1HDyvkUVwXjXVnp5b7cburdus715rG3UshB7Ei IUQq2FhOBS17Bk1MBHasj/xHW1k45r/XWOTkQj0W6eUsDy1Q+jKYht+WmWcxM+t2Ox/M qJ851hynlox9VHT4hhNWZeOm7/OMLBi7cBo4CUKiEaz3dYU5yGF7LqfmhKK8N4ITXdR6 sCZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751649; x=1741356449; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=pqa1aFAu7QIdJu9hJ0J7Y0CFx2OVRuLh0LF6EDAH1R3zWvVB75TrYN1nkhfHhqZwQL ORKm+4RvQ+MEUvXg5SI/6F8e3uUXl1c+0njXv6vzwCfni+fCLoc4OYp13EF92aP7RgbN Y1yOWAm7v8QYNMNadsmngZOfg9a8xiFYlUeGLFbM4tjFIfckr0cHr8gLWloV3zYHZHJ3 Vk6lGaSUaNBNwV1lNDWbsgFVAuL4UJNVcPky1lYoo8qy8ht0akWupdon18yeGdBGX4ub jvF42ykngbnZ/UW0XCZx2tssg0PetOELDW5oFuVuNkKBjD+7H8shH/+LReMCNlGPx0RJ mq8g== X-Gm-Message-State: AOJu0YwNnVhUiqHiWbAoJ2bDGrSvLn5HqF4CT7KeU/cGo3unjCBDRRB7 B6HrxIKNnbQKO7T3PHU8NDtydwlvcKEfvSl27TpnTShX1/rNy+AfLT5PtDMqspY= X-Gm-Gg: ASbGncuNcbOKhRNWBXaXLN3IJVTkg9V9luW//3yIUYXEh4bUEWp6GoYaJlChls89Woa 2qBnxHT2b5GTyQlZB99TyMJ36JWYNPziblRj/XXqd8TSNrSR/XwhtEZPJdMFX3Vx1b9vYEPw9xQ Jaq3A8+evQt1amFekhdoiP0jsD+zjQkpfZBl3qfyrKKgb3atnrKaN4Kkis82gHLLQhmje5UT3jn jvcZL+BBZ0YtUTgVYkq2wvqFKWBAXWl2cgaLd6WHlFxM7O6Vh3ERVL5Dbki85n5qnhbL82GqoBi s8LTaCwW1wNlcHYkTa0/AEP0qkOr62DZM7zHNXH7cGIAEol3c2hl+uDRD8NJLsirBfyI5WqUHtv Jjg4LpLjJFg== X-Google-Smtp-Source: AGHT+IF1zdUSX6ZhtbedenD60jZMcHzIIU2NhAe4k+oRQ6Wt3d6uE7nze1qy/Ap2/A6npGSF7Q9PVw== X-Received: by 2002:a05:6402:348a:b0:5d1:f009:925e with SMTP id 4fb4d7f45d1cf-5e4d6b1869bmr2990380a12.16.1740751648743; Fri, 28 Feb 2025 06:07:28 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:25 +0000 Subject: [PATCH 12/18] rtc: s35390a: drop needless struct s35390a::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-12-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s35390a.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index e3dc18882f41445c41fbea56edbd5c869514880c..3408d2ab274194e39cde38a8356= 7d37bd53f6632 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -63,7 +63,6 @@ MODULE_DEVICE_TABLE(of, s35390a_of_match); =20 struct s35390a { struct i2c_client *client[8]; - struct rtc_device *rtc; int twentyfourhour; }; =20 @@ -422,6 +421,7 @@ static int s35390a_probe(struct i2c_client *client) int err, err_read; unsigned int i; struct s35390a *s35390a; + struct rtc_device *rtc; char buf, status1; struct device *dev =3D &client->dev; =20 @@ -447,9 +447,9 @@ static int s35390a_probe(struct i2c_client *client) } } =20 - s35390a->rtc =3D devm_rtc_allocate_device(dev); - if (IS_ERR(s35390a->rtc)) - return PTR_ERR(s35390a->rtc); + rtc =3D devm_rtc_allocate_device(dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 err_read =3D s35390a_read_status(s35390a, &status1); if (err_read < 0) { @@ -480,17 +480,17 @@ static int s35390a_probe(struct i2c_client *client) =20 device_set_wakeup_capable(dev, 1); =20 - s35390a->rtc->ops =3D &s35390a_rtc_ops; - s35390a->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; - s35390a->rtc->range_max =3D RTC_TIMESTAMP_END_2099; + rtc->ops =3D &s35390a_rtc_ops; + rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max =3D RTC_TIMESTAMP_END_2099; =20 - set_bit(RTC_FEATURE_ALARM_RES_MINUTE, s35390a->rtc->features); - clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, s35390a->rtc->features ); + set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); =20 if (status1 & S35390A_FLAG_INT2) - rtc_update_irq(s35390a->rtc, 1, RTC_AF); + rtc_update_irq(rtc, 1, RTC_AF); =20 - return devm_rtc_register_device(s35390a->rtc); + return devm_rtc_register_device(rtc); } =20 static struct i2c_driver s35390a_driver =3D { --=20 2.48.1.711.g2feabab25a-goog