From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC8E526BDB4 for ; Fri, 28 Feb 2025 14:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751646; cv=none; b=cc+I3R9kaSv9kRwm9sYtEzms4QW20m70pk+PLb3z80lFHYS26a/DewltyHSLgFxhzhTz6u0FVpsbVFaYsYA+X+nKi9PnQdehmGWPv5JGO3Svsjr3PJ4+vercWxDD23OoMWAlgQPXDx4HjlcqwSguXmQ0xaKnzyOtrioQQ3b8pPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751646; c=relaxed/simple; bh=o6iUQpkX2kREXBtqHVFBYq4KM/Ol+6TBK8alsSBDLFk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E3FN4smbJ/LYSRc18LvH4l9pAIGybVV92jEMiu787OE2FvYsGBk4xgr/CkPZjjBxtb4ITyluma+jY/eOCpU7q3CcvVANobk0Ci+SqNolnKfpG2DAnUYPOgoMk6haUx1DBVigjJLmgUGxU2+kaunwNaUwBWuxJYy1kUNrOAeqY0o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=i03efqjn; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i03efqjn" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5deb956aa5eso3239609a12.2 for ; Fri, 28 Feb 2025 06:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751643; x=1741356443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PxV5ubkQILRDTTOOiWiVBaTKuCWcjZ1klG/odToLNLU=; b=i03efqjnlFkObHW1ztwNuqWMePtLs/sq4dmV85pqjRtrRv/6u5zjc3+7LF9N6rvm3D VgUAuMNZCVN2aFvXztpaWFFP6KTLbP292+FHSHhqP8+lbYjhzwIVbSTznR1jePgTeQf3 Xxv3R/EoiFGazGdfUiQXPOq0KgQi7g6izTyHExGklTWZBRp2GjxYsuYqjKIVpz6KU0jg FAk+qFERo+crftlurfpxbBl/JRZqV5Uabocq71zI7Cb2v0M0bUQEHeDAXjmgW8h+/nNU m4kdI1wUlFu64hozU2n29hXURoDUgiVuiisr9Nnt5mdj7Et3JhuyXmsjFzFhCbDmcD1Y bsCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751643; x=1741356443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PxV5ubkQILRDTTOOiWiVBaTKuCWcjZ1klG/odToLNLU=; b=SHH8Nz2xdFroLMfWNPDusPndz2rxr96pVBc1jCD8n0t1mmQdnaeow9njATBY9cxWUI VfLHXlKIknKRABDuhGtRN0Ljc8I+OQwETVHritNGJuk6MeQfV49q4ob16xoU19BWKPLk G+EGPDJ6JsVc1pw7PDwwolVBch+niwoWsSGeXfsJ0w6K3AT0ESjemLCY0lLcav7Abbxn 6RW9eiNGfHaeZNLdsugOFo/GQ9GSio7I/dOgjPwnjutCw7uNd5eOpoSo4AdR4tKvgPyd ukBQolLO9fCPODHaXpBtItPou9PMriybSsx1X1Duq/eENCQpGRnUSeUWp7EJu7iyF9Nn ATkQ== X-Gm-Message-State: AOJu0YwlbG5HuY+zu5wMXFTppV1R37/02cXrlFtQRRFI5Q8jmD5X3COL kCFP8C49LqnzB5XQ6x/WRt/F+nKWTU+8x2MbXtMsnjxjXR4Lon8v8K4SN+B12O4= X-Gm-Gg: ASbGncuRDc2dnAHIhkXJiHV5WQn5jQI8Dy559+pFjG/Z/Vo6uemllSrSmjnuAYgOfrN lez0gSkvC82kuS6aOSXICpWDhJm9xh9xl23frPI0GhHxm2cwvhM2VGm70Szp9xZ6kGUXkAfJ9aM uTPaxkmzgEN7HVfAgH3FKZq/95g9js/amfjzsZce8YuZZ4U+jjZV2A1livGxMe0wWJOnWZi/6k2 o8ufm8baqjQuY/xUX+dEmO3p/ev+bM9dtUCn7vjJtC9vPAvRLkvnneUgdS4ERw3Zt9VbTCHiltT RYS3cp26QPpG7S79kL6e91io+C7kmaPa6iAiXTxSf7cP8ILGPztyG+6X5EwwtjepxpgAessUBZH 5KonnYNbIkw== X-Google-Smtp-Source: AGHT+IFUL7DUuq/VqTU9dmynPShF+8aK2RXF+k+UR0pl4bWqZxWvS8VoSsjq66EWlcydyD7uTG7tww== X-Received: by 2002:a05:6402:1d4d:b0:5dc:796f:fc86 with SMTP id 4fb4d7f45d1cf-5e4d6af436amr7325207a12.16.1740751642551; Fri, 28 Feb 2025 06:07:22 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:21 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:14 +0000 Subject: [PATCH 01/18] rtc: max77686: drop needless struct max77686_rtc_info::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-1-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 When this driver was converted to using the devres managed i2c device in commit 59a7f24fceb3 ("rtc: max77686: convert to devm_i2c_new_dummy_device()"), struct max77686_rtc_info::rtc became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-max77686.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 7bb044d2ac25aeaaf2404b47b7e7bd485ae3d39e..6b0d02b44c8097453f704cbec9f= 02580fb869ca3 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -85,7 +85,6 @@ struct max77686_rtc_driver_data { =20 struct max77686_rtc_info { struct device *dev; - struct i2c_client *rtc; struct rtc_device *rtc_dev; struct mutex lock; =20 @@ -691,6 +690,7 @@ static int max77686_init_rtc_regmap(struct max77686_rtc= _info *info) { struct device *parent =3D info->dev->parent; struct i2c_client *parent_i2c =3D to_i2c_client(parent); + struct i2c_client *client; int ret; =20 if (info->drv_data->rtc_irq_from_platform) { @@ -714,14 +714,14 @@ static int max77686_init_rtc_regmap(struct max77686_r= tc_info *info) goto add_rtc_irq; } =20 - info->rtc =3D devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, - info->drv_data->rtc_i2c_addr); - if (IS_ERR(info->rtc)) { + client =3D devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, + info->drv_data->rtc_i2c_addr); + if (IS_ERR(client)) { dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(info->rtc); + return PTR_ERR(client); } =20 - info->rtc_regmap =3D devm_regmap_init_i2c(info->rtc, + info->rtc_regmap =3D devm_regmap_init_i2c(client, info->drv_data->regmap_config); if (IS_ERR(info->rtc_regmap)) { ret =3D PTR_ERR(info->rtc_regmap); --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CF5126D5AD for ; Fri, 28 Feb 2025 14:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751646; cv=none; b=kEXF7VQFnf8nPw+I/L00ojia9znGoXgSI0eErDlvlS7jdxI3dTLnFFW2MupLkbH6c56oSqtxO+LpYnL6/l1hsKRRCMFH4paGu4jP0EjHqwXZf3882LhSbnZoVSyIGHwtMeBhZxuAOw9/CLyQ53F+KrytC0oSPy6o3KWrQ238Jg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751646; c=relaxed/simple; bh=YYl9m2BnndcCMYaFzMLWUSCBfr0DlXeXEgFndcdua9E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lVkO5OmiXqelxVUezxm5HmZ16DGrRyQnzt/vTe8LT+YdGexdZx/tRuHrLNkudMI0Ka0CRXt8GpKj/wGAyXIiviQ5SBMVyFPCZVpmvVo1NeI4FtOvc9ozrHQp4OOqXUKv9gzWuKdYBRf8lWmTvsPb41eIn4e9vIl/OXztCHGtZFc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FWSYZCEa; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FWSYZCEa" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5e0939c6456so2923100a12.3 for ; Fri, 28 Feb 2025 06:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751643; x=1741356443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NEusmS+5iWAG1jDnjFt/eyKJ89b8w4e+6UytiCX0MQA=; b=FWSYZCEadyU8vj+pOdi9pSaK3qhDb0DI4SvuPVtjfjAN5lOFDiPpEUdNMZ2yKCrCRn XCsoPymSJT6/1KXGy7qXM9YpN+9bX0BkcbuJawYWUjvDgdkf1V9mn/OpD8JcQiEX1dzh l9BMqalRG+AtTZFpjLKPCs6AmJsJfVZ62z+eyXcgzuSRGmEnRHdPP2eeDVgvOvZr3xMy wfdCsQHPpVt3oH6b8rXf6rqiE5YaM61GS3TCBDeDFFySy7l2Fa+mq3GQuEmdIg7vPoMZ EZ4sb7BzTtmF4AwmWcoUZ9F3GvQYPMVuhD/QOxy63cMX2iSmfIRnDVy4iHop7gFfmDQC E+3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751643; x=1741356443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEusmS+5iWAG1jDnjFt/eyKJ89b8w4e+6UytiCX0MQA=; b=hFQD4k/DqmalTmsL386TCvawxFdZepB3qvL3JquebQ+yoP39dPp90Y2T257XLmhRbL cb0oe3CMXNdq4Yaws4QWb7VWrsSxPDZMFRtLGORTgtJRitp6Vp4g+YOl3nbyk5EwdB2b 4XJkzNArDvgVP29moIXRsz476CV3u8u7zzuBwv2KVBSWoN9CJyjcxIgA2cfJ2VCmgjUi /OBO1YqgZogi1NenFaG3Li5fAcW2qBUquOqh4nw3JWTDJaJo/14vgfEnGSMt5VaIQYOa o2Aj01avc38MglZ6mSw/5W9/6NFrNAsttdbtgdQX6ZnXy2/cldMw9wU2yri6cpc0fb+j xQfg== X-Gm-Message-State: AOJu0YxgCu0agPADMLXu1A1yxrc+sUErpIDjIHZCw9fYp+zuM1kScsHR 4eZYToWGYQS1DNrjRwGMEYjN5tnNHvv9NCkZ1wp1iBcN4CA3zvA0JX1dUJp18U0= X-Gm-Gg: ASbGncuvK7SDj6Y10Bsazia0/4MH7pY33porRgSDkHhLWJkGLowsvMohuScTxf6A9bC 5ZuppMJAgBPOp6R9jZcxWrJeHIRP5jj1xW13jlJOkeGJdLVl9PMaOJhxgkTZq84XuoG51D2lJxe GXlf8RA+Zgx7N9obqSaq94HhLZAFAGr9F40bmt01qB3g2XpfvT1PTpx3s0nSdf1FbOc8ozkAFYO QZ3FyK8XBZbHaJR4BLnSWKGvlXdIvRPvJlwok/uncQZ53MKbg4yBIJrtj7hqz0Am4jZOsknsQgj upfwLuvMXQb2CXj5qqjq901TFhljkB7WrW85e2iFRh+uN7RDNQxaBWPHg5xDfOTd2i9VzFuOKTL zgp1FsCngYQ== X-Google-Smtp-Source: AGHT+IHzPJx5i3RI7O2yaVdHtPJ0az692A2jfkouiK94jhHcaAYqi/2J0zpg5aMdk74cXIZT8BcCug== X-Received: by 2002:a05:6402:42cb:b0:5d9:a54:f8b4 with SMTP id 4fb4d7f45d1cf-5e4d6af0565mr2697422a12.11.1740751643440; Fri, 28 Feb 2025 06:07:23 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:22 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:15 +0000 Subject: [PATCH 02/18] rtc: s5m: drop needless struct s5m_rtc_info::i2c member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-2-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 When this driver was converted to using the devres managed i2c device in commit 7db7ad0817fe ("rtc: s5m: use devm_i2c_new_dummy_device()"), struct s5m_rtc_info::i2c became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 36acca5b2639e272dd9baed06ea5582f635702b0..77dd61c30681b8f0a2f23063ad5= f7eb52f5b7158 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -146,7 +146,6 @@ static const struct s5m_rtc_reg_config s2mps15_rtc_regs= =3D { =20 struct s5m_rtc_info { struct device *dev; - struct i2c_client *i2c; struct sec_pmic_dev *s5m87xx; struct regmap *regmap; struct rtc_device *rtc_dev; @@ -640,6 +639,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) { struct sec_pmic_dev *s5m87xx =3D dev_get_drvdata(pdev->dev.parent); struct s5m_rtc_info *info; + struct i2c_client *i2c; const struct regmap_config *regmap_cfg; int ret, alarm_irq; =20 @@ -675,14 +675,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) return -ENODEV; } =20 - info->i2c =3D devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, - RTC_I2C_ADDR); - if (IS_ERR(info->i2c)) { + i2c =3D devm_i2c_new_dummy_device(&pdev->dev, i2c->adapter, + RTC_I2C_ADDR); + if (IS_ERR(i2c)) { dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(info->i2c); + return PTR_ERR(i2c); } =20 - info->regmap =3D devm_regmap_init_i2c(info->i2c, regmap_cfg); + info->regmap =3D devm_regmap_init_i2c(i2c, regmap_cfg); if (IS_ERR(info->regmap)) { ret =3D PTR_ERR(info->regmap); dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4C2B26E166 for ; Fri, 28 Feb 2025 14:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751647; cv=none; b=MEYOkKCz3H3t66zh/ovPpFaUjhqA0WQsbQ+U093PfEd2BsNW9K0pW/iHKObvD/AhZoFdAetqUhKFxwfx0DX0dCdrTGV9Mn+0MRn9n5yxb+rz7lKgbiapt9cxMR/W+sijAinNKrQV2dCUVfwcWHyRKRT8gtOg9+vDkAyLxl748ng= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751647; c=relaxed/simple; bh=ivQXoPCDvr4W65W9v8GXK5+RniJhnQQTUBGH5MrKnmo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KNBcYFDLiK6NdZCYPB72jriUCd0DmWFLTV6TlRGxo/nmFQB4ND/YdifEGr8B7GQpijcb5LzPhWGrShn6V3BwkCPau1AnSDnoDWRuFzvuXgxYLvX8TyhEMUKRLvl2nIgDnlEuISrO7rXL0h9Dh+Mm5FVxKJ3ugfAxOuqOiN+98NQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FPyRRFEQ; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FPyRRFEQ" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5dedae49c63so3851606a12.0 for ; Fri, 28 Feb 2025 06:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751644; x=1741356444; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=FPyRRFEQU31TIcx+DX4zzOdOpzaJ1Oaa0XMP0rD4nenhV8jOMuxWuTzyyad3e2NLb7 +ZEZI6rzCTA3AWBUGtLCg2WeqOoy79RQk8HjEzw5HJpxftDaMgkDze2+Ay5i51vBVM7f Dwvjk/+ajfkXSxJ4FEDpMNikjqliV4y935iv0CNGoZx4glfqqdyDiKDtNsA+jN4z/M9a ph3lZNAw+5X95JZe+LqJM0t7n1lUnfXSVPfcG10pGy6ChMzHJYhZgYjZHrvSCbu6uZPS sTgsHZojZiAH9NUyM5bRzr+CzKNqHjSfYfybIljX+hI4bysZoJQp05zFm1bMR71zVn2G rnlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751644; x=1741356444; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=wosxfwns0PE2s7J4OVMOaYplc8sPF0r/noLtG76+cfivOCQRi6pSZOU1FW+oVgYr4f A6w+QgUfYEohlha3A6b1xPDv4nQgrc7q4MwawIyjhoe0Z//aFqkAgoMhGANqn/j9oXhB dju3hXq3OW3jzuDoGH2Iz8yIrLu3zR4ak9Zu55vI4wtGBjkJTL4q+IY9rr2JiMyU7oE4 VoS6vE14zc/lPS3ZUgpKlcTN0KoeID7vzXfSaVLJMEb561U9tO7iEFSQHpBu5gyR8Mzn hc3/MJZJ/L2fTRa3kyGL0VZRiI513hHqg45SODMQrH4b20hcMsGMOYthBKb6rOFZsGIM KvAw== X-Gm-Message-State: AOJu0Yykq0JDSEKYRfEQV5siTTMgLYTiZsDHTwoj+soz3UDJ5IX4sDuY a8CeOT0zOjAWUqLQgKHJOkerf6kuCR/LuUUDSZSoqqe6yJnHfodsDyrpyFrQmaU= X-Gm-Gg: ASbGncvb6Qtotr2TA0tVD3zaCoJeCPhM2OlQeNvYL2iA7S0rfOAAFntQp4ore5Oh/t9 cY0IOHyaSFpPILGYHhVv79UlXaCHtP6O6vqni9hjn7mZNhn2E+QPX3ZGynDga0RTGcRx67Geu6p XlvF+NPWDonR4uD0FHPt58IQn/sOiEuaN9SJBRTR/6kVFVVVVEMdOZVQlder9KVsvvkVgdEVsLh j+v1WrO3TeFzf8yd9hgJkRFRK96/ODZYmYzuNPVtegPwj7uqyWone+IWYl9rOpWA6x+NJ8che1C SZ7O9gxjQAQQEmPXATUBruvvrtEJIH1fBsDygdLOkBzcUkeOqGkN4RorI05Pw/T7DKEky2/PQHx hxHXfKMXNIg== X-Google-Smtp-Source: AGHT+IESLHMD1ALp0fl5UNtQkvu55XFyzsWGAW2ARn4G0KwygGU8Ail6xNyHqVhAMNH9i4466iKXaA== X-Received: by 2002:a05:6402:848:b0:5dc:d10a:1be8 with SMTP id 4fb4d7f45d1cf-5e4d6b0e6c9mr2959043a12.19.1740751643974; Fri, 28 Feb 2025 06:07:23 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:23 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:16 +0000 Subject: [PATCH 03/18] rtc: aspeed: drop needless struct aspeed_rtc::rtc_dev member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-3-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Andrew Jeffery --- drivers/rtc/rtc-aspeed.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-aspeed.c b/drivers/rtc/rtc-aspeed.c index 880b015eebaf796f68ed82c29998f345e1fd418b..0d0053b52f9b90a61725bf29435= bfc8071977f9e 100644 --- a/drivers/rtc/rtc-aspeed.c +++ b/drivers/rtc/rtc-aspeed.c @@ -8,7 +8,6 @@ #include =20 struct aspeed_rtc { - struct rtc_device *rtc_dev; void __iomem *base; }; =20 @@ -85,6 +84,7 @@ static const struct rtc_class_ops aspeed_rtc_ops =3D { static int aspeed_rtc_probe(struct platform_device *pdev) { struct aspeed_rtc *rtc; + struct rtc_device *rtc_dev; =20 rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) @@ -94,17 +94,17 @@ static int aspeed_rtc_probe(struct platform_device *pde= v) if (IS_ERR(rtc->base)) return PTR_ERR(rtc->base); =20 - rtc->rtc_dev =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(rtc->rtc_dev)) - return PTR_ERR(rtc->rtc_dev); + rtc_dev =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); =20 platform_set_drvdata(pdev, rtc); =20 - rtc->rtc_dev->ops =3D &aspeed_rtc_ops; - rtc->rtc_dev->range_min =3D RTC_TIMESTAMP_BEGIN_1900; - rtc->rtc_dev->range_max =3D 38814989399LL; /* 3199-12-31 23:59:59 */ + rtc_dev->ops =3D &aspeed_rtc_ops; + rtc_dev->range_min =3D RTC_TIMESTAMP_BEGIN_1900; + rtc_dev->range_max =3D 38814989399LL; /* 3199-12-31 23:59:59 */ =20 - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); } =20 static const struct of_device_id aspeed_rtc_match[] =3D { --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4E5F26E17F for ; Fri, 28 Feb 2025 14:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751648; cv=none; b=CGh7euax5BdWjfPwN/bllDo0VP8+ozg3tzIQR+OCP6Fwr2cfFsfAfcA+wembTg+ZO3ulE5B4a1zaVl8wgj4y9M387jaXlIJ7P9n+ZDMy8Ga2Q4mCRdvMutErE3cSc33nVSCibOk6DrYMuFcGxdZS7RtMOesWtW2dQ2VQchFhSvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751648; c=relaxed/simple; bh=ako7uKkoy0pcKOqw3JaomEgmXiZMMPwkguXI68dLj6c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eUY5LuuFOVUbW3PR/K1fAcIDLh1iYaOFUTISlNWEAshe4Rhcty2MrWcFxHtyQfPIDqTgvuzYaQ4zDdnjhSZ/3weAxghfgZXURNLWV2DeJyIEz7n4rB3MLGId7Wq4iswKtIkIt0IVMcfG6gKhBR9ZTn0ZJCKGVG/7GAjSiSGsKf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=duu4VZEP; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="duu4VZEP" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-abbb12bea54so401343866b.0 for ; Fri, 28 Feb 2025 06:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751645; x=1741356445; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=duu4VZEPZ8sGv25ffQJ+1bdz7r6wTagwsUflJFWNZhlu4PyYNBlvdwtqL85JQZ/66C pnbLUZCNHKvbwF4bHYLVonu4tX5SPwbXrV3IIKNh+gQOpW+EnMFnxjekQtQY0ww9WTJp C6tIMdiC7L9O4aTkd5mgj5wQlb+dVsbMdhS5fYVFma2u7QYSM1+0Kn3DNjRHBA8lA05w JH3gd5VC3kH3Vy8wRRS2CXNIPeqL9yBhk7EtAFoxQO/I+uYTKe3wXMsfEyIpCEQpXeEn Mqf+frzpnRT3kQBZ5+LEdVv+MeqIquLzOd4fT5q6LHiZKaReub3O2fC7RrV8a4M8Z+D3 P/Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751645; x=1741356445; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=oe8fy+BKyGtQACaT9L+SCwYIgh2U3/mjOULmLYbJuE8iutgNcfNlTrOZHFkLCROpq6 ZO+prs02CXU3gvh4EMYZlvxIfr6m8T2X+uVTGrLx1Gpznfd5dEv5oLyrIWvseVOIn6zR 2P66OsoHeij8BlsAGma+tTFDBxr/cwPYDN2oP5LWNJ9sGCq0JcnuRlSQ3nNUkEj8n6Jc l9I6SlkuZ3oa0uYoqHzHKxkEIIVXv1BkzaSL/4cHrSM4gbq4tHihODC8zhJV3K7zVzyN nN6OPhe2nG/Fva4atY86WCSEnhareJp5QmWLt5D8BY8Oe3vluOiK6jnceeKg5P7PnQNG rG2A== X-Gm-Message-State: AOJu0Ywy0urB1gG2YZQyCHwq4q1yrSvmUw1PBxBpEqneLBRLmJiE1Dvw iV8aEvLBiTYCT8mRC6QyxQeAWPLWgO4CEVa7dIj0zwG4D9snBZX5uED4kflBHmQ= X-Gm-Gg: ASbGncuI0uv3SpuEZ/DrlAWT8U5pHL/MnEAZA6uQEHvxS7ASyeNBnjDPYiy+1X2Fw+1 nK46aWTcq1nGi0H8aAWoUFCXz9x14fBrwN41KkH2F7/aiqHMXg3s0vJFdRzFwslMACDU8H6ZHnU MuZ8nYKRH3DplHi/zoD/95AZGwAtrxoE9qg3ACRUvY4UOkv8k9K0sUo2wTxivCO8lJWjSyhg4f4 BRjwIR0Tx77+SMySbEdfWkjnv/trVE9hWZYvY1TrKukMwu+6uM9rL8nGLuppfhsh4+Ca7BSjvfk wWXXa8W0iRu3owZAVYfiQNh/r+juNtWQcvwZ29csu8ZkO/CqpD64/BwIpfcvIm9JEfpvcPolvQR k7moSIkp/nw== X-Google-Smtp-Source: AGHT+IFpdib5eLXvAKlYp3fUyW87rQ1IfZ8GEMoJsXuLGkDw56XS2aTZMwaUmenZ5apuVJAYF/Nggw== X-Received: by 2002:a17:907:c018:b0:ab7:fc9a:28e2 with SMTP id a640c23a62f3a-abf2681f8f2mr377695266b.47.1740751644708; Fri, 28 Feb 2025 06:07:24 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:17 +0000 Subject: [PATCH 04/18] rtc: ds2404: drop needless struct ds2404::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-4-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-ds2404.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c index 3231fd9f61da49bdaf00e46486fc34836094ee78..217694eca36c3432a8db3b87437= 4e347eeb802d9 100644 --- a/drivers/rtc/rtc-ds2404.c +++ b/drivers/rtc/rtc-ds2404.c @@ -31,7 +31,6 @@ struct ds2404 { struct gpio_desc *rst_gpiod; struct gpio_desc *clk_gpiod; struct gpio_desc *dq_gpiod; - struct rtc_device *rtc; }; =20 static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pd= ev) @@ -182,6 +181,7 @@ static const struct rtc_class_ops ds2404_rtc_ops =3D { static int rtc_probe(struct platform_device *pdev) { struct ds2404 *chip; + struct rtc_device *rtc; int retval =3D -EBUSY; =20 chip =3D devm_kzalloc(&pdev->dev, sizeof(struct ds2404), GFP_KERNEL); @@ -190,9 +190,9 @@ static int rtc_probe(struct platform_device *pdev) =20 chip->dev =3D &pdev->dev; =20 - chip->rtc =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(chip->rtc)) - return PTR_ERR(chip->rtc); + rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 retval =3D ds2404_gpio_map(chip, pdev); if (retval) @@ -200,10 +200,10 @@ static int rtc_probe(struct platform_device *pdev) =20 platform_set_drvdata(pdev, chip); =20 - chip->rtc->ops =3D &ds2404_rtc_ops; - chip->rtc->range_max =3D U32_MAX; + rtc->ops =3D &ds2404_rtc_ops; + rtc->range_max =3D U32_MAX; =20 - retval =3D devm_rtc_register_device(chip->rtc); + retval =3D devm_rtc_register_device(rtc); if (retval) return retval; =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B6F26B96A for ; Fri, 28 Feb 2025 14:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751648; cv=none; b=rPcn3sRpQ5bzJLg6tUWM3gSgtVtVwjVy8DQDwX6/cbP2yfh3PFlOf7CpMz0b5lZICu0mGMjcAHzDQk0ueEPVpwW0OKIP7dfAtw3yfDqgHGUski0NtMSpmZciZMbWZybc+zimYizGH+AckYg/iFgpuLYZgGKueLkr53e+iV9sRQI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751648; c=relaxed/simple; bh=bdvX1BNhSG2fpjHo2VIxHhZrYGN28llP3/MopMlEtfo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yn8bETLkjeLhXnBGnMGFhWv5Yw2HgtEPeScqL/MEnkU5OjEQuVLlgpBOnjhgsKaiWwSVWfBIZMdrN1NSbESFXRIBcfEUpYxeRUAtqMilnFmmKGnbt4JurYAJOSAYLwDCcY9DKqL/eoDQomIHES2DDmRYu/viqMr8XbGKGaBPubA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aHZl1Ad4; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aHZl1Ad4" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5ded1395213so3473751a12.2 for ; Fri, 28 Feb 2025 06:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751645; x=1741356445; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=aHZl1Ad4ompIcur2hu0an/nxVD3UiTx08uuAx9RxwiUJSD8uNxXGbECXAZKfMIlMsl fuca+nN4dNQzmapwQI2U9IskXO9UIKHA+UDiOBXfn0chFNjjStaUEgCJ9r8rJxS3Dv+m ivtjvL1oK5v9Jg+h4GQFt0ZB/gBHt3UH7ZS25VsqpDPKwv8QkjMrszryqKZAAZZ5Soxj pBqCwMEODoNSRthPKRw1J1F2jTjiGy0V3Oss+LvVfYZnBRfLLLagqml4pnvoApOvIsyL gCz3YqCCdN3rIyQ6hoyMUAUMKlBoJdEGZPqWERrOfU0uMRuce5FnJ8U9hesUpA34Os1d RHVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751645; x=1741356445; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=thcxcAQBUbz9EdrzbSOQPWzlZvwDnkaRcg+6es1o1w+0fvqWCSp1RZxZAEitBB8gXt ZCXsLY9fK/Az8NBfKFm9MahDE1LvtVFQ+VdyndxOCNuH6DZ0zcO2zwjN2WLzjGR6bsbj kY6cX+B+k+Q6svmPJIo5elYbqUGVdyFKt1zrELaM/mkw7A6fzp2vz+7m8H64tZP/Pzmz BqAtqeKc/bHceHxm12OvZjhHIFV8lZ+cZXP4fbkuagnsj9w8ctaewRBhyEUcagp/zBDK 6XmAogU1cn34I0ECQnVdJiHOx3I0ZbgNNdiXlG/Ha3c0T0pXGgmsdZdkHC0C05Dsyn6S ya2A== X-Gm-Message-State: AOJu0Yw8PXn7SZhepdEzAEDJiFZC2NNDBTCmogRGNpkBxZ+VpG0T+grw QWyE6NEQKt0S+ctqCOlIE+XaDnxm4Lpgc8ERP8J6FvxRR6IdTnQfFew8UDvwnLQ= X-Gm-Gg: ASbGncsPc0Xutm37QYYctGKcNYzo9L3fr11OWbBo/0zxyXrOtGV4K4uD3KyFTB7JwFX vgNcsvcX06eE6HrrWUuiv7Q2hQYkDVg6O7jU6+eCnsvvNvHweEchYy7iZ9AFtl10d/XfUmk3LMv qI0Vny/HHPyeMyFM5eHSFqt7EI30plvchq0kgq4EtAopsgNdsxbGABz+o5iM9572LXtQnZL1ITu /LXIRXqMKQBdun/gJ5m6u2ggyvCVVxSqAILfvlSI5hgi7BkNReGkqjWE1lG7OeRr6K2jeBvouKP MIxMB1KJ1/0BtqJ2ZfUOZp+0QE49Io1a2soCK89JmK37Um5LXHJ27OJksNco5bLHZgwi6Yr6xpN D75TBmBdjPA== X-Google-Smtp-Source: AGHT+IFjP5A5it0oOhAqjGMiq+zBlLn6/wyStXZ9TEpg3CsfQx18Ux73fzaAw5ZlIGleu7roV3QB1Q== X-Received: by 2002:a05:6402:84d:b0:5df:5188:11cc with SMTP id 4fb4d7f45d1cf-5e4d6b702a7mr2552045a12.20.1740751645245; Fri, 28 Feb 2025 06:07:25 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:18 +0000 Subject: [PATCH 05/18] rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-5-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-ep93xx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-ep93xx.c b/drivers/rtc/rtc-ep93xx.c index 1fdd20d01560ef4fae2b996cf366b4f812329225..dcdcdd06f30d1ff6d0939f6bcad= 2c17c03c5a65e 100644 --- a/drivers/rtc/rtc-ep93xx.c +++ b/drivers/rtc/rtc-ep93xx.c @@ -28,7 +28,6 @@ =20 struct ep93xx_rtc { void __iomem *mmio_base; - struct rtc_device *rtc; }; =20 static int ep93xx_rtc_get_swcomp(struct device *dev, unsigned short *prelo= ad, @@ -123,6 +122,7 @@ static const struct attribute_group ep93xx_rtc_sysfs_fi= les =3D { static int ep93xx_rtc_probe(struct platform_device *pdev) { struct ep93xx_rtc *ep93xx_rtc; + struct rtc_device *rtc; int err; =20 ep93xx_rtc =3D devm_kzalloc(&pdev->dev, sizeof(*ep93xx_rtc), GFP_KERNEL); @@ -135,18 +135,18 @@ static int ep93xx_rtc_probe(struct platform_device *p= dev) =20 platform_set_drvdata(pdev, ep93xx_rtc); =20 - ep93xx_rtc->rtc =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(ep93xx_rtc->rtc)) - return PTR_ERR(ep93xx_rtc->rtc); + rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - ep93xx_rtc->rtc->ops =3D &ep93xx_rtc_ops; - ep93xx_rtc->rtc->range_max =3D U32_MAX; + rtc->ops =3D &ep93xx_rtc_ops; + rtc->range_max =3D U32_MAX; =20 - err =3D rtc_add_group(ep93xx_rtc->rtc, &ep93xx_rtc_sysfs_files); + err =3D rtc_add_group(rtc, &ep93xx_rtc_sysfs_files); if (err) return err; =20 - return devm_rtc_register_device(ep93xx_rtc->rtc); + return devm_rtc_register_device(rtc); } =20 static const struct of_device_id ep93xx_rtc_of_ids[] =3D { --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD50E26E944 for ; Fri, 28 Feb 2025 14:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751649; cv=none; b=X8EHrhzzhr8CnYzcq1wPfTJlBrVngJDhOJc0ZJPue28k4r2WdCmlLVO4PetGWKFKl2BnPrpTUpPRIY8norts50aQg3XqoXSf218bgfoPW+VD132jMtlx4S+mYQ1xsOSot/sU/uFDIdbxvDm8yXlh/B2ZySUwuXHM5Grydqj/ihQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751649; c=relaxed/simple; bh=azImvETECVTYyY5KXb802HXF74Wu6H0CLseigJQDz6M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SRNpcCAXpNFUK7snps/lEsrx4Xeb8JMlXjm5029vbTRyS7jqfN5gjWoU5B5d0/umRilahZuHpCPBpjlIy/v1kcFwthP4eFvAJ1GV7a6MXZBcQf8xYTp0Or43tIibsJvm7eiuotYihWvtOZ9ac+iPdTtLqzULs2BPaxj6iwKc+mw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KUm45hBS; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KUm45hBS" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5e4bed34bccso2990138a12.3 for ; Fri, 28 Feb 2025 06:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751646; x=1741356446; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dZH0eiBnc3WyY94yEis5FUZqmpsbyvfcyDb3myV5OX0=; b=KUm45hBSiK+cOQntUo+C892Vma7NksHS15MQ/7Rb70GXDkU8AOTDBFW92xIPM1zjxd 9BDRlhLKYxuLNm9gMy9kaqfIahZz26XjmpSeU7Cr/qwqGB+Kj4Bwmu3pAGiYxcXDRbzW PqFHrNvlhbg23xkM1K/zspwuUzFibcGMxBwCjBv5EFDZx+uacAOqUyZx8smqAxTUOEiD x9jhOx/apK+D5stAfw0BuwP7rm26iBBsf5sc4ObUf8Se4fzaR67ezcz8tgkonZ0ZefFA tBk7gTlICLb3HLF03NmV31iTwfj2VMkaZIBMleecwdpycrlaaNl1HndtpNUeEzYcTpw5 ugiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751646; x=1741356446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dZH0eiBnc3WyY94yEis5FUZqmpsbyvfcyDb3myV5OX0=; b=XFZdfekbkH6nfl28u12guMIqtnqYFlmiAzTp1Jdde9Uodx6eV9+fglCtjXJ9qYQhXU 0Utm+zUjExy+jL8agxWPNpXhDbC6xi8L97Q47PXLPu09sN8SvyluaUeWdFw+KzE/vUVG e1hukcFzR9t+IMqeUpenGcFn6O9FEbeUWMdqStUFFXALanDQAJMVaH2DORvrpS7Ij0UI 3M7DufsI0ITEfXCrY2Uyel4nj4jYFxzY1BSUjIw06gipgaT1rRjHT3nvnphi9DamD/Jx pHLESjrO2ERvzUEC9Eq2YNk7EG/ciBXbTt4PVcIuu/SMRgI/QEskXePkGkLVU73Xhj/v TwZA== X-Gm-Message-State: AOJu0Yynafq7T13QCaId/6Tq7rqtZjhKNR+xih6rsdFSTtfXOyXyYToj a3+ApAxlvfeb+FV5NZlXsYpxL2NEug2hJxOZeSb4Yy5CBv63oEyJvvwfmt5VUDE= X-Gm-Gg: ASbGnctfEKDnyebBFzPmRetD/iUo6lB0vdItl9cjnAn0GGv7IWuBUe/rOilfwQQ6CjQ VnMP/4hg96aTTWI469af6E2H9LvkgHcw2aanTwb+Rs9PJvnfhhyUKevaGmOJIx5fisdZmrrtWWI Qm8xVtSV9PV7j5jGT09VNCx44/GgfKRf9/QdVgw/LUarGJBV1ObhXFtAIOkA/1hDIWSfr/tOR8I tPTFD8BDILC1EA2QS0V3vOiv+AOHdIS0pVrWExSdnNd5BE5tYjqyWBOQw68QerCO9Mr5+tmq+Il 99+atiIhQ45fghghw+FhiR8yCh2D+9L/JNQgLn1PYqfP/8cnGADdndXkxAHVFNZvQuNE2kJSB9U EPHLpXFaiuQ== X-Google-Smtp-Source: AGHT+IFbzXWayjdSMfWjy9cwjYueSFy4YBp7IQ8OjzR2IKI5f4QLOeDnV9cvNi5W4D61UevFMTrZwA== X-Received: by 2002:a05:6402:239a:b0:5e5:552:32a8 with SMTP id 4fb4d7f45d1cf-5e5055238efmr931950a12.8.1740751645786; Fri, 28 Feb 2025 06:07:25 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:25 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:19 +0000 Subject: [PATCH 06/18] rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-6-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Linus Walleij --- drivers/rtc/rtc-ftrtc010.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index cb4a5d101f537e20a685bb022e6f6516b0df8271..02608d3784958e69ec0ecbdb9fc= c8b333b19e7cc 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -28,7 +28,6 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:" DRV_NAME); =20 struct ftrtc010_rtc { - struct rtc_device *rtc_dev; void __iomem *rtc_base; int rtc_irq; struct clk *pclk; @@ -113,6 +112,7 @@ static int ftrtc010_rtc_probe(struct platform_device *p= dev) struct ftrtc010_rtc *rtc; struct device *dev =3D &pdev->dev; struct resource *res; + struct rtc_device *rtc_dev; int ret; =20 rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -160,29 +160,28 @@ static int ftrtc010_rtc_probe(struct platform_device = *pdev) goto err_disable_extclk; } =20 - rtc->rtc_dev =3D devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc_dev)) { - ret =3D PTR_ERR(rtc->rtc_dev); + rtc_dev =3D devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) { + ret =3D PTR_ERR(rtc_dev); goto err_disable_extclk; } =20 - rtc->rtc_dev->ops =3D &ftrtc010_rtc_ops; + rtc_dev->ops =3D &ftrtc010_rtc_ops; =20 sec =3D readl(rtc->rtc_base + FTRTC010_RTC_SECOND); min =3D readl(rtc->rtc_base + FTRTC010_RTC_MINUTE); hour =3D readl(rtc->rtc_base + FTRTC010_RTC_HOUR); days =3D readl(rtc->rtc_base + FTRTC010_RTC_DAYS); =20 - rtc->rtc_dev->range_min =3D (u64)days * 86400 + hour * 3600 + - min * 60 + sec; - rtc->rtc_dev->range_max =3D U32_MAX + rtc->rtc_dev->range_min; + rtc_dev->range_min =3D (u64)days * 86400 + hour * 3600 + min * 60 + sec; + rtc_dev->range_max =3D U32_MAX + rtc_dev->range_min; =20 ret =3D devm_request_irq(dev, rtc->rtc_irq, ftrtc010_rtc_interrupt, IRQF_SHARED, pdev->name, dev); if (unlikely(ret)) goto err_disable_extclk; =20 - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); =20 err_disable_extclk: clk_disable_unprepare(rtc->extclk); --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ABF126E97E for ; Fri, 28 Feb 2025 14:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751650; cv=none; b=GwUIulGvyBJnFFjAXxA29N1gyZna8YsombeIFPqC39XDsaPn2h9wKjrbyAfTiSP1iJfwlxy4GJ2I2YEoKN2CrU6ok414fdWI9838vslYwP7ZvuqoY/F3V5EhP9gY4mjT2xrUktL7qHtNy7fJxIhYJgralr39R4U4OWiMRThZ6co= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751650; c=relaxed/simple; bh=96lokglM16xoW0bhDeFwQgKQck5a27ZC3KAyN/gWBFc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NI71mN82Py7sQo8gEFsjE/tsQZcMLADRIHyi5LjYFCCQxyR1rWr7KSQjHfOSCoGC/49Wit+f+ZEQieF5uZCLama5wdXqgjsbfLkS0+4heUHjppTl2KBfYA3aE5veZB13WIytKxdAUMQ9FRA6J37nNOzdKE5e3cPJt1UaFcZbUlo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R9YMZXnh; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R9YMZXnh" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5e0813bd105so3591219a12.1 for ; Fri, 28 Feb 2025 06:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751646; x=1741356446; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=R9YMZXnh1zrTv4GDjxr8Nv0HMUqufzXC/q+ve+iHUkA5myd441jrUh/4BI26Hv0W65 dax2EHzr3zeQ70OEhsQZZ1OXaoITlLwDOhwCAW9ZDXYrEnDQRrG/gekRYUtS0asjNF1k EkQGOjDWVzlAverug5FQmkK7AuUtKRKdR6U/f/tG7dAbEE8TnXxzWd7gHlKpj8dnp0iS Ye+73QhzpOoBa1dE/KzrxJ73E4rcOjnhJdM8QNb0UsHxDiRcAdLrsRa+VuNxlRW9PJBr EPKPrB8K2kguil0L1uN1CDbV5N58fp3LFVi8V/Z5Zw391NSOyl0J1pUyADpHqDeKCn3Z 6gLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751646; x=1741356446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=vnuuJI0HpMr1e9vaupuBZ6Wgqsr2ifkEZg1tRBqlcZ3tyrKG30zXF2qTCB149oIJy2 cT/cSa5gX0anYKHtDPk6MwGOVh2DSZy/K+1tpTHTrcjGeXZIDhDYyfXV6pERg163DjHt x+HEHh6+BfPCHfWw8a+3zbtdZGs+aoNZGv1wz/DxFQJN28D9lrXEX2Y44QXycjkIrBBb mRRphWi9L9u2uFLpvH08CaWEr71LPZr7yZOzOsRO+HLb9AKS6/wLTpm94GcvKOy3iCdP E/BgXK83jm5H7GiXiZ5chZ1TeteHveCBLbYMUSN6XYv6bTQmEgQdy8a7HBLL76dwy7XX 7KQQ== X-Gm-Message-State: AOJu0YxCiDeB0AianJtRxr/af9k52zdPWvDh/QiAd6RCOaMfakS31zLU PXar31FeKi5Me7wm5kV8WOb19ETflUVNfdbCWqF41g53OiA1ntNAi1tgP+ui3iM= X-Gm-Gg: ASbGnctKIS/CnhXcijBeBgQRkchPhANqpsf97fcfU27sSGd9XXj2565b5OXtM39zuHN r9+9MaVcFeMRNXjbxlEGdzyQrMgiWGvZB6fdCCtDQy8bswnENBMxmQWuIWZX2gTWMAWDNDH5Z7h 82092mC6Yd+2YobT2swSyTAw1lhIYxZ6O09BZifNGSMPmXl4mBxpHeX7sYdZ/XyGTGklHKKuXR5 GcX17k+78iZMvZquPPhiGRq8i4fUcuKvtyXHbX9p+vKVQkS5Bphy3YzEcp25lMAERt4uI+XiN5O xMGQ9NCKDiRRPR++Na8rNTc7IekyraV3hl7m0j1+aEayYFBgC55eJcLaQ0GrKu2D5Tc2Yp2NQfc /jxl6my95UQ== X-Google-Smtp-Source: AGHT+IGw8/Em8B8f2s0ytjmI+eWh2dyA3vFh7dmQ8lnXofAka3id8ECQEXS4gzzEIESeh9rUlyHc/w== X-Received: by 2002:a05:6402:270d:b0:5de:5263:ae79 with SMTP id 4fb4d7f45d1cf-5e4d6adec08mr2881207a12.12.1740751646341; Fri, 28 Feb 2025 06:07:26 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:25 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:20 +0000 Subject: [PATCH 07/18] rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-7-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-m48t86.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-m48t86.c b/drivers/rtc/rtc-m48t86.c index dd4a62e2d39c73b1c8c3f50a59fd4fffc0b45105..10cd054fe86f9e6be74eb282222= b2751dd91cc7e 100644 --- a/drivers/rtc/rtc-m48t86.c +++ b/drivers/rtc/rtc-m48t86.c @@ -41,7 +41,6 @@ struct m48t86_rtc_info { void __iomem *index_reg; void __iomem *data_reg; - struct rtc_device *rtc; }; =20 static unsigned char m48t86_readb(struct device *dev, unsigned long addr) @@ -219,6 +218,7 @@ static bool m48t86_verify_chip(struct platform_device *= pdev) static int m48t86_rtc_probe(struct platform_device *pdev) { struct m48t86_rtc_info *info; + struct rtc_device *rtc; unsigned char reg; int err; struct nvmem_config m48t86_nvmem_cfg =3D { @@ -250,17 +250,17 @@ static int m48t86_rtc_probe(struct platform_device *p= dev) return -ENODEV; } =20 - info->rtc =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(info->rtc)) - return PTR_ERR(info->rtc); + rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - info->rtc->ops =3D &m48t86_rtc_ops; + rtc->ops =3D &m48t86_rtc_ops; =20 - err =3D devm_rtc_register_device(info->rtc); + err =3D devm_rtc_register_device(rtc); if (err) return err; =20 - devm_rtc_nvmem_register(info->rtc, &m48t86_nvmem_cfg); + devm_rtc_nvmem_register(rtc, &m48t86_nvmem_cfg); =20 /* read battery status */ reg =3D m48t86_readb(&pdev->dev, M48T86_D); --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8661F26F479 for ; Fri, 28 Feb 2025 14:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751651; cv=none; b=docg4/xR8hmufEdEqPpuG7bOmMP1bOcmpYQyblbJtk6FXmK9MKlGYTIL4mU3mNh+48M0IqQQ0s3+sxxJcH/t7hU0AapBUMwiH8MFllEdNc5Uh+uR4b8AXwQ8DwC5mNV+Bi4SvI749uW3PJbx4TOgopXP30fcXKYBkLYUQz2xG/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751651; c=relaxed/simple; bh=O7YHK/iXPLW7JvXPCw3QSGcpCg8mcQhvQ7AlODxEgPY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qj1a+GTIJFTzBoRnRLrf9a4tpztqKYKc6L7Hd/lZUAvxl9ul/Ug1Kg5Bgc20RA6JdCRy2Ezo5HjZmoFW1NaKpgs4WsgLlA3U86QeYPlkE7kI1b13/NKnRk6dusrNmHR8vHOpnG6sQjg0BPrLW1zXnRYxBUILu2FX1f882QCO4Lo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Z+VN4RK5; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z+VN4RK5" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5e04f2b1685so2788431a12.0 for ; Fri, 28 Feb 2025 06:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751647; x=1741356447; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=Z+VN4RK59krIT3waDSPSbEWZAyx6zqp3HUFfoSFdq6wjod9nTg12bk2ryRv2wO8j0f T7btJSJ5CiEdciiIjwWy/3LBBsMDXLGARfTGlzAKG0VNtH5VgtFcLdahGKvBc8WNyOwH irs4kAbonhFXXBe8haerPUztkXUOVo8Lo5ONClcEL0va9eTsPwKEinocHpzTT+Q08yhj 6COI93jWuujaSskSsjI79il/hyDuqAWt8I++VcLKXQuJOHITPgKQYK/eZHPiprWWOf6Z ri96wOmlg90EIDCQpNfpe3CDl6JEcLYM4HR72lB8vgUyGv4i3/iBnZ5GcYz0gKKtneYH cAdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751647; x=1741356447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=OZYIH2eWo85hIUwpH3vMPjqokskCbc0gYCYoSaZpstQQSPCZU3OW/h+MDVQ/r7dIxZ xBCWGCWi4aZdesDl7HmjMT2tjZcw5NwY4AjGldOYQiLG8NvIIBeQTt23w/hCZZi4yI/3 kc/v0Lw3B0OHoqo6Fpq66G6PBlKg0OHEvRPWakPCRsWrbtqCZDZnfikXMuyV/ONioJn3 Rx43bWWvWX+jS4T9CrOP3GvQ+Snn6kEdNjIqV9xDcPx/lwQtHt7oYqflyqiQTnnYWp9B jcny4JJH5J5Qng8hNnZdtEJ3HGja6ihAZqIOVAf3ybuYAfAxxmF1OMK4svjCAlmqZUND xJpQ== X-Gm-Message-State: AOJu0Yz3gGR7h2dh7FYgWYDxVrw7uUEG5Mb/NDpmvuyE5RrbWgcfEMVV Q69pSF4QUsOBfildlngkUmACYb1kDz5a2r5lAgGTfBNfESPof9wIOXjl7guln9U= X-Gm-Gg: ASbGncvju1Xude+fsE3fBHkU/vE6Vy+FUfekfd7cd99ompw3isC58s5aBf2mT5Y93xn xGcAOcq1GWYlRcniQcekP7TR9vjFMxUfxpFzTAplGbG6LTYF4XnCd2UOyJJPoqHT0DrPpzIr9N8 oswPbvbH35gmHVDRHO3/21p5mJRJpmHDNzuVa/efkUDo7wU4wxyPaCEk5CFk5TC4APZRysthBSX ZGZ55l1m2j+Qe01cc7fZ/+b0Z57rNjaY3qxnOZTy2kWBq7/5wpa2o9KBpvluiG5kiEJgDv/8sUL gak13aR2Em1bRwB/vTCFcyvHAVaLXqS/5xquCK/SMn5rqq7go5nxSe603t20Pc6YM2YR4I9JDOo I8WOR1qXCsg== X-Google-Smtp-Source: AGHT+IELhJPOd4W0qPAgNgABcD5moXsKlcKW8ZKlMd0/6RuVXfSWqRkHz67gqaNmak1AZcnDjWmnpg== X-Received: by 2002:a05:6402:50d0:b0:5e0:818a:5f4d with SMTP id 4fb4d7f45d1cf-5e4d6b628aamr8322653a12.28.1740751646827; Fri, 28 Feb 2025 06:07:26 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:26 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:21 +0000 Subject: [PATCH 08/18] rtc: meson: drop needless struct meson_rtc::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-8-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-meson.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index db1d626edca5fbb590f26c1cdd0774d350244a99..47e9ebf58ffc2f2b6c65932f8ec= 3773a213a62ef 100644 --- a/drivers/rtc/rtc-meson.c +++ b/drivers/rtc/rtc-meson.c @@ -59,7 +59,6 @@ #define MESON_STATIC_DEFAULT (MESON_STATIC_BIAS_CUR | MESON_STATIC_VOLT= AGE) =20 struct meson_rtc { - struct rtc_device *rtc; /* rtc device we created */ struct device *dev; /* device we bound from */ struct reset_control *reset; /* reset source */ struct regulator *vdd; /* voltage input */ @@ -292,6 +291,7 @@ static int meson_rtc_probe(struct platform_device *pdev) }; struct device *dev =3D &pdev->dev; struct meson_rtc *rtc; + struct rtc_device *rtc_dev; void __iomem *base; int ret; u32 tm; @@ -300,16 +300,16 @@ static int meson_rtc_probe(struct platform_device *pd= ev) if (!rtc) return -ENOMEM; =20 - rtc->rtc =3D devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc)) - return PTR_ERR(rtc->rtc); + rtc_dev =3D devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); =20 platform_set_drvdata(pdev, rtc); =20 rtc->dev =3D dev; =20 - rtc->rtc->ops =3D &meson_rtc_ops; - rtc->rtc->range_max =3D U32_MAX; + rtc_dev->ops =3D &meson_rtc_ops; + rtc_dev->range_max =3D U32_MAX; =20 base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) @@ -365,11 +365,11 @@ static int meson_rtc_probe(struct platform_device *pd= ev) } =20 meson_rtc_nvmem_config.priv =3D rtc; - ret =3D devm_rtc_nvmem_register(rtc->rtc, &meson_rtc_nvmem_config); + ret =3D devm_rtc_nvmem_register(rtc_dev, &meson_rtc_nvmem_config); if (ret) goto out_disable_vdd; =20 - ret =3D devm_rtc_register_device(rtc->rtc); + ret =3D devm_rtc_register_device(rtc_dev); if (ret) goto out_disable_vdd; =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A0FB26FD99 for ; Fri, 28 Feb 2025 14:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751651; cv=none; b=FHCBTl2NfOJkK/jey59KJ94mkzGYsVFm20r1KqMSEW5eB76ui9molyMgL2EleY3YXinElTj8TnPGaCpcIlYaAVlqiTJRz36fmYLO1Z5iHJ93ZQYhGx0Wamfsjj7PDAnDcBKBt9g/LEH1pIvAFUtOm+bS3xh1KcHjqaPB2FbCD0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751651; c=relaxed/simple; bh=UGMJ3GCPyVV/uGz6DNqBy2mH3s73qryTRoU1mvi31cQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rEi88SJDdpNmUZa+fIFGrmN3DBbSl8ny0QkL6BwG1PAy+HGhhjUPq/UIA9okDMMFE9sS7CHhjytQesvaNvW6wZo3OzyafITkT2E0dIpKHK80dMlQmwv+AqswutIvlboGb42X87kRJa9HcQpfWsw/eoSj661f4QzoinVF8Takkqs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DdY1jAQ+; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DdY1jAQ+" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5e0b70fb1daso3544820a12.1 for ; Fri, 28 Feb 2025 06:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751647; x=1741356447; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=DdY1jAQ+yjUwqYfgqH9cNfvplNpOsyXlmerA6D719DmwyePTExZbTjec/fn9Ijrhd4 cRcjrUON4m6KBm2dKUpSGjT0WvUdyVAKRhyWmiOytmXk6z2hYnCUTEALexQSWdjavfmn L0a1do+XcvL//KwWx7wttKuLlPdyKvXmpXrhpieOm7aJnhv2H5+VwimdReXH4SduXWfq IpzNE0YvV0t2vVzJj6xu5b8oyq5Ac0ZyeGcZ/nFqHvP1UnfwH7diE5V6IFJ25v8u9fuJ rimxFS4YUZvidbLulGnGDbep+2CZrriPXO1aK+j4UpgL3YN4t79/jHNJ67zBfflQ1nzi HJYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751647; x=1741356447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=QNOk+LDZPqkDzGRjJHDYQoglrvtc5ItSWqZT+sNg2UWi+MC6y60RokO/DyiTvRpRTb 6D8jK/gXC3lAHOK4Jk4G7jLJRDBzuhsZlTTGFYdHfQcpwcnWx//tiyDHeZg+0JkhjBmW vtFr5n4cV0KgrkwuE6pzHtYI/zMyQPWvaZlab+Jz2LVDrNA+C/GmhIu89qqJTfOMtrqu KgJMFpjFw3f9WFexWbNTvhLY/VUDRMYKwl6nGlR08A0xirdgiImIs3mJNwxliTrXMPjC 8ilkMFFq+9zqv5nrIaQF+703JK3B7dv1IX4qzM2C1VsNXMeLzpMibVE30fmq22wmj0Gb FNmg== X-Gm-Message-State: AOJu0Yz26y1M3JLwH+ezsZMJaFlZBfNLf3k03+LFIyzoVT71uK7mlfx2 gGQRidnxE1QjOmSsSPOJGJ7nc4KlFOff2H19e4UQ9s31EbdRcj1Xc4miFgEhs8g= X-Gm-Gg: ASbGncsO8lfpWIh9pdoaG6S7+yoQSre9jIMjX7ix8O3biVc3oPonlVWeRFc/QBrNW4A ZzY1g1oCI8KPVDfhvYsBVXP/gnxnWiHHoIWba0HCW4hTZyKbQ/SMcIoKqG0Wt+og5UGTz3dGHtz lIudHzMzCLBBFQYkq3ai3M1vzsyLA94wREGOJiByEVzLFIbJOkDjeklDkl3w3yI+t1dzuuroQXF U05705mEBxKwS8D3vp5R69E6qeUkOG3/T27qq7hvTAxthJka0io8i1zMzxqDfGwzlk6T8GZVmo0 Z0qI8ZBjP4Tu7pj+fxANRr2cEcrlb+aB2DQU+zkzfdx5EYpsGC3C5jjcO1koDTnsdoHIDj78NMT frIvoqb0aCg== X-Google-Smtp-Source: AGHT+IGZCKi+h7liDGF2k254zFpRo0bnTt6a/BEgRPyIDc7kptNekspya74S4whe/rs/kwdpZDQeGw== X-Received: by 2002:a05:6402:27d1:b0:5e0:82a0:50ab with SMTP id 4fb4d7f45d1cf-5e4d6b6240bmr2836488a12.27.1740751647311; Fri, 28 Feb 2025 06:07:27 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:26 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:22 +0000 Subject: [PATCH 09/18] rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-9-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-meson-vrtc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-meson-vrtc.c b/drivers/rtc/rtc-meson-vrtc.c index 5849729f7d01d7ec7868ff3bbdc5ed599aaa8238..7d38258cbe376e5a1b2af6250cb= 6d04c313175fb 100644 --- a/drivers/rtc/rtc-meson-vrtc.c +++ b/drivers/rtc/rtc-meson-vrtc.c @@ -13,7 +13,6 @@ =20 struct meson_vrtc_data { void __iomem *io_alarm; - struct rtc_device *rtc; unsigned long alarm_time; bool enabled; }; @@ -65,6 +64,7 @@ static const struct rtc_class_ops meson_vrtc_ops =3D { static int meson_vrtc_probe(struct platform_device *pdev) { struct meson_vrtc_data *vrtc; + struct rtc_device *rtc; =20 vrtc =3D devm_kzalloc(&pdev->dev, sizeof(*vrtc), GFP_KERNEL); if (!vrtc) @@ -78,12 +78,12 @@ static int meson_vrtc_probe(struct platform_device *pde= v) =20 platform_set_drvdata(pdev, vrtc); =20 - vrtc->rtc =3D devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(vrtc->rtc)) - return PTR_ERR(vrtc->rtc); + rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - vrtc->rtc->ops =3D &meson_vrtc_ops; - return devm_rtc_register_device(vrtc->rtc); + rtc->ops =3D &meson_vrtc_ops; + return devm_rtc_register_device(rtc); } =20 static int __maybe_unused meson_vrtc_suspend(struct device *dev) --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A31226FDA1 for ; Fri, 28 Feb 2025 14:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751651; cv=none; b=CgsfT/9Fw0jDknCNMmopLqgVU+JmFWgHvpaMPrfbzSj+k2PjHeYHXneHBDUyRbsuT/FktrsdZ+pgUeOigGHgZ7AoV9t+KBtkHL95/1vicrUF01hkXTQTCOZXPU5Um1hSCoehyu3CorLn6MQcGjDy6MnTr4c/tRFdjWTUZP8Kw7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751651; c=relaxed/simple; bh=Zg5sH/XIOlpdSTMnWDhKje/CxuIIhLnTjwMNeJlDZ24=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ASTudGXbKdmE/hsFlAKuXT7MKTPH+pbE1ZcJ+QNcxyTOD+2A+bRtPjOay6jGrN6rxbd/ffFBxP4HuGZFnJi8DJkpMY/iKfh+wFgNqIPir1kUzoR7JrUHjiMYyZhR0Y3vFpBATnc/W4LpJXBnWXYi74pzYcwXzENYlFAgTZ0yEqM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E2wT9l5T; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E2wT9l5T" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5e4f88ea298so1205052a12.2 for ; Fri, 28 Feb 2025 06:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751648; x=1741356448; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e0FEi4ElpfP7bsjHYl+IPy7QOEVjafD0mk0qg+EAmzU=; b=E2wT9l5TLY0++O8cIqYxZddJMTa7e3zZNmBSoHYPF+Ul9Pfpp1OBDGx4vd2VXFOAvl gdsmAGITGd1eBFTlyW426csG/mpVfd/dGiB1oViFVgdalqv9yQWF9Apv6Vmsr0E4w1yp BCgaEiaHNNKTYUsHIcx9W/KnyCKVEOuFb6BjITBWrnKeJfQoFd9PsmQjs6NQtX6XE93c xUM5iZfhbXIimHtuqJUTJh8CsCKLm6/xDGQuGF5XMrlYZ4YjKe1ZasZ0Ny1DobnDvaTE DZI9IOddMK+Mx5bNdkAcMR7q/dQs8JCic1XI7HjX/1Fy+X4mBfnAHYGu50BxKzKNGS8o PdoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751648; x=1741356448; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e0FEi4ElpfP7bsjHYl+IPy7QOEVjafD0mk0qg+EAmzU=; b=exQ+b9iAwKX6zO576D/Pp9N8EiGEsorEA/9wHqNrW5iv9cZhRzaAIwoaeb+ENj7IlX Z4DD68kDi595R6fHznBeBzfELmPteVSSghTZE2yevOTo3kHYWmSqV2eA8s0QFDrxuc4E lifeuqGBFV9v6di86+v8jAYy83XsUk0KGPZa9lPYObor1ZEQkU3PMMYUHNLTjJjfXIK6 QUmHLSctMc9aaaUIKDoosMDiTcTjPkCIWExfnANN9n4AA9dP4OlLg5UBMQJWhqUyAAwS /RVcN6gnVVrbqLkPr76697hTIAj6jnKH9fG3PgbgaEkmawRAsaLW4NdYYD3Kek4PsHSI grFw== X-Gm-Message-State: AOJu0Yx0vEbGV9f3Me4UWL1MAZ01mG+zzxZQiA5OaiCyKFqo/+nqdTX/ liu1SB5zhBdb3lZubm2LC4Ah5ROkL0UuF9BbvxxreTMRUG5RfyC5ud2pndBnoCg= X-Gm-Gg: ASbGncsr3azsLwNXsDg+0dLu9EgnyVtIFZMTbH+ssgiAE4LJBJrSeFqX5acdXJyj8SN VymNEsG5UCZcc6avk8fQ4sXQM5vFpot+JhWooRfxyJxECYEAASn4HYMwex/LpG8G4/ka/72RHv2 CS8TQ0asBti+fBfxAiuOdyQiNOVhO1WP07Qg8Ts+mal9fWIZYiwC5S3qOjZU2wA1axV83kd87TZ 8MTwRNMixUp53ZZOPM8zZzS2LGIfq119Bq2fV4P3Yq4jLF1zx1/IHc5WHgUhFz7fNfPcJu9nkca tjzo9gi6h0P1KdbjE3PG6o2HRSjiY3T7Gn/h1znuaaV3HcPq5QsBPRbnF7FdHNeJstWDibPWemB kAdfWZ+Xs/Q== X-Google-Smtp-Source: AGHT+IFd5qkPHWKs7u0kGQaxuAKFWYEyb+eqqsQgE6/A1ZcU9oZLI/LHqjeh9PQlI3f0EWIivI7Brw== X-Received: by 2002:a05:6402:26c2:b0:5db:f423:19c5 with SMTP id 4fb4d7f45d1cf-5e4d6ac4066mr2619097a12.5.1740751647799; Fri, 28 Feb 2025 06:07:27 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:27 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:23 +0000 Subject: [PATCH 10/18] rtc: pl030: drop needless struct pl030_rtc::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-10-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Linus Walleij --- drivers/rtc/rtc-pl030.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c index 39038c0754ee55a952e5986afe711cffff35840b..e7c81740061bb60c4d8447d6522= 819685bea9180 100644 --- a/drivers/rtc/rtc-pl030.c +++ b/drivers/rtc/rtc-pl030.c @@ -21,7 +21,6 @@ #define RTC_CR_MIE (1 << 0) =20 struct pl030_rtc { - struct rtc_device *rtc; void __iomem *base; }; =20 @@ -86,6 +85,7 @@ static int pl030_probe(struct amba_device *dev, const str= uct amba_id *id) { struct pl030_rtc *rtc; int ret; + struct rtc_device *rtc_dev; =20 ret =3D amba_request_regions(dev, NULL); if (ret) @@ -97,14 +97,14 @@ static int pl030_probe(struct amba_device *dev, const s= truct amba_id *id) goto err_rtc; } =20 - rtc->rtc =3D devm_rtc_allocate_device(&dev->dev); - if (IS_ERR(rtc->rtc)) { - ret =3D PTR_ERR(rtc->rtc); + rtc_dev =3D devm_rtc_allocate_device(&dev->dev); + if (IS_ERR(rtc_dev)) { + ret =3D PTR_ERR(rtc_dev); goto err_rtc; } =20 - rtc->rtc->ops =3D &pl030_ops; - rtc->rtc->range_max =3D U32_MAX; + rtc_dev->ops =3D &pl030_ops; + rtc_dev->range_max =3D U32_MAX; rtc->base =3D ioremap(dev->res.start, resource_size(&dev->res)); if (!rtc->base) { ret =3D -ENOMEM; @@ -121,7 +121,7 @@ static int pl030_probe(struct amba_device *dev, const s= truct amba_id *id) if (ret) goto err_irq; =20 - ret =3D devm_rtc_register_device(rtc->rtc); + ret =3D devm_rtc_register_device(rtc_dev); if (ret) goto err_reg; =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D6A026FDBD for ; Fri, 28 Feb 2025 14:07:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751653; cv=none; b=PEH3mYIpSVP+EW0QPi0UZlJtj45N+zW/JZC8B4DgolCeufqEJZ6B8bg4qp+yWXa4AFBswQRJViFlfqNxtBN+UCs7VAGCCAMKLsROEw60aCKRaXnLCfTHgoZV/V5AgmYZ6WeWis3uavqysm2UJvBuhk9glxrZejH1FO/5erRkGXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751653; c=relaxed/simple; bh=+Kph84gyNH2FaYt3N+VrOHuKaKCtB8nOyu2qKHWEIWY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=btAaHT4sFTEE9wZXmbGmS1+Yn9BiBNcR+dwDFyOvTL3kX3ldHR+WU4dls1QdixwAp17YFSE7g7LGXf+gOOxkZIys+k2bgh3Ki12mUBwjd16bHccUpnGkJKtwyuIYkrs8SEWCKuQmsNsBeEhVDvYUvu6pFWAa1g5cskpaUU7QyVo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oK3XLD2i; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oK3XLD2i" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5dccaaca646so4075427a12.0 for ; Fri, 28 Feb 2025 06:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751648; x=1741356448; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7nzHwlkUM09BG0CuM/bA+EpIQxILewT/ffWeXrAz77U=; b=oK3XLD2iq0t/+2Il/MmrTMKGJKRoLUsVfpyx4Ng+GxLv/Kkq4myvUMgB8L2ilRRl6b W5jpg2Q68WdTg68Pxw+Bj66o9d8GG4ybSYTDUAuEexBQbY6M40SdW9l3Xgr+ncoj8i21 8dgJk4ir8sqj19cIxHLJ1+ISGioytOnl/G0SrhbyCWc5FRABkTdyeBRhTic5Zu0FQHwd ABZs3zK64OEWUdJQXww7lz7gSTlPHWmMmRTENgZJ+FjZOTxZEPiRKwiiQeWpH1pV4fRc jKVcA3EJaxILEAlKvouxyPPdRrbdlGSnakdV8rfUzrUlBKKu0yLFJMH2pxde+RnEx8F/ 5cQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751648; x=1741356448; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7nzHwlkUM09BG0CuM/bA+EpIQxILewT/ffWeXrAz77U=; b=aPBa1GI/kNJeezn5MZhrE5wvWkTNcOCxb6ydj2lQWyyQC9cQGZSrsgaJYc7IrAphGj zWfvQsEXdHRDGqQFi7iA/YB/fXjTOnF4NaUbvgms8FUSPCXFZgtRzmXCqHtr1AbEb6yI W9HalWz7XHcbwSljiNieV6ecdgBJDjCJl7RQMXfTdnI+r5higF8bMlL6OI1YlsCnugAK 1PLYJL76fRSjy7kpYbhO1gTniAtGFkOJFCWB2opJakYwyzuVBs+KQjZ8yc/MkMS/sRE2 2a/8EekUQP3qwXpYYwAjk+W3TQKkildAviScphdTTMe/QYXA6SJCJjVmOlO5IFX/3oSd lXrw== X-Gm-Message-State: AOJu0Yz1AQmxCcEwsqViZh68olCVR9f1hJuVWp8asc5xKrE7oBb6oDhg UwQWpj2fYTcOPUCdbnwfqkHj2BZhSbMFbiCb7icuPT9N7G8l6sL0wiuLPkC9R14= X-Gm-Gg: ASbGncvxzN4b17GeaDAvhpT5NhE3zxNrNtnxxqWaXPNmS9FmJGIKQ55nRB1zDb8UwwW urYSRcKeeY3OzjK5xQKd8LG9XZSIQZXV02zrdJHyri+hFHZ2n9PsgVHGe72fzL1hs9Zlc8yIOMP kqHESqXoCfshLhFRWjL279MZQ2KMjzsnFIYF6ddBLzmbwPjolMbSDrp4AewWQbP8UMezLv7RL90 7q0az4+pZIgh7Z3EfT5g/7YgEu6x+myKmBsoQagmXJuVRZtVCZfmUFXsS3FlmgdHJfEKvJs9Q2o jz8cdtqLTFNPsC6buePGVcI+Tj1p7uLUC0yJh4DpoPI+N16hkN74W8e3n2lTBvX4/rS70p0ndeI jhn51NfBMvQ== X-Google-Smtp-Source: AGHT+IGquByOTAI+pOBsMihZmYnZaIy5p2XitRnKkTWDJg07k5RO868wRYsHEejBUavy8mEmWjqo9Q== X-Received: by 2002:a05:6402:13d4:b0:5e0:8a27:cd36 with SMTP id 4fb4d7f45d1cf-5e4bfacb0a8mr8959084a12.8.1740751648271; Fri, 28 Feb 2025 06:07:28 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:27 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:24 +0000 Subject: [PATCH 11/18] rtc: rx8581: drop needless struct rx8581::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-11-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-rx8581.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index b18c12887bdc3705ea4cee9b8d75086a05b24e71..785ebaca07ac971eee34559f8d1= e0a8a872cbba9 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -54,7 +54,6 @@ =20 struct rx8581 { struct regmap *regmap; - struct rtc_device *rtc; }; =20 struct rx85x1_config { @@ -252,6 +251,7 @@ static int rx8581_probe(struct i2c_client *client) struct rx8581 *rx8581; const struct rx85x1_config *config =3D &rx8581_config; const void *data =3D of_device_get_match_data(&client->dev); + struct rtc_device *rtc; static struct nvmem_config nvmem_cfg[] =3D { { .name =3D "rx85x1-", @@ -286,21 +286,21 @@ static int rx8581_probe(struct i2c_client *client) if (IS_ERR(rx8581->regmap)) return PTR_ERR(rx8581->regmap); =20 - rx8581->rtc =3D devm_rtc_allocate_device(&client->dev); - if (IS_ERR(rx8581->rtc)) - return PTR_ERR(rx8581->rtc); + rtc =3D devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - rx8581->rtc->ops =3D &rx8581_rtc_ops; - rx8581->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; - rx8581->rtc->range_max =3D RTC_TIMESTAMP_END_2099; - rx8581->rtc->start_secs =3D 0; - rx8581->rtc->set_start_time =3D true; + rtc->ops =3D &rx8581_rtc_ops; + rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max =3D RTC_TIMESTAMP_END_2099; + rtc->start_secs =3D 0; + rtc->set_start_time =3D true; =20 - ret =3D devm_rtc_register_device(rx8581->rtc); + ret =3D devm_rtc_register_device(rtc); =20 for (i =3D 0; i < config->num_nvram; i++) { nvmem_cfg[i].priv =3D rx8581; - devm_rtc_nvmem_register(rx8581->rtc, &nvmem_cfg[i]); + devm_rtc_nvmem_register(rtc, &nvmem_cfg[i]); } =20 return ret; --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D7D526E94F for ; Fri, 28 Feb 2025 14:07:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751653; cv=none; b=ddXkMAYk0JBq8kQQiZe4qDC+5l4Z6fJ5acNuizdFgI+U0uQRGfnUSABmn+xAsJ7Myh6EF13MvFT5q3wiJHaucqcxqOUnebcw2Rxbs5c/30apkj5KUHjoJiD/cVzLbRQp/9tKmV5kOj0ajh2TpxnYTHyuH8vJ4CmBuja/ndT8QIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751653; c=relaxed/simple; bh=wcWeDWs75X61m+m4siXkgCaNrKLjTdrfe/93knsU6io=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XCmSq+B+TjTv514RuBHCSZ/GUgnxImaBmIqCkfMI/seLnNDl01mPVk+8B3gLKBLXSkzga3kNfMZKTmy7atfjEBTFmnFvCI+zRFSeouzyRWgV5E8N4PFUok3x8aCDWoZIz8fsHox1l5HKQ000odRDT/DOOqMK47PExHNIImKC5jQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tIkP3JAb; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tIkP3JAb" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5e04064af07so3923189a12.0 for ; Fri, 28 Feb 2025 06:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751649; x=1741356449; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=tIkP3JAbCYhrYFOvnjaeq/dbjJ2fYEWvHO8pFId005Ye5HsqEYCJIwTnArTYJ+nei/ u4dh0WqEivGHiSn6n0O94Bj43dMAfp/YJPge5ypbvZ5U6O/CRGd0gAZGDSfiAAdp2DBd UJwJQi4xBfOAy0LCaFCiCDlhEB5iSD1HDyvkUVwXjXVnp5b7cburdus715rG3UshB7Ei IUQq2FhOBS17Bk1MBHasj/xHW1k45r/XWOTkQj0W6eUsDy1Q+jKYht+WmWcxM+t2Ox/M qJ851hynlox9VHT4hhNWZeOm7/OMLBi7cBo4CUKiEaz3dYU5yGF7LqfmhKK8N4ITXdR6 sCZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751649; x=1741356449; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=pqa1aFAu7QIdJu9hJ0J7Y0CFx2OVRuLh0LF6EDAH1R3zWvVB75TrYN1nkhfHhqZwQL ORKm+4RvQ+MEUvXg5SI/6F8e3uUXl1c+0njXv6vzwCfni+fCLoc4OYp13EF92aP7RgbN Y1yOWAm7v8QYNMNadsmngZOfg9a8xiFYlUeGLFbM4tjFIfckr0cHr8gLWloV3zYHZHJ3 Vk6lGaSUaNBNwV1lNDWbsgFVAuL4UJNVcPky1lYoo8qy8ht0akWupdon18yeGdBGX4ub jvF42ykngbnZ/UW0XCZx2tssg0PetOELDW5oFuVuNkKBjD+7H8shH/+LReMCNlGPx0RJ mq8g== X-Gm-Message-State: AOJu0YwNnVhUiqHiWbAoJ2bDGrSvLn5HqF4CT7KeU/cGo3unjCBDRRB7 B6HrxIKNnbQKO7T3PHU8NDtydwlvcKEfvSl27TpnTShX1/rNy+AfLT5PtDMqspY= X-Gm-Gg: ASbGncuNcbOKhRNWBXaXLN3IJVTkg9V9luW//3yIUYXEh4bUEWp6GoYaJlChls89Woa 2qBnxHT2b5GTyQlZB99TyMJ36JWYNPziblRj/XXqd8TSNrSR/XwhtEZPJdMFX3Vx1b9vYEPw9xQ Jaq3A8+evQt1amFekhdoiP0jsD+zjQkpfZBl3qfyrKKgb3atnrKaN4Kkis82gHLLQhmje5UT3jn jvcZL+BBZ0YtUTgVYkq2wvqFKWBAXWl2cgaLd6WHlFxM7O6Vh3ERVL5Dbki85n5qnhbL82GqoBi s8LTaCwW1wNlcHYkTa0/AEP0qkOr62DZM7zHNXH7cGIAEol3c2hl+uDRD8NJLsirBfyI5WqUHtv Jjg4LpLjJFg== X-Google-Smtp-Source: AGHT+IF1zdUSX6ZhtbedenD60jZMcHzIIU2NhAe4k+oRQ6Wt3d6uE7nze1qy/Ap2/A6npGSF7Q9PVw== X-Received: by 2002:a05:6402:348a:b0:5d1:f009:925e with SMTP id 4fb4d7f45d1cf-5e4d6b1869bmr2990380a12.16.1740751648743; Fri, 28 Feb 2025 06:07:28 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:25 +0000 Subject: [PATCH 12/18] rtc: s35390a: drop needless struct s35390a::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-12-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s35390a.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index e3dc18882f41445c41fbea56edbd5c869514880c..3408d2ab274194e39cde38a8356= 7d37bd53f6632 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -63,7 +63,6 @@ MODULE_DEVICE_TABLE(of, s35390a_of_match); =20 struct s35390a { struct i2c_client *client[8]; - struct rtc_device *rtc; int twentyfourhour; }; =20 @@ -422,6 +421,7 @@ static int s35390a_probe(struct i2c_client *client) int err, err_read; unsigned int i; struct s35390a *s35390a; + struct rtc_device *rtc; char buf, status1; struct device *dev =3D &client->dev; =20 @@ -447,9 +447,9 @@ static int s35390a_probe(struct i2c_client *client) } } =20 - s35390a->rtc =3D devm_rtc_allocate_device(dev); - if (IS_ERR(s35390a->rtc)) - return PTR_ERR(s35390a->rtc); + rtc =3D devm_rtc_allocate_device(dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 err_read =3D s35390a_read_status(s35390a, &status1); if (err_read < 0) { @@ -480,17 +480,17 @@ static int s35390a_probe(struct i2c_client *client) =20 device_set_wakeup_capable(dev, 1); =20 - s35390a->rtc->ops =3D &s35390a_rtc_ops; - s35390a->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; - s35390a->rtc->range_max =3D RTC_TIMESTAMP_END_2099; + rtc->ops =3D &s35390a_rtc_ops; + rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max =3D RTC_TIMESTAMP_END_2099; =20 - set_bit(RTC_FEATURE_ALARM_RES_MINUTE, s35390a->rtc->features); - clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, s35390a->rtc->features ); + set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); =20 if (status1 & S35390A_FLAG_INT2) - rtc_update_irq(s35390a->rtc, 1, RTC_AF); + rtc_update_irq(rtc, 1, RTC_AF); =20 - return devm_rtc_register_device(s35390a->rtc); + return devm_rtc_register_device(rtc); } =20 static struct i2c_driver s35390a_driver =3D { --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1032702B6 for ; Fri, 28 Feb 2025 14:07:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751654; cv=none; b=DYxf7im1FT1awCAJys7EniuimLNHvCttGDGpvO8tYxnTDoWt/YLynMjJX/oyju7KtqDr5WvSHKC95iA7oKfJZjWe/bhsBP7QZYEbICUOVEVv8mFrX3x3S4cGWMC2T/wroDRj/uMV5jIFCCxt1oKUyOf83WcowWPsjJe79DSSdAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751654; c=relaxed/simple; bh=YWsW1Hi2ZTuQ4PTHK3D3g/NShAx4HGeNxSNC1qLA8+w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JL+20gcrapKnYWyhbE826E+4O7VP1GRfd+QXvYX8h0W+nRJm9enUpVjJUnOOoVzyLuEJQF3/l6Nbbhi1Njm7lcNKtIrVndYSgATJ2XlTa6Zr9qb6QBiroSq2aoNiTX7EntjkQmWxkfnVd9kkR0lDZBCAV+4pg7BkqQyJ05rKR4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=j7tPzYs5; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j7tPzYs5" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5dec817f453so3274775a12.2 for ; Fri, 28 Feb 2025 06:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751649; x=1741356449; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IKZrDxBZwKYSSWAqYI1nyzOGiPZfFb6S25OWnyP8uMM=; b=j7tPzYs5kMi3OXCfBSZ/zp59PZ+0it49nJTyQFkUfV98Nqr5zXXgEjXPo13EQACQwE rcl9sDp+2z2BcLQVgAMS5Y3V9JXPp/rQewLRxGFGD1Eh7t+2ZCSpgDIx69ApmNMeuUZH c7WRW3zkmtX4PdALnviuis+bbbC4PKjDhzzFyacNWkFMiu7iGgYm139IpWMdssRf6qmS SPI3h6UI3BxN7ewQ74RQ+qCWy1QpSRfmH+TiJF6aALk56/+A4njF/T8nMYYAqWRXpMcQ KxROVbTWTF0sjLmmkczb05zYo5zeo2Lk5Yam8b/qihY1xZ2X50pW0fxChgbxBzChM91p kjMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751649; x=1741356449; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IKZrDxBZwKYSSWAqYI1nyzOGiPZfFb6S25OWnyP8uMM=; b=pSAjTPAo7ReMVcgfl/9asc7R6g58yDg4oJUGmzbpUYeSbjDak3vpGzs7RKFlmsT0B7 Lj3TMsPSSSrNGLI2aAz8xSktisrORi3xPjWU/Y/qOAIJq35gXX1JYtJ+frCK7A1H7o7D NCU452Ox8t7o7mfMDXK+I9kWEOy3pl2Y9VRgM+JYYT/6gEEalO+aS20V2gJWwDHbB+48 RO828obq4fZkrZX0pIO839hVAc3JzNtT5wCFUGFqzLb6iVmCW2di30+IleUeFUMVbnDG yAON8G38UKyePiiPnq0acSSq2vXM1G+dmmTF/f7WNvZGfXONgJwNtJ7nI5xUbwnC4T0x 1SKQ== X-Gm-Message-State: AOJu0Yz+3RNHNwB7l14/4ZylilqmA90IHCAfQy5Z+XJPSsZ6fuFoh8rv 3b+Rmm8iIcGmDHa0dJ2xplghyK1TNGg80xqkK+r09oFNGIsRazCnohAbLQzX2T8= X-Gm-Gg: ASbGncsPDQ/qD/n+ksSgzOSmFkVvpfE0HzWAMPRT2Co8T9ZlOARxV++wzaCLqTYTKnF Xm5HsrEVg6oZoi5amCZAaHiwOrTqU3Pti7yyqRYA6cjUXjJJyQ5kQLhQSZ0jMtILNMMwRXNqf3d 9lC+MG5jn+AIuii7AGAysmK1d+74HWCYmRFZgNTuvatcE0xtbmyoCnjAJLiMX8VkpKUayyuAoMy 0P2J2lxpnU6UJVVFM4cCkPWmnr79h2XzYnBef8gZIyZTHUWbltuz1QeP5EPJP9Nolo8i+FxnK6L F5sLvdNTbb8HyN4DAUizD2ae1pZWh5kijJHg1+5/7G+2SLX/WNfgbdL0FnLH81tt5sy5g8r2mRi rMCsLajWJwQ== X-Google-Smtp-Source: AGHT+IHq59q43U3ESaHrkdTJX61FFZSQWYbph+vbGLJu0Eb0VqRkvBLNVX+MfvKgdS008nj52Al/2Q== X-Received: by 2002:a05:6402:5188:b0:5dc:c531:e5c0 with SMTP id 4fb4d7f45d1cf-5e4d6b83d0emr2632501a12.27.1740751649255; Fri, 28 Feb 2025 06:07:29 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:26 +0000 Subject: [PATCH 13/18] rtc: sd2405al: drop needless struct sd2405al::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-13-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik Tested-by: T=C3=B3th J=C3=A1nos --- drivers/rtc/rtc-sd2405al.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sd2405al.c b/drivers/rtc/rtc-sd2405al.c index d2568c3e387659dfea598cd2ef6bddc5c076cbb9..00c3033e8079b5f10aaabcc7a1d= 3f19771263a02 100644 --- a/drivers/rtc/rtc-sd2405al.c +++ b/drivers/rtc/rtc-sd2405al.c @@ -42,7 +42,6 @@ =20 struct sd2405al { struct device *dev; - struct rtc_device *rtc; struct regmap *regmap; }; =20 @@ -167,6 +166,7 @@ static const struct regmap_config sd2405al_regmap_conf = =3D { static int sd2405al_probe(struct i2c_client *client) { struct sd2405al *sd2405al; + struct rtc_device *rtc; int ret; =20 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) @@ -182,17 +182,17 @@ static int sd2405al_probe(struct i2c_client *client) if (IS_ERR(sd2405al->regmap)) return PTR_ERR(sd2405al->regmap); =20 - sd2405al->rtc =3D devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd2405al->rtc)) - return PTR_ERR(sd2405al->rtc); + rtc =3D devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - sd2405al->rtc->ops =3D &sd2405al_rtc_ops; - sd2405al->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; - sd2405al->rtc->range_max =3D RTC_TIMESTAMP_END_2099; + rtc->ops =3D &sd2405al_rtc_ops; + rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max =3D RTC_TIMESTAMP_END_2099; =20 dev_set_drvdata(&client->dev, sd2405al); =20 - ret =3D devm_rtc_register_device(sd2405al->rtc); + ret =3D devm_rtc_register_device(rtc); if (ret < 0) return ret; =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6E3726BDB4 for ; Fri, 28 Feb 2025 14:07:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751654; cv=none; b=G/ccLCL9UlLK1hxIT3vg5PRTWleUbJ1dg3OClIwFRvV/4Q8ajJPh2uFSD2K9OflrD1i4EPMDec+63LpXDKjDo/giKkOIA66It86z09zA8s54I5vykUtvIyJ0/ONNzwQ5oNI7MHNbAPqV5A5DwCJVvResvpFpaS7e911GeIAHJck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751654; c=relaxed/simple; bh=csOMxrJ8DUKG8jZ2g+nC3altbQsJLgJ3nzkzZybq300=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fhV09nphEfOKt+6HUePPouA0l7rd79RPr2sUmPYNNnu8lhWLPFh2nngP1ieuQViNq43qa1Np1JA7VXk8F6gEhyCpKOKjZWPluLz6iIb67u46LlwaW01FyceNnIeVmboQHrYWKXEDT/gsYu68QNIT3ZUocTxnzHcimYRkCQMjaQU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QOM1+0+E; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QOM1+0+E" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5e095d47a25so3595945a12.0 for ; Fri, 28 Feb 2025 06:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751650; x=1741356450; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wVgVdQhbC2YyNwH7K95+EhEh/kAvax64uDHN7A2amTM=; b=QOM1+0+EeNvhAM/TKJ0qctceEbRr0WzYClZbSW63L29B2imhJlMzgqCkKNBIfQtU+V QuQMZtwErSgGydIOWkB6SiQMHnZF1pcuu56uenHSO9qrXuHSg3RPOXwXDmvKt+LmsyfB MicOfm81eg7/+heDKjLcIdOmVp/bSiuVMQzUNRlWQ+h6puitUmpTkVbs4ZYgfbY9yzsd PNKKXw1ak/dEjH6ymbT2ye1HfL/7SA9PbCXOyZ/Aqw8pC/kZpVoWjDGFFbKmuvLcS6Aa dhqVIr+YKq4i9susfCX6KNHJxbwr7MsCCWgVg8T04QKNkSOCVdkhLlQpjvyDz4BtjEzc 8Rew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751650; x=1741356450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wVgVdQhbC2YyNwH7K95+EhEh/kAvax64uDHN7A2amTM=; b=XRQtGdJ5H+tlfacLvK6uzz5xBf9Uhn5NK+Ti+EowjwfNdN7NfOu8oM4SN+jL36aerT s2q5BhTfplUEh7WQT9g6Q5axGmNTZ79YIfsftYOKgD7onFau5xsatBa8VNjqCc1yd2fa Lnm98JDTOJTcgxE16JReiEdc8NHCRkFAWdGEQZVRy+Pv3FeowiDH+haFu3y21/IZ+es3 yIcTbWl8VaUVV41OZ9gi4MYdHqxjcyobtExFyFMe+Ve09aji3uOtTReVHc8J/CuJskfe fy2abkOiAscbRQy1EPPmnIl8jkFI7GmysOz336RhU4/P9hvCESIPsylz50/m9LHrBcJ7 BC8g== X-Gm-Message-State: AOJu0YzdhyIauu7LQd6Q0SWVAkJ/ksdff5xP3rixpmKa7qj2nSyJjutk DR13uwx5FrZYAbHoeEBK8fCifzCsj2Jzg1kaO9jUMG8zqz14bhlX8i+ybbpOHgA= X-Gm-Gg: ASbGncti5kiJBeGL0SNdbQe+jJhn89rZpzCAbsukchLBgl3MgxeuWtXp/vHICYBsSSD ZT6nYJI2kfUgt226N9HM7US/2t/CQNLifqyGrWzVGZiqcwBpTqX69vQj2Zf2z8VxSAMNc50oohs v8ImAnRPpi1XLvuvHDsUYM9MGicS52SeUEjQ8bZl2pWX2aYk3ZL5KpSQeD3VmK/rMospTnyq/SE XSrVWqDULX8YwIDKfybHtNSRlVf4GxuTlDKAcGz371gcV+GrR+lpSzTfgVjTvzcq3gQhEMiXLIR sL+anIeNw8ITRT7jMj1GCrezAOFArrC4r1BcnzOR3JcEk0XvgUn+S8hMLw7imMC35u6eznfDRZB DMLehlLOGwQ== X-Google-Smtp-Source: AGHT+IHCyDQzEJ6kBhW3v4N+pYx5F1W3SqfuZOszPC9Ixk4jqjoqtVWckx72H2jiEWEF9nyPWj82Qw== X-Received: by 2002:a05:6402:254d:b0:5e4:cfe8:3502 with SMTP id 4fb4d7f45d1cf-5e4d6afa314mr2938285a12.17.1740751649850; Fri, 28 Feb 2025 06:07:29 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:29 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:27 +0000 Subject: [PATCH 14/18] rtc: sd3078: drop needless struct sd3078::rtc member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-14-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-sd3078.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index fe27b54beaad1c06b70bf7f22e44c3f6da087267..ebb4d45ce2409982880affbc7a8= 5d5e7410c8f42 100644 --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -37,7 +37,6 @@ #define WRITE_PROTECT_EN 0 =20 struct sd3078 { - struct rtc_device *rtc; struct regmap *regmap; }; =20 @@ -167,6 +166,7 @@ static int sd3078_probe(struct i2c_client *client) { int ret; struct sd3078 *sd3078; + struct rtc_device *rtc; =20 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; @@ -183,15 +183,15 @@ static int sd3078_probe(struct i2c_client *client) =20 i2c_set_clientdata(client, sd3078); =20 - sd3078->rtc =3D devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd3078->rtc)) - return PTR_ERR(sd3078->rtc); + rtc =3D devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); =20 - sd3078->rtc->ops =3D &sd3078_rtc_ops; - sd3078->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; - sd3078->rtc->range_max =3D RTC_TIMESTAMP_END_2099; + rtc->ops =3D &sd3078_rtc_ops; + rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max =3D RTC_TIMESTAMP_END_2099; =20 - ret =3D devm_rtc_register_device(sd3078->rtc); + ret =3D devm_rtc_register_device(rtc); if (ret) return ret; =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AEB42702CB for ; Fri, 28 Feb 2025 14:07:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751655; cv=none; b=Spi/+C60TGFEczC28bhRTFVXTgloBZojqFOHYSxtZjToUC8gpzM99Vk3zoeKlWRC/N9UHKe1Df4xlPnkuTK4hB75qeOx8KBLz0N0kB1QP1kVlW6MVQYeaMr+31cfCBRK255AjZXw9GHHVF0aiJv3psSK8svddqu4PEpzTFM1+ZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751655; c=relaxed/simple; bh=KnTT7JVjJd7L84lbqgaLnnpzphht/b/4e/xeT/zzGuY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZbjWIe6UxDqpkwQ2K4jhWqehnOHvUR9B5L+hZtbCytyZTUnjuyFcTLzZuAHON70TCae3MdxokS5XZCl00nakysMZDWHqJKM38+VzKhcGUntQkJE8Iz1/YyojW0wAnt/RP5frBWgJKOnpWRJd8MQtZIDxj07ToFg+4cXc/JUE378= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vhrOgg2a; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vhrOgg2a" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5e04cb346eeso3602147a12.2 for ; Fri, 28 Feb 2025 06:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751650; x=1741356450; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XNaBzsv98dZxOnoY4pQ3hhfyEv1+PH+c26jk5v5UbcU=; b=vhrOgg2aZzOd7RHT7K//qXuwRzvsaz4MFsjVoDelpXKBUjMPSvIgzT6bBKwLVTbQmZ VRKD2pCMB3yjkeq0prZ65/MeBO3cnurRHrgd80hTWrmxImi/msDee3LZQkZO7nUHxLqP RmAnybYsLu2jBsM9fMSK7tQKUT04/iBLxq6snU1164ReVjrX/tzR3FwgvsMdyYQItrbq 0pg94gzAuGLRpvllaJZ5nlu3z+TZoqSd5SgZz+e+sP3O8rjyBH00+OvgNyuRvQkObyaD yu3cmDmWgsdnr7o+nA9ShVaXrOT7nWZCT48jNMYGcYL26P4QRph1DQFFKCkTxhgVKq6b FgFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751650; x=1741356450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XNaBzsv98dZxOnoY4pQ3hhfyEv1+PH+c26jk5v5UbcU=; b=C9ZPrRUpVLpznBsObnJwEPiugZndfbKmyYHNBXsYamW6/DZi8bR4HdGQhLS3bUubl8 rEDyJP7YjZMYWqK8qmy25ePU/6XIO7Hkole1Mr+YJ6DBSOqQbW+ghusR+lGtBF5NAG8v U4aUmssSJ3HDT8zo6x29UeFSLNPJAnH79yggnNXMZ2xcDUYi1PaH5tH2dbWI6edJCjke Hx3oS5qq+v0Xy4KnIaibzCMgqN7WA5DnI3ujDNStDwSSWtwSTORvjC6QrheDDRz2XDZz 4dAOq61gXaZFlq7OWBPVacHnPa1jXMbQ0L/V15+u/4C73Ua4uOwgxYUI8odrCuYpuD3X 4sdQ== X-Gm-Message-State: AOJu0YweH8zIhoW2MHSsIzPZxx0NT2DGRg/o26h2vpwwpxleJ6m00p/s 4+nQ0rkwa+Xok/SZt9o5+CJfCpT6N0ekP/ocEPr72InmsfZtsKEMalD9YPjC2tE= X-Gm-Gg: ASbGncu15C9A8Leac9O20tM8GtXUZRhHtGdDKqUtX9rDZ34gVQ7AQlXkNfxQoNDTob3 fq/o3yL3sh+0QGYugROOWP8hDxFkyRuS30UgPV3by8PYmiiODdvQBi9iyr9l5YAFjQqXo8sO+sJ zsYz8+3zRxYNKb0pndvcRQT8K2/G933DKA4iZs9rW9+AFZGEzAto4pxvzfIAgTKZni+zlqHtEsr qCMPCxnPWhBaWNhniQdzRh4LW698JcFjyCKZxPgp+sVrNYvln5qfBQS/Gee6AYJRKtqXQ5eUKKR RBubruf4vpNIjW8lIKPK9VAJT0qrgn4veUfu5KQBufvJl5vo4kJv5W/0iFBdmFEdkwcfLiiTMkx 8Pw4MuUv0uA== X-Google-Smtp-Source: AGHT+IHJgHIb94bIAN1OxpmT/CmpG5hxROPCgFLfrUaKlqlLkHckO5CTYjuy4Kdl9gpiKvePvUPO6w== X-Received: by 2002:a05:6402:35d3:b0:5e0:9959:83cd with SMTP id 4fb4d7f45d1cf-5e4d6b70ef7mr2396243a12.21.1740751650375; Fri, 28 Feb 2025 06:07:30 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:30 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:28 +0000 Subject: [PATCH 15/18] rtc: rx8581: drop needless struct rx8581 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-15-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 This private data struct has one member only, there is no need to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation, reducing runtime memory consumption. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-rx8581.c | 63 +++++++++++++++++++-------------------------= ---- 1 file changed, 25 insertions(+), 38 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index 785ebaca07ac971eee34559f8d1e0a8a872cbba9..20c2dff01bae833ae4e100cc38c= d5f030017be75 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -52,10 +52,6 @@ #define RX8571_USER_RAM 0x10 #define RX8571_NVRAM_SIZE 0x10 =20 -struct rx8581 { - struct regmap *regmap; -}; - struct rx85x1_config { struct regmap_config regmap; unsigned int num_nvram; @@ -71,14 +67,14 @@ static int rx8581_rtc_read_time(struct device *dev, str= uct rtc_time *tm) unsigned char date[7]; unsigned int data; int err; - struct rx8581 *rx8581 =3D i2c_get_clientdata(client); + struct regmap *regmap =3D i2c_get_clientdata(client); =20 /* First we ensure that the "update flag" is not set, we read the * time and date then re-read the "update flag". If the update flag * has been set, we know that the time has changed during the read so * we repeat the whole process again. */ - err =3D regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err =3D regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; =20 @@ -91,20 +87,20 @@ static int rx8581_rtc_read_time(struct device *dev, str= uct rtc_time *tm) do { /* If update flag set, clear it */ if (data & RX8581_FLAG_UF) { - err =3D regmap_write(rx8581->regmap, RX8581_REG_FLAG, - data & ~RX8581_FLAG_UF); + err =3D regmap_write(regmap, RX8581_REG_FLAG, + data & ~RX8581_FLAG_UF); if (err < 0) return err; } =20 /* Now read time and date */ - err =3D regmap_bulk_read(rx8581->regmap, RX8581_REG_SC, date, + err =3D regmap_bulk_read(regmap, RX8581_REG_SC, date, sizeof(date)); if (err < 0) return err; =20 /* Check flag register */ - err =3D regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err =3D regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; } while (data & RX8581_FLAG_UF); @@ -136,7 +132,7 @@ static int rx8581_rtc_set_time(struct device *dev, stru= ct rtc_time *tm) struct i2c_client *client =3D to_i2c_client(dev); int err; unsigned char buf[7]; - struct rx8581 *rx8581 =3D i2c_get_clientdata(client); + struct regmap *regmap =3D i2c_get_clientdata(client); =20 dev_dbg(dev, "%s: secs=3D%d, mins=3D%d, hours=3D%d, " "mday=3D%d, mon=3D%d, year=3D%d, wday=3D%d\n", @@ -159,25 +155,23 @@ static int rx8581_rtc_set_time(struct device *dev, st= ruct rtc_time *tm) buf[RX8581_REG_DW] =3D (0x1 << tm->tm_wday); =20 /* Stop the clock */ - err =3D regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + err =3D regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, RX8581_CTRL_STOP); if (err < 0) return err; =20 /* write register's data */ - err =3D regmap_bulk_write(rx8581->regmap, RX8581_REG_SC, - buf, sizeof(buf)); + err =3D regmap_bulk_write(regmap, RX8581_REG_SC, buf, sizeof(buf)); if (err < 0) return err; =20 /* get VLF and clear it */ - err =3D regmap_update_bits(rx8581->regmap, RX8581_REG_FLAG, - RX8581_FLAG_VLF, 0); + err =3D regmap_update_bits(regmap, RX8581_REG_FLAG, RX8581_FLAG_VLF, 0); if (err < 0) return err; =20 /* Restart the clock */ - return regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + return regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, 0); } =20 @@ -189,29 +183,27 @@ static const struct rtc_class_ops rx8581_rtc_ops =3D { static int rx8571_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 =3D priv; + struct regmap *regmap =3D priv; =20 - return regmap_bulk_read(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_read(regmap, RX8571_USER_RAM + offset, val, bytes); } =20 static int rx8571_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 =3D priv; + struct regmap *regmap =3D priv; =20 - return regmap_bulk_write(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_write(regmap, RX8571_USER_RAM + offset, val, bytes); } =20 static int rx85x1_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 =3D priv; + struct regmap *regmap =3D priv; unsigned int tmp_val; int ret; =20 - ret =3D regmap_read(rx8581->regmap, RX8581_REG_RAM, &tmp_val); + ret =3D regmap_read(regmap, RX8581_REG_RAM, &tmp_val); (*(unsigned char *)val) =3D (unsigned char) tmp_val; =20 return ret; @@ -220,12 +212,11 @@ static int rx85x1_nvram_read(void *priv, unsigned int= offset, void *val, static int rx85x1_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 =3D priv; + struct regmap *regmap =3D priv; unsigned char tmp_val; =20 tmp_val =3D *((unsigned char *)val); - return regmap_write(rx8581->regmap, RX8581_REG_RAM, - (unsigned int)tmp_val); + return regmap_write(regmap, RX8581_REG_RAM, (unsigned int)tmp_val); } =20 static const struct rx85x1_config rx8581_config =3D { @@ -248,7 +239,7 @@ static const struct rx85x1_config rx8571_config =3D { =20 static int rx8581_probe(struct i2c_client *client) { - struct rx8581 *rx8581; + struct regmap *regmap; const struct rx85x1_config *config =3D &rx8581_config; const void *data =3D of_device_get_match_data(&client->dev); struct rtc_device *rtc; @@ -276,15 +267,11 @@ static int rx8581_probe(struct i2c_client *client) if (data) config =3D data; =20 - rx8581 =3D devm_kzalloc(&client->dev, sizeof(struct rx8581), GFP_KERNEL); - if (!rx8581) - return -ENOMEM; - - i2c_set_clientdata(client, rx8581); + regmap =3D devm_regmap_init_i2c(client, &config->regmap); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); =20 - rx8581->regmap =3D devm_regmap_init_i2c(client, &config->regmap); - if (IS_ERR(rx8581->regmap)) - return PTR_ERR(rx8581->regmap); + i2c_set_clientdata(client, regmap); =20 rtc =3D devm_rtc_allocate_device(&client->dev); if (IS_ERR(rtc)) @@ -299,7 +286,7 @@ static int rx8581_probe(struct i2c_client *client) ret =3D devm_rtc_register_device(rtc); =20 for (i =3D 0; i < config->num_nvram; i++) { - nvmem_cfg[i].priv =3D rx8581; + nvmem_cfg[i].priv =3D regmap; devm_rtc_nvmem_register(rtc, &nvmem_cfg[i]); } =20 --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F15A26E62F for ; Fri, 28 Feb 2025 14:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751655; cv=none; b=aqGR8B/2e0kFCF7Lev2sIWXQ1X2y6ei/LKcJuEyFROY2ytIFPHXV/SFjSZqiuf7UUg8B75Oh4BG6aEB6bRiH37+XQyP4B6kVMBNFHhAiqIGJDVgOlIN7agTIgyhAymx3MGOI8ux0HceamYypcWFXZetXI2VtXpKsPgbElBnrPhw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751655; c=relaxed/simple; bh=fWzdE+Hu5xOwZqrVrpDeDLFG0S6j3Aw3nymZYqj35jQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WUi4aAvWacnh9nJHabGtJOrynYVQaSBV3KaeBTpMRHH7rDB2ffXytEwUHBd7j8BGWnh/O47vefl7AtZchmDy4KECRrogm0fUsw8NneWeKMJ5SMAJ4gAyWEHiaE41BlIqiPhgeGkPSICrbvEBw9/DBugY1D1HHWorikcDsbjk7GE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JodhXI1z; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JodhXI1z" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5deb1266031so3679058a12.2 for ; Fri, 28 Feb 2025 06:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751651; x=1741356451; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/r1ypkbSjtebcdcKcBz70+d9/hPyy6PTiaBKA6Wiwh8=; b=JodhXI1zeosrw04nHBmla+PiMvN97KQqyGOjn7WjAGmy5tKwpwUvXrolAs1dXjytx+ 1g8YQ9E5PUVKjg/DK5mQeGSoSRZ9r1Vvgxgk3tiCG8sdHmA9B0JwGYjMwOx8gGIRsOrX B7F0j3hUJ84AEu0TPczihCvLjF2HLKX2XUJ0ihNNO8OJGJMuHbSXCoxaVVDjQKvN/oM2 rT3FbdKk7MsNYGXSDVlyTG6fP8eeXYCT/iw1u3WvtwGBC22NVXB5dM3dw9u2lTK56UeJ U67muVpqhN+T2r8MBCFnXFYzdjb5qaw+37J8+R1Amgm8sbkYzFk53eRHwqW31adALoHr pwFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751651; x=1741356451; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/r1ypkbSjtebcdcKcBz70+d9/hPyy6PTiaBKA6Wiwh8=; b=dF2IqQFDauwVl4yMlNj46uMleKfodUKAaZWhAQPnKfDWc5+CGCqjdvD1cHXAkw2kID z3f19iCSih1lAIVOVU+6a4h+QfmtpCN38nzzkqWrgrI9rMHTdY9Txj1lwbMyzbpGoGJU RDOyoBC/YqY5wydM7aVVjBsT8Q3nH7idYUvsYuAvxpx1zDQbELM1iT7yZIg1FB7wpwn7 yvIwpvFqg/KDhmZQLVmMyy68BnsvRm1Nf/vHjaiCyIFA/hUQckuURPt1pC81bUKHswle 0rH6eJ2o+9KPIxWoO/+bebkdqUnoYEVlX6RrU9UNupIXK0NAOoixPiVGJh0uMatR+FaX rtcw== X-Gm-Message-State: AOJu0YzcS3Ao8RxWkQisNTl59tst36uvMW8aiWL0veANybz6ciAcAz9C 9BQ6XCJ9zsFwhSKdta5WD7Qo2ZkFMwigSb31nVwaTebDdSPUtw80S7IYEGmu2dg= X-Gm-Gg: ASbGncvcPaBLi6fMZMgdJLpBNR1s/FdBT8RsyKf82WmmNKW3fQa4i/XJT7CKa/6HHyS NLG7OF6UZi2pgy7UskeePmAx6WuxmkISsyRLYe9UO7JegbgEW3upq+QRkXD5g2xGWgYhpijdO/l mIncjx3jtzXhq2Xf9mi7vdaQpdF1ICft/e/8KT/5H7pxR0q70bDeybmwxlHvSYwCGnMwK6JAJGH q16zpYysSR0ESrulYxrlaRDmZKmdsTiSU6wexGgHny98uMdoQkwKe//yWB1dhbFXAUQNksoQjt3 2xodFrloE4l3e+3IZle00mXtoQoCVSID9sESQ7aISSaCh1bjYJ/D81sTNNT5iTKfaCOWBglnMSS pk/xe19l9nQ== X-Google-Smtp-Source: AGHT+IEmNzc9psOsG8S5U8hQjyEGUEZtM5fJSHlUXxz0d+LoEipOpq1K+57NoVXqKGgpzCnWIQsf3g== X-Received: by 2002:a05:6402:2711:b0:5de:dfd0:9d22 with SMTP id 4fb4d7f45d1cf-5e4d6b6ebf3mr3156214a12.22.1740751650904; Fri, 28 Feb 2025 06:07:30 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:30 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:29 +0000 Subject: [PATCH 16/18] rtc: sd3078: drop needless struct sd3078 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-16-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 This private data struct has one member only, there is no need to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation, reducing runtime memory consumption. Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-sd3078.c | 55 ++++++++++++++++++--------------------------= ---- 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index ebb4d45ce2409982880affbc7a85d5e7410c8f42..10cc1dcfc7748144f51ef674939= 506feee1fb471 100644 --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -36,10 +36,6 @@ */ #define WRITE_PROTECT_EN 0 =20 -struct sd3078 { - struct regmap *regmap; -}; - /* * In order to prevent arbitrary modification of the time register, * when modification of the register, @@ -48,14 +44,11 @@ struct sd3078 { * 2. set WRITE2 bit * 3. set WRITE3 bit */ -static void sd3078_enable_reg_write(struct sd3078 *sd3078) +static void sd3078_enable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, KEY_WRITE1); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, KEY_WRITE2); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, KEY_WRITE3); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, KEY_WRITE1); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, KEY_WRITE2); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, KEY_WRITE3); } =20 #if WRITE_PROTECT_EN @@ -68,14 +61,11 @@ static void sd3078_enable_reg_write(struct sd3078 *sd30= 78) * 2. clear WRITE3 bit * 3. clear WRITE1 bit */ -static void sd3078_disable_reg_write(struct sd3078 *sd3078) +static void sd3078_disable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, 0); } #endif =20 @@ -84,11 +74,10 @@ static int sd3078_rtc_read_time(struct device *dev, str= uct rtc_time *tm) unsigned char hour; unsigned char rtc_data[NUM_TIME_REGS] =3D {0}; struct i2c_client *client =3D to_i2c_client(dev); - struct sd3078 *sd3078 =3D i2c_get_clientdata(client); + struct regmap *regmap =3D i2c_get_clientdata(client); int ret; =20 - ret =3D regmap_bulk_read(sd3078->regmap, SD3078_REG_SC, rtc_data, - NUM_TIME_REGS); + ret =3D regmap_bulk_read(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "reading from RTC failed with err:%d\n", ret); return ret; @@ -122,7 +111,7 @@ static int sd3078_rtc_set_time(struct device *dev, stru= ct rtc_time *tm) { unsigned char rtc_data[NUM_TIME_REGS]; struct i2c_client *client =3D to_i2c_client(dev); - struct sd3078 *sd3078 =3D i2c_get_clientdata(client); + struct regmap *regmap =3D i2c_get_clientdata(client); int ret; =20 rtc_data[SD3078_REG_SC] =3D bin2bcd(tm->tm_sec); @@ -134,10 +123,10 @@ static int sd3078_rtc_set_time(struct device *dev, st= ruct rtc_time *tm) rtc_data[SD3078_REG_YR] =3D bin2bcd(tm->tm_year - 100); =20 #if WRITE_PROTECT_EN - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); #endif =20 - ret =3D regmap_bulk_write(sd3078->regmap, SD3078_REG_SC, rtc_data, + ret =3D regmap_bulk_write(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "writing to RTC failed with err:%d\n", ret); @@ -145,7 +134,7 @@ static int sd3078_rtc_set_time(struct device *dev, stru= ct rtc_time *tm) } =20 #if WRITE_PROTECT_EN - sd3078_disable_reg_write(sd3078); + sd3078_disable_reg_write(regmap); #endif =20 return 0; @@ -165,23 +154,19 @@ static const struct regmap_config regmap_config =3D { static int sd3078_probe(struct i2c_client *client) { int ret; - struct sd3078 *sd3078; + struct regmap *regmap; struct rtc_device *rtc; =20 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; =20 - sd3078 =3D devm_kzalloc(&client->dev, sizeof(*sd3078), GFP_KERNEL); - if (!sd3078) - return -ENOMEM; - - sd3078->regmap =3D devm_regmap_init_i2c(client, ®map_config); - if (IS_ERR(sd3078->regmap)) { + regmap =3D devm_regmap_init_i2c(client, ®map_config); + if (IS_ERR(regmap)) { dev_err(&client->dev, "regmap allocation failed\n"); - return PTR_ERR(sd3078->regmap); + return PTR_ERR(regmap); } =20 - i2c_set_clientdata(client, sd3078); + i2c_set_clientdata(client, regmap); =20 rtc =3D devm_rtc_allocate_device(&client->dev); if (IS_ERR(rtc)) @@ -195,7 +180,7 @@ static int sd3078_probe(struct i2c_client *client) if (ret) return ret; =20 - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); =20 return 0; } --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCC8E270052 for ; Fri, 28 Feb 2025 14:07:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751656; cv=none; b=gj7Md2POVHoorKhnBGJ/u6pm7bMmjlFz9aSD6VrqlWBk8ZDJJyEuxEwvCSsQRehk58fb+hDdQ/mYpfDmWMfyDOiv83RM0OpSlKl+gD6ZCIF5BltRmIC931HwqULZJUiTGAEdyIXbYZ0PJYDXiQApW7Xdx8z0flkcUuhbNwb75sY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751656; c=relaxed/simple; bh=K1YnffI9DtkL7cIsY9hYSQnQd4r9QfJylkyPV44F0aY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fhLhFv5iGQio6ydixTU7Yay67x6aIW5/HcHCe6/qGEVlq9qbKmZBmy+wHTxNjM4Y7l8RuNkHcFdIi+BjfPNFoQOjn+YUSuv69ufcwQGEeyYZ7gGx9NZF0odaZJlYTLSw4dn9ytirW9BdXdH4qXKpZMqb9tk/w4jNKFaz+akxHx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Fq2IaRUD; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Fq2IaRUD" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5dedae49c63so3851942a12.0 for ; Fri, 28 Feb 2025 06:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751652; x=1741356452; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J1wrjOZ25AMEbbC5RG2Bl34Xp7n5uiu5eMlW7fz5kxo=; b=Fq2IaRUDGGTVcTdoqKq/uXNxxWjhVn03scZGsguKU9PU6Q0wr0ayInn7XtBuXM8lz4 yDkx/GrB1E4zpJkmJXPxTgADPUi5N0GR/WdHsCpVJM+GzTJOY/eL2r8fFFvzp4IVCXlS ilpuIWd51quE/qXKrptdngdnQPZcI67eQkrlACdOCfLL22RD4zwvcC3rMIG039pnSXSD TIPhWmUu87i2MWzhQyi+QSEfxCXj9SKHRV5AEsOQ+ATzphTuDs7TayRYZQvCm5OQ0NcR M60dpxpwomQe/KYzOgrQBkAvWFeLd7KhDN2FICurQFrenTeayj9ihCvSdrvfzM7MUSk6 ABIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751652; x=1741356452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J1wrjOZ25AMEbbC5RG2Bl34Xp7n5uiu5eMlW7fz5kxo=; b=Zf5YNci274uHzJkqyU9JsHKtdWPSsXMviBiC/8DQQ5IDdFp9rdTjFZckBMNhImaniY jNNaujHX5tJl5Ba5yQKOLJcVJZ9o/cQUS2q7d3/NM9g9Da7vyCNkMJthu+3fbtM7ZDLs EhdnYBNipz3Sjs+hSXZiu/kVCWTQWYnBywRQP/WPm51KWeiIgctvwpq7ix/ANHiUi2IU EGTg6sdEw1yAUgHrEyd4v0Hd5AFcpQGAtpGF41cqUZlcbSkOAjWKVt91A76j5R2XTZQ3 vGcrT7WcmdvuQAoxXoefoak4qCoXxZVMiP/f0VTIULw9GlQGNCi5d/P+bsLxvkeXkmoi 47vQ== X-Gm-Message-State: AOJu0YxgNqM//V4i1QV36kKVmlPfa1mgAGFB7HgVjSS3QzdbtIb3fqgv Cn6qeOivENZKesWOK4QmYHhdVzYbX+ih4qHMoHHLNtW9L9Y+tZB/Qk57Pl6zLxk= X-Gm-Gg: ASbGncuR+XWRafSvsedGHoWykiP3Luw5nvCHkTaU01dy7O/AcHwFiHqTstFSuJs4bTx bYoiFb1eRuiu1V2eTPr7x34/UmFtjqREVl7Qoe2/KPPvMxbxe0C8U3VeQU+sBZJPF3wg9VQPS93 XZKo5TR7Icl/AoQzo4FaE6BMcUMhU/uc+l9sGDB8WdPVWTVKMxOqHsVi8Yfwmd03Z0R+w1vL7hm YyoNv+kkR2VA6vxukxX49tiLnUV6OrGz89miIR1HvzxB+89wdoC3YVM/z/ZLLZSzH2uoDXcIAFp TxKtUbHs6g6VysyFFWKUn4PT4xBpqiavvsZuBKzt0XtxRrdDBOEFnHg/p67nP3T8Rf41QbR6wbs 25X4qwtisdg== X-Google-Smtp-Source: AGHT+IH8oBqlrNujitdioxAVXjdPgLAryRZxpXTnrztyLFYptlh+GD/CB4rbFiDA0RhEFxZK1lBu3A== X-Received: by 2002:a05:6402:35c6:b0:5dc:c943:7b6 with SMTP id 4fb4d7f45d1cf-5e4d6ad4a6amr2900190a12.3.1740751651952; Fri, 28 Feb 2025 06:07:31 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:31 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:30 +0000 Subject: [PATCH 17/18] rtc: max77686: use dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-17-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-max77686.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 6b0d02b44c8097453f704cbec9f02580fb869ca3..69ea3ce75b5a5426d4a56b97977= 3be71c4ee7562 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -704,10 +704,9 @@ static int max77686_init_rtc_regmap(struct max77686_rt= c_info *info) } =20 info->regmap =3D dev_get_regmap(parent, NULL); - if (!info->regmap) { - dev_err(info->dev, "Failed to get rtc regmap\n"); - return -ENODEV; - } + if (!info->regmap) + return dev_err_probe(info->dev, -ENODEV, + "Failed to get rtc regmap\n"); =20 if (info->drv_data->rtc_i2c_addr =3D=3D MAX77686_INVALID_I2C_ADDR) { info->rtc_regmap =3D info->regmap; @@ -716,28 +715,24 @@ static int max77686_init_rtc_regmap(struct max77686_r= tc_info *info) =20 client =3D devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, info->drv_data->rtc_i2c_addr); - if (IS_ERR(client)) { - dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(client); - } + if (IS_ERR(client)) + return dev_err_probe(info->dev, PTR_ERR(client), + "Failed to allocate I2C device for RTC\n"); =20 info->rtc_regmap =3D devm_regmap_init_i2c(client, info->drv_data->regmap_config); - if (IS_ERR(info->rtc_regmap)) { - ret =3D PTR_ERR(info->rtc_regmap); - dev_err(info->dev, "Failed to allocate RTC regmap: %d\n", ret); - return ret; - } + if (IS_ERR(info->rtc_regmap)) + return dev_err_probe(info->dev, PTR_ERR(info->rtc_regmap), + "Failed to allocate RTC regmap\n"); =20 add_rtc_irq: ret =3D regmap_add_irq_chip(info->rtc_regmap, info->rtc_irq, IRQF_ONESHOT | IRQF_SHARED, 0, info->drv_data->rtc_irq_chip, &info->rtc_irq_data); - if (ret < 0) { - dev_err(info->dev, "Failed to add RTC irq chip: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "Failed to add RTC irq chip\n"); =20 return 0; } --=20 2.48.1.711.g2feabab25a-goog From nobody Sun Feb 8 12:32:47 2026 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CC05272904 for ; Fri, 28 Feb 2025 14:07:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751657; cv=none; b=Ehz+w9O8z3W/bEJSY/k2tJB0j844xUiql22VYZAn0blPegkn2BhHHj2Psr58YeaBJtdq/iKoWht7blFWEW49cXOl+o/cN7hJ0Z/Js2/Xe3eJ6MibO9LN4ngGqChuOB49G92p69I10h6KF/3vN3d9Mlwjkbm99YRd3ktBW2Wbqw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740751657; c=relaxed/simple; bh=v9dyh7vGu2dacgwW0mj5cIBOkYcMAu4WL7myCF88UoA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EY0TuH/pT1Tu18/LYamZ/wzmJ/tQPbqI1OLNw1bfOEGmntHb1KZEbDIIsSMYw/3A92u6ZrqbvVPvZUvXq8MSAazEfd5Y+z1W5yhOTF2zVlusfOposce++hQu3L92H9EiTXx3NNmhrtgmRpg+QnkkFB/KgN/2r6U7FMPn/zK1Qko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=psEjhImf; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="psEjhImf" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5e08064b4ddso2800597a12.1 for ; Fri, 28 Feb 2025 06:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751652; x=1741356452; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ucCmymGJlfsI4F5PNnMG7qiqKtfzqtFmwv0m9GhXqKs=; b=psEjhImf2z84Zyymr3jbDWSwcYu5wLvmzNG5Roh6x2DrxXe9THSO4gG6ngM8t8t0rN yDWLM7aqWx8COqo9pvgwZotIU0b5zrL9jSEgYObInU2IafnBc7laTM79iC9aYSxcv2Px lQFUYj1ZD7ZYqeJhwY5xWZg7Qj/ZJ0kDT37yFx6bDwsWMWTLrf9nzHtpke//CQ0qygpO 2S6U81Mi9ZHfpk0YQ4WC4Sue43tVFZLjEXOrzdZJKdM/vtV0uhCjeGu8vWhGz3U+8On9 TPzL+LrvVv20TXxvYA3/GRm4N895UZfD+3tbOVkIuh0Whyq+0nB3IXAtWV0GIZx3ofWu BZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751652; x=1741356452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ucCmymGJlfsI4F5PNnMG7qiqKtfzqtFmwv0m9GhXqKs=; b=t2Y0+v7QlR/xMa/W2iSe87WYY7sp18iXVkNXG6WL/fCZ2O9rPQUMvE9Ph3Q4/CWKj9 BDpIVpSgxJ82cy2ZtAhgyYkGtkgRy8zHfPJT/VxEPOaWzmJAP88YfnlxKa1+yvD92sSn I9Z/OMkq5qQ+B/NVVGroRjNRRMxe+U/7QA1K2jroPRvzzIY+lcntLcFhDEQEab1OV8Sd ZfnQDOqoVwKqUoqEw9AHnmlDpyN0slt7kWHxCgcb1u7vUPam15i2+wOxZgpBAllmWlxh gTv/CqwCzVwewggznp7EIg7uSugDqar4wfoAlo6ebY97Z987dUWkWIHBUPUAkY5So6b5 U7IA== X-Gm-Message-State: AOJu0Yw+gdGPEdSCL1BaLXbldARFmlrGA9sUZvYibUr2aQwuADMH4Nhl nvPXUVGbKgoJ7eKSaTykGJpdflaSkvhzBzH4nfr7Z1Q13LROI17MRLW9heDCFq0= X-Gm-Gg: ASbGncuQo2RGk2QUp2JILUlvh65RBLsEbQ27IzCEi/SrWe5oMRSRoWg8tNarEl409N/ MKxiTxR7V2sIjqFeTXn0s1HSa2AVuREpurO5Lo1hKyVFihluU0CcoYyuUKLPbjLT/61KAcLgiOu 5nLNXDqpdNw+hRRbH9IWXLkdDcjjewwm79yVTqQ1wxw6BzIVmzldkCNfGaG41XH0K78ZM7/JyTs klix0kNq7CAS+jkU0cwtSoPFPoAJ3TCcehiHVrdUU3dMFfURZ3qrJIYkWOKd2+4sNzVc8JvsZB4 B+FP1XX09nTtIMFzraYGLdEsbjc9G2XRLe2lK8kcE26SWRAQajMiBpceQECe22h/6qWA7HBDY7n WOVxYYIBlUg== X-Google-Smtp-Source: AGHT+IHUtKBxx/Kb6wMivayuykLjA27f1K+WzySysSQHyW8EvpaAIClZC0PRyUOpjP+2MS95jX29jw== X-Received: by 2002:a05:6402:35cd:b0:5db:f5bc:f696 with SMTP id 4fb4d7f45d1cf-5e4d6ad3e14mr2592499a12.5.1740751652457; Fri, 28 Feb 2025 06:07:32 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:32 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:31 +0000 Subject: [PATCH 18/18] rtc: s5m: convert to dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250228-rtc-cleanups-v1-18-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?q?T=C3=B3th_J=C3=A1nos?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 50 +++++++++++++++++++++--------------------------= --- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 77dd61c30681b8f0a2f23063ad5f7eb52f5b7158..4c66e38145b02638c48685580c7= 943bdf79bfbd4 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -626,11 +626,10 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *= info) } =20 info->rtc_24hr_mode =3D 1; - if (ret < 0) { - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", - __func__, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "%s: fail to write controlm reg\n", + __func__); =20 return ret; } @@ -669,26 +668,21 @@ static int s5m_rtc_probe(struct platform_device *pdev) alarm_irq =3D S5M8767_IRQ_RTCA1; break; default: - dev_err(&pdev->dev, - "Device type %lu is not supported by RTC driver\n", - platform_get_device_id(pdev)->driver_data); - return -ENODEV; + return dev_err_probe(&pdev->dev, -ENODEV, + "Device type %lu is not supported by RTC driver\n", + platform_get_device_id(pdev)->driver_data); } =20 i2c =3D devm_i2c_new_dummy_device(&pdev->dev, i2c->adapter, RTC_I2C_ADDR); - if (IS_ERR(i2c)) { - dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(i2c); - } + if (IS_ERR(i2c)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c), + "Failed to allocate I2C for RTC\n"); =20 info->regmap =3D devm_regmap_init_i2c(i2c, regmap_cfg); - if (IS_ERR(info->regmap)) { - ret =3D PTR_ERR(info->regmap); - dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", - ret); - return ret; - } + if (IS_ERR(info->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap), + "Failed to allocate RTC register map\n"); =20 info->dev =3D &pdev->dev; info->s5m87xx =3D s5m87xx; @@ -696,11 +690,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) =20 if (s5m87xx->irq_data) { info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) { - dev_err(&pdev->dev, "Failed to get virtual IRQ %d\n", - alarm_irq); - return -EINVAL; - } + if (info->irq <=3D 0) + return dev_err_probe(&pdev->dev, -EINVAL, + "Failed to get virtual IRQ %d\n", + alarm_irq); } =20 platform_set_drvdata(pdev, info); @@ -724,11 +717,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) ret =3D devm_request_threaded_irq(&pdev->dev, info->irq, NULL, s5m_rtc_alarm_irq, 0, "rtc-alarm0", info); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", - info->irq, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to request alarm IRQ %d\n", + info->irq); device_init_wakeup(&pdev->dev, true); } =20 --=20 2.48.1.711.g2feabab25a-goog