From nobody Sun Feb 8 13:27:34 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A65891A4E9D; Thu, 27 Feb 2025 11:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740656845; cv=none; b=lXsWNyKId36owVrtH8CVzy1WoU6w5XOjeJjn65LERZQEHojwSAQejM+b9oFNIyFGV3EtIQclTrF74tqiUGXCNVrACqqMWcNV/vTsP3tjAkaAdbeU3p9as3ZFDMQqm8TOd2J8st4XT+SeKku2iyTCEHvz12v2tJKPalldUmsigeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740656845; c=relaxed/simple; bh=CMGReD0WqsB5uzTiYELuHAlkALxDIGEWwbM9C6aIjt4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NKBcDKgRj6bV67WxE/Jt/aqrjZ4qhhZCK7GZ1naBtYOBn6P9SDKutefd5W6cPvIeIYmGS8OqTaxE1KLuB0ARm5BI7bIkgDYQqzXMmsY+O8Jy8xuNefKW9h2o1HCt/S0s6o3xW2xbXsTcpEAjwov82S0AqpQKmbxhBfL+a/gVckg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=nNbVrRRb; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nNbVrRRb" Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:a3f5:6799:2ce9:5b66]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A210F7F5; Thu, 27 Feb 2025 12:45:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740656753; bh=CMGReD0WqsB5uzTiYELuHAlkALxDIGEWwbM9C6aIjt4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nNbVrRRbOHj2qb2EDYltAkOsywSZzX+6+HSimopSAyVCAKq1UeOqYA2PGrgs8aA+A KDZe68m4fBapfK/vtkoUWGxBWkT7a2zk3ypB07klrxY+dvjNUu4sD2KrDdp7uHSQCR YyKSnKl4Suc/pvMMwfWwUrbV8bHm8jTqk+mg8KK4= From: Stefan Klug To: linux-media@vger.kernel.org, Laurent Pinchart , Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner Cc: Stefan Klug , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] media: rkisp1: Set format defaults based on requested color space Date: Thu, 27 Feb 2025 12:44:59 +0100 Message-ID: <20250227114558.3097101-2-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250227114558.3097101-1-stefan.klug@ideasonboard.com> References: <20250227114558.3097101-1-stefan.klug@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When color space JPEG is requested, the ISP sets the quantization incorrectly to limited range. To fix that, set the xfer_func, ycbcr_enc and quantization to the defaults for the requested color space if they are not specified explicitly. Do this only in case we are converting from RAW to YUV. Signed-off-by: Stefan Klug --- .../media/platform/rockchip/rkisp1/rkisp1-isp.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/= media/platform/rockchip/rkisp1/rkisp1-isp.c index d94917211828..468f5a7d03c7 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c @@ -680,10 +680,23 @@ static void rkisp1_isp_set_src_fmt(struct rkisp1_isp = *isp, if (sink_info->pixel_enc =3D=3D V4L2_PIXEL_ENC_BAYER) { if (format->colorspace !=3D V4L2_COLORSPACE_DEFAULT) src_fmt->colorspace =3D format->colorspace; - if (format->xfer_func !=3D V4L2_XFER_FUNC_DEFAULT) + + if (format->xfer_func =3D=3D V4L2_XFER_FUNC_DEFAULT) src_fmt->xfer_func =3D format->xfer_func; + else + src_fmt->xfer_func =3D + V4L2_MAP_XFER_FUNC_DEFAULT(format->colorspace); + if (format->ycbcr_enc !=3D V4L2_YCBCR_ENC_DEFAULT) src_fmt->ycbcr_enc =3D format->ycbcr_enc; + else + src_fmt->ycbcr_enc =3D + V4L2_MAP_YCBCR_ENC_DEFAULT(format->colorspace); + + if (format->quantization =3D=3D V4L2_QUANTIZATION_DEFAULT) + src_fmt->quantization =3D + V4L2_MAP_QUANTIZATION_DEFAULT(false, + format->colorspace, format->ycbcr_enc); } =20 if (format->quantization !=3D V4L2_QUANTIZATION_DEFAULT) --=20 2.43.0 From nobody Sun Feb 8 13:27:34 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33BA72206BE; Thu, 27 Feb 2025 11:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740656850; cv=none; b=akyMUl0r30eshR//fhvqMR1XAwvYHiLwAHttXekUb56ByyfPf42a/Q2igAPooKGsg0UlxGAFs5p1ARjA+geEjhEMXqMHnmJUN6Qcf6sVx4yVZYAyh4ObM12K3yhAwdxn7gLsWDDLdhATE7eEfZ0F8vvezhO+esHug6F4fBvVrH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740656850; c=relaxed/simple; bh=ZMtBQPd4FzhfOHdAq6GWMwplFQzrNJIKsTRatQkysMg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jHfmOp0kzfbgQBNeiLuOyAu0yLoYZSEiNBzQlYnE8mUyojyJkZLoe7Wv79EwnzR1zbEDslYiIWS18SUSdu+SctCyzITQTBhDW3oXrfO8qAP8OHiBo8ocPrGR3Upzp6cIQX8aMzRsvxD/PfBalrK+MNVF2XKur2F0wX2qrfVa8Co= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=WrfOY8eA; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WrfOY8eA" Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:a3f5:6799:2ce9:5b66]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 219757F5; Thu, 27 Feb 2025 12:45:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740656759; bh=ZMtBQPd4FzhfOHdAq6GWMwplFQzrNJIKsTRatQkysMg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WrfOY8eAN6//OTBhu3YmHBaQHHnd6K7fP80Uf5lGh1eAnoiNPebMw8JPai2n30yuf dx3Rpz0+2sNYuDtO573n4+1SnwYUhqdCK19mm6UtYt8vnImVAhHN+UfoC52qwnaG/s cqlHsK8BNx8+TlJNCDyjBIV9gQiy6zZ0qCuVk+38= From: Stefan Klug To: linux-media@vger.kernel.org, Laurent Pinchart , Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner Cc: Stefan Klug , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] media: rkisp1: Fix the quantization settings of CPROC Date: Thu, 27 Feb 2025 12:45:00 +0100 Message-ID: <20250227114558.3097101-3-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250227114558.3097101-1-stefan.klug@ideasonboard.com> References: <20250227114558.3097101-1-stefan.klug@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On the imx8mp the Image Effect module is not supported. In my case the effect variable had an uninitialized default value of 0x700 leading to limited YUV range in all cases (effects were never touched from user space). The effects configuration is as far is I understand completely independent of CPROC. Completely remove that check. This fixes full range mode on imx8mp and possibly others. Signed-off-by: Stefan Klug --- drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drive= rs/media/platform/rockchip/rkisp1/rkisp1-params.c index b28f4140c8a3..8d61e21ad475 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c @@ -764,11 +764,6 @@ static void rkisp1_aec_config_v12(struct rkisp1_params= *params, static void rkisp1_cproc_config(struct rkisp1_params *params, const struct rkisp1_cif_isp_cproc_config *arg) { - struct rkisp1_cif_isp_isp_other_cfg *cur_other_cfg =3D - container_of(arg, struct rkisp1_cif_isp_isp_other_cfg, cproc_config); - struct rkisp1_cif_isp_ie_config *cur_ie_config =3D - &cur_other_cfg->ie_config; - u32 effect =3D cur_ie_config->effect; u32 quantization =3D params->quantization; =20 rkisp1_write(params->rkisp1, RKISP1_CIF_C_PROC_CONTRAST, @@ -778,8 +773,7 @@ static void rkisp1_cproc_config(struct rkisp1_params *p= arams, rkisp1_write(params->rkisp1, RKISP1_CIF_C_PROC_BRIGHTNESS, arg->brightness); =20 - if (quantization !=3D V4L2_QUANTIZATION_FULL_RANGE || - effect !=3D V4L2_COLORFX_NONE) { + if (quantization !=3D V4L2_QUANTIZATION_FULL_RANGE) { rkisp1_param_clear_bits(params, RKISP1_CIF_C_PROC_CTRL, RKISP1_CIF_C_PROC_YOUT_FULL | RKISP1_CIF_C_PROC_YIN_FULL | --=20 2.43.0 From nobody Sun Feb 8 13:27:34 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67D7722CBE8; Thu, 27 Feb 2025 11:47:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740656854; cv=none; b=YsqXYHLazuPM3MoPotqyo1HebQFYw/QRC1iSEI6ulUGdHSMmoVdSN1uxyEMaX2to/yFn1y9jh4HgEu7HvP26AfujGOAYNkHBdSmXnpv3GGHHbo8ZHdMy8h2/dwzGdNpBu2tAHK6oLRzE4fnBihp1G/eaPapffuLBnJg8TISC8JM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740656854; c=relaxed/simple; bh=P9xqUjKbHM5Je+UfdaKgLXkxGRlIAHd1iEy80IGgQXE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KMQM/FR/5mN8yZjoBUDsFb9ISVKC36+WDvUfF8R79r3HBtEG+S+6rl/2i/1u8Kzmuw4pFnWxQqV0LolimlUHgt7fFbSdtsnzz+UZShr21pZ7qeF/Mi5POkFK6kyeLYlDgPrSjZWVn1SGEAMZSr23ejXHnK7NeZGpTxn+MAzBENc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=TCN0cIHz; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TCN0cIHz" Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:a3f5:6799:2ce9:5b66]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DFD27F5; Thu, 27 Feb 2025 12:46:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740656763; bh=P9xqUjKbHM5Je+UfdaKgLXkxGRlIAHd1iEy80IGgQXE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TCN0cIHzr1IRMzTI7bhy1uuEj1SRVAB00NAagrYvtrsx4PI91VFfxUNlIEg/EzI02 1Hl0d4eE73DYpypXFuli6Yj27dkq5nre2BNTyUIHQf9DIlWA0JJ6PKtP6jd6RpWBRF CZKearkxFmOjwsNV9nLve8me29659QOwH6R21HdQ= From: Stefan Klug To: linux-media@vger.kernel.org, Laurent Pinchart , Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner Cc: Stefan Klug , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] media: rkisp1: Remove unnecessary defines Date: Thu, 27 Feb 2025 12:45:01 +0100 Message-ID: <20250227114558.3097101-4-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250227114558.3097101-1-stefan.klug@ideasonboard.com> References: <20250227114558.3097101-1-stefan.klug@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The effect modes are not shifts but numbers which are already defined a few lines above. Remove the misleading defines. Signed-off-by: Stefan Klug Reviewed-by: Laurent Pinchart --- drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers= /media/platform/rockchip/rkisp1/rkisp1-regs.h index bf0260600a19..139177db9c6d 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h @@ -327,13 +327,6 @@ #define RKISP1_CIF_IMG_EFF_CTRL_CFG_UPD BIT(4) #define RKISP1_CIF_IMG_EFF_CTRL_YCBCR_FULL BIT(5) =20 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_BLACKWHITE_SHIFT 0 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_NEGATIVE_SHIFT 1 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_SEPIA_SHIFT 2 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_COLOR_SEL_SHIFT 3 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_EMBOSS_SHIFT 4 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_SKETCH_SHIFT 5 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_SHARPEN_SHIFT 6 #define RKISP1_CIF_IMG_EFF_CTRL_MODE_MASK 0xe =20 /* IMG_EFF_COLOR_SEL */ --=20 2.43.0