From nobody Fri Dec 19 05:31:33 2025 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E858218585; Thu, 27 Feb 2025 06:01:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636109; cv=none; b=gke33x5ImaC7h6f8hKrAMpUYJ6nJe0Bq86APEcqQvT9xvDGvERhL9Z6FGMTTdDQtkHZ3DcSA4d1fd5hsAZFA8EJxxFCFgiV1wtSJywGRv3qgb6NtZprNLWbMHyz2WgvAAbGR2Jszw7NKCJUAMh5UQVWmduxW2csQ6H+4dCcx+kU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636109; c=relaxed/simple; bh=KC3evV8+E4TMmXJsaHaV+xF+Zlwo3/sRwLFbnpUYLeo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JhnHjesza3A4tslV+Xy4gEYDs8W/TsaD59hgue7a2IwV+eV4LidNHpuzqgM08OcJ7pFC2wWEz+KsVGhmgGd5XTMw5Fo5maa3UiH3QGn+8CS6yx5tP96BPASmabXl3RtDYqC3YqK0Y4vy3Ji7RETmWDCE0EoI7aNE58WiJ+sLh7Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CDdgiBS/; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CDdgiBS/" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2211cd4463cso8939635ad.2; Wed, 26 Feb 2025 22:01:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636107; x=1741240907; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=CDdgiBS/cL9CmxQjLsLkgzWqTPVyjzN0JstO48/s+SePScZ4j74azHug6Akt36fOHO 5ZmhfuzMSqdXHK6eNJBQyC6HitBWPzMTAiIIGCkh6mriyRQ3dcVI4QavWJaVygnNRPtz OriVInGj/ChJRAPykVycSqxmi4uzVQqDy7FRmwB0IWYgPuDcSP7AfGBCe6fmvVlbgOG4 Zrxg/Ur5k7qp2yG2z6Rjfv11UphnLmnfQcpL8sYMOWHWH2SZjYyXi1SEmGJPWqQEg/8A 3ou78KP6LHEYKJEcfFFMhWNViuTONj+CWYhGSewZdILK3ttBcY7PZAoJrgcu4FmNV/jM 8ElA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636107; x=1741240907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=EL13EptH5iLaPTtXhDs0leqnxE3by/w/Bx1KEhyzsQVQ+XkgBtJFd476auz7/4nW9y p75URjTayuacWLQUa2S5jipFBCkbn7F3DLU4lgn9ewhP31Ks3Adi3elND7ygATwdQp+6 AuPFKPr4EjetR/7nS2eV6frJkT9hBMbbcK4E8UNAHsBCVWSAjcYA2AVo7WocT2RSAMir 4olECmQhKDHGzU/fuS9y6mm10k/jZtQXoKSHzkjzAWNPjwO4jaQ05NJUhSCB47VJ85By ZpM6BiVGblSKzvG6APPpkDEnkinMaye4yziPg/5/BLcpV8kYJBCCDBLun2DuIA6ha71I UXQA== X-Forwarded-Encrypted: i=1; AJvYcCWLZJ4pCU2FyVoFTbIHFXnW3Gxi+1I7vmI/GiHFSb38UAkLILp9QRz5cCDc6EV8FClWosdgmdJEOCiv@vger.kernel.org X-Gm-Message-State: AOJu0YzMPdcnX5I6AlZobI/lhmS2v7fqZWidHAcN2QYc3rSy098V27z9 dDTRnxrtp8+AyX0fGFlQku402F4rQSeTxg3//9urUJxFDzgpS6C+ X-Gm-Gg: ASbGncs32ft/GBrMrFDFdfUxJ635z2keG5Sc/XC87zimekxdohx8iztZCO8e8W29o20 gEoZnFj3K2O5YRWvP/WTvAryaenlzo++86we22YPbXbhyC8i1YLDBrBbzarJJCuCZoz1KiShGNs pWJ0q3g7KBSFccvizu3xstxx6YIh798wqKp1JrUCzSJFmiZ+5PHvUX54fKokqqm5rFR5qdGlTi6 AcX8E1s30EwNc/sQRFAk0mjUldSJiGqeOzwiwHiWQlTuKKoA/kIBhS4Yyw05WClLsho9lujU8TB AoRauDgLbmaR2ouCml9vAkSTTZTvtSSscp9m X-Google-Smtp-Source: AGHT+IFUBTM3E9ZUTYM/b7On4JzvSLZbPDNefBic4lp+FqFMQP4Iebm5RLt6/QZBY9X9G7Gd7D0Cdw== X-Received: by 2002:a17:902:d4cc:b0:215:a04a:89d5 with SMTP id d9443c01a7336-22307b33034mr151602275ad.2.1740636107465; Wed, 26 Feb 2025 22:01:47 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:47 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, Frank Li , Krzysztof Kozlowski Subject: [PATCH v5 1/5] dt-bindings: i3c: silvaco: Add npcm845 compatible string Date: Thu, 27 Feb 2025 14:01:27 +0800 Message-Id: <20250227060131.2206860-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Need to add a new compatible string to distinguish between different hardware versions. Reviewed-by: Frank Li Acked-by: Krzysztof Kozlowski Signed-off-by: Stanley Chu --- Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml = b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml index c56ff77677f1..4fbdcdac0aee 100644 --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml @@ -14,7 +14,9 @@ allOf: =20 properties: compatible: - const: silvaco,i3c-master-v1 + enum: + - nuvoton,npcm845-i3c + - silvaco,i3c-master-v1 =20 reg: maxItems: 1 --=20 2.34.1 From nobody Fri Dec 19 05:31:33 2025 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3645521B9FA; Thu, 27 Feb 2025 06:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636112; cv=none; b=PomkGrbvg2T1UShGYcRHHjKmHCmRRF0svEy18QsTYykBnc87tqzy9Xvqox/y1ViAWiSS475I51LuMCMT1iGGyqcmUKZ5Lx5DqjGDF3xwFCkwOvlkQ9tlzDu1lLIxXum1UZ78LJUwee/IlKOJ519szBu0bRSoT/edvTrP0gV+4Hk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636112; c=relaxed/simple; bh=WgQiFtvSaXDUKj25QoRJIdQwRAilkoADHx3Rz71ZUf4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=twHnY8A6X+mJyXDBVLR9qgZRQLG16ao08gpfMzaKczOQhZrkvNDNoN8NBGNj/wVMErfRB4v0YX4Lkr1qF7+loWfvVBcQU+v+Kulm6IXMQtDXq1aNyof81ZOxyv2iWgXIokZqyJr+zt6Ug6W+ebAIpMvujxS9DbTHslKLwmfdThE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HMBeHwMg; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HMBeHwMg" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2fe98d173daso983589a91.1; Wed, 26 Feb 2025 22:01:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636110; x=1741240910; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=okBbsi8R7J7tXxfGwTKtAERjRy2rLXaYUYDOVdToU2Y=; b=HMBeHwMgaMHiyNiw8EXQHBOeR5cnwrWbHWQciR8tqzWjpZSFDdDwTAAOA/tcFBgmEr v8IxSyhK9CgKAcuAeXL7b0OYHIZsvSBSeNeUOnyMyIN6wmHKHPuna6zJUhG+yO4M9yzX aAASunUJaXyt5jOLDrePbQ6wEYxgC2oCFalbxnvDr4hjUWi3uK/jGHMoJ9pk35X0hNRq wJVcvDU59fKW43Szf2J6wOkcl1i7hOyJtfT5nMfRE5VD/H51QUiEucuolK5LWHSV7+mY DVY8K3UOdlHhINwSBPetn2hx/qx91y/DW/9ti1q0okEhHDv0T/dzWJJjoUOb5a5aVjhV XePg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636110; x=1741240910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=okBbsi8R7J7tXxfGwTKtAERjRy2rLXaYUYDOVdToU2Y=; b=Qoa5XUcndvpdh4LXBouMgNyhXIR+lvDNyW24GIT4q67VakQ/wGgFQwb+FgLWwFOk5u ZAMcLunGNI7GrynVrFutY+/bKwvCzTSq3fZ0t7/f6A8ifuCJdpZBYtHS2ncjIszTb8FB PaUaY20ZN8I8258F5DFIiiK8/twUco7MgyfNynlm7sx9H847lSetWwdVT4iSeITC7tq/ q8IsNznx75DR0JEo7TC/0WOYrHBCwHzD+a3h+ydcIKITyakQzmsEXHXtI8ZDsJeOPBuX +bZAYCTAYm+U/o1OSRLKNEIWuLh+N7q+8ouZmSp7R+fw7TVXJU95np7gbqHs+eXWOBfB vY5A== X-Forwarded-Encrypted: i=1; AJvYcCV3pWGTAFn3DwT/UkCELDPqkBRtBgqNuMcvcUgFA8W9byBN5Fow7yRbddWyV1R5lNdG+vbw3UvczlZu@vger.kernel.org X-Gm-Message-State: AOJu0YwDB+nnyWoIexloykoZMZZ7Q/FSalou8IfZuoAqH2jKmtPyV8mm rmPav67KWIkv4d6F8TP6eaHqclePg0jYIGQwv4zbGR1lm9yih1+9 X-Gm-Gg: ASbGncu+Iv9IXLR7nOBfzn8JutpqyNURb89ASHy37Sez4oRlAZdAlv9S+bU+uLfcXb2 hev4Yhp1ccHGjF+9eR6Y6ualhru+gduf4QjxmrSE8IuFsiCvKVJYSOAe61k0Y+Ii9CZSnqLOgsy o7hSoL9OTaV7tI7mb2h8mFsc+C4NeQYDo+X1h4MumqN7nAihPM8FHNiQ1GPJqLXCnttX2fx40kv yxxjEKwsSQ+VaZRcv6mcFA9ZNH4vd67Mxpdg7XFS3zw2OFBA/wRwQmS0W7vDOODDnL3A10wA1jD W2SUjVA9V0A2ZGBEfG9SZnwXcQ+RFkCnpHEe X-Google-Smtp-Source: AGHT+IHTzGNN16mA3hpJreOiHYFjyZ3AeGJoP48E0laGo4020Qg/YZh8K/FYFaSVpFevtJH+vOQWPQ== X-Received: by 2002:a17:90b:5148:b0:2ee:c9b6:4c42 with SMTP id 98e67ed59e1d1-2fce86cf0ebmr42714472a91.16.1740636110407; Wed, 26 Feb 2025 22:01:50 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:50 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v5 2/5] i3c: master: svc: Add support for Nuvoton npcm845 i3c Date: Thu, 27 Feb 2025 14:01:28 +0800 Message-Id: <20250227060131.2206860-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Add quirks to address the npcm845 specific issues. FIFO empty issue: I3C HW stalls the write transfer if the transmit FIFO becomes empty, when new data is written to FIFO, I3C HW resumes the transfer but the first transmitted data bit may have the wrong value. Invalid SlvStart event: I3C HW may generate an invalid SlvStart event when emitting a STOP. DAA process corruption: When MCONFIG.SKEW=3D0 and MCONFIG.ODHPP=3D0, the ENTDAA transaction gets corrupted and results in a no repeated-start condition at the end of address assignment. Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 56 ++++++++++++++++++++++++++++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index d6057d8c7dec..9143a079de53 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -32,6 +32,7 @@ #define SVC_I3C_MCONFIG_ODBAUD(x) FIELD_PREP(GENMASK(23, 16), (x)) #define SVC_I3C_MCONFIG_ODHPP(x) FIELD_PREP(BIT(24), (x)) #define SVC_I3C_MCONFIG_SKEW(x) FIELD_PREP(GENMASK(27, 25), (x)) +#define SVC_I3C_MCONFIG_SKEW_MASK GENMASK(27, 25) #define SVC_I3C_MCONFIG_I2CBAUD(x) FIELD_PREP(GENMASK(31, 28), (x)) =20 #define SVC_I3C_MCTRL 0x084 @@ -133,6 +134,32 @@ #define SVC_I3C_EVENT_IBI GENMASK(7, 0) #define SVC_I3C_EVENT_HOTJOIN BIT(31) =20 +/* + * SVC_I3C_QUIRK_FIFO_EMPTY: + * I3C HW stalls the write transfer if the transmit FIFO becomes empty, + * when new data is written to FIFO, I3C HW resumes the transfer but + * the first transmitted data bit may have the wrong value. + * Workaround: + * Fill the FIFO in advance to prevent FIFO from becoming empty. + */ +#define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) +/* + * SVC_I3C_QUIRK_FLASE_SLVSTART: + * I3C HW may generate an invalid SlvStart event when emitting a STOP. + * If it is a true SlvStart, the MSTATUS state is SLVREQ. + */ +#define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) +/* + * SVC_I3C_QUIRK_DAA_CORRUPT: + * When MCONFIG.SKEW=3D0 and MCONFIG.ODHPP=3D0, the ENTDAA transaction gets + * corrupted and results in a no repeated-start condition at the end of + * address assignment. + * Workaround: + * Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA + * process is completed, return MCONFIG.SKEW to its previous value. + */ +#define SVC_I3C_QUIRK_DAA_CORRUPT BIT(2) + struct svc_i3c_cmd { u8 addr; bool rnw; @@ -158,6 +185,10 @@ struct svc_i3c_regs_save { u32 mdynaddr; }; =20 +struct svc_i3c_drvdata { + u32 quirks; +}; + /** * struct svc_i3c_master - Silvaco I3C Master structure * @base: I3C master controller @@ -183,6 +214,7 @@ struct svc_i3c_regs_save { * @ibi.tbq_slot: To be queued IBI slot * @ibi.lock: IBI lock * @lock: Transfer lock, protect between IBI work thread and callbacks fro= m master + * @drvdata: Driver data * @enabled_events: Bit masks for enable events (IBI, HotJoin). * @mctrl_config: Configuration value in SVC_I3C_MCTRL for setting speed b= ack. */ @@ -214,6 +246,7 @@ struct svc_i3c_master { spinlock_t lock; } ibi; struct mutex lock; + const struct svc_i3c_drvdata *drvdata; u32 enabled_events; u32 mctrl_config; }; @@ -230,6 +263,25 @@ struct svc_i3c_i2c_dev_data { struct i3c_generic_ibi_pool *ibi_pool; }; =20 +const struct svc_i3c_drvdata svc_default_drvdata =3D {}; +const struct svc_i3c_drvdata npcm845_drvdata =3D { + .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY | + SVC_I3C_QUIRK_FALSE_SLVSTART | + SVC_I3C_QUIRK_DAA_CORRUPT, +}; + +static inline bool svc_has_quirk(struct svc_i3c_master *master, u32 quirk) +{ + return (master->drvdata->quirks & quirk); +} + +static inline bool svc_has_daa_corrupt(struct svc_i3c_master *master) +{ + return ((master->drvdata->quirks & SVC_I3C_QUIRK_DAA_CORRUPT) && + !(master->mctrl_config & + (SVC_I3C_MCONFIG_SKEW_MASK | SVC_I3C_MCONFIG_ODHPP(1)))); +} + static inline bool is_events_enabled(struct svc_i3c_master *master, u32 ma= sk) { return !!(master->enabled_events & mask); @@ -1868,6 +1920,7 @@ static int svc_i3c_master_probe(struct platform_devic= e *pdev) } =20 platform_set_drvdata(pdev, master); + master->drvdata =3D of_device_get_match_data(dev); =20 pm_runtime_set_autosuspend_delay(&pdev->dev, SVC_I3C_PM_TIMEOUT_MS); pm_runtime_use_autosuspend(&pdev->dev); @@ -1959,7 +2012,8 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { }; =20 static const struct of_device_id svc_i3c_master_of_match_tbl[] =3D { - { .compatible =3D "silvaco,i3c-master-v1"}, + { .compatible =3D "silvaco,i3c-master-v1", .data =3D &svc_default_drvdata= }, + { .compatible =3D "nuvoton,npcm845-i3c", .data =3D &npcm845_drvdata }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl); --=20 2.34.1 From nobody Fri Dec 19 05:31:33 2025 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D7AB21CC78; Thu, 27 Feb 2025 06:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636115; cv=none; b=TqDECLGBm5QrvGot0Rr1/JW1BjZN7KA+Qbuus7v91HzfCFd0q15lx6WBVAH+zvpXsAED0VeJY7kJMlNOk06qQ/F8RA1n9ZxYP6jyA4HBf6GzF6HYY4kjpWMTG8vhdElj2nzeFKZD7/32T9OPXi0Yv8zpgdBNpZKCthnKdVz+Rkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636115; c=relaxed/simple; bh=n5x1RSWO88eudXIOnQe5F6cW1vLQoM5iOAUvbK3otuI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qnzqghbAWcDgGSgVz92VxtrgFtIi30/muaqolEXamqOrjVxJvprAm92gnXktl80O+9pIaIIEejK4pwj3PCQC6Yl9jLEOG9TeAOrsfp3HcZpj3aqxS5H/1FWcA+TLoE4lR/JrTkemsRrwy5BPMFSMN2fH/UGsdOjxol3Og9+werM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XMFrObb2; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XMFrObb2" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2f441791e40so964885a91.3; Wed, 26 Feb 2025 22:01:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636113; x=1741240913; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jkvj3L9bGHMjbRbwPbZT9vYFOnv0oJXGKH8ygdTiAFw=; b=XMFrObb2l79xaNMksRhsyds/2CVpWYybKSU1NzOgsWMqFZDMCJi3GQ4qLSgQC/lPFe C12WQKa+c96kn6KFUTE/OmlNN4vi5Uu146+jFvjJlFxJDYDX5ByZZYoY+mpB2+IUxYn/ f7loFoyXlnLFCFdM9foKQEZLOfSfROpyhpflV+Xfe0O6RYbi7Y14e1ZMgq9MQvRZRxtW URzudA5YkfQysz5XtI5JEKSVSyDUXyi19m4ygjsY4rkIp1M31ff6VuD0uOzNL9l3/MHB bqhIeIOH97gSUO4AqEOmVAvUBu97tkBFZoUUH7l8/zltq48vGxSSQspXi95J06Kz12NL jj+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636113; x=1741240913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jkvj3L9bGHMjbRbwPbZT9vYFOnv0oJXGKH8ygdTiAFw=; b=rqHx8K1O9PHXxCmg49WHWsC7vAvgAcmT2gjPKZzy2ZFL8HYBhFxce1eskVT9qp090w KJztOrfTXk9E3dk4ghggOCKsR2d7S/N6/ZR3HT2yCC9g83r322GRlx9EmMk1dOS21/ZA k/xh20RZha/hJAOQ8u6lm58xSbzAFWFqIBF1RRDVR+aZWOsvf/1klERVmXR+0pRS8Ub1 ABEqaJSW+jQFLdu7cfttipVcMmWX/r5gUyV3+ZmY6m0mJOGpLanP0AiqfvLs9bSDx9kD iCMoc49a7GkdR/k0LDWnVM5/6XQrVwwEHa4BZ1jJFb6zuVF1iVK1TBlFoupu/k+BS5M0 d7WA== X-Forwarded-Encrypted: i=1; AJvYcCUXhZmsSf9iKGv+AC3Qlb4THtsGE8Soby+kueXun778fNrCJpACw6oJ1kbO4amdyFtD00XJeLdk+0In@vger.kernel.org X-Gm-Message-State: AOJu0YxM3Fxo6bA2gcBAqiKpxEO0GtmkO+S121cTPW+qVtg2HIe1apOS +U8PIb4vP16wuE08ijAopmpRF+oF9/VOP3u8G6LfhEhTj7M34hYo X-Gm-Gg: ASbGncsEWSIk1Ga/DaijUhYeXPSb6f5jhdj58ZAOOlCTkDMXnO61twDVWTISmpVFjpc 8pVIDDUhsvE9PJnlKcw79CHEsigTc73XQXpyVArmb9wQRuTfJXg7/tG69yE6FSnz51FZzM9Y0Mk XQ0gv9K2zbsV10dWrrY6TXU76ez/TbAoMVjGt1HmQrgbBZkaUdlLeyW52ujb4npBeAahTLX7Ycx QlXpXv+ssC9lvRigp5elqSePtg81O+91Cu6P0/tfIBC1SoLARCrKmcOPnTLpK1+hKS/aoJ3MJ5Z iLQM9pv0Rv32rcVIhdjx5+VKlXxXbzH6PLXr X-Google-Smtp-Source: AGHT+IGJf1EprWbsXZ2jFkUl5sHahMq3HVyinxDfNpi1XqlJ5NGR7aG6ByojzGWqVWyAfi7gUIv7zQ== X-Received: by 2002:a17:90b:1f81:b0:2ee:d433:7c50 with SMTP id 98e67ed59e1d1-2fce873af2cmr32572563a91.23.1740636113433; Wed, 26 Feb 2025 22:01:53 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:53 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v5 3/5] i3c: master: svc: Fix npcm845 FIFO empty issue Date: Thu, 27 Feb 2025 14:01:29 +0800 Message-Id: <20250227060131.2206860-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu I3C HW stalls the write transfer if the transmit FIFO becomes empty, when new data is written to FIFO, I3C HW resumes the transfer but the first transmitted data bit may have the wrong value. Fill the FIFO in advance to prevent FIFO from becoming empty. Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 52 ++++++++++++++++++++++++----- 1 file changed, 43 insertions(+), 9 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 9143a079de53..a0c6d8053a25 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -114,6 +114,7 @@ #define SVC_I3C_MWDATAHE 0x0BC #define SVC_I3C_MRDATAB 0x0C0 #define SVC_I3C_MRDATAH 0x0C8 +#define SVC_I3C_MWDATAB1 0x0CC #define SVC_I3C_MWMSG_SDR 0x0D0 #define SVC_I3C_MRMSG_SDR 0x0D4 #define SVC_I3C_MWMSG_DDR 0x0D8 @@ -940,7 +941,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_= master *master, u8 *addrs, unsigned int *count) { u64 prov_id[SVC_I3C_MAX_DEVS] =3D {}, nacking_prov_id =3D 0; - unsigned int dev_nb =3D 0, last_addr =3D 0; + unsigned int dev_nb =3D 0, last_addr =3D 0, dyn_addr; u32 reg; int ret, i; =20 @@ -983,6 +984,25 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c= _master *master, if (SVC_I3C_MSTATUS_RXPEND(reg)) { u8 data[6]; =20 + /* + * One slave sends its ID to request for address assignment, + * prefilling the dynamic address can reduce SCL clock stalls + * and also fix the SVC_I3C_QUIRK_FIFO_EMPTY quirk. + * + * Ideally, prefilling before the processDAA command is better. + * However, it requires an additional check to write the dyn_addr + * at the right time because the driver needs to write the processDAA + * command twice for one assignment. + * Prefilling here is safe and efficient because the FIFO starts + * filling within a few hundred nanoseconds, which is significantly + * faster compared to the 64 SCL clock cycles. + */ + dyn_addr =3D i3c_master_get_free_addr(&master->base, last_addr + 1); + if (dyn_addr < 0) + return -ENOSPC; + + writel(dyn_addr, master->regs + SVC_I3C_MWDATAB); + /* * We only care about the 48-bit provisioned ID yet to * be sure a device does not nack an address twice. @@ -1061,21 +1081,16 @@ static int svc_i3c_master_do_daa_locked(struct svc_= i3c_master *master, if (ret) break; =20 - /* Give the slave device a suitable dynamic address */ - ret =3D i3c_master_get_free_addr(&master->base, last_addr + 1); - if (ret < 0) - break; - - addrs[dev_nb] =3D ret; + addrs[dev_nb] =3D dyn_addr; dev_dbg(master->dev, "DAA: device %d assigned to 0x%02x\n", dev_nb, addrs[dev_nb]); - - writel(addrs[dev_nb], master->regs + SVC_I3C_MWDATAB); last_addr =3D addrs[dev_nb++]; } =20 /* Need manual issue STOP except for Complete condition */ svc_i3c_master_emit_stop(master); + svc_i3c_master_flush_fifo(master); + return ret; } =20 @@ -1272,6 +1287,24 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, SVC_I3C_MCTRL_RDTERM(*actual_len), master->regs + SVC_I3C_MCTRL); =20 + /* + * The entire transaction can consist of multiple write transfers. + * Prefilling before EmitStartAddr causes the data to be emitted + * immediately, becoming part of the previous transfer. + * The only way to work around this hardware issue is to let the + * FIFO start filling as soon as possible after EmitStartAddr. + */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FIFO_EMPTY) && !rnw && xfer_len)= { + u32 end =3D xfer_len > SVC_I3C_FIFO_SIZE ? 0 : BIT(8); + u32 len =3D min_t(u32, xfer_len, SVC_I3C_FIFO_SIZE); + + writesb(master->regs + SVC_I3C_MWDATAB1, out, len - 1); + /* Mark END bit if this is the last byte */ + writel(out[len - 1] | end, master->regs + SVC_I3C_MWDATAB); + xfer_len -=3D len; + out +=3D len; + } + ret =3D readl_poll_timeout(master->regs + SVC_I3C_MSTATUS, reg, SVC_I3C_MSTATUS_MCTRLDONE(reg), 0, 1000); if (ret) @@ -1360,6 +1393,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, emit_stop: svc_i3c_master_emit_stop(master); svc_i3c_master_clear_merrwarn(master); + svc_i3c_master_flush_fifo(master); =20 return ret; } --=20 2.34.1 From nobody Fri Dec 19 05:31:33 2025 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C20B21D5AD; Thu, 27 Feb 2025 06:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636118; cv=none; b=In7F6+90J1Mc1bpXX/b67IMUhK0TfORIpaF8MgQ+OWm+YjNHTyuq/Sta8VNwaMaOc9IZVL3QfcSDetVCDltIQtKxQ7l1D6fH68o0Nquuxf/DfEvnOQtPoadR0UwyWXTQna1jWrMVAdfoX3FPgclyNNw8duJ/Al4jnM67hY/BdtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636118; c=relaxed/simple; bh=9Q/5fhQklB9IJmrBT5IrEVLkeSwQGbC8hw42rvNgFTE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IDZxGAamJ0MbF6Bq/e6Gi6tT3yq9g7QPEhev9he2lCdtvj+ZfUoRtvFjAxfbISPySM5Dmp9nz9SDCkBGpphhq/4k72r4RuKvncZctOojHic4Dt+07hhB4wUxzBNSXqWFN3J5lTuIJ+7n/hsDc2uGnoZfWUVUNi7Qgyzn4qZwh+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GjWjdJOQ; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GjWjdJOQ" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2fe8c35b6cbso929842a91.3; Wed, 26 Feb 2025 22:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636116; x=1741240916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tfcsKyxsqqNF1ObsRkAL+Fr53iDPz5SE+sP10CWPKmY=; b=GjWjdJOQGgauSlbvCKMHgfeVoYodh9GyfzUYB+qNogTapeCGtEqQiNPHlQ86gN2XSL xUhH5bpQwi4f69uaovbF6Y13Ieo3Nr1jIJoj7mhO40O+2xAXF7/KAKzQ7zxb2pfeoMLm 0dCAlghl35LtnJz2GvJ5ACIW2v3Dqsw0FX65RwZTIGCXZRehBMRfwPjTImEnzSphqMjf zpMtZPhm4/inQFooaWU0/yW+zqVddpF0+tVd5HynuCh30v9F6clMNEXKghPZdDIA2mpA 8yTvSXozU8t2x64DWZCf9wDcj3XTU5x7Oviq1THvlfNVPOkKn1DAdx6co7BNM5yGeQVJ IJDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636116; x=1741240916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tfcsKyxsqqNF1ObsRkAL+Fr53iDPz5SE+sP10CWPKmY=; b=ZQsTtBhfRToD3EHnsCBlXVmQx5ONdNng550J6gf42QCt/cgMIn7Ce52xngnJyjWQjT UamAdKLuh0VRidSlReDk2hMYDRCQW61FH1fV64T9NSo8eE5Lvfd+PyH78vJvH9zkoEUI ZwhE/fAgSrtq4P97N7BUrB5dViFdiHn9ar6UlRVb5F55OziY2LFxwu04idTqMarKSHRT dEi6Aa9SwIQVh6+bT9m4iV0tJ339fiVvPG6cFX5RpPa1ewjbOK5Rs5PcpONe/IKz6ibA w9WiduFei+ru101ewwc+uvw19Kl39ZDuXCYAY6qY3RRJedWAz4R84El6uayuPJOuQtN8 8Xig== X-Forwarded-Encrypted: i=1; AJvYcCVHKamOXkIWKe18Q/1ewuDjdLCjpsTdHM/tAxOot3ZDFmEz8XqJCT2F+0CIi5t3HXzWn8oXgkVj5+Vw@vger.kernel.org X-Gm-Message-State: AOJu0YyWx3rCNIBg8kpd9a6gG9boj5XDww45Xp69j7PjL8jWJHUr63EU d9cwM9jKc6JWxiXFhs9T3+8sicFmm1vYFW74fcnlMEjIGqYKgfan X-Gm-Gg: ASbGncuWQeNZ2JSMJ0+Hp7L3neA8YDBhLFzgQDpBOiH2gL4pTGG4Lz9WirRLFeeVMGN lXfipCKpt1zx6zrojB5BoQym8I9GaUIjg+KxC3h7JbW0iY3CudIEGNJ8xhIZnuQ7Xq7F9NIxFAi /kr1hWuklbUXBe33/h1tH5mZ2FSza81GxxayhM+6P8KjO23OGGPBJvN9vu1Bmk6OZaSVbOPkAIB xGjiyOf2hhfVq/L41iAy5WoLSE4xfRpMBokFIrFGtnQomD1Cng+gYuMyrF15jCpeq/TnGGFstAK 6zWVsN5jlYN08Boz/gQVOWummlAmPMoRBuW9 X-Google-Smtp-Source: AGHT+IE958nyxT/MQ1RXRPl3RO6BV1mQ+QuBOyNiN7aTAS3Jr7cbgeA5uuT5xa5jaBuU3GsTGvI1Fg== X-Received: by 2002:a17:90b:1808:b0:2fe:9e6c:add9 with SMTP id 98e67ed59e1d1-2fe9e6cb035mr4296027a91.18.1740636116626; Wed, 26 Feb 2025 22:01:56 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:56 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, Frank Li Subject: [PATCH v5 4/5] i3c: master: svc: Fix npcm845 invalid slvstart event Date: Thu, 27 Feb 2025 14:01:30 +0800 Message-Id: <20250227060131.2206860-5-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu I3C HW may generate an invalid SlvStart event when emitting a STOP. If it is a true SlvStart, the MSTATUS state is SLVREQ. Check the MSTATUS state to ignore the false event. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index a0c6d8053a25..952afc75f6e4 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -59,6 +59,7 @@ #define SVC_I3C_MSTATUS 0x088 #define SVC_I3C_MSTATUS_STATE(x) FIELD_GET(GENMASK(2, 0), (x)) #define SVC_I3C_MSTATUS_STATE_DAA(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 5) +#define SVC_I3C_MSTATUS_STATE_SLVREQ(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D= 1) #define SVC_I3C_MSTATUS_STATE_IDLE(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 0) #define SVC_I3C_MSTATUS_BETWEEN(x) FIELD_GET(BIT(4), (x)) #define SVC_I3C_MSTATUS_NACKED(x) FIELD_GET(BIT(5), (x)) @@ -617,6 +618,11 @@ static irqreturn_t svc_i3c_master_irq_handler(int irq,= void *dev_id) /* Clear the interrupt status */ writel(SVC_I3C_MINT_SLVSTART, master->regs + SVC_I3C_MSTATUS); =20 + /* Ignore the false event */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FALSE_SLVSTART) && + !SVC_I3C_MSTATUS_STATE_SLVREQ(active)) + return IRQ_HANDLED; + svc_i3c_master_disable_interrupts(master); =20 /* Handle the interrupt in a non atomic context */ --=20 2.34.1 From nobody Fri Dec 19 05:31:33 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E4422206BB; Thu, 27 Feb 2025 06:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636121; cv=none; b=d/sFyRNSUbKryEG4IfKZ60MnD0aDjxwHQ95nTaI4E3snhC20WloizyEAdyZTId2RXH/PhUGorL0MsO41CfsMZ1w5NaCvBja0P8moTFidcjqd77fOpK/lYkQ3JNXBnvrDod7e7miiO0Yir/9Bfs2sLnXyl+ELWB5NfArq4b1Yo3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740636121; c=relaxed/simple; bh=OWeq6d6NKg5biA4HMES8aq5niN8erXf9y3LUci07koM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ECZwzfgQi0VNrzOlU9nWEnoPaCvkt+Z8g1LWQQfBmsVOh2ZYrrJFc/f9iMiGHT8QyRmbT2/tfElGUtkOm3Fi9KgGKIYzwfm0lME1FeZElVa6hJfvyDbfeOhzhzTvxJUpQihe8EulsKR04RyJoqbsKcQdEctPmGM8Xxgm9buD/es= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AQJWwfNe; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AQJWwfNe" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-220c8f38febso8876635ad.2; Wed, 26 Feb 2025 22:02:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636120; x=1741240920; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3OREH+iLC47dZ2hUuoqhiGCsdCQC5cRnPwerNbjmWOc=; b=AQJWwfNeCZwhlSO5WLKV7ysbmXelBcG1Q6pgW+1nRd+LamGrVTBLmCaluypcAh3jhg wu2uYgUeAVNGfP+QkHcdM+dJH1rEJ1qLf4BBZO1Wv21/AgNbUnd4ll7cVKQUi0qkvphb SNVGKM3MTUwSIICWuMPfQEK4NcgMb/yjZ0GTjAKbKP8ZKVzxx1SJ5vaeGDq1u17Nz/uP lzrK5uGCX6lMlznP8RWcmnDo9UeMUN2QaUa5H6CQ+V7b061MOPqwRg0kUxnru9+z5Zoz wvauMvv0mvNbZJhzheP69CWHixVpIvQdxggbXHQbGLd+haOfHnabZP+zZGeHT3aa3a3F y9xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636120; x=1741240920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3OREH+iLC47dZ2hUuoqhiGCsdCQC5cRnPwerNbjmWOc=; b=INZGxv+2lUmE4GFEbQbNkbsyCU3ElpH95B9JZHLbDLTKc/zYgmCun+8s++Ogew+Wvq HzfnGFhGYLHceH1qC3RuWUeNikvdr6ioth789h3WMZwaNofhR4qKvMQtLC1tJfXhayrp iPxBqCpew3FHmLJaXBAdEtMSBIi2gjc6YQ/mb4VTsE4tQ16vZuBuytE07FQyxxevgwgi g49v9FtNWPkPeKzz5tyNr62O2Ipja/52hD4qppYr2aJFe25ubXWK5YOuB4wBhHqf3XFc cv5Lq3miaSq4EPW9+iAVbiigqs6S1MXSnmID3tIfoKbg2PkRGzW2cqTvWHB769UosQkw Xh5A== X-Forwarded-Encrypted: i=1; AJvYcCWzV7ghNqofyp1B7WwB1SNgS1hsZeX8JkixVxI3AASZzvG8uztZBlIE2io8zwyDYLJFPrJh/seDZFLx@vger.kernel.org X-Gm-Message-State: AOJu0YyrJi+7nlcvN4VCkHIdKbuIKRgaVQTFYb1BVTHOs/MhW83CP5mM EIwmAxAsUvzAiQx+IRwIPOUxD4iTe5i5J4auDWqqduk+gCXX8fhc X-Gm-Gg: ASbGncsDMkGnLfRnVws2Gu3iU//mUmasSVy+tP9rqM4uLZWbHLYIQH5bZtG3x44ydO4 H2/Lu1zLcTTS7kyEUI63UEAN41jnkTyXTHyzZG930KnQUQHqIDK+lEQAm2tyJ1aOGcS+yC6NA2n hlE1/ecb8Uhysr3H9zpnlVzwGFApzS6uTy3IwBqOLvN7HVl3rpfI2XaoRJqVhGrineXLeGrRsgh 2wfCFB5SZKRTJisORWHI7F6Rfd6GEA+Gxp8UHgZccI5pV2J+w1SP+HUUcQ9tQEOV+ROgyrqtqY6 g1k+z3Ucn24b6BIsEBSidjYXaq1YL9FEjZdB X-Google-Smtp-Source: AGHT+IEqIBEjElcYfutyZm2+ie7egiFz7kMRAMyX+Q/RVxplxMI9mjXMEKkY217XYnf9eGB2wXWsGg== X-Received: by 2002:a17:902:d502:b0:21a:8300:b9ce with SMTP id d9443c01a7336-221a002afb5mr415841785ad.49.1740636119772; Wed, 26 Feb 2025 22:01:59 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:59 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, Frank Li Subject: [PATCH v5 5/5] i3c: master: svc: Fix npcm845 DAA process corruption Date: Thu, 27 Feb 2025 14:01:31 +0800 Message-Id: <20250227060131.2206860-6-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu When MCONFIG.SKEW=3D0 and MCONFIG.ODHPP=3D0, the ENTDAA transaction gets corrupted and results in a no repeated-start condition at the end of address assignment. Workaround: Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA process is completed, return MCONFIG.SKEW to its previous value. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 952afc75f6e4..774f94ee761c 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1169,7 +1169,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_c= ontroller *m) } =20 spin_lock_irqsave(&master->xferqueue.lock, flags); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config | SVC_I3C_MCONFIG_SKEW(1), + master->regs + SVC_I3C_MCONFIG); + ret =3D svc_i3c_master_do_daa_locked(master, addrs, &dev_nb); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config, master->regs + SVC_I3C_MCONFIG); + spin_unlock_irqrestore(&master->xferqueue.lock, flags); =20 svc_i3c_master_clear_merrwarn(master); --=20 2.34.1