From nobody Fri Dec 19 21:11:38 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8355A21D3E7 for ; Wed, 26 Feb 2025 13:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740575011; cv=none; b=H4QJnBLBPLFmuiU3jvGAeNsykdh2QBkmzMgYXtRms4/weQ0ElI9m5Fw7UwBZzreIkK1OuL3sMLl29gZNfDot5pS9Vy7t2bDIJJZ/Rdun127SlPQ3yfXxuLNInhJ+ozXJi+hnsG0gjAobfUHaGdLEUYskH+uwnkRfkHpW2/cXhIM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740575011; c=relaxed/simple; bh=PoxKI0ploMO04bMecVMc9KBs5Z5x4tVBjLfD2git3RU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KUQk94zyCkhwIa4K5OtYfdI1Zg+g24m7aoaQb83nAIMlNVXj6rJUD90JAwcZfc56fKP8qCFUY7m7g4JSZG5eGIsNitu9sXYkyOoG/Y630+Sd/xOULB6i6CEnpPZr/03yWxZaxFQ6q2LM+37WShOagfF2NNIb5DTVpYHHNE100BQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kv0dbezb; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kv0dbezb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740575010; x=1772111010; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PoxKI0ploMO04bMecVMc9KBs5Z5x4tVBjLfD2git3RU=; b=kv0dbezbwbl3bMEkAm8xuI7sYx/4SCtxVHcBM92/ZyEaapIDBvZutlHN Bzk7oIVswi6UONNxmzxpdAsJQ3J54ZScwlkXvJ30aPn71dSV34Db4m7NR NcAt1fwmbcQiccz+rKz5VbgcXlCVdpDr2NPkdlCwHKxs6mt/YB/7IHs6f 9SYedcpOnX8K9F5P/7ZSSxsz6osKcbsRwkrgdD3iOzs7jtngj0AjjzYA+ NL9CDWFH2LaKhgMp3a/l2PUDLVGth01BZhR/IW67vySklFVDs5a8ly8Hm XmUUJnRYQiCHGtcL5aLa5pnPynGsUnWa403vZDofhThA/SxenNLYcqhdp Q==; X-CSE-ConnectionGUID: 3bg0ERbZSLmaNaNKcTalfw== X-CSE-MsgGUID: YVyUcfj1Tza+s1tuxWimog== X-IronPort-AV: E=McAfee;i="6700,10204,11357"; a="41341587" X-IronPort-AV: E=Sophos;i="6.13,317,1732608000"; d="scan'208";a="41341587" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 05:03:30 -0800 X-CSE-ConnectionGUID: naYMxRl1SZ2Fv7oe9OpBxg== X-CSE-MsgGUID: FliEkHF9QHeMqaBpXsQl2A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,317,1732608000"; d="scan'208";a="121690825" Received: from sannilnx-dsk.jer.intel.com ([10.12.231.107]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 05:03:24 -0800 From: Alexander Usyskin To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , Karthik Poosa Cc: Reuven Abliyev , Oren Weil , linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alexander Usyskin Subject: [PATCH v5 06/11] mtd: intel-dg: align 64bit read and write Date: Wed, 26 Feb 2025 14:51:38 +0200 Message-ID: <20250226125143.3791515-7-alexander.usyskin@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250226125143.3791515-1-alexander.usyskin@intel.com> References: <20250226125143.3791515-1-alexander.usyskin@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GSC NVM controller HW errors on quad access overlapping 1K border. Align 64bit read and write to avoid readq/writeq over 1K border. Acked-by: Miquel Raynal Signed-off-by: Alexander Usyskin --- drivers/mtd/devices/mtd-intel-dg.c | 35 ++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/drivers/mtd/devices/mtd-intel-dg.c b/drivers/mtd/devices/mtd-i= ntel-dg.c index 062e17b7d99a..785a52f2803d 100644 --- a/drivers/mtd/devices/mtd-intel-dg.c +++ b/drivers/mtd/devices/mtd-intel-dg.c @@ -238,6 +238,24 @@ static ssize_t idg_write(struct intel_dg_nvm *nvm, u8 = region, len_s -=3D to_shift; } =20 + if (!IS_ALIGNED(to, sizeof(u64)) && + ((to ^ (to + len_s)) & GENMASK(31, 10))) { + /* + * Workaround reads/writes across 1k-aligned addresses + * (start u32 before 1k, end u32 after) + * as this fails on hardware. + */ + u32 data; + + memcpy(&data, &buf[0], sizeof(u32)); + idg_nvm_write32(nvm, to, data); + if (idg_nvm_error(nvm)) + return -EIO; + buf +=3D sizeof(u32); + to +=3D sizeof(u32); + len_s -=3D sizeof(u32); + } + len8 =3D ALIGN_DOWN(len_s, sizeof(u64)); for (i =3D 0; i < len8; i +=3D sizeof(u64)) { u64 data; @@ -295,6 +313,23 @@ static ssize_t idg_read(struct intel_dg_nvm *nvm, u8 r= egion, from +=3D from_shift; } =20 + if (!IS_ALIGNED(from, sizeof(u64)) && + ((from ^ (from + len_s)) & GENMASK(31, 10))) { + /* + * Workaround reads/writes across 1k-aligned addresses + * (start u32 before 1k, end u32 after) + * as this fails on hardware. + */ + u32 data =3D idg_nvm_read32(nvm, from); + + if (idg_nvm_error(nvm)) + return -EIO; + memcpy(&buf[0], &data, sizeof(data)); + len_s -=3D sizeof(u32); + buf +=3D sizeof(u32); + from +=3D sizeof(u32); + } + len8 =3D ALIGN_DOWN(len_s, sizeof(u64)); for (i =3D 0; i < len8; i +=3D sizeof(u64)) { u64 data =3D idg_nvm_read64(nvm, from + i); --=20 2.43.0