From nobody Fri Dec 19 22:07:42 2025 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F04947F4A for ; Wed, 26 Feb 2025 00:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740530184; cv=none; b=uyMioSxvTt0SEforTUHkV/32gPFB8a1vbVyzwUHTK4kD9A9zT0gX2ho3QZARPoQbcKM32p8NJDzzSFZ7s+lGwI0FdKC/3tm+4Vit86Gkj0ai0PhWrIi7qZqt7zg9yhituQH1RohgLESaha6XVTCKRIcpg0K7yXGZ8GmpJz4w73g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740530184; c=relaxed/simple; bh=bN8gfJuIIhF73j3nDVVpaoOYFmyR/2OtbGeHfy6t+bs=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=UHwjdhBwX8uaxmQEIKYQMVOovCgIWhhuiMXmMUbDSTg4cvVk7tihpVndTet3zzbTozC3hZZDsLd0TbCLYbSFyf1RKpFIUWsC09G9X+vdLD/ZLvE/tyf8czuIjJhRebcW4NEYMTMWgmEtSL4J857x27Tx1b+WWo9FGyFhZ+hKhCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UwEPWxhi; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UwEPWxhi" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2fc2f22f959so636615a91.0 for ; Tue, 25 Feb 2025 16:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740530183; x=1741134983; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=nXsj9VmJS338dGGKNMmEL0zNWuSXmfxwvYQboUIxXE8=; b=UwEPWxhiiNnorZC9wJ/Of682IgfnOwCy7G9Xc4NiQ0ygyn4I7nfWJzOO7BYCz9KKv+ ogReU2zk+SXhOAbNYORDfMjpdaj1oPKwQsf+hNRb9L1UcFbOeL6/KjmmsrzjSUtBv2Vc BgjaA5sUYuDqAV+vlNInsQk0TvcvnJujn4aKvAPnKq3kQjXJHS9SXDFBfDw7RaswcGVk CDicoCCJt9ShYFFpArbL2B0iDgaQcebIjbEDKs4dSONGw9NmyN+9X41PnSr/hWQnAFoI ds0kC+9Me5JFJatAEDLfs+hYaprzs++kiOBLZUYfMizBmAUFCZT6Pf4k0JQzPGOxdvo6 aBRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740530183; x=1741134983; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nXsj9VmJS338dGGKNMmEL0zNWuSXmfxwvYQboUIxXE8=; b=ciUElZR+0KQwbmkrtEsvN6ezsHCq341ijw3gT+wJFR4tq4cmzkxDlp+5k6H6e4SCSC ZWYJwD7yc+m2AlOSq1ERt0uLJ9XeY1MqUJFfcJ+YX4vJzK1XXyE/o9raw53R/ArhFejE H/HqueYFAS5O8lY2juk7ugGwVkEl9pz01WUSy2AL+Z7vdWYii8c9LyN5fn93focAWLQK 5LQDxAdrPfbuRxux8C5CJ/9gMWD7G75sQubplWSKeI2vFIWcCN+y9d7q6OWLSS16Tvfa VlQdaITkxsm8e0HRnCg/uWW0TV3gqXwrleTtBEz4OFQkWjQZM7tOBm/GJ7oCzP8/kACU +Chw== X-Forwarded-Encrypted: i=1; AJvYcCUYZ+f4PDWoQxLbWn5nTySo25ewHiw6Aqfj0JV50eHAGZFurofuFwUpehFgBf8ZjfgWkTRULRoVh28bTRU=@vger.kernel.org X-Gm-Message-State: AOJu0YwQnPXQ+czK1Os3zmrgY6+FjAnXOeJHImVVor/t0BApMXtUTv4C choYsGWEUjAfKzgnNRRQjFGg3156Ci3J3Y0xbaVZlRStf5n9z93HcUfG2cwWARZBbgl1FONUpLb h59UITjcFyIfQmpvfHzuAuw== X-Google-Smtp-Source: AGHT+IFAJA9kXjbtodM50cg9NdVfJgqMXkKHhhOKxSVMlYERHkjtSUyApwsAYc+sWvgX0xUTBoLiM0dw3MhKeHxGbw== X-Received: from pjz15.prod.google.com ([2002:a17:90b:56cf:b0:2fb:fac8:f45b]) (user=hramamurthy job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1b50:b0:2e2:c2b0:d03e with SMTP id 98e67ed59e1d1-2fce7ae8f31mr29815385a91.5.1740530182660; Tue, 25 Feb 2025 16:36:22 -0800 (PST) Date: Wed, 26 Feb 2025 00:35:26 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.48.1.658.g4767266eb4-goog Message-ID: <20250226003526.1546854-1-hramamurthy@google.com> Subject: [PATCH net] gve: unlink old napi when stopping a queue using queue API From: Harshitha Ramamurthy To: netdev@vger.kernel.org Cc: jeroendb@google.com, hramamurthy@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, pkaligineedi@google.com, shailend@google.com, willemb@google.com, jacob.e.keller@intel.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a queue is stopped using the ndo queue API, before destroying its page pool, the associated NAPI instance needs to be unlinked to avoid warnings. Handle this by calling page_pool_disable_direct_recycling() when stopping a queue. Cc: stable@vger.kernel.org Fixes: ebdfae0d377b ("gve: adopt page pool for DQ RDA mode") Reviewed-by: Praveen Kaligineedi Signed-off-by: Harshitha Ramamurthy Reviewed-by: Jacob Keller --- drivers/net/ethernet/google/gve/gve_rx_dqo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/google/gve/gve_rx_dqo.c b/drivers/net/eth= ernet/google/gve/gve_rx_dqo.c index 8ac0047f1ada..f0674a443567 100644 --- a/drivers/net/ethernet/google/gve/gve_rx_dqo.c +++ b/drivers/net/ethernet/google/gve/gve_rx_dqo.c @@ -109,10 +109,12 @@ static void gve_rx_reset_ring_dqo(struct gve_priv *pr= iv, int idx) void gve_rx_stop_ring_dqo(struct gve_priv *priv, int idx) { int ntfy_idx =3D gve_rx_idx_to_ntfy(priv, idx); + struct gve_rx_ring *rx =3D &priv->rx[idx]; =20 if (!gve_rx_was_added_to_block(priv, idx)) return; =20 + page_pool_disable_direct_recycling(rx->dqo.page_pool); gve_remove_napi(priv, ntfy_idx); gve_rx_remove_from_block(priv, idx); gve_rx_reset_ring_dqo(priv, idx); --=20 2.48.1.658.g4767266eb4-goog