From nobody Mon Feb 9 15:59:12 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E80DF20C49C; Tue, 25 Feb 2025 20:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740514097; cv=none; b=EdzRt2VMxaV1czbW2IUqvaZXw5KzPy72R3RFBLaPSmW+vD5ou884/oBREPdEoaIycXdk+2heGd2fMQZFBR3ZfFG3TMSoccJ7khcpVDyVKg7sYOmhuytBINAQ5MAsb8aiqF2rTAVNVAoNmg7sX3nyp2S9bzalZc7AFdct/GlbrSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740514097; c=relaxed/simple; bh=1X9gti/AqBedO64ZojlHc4HxFQ9alWiuV/NkoEvikIg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rFA86qd1PZ3IXBF5d4DbhFoUzX+IeHck4MQhzOlLd4FGZ4rbgW//EXZnuNr4IQF9eTyYOObhXzDmOn6Ne83P4ahnFbqhVZ9O6rPFtA9z41mKdCwDJ0Kj7Gu43ntMKsI8mVwBsAYGHZn3WROf2z+CowqbjlndWhsF5uMTgyPPkKM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GXUctQDM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GXUctQDM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5EACC4CEDD; Tue, 25 Feb 2025 20:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740514096; bh=1X9gti/AqBedO64ZojlHc4HxFQ9alWiuV/NkoEvikIg=; h=From:To:Cc:Subject:Date:From; b=GXUctQDMq2dJR5ZYCXwcuvk755B0POltC5zhf8NUQfss9+z4wFY4nnYvZu9kLCwhR RCBDsDNEp0sTpOTO2bNjLX6yo67/kT4Q4BsdqrS0GpVIvtoMGnW+iaQXUUDtWjrFMX 2gPyuvBvDYzbeODgfvPmLgW7cg7pvs4IPuuk+6mBH9T9W6EeptdGaC7WHdpe9KTpqy fVUNHWqtk7DBI7n70E94o3F+jYmc3ndJUwtIs+J6QWVz1JlEJ7G6kTAqQG89BUHDbq g1h7swkC84a2d8i3yZuGPBAcSBg/CmfjWO6w75ARxUff94PmMQ/PLDU1LLjnLq0e2w aEhwxAqPF3U9w== From: Arnd Bergmann To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Nathan Chancellor Cc: Arnd Bergmann , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH] sched: open-code max_rt_runtime definition Date: Tue, 25 Feb 2025 21:07:39 +0100 Message-Id: <20250225200806.4012494-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Building with clang using "make W=3D1" normally produces warnings about unu= sed const variables, but clang does not warn about those in header files. In case of rt.c it also doesn't warn because this gets included by from build_policy.c. Enabling the same warning on gcc also warns about it in included files, so we end up with a warning when all users of max_rt_runtime are hidden because both CONFIG_RT_GROUP_SCHED and CONFIG_SYSCTL are disabled: ernel/sched/rt.c:9:18: error: 'max_rt_runtime' defined but not used [-Werro= r=3Dunused-const-variable] It's not possible to avoid the warning by moving max_rt_runtime into one of the #ifdef sections, but since it is itself defined as MAX_BW, simply open-coding that is an easy workaround. Signed-off-by: Arnd Bergmann --- kernel/sched/rt.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 7a9ed4d93397..5dd6280442f0 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -5,8 +5,6 @@ */ =20 int sched_rr_timeslice =3D RR_TIMESLICE; -/* More than 4 hours if BW_SHIFT equals 20. */ -static const u64 max_rt_runtime =3D MAX_BW; =20 /* * period over which we measure -rt task CPU usage in us. @@ -2779,7 +2777,7 @@ static int tg_set_rt_bandwidth(struct task_group *tg, /* * Bound quota to defend quota against overflow during bandwidth shift. */ - if (rt_runtime !=3D RUNTIME_INF && rt_runtime > max_rt_runtime) + if (rt_runtime !=3D RUNTIME_INF && rt_runtime > MAX_BW) return -EINVAL; =20 mutex_lock(&rt_constraints_mutex); @@ -2891,7 +2889,7 @@ static int sched_rt_global_validate(void) if ((sysctl_sched_rt_runtime !=3D RUNTIME_INF) && ((sysctl_sched_rt_runtime > sysctl_sched_rt_period) || ((u64)sysctl_sched_rt_runtime * - NSEC_PER_USEC > max_rt_runtime))) + NSEC_PER_USEC > MAX_BW))) return -EINVAL; =20 return 0; --=20 2.39.5