From nobody Mon Feb 9 17:14:44 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F03B320B80F for ; Tue, 25 Feb 2025 17:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740503574; cv=none; b=DhVcu7AhIVsUDakDdpDHJBn6avyYVgCIoQGXBrwgT8OCSo4nzkjYrAXfqnoqeLr/t033ChcBwOj48p6MfobIjNaYpzURqXkUQgrbZtGcj3zTiRr9HmAr2L7/BoaMOZyBpOzAEGP6AyZLgBXflP8bniSijZib2ZaV5c3oY8HIG/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740503574; c=relaxed/simple; bh=FnUacC9VqqRTi29gXJo7HKIQwygyqPBosmqqmN5z+pw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UjNJlC/lzHk31TFD/jy3Z0wLQBcv23Ka1cthq0FexUWG/HGuwwud0Iqn8Npbt8p1t7N7Eubkj3OS7Vgs47DN4eosqnYjHlcTKxlFE4FOhc8qIFqFIKMSl+S4EWKssZBFEq4vSA5VCcMZIOnIeBufhI40pEhDYFdokrbSP3oQUpU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g3mbytdo; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g3mbytdo" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-220f4dd756eso125291585ad.3 for ; Tue, 25 Feb 2025 09:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740503572; x=1741108372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a5lxY7B542/PLdEoJyDDrjtx4yD4vXFk48rEXnqEjwQ=; b=g3mbytdoVZEX7ZA7zKRirvzIYoazIPF7Ip+vVmtGRxCRnTiPnJKPfKMnV4qaQUJQPV igsbUbOq1xu7s4+tHbCV/rH+hc4M8oDeofNvzJEEeAJcHJwclG6kCXG9vNnK3sHU4hpu lXCktHOOimAkRtZOR6OlZgxu1Oh30uf2s1R+Z61XcMDy1Y18VN0bTjeZbceiuwpPcHJ6 v6jniiZ8HjYT+6/dIMcfK/bmYEwzjajxtvyTA2jCmfXJKcTCv3v9YCrWhaGwK5WvDIFr 8n1q1IngxQ7Q01OKGnpp6B5UNe0M9/rXLQ6NZKBA/idXKYgJwlQFXSmysAnjWx4C7FCN 8t/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740503572; x=1741108372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a5lxY7B542/PLdEoJyDDrjtx4yD4vXFk48rEXnqEjwQ=; b=OREuE3+9bbF0St9nJ4Cpguo4QHZZk18S50apLEYaA+nLidDB2jA+j7VPnF84CYCzpY YeHWwkTY5GhB4g0JmbXxTqbsia+opKnkfvH7o/p4biLohdstmo/zfVArLHsfVI07sPeB jk/mVzSrIbreE4422WGpicrY2syMLlzorh9NoCdd9yHNMzq5ant2p1RHTAQOn0n4+wxO 8EejgIBf70mOnTa2xzmQykf4eYrD/o2PGwOBoPHKf+0FoW9SCaqMxmx/5izv25Jpa7Hx IGKGiv6lGKeGTo9T2e1zTro4f5T1EH3fwL7IsTDBC8x1MFoBTAi3IvZlnMaMGxrd/Lhl b2Eg== X-Forwarded-Encrypted: i=1; AJvYcCVZvOGfkoT5Z/k5SgPtJjcxwh+vU4f4wTMYFTpLNaG1jnCAHNt4IGnO84rr8uFpWDSYZxa8C5nSkxVlEAM=@vger.kernel.org X-Gm-Message-State: AOJu0YyFB17u7zh38MqfAgvyKpP0RD6GfGjNHK8xw3l6fDBWJZCbZ1Cp PvvFeWw2j/uKGiGFZSlhnxsogiqE3NLfWQkuu3Mrqhh4OTUeyX8zTWI5KxLhYw== X-Gm-Gg: ASbGncsDh6CL+bZwmuFNJ3vg7A2mItT/NTeBsiVEHMYQdfqJ6FGiOPPQzxbxexfgavF RHLjqr1zFmdFtoBbhJkjqdrmv52jQb48ABAR6TWRE9wgHbT59HzmgfqPFKNTEp7SsE6VXACOnxA qmQxsnz0975s27DF/UpOHt/TtC/DXjGos/mGcjRGeDELHqmEQtVM6P8Mf11PLO1iSSh5pm7J+Ld uLafPZ+PAGWZwJjT4ICFC6yU35nj0iQfdae9vIWHInewB48dK05hgFNQzwxpTX968N44KPm30A7 tEp2uxeq8soulB33KeQNYnUPCSFyPH0LPY0dt3zbLPuB1DxFAJCaiA== X-Google-Smtp-Source: AGHT+IFw71b3OYVPNe+t05CidalajI1SiIlNZ2RN6zsNLW4GExT54+gYQjXEbzLSFC9QbDLlJoqFIQ== X-Received: by 2002:a17:903:2344:b0:215:b75f:a18d with SMTP id d9443c01a7336-22307b4554dmr67545865ad.11.1740503572170; Tue, 25 Feb 2025 09:12:52 -0800 (PST) Received: from localhost.localdomain ([120.60.68.212]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2230a095f40sm16844925ad.144.2025.02.25.09.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 09:12:51 -0800 (PST) From: Manivannan Sadhasivam To: jingoohan1@gmail.com, lpieralisi@kernel.org, kw@linux.com Cc: robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, shradha.t@samsung.com, cassel@kernel.org, Manivannan Sadhasivam Subject: [PATCH 1/2] PCI: dwc-debugfs: Perform deinit only when the debugfs is initialized Date: Tue, 25 Feb 2025 22:42:38 +0530 Message-Id: <20250225171239.19574-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250225171239.19574-1-manivannan.sadhasivam@linaro.org> References: <20250225171239.19574-1-manivannan.sadhasivam@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some endpoint controller drivers like pcie-qcom-ep, pcie-tegra194 call dw_pcie_ep_cleanup() to cleanup the resources at the start of the PERST# deassert (due to refclk dependency). By that time, debugfs won't be registered, leading to NULL pointer dereference: Unable to handle kernel NULL pointer dereference at virtual address 0000000= 000000000 Call trace: dwc_pcie_debugfs_deinit+0x18/0x38 (P) dw_pcie_ep_cleanup+0x2c/0x50 qcom_pcie_ep_perst_irq_thread+0x278/0x5e8 So perform deinit only when the debugfs is initialized. Fixes: 24c117c60658 ("PCI: dwc: Add debugfs based Silicon Debug support for= DWC") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Krzysztof Wilczy=C5=84ski --- drivers/pci/controller/dwc/pcie-designware-debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-debugfs.c b/drivers= /pci/controller/dwc/pcie-designware-debugfs.c index dca1e9999113..9ff4d45e80f1 100644 --- a/drivers/pci/controller/dwc/pcie-designware-debugfs.c +++ b/drivers/pci/controller/dwc/pcie-designware-debugfs.c @@ -535,6 +535,9 @@ static int dwc_pcie_rasdes_debugfs_init(struct dw_pcie = *pci, struct dentry *dir) =20 void dwc_pcie_debugfs_deinit(struct dw_pcie *pci) { + if (!pci->debugfs) + return; + dwc_pcie_rasdes_debugfs_deinit(pci); debugfs_remove_recursive(pci->debugfs->debug_dir); } --=20 2.25.1 From nobody Mon Feb 9 17:14:44 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EDAB20E6F1 for ; Tue, 25 Feb 2025 17:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740503577; cv=none; b=Z9joDr/Rz2TKTXIWpUpx3BK8fR2igQGL/eJVUrpFb42m/wXagGVVnmVVBpr+IixeTUUiMOwezcmcQOQgk05yTamDUdRZqI6ObhizuEh4ccZwDV1yEF4C6VSt/8Bv1nGbrkt/zywyEbIv+w/ouw4OG0z1/DH5POJFb4IpH/C1Juw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740503577; c=relaxed/simple; bh=+tGGIMv06lp+ks8XnH860+Gw5Lwd/dSbE8h71qHq7Wk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A6Ly9gcRtvS9lEEed8Nhu3irrSZwNS2/xwFxvio2AS4tKCxc5cl43gdN/AJ21ElQ0Xwu79fjOzsGXlny9bmNsXCJnf2k/raSFdGmEM8gSJ5wUPzwLblNNRs0M3b/YAgpYdbJcyNAc6IpcIVWTOpYA8BYCdixsxXmPgA3N8wHYAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W4y/yAJs; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W4y/yAJs" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-220c8cf98bbso39474995ad.1 for ; Tue, 25 Feb 2025 09:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740503575; x=1741108375; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k2A4Pw1OXG2cGpbo5o64UmI83DrJNfZOQBEMUYC4MwM=; b=W4y/yAJs8GoxR5cax841iWfWeGUr5x+eZgtcIdQXKDJ/RsyKbNnlRJAaIZjd9DT66O M0r9CU0QbDNJYVP8YqVIh2phMb0pkOXEPXQ7WyjgpX1VHEaKFFa7gkf4K3XcW2hl9AKd dafJr/X3wBWdfkl8XxGGIXGhBbjCvmT2UfLIDrIz/cNgFumyiTMIWcKBg2qDKBSjA+qJ OaNnaw5vDDAPcD26CndOHe/ksYdWXbJpGNdB+3FG1Q3gs5aIlVRmBPrgLxuKHJBBUwtc 7dtxGT+wQiumYMTzxjNQ9qNf3/0nf662ekf4WQdlO8WTYoqCWfVgP0vTei5sUP34r7WO OtMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740503575; x=1741108375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k2A4Pw1OXG2cGpbo5o64UmI83DrJNfZOQBEMUYC4MwM=; b=JSHWVJANmW5eoScOA92cUiLzoz+0PRHIOoBH6Zu+XSiV9+oHJMjVGVLUGw8mPvdIJP WOmLiXRPH7Qgqz789yvPAW7jah6bz7JGGwjF77vz157SIc0BxSbzOej/LBRAyj04r1Bd /I5/wjxftU3CRP7iAi4DUyp96/WRMW8uaAAP+HNHXRsNmn9dPEwaXuhGf3MZyC3/bkl6 2UI9OxdqzcQb0Zlyy6fOmEgiXWQiT230WRfY2QNLjhMUBVnRflKZRbxN9GSvCcj3091w AMXwWhI8uYHiooy5IeetYPcOAjIYiQunkdh/2tGGn3rhGsl/w+h1j+y6gYw2rI+b603A EMew== X-Forwarded-Encrypted: i=1; AJvYcCWU9L/jOJC6W1xh1M+8vJtWpa/73gRzqUlC7oHvIi6Nnmrc5hUMpxK3ECGXdGjZG6E4YqelLIwqGkgIQqg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7rABI05U4mJOYAqOXn1HjdF4JAIfiMbW/Ub0hjNeJin8byqoI 82WwGpD0K1G3qOcrCX0eCB9EqA2kCFu6hoQebWAfBrceuLolspf/mWlNl2iirWSjiiIIDCGlBHU = X-Gm-Gg: ASbGncuFsdq5S5NjmhDlRU4B7NZmMfmd/zCq6Be7/ZN4fcvOmvMXclnX1qWFchLAZrK lwLlLJj99TqN12rrcT2/FSmey03m+DPWW7HT96zVCo6m+Rd5adaqdO5T03BRICxsu4vY5BzI+gw yCur1NvuDzLpMJtyG/MqzYOKsfEupV8VUyC0EI1GE1j+ZDiTwqbc25gfc13cgH7uSr6sxX74Wda jd0S0DLAbwOK8qDFX1SkMDDGJdee8RHwBk4ElPPvvcm7Bt8NtfRkGkH5Gda1yByVhGhbZuWTIHT pARcQuoQfzuOyRiAhNvuS5kWIrbS2kTCmrqiQ7hx4ysBhHiU7qvKxw== X-Google-Smtp-Source: AGHT+IF0H7ee+2m65dVm/sTEhXmntHs5M4Jmtg3yLBFmQYpcVS+0owZYZL1XMbzJ3AMwJRYXJcklRQ== X-Received: by 2002:a17:902:e54e:b0:220:f1db:d96b with SMTP id d9443c01a7336-221a1148be7mr311401165ad.41.1740503575534; Tue, 25 Feb 2025 09:12:55 -0800 (PST) Received: from localhost.localdomain ([120.60.68.212]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2230a095f40sm16844925ad.144.2025.02.25.09.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 09:12:55 -0800 (PST) From: Manivannan Sadhasivam To: jingoohan1@gmail.com, lpieralisi@kernel.org, kw@linux.com Cc: robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, shradha.t@samsung.com, cassel@kernel.org, Manivannan Sadhasivam Subject: [PATCH 2/2] PCI: dwc-debugfs: Return -EOPNOTSUPP if an event counter is not supported Date: Tue, 25 Feb 2025 22:42:39 +0530 Message-Id: <20250225171239.19574-3-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250225171239.19574-1-manivannan.sadhasivam@linaro.org> References: <20250225171239.19574-1-manivannan.sadhasivam@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the platform doesn't support an event counter, enabling it using the 'counter_enable' debugfs attribute currently will succeed. But reading the debugfs attribute back will return 'Counter Disabled'. This could cause confusion to the users. So while enabling an event counter in counter_enable_write(), always read back the status to check if the counter is enabled or not. If not, return -EOPNOTSUPP to let the users know that the event counter is not supported. Fixes: 9f99c304c467 ("PCI: dwc: Add debugfs based Statistical Counter suppo= rt for DWC") Suggested-by: Niklas Cassel Signed-off-by: Manivannan Sadhasivam Reviewed-by: Krzysztof Wilczy=C5=84ski --- .../pci/controller/dwc/pcie-designware-debugfs.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-debugfs.c b/drivers= /pci/controller/dwc/pcie-designware-debugfs.c index 9ff4d45e80f1..1f1bd9888327 100644 --- a/drivers/pci/controller/dwc/pcie-designware-debugfs.c +++ b/drivers/pci/controller/dwc/pcie-designware-debugfs.c @@ -352,6 +352,21 @@ static ssize_t counter_enable_write(struct file *file,= const char __user *buf, val |=3D FIELD_PREP(EVENT_COUNTER_ENABLE, PER_EVENT_OFF); =20 dw_pcie_writel_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_CTR= L_REG, val); + + /* + * While enabling the counter, always read back the status to check if + * it is enabled or not. Return error if it is not enabled to let the + * users know that the counter is not supported on the platform. + */ + if (enable) { + val =3D dw_pcie_readl_dbi(pci, rinfo->ras_cap_offset + + RAS_DES_EVENT_COUNTER_CTRL_REG); + if (!FIELD_GET(EVENT_COUNTER_STATUS, val)) { + mutex_unlock(&rinfo->reg_event_lock); + return -EOPNOTSUPP; + } + } + mutex_unlock(&rinfo->reg_event_lock); =20 return count; --=20 2.25.1