From nobody Mon Feb 9 01:49:09 2026 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE8226E178 for ; Tue, 25 Feb 2025 15:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740497401; cv=none; b=F7ol9Q5Al9F3YhOaZy1wprVziWoeOr6TRJwB7h3NeAUy6yrE6crjPrmURm6JUPaVYUwDcUta0iOky9H/YdSwJdmmkszP3ZRUDQBS9FEk7U5dQv5tFTF5H8zRPdy58Hmr9w/4l8FPO7TC2tzqCAVsR/2TimoF4sL0HF9RGTMsEjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740497401; c=relaxed/simple; bh=SAtCeGGThvYtyN8fuDzXe+M8ncw+a//ocp2DTg2/S3E=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=RfniiRuaimtIu5wRCUh/xgml4J4b3oMEAxRUgzN1H3nwOR7R6EF72Cbr3lZWoBsjlZpPDlwF3uXikAtNkCAdFrxz4RRNZXvzIdWSN2biTKT0e7HuHNvcpzUO9Y7WS46OmxFv/YtjZxynGZo+20kMt32GbuD1RNH9oiGD5oMv75A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1tgJAO4W; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1tgJAO4W" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-438e4e9a53fso46034845e9.1 for ; Tue, 25 Feb 2025 07:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740497397; x=1741102197; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=nx6t1c8/cloSJvCisk/ifycZ3o4OR3QkzD+SEADwtx8=; b=1tgJAO4WGgL+TLxEpeiUqhQvb65N9gBbdwZF6x06YK67LJlTJGAoWsIKA0m1NbtpR7 cH8LUi5dOw5vleEU98rdD2UFT5t8RMoBPJnMTevkmHBHiKopTX3sfFWWNcrMJxynuOqC pN1WmObZCePJENhNfehodIYNQ4AAKrpAwdzeMJRntbFrRFfULJVBxV9H2vQCKgNQILZo 9xLkfO+sRpeom81O2/UCbEetgaqw0oMsadyHUcbLRQNfAIvfzo0nsQTtCqml0GvnNEnR nKEigGOT3XZzkNe4NmXR8zNB/2YzyenRaVGLgH8ZjgkgkauwRk678i7nHa+McmXVtGBT qTog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740497397; x=1741102197; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nx6t1c8/cloSJvCisk/ifycZ3o4OR3QkzD+SEADwtx8=; b=ljZrCz3kefpPaJYo/gkwKoaqWlylHQ0AJAHG+06y4iRXzzEbNhN1CB10z4Eo+qssgV x41WexokNZLvbyZS6mTOOY/cret24gESwgF6R54jw61VmK2OFhSDIUSr0+Fn5wRSfYya JDsf7PLEPRpe+zWkBsaGJsDGngBSSTVNu1tt3tdUWY58poOIG8bkpUbpfc/LvmMuf9Od /v3HgainF4ZLBsDwsJa+0dl0zOcTZyfvmTq+Qrmq5aZ2leCUWvcY6w4UBtgGcBfTTSxO CCigmGaIzr5TBFF9nb2xWHOhsPmND3wizrrMpOvYoBLeSOVCTWwcMRMy1ZKpyLg6D43c qgew== X-Forwarded-Encrypted: i=1; AJvYcCV/qJ/5YsnTRjArDWDhKCmm3JE/TRxTC0K73VICcOoOmC23BOpUalTaa7eVGWNxcooBby9DI75zci3wE7g=@vger.kernel.org X-Gm-Message-State: AOJu0Ywn+/8G9BopsfNe32muXxk2giZ3Xrxc0JvxXmF6BXWTW6YeqIYc Kby5UnOkiqsgO9q1N6hBDb/qCuQdgvmhXekiLAqyIebO2+d3mg7B7CtOt5gUWe6VPbN+6tgR92r KvrQiFHJj3g== X-Google-Smtp-Source: AGHT+IGn32bsk1prP4wPiO8UR6qaQxLW4dASvWo6m65ubj1QAEwH4BO/I8DvVEW43uBjNISApDxTFJ0VJ+OChw== X-Received: from wmsd4.prod.google.com ([2002:a05:600c:3ac4:b0:439:5fab:db0f]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1e18:b0:439:a1f2:50a3 with SMTP id 5b1f17b1804b1-439af0d503dmr150580675e9.4.1740497397567; Tue, 25 Feb 2025 07:29:57 -0800 (PST) Date: Tue, 25 Feb 2025 15:29:48 +0000 In-Reply-To: <20250225-clarify-steal-v3-0-f2550ead0139@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250225-clarify-steal-v3-0-f2550ead0139@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250225-clarify-steal-v3-1-f2550ead0139@google.com> Subject: [PATCH v3 1/2] mm/page_alloc: Clarify terminology in migratetype fallback code From: Brendan Jackman To: Andrew Morton Cc: Vlastimil Babka , Mel Gorman , Michal Hocko , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brendan Jackman , Yosry Ahmed Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This code is rather confusing because: 1. "Steal" is sometimes used to refer to the general concept of allocating from a from a block of a fallback migratetype (steal_suitable_fallback()) but sometimes it refers specifically to converting a whole block's migratetype (can_steal_fallback()). 2. can_steal_fallback() sounds as though it's answering the question "am I functionally permitted to allocate from that other type" but in fact it is encoding a heuristic preference. 3. The same piece of data has different names in different places: can_steal vs whole_block. This reinforces point 2 because it looks like the different names reflect a shift in intent from "am I allowed to steal" to "do I want to steal", but no such shift exists. Fix 1. by avoiding the term "steal" in ambiguous contexts. Start using the term "claim" to refer to the special case of stealing the entire block. Fix 2. by using "should" instead of "can", and also rename its parameters and add some commentary to make it more explicit what they mean. Fix 3. by adopting the new "claim" terminology universally for this set of variables. Signed-off-by: Brendan Jackman Reviewed-by: Vlastimil Babka --- mm/compaction.c | 4 ++-- mm/internal.h | 2 +- mm/page_alloc.c | 72 ++++++++++++++++++++++++++++-------------------------= ---- 3 files changed, 39 insertions(+), 39 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 0992106d4ea751f7f1f8ebf7c75cd433d676cbe0..550ce50218075509ccb5f9485fd= 84f5d1f3d23a7 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2333,7 +2333,7 @@ static enum compact_result __compact_finished(struct = compact_control *cc) ret =3D COMPACT_NO_SUITABLE_PAGE; for (order =3D cc->order; order < NR_PAGE_ORDERS; order++) { struct free_area *area =3D &cc->zone->free_area[order]; - bool can_steal; + bool claim_block; =20 /* Job done if page is free of the right migratetype */ if (!free_area_empty(area, migratetype)) @@ -2350,7 +2350,7 @@ static enum compact_result __compact_finished(struct = compact_control *cc) * other migratetype buddy lists. */ if (find_suitable_fallback(area, order, migratetype, - true, &can_steal) !=3D -1) + true, &claim_block) !=3D -1) /* * Movable pages are OK in any pageblock. If we are * stealing for a non-movable allocation, make sure diff --git a/mm/internal.h b/mm/internal.h index b07550db2bfd1d152fa90f91b3687b0fa1a9f653..aa30282a774ae26349944a75da8= 54ae6a3da2a98 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -863,7 +863,7 @@ static inline void init_cma_pageblock(struct page *page) =20 =20 int find_suitable_fallback(struct free_area *area, unsigned int order, - int migratetype, bool only_stealable, bool *can_steal); + int migratetype, bool claim_only, bool *claim_block); =20 static inline bool free_area_empty(struct free_area *area, int migratetype) { diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5d8e274c8b1d500d263a17ef36fe190f60b88196..5e694046ef92965b34d4831e96d= 92f02681a8b45 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1942,22 +1942,22 @@ static inline bool boost_watermark(struct zone *zon= e) =20 /* * When we are falling back to another migratetype during allocation, try = to - * steal extra free pages from the same pageblocks to satisfy further - * allocations, instead of polluting multiple pageblocks. + * claim entire blocks to satisfy further allocations, instead of polluting + * multiple pageblocks. * - * If we are stealing a relatively large buddy page, it is likely there wi= ll - * be more free pages in the pageblock, so try to steal them all. For - * reclaimable and unmovable allocations, we steal regardless of page size, - * as fragmentation caused by those allocations polluting movable pagebloc= ks - * is worse than movable allocations stealing from unmovable and reclaimab= le - * pageblocks. + * If we are stealing a relatively large buddy page, it is likely there wi= ll be + * more free pages in the pageblock, so try to claim the whole block. For + * reclaimable and unmovable allocations, we claim the whole block regardl= ess of + * page size, as fragmentation caused by those allocations polluting movab= le + * pageblocks is worse than movable allocations stealing from unmovable and + * reclaimable pageblocks. */ -static bool can_steal_fallback(unsigned int order, int start_mt) +static bool should_claim_block(unsigned int order, int start_mt) { /* * Leaving this order check is intended, although there is * relaxed order check in next check. The reason is that - * we can actually steal whole pageblock if this condition met, + * we can actually claim the whole pageblock if this condition met, * but, below check doesn't guarantee it and that is just heuristic * so could be changed anytime. */ @@ -1970,7 +1970,7 @@ static bool can_steal_fallback(unsigned int order, in= t start_mt) * reclaimable pages that are closest to the request size. After a * while, memory compaction may occur to form large contiguous pages, * and the next movable allocation may not need to steal. Unmovable and - * reclaimable allocations need to actually steal pages. + * reclaimable allocations need to actually claim the whole block. */ if (order >=3D pageblock_order / 2 || start_mt =3D=3D MIGRATE_RECLAIMABLE || @@ -1983,12 +1983,14 @@ static bool can_steal_fallback(unsigned int order, = int start_mt) =20 /* * Check whether there is a suitable fallback freepage with requested orde= r. - * If only_stealable is true, this function returns fallback_mt only if - * we can steal other freepages all together. This would help to reduce + * Sets *claim_block to instruct the caller whether it should convert a wh= ole + * pageblock to the returned migratetype. + * If only_claim is true, this function returns fallback_mt only if + * we would do this whole-block claiming. This would help to reduce * fragmentation due to mixed migratetype pages in one pageblock. */ int find_suitable_fallback(struct free_area *area, unsigned int order, - int migratetype, bool only_stealable, bool *can_steal) + int migratetype, bool only_claim, bool *claim_block) { int i; int fallback_mt; @@ -1996,19 +1998,16 @@ int find_suitable_fallback(struct free_area *area, = unsigned int order, if (area->nr_free =3D=3D 0) return -1; =20 - *can_steal =3D false; + *claim_block =3D false; for (i =3D 0; i < MIGRATE_PCPTYPES - 1 ; i++) { fallback_mt =3D fallbacks[migratetype][i]; if (free_area_empty(area, fallback_mt)) continue; =20 - if (can_steal_fallback(order, migratetype)) - *can_steal =3D true; + if (should_claim_block(order, migratetype)) + *claim_block =3D true; =20 - if (!only_stealable) - return fallback_mt; - - if (*can_steal) + if (*claim_block || !only_claim) return fallback_mt; } =20 @@ -2016,14 +2015,14 @@ int find_suitable_fallback(struct free_area *area, = unsigned int order, } =20 /* - * This function implements actual steal behaviour. If order is large enou= gh, we - * can claim the whole pageblock for the requested migratetype. If not, we= check - * the pageblock for constituent pages; if at least half of the pages are = free - * or compatible, we can still claim the whole block, so pages freed in the - * future will be put on the correct free list. + * This function implements actual block claiming behaviour. If order is l= arge + * enough, we can claim the whole pageblock for the requested migratetype.= If + * not, we check the pageblock for constituent pages; if at least half of = the + * pages are free or compatible, we can still claim the whole block, so pa= ges + * freed in the future will be put on the correct free list. */ static struct page * -try_to_steal_block(struct zone *zone, struct page *page, +try_to_claim_block(struct zone *zone, struct page *page, int current_order, int order, int start_type, int block_type, unsigned int alloc_flags) { @@ -2091,11 +2090,12 @@ try_to_steal_block(struct zone *zone, struct page *= page, /* * Try finding a free buddy page on the fallback list. * - * This will attempt to steal a whole pageblock for the requested type + * This will attempt to claim a whole pageblock for the requested type * to ensure grouping of such requests in the future. * - * If a whole block cannot be stolen, regress to __rmqueue_smallest() - * logic to at least break up as little contiguity as possible. + * If a whole block cannot be claimed, steal an individual page, regressin= g to + * __rmqueue_smallest() logic to at least break up as little contiguity as + * possible. * * The use of signed ints for order and current_order is a deliberate * deviation from the rest of this file, to make the for loop @@ -2112,7 +2112,7 @@ __rmqueue_fallback(struct zone *zone, int order, int = start_migratetype, int min_order =3D order; struct page *page; int fallback_mt; - bool can_steal; + bool claim_block; =20 /* * Do not steal pages from freelists belonging to other pageblocks @@ -2131,15 +2131,15 @@ __rmqueue_fallback(struct zone *zone, int order, in= t start_migratetype, --current_order) { area =3D &(zone->free_area[current_order]); fallback_mt =3D find_suitable_fallback(area, current_order, - start_migratetype, false, &can_steal); + start_migratetype, false, &claim_block); if (fallback_mt =3D=3D -1) continue; =20 - if (!can_steal) + if (!claim_block) break; =20 page =3D get_page_from_free_area(area, fallback_mt); - page =3D try_to_steal_block(zone, page, current_order, order, + page =3D try_to_claim_block(zone, page, current_order, order, start_migratetype, fallback_mt, alloc_flags); if (page) @@ -2149,11 +2149,11 @@ __rmqueue_fallback(struct zone *zone, int order, in= t start_migratetype, if (alloc_flags & ALLOC_NOFRAGMENT) return NULL; =20 - /* No luck stealing blocks. Find the smallest fallback page */ + /* No luck claiming pageblock. Find the smallest fallback page */ for (current_order =3D order; current_order < NR_PAGE_ORDERS; current_ord= er++) { area =3D &(zone->free_area[current_order]); fallback_mt =3D find_suitable_fallback(area, current_order, - start_migratetype, false, &can_steal); + start_migratetype, false, &claim_block); if (fallback_mt =3D=3D -1) continue; =20 --=20 2.48.1.658.g4767266eb4-goog From nobody Mon Feb 9 01:49:09 2026 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BFE426BDBF for ; Tue, 25 Feb 2025 15:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740497402; cv=none; b=hEtur+B/cCLRHrVnJy7GfOkdD1/Vdzt2e5rO3Bco2NLrwOOlvTyvdbKeEvbcqQiil5rJTce0w2hKuvR43li+CkPrcf+PaJHAvLltN1noVYGrCZR/mZZzSxI63VcONm+kvFYb4A/YRWI58nGIyB7hkdQ/6HULsMQ4UhjpimcZAhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740497402; c=relaxed/simple; bh=2t7x2tjKNw2qIHCtZTtrUlEyUmTO9R0TRnhffv1XEwM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=jfgVD9TdczDu7HbA+eKPPidAXYzrp/UZHjbcn7PaIyfbG9AZgy5JekLJm8orrWJUG0yFy9Odn/ACbP0OzJJpkW2eNbR/EINW71wsNzH7VdJD7asI+Z17B6IX5eV2gGmCEgatH+oCWytnasf5f4G12bSJFp1tLINIylTngdSAKFo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yZFm787S; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yZFm787S" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-438e4e9a53fso46035075e9.1 for ; Tue, 25 Feb 2025 07:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740497399; x=1741102199; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=NLwoRANke7kr877qFcAfj/lJYQPtzdEo7Afw90Odwbs=; b=yZFm787SImXmOE4/jgnBaC/RMffXZRgeq1wm3Eq1kXBio24R0gWa2UK24jjIGHV7nK 3UsjDy3NUJI+vMY5Zoq5wNMS2SZ6SIUQuIkJFev+kKzRNaJec03j9mqaC6QSSNh/cGld jGoqDK/tMi3MkdlWIVoQDAxEE4Af5noK8fyBsUTcF2IlxlDtFsY/tTmcKIofz2RJ3pti X5y78NOCAMb/PnSObmv40aWxKS6/MC8FGGEga7J0mel5n2cAGxHTUhmofrFZ32KykzED SaWl/LVGA51ffemcusou2P2yxFWdH2jYrvImY6l6j/F8QVnZRiUXDRg+wGKd9t6bPnDB Bx8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740497399; x=1741102199; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NLwoRANke7kr877qFcAfj/lJYQPtzdEo7Afw90Odwbs=; b=Km0QXNmNTUde/egQcY81+DUr3/8nAs7uPyVp+yn2+uRYXWef/pPDzrpQf7oSRez85S P8ztbPWMykGsg917Cl9C9bTvcBfNNw1hmsNnfN90DIU0bzXD1fL0Ud2YC9/yD2DoS4tm LEaAGqn/UkypnZJ8TkiGjWYV56AozIup4J9zUL56vKV9oSnrd/yCNV0k5/Lh4ANxlkGF XY2nQBXQc2rWnrLKPAR+r0+UpXRd4pzPQRfgAJz4ZrhKboLSs29J8KPDcxRtu5SWGTen w//8MXp8Bt3tBwdnRJ+wq1oFUY5ao38WR/dnrhyW7xwb8jy/XkEMEl8zZca8ybaevrMM rrVA== X-Forwarded-Encrypted: i=1; AJvYcCVnQt3usjwSpD/b3/CGtZi11uJSLaYEIMSq0UwC1aiG+J1xt9GoJU+XmbFviTzqerO1knKFPfES72QI+yA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8o0t0NxerlcXtb4XlYUjV6IiyvrhcZdJYARVYWpzRV/MCXSVn DTgFqT9NE5Shi/4i/VAmSVAK8p3yJMz18TcFoAkYzYeeshZp2HeOW1zYPIr6OxP0IeycApIS/QW yo268vfsMeA== X-Google-Smtp-Source: AGHT+IGO83dLwzMAW2+OSLdDNKSAMPRJx7wbGvVzqnB7FL9rEUp8ltEN+IEPBCHAKKIyLKaCJmNhINOp203v6A== X-Received: from wmbed10.prod.google.com ([2002:a05:600c:614a:b0:439:985c:9199]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1910:b0:439:98f6:8bc8 with SMTP id 5b1f17b1804b1-439aebcf61dmr138093215e9.26.1740497399462; Tue, 25 Feb 2025 07:29:59 -0800 (PST) Date: Tue, 25 Feb 2025 15:29:49 +0000 In-Reply-To: <20250225-clarify-steal-v3-0-f2550ead0139@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250225-clarify-steal-v3-0-f2550ead0139@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250225-clarify-steal-v3-2-f2550ead0139@google.com> Subject: [PATCH v3 2/2] mm/page_alloc: Clarify should_claim_block() commentary From: Brendan Jackman To: Andrew Morton Cc: Vlastimil Babka , Mel Gorman , Michal Hocko , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brendan Jackman , Yosry Ahmed Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable There's lots of text here but it's a little hard to follow, this is an attempt to break it up and align its structure more closely with the code. Reword the top-level function comment to just explain what question the function answers from the point of view of the caller. Break up the internal logic into different sections that can have their own commentary describing why that part of the rationale is present. Note the page_groupy_by_mobility_disabled logic is not explained in the commentary, that is outside the scope of this patch... Signed-off-by: Brendan Jackman --- mm/page_alloc.c | 39 +++++++++++++++++++++++---------------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5e694046ef92965b34d4831e96d92f02681a8b45..475ec1284033acec69da4a39dd4= e7d7fbaee6d0f 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1941,16 +1941,9 @@ static inline bool boost_watermark(struct zone *zone) } =20 /* - * When we are falling back to another migratetype during allocation, try = to - * claim entire blocks to satisfy further allocations, instead of polluting - * multiple pageblocks. - * - * If we are stealing a relatively large buddy page, it is likely there wi= ll be - * more free pages in the pageblock, so try to claim the whole block. For - * reclaimable and unmovable allocations, we claim the whole block regardl= ess of - * page size, as fragmentation caused by those allocations polluting movab= le - * pageblocks is worse than movable allocations stealing from unmovable and - * reclaimable pageblocks. + * When we are falling back to another migratetype during allocation, shou= ld we + * try to claim an entire block to satisfy further allocations, instead of + * polluting multiple pageblocks? */ static bool should_claim_block(unsigned int order, int start_mt) { @@ -1964,6 +1957,26 @@ static bool should_claim_block(unsigned int order, i= nt start_mt) if (order >=3D pageblock_order) return true; =20 + /* + * Above a certain threshold, always try to claim, as it's likely there + * will be more free pages in the pageblock. + */ + if (order >=3D pageblock_order / 2) + return true; + + /* + * Unmovable/reclaimable allocations would cause permanent + * fragmentations if they fell back to allocating from a movable block + * (polluting it), so we try to claim the whole block regardless of the + * allocation size. Later movable allocations can always steal from this + * block, which is less problematic. + */ + if (start_mt =3D=3D MIGRATE_RECLAIMABLE || start_mt =3D=3D MIGRATE_UNMOVA= BLE) + return true; + + if (page_group_by_mobility_disabled) + return true; + /* * Movable pages won't cause permanent fragmentation, so when you alloc * small pages, you just need to temporarily steal unmovable or @@ -1972,12 +1985,6 @@ static bool should_claim_block(unsigned int order, i= nt start_mt) * and the next movable allocation may not need to steal. Unmovable and * reclaimable allocations need to actually claim the whole block. */ - if (order >=3D pageblock_order / 2 || - start_mt =3D=3D MIGRATE_RECLAIMABLE || - start_mt =3D=3D MIGRATE_UNMOVABLE || - page_group_by_mobility_disabled) - return true; - return false; } =20 --=20 2.48.1.658.g4767266eb4-goog