From nobody Sun Feb 8 14:56:57 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEC231DDC28; Mon, 24 Feb 2025 08:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386389; cv=none; b=eIPx5G5ZLA6jNG1XnVfkUw7MUWREQAn0BUs8QDM5K6/qgpaUuQTNKg8sZdjOt7JoX2r1kaPlFUNq26WxDNYgEj6HS4U6ZXnPy83ykOOAhset7io+kLq0SuPFiC6Ku/cmMirDFgPu070IUUZY/6e+Vm5pjXVmf6p+dKE7o6Tt+r4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386389; c=relaxed/simple; bh=OPib70z7RStdLqTILP/CTDIzshCEGAvZQiaDyNFFxIk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=shEZsM78ilKr9uAqcID3wzDtDpjuS++paOgX+9AyD/N//zpwiKXBZ+cfXhuKJ/nGbDKTRCTpkmDKU9k3pvoyUU06IdNTKsvKqA9FfAfad9+mWBeN2ii7Pe6DjOStNMllpEGDjY7t2BzPm0t8LpXUuhoXWA55ltT8Lu3MvxmbSkg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K3ks3Uaq; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K3ks3Uaq" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-21c2f1b610dso117657025ad.0; Mon, 24 Feb 2025 00:39:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740386387; x=1740991187; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=95SHW6HzB6iNhL/wzrH3WG7qpOIgT6dZkumEvj+k6IY=; b=K3ks3Uaq+YSU930lYDlice6Rw1iPLBsMk8pd7+HbiA3SPPcNQrJikIvJ7uYR14G0E7 0ZByAWdVsIf1UMMvurkqFZwnCqithN1+s6PQH/X+L7bD5VPTVYqMsstP5VXv4kw182rR RgFmQV67eU616iOJSDxdynzWPEKvR/321UYy93MhvinE0qwM+kQPglKBVX0JBvtuvK8n N1spDT1IjuYor83a1c0jve+U1pPS9LJNAk5ZLBRyOt4qDh7Uc1TwK34lUHg4slCVReEn h5sTLmC6rMTUJrHr7KEI/bzLV7cbMfIqL4ZrVPVZ9RUROnyhnLN0DUXC7j6LWbOPSctA zzEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740386387; x=1740991187; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=95SHW6HzB6iNhL/wzrH3WG7qpOIgT6dZkumEvj+k6IY=; b=XPgtypLFQyNnX5HIsfvj8FibFArxRhCVClLK7wB+C0W8azY4y/cMnjChYihQaE8Jqr WBA1XfnqNsVqBnaRPTGd+4i9xJ64M3dk791BEM0qa0ghxlWZwz/tK8wP3enbZcYvoaVe GHXeQuPJB4tWHaRoYBEOu/OpL2oJkZLs7nLSFfSz8/6uzvWfmM+qZCUJUESeD0n81rh0 5VzlFrFkrxcApyiF3/Hh9q5t5ndBZDx7Xzp23KYzKw7eYS36enoGkpxqDeaKXVbfm8jF 3ZTuewIovmMFjX6YiGHyP5KALaU7Lv1HkB/MN6erSSKLtLcod0WUpKu99YUNXJVy+tHw cDRQ== X-Forwarded-Encrypted: i=1; AJvYcCUaBIpHsHLp5UHWhJ5lF7QuIVLNz8P8cWKYNAe1O+fLWc9phaYPROzw22GQVloH/funtbiPmth2SI9v@vger.kernel.org X-Gm-Message-State: AOJu0YzrZ+z2t1pdHsMWiKAIqtgjp/nKywqddUUCMnmq4nJknH1QeRgj 6UVk2kjpCEzn7XoE/2qNcEZjQpYhqF4+Ue6l8YsduUZz8iwnKXyu X-Gm-Gg: ASbGncvUZrAwKaow6mHgzT/Ht82EfF2SMIiOMXZdoMFkYsqSK/rJhfn554k8tgcDDQQ PuFLgB5jThVBIiANZg9Z0aG0+/2fgXwQykju+eUJsW+G7kNuUszXmkB6NyYhkVWewfMlVhW5eUr ghkmXMzLksKT4ljf2JgCPSNWy07PBfTe01hJdCzUNxpHJA0vgvA0FEQiRAlhI71IV56SIRYAZJO t/EV8BK1yN9buhCVpKfvkPR9ZXvyN60tqjTfE3gtGgMf9ArGK7lEdsIxq9kxXGbZv74Sz7+LRes WNNbwG8TQa+mRTKMTWyqw8bIeljLYRbbKRNv X-Google-Smtp-Source: AGHT+IFre9XOybV0YxAiqbX3XhSPOqNf9uDTbDbMVVNdbMkg+GELuP1pFb1lBJN/C9iaOtzknuA7gA== X-Received: by 2002:a05:6a00:2ea9:b0:731:771:38f2 with SMTP id d2e1a72fcca58-73426cab14fmr26237456b3a.8.1740386386696; Mon, 24 Feb 2025 00:39:46 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7327590ff12sm14634793b3a.115.2025.02.24.00.39.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 00:39:46 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, Krzysztof Kozlowski Subject: [PATCH v4 1/5] dt-bindings: i3c: silvaco: Add npcm845 compatible string Date: Mon, 24 Feb 2025 16:39:04 +0800 Message-Id: <20250224083908.1880383-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250224083908.1880383-1-yschu@nuvoton.com> References: <20250224083908.1880383-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Need to add a new compatible string to distinguish between different hardware versions. Acked-by: Krzysztof Kozlowski Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml = b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml index c56ff77677f1..4fbdcdac0aee 100644 --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml @@ -14,7 +14,9 @@ allOf: =20 properties: compatible: - const: silvaco,i3c-master-v1 + enum: + - nuvoton,npcm845-i3c + - silvaco,i3c-master-v1 =20 reg: maxItems: 1 --=20 2.34.1 From nobody Sun Feb 8 14:56:57 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63F991FBCB9; Mon, 24 Feb 2025 08:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386391; cv=none; b=HyNVMBEPVfGYhWptQHKheXpBghHDH6PdmoNpeP7aIzEgziFDHjN/5nLVmFz3ZGzGI/W7lfZXhfcoyETMEL4NPg/TynFOGaLlghcFmTov8TKK2EDTzmWnqkCgwnVrzy09DqIzulDQpb3tvbuqFWQLxzJyrjSGIP2JqDFxjdV820c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386391; c=relaxed/simple; bh=2X7tfsUl5HpGxgWVGWz6C35KUS72yu1Udq+8hJpnhsw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mwla6RnAEroaR+3ipbuE8CJfMUwyS4fh0KzuucXedN/Odv+JU1sBgUaKC/wTo5sNf6y2anhiVX0/kOHBDpTLbzqZKntUDrcV8/h0mrignxhn56i3Fe01L0zU2Offf90lNxuBi7Y/CkgqZrR2SOaQurYGHc43hMwXlFrm8r1+Lec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BCSJuQ/o; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BCSJuQ/o" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-220c8cf98bbso91743805ad.1; Mon, 24 Feb 2025 00:39:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740386390; x=1740991190; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q2THBoMljTsJt94BbNpCp/YTgHXkT5f9Tt/dpOHOy6U=; b=BCSJuQ/oevUz4XpUI2xlPrOLiGD5n5/DRKDYfDaGuDTfUJlhJk4De0MSWXKqQNVhli wKQT83N14wU4Tooi41wnPJOc8ULhFI2w83pl7hiyKnxF1En9096B1OQHJSk1uO5dqfV0 mrkVptT2pX49BGStNTBZjbKMzP/K/0euaiyJuRX698Rt9OizcVzBo9RLktjs77/YOyIY BwhdcnXq4i83bqMur1J+RgqUr+DpP9fS7AvKRtsHVT2iNGjwGtJMQetQu5n0kvbshPVP Uaty9miTGbuV0tQ8ZMSOmZe/wXPddiDhU3HI4g53uAlwM+ihY6xmoc+aP2TrDz/jIl2d HgjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740386390; x=1740991190; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q2THBoMljTsJt94BbNpCp/YTgHXkT5f9Tt/dpOHOy6U=; b=mkvZJC/F7LMU1R1NndTPdHLeu6u1PicXBC6QG3VLPUBVfA3/kpAg6ZZdtBhqvYP5Jx JKazxjbKcCfQ6yeLHKltEbez8BHjPxE7rVUlL8Ci1EOlAG73mg2zdg4/mUVVYP0yZG/e fVKhESxzUl648H5xLdtjNG0/yDwZe0z0C6GOXV43dTc8kaTT9nq+c7etR7AWmZKx1wZF uSelKWqZFy3znQRG4e/KZDzYFX0ArtcZ5zfNbq/MREsOOtit6OtkLbeibX9yBfRFCBYx +02CJgzR6DH2P4fZSFomYW0AdaQR66gZlY2j6kZ5cLZ3RDpgIuAn+ezo9CSCYagJ75e5 ul8Q== X-Forwarded-Encrypted: i=1; AJvYcCXFlGihMFW4tn+EFW9OF5aqWt6uAJx7d3+NcQPYNZRh/sPujhNRonSSVNtmadb7StUOlmzUFvIjBoSg@vger.kernel.org X-Gm-Message-State: AOJu0YyiDJRYZFSpRiIOVUEdeDoMkhjwnPANm9ppbrUwYJbIa9/6n0E3 xqztcBlgPrb2/0IRpQckEsYR0Rg+KNidMF0X5d1krwpybH1FhUzVfHG0SA== X-Gm-Gg: ASbGncsOuiQHbIT+unimDbLodfhDyaNi+gMca+muHsmfI2SqOYwfTme5FdpZpvG/NIU nsube/3DcQYSLy4kIn9Tpr2YC9Jm73VIGUFo/B6c1TD2CsDuPHvEsYEkluj6OlxF1arP8h0q6MG NuAkkcsuVJJM2m0JKXyxzh9vpEPD9SkUusDYxF+u+AnJOfvFg75h4UDyM+u/Hg/MDrjIxpFbKN7 IID2H3IWqdDxMfMJm9uyxxpbQXM4ejcyFvCYpYu7ohAMfD4aDpTkeq5W1QEvnDyDcAuEFYS66sn uVrfj6t9sJRrTcLKLWP3sPhWlPjIcOd7BNqe X-Google-Smtp-Source: AGHT+IHPyq8u2np9gCVs9VjWgMl09L8z2ydAhriEM3Mo//Ztd8gpkj+ZbDCs/Wj2n6eQzW+dpn8+6A== X-Received: by 2002:a05:6a00:3d0a:b0:730:888a:251d with SMTP id d2e1a72fcca58-73426d9ee22mr21997073b3a.20.1740386389638; Mon, 24 Feb 2025 00:39:49 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7327590ff12sm14634793b3a.115.2025.02.24.00.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 00:39:49 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v4 2/5] i3c: master: svc: Add support for Nuvoton npcm845 i3c Date: Mon, 24 Feb 2025 16:39:05 +0800 Message-Id: <20250224083908.1880383-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250224083908.1880383-1-yschu@nuvoton.com> References: <20250224083908.1880383-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Add quirks to address the npcm845 specific issues. Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 56 +++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index d6057d8c7dec..8834f87a4767 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -32,6 +32,7 @@ #define SVC_I3C_MCONFIG_ODBAUD(x) FIELD_PREP(GENMASK(23, 16), (x)) #define SVC_I3C_MCONFIG_ODHPP(x) FIELD_PREP(BIT(24), (x)) #define SVC_I3C_MCONFIG_SKEW(x) FIELD_PREP(GENMASK(27, 25), (x)) +#define SVC_I3C_MCONFIG_SKEW_MASK GENMASK(27, 25) #define SVC_I3C_MCONFIG_I2CBAUD(x) FIELD_PREP(GENMASK(31, 28), (x)) =20 #define SVC_I3C_MCTRL 0x084 @@ -133,6 +134,32 @@ #define SVC_I3C_EVENT_IBI GENMASK(7, 0) #define SVC_I3C_EVENT_HOTJOIN BIT(31) =20 +/* + * SVC_I3C_QUIRK_FIFO_EMPTY: + * I3C HW stalls the write transfer if the transmit FIFO becomes empty, + * when new data is written to FIFO, I3C HW resumes the transfer but + * the first transmitted data bit may have the wrong value. + * Workaround: + * Fill the FIFO in advance to prevent FIFO from becoming empty. + */ +#define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) +/* + * SVC_I3C_QUIRK_FLASE_SLVSTART: + * I3C HW may generate an invalid SlvStart event when emitting a STOP. + * If it is a true SlvStart, the MSTATUS state is SLVREQ. + */ +#define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) +/* + * SVC_I3C_QUIRK_DAA_CORRUPT: + * When MCONFIG.SKEW=3D0 and MCONFIG.ODHPP=3D0, the ENTDAA transaction gets + * corrupted and results in a no repeated-start condition at the end of + * address assignment. + * Workaround: + * Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA + * process is completed, return MCONFIG.SKEW to its previous value. + */ +#define SVC_I3C_QUIRK_DAA_CORRUPT BIT(2) + struct svc_i3c_cmd { u8 addr; bool rnw; @@ -158,6 +185,10 @@ struct svc_i3c_regs_save { u32 mdynaddr; }; =20 +struct svc_i3c_drvdata { + u32 quirks; +}; + /** * struct svc_i3c_master - Silvaco I3C Master structure * @base: I3C master controller @@ -183,6 +214,7 @@ struct svc_i3c_regs_save { * @ibi.tbq_slot: To be queued IBI slot * @ibi.lock: IBI lock * @lock: Transfer lock, protect between IBI work thread and callbacks fro= m master + * @drvdata: Driver data * @enabled_events: Bit masks for enable events (IBI, HotJoin). * @mctrl_config: Configuration value in SVC_I3C_MCTRL for setting speed b= ack. */ @@ -214,6 +246,7 @@ struct svc_i3c_master { spinlock_t lock; } ibi; struct mutex lock; + const struct svc_i3c_drvdata *drvdata; u32 enabled_events; u32 mctrl_config; }; @@ -230,6 +263,27 @@ struct svc_i3c_i2c_dev_data { struct i3c_generic_ibi_pool *ibi_pool; }; =20 +const struct svc_i3c_drvdata npcm845_drvdata =3D { + .quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY | SVC_I3C_QUIRK_FALSE_SLVSTART + | SVC_I3C_QUIRK_DAA_CORRUPT, +}; + +static bool svc_has_quirk(struct svc_i3c_master *master, u32 quirk) +{ + if (!master->drvdata) + return false; + + if ((master->drvdata->quirks & quirk) =3D=3D SVC_I3C_QUIRK_DAA_CORRUPT) { + if (master->mctrl_config & + (SVC_I3C_MCONFIG_SKEW_MASK | SVC_I3C_MCONFIG_ODHPP(1))) + return false; + else + return true; + } + + return (master->drvdata->quirks & quirk); +} + static inline bool is_events_enabled(struct svc_i3c_master *master, u32 ma= sk) { return !!(master->enabled_events & mask); @@ -1868,6 +1922,7 @@ static int svc_i3c_master_probe(struct platform_devic= e *pdev) } =20 platform_set_drvdata(pdev, master); + master->drvdata =3D of_device_get_match_data(dev); =20 pm_runtime_set_autosuspend_delay(&pdev->dev, SVC_I3C_PM_TIMEOUT_MS); pm_runtime_use_autosuspend(&pdev->dev); @@ -1960,6 +2015,7 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { =20 static const struct of_device_id svc_i3c_master_of_match_tbl[] =3D { { .compatible =3D "silvaco,i3c-master-v1"}, + { .compatible =3D "nuvoton,npcm845-i3c", .data =3D &npcm845_drvdata }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl); --=20 2.34.1 From nobody Sun Feb 8 14:56:57 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 512771DC99C; Mon, 24 Feb 2025 08:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386394; cv=none; b=DocMfW/nhWCQrAO4Tdgoz5MZ1MNA4bke8nRvTrWWb3VhKDt0TPGEiWip9RzSYu2gCi6m0PRhE2m750wPXFi3wdIrQUIh8hSMD5U/+NcIFYHcRgsPM3Tl7P/Xkkriv3Tu63p7FjN+JzZxGvdunhPQklh4CD7NEYCqWBvQJ0ccpas= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386394; c=relaxed/simple; bh=qRH5fVxfQAsRwmC+LwhbI9RH7UEigg8d33gbtNKiX84=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=J36BfJO7WzZkHzD4pfIWAqytqXKXGzUVkbFLpNft59+9U37bruUwpiKPgOP6I+QaRl779t7u1RNauag3n7PD9OfRMFjG954jiA87Nak9EqnRm6qdSN2YnO0j9oQCBxVH/uRrgzwkMxIcCtDZv2DhueM+KGhrggG7iFwjkV/OMFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BSVJjGNd; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BSVJjGNd" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-220dc3831e3so78357255ad.0; Mon, 24 Feb 2025 00:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740386392; x=1740991192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8/zcMpskijGYRuDfk1c7h2QKxlF14yge6iyoocOzfaI=; b=BSVJjGNdP/IupYYxgOFMJD7+2XZxySbBjyjWyWXywe0B0bQqxPT8929xSXDwhhATah UeHXzgch0+6p5ChhmjwSduZAd/vEStvocND/ANAcNVEGIRLJkXDoyWtTHVCPKuV0okw2 w8cm7c1b6iZZMy7TLbIVVEtDI+B7ZUJJ5LI570I0A2WVitZcyFgEckH8csuh4fR3PaJW G2qvoRI298pPj6pPKRagusKD8IXLGPqZuSjxqB0HjmWlJ91BH6SoVcow9bPNTnCwvFNF 19OrVsVwzaj2G+Brl0MpWJotxs5qmyWqTwZdY/a2xrjblKlU0XvEyyF0FDcN8LSm7GsX QxCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740386392; x=1740991192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8/zcMpskijGYRuDfk1c7h2QKxlF14yge6iyoocOzfaI=; b=lvLmLqNzuRKY0CjCtmGZ7IT6GKS6+/Hm9cq0sOmtlFPaV1qsyMdn5DiI77rUaavLYT SSZgrk2ZYYnOk/VjC6p/cwbGPI6GC6vLtnmTVFD9pJ8W+IZVm4zT8Bd7Xnz9inv6InLb nOPjLGLHme2BxJ9FG5bYF+ppXmslgFHcr4urjYaNtNKKxjnxh9yg/2laCZKLQ0qwyT4f Chlyczw5o1lg+AcMQN1r+bnGKNVSDxFl99TICGBrr8gF+rezfkl7RMoUWHRvTh/Lewwa H/yl0BzoUhLJrl3yOrVXdsDlUP/2o45IeihQNwONtBn5GxHARXCUZUq33g+hZP8op5zR u0Dw== X-Forwarded-Encrypted: i=1; AJvYcCV9BmTvNagubwYMdwrn213VzBjPmydIlDUW66DF1zV+VV+ZM3A/9C25I7Ib07bE30LuLEBrepTgTv6w@vger.kernel.org X-Gm-Message-State: AOJu0Ywvejkbx4DFcm8VOEH+cQPS+ZAmgAXl2QrWMNqadk8h8Uryur0p fbfNCUZTEocISs8/jUgAGQ9rRk1JHvz0r6EC20TcfAPj0iIvkKVk X-Gm-Gg: ASbGnctJ7E6RYBZ6+jBH3Agp0gf+aReit8u688mMvmg9g/0CMQ4Ad7EKNG4DM+5NsUB G4DTQ55HmXA/H6wQNE8BV/2SBJd4IkM5BaVOsF72ghPVXoGyI2LVw6IOX7fyTtE9uDfl3Whde9k oqbVDAuRZ84xgTRoZi0pncXFhajQSAZ1cBU7ukFbZt8E7w9KKKVDjq0qF+eaHWZcDDEV+sSe8A1 71LMG3FZDbhwxaygpDCt2ZMIQ/2oCZn4K8PyqK97dkKaiBBGLgEj672XipXwnzXjdDOKx8erc/a O60CWe7PmY0jrOL0h2zw+wsVPuPmZREeJnsh X-Google-Smtp-Source: AGHT+IH0vF5JtrmGfyOiw3Uz/WiGXZ6m0VJD5EWTauPDEIQovZ+YQzc9KpIobnt648BkAXZ8UT2PeQ== X-Received: by 2002:a05:6a21:3991:b0:1e0:cc01:43da with SMTP id adf61e73a8af0-1eef3b2586amr18631154637.0.1740386392571; Mon, 24 Feb 2025 00:39:52 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7327590ff12sm14634793b3a.115.2025.02.24.00.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 00:39:52 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v4 3/5] i3c: master: svc: Fix npcm845 FIFO empty issue Date: Mon, 24 Feb 2025 16:39:06 +0800 Message-Id: <20250224083908.1880383-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250224083908.1880383-1-yschu@nuvoton.com> References: <20250224083908.1880383-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu I3C HW stalls the write transfer if the transmit FIFO becomes empty, when new data is written to FIFO, I3C HW resumes the transfer but the first transmitted data bit may have the wrong value. Fill the FIFO in advance to prevent FIFO from becoming empty. Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 44 ++++++++++++++++++++--------- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 8834f87a4767..07506ae0f914 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -942,7 +942,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_= master *master, u8 *addrs, unsigned int *count) { u64 prov_id[SVC_I3C_MAX_DEVS] =3D {}, nacking_prov_id =3D 0; - unsigned int dev_nb =3D 0, last_addr =3D 0; + unsigned int dev_nb =3D 0, last_addr =3D 0, dyn_addr; u32 reg; int ret, i; =20 @@ -985,6 +985,17 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c= _master *master, if (SVC_I3C_MSTATUS_RXPEND(reg)) { u8 data[6]; =20 + /* + * One slave sends its ID to request for address assignment, + * pre-filling the dynamic address can reduce SCL clock stalls + * and also fix the SVC_I3C_QUIRK_FIFO_EMPTY quirk. + */ + dyn_addr =3D i3c_master_get_free_addr(&master->base, last_addr + 1); + if (dyn_addr < 0) + return -ENOSPC; + + writel(dyn_addr, master->regs + SVC_I3C_MWDATAB); + /* * We only care about the 48-bit provisioned ID yet to * be sure a device does not nack an address twice. @@ -1063,21 +1074,16 @@ static int svc_i3c_master_do_daa_locked(struct svc_= i3c_master *master, if (ret) break; =20 - /* Give the slave device a suitable dynamic address */ - ret =3D i3c_master_get_free_addr(&master->base, last_addr + 1); - if (ret < 0) - break; - - addrs[dev_nb] =3D ret; + addrs[dev_nb] =3D dyn_addr; dev_dbg(master->dev, "DAA: device %d assigned to 0x%02x\n", dev_nb, addrs[dev_nb]); - - writel(addrs[dev_nb], master->regs + SVC_I3C_MWDATAB); last_addr =3D addrs[dev_nb++]; } =20 /* Need manual issue STOP except for Complete condition */ svc_i3c_master_emit_stop(master); + svc_i3c_master_flush_fifo(master); + return ret; } =20 @@ -1225,8 +1231,8 @@ static int svc_i3c_master_read(struct svc_i3c_master = *master, return offset; } =20 -static int svc_i3c_master_write(struct svc_i3c_master *master, - const u8 *out, unsigned int len) +static int svc_i3c_master_write(struct svc_i3c_master *master, const u8 *o= ut, + unsigned int len, bool last) { int offset =3D 0, ret; u32 mdctrl; @@ -1243,7 +1249,7 @@ static int svc_i3c_master_write(struct svc_i3c_master= *master, * The last byte to be sent over the bus must either have the * "end" bit set or be written in MWDATABE. */ - if (likely(offset < (len - 1))) + if (likely(offset < (len - 1)) || !last) writel(out[offset++], master->regs + SVC_I3C_MWDATAB); else writel(out[offset++], master->regs + SVC_I3C_MWDATABE); @@ -1274,6 +1280,17 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, SVC_I3C_MCTRL_RDTERM(*actual_len), master->regs + SVC_I3C_MCTRL); =20 + if (svc_has_quirk(master, SVC_I3C_QUIRK_FIFO_EMPTY) && !rnw && xfer_len)= { + u32 len =3D min_t(u32, xfer_len, SVC_I3C_FIFO_SIZE); + + ret =3D svc_i3c_master_write(master, out, len, + xfer_len <=3D SVC_I3C_FIFO_SIZE); + if (ret < 0) + goto emit_stop; + xfer_len -=3D len; + out +=3D len; + } + ret =3D readl_poll_timeout(master->regs + SVC_I3C_MSTATUS, reg, SVC_I3C_MSTATUS_MCTRLDONE(reg), 0, 1000); if (ret) @@ -1335,7 +1352,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, if (rnw) ret =3D svc_i3c_master_read(master, in, xfer_len); else - ret =3D svc_i3c_master_write(master, out, xfer_len); + ret =3D svc_i3c_master_write(master, out, xfer_len, true); if (ret < 0) goto emit_stop; =20 @@ -1362,6 +1379,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, emit_stop: svc_i3c_master_emit_stop(master); svc_i3c_master_clear_merrwarn(master); + svc_i3c_master_flush_fifo(master); =20 return ret; } --=20 2.34.1 From nobody Sun Feb 8 14:56:57 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B2720AF88; Mon, 24 Feb 2025 08:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386398; cv=none; b=N4b+m5RL4XDAP9SLf7jqY/IMDzf7wFj8gN/77+wJKxNt/ALmtftLONw2RmwnUZp7A+aAbfsszlJLaVkUfcTKSsyKgzhJ+bP0SkKSjIxPrwvNkUG3QVY191meCdsgUDLv+Jx5WcXg/qDHwMgmZMKUXrvc1TeGXRe2rEsVfkE3nl4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386398; c=relaxed/simple; bh=FNxmf5D7GN2aG4QMrxR+UXFyed8yl/FXkhCgriBGHag=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cRU5DgWcP4w6ZzaHSHUQf/YVfQdwPVBwn79hitTScvhofs7yzEIxuv9UTSmneQ+OvQvgKmhVrgW7EoNEhvYLDr64Q4pNXyrdVxxkBKC2e/7lrVaG3hR+YoYJOoOK5eb3m66OP1AQzk2WffL+w8Rc6kqcQ1sLIUlMAgcv3LSwn6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kt7ARhXm; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kt7ARhXm" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-220e989edb6so110241005ad.1; Mon, 24 Feb 2025 00:39:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740386396; x=1740991196; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KLJZ0UdIyJvoaYBSKuZ/YiS+j0w/Er7zxoHnMzji8nw=; b=Kt7ARhXmGhq9Y9x+ZWlv7cj5nzHw5cFgBe2UXC40neQbdlLTyu44aJWprjYBsKD66Y 03fXVnbm+gYTdxU0XiZEoq2BmcX04uF22/lupd4LjDafjZVGoNZ8dKI2825u6cl+WTxS bblsf9UfAPcBW9Uf6B5UlovdH5TDUrWlD15P40dT3IH4zDwQYk0AGQn5p4qR8EzXZkEb vPRnZ+NcN/tuzX7/6mnwwBQ9Fd+ikHDa1jxIzUHzYWfEcWL2l9GCI/rE5UEtslxJV9Cy fR36dEOW2S5MKK5il7aDJzFcq06qSBpznOP64STr/ZL/1SvDIDBWZb2EpsFfmG4kHjoE FxEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740386396; x=1740991196; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KLJZ0UdIyJvoaYBSKuZ/YiS+j0w/Er7zxoHnMzji8nw=; b=ebdD1Y2i0IGZX6jEBOjKEIGgu/tXhNXBjst2VDMjkbmEq49r9vaNL0krL8NydFi1Iq p8mTgYgqsdSPEB/AJGjABsvn3RBZu0LysE6cImF+dqlYOktON/eiCen31OLopONa23jc mGnGp+GFdZk/90jOntMbOQd7fhaXvauTX4s8Za7eDhSouOQRwtzb5pK/ZmJCHCyhQGwc QB7kBDGI1Uytk4ZnPh1R/AnMi2cDf1kBOpPNrgLcvlkuM63tZm3M/0yZwSzXJ/MupnBo CMJ7Xv6ol7d180GNoB6yASvp0c/IVG26SjDJXzoP0fwkLkcLhRmWPOCVVszMCOb/e4Bi lcVg== X-Forwarded-Encrypted: i=1; AJvYcCUPIg8gPJqlvo73UcqBbmz/eSnfj45KB8NotpSrhHsjfzV1SsZczJGlpThBo2mORx931uZfiGQtER4a@vger.kernel.org X-Gm-Message-State: AOJu0YynoRb65v0IkgtxO5n/bOqlTJLPBwKOEPwIMOIpxhubOs9yz+Dk v83KHw+dKSFLIkZ6O6xOCi070wQ4WP9cK2fTj4ZjD/lDjTGf49XftW+wqQ== X-Gm-Gg: ASbGncviTVcz6ojJhuJTB9RidOnggFlUGlJjgmAQgpml/XZ5lYQEUETi/6DrhTyWuN0 zoKb+y+3zq83bvIBhczwny3iKRiXkgbVhBhcf9LYAJ+YizCzYcKHrOv1HalSkM2ER/pBdZlVVqH 0dt/p80AzF+aSC6AoiAnzjo7ni/LpmE1drvufDaY3oHjqxoo9GXDHT/RgjjrDuiML5t+ohIKw4l Iqz7Wyp/msu6buJV4oCLVhE4foI4dl5hzPcu5jxkY6Qmitg8An9PBbWJYXaWAZJrRkI5nQlixuW n9gFXsg1bv07UBGm0HXovUnkTvCXQHcBAk6r X-Google-Smtp-Source: AGHT+IHmzcYOYpmi88RS8NVpMCYxjPv8F2R9zaGHSVBGMM+f8o94gQg8TxLc4zMuEg1JgPNRviBc3w== X-Received: by 2002:a05:6a20:a107:b0:1ee:e641:ca8 with SMTP id adf61e73a8af0-1eef3cd44cdmr22835172637.20.1740386395705; Mon, 24 Feb 2025 00:39:55 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7327590ff12sm14634793b3a.115.2025.02.24.00.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 00:39:55 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, Frank Li Subject: [PATCH v4 4/5] i3c: master: svc: Fix npcm845 invalid slvstart event Date: Mon, 24 Feb 2025 16:39:07 +0800 Message-Id: <20250224083908.1880383-5-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250224083908.1880383-1-yschu@nuvoton.com> References: <20250224083908.1880383-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu I3C HW may generate an invalid SlvStart event when emitting a STOP. If it is a true SlvStart, the MSTATUS state is SLVREQ. Check the MSTATUS state to ignore the false event. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 07506ae0f914..4eb4b8888725 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -59,6 +59,7 @@ #define SVC_I3C_MSTATUS 0x088 #define SVC_I3C_MSTATUS_STATE(x) FIELD_GET(GENMASK(2, 0), (x)) #define SVC_I3C_MSTATUS_STATE_DAA(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 5) +#define SVC_I3C_MSTATUS_STATE_SLVREQ(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D= 1) #define SVC_I3C_MSTATUS_STATE_IDLE(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 0) #define SVC_I3C_MSTATUS_BETWEEN(x) FIELD_GET(BIT(4), (x)) #define SVC_I3C_MSTATUS_NACKED(x) FIELD_GET(BIT(5), (x)) @@ -618,6 +619,11 @@ static irqreturn_t svc_i3c_master_irq_handler(int irq,= void *dev_id) /* Clear the interrupt status */ writel(SVC_I3C_MINT_SLVSTART, master->regs + SVC_I3C_MSTATUS); =20 + /* Ignore the false event */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FALSE_SLVSTART) && + !SVC_I3C_MSTATUS_STATE_SLVREQ(active)) + return IRQ_HANDLED; + svc_i3c_master_disable_interrupts(master); =20 /* Handle the interrupt in a non atomic context */ --=20 2.34.1 From nobody Sun Feb 8 14:56:57 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EB4420C023; Mon, 24 Feb 2025 08:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386401; cv=none; b=m7HD1q8gULXtoBeSxlQnHZena7ewFqItwjaR2MI0WZKvDZtbQ8sp2G7yr9do4TgUK+A2LfWH8nv2hJ2K2JUuII3G09MEQJeaEUwTp+490NHDkS4PxeZ2+P9IAz+mMPsQ7qvYfTxYbRCqc8UR/ZWXeitfjp5AQh5IjtGW9zg3vyE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740386401; c=relaxed/simple; bh=mzRbaEDFD4OYuJd1bGaOG/2PPYgmia+chNPV24BpCxU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MLsqbSC1mCPK7kBGWZM9EbS8O0AiiBNzisP2sOI86+a/jmR5p1t3XLnrn6GuMVHOZeSUm+MOeo4aLplK/SAV1sSePy18vPlvml4F5kCJ7LLpj8/BeHbgC/4jdojYrBDEHcWrqVLzdCnfDp9b3AVp8gzuM4mr7jB0lNaDd+9XcdU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lzHghznJ; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lzHghznJ" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-220f4dd756eso81355075ad.3; Mon, 24 Feb 2025 00:39:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740386399; x=1740991199; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p6cKbHN4qfM72wdTSv8VPMRBomnhPqBZxZM0i+T4Gyg=; b=lzHghznJmH+5oueoAsrKpXw3aCGXMy6b/bG9KjuqVvZdpfQSmofE6VN9KHTebOLyA+ 2q15wFCq+LHOYG70L2rXR2GvbXw2zGVlz58xwz2yrkGs5RA/hzz0/bUeSQ8y2f6odI/U NsrLWzksz65JLE6nbCWu8LHXBtu5S/vNq+qrhUS81gQaTDxhqAP9Jfv5npnE1N9uJNl5 zSY/KdrUbwRiPOv/SsSwH56cQ890uzm3aWXmaVFU/PY62sGZDVOoEbwfHRH/H4ZMbcJD 8D7KCWBAJYAboRLfi+7fpv7nvgSr+xj8mWgAoiGNz8PyF2Drdjk8pSJauYDocN2dVNdE cmGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740386399; x=1740991199; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p6cKbHN4qfM72wdTSv8VPMRBomnhPqBZxZM0i+T4Gyg=; b=IAeNwVcNEG39WgvLEhfm/vKirEId49CqSc7PCFfSRTC/brokBeRJR+UHf1dTLFhCz/ z8j5QlSwDmaKOmwb8r0InVPYkWRf49wnOR6CjFoQRGsHIV1lge8OlOkYxyvSGHA7gfqL Wy9hNf5zGWDfdiH/2vRu+o6xOyKmnRkRwpLl/mkW+qc020VRhyK3uzub0/9P5hWeuLU7 fMWi/6uJh0OsMqAHQJwq5ss6aEy43NbyISgo3uKLkaQKMmfU03nY9vBl2w8P2tmnngLJ c4m/iNYTKfMalKDKTtAGQkY8NQdRHIX/R8hJIuoRZAml8nuE5pUyDwJrdw9tXJYcDTYw DkEw== X-Forwarded-Encrypted: i=1; AJvYcCW9yvQ+9GVXttnXNE0Um0j/ofO56dfgsznLg+E2BFhO7UNjezhnaJk1/SphOIUwZIMRRQQXgj1r5Ivx@vger.kernel.org X-Gm-Message-State: AOJu0YwStnFfuOOv4gNK6mVNFYgGUR4t48d1VGYGHv3cRgBRWD23zxen eiaJ8Mqpp4tNvydeCzfkVrTUHUSLjsDoeS4TfxUUya7g4SC4ZIHPaYXdAQ== X-Gm-Gg: ASbGnct0AgLP531ueOjOkn+4wjnBe8gyvfy2+LYuGutlPzNIIw0qaiSK8khJ81FMzoH I5irGgrLYvTpOUgrffsb4VqFkSAEAuEUS86H+isknZLwR/cIcYvsG/DfDaXIO19BbBHsgzRq2cC ClGA1Hzd1OW4gT+G0qY+6tX6J2dNTgrieukoxcWjCUyh4vi2nv8FiTZTfetYVO9pnoQnebthaNf OtjVaN0QrYaS3QDpG79ofY4pK//mgPf2lZI1KDVw63vrFtCak43vmNZs+azbjdpCsxZnM124NAZ FO1HxR5e3BPDpXc6CSgG09V7gnwIX3c/+d7O X-Google-Smtp-Source: AGHT+IGdjRXZheSkV3s1DvGyCdmz3tYxghaKg5ParvRKOuHPh2Zz2Irrj+s+VtVp1uXaNHZqFpFNNA== X-Received: by 2002:a05:6a21:7011:b0:1ee:dd60:194f with SMTP id adf61e73a8af0-1eef3d66471mr21615752637.26.1740386398761; Mon, 24 Feb 2025 00:39:58 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7327590ff12sm14634793b3a.115.2025.02.24.00.39.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 00:39:58 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v4 5/5] i3c: master: svc: Fix npcm845 DAA process corruption Date: Mon, 24 Feb 2025 16:39:08 +0800 Message-Id: <20250224083908.1880383-6-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250224083908.1880383-1-yschu@nuvoton.com> References: <20250224083908.1880383-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stanley Chu When MCONFIG.SKEW=3D0 and MCONFIG.ODHPP=3D0, the ENTDAA transaction gets corrupted and results in a no repeated-start condition at the end of address assignment. Workaround: Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA process is completed, return MCONFIG.SKEW to its previous value. Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 4eb4b8888725..403d625e999e 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1162,7 +1162,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_c= ontroller *m) } =20 spin_lock_irqsave(&master->xferqueue.lock, flags); + + if (svc_has_quirk(master, SVC_I3C_QUIRK_DAA_CORRUPT)) + writel(master->mctrl_config | SVC_I3C_MCONFIG_SKEW(1), + master->regs + SVC_I3C_MCONFIG); + ret =3D svc_i3c_master_do_daa_locked(master, addrs, &dev_nb); + + if (svc_has_quirk(master, SVC_I3C_QUIRK_DAA_CORRUPT)) + writel(master->mctrl_config, master->regs + SVC_I3C_MCONFIG); + spin_unlock_irqrestore(&master->xferqueue.lock, flags); =20 svc_i3c_master_clear_merrwarn(master); --=20 2.34.1